Re: [PATCH net-next v3 3/4] bridge: push bridge setting ageing_time down to switchdev

On Sat, Oct 10, 2015 at 12:04 AM, Jiri Pirko wrote: > Sat, Oct 10, 2015 at 04:53:52AM CEST, sfel...@gmail.com wrote: >>On Thu, Oct 8, 2015 at 9:38 PM, Premkumar Jonnala >>wrote: >>> >>> -Original Message- From: sfel...@gmail.com [mailto:sfel...@gmail.com] Sent: Friday, Oct

Re: switchdev and VLAN ranges

On Sun, Oct 11, 2015 at 5:13 PM, Nikolay Aleksandrov wrote: > On 10/12/2015 12:41 AM, Vivien Didelot wrote: >> On Oct. Sunday 11 (41) 09:12 AM, Jiri Pirko wrote: >>> Sat, Oct 10, 2015 at 12:36:26PM CEST, niko...@cumulusnetworks.com wrote: On 10/10/2015 09:49 AM, Elad Raz wrote: > >> O

RE: [PATCH net-next v3 3/4] bridge: push bridge setting ageing_time down to switchdev

> 2015-10-10 15:41 GMT-07:00 Vivien Didelot > : > > On Oct. Saturday 10 (41) 11:09 PM, Jiri Pirko wrote: > >> Sat, Oct 10, 2015 at 05:56:19PM CEST, vivien.dide...@savoirfairelinux.com > wrote: > >> >On Oct. Saturday 10 (41) 09:04 AM, Jiri Pirko wrote: > >> >> Sat, Oct 10, 2015 at 04:53:52AM CEST, s

Re: [patch net-next] bridge: try switchdev op first in __vlan_vid_add/del

On Sat, Oct 10, 2015 at 9:03 AM, Vivien Didelot wrote: > On Oct. Friday 09 (41) 08:20 PM, Scott Feldman wrote: >> On Fri, Oct 9, 2015 at 3:44 PM, Vivien Didelot >> wrote: >> > Hi Jiri, >> > >> > On Oct. Friday 09 (41) 01:54 PM, Jiri Pirko wrote: >> >> From: Jiri Pirko >> >> >> >> Some drivers ne

Re: [PATCH net-next v2 1/2] hisilicon net: removes the once HANDEL_TX_MSG macro

On 2015/10/12 11:24, Joe Perches wrote: Hello Huang. On Mon, 2015-10-12 at 11:23 +0800, huangdaode wrote: This patch changes the code style to make the code more simple. also removes the once used HNADEL_TX_MSG macro, according to the HANDEL_TX_MSG typo review comments from Joe Perches. Sig

Re: [PATCH net-next v2 1/2] hisilicon net: removes the once HANDEL_TX_MSG macro

Hello Huang. On Mon, 2015-10-12 at 11:23 +0800, huangdaode wrote: > This patch changes the code style to make the code more simple. > also removes the once used HNADEL_TX_MSG macro, according to the HANDEL_TX_MSG typo > review comments from Joe Perches. > > Signed-off-by: huangdaode > Reviewed

[PATCH net-next v2 0/2] hisilicon net: fix some bugs in HNS drivers

This patchset fixes the two bugs in HNS driver, one is change the code style according to the review comments from Joe Perches, another is fixing the wrong mac_id judgement bug which is found during internal tests. change log: v2 1) remove first bug fix, which is fixed in another patch submitte

[PATCH net-next v2 1/2] hisilicon net: removes the once HANDEL_TX_MSG macro

This patch changes the code style to make the code more simple. also removes the once used HNADEL_TX_MSG macro, according to the review comments from Joe Perches. Signed-off-by: huangdaode Reviewed-by: Joe Perches --- drivers/net/ethernet/hisilicon/hns/hnae.c | 45 +++---

[PATCH net-next v2 2/2] hisilicon net: fix a bug on Hisilicon Network Subsystem

This patch fixes the wrong judgement of mac_id when get port num. Signed-off-by: huangdaode Signed-off-by: yankejian --- drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.c b/dri

Re: [PATCH net-next 0/2] net: fix some bugs in HNS drivers

On 2015/10/11 20:02, David Miller wrote: From: huangdaode Date: Thu, 8 Oct 2015 14:17:23 +0800 This patchset fixes the two bugs in HNS driver, one is for fixing the compilation warning bug on arm 32-bit platform, another is fixing the wrong mac port judgement bug which is found during internal

Re: [PATCH net-next] RDS-TCP: Reset tcp callbacks if re-using an outgoing socket in rds_tcp_accept_one()

On 10/11/15 1:49 PM, Sowmini Varadhan wrote: Consider the following "duelling syn" sequence between two peers A and B: A B SYN1 --> <-- SYN2 SYN2ACK --> Note that the SYN/ACK has already been sent out by

Re: [PATCH net-next] RDS: Invoke ->laddr_check() in rds_bind() for explicitly bound transports.

On 10/11/15 1:46 PM, Sowmini Varadhan wrote: The IP address passed to rds_bind() should be vetted by the transport's ->laddr_check() for a previously bound transport. This needs to be done to avoid cases where, for example, the application has asked for an IB transport, but the IP address passed

Re: [PATCH] net: nhs: fix 32-bit build warning

On 2015/10/12 4:13, Joe Perches wrote: On Tue, 2015-10-06 at 23:53 +0200, Arnd Bergmann wrote: diff --git a/drivers/net/ethernet/hisilicon/hns/hnae.c b/drivers/net/ethernet/hisilicon/hns/hnae.c [] @@ -448,12 +448,12 @@ static ssize_t handles_show(struct device *dev, s += sprin

Re: switchdev and VLAN ranges

On 10/12/2015 12:41 AM, Vivien Didelot wrote: > On Oct. Sunday 11 (41) 09:12 AM, Jiri Pirko wrote: >> Sat, Oct 10, 2015 at 12:36:26PM CEST, niko...@cumulusnetworks.com wrote: >>> On 10/10/2015 09:49 AM, Elad Raz wrote: > On Oct 10, 2015, at 2:30 AM, Vivien Didelot > wrote: >

Re: [PATCH] icmp: Fixed bug in raw sockets causing incorrect ICMP SNMP counter values

Please do not top-post on netdev and/or lkml On Mon, 2015-10-12 at 00:14 +0100, Ben Cox wrote: > Nice! > > That works in my head at least, Sorry about not seeing that fairly > glaring memory issue there. No problem, this is why we review patches ;) > > Are you sure " skb->transport_header +=

Re: [PATCH] icmp: Fixed bug in raw sockets causing incorrect ICMP SNMP counter values

Nice! That works in my head at least, Sorry about not seeing that fairly glaring memory issue there. Are you sure " skb->transport_header += iphlen; " won't have a knock on affect when it's given to NF_HOOK ( as in, would a potential userspace program get something it does not expect anymore ) ?

Re: [PATCH] icmp: Fixed bug in raw sockets causing incorrect ICMP SNMP counter values

On Sun, 2015-10-11 at 15:44 -0700, Eric Dumazet wrote: > On Sun, 2015-10-11 at 15:43 -0700, Eric Dumazet wrote: > > > But your code reads 21th byte. > > BTW, nice catch ! Maybe the following one. 1) We properly set transport header 2) We use icmp_hdr() helper. diff --git a/net/ipv4/raw.c b/net

Re: [PATCH] icmp: Fixed bug in raw sockets causing incorrect ICMP SNMP counter values

On Sun, 2015-10-11 at 15:43 -0700, Eric Dumazet wrote: > But your code reads 21th byte. BTW, nice catch ! Your patch only need a small addition. Thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo in

Re: [PATCH] icmp: Fixed bug in raw sockets causing incorrect ICMP SNMP counter values

On Sun, 2015-10-11 at 23:17 +0100, Ben Cox wrote: > Forgive me for possibly being a little stupid here (This is my first > patch to Linux so I am slightly over my head) > > Is this issue not addressed above the file where the following check is done? > > if (iphlen > length) > goto error_free

Re: switchdev and VLAN ranges

On Oct. Sunday 11 (41) 09:12 AM, Jiri Pirko wrote: > Sat, Oct 10, 2015 at 12:36:26PM CEST, niko...@cumulusnetworks.com wrote: > >On 10/10/2015 09:49 AM, Elad Raz wrote: > >> > >>> On Oct 10, 2015, at 2:30 AM, Vivien Didelot > >>> wrote: > >>> > >>> I have two concerns in mind: > >>> > >>> a) if

Re: [PATCH net-next v3 3/4] bridge: push bridge setting ageing_time down to switchdev

On Oct. Saturday 10 (41) 05:07 PM, Florian Fainelli wrote: > 2015-10-10 15:41 GMT-07:00 Vivien Didelot > : > > On Oct. Saturday 10 (41) 11:09 PM, Jiri Pirko wrote: > >> Sat, Oct 10, 2015 at 05:56:19PM CEST, vivien.dide...@savoirfairelinux.com > >> wrote: > >> >On Oct. Saturday 10 (41) 09:04 AM, J

Re: [PATCH] icmp: Fixed bug in raw sockets causing incorrect ICMP SNMP counter values

Forgive me for possibly being a little stupid here (This is my first patch to Linux so I am slightly over my head) Is this issue not addressed above the file where the following check is done? if (iphlen > length) goto error_free; On Sun, Oct 11, 2015 at 11:10 PM, Eric Dumazet wrote: > On

[PATCH net-next 0/4] net: dsa: mv88e6xxx: fix hardware bridging

DSA and its drivers currently hook the NETDEV_CHANGEUPPER net_device event in order to configure the VLAN map of every port. This VLAN map is a feature of these switch chips to hardcode and restrict which output ports a given input port can egress frames to. A Linux bridge is a simple untagged VL

Re: [PATCH] icmp: Fixed bug in raw sockets causing incorrect ICMP SNMP counter values

On Sun, 2015-10-11 at 20:55 +, Ben Cartwright-Cox wrote: > Sending ICMP packets with raw sockets ends up in the SNMP counters > logging the type as the first byte of the IPv4 header rather than > the ICMP header (in nearly all cases this is seen as "OutType69". > This is fixed by adding the IP

[PATCH net-next 3/4] net: dsa: do not warn unsupported bridge ops

A DSA driver may not provide the port_join_bridge and port_leave_bridge functions, so don't warn in such case. Signed-off-by: Vivien Didelot --- net/dsa/slave.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/dsa/slave.c b/net/dsa/slave.c index bb2bd3b..43d7342 100644 ---

[PATCH net-next 4/4] net: dsa: mv88e6xxx: fix hardware bridging

Playing with the VLAN map of every port to implement "hardware bridging" in the 88E6352 driver was a hack until full 802.1Q was supported. Indeed with 802.1Q port mode "Disabled" or "Fallback", this feature is used to restrict which output ports an input port can egress frames to. A Linux bridge

[PATCH net-next 2/4] net: dsa: mv88e6xxx: do not support per-port FID

Since we configure a switch chip through a Linux bridge, and a bridge is implemented as a VLAN, there is no need for per-port FID anymore. This patch gets rid of this and simplifies the driver code since we can now directly map all 4095 FIDs available to all VLANs. Signed-off-by: Vivien Didelot

[PATCH net-next 1/4] net: dsa: mv88e6xxx: bridges do not need an FID

With 88E6352 and similar switch chips, each port has a map to restrict which output port this input port can egress frames to. The current driver code implements hardware bridging using this feature, and assigns to a bridge group the FID of its first member. Now that 802.1Q is fully implemented i

Re: [PATCH net-next v3 2/2] mpls: flow-based multipath selection

On 10/11/15, 12:43 PM, Eric W. Biederman wrote: > Roopa Prabhu writes: > >> From: Robert Shearman >> >> Change the selection of a multipath route to use a flow-based >> hash. This more suitable for traffic sensitive to reordering within a >> flow (e.g. TCP, L2VPN) and whilst still allowing a good

[PATCH] icmp: Fixed bug in raw sockets causing incorrect ICMP SNMP counter values

Sending ICMP packets with raw sockets ends up in the SNMP counters logging the type as the first byte of the IPv4 header rather than the ICMP header (in nearly all cases this is seen as "OutType69". This is fixed by adding the IP Header Length to the casting into a icmphdr struct. Signed-off-by: B

Re: [PATCH net-next v3 1/2] mpls: multipath route support

On 10/11/15, 1:41 PM, Eric W. Biederman wrote: > Roopa Prabhu writes: > >> From: Roopa Prabhu >> >> This patch adds support for MPLS multipath routes. >> >> Includes following changes to support multipath: >> - splits struct mpls_route into 'struct mpls_route + struct mpls_nh' >> >> - 'struct mpl

[PATCH iproute2 v2] bridge: add batch command support

From: Wilson Kok This patch adds support to batch bridge commands. Follows ip batch code. Signed-off-by: Wilson Kok Signed-off-by: Roopa Prabhu Acked-by: Christophe Gouault --- v2 - change tab to space in usage as pointed out by Christophe Gouault bridge/bridge.c | 59 +++

[PATCH net-next] RDS-TCP: Reset tcp callbacks if re-using an outgoing socket in rds_tcp_accept_one()

Consider the following "duelling syn" sequence between two peers A and B: A B SYN1 --> <-- SYN2 SYN2ACK --> Note that the SYN/ACK has already been sent out by TCP before rds_tcp_accept_one() gets invoke

Re: [PATCH net-next v3 1/2] mpls: multipath route support

Roopa Prabhu writes: > From: Roopa Prabhu > > This patch adds support for MPLS multipath routes. > > Includes following changes to support multipath: > - splits struct mpls_route into 'struct mpls_route + struct mpls_nh' > > - 'struct mpls_nh' represents a mpls nexthop label forwarding entry > >

[PATCH net-next] RDS: Invoke ->laddr_check() in rds_bind() for explicitly bound transports.

The IP address passed to rds_bind() should be vetted by the transport's ->laddr_check() for a previously bound transport. This needs to be done to avoid cases where, for example, the application has asked for an IB transport, but the IP address passed to bind is only usable on ethernet interfaces.

Re: [PATCH] net: nhs: fix 32-bit build warning

On Tue, 2015-10-06 at 23:53 +0200, Arnd Bergmann wrote: > diff --git a/drivers/net/ethernet/hisilicon/hns/hnae.c > b/drivers/net/ethernet/hisilicon/hns/hnae.c [] > @@ -448,12 +448,12 @@ static ssize_t handles_show(struct device *dev, > s += sprintf(buf + s, "handle %d (eport_id=%u fr

Re: [PATCH net-next v3 2/2] mpls: flow-based multipath selection

Roopa Prabhu writes: > From: Robert Shearman > > Change the selection of a multipath route to use a flow-based > hash. This more suitable for traffic sensitive to reordering within a > flow (e.g. TCP, L2VPN) and whilst still allowing a good distribution > of traffic given enough flows. > > Selec

Re: [PATCH net-next v3 0/2] mpls: multipath support

Roopa Prabhu writes: > From: Roopa Prabhu > > This patch adds support for MPLS multipath routes. > > Includes following changes to support multipath: > - splits struct mpls_route into 'struct mpls_route + struct mpls_nh'. > > - struct mpls_nh represents a mpls nexthop label forwarding entry > >

e1000_driver_checkpatch_remove_errors_warnings_checks

From daf0a1f5100c21f10b9e08829433258267748c44 Mon Sep 17 00:00:00 2001 From: Janusz Wolak Date: Tue, 6 Oct 2015 21:03:19 +0200 Subject: [PATCH 1/6] Remove checkpatch warnings and checks. Signed-off-by: Janusz Wolak --- drivers/net/ethernet/intel/e1000/e1000_main.c | 145 ++

[PATCH net-next v3 2/2] mpls: flow-based multipath selection

From: Robert Shearman Change the selection of a multipath route to use a flow-based hash. This more suitable for traffic sensitive to reordering within a flow (e.g. TCP, L2VPN) and whilst still allowing a good distribution of traffic given enough flows. Selection of the path for a multipath rout

[PATCH net-next v3 0/2] mpls: multipath support

From: Roopa Prabhu This patch adds support for MPLS multipath routes. Includes following changes to support multipath: - splits struct mpls_route into 'struct mpls_route + struct mpls_nh'. - struct mpls_nh represents a mpls nexthop label forwarding entry - Adds support to parse/fill RTA_MULTIP

[PATCH net-next v3 1/2] mpls: multipath route support

From: Roopa Prabhu This patch adds support for MPLS multipath routes. Includes following changes to support multipath: - splits struct mpls_route into 'struct mpls_route + struct mpls_nh' - 'struct mpls_nh' represents a mpls nexthop label forwarding entry - moves mpls route and nexthop structu

Re: [PATCH net-next] net: Fix vti use case with oif in dst lookups for IPv6

On 10/11/15 8:24 AM, Hajime Tazaki wrote: I've faced this issue since the following patch was applied. commit 741a11d9e4103a8e1c590ef1280143fe654e4e33 Author: David Ahern Date: Mon Sep 28 10:12:13 2015 -0700 net: ipv6: Add RT6_LOOKUP_F_IFACE flag if oif is set I still couldn't spot wh

[PATCH nf-next 0/7] coding style improvements for netfilter

This series of patches improves the coding style of the netfilter-ipv6 code by addressing some issues detected by checkpatch. The changes were previously submitted as part of a larger monolithic patch but on advice from Pablo, these are being re-sent in smaller, more structured batches. Ian Mo

[PATCH nf-next 1/7] netfilter-ipv6: label placement

Whitespace cleansing: Labels should not be indented. No changes detected by objdiff. Signed-off-by: Ian Morris --- net/ipv6/netfilter/ip6_tables.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/ipv6/netfilter/ip6_tables.c b/net/ipv6/netfilter/ip6_tables.c index 80e3bd7.

[PATCH nf-next 3/7] netfilter-ipv6: code indentation

Use tabs instead of spaces to indent code. No changes detected by objdiff. Signed-off-by: Ian Morris --- net/ipv6/netfilter/ip6_tables.c | 4 ++-- net/ipv6/netfilter/ip6t_SYNPROXY.c| 2 +- net/ipv6/netfilter/nft_chain_route_ipv6.c | 6 +++--- 3 files changed, 6 insertions(+),

[PATCH nf-next 4/7] netfilter-ipv6: whitespace around operators

This patch cleanses whitespace around arithmetical operators. No changes detected by objdiff. Signed-off-by: Ian Morris --- net/ipv6/netfilter/nf_conntrack_proto_icmpv6.c | 4 ++-- net/ipv6/netfilter/nf_conntrack_reasm.c| 2 +- net/ipv6/netfilter/nf_reject_ipv6.c| 4 ++-- 3

[PATCH nf-next 6/7] netfilter-ipv6: improve if statements

Correct whitespace layout of if statements. No changes detected by objdiff. Signed-off-by: Ian Morris --- net/ipv6/netfilter/ip6_tables.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/ipv6/netfilter/ip6_tables.c b/net/ipv6/netfilter/ip6_tables.c index 80f014a..bd66

[PATCH nf-next 7/7] netfilter-ipv6: pointer cast layout

Correct whitespace layout of a pointer casting. No changes detected by objdiff. Signed-off-by: Ian Morris --- net/ipv6/netfilter/nf_conntrack_reasm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/ipv6/netfilter/nf_conntrack_reasm.c b/net/ipv6/netfilter/nf_conntrack_re

[PATCH nf-next 5/7] netfilter-ipv6: ternary operator layout

Correct whitespace layout of ternary operators in the netfilter-ipv6 code. No changes detected by objdiff. Signed-off-by: Ian Morris --- net/ipv6/netfilter/ip6_tables.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/ipv6/netfilter/ip6_tables.c b/net/ipv6/netfilter/i

[PATCH nf-next 2/7] netfilter-ipv6: function definition layout

Use tabs instead of spaces to indent second line of parameters in function definitions. No changes detected by objdiff. Signed-off-by: Ian Morris --- net/ipv6/netfilter/ip6_tables.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/net/ipv6/netfilter/ip6_tables.c b/net/i

[patch net-next 3/7] switchdev: remove pointers from switchdev objects

From: Jiri Pirko When object is used in deferred work, we cannot use pointers in switchdev object structures because the memory they point at may be already used by someone else. So rather do local copy of the value. Signed-off-by: Jiri Pirko --- drivers/net/ethernet/rocker/rocker.c | 6 +++--

[patch net-next 4/7] switchdev: introduce possibility to defer obj_add/del

From: Jiri Pirko Similar to the attr usecase, the caller knows if he is holding RTNL and is in atomic section. So let the called to decide the correct call variant. This allows drivers to sleep inside their ops and wait for hw to get the operation status. Then the status is propagated into switc

[patch net-next 1/7] switchdev: introduce switchdev workqueue

From: Jiri Pirko This is going to be used for deferred operations. Signed-off-by: Jiri Pirko --- include/net/switchdev.h | 5 + net/switchdev/switchdev.c | 19 +++ 2 files changed, 24 insertions(+) diff --git a/include/net/switchdev.h b/include/net/switchdev.h index 892

[patch net-next 6/7] rocker: remove nowait from switchdev callbacks.

From: Jiri Pirko No need to avoid sleeping in switchdev callbacks now, as the switchdev core allows it. Signed-off-by: Jiri Pirko --- drivers/net/ethernet/rocker/rocker.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/rocker/rocker.c b/drivers/

[patch net-next 5/7] bridge: defer switchdev fdb del call in fdb_del_external_learn

From: Jiri Pirko Since spinlock is held here, defer the switchdev operation. Signed-off-by: Jiri Pirko --- net/bridge/br_fdb.c | 5 - net/bridge/br_if.c | 3 +++ 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/net/bridge/br_fdb.c b/net/bridge/br_fdb.c index b3801fd..8b723b4

[patch net-next 0/7] switchdev: change locking

From: Jiri Pirko This is something which I'm currently struggling with. Callers of attr_set and obj_add/del often hold not only RTNL, but also spinlock (bridge). So in that case, the driver implementing the op cannot sleep. The way rocker is dealing with this now is just to invoke driver operati

[patch net-next 7/7] switchdev: assert rtnl mutex when going over lower netdevs

From: Jiri Pirko netdev_for_each_lower_dev has to be called with rtnl mutex held. So better enforce it in switchdev functions. Signed-off-by: Jiri Pirko --- net/switchdev/switchdev.c | 15 +++ 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/net/switchdev/switchdev.c

[patch net-next 2/7] switchdev: allow caller to explicitly request attr_set as deferred

From: Jiri Pirko Caller should know if he can call attr_set directly (when holding RTNL) or if he has to defer the att_set processing for later. This also allows drivers to sleep inside attr_set and report operation status back to switchdev core. Switchdev core then warns if status is not ok, in

Re: [kbuild-all] [PATCH net-next] net: Lookup actual route when oif is VRF device

Hi David, On Mon, Oct 05, 2015 at 12:10:12PM -0600, David Ahern wrote: > On 10/5/15 12:01 PM, kbuild test robot wrote: > >Hi David, > > > >[auto build test ERROR on v4.3-rc4 -- if it's inappropriate base, please > >ignore] > > > > net-next patches can *not* be applied to Linus' tree. If you are

Re: [PATCH net-next] net: Fix vti use case with oif in dst lookups for IPv6

At Sun, 11 Oct 2015 07:31:32 -0600, David Ahern wrote: > >> The attached patch applied to Linus' tree works for me. Currently the > >> above change is not in his tree, so I added it to this patch. Once you > >> confirm that it works for you I'll create the delta-patch for net and > >> send out. >

Re: [PATCH net-next] bridge: vlan: enforce no pvid flag in vlan ranges

Sun, Oct 11, 2015 at 12:49:56PM CEST, ra...@blackwall.org wrote: >From: Nikolay Aleksandrov > >Currently it's possible for someone to send a vlan range to the kernel >with the pvid flag set which will result in the pvid bouncing from a >vlan to vlan and isn't correct, it also introduces problems f

Re: BUG: Mellanox crash with iommu=soft and swiotlb=force

Hi, On Tue, Sep 29, 2015 at 12:59:35AM +0300, Or Gerlitz wrote: > On Tue, Sep 29, 2015 at 12:04 AM, Christoffer Dall > wrote: > > Hi, > > > > In doing some performance experiments I found that using a 10G Mellanox > > MX354A Dual port FDR CX3 device on a server running Apache and running > > ab a

Re: [PATCH v4 1/3] net: unix: fix use-after-free in unix_dgram_poll()

Hannes Frederic Sowa writes: > Jason Baron writes: > >> The unix_dgram_poll() routine calls sock_poll_wait() not only for the wait >> queue associated with the socket s that we are poll'ing against, but also >> calls >> sock_poll_wait() for a remote peer socket p, if it is connected. Thus, >> if

Re: [PATCH net-next] net: Fix vti use case with oif in dst lookups for IPv6

On 10/11/15 7:22 AM, Hajime Tazaki wrote: At Fri, 9 Oct 2015 11:27:36 -0600, David Ahern wrote: [1 ] On 10/9/15 1:17 AM, Steffen Klassert wrote: diff --git a/net/ipv6/xfrm6_policy.c b/net/ipv6/xfrm6_policy.c index 30caa289c5db..5cedfda4b241 100644 --- a/net/ipv6/xfrm6_policy.c +++ b/net/ipv6

Re: [PATCH net-next] net: Fix vti use case with oif in dst lookups for IPv6

At Fri, 9 Oct 2015 11:27:36 -0600, David Ahern wrote: > > [1 ] > On 10/9/15 1:17 AM, Steffen Klassert wrote: > >>> diff --git a/net/ipv6/xfrm6_policy.c b/net/ipv6/xfrm6_policy.c > >>> index 30caa289c5db..5cedfda4b241 100644 > >>> --- a/net/ipv6/xfrm6_policy.c > >>> +++ b/net/ipv6/xfrm6_policy.c

Re: simplify configfs attributes V2

On Fri, Oct 09, 2015 at 04:37:51PM -0500, Felipe Balbi wrote: > For reference, I'm fine if you guys take all patches through FS > tree. Another option is waiting for dependencies to be merged in v4.4, > and the gadget changes merge in v4.5, whatever works. I'd prefer to take them all in one go. I

Re: [PATCH 02/23] usb-gadget: use per-attribute show and store methods

On Fri, Oct 09, 2015 at 04:19:57PM -0500, Felipe Balbi wrote: > > Signed-off-by: Christoph Hellwig > > Reviewed-by: Andrzej Pietrasiewicz > > I suppose this depends on other fs/configfs changes ? The whole series should be applied in order, but doesn't have any other dependencies. -- To unsubsc

Re: [PATCH 18/23] spear13xx_pcie_gadget: use per-attribute show and store methods

On Fri, Oct 09, 2015 at 04:05:17PM -0500, Felipe Balbi wrote: > Pratyush Anand writes: > > > On Sat, Oct 3, 2015 at 7:02 PM, Christoph Hellwig wrote: > >> Signed-off-by: Christoph Hellwig > > > > Acked-by: Pratyush Anand > > I don't seem to have the actual patch, care to resend? The whole se

Re: [PATCH net-next 4/5] bridge: vlan: fix possible null ptr derefs on port init and deinit

Wed, Sep 30, 2015 at 09:16:54PM IDT, ra...@blackwall.org wrote: >From: Nikolay Aleksandrov > >When a new port is being added we need to make vlgrp available after >rhashtable has been initialized and when removing a port we need to >flush the vlans and free the resources after we're sure noone can

Re: [PATCH 1/2] net/fsl_pq_mdio: check TBI address for consistency with mapped range

Gerlando Falauto wrote: Change-Id: If1e7d8931f440ea9259726c36d3df797dda016fb You need to remove these from patches that are emailed, and fix the pointer type comparison. Otherwise, Acked-by: Timur Tabi -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a m

Re: [PATCH net-next 4/5] bridge: vlan: fix possible null ptr derefs on port init and deinit

On 10/11/2015 02:42 PM, Nikolay Aleksandrov wrote: > On 10/11/2015 02:21 PM, Ido Schimmel wrote: >> Wed, Sep 30, 2015 at 09:16:54PM IDT, ra...@blackwall.org wrote: >>> From: Nikolay Aleksandrov >>> >>> When a new port is being added we need to make vlgrp available after >>> rhashtable has been ini

Re: [PATCH net-next 4/5] bridge: vlan: fix possible null ptr derefs on port init and deinit

On 10/11/2015 02:21 PM, Ido Schimmel wrote: > Wed, Sep 30, 2015 at 09:16:54PM IDT, ra...@blackwall.org wrote: >> From: Nikolay Aleksandrov >> >> When a new port is being added we need to make vlgrp available after >> rhashtable has been initialized and when removing a port we need to >> flush the

Re: [PATCH net-next] tcp: fix RFS vs lockless listeners

From: Eric Dumazet Date: Thu, 08 Oct 2015 11:16:48 -0700 > From: Eric Dumazet > > Before recent TCP listener patches, we were updating listener > sk->sk_rxhash before the cloning of master socket. > > children sk_rxhash was therefore correct after the normal 3WHS. > > But with lockless listen

Re: [PATCH net] ipv6: gre: setup default multicast routes over PtP links

From: Hannes Frederic Sowa Date: Thu, 8 Oct 2015 18:19:39 +0200 > GRE point-to-point interfaces should also support ipv6 multicast. Setting > up default multicast routes on interface creation was forgotten. Add it. > > Bugzilla: > Cc: Julien

Re: [PATCH net] ipv6: drop frames with attached skb->sk in forwarding

From: Hannes Frederic Sowa Date: Thu, 8 Oct 2015 18:19:53 +0200 > This is a clone of commit 2ab957492d13b ("ip_forward: Drop frames with > attached skb->sk") for ipv6. > > This commit has exactly the same reasons as the above mentioned commit, > namely to prevent panics during netfilter reload

Re: [PATCH net-next v2 0/3] net: dsa: push switchdev prepare phase in FDB ops

From: Vivien Didelot Date: Thu, 8 Oct 2015 11:35:11 -0400 > This patchset pushes the switchdev prepare phase for the FDB add and del > operations down to the DSA drivers. Currently only mv88e6xxx is affected. > > Since the dump requires a bit of refactoring in the driver, it'll come in a > futu

Re: [PATCH net-next] net: encx24j600: Fix typos in Kconfig

From: j...@ringle.org Date: Thu, 8 Oct 2015 11:10:19 -0400 > From: Jon Ringle > > Signed-off-by: Jon Ringle Applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.or

Re: pull request: bluetooth-next 2015-10-08

From: Johan Hedberg Date: Thu, 8 Oct 2015 17:00:58 +0300 > Here's another set of Bluetooth & 802.15.4 patches for the 4.4 kernel. > > 802.15.4: > - Many improvements & fixes to the mrf24j40 driver > - Fixes and cleanups to nl802154, mac802154 & ieee802154 code > > Bluetooth: > - New chipset

[PATCH] qlcnic: constify qlcnic_mbx_ops structure

The only instance of a qlcnic_mbx_ops structure is never modified. Thus the declaration of the structure and all references to the structure type can be made const. In the definition of the qlcnic_mailbox structure, the ops field is no longer lined up with the other fields. This was left as is,

Re: [patch net 0/2] mlxsw: couple of fixes

From: Jiri Pirko Date: Thu, 8 Oct 2015 15:17:36 +0200 > Just a couple of small fixes. Series applied, thanks Jiri. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-

Re: [PATCH net-next v3] BNX2: fix a Null Pointer for stats_blk

From: Weidong Wang Date: Thu, 8 Oct 2015 18:03:47 +0800 > we have two processes to do: > P1#: ifconfig eth0 down; which will call bnx2_close, then will > , and set Null to stats_blk > P2#: ifconfig eth0; which will call bnx2_get_stats64, it will > use stats_blk. > In one case: > --P1#--

Re: [PATCH net-next] net: synack packets can be attached to request sockets

From: Eric Dumazet Date: Thu, 08 Oct 2015 05:01:55 -0700 > From: Eric Dumazet > > selinux needs few changes to accommodate fact that SYNACK messages > can be attached to a request socket, lacking sk_security pointer > > (Only syncookies are still attached to a TCP_LISTEN socket) > > Adds a ne

Re: [PATCH net-next 0/2] net: fix some bugs in HNS drivers

From: huangdaode Date: Thu, 8 Oct 2015 14:17:23 +0800 > This patchset fixes the two bugs in HNS driver, one is for fixing the > compilation warning bug on arm 32-bit platform, another is fixing the wrong > mac port judgement bug which is found during internal tests. This patch series does not ap

Re: [PATCH v4 0/3] net: unix: fix use-after-free

From: Jason Baron Date: Fri, 9 Oct 2015 00:15:59 -0400 > These patches are against mainline, I can re-base to net-next, please > let me know. > > They have been tested against: https://lkml.org/lkml/2015/9/13/195, > which causes the use-after-free quite quickly and here: > https://lkml.org/lkml

Re: [Patch net] sch_hhf: fix return value of hhf_drop()

From: Cong Wang Date: Wed, 7 Oct 2015 16:47:32 -0700 > Similar to commit c0afd9ce4d6a ("fq_codel: fix return value of > fq_codel_drop()") > ->drop() is supposed to return the number of bytes it dropped, > but hhf_drop () returns the id of the bucket where it drops > a packet from. > > Cc: Jama

Re: [PATCH net-next 0/4 v2] net: VRF support in IPv6 stack

Please minimize the crazy pointer casting in this series. All of these casts between ipv4/ipv6 route objects and dsts are completely unnecessary. Prefer to maintain an rt/rt6 in local variables, and then when you need the dst say &rt6->dst, or to get the device say rt6->dst.dev or similar. Than

Re: [PATCH net-next v4] net: ipv6: Make address flushing on ifdown optional

From: David Ahern Date: Wed, 7 Oct 2015 08:17:39 -0700 > +static void fixup_managed_addr(struct inet6_dev *idev, struct inet6_ifaddr > *ifp) > +{ > + if (!ifp->rt) > + ifp->rt = addrconf_dst_alloc(idev, &ifp->addr, false); This potentially leaves an error pointer dangling in if

Re: [PATCH v2 net-next] bpf: fix cb access in socket filter programs

From: Alexei Starovoitov Date: Wed, 7 Oct 2015 10:55:41 -0700 > eBPF socket filter programs may see junk in 'u32 cb[5]' area, > since it could have been used by protocol layers earlier. > > For socket filter programs used in af_packet we need to clean > 20 bytes of skb->cb area if it could be u

Re: [PATCH v4 net-next 01/10] qed: Add module with basic common support

From: Yuval Mintz Date: Sat, 10 Oct 2015 14:18:18 + > So far we've worked on stabalizing it on 64-bit LE endian. > I can easily understand why we'd want to relax this restriction later on > [and sooner rather than later], but what would you gain be gained by > compile-fixing for platforms on

[PATCH net-next] bridge: vlan: enforce no pvid flag in vlan ranges

From: Nikolay Aleksandrov Currently it's possible for someone to send a vlan range to the kernel with the pvid flag set which will result in the pvid bouncing from a vlan to vlan and isn't correct, it also introduces problems for hardware where it doesn't make sense having more than 1 pvid. iprou

Re: switchdev and VLAN ranges

Sat, Oct 10, 2015 at 12:36:26PM CEST, niko...@cumulusnetworks.com wrote: >On 10/10/2015 09:49 AM, Elad Raz wrote: >> >>> On Oct 10, 2015, at 2:30 AM, Vivien Didelot >>> wrote: >>> >>> I have two concerns in mind: >>> >>> a) if we imagine that drivers like Rocker allocate memory in the prepare >>