[PATCH net-next] net: validate_xmit_skb() changes

2016-04-12 Thread Eric Dumazet
From: Eric Dumazet skbs given to validate_xmit_skb() should not have a next pointer anymore. Also if a packet is dropped, increment dev->tx_dropped __dev_queue_xmit() no longer has to change tx_dropped in this case. Signed-off-by: Eric Dumazet ---

Re: TCP reaching to maximum throughput after a long time

2016-04-12 Thread Eric Dumazet
On Tue, 2016-04-12 at 20:08 -0700, Yuchung Cheng wrote: > based on the prev thread I propose we disable hystart ack-train. It is > brittle under various circumstances. We've disabled that at Google for > years. Right, but because we also use sch_fq packet scheduler and pacing ;)

Re: TCP reaching to maximum throughput after a long time

2016-04-12 Thread Yuchung Cheng
On Tue, Apr 12, 2016 at 2:40 PM, Ben Greear wrote: > On 04/12/2016 01:29 PM, Eric Dumazet wrote: >> >> On Tue, 2016-04-12 at 13:23 -0700, Ben Greear wrote: >> >>> It worked well enough for years that I didn't even know other algorithms >>> were >>> available. It was

Re: [PATCH RFC] net: decrease the length of backlog queue immediately after it's detached from sk

2016-04-12 Thread Eric Dumazet
On Tue, 2016-04-12 at 20:31 +0800, Yang Yingliang wrote: > I traced the cost cycles of handling backlog packets in > __release_sock(). > 16.97 ms to handling about 12MB backlog packets, of which 13.66ms to do > sk_data_ready. > The speed of handling packets in TCP is 5.65Gb/s which is smaller

Re: [PATCH V3 0/8] net: mediatek: make the driver pass stress tests

2016-04-12 Thread David Miller
From: John Crispin Date: Fri, 8 Apr 2016 00:54:03 +0200 > While testing the driver we managed to get the TX path to stall and fail > to recover. When dual MAC support was added to the driver, the whole queue > stop/wake code was not properly adapted. There was also a

Re: [PATCH 0/8] Netfilter updates for net-next

2016-04-12 Thread David Miller
From: Pablo Neira Ayuso Date: Wed, 13 Apr 2016 01:02:38 +0200 > The following patchset contains the first batch of Netfilter updates for > your net-next tree. ... Pulled, thanks Pablo.

Re: Configuring ethernet link fails with No such device

2016-04-12 Thread Stefan Agner
[added Tom Gundersen as he seemed to have worked on udev's net link built-in] On 2016-04-12 08:44, David Miller wrote: > From: Bob Ham > Date: Tue, 12 Apr 2016 09:58:12 +0100 > >> On Mon, 2016-04-11 at 15:46 -0700, Stefan Agner wrote: >> >>> Or in other words: Is this a

Re: [PATCH net-next] ibmvnic: Defer tx completion processing using a wait queue

2016-04-12 Thread David Miller
From: John Allen Date: Tue, 12 Apr 2016 16:00:23 -0500 > On 04/12/2016 03:12 PM, Eric Dumazet wrote: >> On Tue, 2016-04-12 at 14:38 -0500, John Allen wrote: >>> Moves tx completion processing out of interrupt context, deferring work >>> using a wait queue. With this

[PATCH v2 net-next 0/7] DSA refactoring: set 1

2016-04-12 Thread Andrew Lunn
There has been a long running effort to refractor DSA probing to make the switches true linux devices. Here are a small collection of patches moving in this direction. Most have been seen before. We take a little step forward by passing the dsa device point to the driver, thus allowing it to

[PATCH v2 net-next 6/7] dsa: Rename phys_port_mask to enabled_port_mask

2016-04-12 Thread Andrew Lunn
The phys in phys_port_mask suggests this mask is about PHYs. In fact, it means physical ports. Rename to enabled_port_mask, indicating external enabled ports of the switch, which is hopefully less confusing. Signed-off-by: Andrew Lunn Tested-by: Vivien Didelot

[PATCH v2 net-next 1/7] net: dsa: Pass the dsa device to the switch drivers

2016-04-12 Thread Andrew Lunn
By passing a device structure to the switch devices, it allows them to use devm_* methods for resource management. Signed-off-by: Andrew Lunn Acked-by: Florian Fainelli Tested-by: Vivien Didelot ---

[PATCH v2 net-next 4/7] net: dsa: Keep the mii bus and address in the private structure

2016-04-12 Thread Andrew Lunn
Rather than looking up the mii bus and address every time, do it once at probe, and keep it in the private structure. Centralise this probe code in mv88e6xxx. Signed-off-by: Andrew Lunn Acked-by: Florian Fainelli Tested-by: Vivien Didelot

[PATCH v2 net-next 2/7] net: dsa: Have the switch driver allocate there own private memory

2016-04-12 Thread Andrew Lunn
Now the switch devices have a dev pointer, make use of it for allocating the drivers private data structures using a devm_kzalloc(). Signed-off-by: Andrew Lunn Acked-by: Florian Fainelli Tested-by: Vivien Didelot ---

[PATCH v2 net-next 5/7] net: dsa: Rename DSA probe function.

2016-04-12 Thread Andrew Lunn
Rename the function called from the DSA to perform a probe for the switch. This makes the normal _probe() name available for a standard Linux device driver probe function. Signed-off-by: Andrew Lunn Tested-by: Vivien Didelot ---

[PATCH v2 net-next 7/7] dsa: mv88e6xxx: Use bus in mv88e6xxx_lookup_name()

2016-04-12 Thread Andrew Lunn
mv88e6xxx_lookup_name() returns the model name of a switch at a given address on an MII bus. Using mii_bus to identify the bus rather than the host device is more logical, so change the parameter. Signed-off-by: Andrew Lunn Tested-by: Vivien Didelot

[PATCH v2 net-next 3/7] net: dsa: Remove allocation of driver private memory

2016-04-12 Thread Andrew Lunn
The drivers now allocate their own memory for private usage. Remove the allocation from the core code. Signed-off-by: Andrew Lunn Acked-by: Florian Fainelli Tested-by: Vivien Didelot --- include/net/dsa.h | 1 -

[PATCH 6/8] netfilter: ipv6: unnecessary to check whether ip6_route_output() returns NULL

2016-04-12 Thread Pablo Neira Ayuso
From: Haishuang Yan ip6_route_output() never returns NULL, so it is not appropriate to check if the return value is NULL. Signed-off-by: Haishuang Yan Signed-off-by: Pablo Neira Ayuso ---

[PATCH 7/8] netfilter: conntrack: de-inline nf_conntrack_eventmask_report

2016-04-12 Thread Pablo Neira Ayuso
From: Florian Westphal Way too large; move it to nf_conntrack_ecache.c. Reduces total object size by 1216 byte on my machine. Signed-off-by: Florian Westphal Signed-off-by: Pablo Neira Ayuso --- include/net/netfilter/nf_conntrack_ecache.h

[PATCH 4/8] netfilter: bridge: nf queue verdict to use NFQA_VLAN and NFQA_L2HDR

2016-04-12 Thread Pablo Neira Ayuso
From: Stephane Bryant This makes nf queues use NFQA_VLAN and NFQA_L2HDR in verdict to modify the original skb Signed-off-by: Stephane Bryant Signed-off-by: Pablo Neira Ayuso --- net/netfilter/nfnetlink_queue.c |

[PATCH 2/8] netfilter: bridge: add nf_afinfo to enable queuing to userspace

2016-04-12 Thread Pablo Neira Ayuso
From: Stephane Bryant This just adds and registers a nf_afinfo for the ethernet bridge, which enables queuing to userspace for the AF_BRIDGE family. No checksum computation is done. Signed-off-by: Stephane Bryant Signed-off-by: Pablo

[PATCH 5/8] netfilter: ip6t_SYNPROXY: remove magic number for hop_limit

2016-04-12 Thread Pablo Neira Ayuso
From: Liping Zhang Replace '64' with the per-net ipv6_devconf_all's hop_limit when building the ipv6 header. Signed-off-by: Liping Zhang Signed-off-by: Pablo Neira Ayuso --- net/ipv6/netfilter/ip6t_SYNPROXY.c | 56

[PATCH 8/8] netfilter: conntrack: move expectation event helper to ecache.c

2016-04-12 Thread Pablo Neira Ayuso
From: Florian Westphal Not performance critical, it is only invoked when an expectation is added/destroyed. While at it, kill unused nf_ct_expect_event() wrapper. Signed-off-by: Florian Westphal Signed-off-by: Pablo Neira Ayuso ---

[PATCH 3/8] netfilter: bridge: pass L2 header and VLAN as netlink attributes in queues to userspace

2016-04-12 Thread Pablo Neira Ayuso
From: Stephane Bryant - This creates 2 netlink attribute NFQA_VLAN and NFQA_L2HDR. - These are filled up for the PF_BRIDGE family on the way to userspace. - NFQA_VLAN is a nested attribute, with the NFQA_VLAN_PROTO and the NFQA_VLAN_TCI carrying the corresponding

[PATCH 1/8] netfilter: nf_conntrack: Uses pr_fmt() for logging.

2016-04-12 Thread Pablo Neira Ayuso
From: Weongyo Jeong Uses pr_fmt() macro for debugging messages of nf_conntrack module. Signed-off-by: Weongyo Jeong Signed-off-by: Pablo Neira Ayuso --- net/netfilter/nf_conntrack_core.c | 15 --- 1 file

[PATCH 0/8] Netfilter updates for net-next

2016-04-12 Thread Pablo Neira Ayuso
Hi David, The following patchset contains the first batch of Netfilter updates for your net-next tree. 1) Define pr_fmt() in nf_conntrack, from Weongyo Jeong. 2) Define and register netfilter's afinfo for the bridge family, this comes in preparation for native nfqueue's bridge for nft,

Re: Issue with ping source address display

2016-04-12 Thread 吉藤英明
Hi, 2016-04-13 2:52 GMT+09:00 Daniele Orlandi : > > Hello, > > More than one year ago I posted the following message but it hasn't > received a reply, now I've been stung by a similar issue, you may want > to investigate: > > > I noticed that when ping receives ICMP messages

[PATCH iproute2] ss: 64bit inode numbers

2016-04-12 Thread Eric Dumazet
From: Eric Dumazet Lets prepare for a possibility to have 64bit inode numbers for sockets, even if the kernel currently enforces 32bit numbers. Presumably, if both kernel and userland are 64bit (no 32bit emulation), kernel could switch to 64bit inode numbers soon.

Re: [PATCH] mwifiex: fix possible NULL dereference

2016-04-12 Thread Andy Shevchenko
On Tue, Apr 12, 2016 at 8:43 PM, Rustad, Mark D wrote: > Andy Shevchenko wrote: > >> On Mon, Apr 11, 2016 at 6:27 PM, Sudip Mukherjee >> wrote: >>> >>> From: Sudip Mukherjee >>> >>>

[PATCH net-next 0/5] BPF updates

2016-04-12 Thread Daniel Borkmann
This series adds a new verifier argument type called ARG_PTR_TO_RAW_STACK and converts related helpers to make use of it. Basic idea is that we can save init of stack memory when the helper function is guaranteed to fully fill out the passed buffer in every path. Series also adds test cases and

[PATCH net-next 5/5] bpf, samples: add test cases for raw stack

2016-04-12 Thread Daniel Borkmann
This adds test cases mostly around ARG_PTR_TO_RAW_STACK to check the verifier behaviour. [...] #84 raw_stack: no skb_load_bytes OK #85 raw_stack: skb_load_bytes, no init OK #86 raw_stack: skb_load_bytes, init OK #87 raw_stack: skb_load_bytes, spilled regs around bounds OK #88

[PATCH net-next 1/5] bpf, verifier: add bpf_call_arg_meta for passing meta data

2016-04-12 Thread Daniel Borkmann
Currently, when the verifier checks calls in check_call() function, we call check_func_arg() for all 5 arguments e.g. to make sure expected types are correct. In some cases, we collect meta data (here: map pointer) to perform additional checks such as checking stack boundary on key/value sizes for

[PATCH net-next 3/5] bpf: convert relevant helper args to ARG_PTR_TO_RAW_STACK

2016-04-12 Thread Daniel Borkmann
This patch converts all helpers that can use ARG_PTR_TO_RAW_STACK as argument type. For tc programs this is bpf_skb_load_bytes(), bpf_skb_get_tunnel_key(), bpf_skb_get_tunnel_opt(). For tracing, this optimizes bpf_get_current_comm() and bpf_probe_read(). The check in bpf_skb_load_bytes() for

[PATCH net-next 4/5] bpf, samples: don't zero data when not needed

2016-04-12 Thread Daniel Borkmann
Remove the zero initialization in the sample programs where appropriate. Note that this is an optimization which is now possible, old programs still doing the zero initialization are just fine as well. Also, make sure we don't have padding issues when we don't memset() the entire struct anymore.

[PATCH net-next 2/5] bpf, verifier: add ARG_PTR_TO_RAW_STACK type

2016-04-12 Thread Daniel Borkmann
When passing buffers from eBPF stack space into a helper function, we have ARG_PTR_TO_STACK argument type for helpers available. The verifier makes sure that such buffers are initialized, within boundaries, etc. However, the downside with this is that we have a couple of helper functions such as

Re: [PATCH] sctp: add support for RPS and RFS

2016-04-12 Thread Tom Herbert
On Tue, Apr 12, 2016 at 2:57 PM, Marcelo Ricardo Leitner wrote: > On Tue, Apr 12, 2016 at 02:50:45PM -0700, Tom Herbert wrote: >> On Tue, Apr 12, 2016 at 2:11 PM, Marcelo Ricardo Leitner >> wrote: >> > This patch adds what's missing to

Re: [PATCH] sctp: add support for RPS and RFS

2016-04-12 Thread Marcelo Ricardo Leitner
On Tue, Apr 12, 2016 at 02:50:45PM -0700, Tom Herbert wrote: > On Tue, Apr 12, 2016 at 2:11 PM, Marcelo Ricardo Leitner > wrote: > > This patch adds what's missing to properly support RPS and RFS on SCTP, > > as some of it is already implemented in common calls. > > > >

Re: [PATCH] sctp: add support for RPS and RFS

2016-04-12 Thread Tom Herbert
On Tue, Apr 12, 2016 at 2:11 PM, Marcelo Ricardo Leitner wrote: > This patch adds what's missing to properly support RPS and RFS on SCTP, > as some of it is already implemented in common calls. > > Having support for RPS and RFS allows better scaling specially because >

Re: TCP reaching to maximum throughput after a long time

2016-04-12 Thread Ben Greear
On 04/12/2016 01:29 PM, Eric Dumazet wrote: On Tue, 2016-04-12 at 13:23 -0700, Ben Greear wrote: It worked well enough for years that I didn't even know other algorithms were available. It was broken around 4.0 time, and I reported it to the list, and no one seemed to really care enough to do

[PATCH] sctp: add support for RPS and RFS

2016-04-12 Thread Marcelo Ricardo Leitner
This patch adds what's missing to properly support RPS and RFS on SCTP, as some of it is already implemented in common calls. Having support for RPS and RFS allows better scaling specially because not all NICs support hashing SCTP headers. Save the hash right when we dequeue a skb from inqueue

Re: [PATCH net-next] ibmvnic: Defer tx completion processing using a wait queue

2016-04-12 Thread John Allen
On 04/12/2016 03:12 PM, Eric Dumazet wrote: > On Tue, 2016-04-12 at 14:38 -0500, John Allen wrote: >> Moves tx completion processing out of interrupt context, deferring work >> using a wait queue. With this work now deferred, we must account for the >> possibility that skbs can be sent faster than

Re: TCP reaching to maximum throughput after a long time

2016-04-12 Thread Eric Dumazet
On Tue, 2016-04-12 at 13:23 -0700, Ben Greear wrote: > It worked well enough for years that I didn't even know other algorithms were > available. It was broken around 4.0 time, and I reported it to the list, > and no one seemed to really care enough to do anything about it. I changed > to reno

Re: Issue with ping source address display

2016-04-12 Thread Julian Anastasov
Hello, On Tue, 12 Apr 2016, Daniele Orlandi wrote: > On 12/04/2016 21:38, Julian Anastasov wrote: > > > > What is the kernel version? > > Much time passed and I don't remember, however the latest test with IPv6 > ping was made on this host: > > root@monitor:~# uname -a > Linux

Re: TCP reaching to maximum throughput after a long time

2016-04-12 Thread Ben Greear
On 04/12/2016 01:17 PM, Eric Dumazet wrote: On Tue, 2016-04-12 at 13:11 -0700, Ben Greear wrote: On 04/12/2016 12:31 PM, Machani, Yaniv wrote: On Tue, Apr 12, 2016 at 18:04:52, Ben Greear wrote: On 04/12/2016 07:52 AM, Eric Dumazet wrote: On Tue, 2016-04-12 at 12:17 +, Machani, Yaniv

Re: TCP reaching to maximum throughput after a long time

2016-04-12 Thread Eric Dumazet
On Tue, 2016-04-12 at 13:11 -0700, Ben Greear wrote: > On 04/12/2016 12:31 PM, Machani, Yaniv wrote: > > On Tue, Apr 12, 2016 at 18:04:52, Ben Greear wrote: > >> On 04/12/2016 07:52 AM, Eric Dumazet wrote: > >>> On Tue, 2016-04-12 at 12:17 +, Machani, Yaniv wrote: > > >> > >> If you are

Re: [PATCH net-next] ibmvnic: Defer tx completion processing using a wait queue

2016-04-12 Thread Eric Dumazet
On Tue, 2016-04-12 at 14:38 -0500, John Allen wrote: > Moves tx completion processing out of interrupt context, deferring work > using a wait queue. With this work now deferred, we must account for the > possibility that skbs can be sent faster than we can process completion > requests in which

Re: TCP reaching to maximum throughput after a long time

2016-04-12 Thread Ben Greear
On 04/12/2016 12:31 PM, Machani, Yaniv wrote: On Tue, Apr 12, 2016 at 18:04:52, Ben Greear wrote: On 04/12/2016 07:52 AM, Eric Dumazet wrote: On Tue, 2016-04-12 at 12:17 +, Machani, Yaniv wrote: If you are using 'Cubic' TCP congestion control, then please try something different. It

Re: [PATCH v3 1/2] sctp: compress bit-wide flags to a bitfield on sctp_sock

2016-04-12 Thread Neil Horman
On Fri, Apr 08, 2016 at 04:41:27PM -0300, Marcelo Ricardo Leitner wrote: > It wastes space and gets worse as we add new flags, so convert bit-wide > flags to a bitfield. > > Currently it already saves 4 bytes in sctp_sock, which are left as holes > in it for now. The whole struct needs packing,

Re: Issue with ping source address display

2016-04-12 Thread Daniele Orlandi
On 12/04/2016 21:38, Julian Anastasov wrote: > > Hello, > > On Tue, 12 Apr 2016, Daniele Orlandi wrote: > >> I noticed that when ping receives ICMP messages from different sources >> the first IP address is always used and displayed: >> >> >> vihai@seviolab:~$ ping -V >> ping utility,

Re: Issue with ping source address display

2016-04-12 Thread Julian Anastasov
Hello, On Tue, 12 Apr 2016, Daniele Orlandi wrote: > I noticed that when ping receives ICMP messages from different sources > the first IP address is always used and displayed: > > > vihai@seviolab:~$ ping -V > ping utility, iputils-s20121221 What is the kernel version?

[PATCH net-next] ibmvnic: Defer tx completion processing using a wait queue

2016-04-12 Thread John Allen
Moves tx completion processing out of interrupt context, deferring work using a wait queue. With this work now deferred, we must account for the possibility that skbs can be sent faster than we can process completion requests in which case the tx buffer will overflow. If the tx buffer is full,

RE: TCP reaching to maximum throughput after a long time

2016-04-12 Thread Machani, Yaniv
On Tue, Apr 12, 2016 at 18:04:52, Ben Greear wrote: > On 04/12/2016 07:52 AM, Eric Dumazet wrote: > > On Tue, 2016-04-12 at 12:17 +, Machani, Yaniv wrote: >>> > > If you are using 'Cubic' TCP congestion control, then please try > something different. > It was broken last I checked, at least

Issue with ping source address display

2016-04-12 Thread Daniele Orlandi
Hello, More than one year ago I posted the following message but it hasn't received a reply, now I've been stung by a similar issue, you may want to investigate: I noticed that when ping receives ICMP messages from different sources the first IP address is always used and displayed:

Re: [PATCH] mwifiex: fix possible NULL dereference

2016-04-12 Thread Rustad, Mark D
Andy Shevchenko wrote: On Mon, Apr 11, 2016 at 6:27 PM, Sudip Mukherjee wrote: From: Sudip Mukherjee We have a check for card just after dereferencing it. So if it is NULL we have already dereferenced

[PATCH net] bpf/verifier: reject invalid LD_ABS | BPF_DW instruction

2016-04-12 Thread Alexei Starovoitov
verifier must check for reserved size bits in instruction opcode and reject BPF_LD | BPF_ABS | BPF_DW and BPF_LD | BPF_IND | BPF_DW instructions, otherwise interpreter will WARN_RATELIMIT on them during execution. Fixes: ddd872bc3098 ("bpf: verifier: add checks for BPF_ABS | BPF_IND

Re: [Lsf] [Lsf-pc] [LSF/MM TOPIC] Generic page-pool recycle facility?

2016-04-12 Thread Alexei Starovoitov
On Tue, Apr 12, 2016 at 08:16:49AM +0200, Jesper Dangaard Brouer wrote: > > On Mon, 11 Apr 2016 15:21:26 -0700 > Alexei Starovoitov wrote: > > > On Mon, Apr 11, 2016 at 11:41:57PM +0200, Jesper Dangaard Brouer wrote: > > > > > > On Sun, 10 Apr 2016 21:45:47 +0300

[PATCH net 2/2] soreuseport: test mixed v4/v6 sockets

2016-04-12 Thread Craig Gallek
From: Craig Gallek Test to validate the behavior of SO_REUSEPORT sockets that are created with both AF_INET and AF_INET6. See the commit prior to this for a description of this behavior. Signed-off-by: Craig Gallek ---

[PATCH net 0/2] Fixes for SO_REUSEPORT and mixed v4/v6 sockets

2016-04-12 Thread Craig Gallek
From: Craig Gallek Recent changes to the datastructures associated with SO_REUSEPORT broke an existing behavior when equivalent SO_REUSEPORT sockets are created using both AF_INET and AF_INET6. This patch series restores the previous behavior and includes a test to validate

[PATCH net 1/2] soreuseport: fix ordering for mixed v4/v6 sockets

2016-04-12 Thread Craig Gallek
From: Craig Gallek With the SO_REUSEPORT socket option, it is possible to create sockets in the AF_INET and AF_INET6 domains which are bound to the same IPv4 address. This is only possible with SO_REUSEPORT and when not using IPV6_V6ONLY on the AF_INET6 sockets. Prior to the

Re: TCP reaching to maximum throughput after a long time

2016-04-12 Thread Yuchung Cheng
On Tue, Apr 12, 2016 at 7:52 AM, Eric Dumazet wrote: > > On Tue, 2016-04-12 at 12:17 +, Machani, Yaniv wrote: > > Hi, > > After updating from Kernel 3.14 to Kernel 4.4 we have seen a TCP > > performance degradation over Wi-Fi. > > In 3.14 kernel, TCP got to its max

Re: Inter-VRF routing on a single machine

2016-04-12 Thread David Ahern
On 4/12/16 4:09 AM, Darwin Dingel wrote: Hi All, Have anyone tried the following setup on a single machine with 2 TCP sockets on different VRF's and succeeded? - client_socket on VRF1 - server_socket on VRF2 - ip rules and iproutes for inter-VRF set up - client_socket sends TCP connect to

[PATCH 4.6 fix] bgmac: fix MAC soft-reset bit for corerev > 4

2016-04-12 Thread Rafał Miłecki
From: Felix Fietkau Only core revisions older than 4 use BGMAC_CMDCFG_SR_REV0. This mainly fixes support for BCM4708A0KF SoCs with Ethernet core rev 5 (it means only some devices as most of BCM4708A0KF-s got core rev 4). This was tested for regressions on BCM47094 which doesn't

Re: [PATCH net v3] net: sched: do not requeue a NULL skb

2016-04-12 Thread Eric Dumazet
On Tue, 2016-04-12 at 08:45 +0200, Lars Persson wrote: > A failure in validate_xmit_skb_list() triggered an unconditional call > to dev_requeue_skb with skb=NULL. This slowly grows the queue > discipline's qlen count until all traffic through the queue stops. > > Fixes: 55a93b3ea780 ("qdisc:

[RFC PATCH net-next] sunvnet: Add ethtool support for netdev stastics

2016-04-12 Thread Atish Patra
Currently, sunvnet does not support statstics display via sysfs entry using ethtool. This patch enables the basic support in sunvnet that displays the all the netdev stastics for the specific interface using ethtool. Other sunvnet statstics and support for ldmvsw will be added later.

Re: [RFC v5 0/5] Add virtio transport for AF_VSOCK

2016-04-12 Thread Ian Campbell
Some how Stefan's reply disapeared from my INBOX (although I did see it) so replying here. On Mon, 2016-04-11 at 15:54 +0300, Michael S. Tsirkin wrote: > On Mon, Apr 11, 2016 at 11:45:48AM +0100, Stefan Hajnoczi wrote: > > > > On Fri, Apr 08, 2016 at 04:35:05PM +0100, Ian Campbell wrote: > > >

Re: pull request: bluetooth-next 2016-04-12

2016-04-12 Thread David Miller
From: Johan Hedberg Date: Tue, 12 Apr 2016 11:08:15 +0300 > Here's a set of Bluetooth & 802.15.4 patches intended for the 4.7 kernel: > > - Fix for race condition in vhci driver > - Memory leak fix for ieee802154/adf7242 driver > - Improvements to deal with

Re: [PATCH net-next 00/11] FUJITSU Extended Socket driver version 1.1

2016-04-12 Thread David Miller
From: "Izumi, Taku" Date: Tue, 12 Apr 2016 08:35:09 + > But I'd like to keep some debugfs facility for status information > and some specific stats other thatn net_stats. We have a facility for arbitrary driver stats, remove this debugfs crap please. I'm not

Re: Configuring ethernet link fails with No such device

2016-04-12 Thread David Miller
From: Bob Ham Date: Tue, 12 Apr 2016 09:58:12 +0100 > On Mon, 2016-04-11 at 15:46 -0700, Stefan Agner wrote: > >> Or in other words: Is this a Kernel or systemd issue? > > From what I recall, both; an issue with the FEC driver, and issues in > systemd/udevd's handling of

Re: [Lsf] [Lsf-pc] [LSF/MM TOPIC] Generic page-pool recycle facility?

2016-04-12 Thread Alexander Duyck
On Mon, Apr 11, 2016 at 11:28 PM, Jesper Dangaard Brouer wrote: > > On Mon, 11 Apr 2016 15:02:51 -0700 Alexander Duyck > wrote: > >> Have you taken a look at possibly trying to optimize the DMA pool API >> to work with pages? It sounds like it is

[PATCH 2/3] rxrpc: The RXRPC_ACCEPT control message should not have an address

2016-04-12 Thread David Howells
When sendmsg() is called with the RXRPC_ACCEPT control message, sendmsg() shouldn't also be given an address in msg_name. Signed-off-by: David Howells --- net/rxrpc/ar-output.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/net/rxrpc/ar-output.c

[PATCH 3/3] rxrpc: Use the listen() system call to move to listening state

2016-04-12 Thread David Howells
Use the listen() system call to move to listening state and to set the socket backlog queue size. A limit is placed on the maximum queue size by way of: /proc/sys/net/rxrpc/max_backlog Signed-off-by: David Howells --- fs/afs/rxrpc.c | 34

[PATCH 0/3] RxRPC: 2nd rewrite part 2

2016-04-12 Thread David Howells
/kernel/git/dhowells/linux-fs.git/log/?h=rxrpc-rewrite Tagged thusly: git://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git rxrpc-rewrite-20160412 This is based on net-next/master David --- David Howells (3): rxrpc: Don't permit use of connect() op and simplify

[PATCH 1/3] rxrpc: Don't permit use of connect() op and simplify sendmsg() op

2016-04-12 Thread David Howells
Simplify the RxRPC user interface and remove the use of connect() to direct client calls. It is redundant given that sendmsg() can be given the target address and calls to multiple targets are permitted from a client socket and also from a service socket. Simplify sendmsg() also. If we can't

Re: TCP reaching to maximum throughput after a long time

2016-04-12 Thread Ben Greear
On 04/12/2016 07:52 AM, Eric Dumazet wrote: On Tue, 2016-04-12 at 12:17 +, Machani, Yaniv wrote: Hi, After updating from Kernel 3.14 to Kernel 4.4 we have seen a TCP performance degradation over Wi-Fi. In 3.14 kernel, TCP got to its max throughout after less than a second, while in the

Re: [PATCH RFT 2/2] macb: kill PHY reset code

2016-04-12 Thread Nicolas Ferre
Le 12/04/2016 15:54, Sergei Shtylyov a écrit : > Hello. > > On 4/12/2016 12:22 PM, Nicolas Ferre wrote: > With the 'phylib' now being aware of the "reset-gpios" PHY node property, there should be no need to frob the PHY reset in this driver anymore... Signed-off-by:

Re: TCP reaching to maximum throughput after a long time

2016-04-12 Thread Eric Dumazet
On Tue, 2016-04-12 at 12:17 +, Machani, Yaniv wrote: > Hi, > After updating from Kernel 3.14 to Kernel 4.4 we have seen a TCP performance > degradation over Wi-Fi. > In 3.14 kernel, TCP got to its max throughout after less than a second, while > in the 4.4 it is taking ~20-30 seconds. > UDP

VLAN aux info for AF_PACKET available only with ETH_P_ALL

2016-04-12 Thread Peter Palúch
Greetings, I am running vanilla Linux kernel v4.4.6. When using AF_PACKET sockets with PACKET_AUXDATA socket option to access the VLAN TCI information of received frames, I have noticed that the VLAN information in struct tpacket_auxdata, namely, - tp_vlan_tci - tp_vlan_tpid -

Re: [PATCH RFT 2/2] macb: kill PHY reset code

2016-04-12 Thread Nicolas Ferre
Le 12/04/2016 15:40, Andrew Lunn a écrit : > On Tue, Apr 12, 2016 at 11:22:10AM +0200, Nicolas Ferre wrote: >> Le 11/04/2016 04:28, Andrew Lunn a écrit : >>> On Sat, Apr 09, 2016 at 01:25:03AM +0300, Sergei Shtylyov wrote: With the 'phylib' now being aware of the "reset-gpios" PHY node

[PATCH net,stable] cdc_mbim: apply "NDP to end" quirk to all Huawei devices

2016-04-12 Thread Bjørn Mork
We now have a positive report of another Huawei device needing this quirk: The ME906s-158 (12d1:15c1). This is an m.2 form factor modem with no obvious relationship to the E3372 (12d1:157d) we already have a quirk entry for. This is reason enough to believe the quirk might be necessary for any

Re: [PATCH] mwifiex: fix possible NULL dereference

2016-04-12 Thread Andy Shevchenko
On Mon, Apr 11, 2016 at 6:27 PM, Sudip Mukherjee wrote: > From: Sudip Mukherjee > > We have a check for card just after dereferencing it. So if it is NULL > we have already dereferenced it before its check. Lets dereference it > after

Re: [RFC v5 0/5] Add virtio transport for AF_VSOCK

2016-04-12 Thread Stefan Hajnoczi
On Mon, Apr 11, 2016 at 03:54:08PM +0300, Michael S. Tsirkin wrote: > On Mon, Apr 11, 2016 at 11:45:48AM +0100, Stefan Hajnoczi wrote: > > On Fri, Apr 08, 2016 at 04:35:05PM +0100, Ian Campbell wrote: > > > On Fri, 2016-04-01 at 15:23 +0100, Stefan Hajnoczi wrote: > > > > This series is based on

Re: Unhandled fault during system suspend in sky2_shutdown

2016-04-12 Thread Sudeep Holla
On 11/04/16 19:24, Stephen Hemminger wrote: On Mon, 11 Apr 2016 17:24:37 +0100 Sudeep Holla wrote: [...] diff --git i/drivers/net/ethernet/marvell/sky2.c w/drivers/net/ethernet/marvell/sky2.c index ec0a22119e09..0ff0434e32fc 100644 ---

Re: [RFC PATCH 0/2] selinux: avoid nf hooks overhead when not needed

2016-04-12 Thread Casey Schaufler
On 4/12/2016 1:52 AM, Paolo Abeni wrote: > On Thu, 2016-04-07 at 14:55 -0400, Paul Moore wrote: >> On Thursday, April 07, 2016 01:45:32 AM Florian Westphal wrote: >>> Paul Moore wrote: On Wed, Apr 6, 2016 at 6:14 PM, Florian Westphal wrote: >

Re: AF_VSOCK status

2016-04-12 Thread Stefan Hajnoczi
On Mon, Apr 11, 2016 at 06:53:05PM +0700, Antoine Martin wrote: > > There are a few existing ways to achieve that without involving > > virtio-vsock: vhost-user or ivshmem. > Yes, I've looked at those and they seem a bit overkill for what we > want to achieve. We don't want sharing with multiple

Re: [PATCH RFT 2/2] macb: kill PHY reset code

2016-04-12 Thread Sergei Shtylyov
Hello. On 4/12/2016 12:22 PM, Nicolas Ferre wrote: With the 'phylib' now being aware of the "reset-gpios" PHY node property, there should be no need to frob the PHY reset in this driver anymore... Signed-off-by: Sergei Shtylyov ---

Re: [PATCH RFT 2/2] macb: kill PHY reset code

2016-04-12 Thread Andrew Lunn
On Tue, Apr 12, 2016 at 11:22:10AM +0200, Nicolas Ferre wrote: > Le 11/04/2016 04:28, Andrew Lunn a écrit : > > On Sat, Apr 09, 2016 at 01:25:03AM +0300, Sergei Shtylyov wrote: > >> With the 'phylib' now being aware of the "reset-gpios" PHY node > >> property, > >> there should be no need to

Re: GMII2RGMII Converter support in macb driver

2016-04-12 Thread Phil Reid
On 12/04/2016 9:21 PM, Nicolas Ferre wrote: Le 12/04/2016 15:03, Appana Durga Kedareswara Rao a écrit : Hi All, There is a Xilinx custom IP for GMII to RGMII conversion data sheet here

RE: GMII2RGMII Converter support in macb driver

2016-04-12 Thread Appana Durga Kedareswara Rao
Hi Nicolas Ferre, > -Original Message- > From: Nicolas Ferre [mailto:nicolas.fe...@atmel.com] > Sent: Tuesday, April 12, 2016 6:52 PM > To: Appana Durga Kedareswara Rao ; > netdev@vger.kernel.org; Michal Simek > Cc: Punnaiah Choudary Kalluri

Re: [PATCH net-next v2 1/2] rtnetlink: add new RTM_GETSTATS message to dump link stats

2016-04-12 Thread Thomas Graf
On 04/11/16 at 08:53pm, roopa wrote: > Top level stats attributes can be netdev or global attributes: We can include > string "LINK" in > the names of all stats belonging to a netdev to make it easier to recognize > the netdev stats (example): > IFLA_STATS_LINK64, (netdev) >

Re: GMII2RGMII Converter support in macb driver

2016-04-12 Thread Nicolas Ferre
Le 12/04/2016 15:03, Appana Durga Kedareswara Rao a écrit : > Hi All, > > > > > >There is a Xilinx custom IP for GMII to RGMII conversion > data sheet here > (http://www.xilinx.com/support/documentation/ip_documentation/gmii_to_rgmii/v4_0/pg160-gmii-to-rgmii.pdf

Re: [PATCH RFC] net: decrease the length of backlog queue immediately after it's detached from sk

2016-04-12 Thread Yang Yingliang
On 2016/4/12 10:59, Yang Yingliang wrote: On 2016/4/11 20:13, Eric Dumazet wrote: On Mon, 2016-04-11 at 19:57 +0800, Yang Yingliang wrote: On 2016/4/8 22:44, Eric Dumazet wrote: On Fri, 2016-04-08 at 19:18 +0800, Yang Yingliang wrote: I expand tcp_adv_win_scale and tcp_rmem. It has no

Re: [PATCH v2] mwifiex: fix possible NULL dereference

2016-04-12 Thread Sudip Mukherjee
On Tuesday 12 April 2016 05:20 PM, Arend van Spriel wrote: On 12-04-16 13:46, Sudip Mukherjee wrote: From: Sudip Mukherjee We have a check for card just after dereferencing it. So if it is NULL we have already dereferenced it before its check. Lets

Re: [PATCH v2] mwifiex: fix possible NULL dereference

2016-04-12 Thread Arend van Spriel
On 12-04-16 13:46, Sudip Mukherjee wrote: > From: Sudip Mukherjee > > We have a check for card just after dereferencing it. So if it is NULL > we have already dereferenced it before its check. Lets dereference it > after checking card for NULL. And you are

[PATCH v2] mwifiex: fix possible NULL dereference

2016-04-12 Thread Sudip Mukherjee
From: Sudip Mukherjee We have a check for card just after dereferencing it. So if it is NULL we have already dereferenced it before its check. Lets dereference it after checking card for NULL. Signed-off-by: Sudip Mukherjee ---

[PATCH 4.6 fix] bgmac: reset & enable Ethernet core before using it

2016-04-12 Thread Rafał Miłecki
This fixes Ethernet on D-Link DIR-885L with BCM47094 SoC. Felix reported similar fix was needed for his BCM4709 device (Buffalo WXR-1900DHP?). I tested this for regressions on BCM4706, BCM4708A0 and BCM47081A0. Cc: Felix Fietkau Signed-off-by: Rafał Miłecki

Re: [PATCH 0/3] crypto: af_alg - add TLS type encryption

2016-04-12 Thread Fridolin Pokorny
On 08.04.2016 04:58, Tom Herbert wrote: > On Thu, Apr 7, 2016 at 11:52 PM, Herbert Xu > wrote: >> On Wed, Apr 06, 2016 at 10:56:12AM -0700, Tadeusz Struk wrote: >>> >>> The intend is to enable HW acceleration of the TLS protocol. >>> The way it will work is that

[PATCH net-next v1 1/1] tipc: fix a race condition leading to subscriber refcnt bug

2016-04-12 Thread Parthasarathy Bhuvaragan
Until now, the requests sent to topology server are queued to a workqueue by the generic server framework. These messages are processed by worker threads and trigger the registered callbacks. To reduce latency on uniprocessor systems, explicit rescheduling is performed using cond_resched() after

Inter-VRF routing on a single machine

2016-04-12 Thread Darwin Dingel
Hi All, Have anyone tried the following setup on a single machine with 2 TCP sockets on different VRF's and succeeded? - client_socket on VRF1 - server_socket on VRF2 - ip rules and iproutes for inter-VRF set up - client_socket sends TCP connect to server_socket. skb was sent using VRF1

Re: [PATCH net-next WIP] ethtool: generic netlink policy

2016-04-12 Thread Johannes Berg
Hi, > + [ETHTOOL_ATTR_FLAGS]= { .type = NLA_U32 }, I suppose this comes from the current API, but perhaps it'd be worthwhile to make provision for more flags? Perhaps even using NLA_BINARY and have "infinitely extensible" flags. > + [ETHTOOL_ATTR_SSET_COUNT] =

Re: [PATCH RFT 2/2] macb: kill PHY reset code

2016-04-12 Thread Nicolas Ferre
Le 11/04/2016 20:51, Andrew Lunn a écrit : > On Mon, Apr 11, 2016 at 09:39:02PM +0300, Sergei Shtylyov wrote: >> Hello. >> >> On 04/11/2016 09:19 PM, Andrew Lunn wrote: >> > The code you are deleting would of ignored the flags in the gpio > property, i.e. active low. Hm,

Re: [PATCH RFT 2/2] macb: kill PHY reset code

2016-04-12 Thread Nicolas Ferre
Le 11/04/2016 04:28, Andrew Lunn a écrit : > On Sat, Apr 09, 2016 at 01:25:03AM +0300, Sergei Shtylyov wrote: >> With the 'phylib' now being aware of the "reset-gpios" PHY node property, >> there should be no need to frob the PHY reset in this driver anymore... >> >> Signed-off-by: Sergei

  1   2   >