VRF_DEVICE integration plan

2016-04-23 Thread Elluru, Krishna Mohan
HI Netdev team, Greetings. We have been monitoring the vrf device approach for l3 isolation from cumulus networks and we are currently interested in validating it. We have following questions on them and hoping to get answers from you/concerned team. 1. As per the linux documentation,

smc911 vs smsc911

2016-04-23 Thread Ran Shalit
Hello, Does anyone can say what's the difference between smc911 and smsc911 ? On reading the first comments in each file it seems that there is overlapping between them: smc911x.c * This is a driver for SMSC's LAN911{5,6,7,8} single-chip Ethernet devices. smsc911x.c === *

Re: [PATCH 00/23] Netfilter updates for net-next

2016-04-23 Thread David Miller
From: Pablo Neira Ayuso Date: Fri, 22 Apr 2016 15:39:31 +0200 > The following patchset contains Netfilter updates for your net-next > tree, mostly from Florian Westphal to sort out the lack of sufficient > validation in x_tables and connlabel preparation patches to add >

Re: net merged into net-next

2016-04-23 Thread Eric Dumazet
On Sat, 2016-04-23 at 20:12 -0400, David Miller wrote: > Eric, please double check my merge work for net/ipv4/udp.c > > In net we fixed a soreuseport bug that added a hlist_nulls_add_tail_rcu() > call to net/ipv4/udp.c > > And in net-next you converted UDP sockets away from nulls lists. > >

Re: [PATCH net] net/mlx4_en: fix spurious timestamping callbacks

2016-04-23 Thread Eric Dumazet
On Sat, 2016-04-23 at 23:23 +0300, Or Gerlitz wrote: > On Sat, Apr 23, 2016 at 9:35 PM, Eric Dumazet wrote: > > From: Eric Dumazet > > > > When multiple skb are TX-completed in a row, we might incorrectly keep > > a timestamp of a prior skb and cause

Re: [PATCH net-next 0/9] netlink: align attributes when needed (patchset #1)

2016-04-23 Thread David Miller
From: Nicolas Dichtel Date: Fri, 22 Apr 2016 17:31:15 +0200 > This is the continuation of the work done to align netlink attributes > when these attributes contain some 64-bit fields. > > David, if the third patch is too big (or maybe the series), I can split it. >

net merged into net-next

2016-04-23 Thread David Miller
Eric, please double check my merge work for net/ipv4/udp.c In net we fixed a soreuseport bug that added a hlist_nulls_add_tail_rcu() call to net/ipv4/udp.c And in net-next you converted UDP sockets away from nulls lists. Therefore I had to add a hlist_add_tail_rcu() implementation to

Re: [PATCH net-next 12/12] net/mlx5e: Disable link up on INIT HCA command

2016-04-23 Thread Ido Schimmel
Sat, Apr 23, 2016 at 11:21:45PM IDT, sae...@dev.mellanox.co.il wrote: >On Sat, Apr 23, 2016 at 7:00 PM, Ido Schimmel wrote: >> mutt suggests I sent you the following patches a while ago: >> >> net/mlx5e: Set port administrative status in ndo_{open, close} >> net/mlx5e:

Re: [PATCH net-next 2/2] net: ethernet: enc28j60: add device tree support

2016-04-23 Thread Arnd Bergmann
On Saturday 23 April 2016 23:43:20 Michael Heimpold wrote: > diff --git a/drivers/net/ethernet/microchip/enc28j60.c > b/drivers/net/ethernet/microchip/enc28j60.c > index b723622..49635d7 100644 > --- a/drivers/net/ethernet/microchip/enc28j60.c > +++ b/drivers/net/ethernet/microchip/enc28j60.c >

[PATCH net-next] macvlan: fix failure during registration v3

2016-04-23 Thread Francesco Ruggeri
If macvlan_common_newlink fails in register_netdevice after macvlan_init then it decrements port->count twice, first in macvlan_uninit (from register_netdevice or rollback_registered) and then again in macvlan_common_newlink. A similar problem may exist in the ipvlan driver. This patch

[PATCH net-next 0/2] net: ethernet: enc28j60: small improvements

2016-04-23 Thread Michael Heimpold
This series of two patches adds the following improvements to the driver: 1) Rework the central SPI read function so that it is compatible with SPI masters which only support half duplex transfers. 2) Add a device tree binding for the driver. Michael Heimpold (2): net: ethernet: enc28j60:

[PATCH net-next 2/2] net: ethernet: enc28j60: add device tree support

2016-04-23 Thread Michael Heimpold
The following patch adds the required match table for device tree support (and while at, fix the indent). Also add the corresponding binding documentation file. Signed-off-by: Michael Heimpold --- .../devicetree/bindings/net/microchip-enc28j60.txt | 49 ++

[PATCH net-next 1/2] net: ethernet: enc28j60: support half-duplex SPI controllers

2016-04-23 Thread Michael Heimpold
The current spi_read_buf function fails on SPI host masters which are only half-duplex capable. Splitting the Tx and Rx part solves this issue. Tested on Raspberry Pi (full duplex) and I2SE Duckbill (half duplex). Signed-off-by: Michael Heimpold ---

Re: [PATCH net-next 12/12] net/mlx5e: Disable link up on INIT HCA command

2016-04-23 Thread Or Gerlitz
On Sun, Apr 24, 2016 at 12:24 AM, Saeed Mahameed wrote: > On Sat, Apr 23, 2016 at 11:28 PM, Or Gerlitz wrote: >> On Sat, Apr 23, 2016 at 11:21 PM, Saeed Mahameed >> wrote: >>> On Sat, Apr 23, 2016 at 7:00 PM, Ido

Re: [PATCH net-next 12/12] net/mlx5e: Disable link up on INIT HCA command

2016-04-23 Thread Saeed Mahameed
On Sat, Apr 23, 2016 at 11:28 PM, Or Gerlitz wrote: > On Sat, Apr 23, 2016 at 11:21 PM, Saeed Mahameed > wrote: >> On Sat, Apr 23, 2016 at 7:00 PM, Ido Schimmel wrote: > >>> Also, why is this directed at net-next? > >> it is

Re: [PATCH net-next 12/12] net/mlx5e: Disable link up on INIT HCA command

2016-04-23 Thread Or Gerlitz
On Sat, Apr 23, 2016 at 11:21 PM, Saeed Mahameed wrote: > On Sat, Apr 23, 2016 at 7:00 PM, Ido Schimmel wrote: >> Also, why is this directed at net-next? > it is kind of new behavior, and not a bug fix. Saeed, We should be aiming to patch the

Re: [PATCH net] net/mlx4_en: fix spurious timestamping callbacks

2016-04-23 Thread Or Gerlitz
On Sat, Apr 23, 2016 at 9:35 PM, Eric Dumazet wrote: > From: Eric Dumazet > > When multiple skb are TX-completed in a row, we might incorrectly keep > a timestamp of a prior skb and cause extra work. > > Fixes: ec693d47010e8 ("net/mlx4_en: Add HW

Re: [PATCH net-next 12/12] net/mlx5e: Disable link up on INIT HCA command

2016-04-23 Thread Saeed Mahameed
On Sat, Apr 23, 2016 at 7:00 PM, Ido Schimmel wrote: > mutt suggests I sent you the following patches a while ago: > > net/mlx5e: Set port administrative status in ndo_{open, close} > net/mlx5e: Initialize port administrative status to down > > So I'm curious as to why you

[PATCH net-next 1/3] ila: Add struct definitions and helpers

2016-04-23 Thread Tom Herbert
Add structures for identifiers, locators, and an ila address which is composed of a locator and identifier and in6_addr can be cast to it. This includes a three bit type field and enums for the types defined in ILA I-D. In ILA lwt don't allow user to set a translation for a non-ILA address (type

[PATCH net-next 0/3] ila: Support for checksum neutral translations

2016-04-23 Thread Tom Herbert
This patch set updates ILA to support draft-herbert-nvo3-ila-02. The primary addition is support checksum neutral ILA translation. This allows address to be performed and still keep any transport layer checksums that include the addresses in their pseudo header to still be correct without the

[PATCH net-next 3/3] ila: add checksum neutral ILA translations

2016-04-23 Thread Tom Herbert
Support checksum neutral ILA as described in the ILA draft. The low order 16 bits of the identifier are used to contain the checksum adjustment value. The csum-mode parameter is added to described checksum processing. There are three values: - adjust transport checksum (previous behavior) - do

[PATCH net-next 2/3] ila: xlat changes

2016-04-23 Thread Tom Herbert
Change model of xlat to be used only for input where lookup is done on the locator part of an address (comparing to locator_match as key in rhashtable). This is needed for checksum neutral translation which obfuscates the low order 16 bits of the identifier. It also permits hosts to be in muliple

[PATCH net] net/mlx4_en: fix spurious timestamping callbacks

2016-04-23 Thread Eric Dumazet
From: Eric Dumazet When multiple skb are TX-completed in a row, we might incorrectly keep a timestamp of a prior skb and cause extra work. Fixes: ec693d47010e8 ("net/mlx4_en: Add HW timestamping (TS) support") Signed-off-by: Eric Dumazet Willem de

Re: [PATCH net-next 2/9] libnl: nla_put_le64(): align on a 64-bit area

2016-04-23 Thread Alexander Aring
Hi, On 04/23/2016 07:05 PM, Alexander Aring wrote: ... > > if this is really needed, then nla_put_u64/be64/etc need to be changed also, Okay, I found PATCH 3/9 do it for be64, but what's about u64? - Alex

[PATCH] off-by-one in DecodeQ931

2016-04-23 Thread Toby DiPasquale
I was reviewing the H.323 conntrack helper in the kernel when I came across what appears to be an off-by-one error in the DecodeQ931 function. The MessageType field of the Q931 record is assigned and p is incremented, but the corresponding decrement to sz is missing, leading the sz variable to be

Re: [PATCH net-next 2/9] libnl: nla_put_le64(): align on a 64-bit area

2016-04-23 Thread Alexander Aring
Hi, On 04/22/2016 06:51 PM, Eric Dumazet wrote: > On Fri, 2016-04-22 at 17:31 +0200, Nicolas Dichtel wrote: >> nla_data() is now aligned on a 64-bit area. >> >> Signed-off-by: Nicolas Dichtel >> --- >> include/net/netlink.h | 8 +--- >>

Re: [PATCH net-next 12/12] net/mlx5e: Disable link up on INIT HCA command

2016-04-23 Thread Ido Schimmel
Hi, Fri, Apr 22, 2016 at 10:00:47PM IDT, sae...@mellanox.com wrote: >From: Eran Ben Elisha > >Disable link up when initializing the HCA. Link up/down will be changed >using (Ports Administrative and Operational Status Register) PAOS >commands. > >If link layer is Ethernet,

[PATCH] net: dummy: remove note about being Y by default

2016-04-23 Thread Ivan Babrou
Signed-off-by: Ivan Babrou --- drivers/net/Kconfig | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig index 2a1ba62b..bd86a23 100644 --- a/drivers/net/Kconfig +++ b/drivers/net/Kconfig @@ -62,9 +62,8 @@ config

[PATCH v5 06/21] IB/hns: Add initial cmd operation

2016-04-23 Thread Lijun Ou
This patch added the operation for initing cmd. In addition that, added some functions for initing eq table and selecting cmd mode in next stages. Signed-off-by: Lijun Ou Signed-off-by: Wei Hu(Xavier) --- drivers/infiniband/hw/hns/hns_roce_cmd.c

[PATCH v5 11/21] IB/hns: Add IB device registration function

2016-04-23 Thread Lijun Ou
This patch registers IB device and unregister IB device when removed. Signed-off-by: Lijun Ou Signed-off-by: Wei Hu(Xavier) --- drivers/infiniband/hw/hns/hns_roce_main.c | 48 +++ 1 file changed, 48 insertions(+) diff

[PATCH v5 03/21] IB/hns: Add initial main frame driver and get cfg info

2016-04-23 Thread Lijun Ou
This patch mainly added the initial bare main driver. it could get the relative configure information of net node. Signed-off-by: Lijun Ou Signed-off-by: Wei Hu(Xavier) --- drivers/infiniband/hw/hns/hns_roce_device.h | 49

[PATCH v5 04/21] IB/hns: Add RoCE engine reset function

2016-04-23 Thread Lijun Ou
This patch mainly added RoCE engine reset process in RoCE driver. it is necessary when RoCE was loaded and removed. Signed-off-by: Lijun Ou Signed-off-by: Wei Hu(Xavier) --- drivers/infiniband/hw/hns/hns_roce_device.h | 7

[PATCH v5 00/21] Add HiSilicon RoCE driver

2016-04-23 Thread Lijun Ou
The HiSilicon Network Substem is a long term evolution IP which is supposed to be used in HiSilicon ICT SoCs. HNS (HiSilicon Network Sybsystem) also has a hardware support of performing RDMA with RoCEE. The driver for HiSilicon RoCEE(RoCE Engine) is a platform driver and will support mulitple

[PATCH v5 19/21] IB/hns: Add memory region operation support

2016-04-23 Thread Lijun Ou
This patch was mainly for implemention of memory region. Memory Registration provides mechanisms that allow Consumers to describe a set of virtually contiguous memory locations or a set of physically contiguous memory locations. MR operations includes as follows: 1. get dma MR in kernel mode

[PATCH v5 05/21] IB/hns: Add initial profile resource

2016-04-23 Thread Lijun Ou
This patch mainly configured some profile resoure. for exmaple, vendor_id, hardware version, and some data structure sizes so on. Signed-off-by: Lijun Ou Signed-off-by: Wei Hu(Xavier) --- drivers/infiniband/hw/hns/hns_roce_common.h | 25 +

[PATCH v5 17/21] IB/hns: Add QP operation implemention support

2016-04-23 Thread Lijun Ou
This patch was implemention for queue pair operations. QP Consists of a Send Work Queue and a Receive Work Queue. Send and receive queues are always created as a pair and remain that way throughout their lifetime. A Queue Pair is identified by its Queue Pair Number. QP operations implemention as

[PATCH v5 02/21] devicetree: bindings: IB: Add binding document for HiSilicon RoCE

2016-04-23 Thread Lijun Ou
This patch adds related DTS binding document for HiSilicon RoCE driver. Signed-off-by: Lijun Ou Signed-off-by: Wei Hu(Xavier) --- .../bindings/infiniband/hisilicon-hns-roce.txt | 107 + 1 file changed, 107 insertions(+)

[PATCH v5 15/21] IB/hns: Add PD operations support

2016-04-23 Thread Lijun Ou
This patch added the verbs to operate PD. It mainly includes the functions of allocating PD and deallocating PD. Signed-off-by: Lijun Ou Signed-off-by: Wei Hu(Xavier) --- drivers/infiniband/hw/hns/hns_roce_device.h | 17

[PATCH v5 10/21] IB/hns: Add process flow to init RoCE engine

2016-04-23 Thread Lijun Ou
This patch mainly initialized the RoCE engine. It is absolutely necessary to run RoCE function. It mainly includes that configure DMAE user, init doorbell and raq operations, enable port. Signed-off-by: Lijun Ou Signed-off-by: Wei Hu(Xavier) ---

[PATCH v5 12/21] IB/hns: Set mtu and gid support

2016-04-23 Thread Lijun Ou
This patch mainly set mtu and gid resource. These resource will be used to set up network transmission in nodes. Signed-off-by: Lijun Ou Signed-off-by: Wei Hu(Xavier) --- drivers/infiniband/hw/hns/hns_roce_common.h | 16

[PATCH v5 20/21] IB/hns: Kconfig and Makefile for RoCE module

2016-04-23 Thread Lijun Ou
This patch add Kconfig and Makefile for building RoCE module. Signed-off-by: Lijun Ou Signed-off-by: Wei Hu(Xavier) --- drivers/infiniband/Kconfig | 1 + drivers/infiniband/hw/Makefile | 1 + drivers/infiniband/hw/hns/Kconfig | 10

[PATCH v5 07/21] IB/hns: Add event queue support

2016-04-23 Thread Lijun Ou
This patch added event queue support for RoCE driver. it is used for RoCE interrupt. RoCE includes 32 synchronous event irqs, 1 asynchronous event irq and 1 common overflow irq. Signed-off-by: Lijun Ou Signed-off-by: Wei Hu(Xavier) ---

[PATCH v5 13/21] IB/hns: Add interface of the protocol stack registration

2016-04-23 Thread Lijun Ou
This patch mainly added the function module which netif notify registered the protocol stack. It includes interface functions as follows: 1. The executive called interface of RoCE when the netlink event that registered protocol stack was generated 2. The executive called interface

[PATCH v5 14/21] IB/hns: Add operations support for IB device and port

2016-04-23 Thread Lijun Ou
This patch mainly registered some relative verbs for the kernel. These operation funtions will be called by user. For example: 1. modify device 2. query device 3. query_port 4. modify_port and so on. Signed-off-by: Lijun Ou Signed-off-by: Wei Hu(Xavier)

[PATCH v5 09/21] IB/hns: Add hca support

2016-04-23 Thread Lijun Ou
This patch mainly setup hca for RoCE. it will do a series of initial works as follows: 1. init uar table, allocate uar resource 2. init pd table 3. init cq table 4. init mr table 5. init qp table Signed-off-by: Lijun Ou Signed-off-by: Wei

[PATCH v5 18/21] IB/hns: Add CQ operation implemention support

2016-04-23 Thread Lijun Ou
This patch was implemention for Completion Queue(CQ) operations. A CQ can be used to multiplex work completions from multiple work queues across queue pairs on the same HCA. CQ as the notification mechanism for Work Request completions. CQ operations implemention as follows: 1. create CQ. CQ

[PATCH v5 08/21] IB/hns: Add icm support

2016-04-23 Thread Lijun Ou
This patch mainly added icm support for RoCE. It inits the icm which managers the relative memory blocks for RoCE. the data structures of RoCE will be located in it. for example, CQ table, QP table and MTPT table so on. Signed-off-by: Lijun Ou Signed-off-by: Wei Hu(Xavier)

[PATCH v5 21/21] MAINTAINERS: Add maintainers for HiSilicon RoCE driver

2016-04-23 Thread Lijun Ou
This patch added maintainers for RoCE driver. Signed-off-by: Lijun Ou Signed-off-by: Wei Hu(Xavier) --- MAINTAINERS | 8 1 file changed, 8 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 61a323a..cb45b6f 100644 --- a/MAINTAINERS

[PATCH v5 16/21] IB/hns: Add ah operation support

2016-04-23 Thread Lijun Ou
This patch was for implemention of address handle operation. It includes three verbs that create ah, query ah and destory ah. They is completed independently by RoCE driver. Signed-off-by: Lijun Ou Signed-off-by: Wei Hu(Xavier) ---

[PATCH v5 01/21] net: hns: Add reset function support for RoCE driver

2016-04-23 Thread Lijun Ou
It added reset function for RoCE driver. RoCE is a feature of hns. In hip06 SoC, in RoCE reset process, it's needed to configure dsaf channel reset, port and sl map info. Reset function of RoCE is located in dsaf module, we only call it in RoCE driver when needed. Signed-off-by: Lijun Ou

[PATCH] net: tsi108: use NULL for pointer-typed argument

2016-04-23 Thread Julia Lawall
The first argument of pci_free_consistent has type struct pci_dev *, so use NULL instead of 0. The semantic patch that performs this transformation is as follows: (http://coccinelle.lip6.fr/) // @@ @@ pci_free_consistent( - 0 + NULL , ...) // Signed-off-by: Julia Lawall

[PATCH v2 net-next 04/13] net: hns: add attribute reset-field-offset for dsaf node

2016-04-23 Thread Yisen Zhuang
Add the subctrl reset offset for dsaf, this property is used to reset xge/ge ports for different dsaf. If this attribute is not present, default value 0 will be used. Signed-off-by: Daode Huang Signed-off-by: Yisen Zhuang --- change log: PATCH

[PATCH v2 net-next 02/13] net: hns: set debug port irq index to 0

2016-04-23 Thread Yisen Zhuang
From: Daode Huang As debug ports are moved from service dsaf to debug dsaf, the interrupts offset should start from 0, So this patch re-defines the offset index of debug ports. Signed-off-by: Daode Huang Signed-off-by: Yisen Zhuang

[PATCH v2 net-next 01/13] net: hns: add a new dsaf mode for debug port

2016-04-23 Thread Yisen Zhuang
This patch adds a new dsaf mode named "single-port" mode for debug port. This mode only contains one debug port. This patch also changes the method of distinguishing the port type. Signed-off-by: Daode Huang Signed-off-by: Yisen Zhuang ---

[PATCH v2 net-next 11/13] Documentation: Bindings: Update DT binding for separating dsaf dev support

2016-04-23 Thread Yisen Zhuang
Because debug dsaf port was separated from service dsaf port, this patch updates the related information of DT binding. Signed-off-by: Yisen Zhuang --- .../devicetree/bindings/net/hisilicon-hns-dsaf.txt | 59 ++ 1 file changed, 49 insertions(+), 10

[PATCH v2 net-next 09/13] net: hns: add attribute port-rst-offset for dsaf port node

2016-04-23 Thread Yisen Zhuang
The reset offset for each port in a dsaf is different. The current code is not so readability. This patch adds configuration named port-rst-offset to make the code simple and more readability. If this attribute doesn't exist, default value of this attribute is equal to its port index.

[PATCH v2 net-next 06/13] net: hns: sort the header file by alphabetical order

2016-04-23 Thread Yisen Zhuang
From: Daode Huang This patch tunes the header file by the alphabetical order. Signed-off-by: Daode Huang Signed-off-by: Yisen Zhuang --- drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.c | 12 ++--

[PATCH v2 net-next 13/13] dts: hisi: update hns dst for separating dsaf dev support

2016-04-23 Thread Yisen Zhuang
Because debug dsaf port was separated from service dsaf port, this patch updates the related configurations of hns dts, changes it to match with the new binding files. This also removes enet nodes which don't exist in d02 board. Signed-off-by: Yisen Zhuang ---

[PATCH v2 net-next 12/13] Documentation: Bindings: add port-idx-in-ae for enet node

2016-04-23 Thread Yisen Zhuang
This patch adds description for port-idx-in-ae attribute. Signed-off-by: Yisen Zhuang --- .../devicetree/bindings/net/hisilicon-hns-nic.txt | 30 +- 1 file changed, 29 insertions(+), 1 deletion(-) diff --git

[PATCH v2 net-next 00/13] net: hns: add support of debug dsaf device

2016-04-23 Thread Yisen Zhuang
There are two kinds of dsaf device in hns, one is for service ports, contains crossbar in it, can work under different mode. Another is for debug port, only can work under single port mode. The current code only declares a dsaf device for both service ports and debug ports.It is not so

[PATCH v2 net-next 03/13] net: hns: add attribute port-idx-in-ae in enet node.

2016-04-23 Thread Yisen Zhuang
This patch parse port-idx-in-ae in enet node. In NIC mode of DSAF, all 6 PHYs of service DSAF are taken as ethernet ports to the CPU. The port-idx-in-ae can be 0 to 5. Here is the diagram: +-+---+ |CPU | +-+-+-+---+-+-+-+-+-+-+

[PATCH v2 net-next 07/13] net: hns: separate debug dsaf device from service dsaf device

2016-04-23 Thread Yisen Zhuang
There are two kinds of dsaf device in hns, one is for service ports, contains crossbar in it, can work under different mode. Another is for debug port, only can work under "single-port" mode. The current code only declared a dsaf device for both service ports and debug ports. This patch separate

[PATCH v2 net-next 10/13] net: hns: add attribute port-mode-offset for dsaf port node

2016-04-23 Thread Yisen Zhuang
Port mode offset for each dsaf port is different. The current code is not so readability. This patch adds configuration named port-mode-offset to make the code simple and more readability. If port-mode-offset isn't exists, default value 0 will be used. Signed-off-by: Daode Huang

[PATCH v2 net-next 08/13] net: hns: add attribute cpld_ctrl for dsaf port node

2016-04-23 Thread Yisen Zhuang
This patch adds attribute cpld_ctrl for dsaf port node, parses the syscon for mac_cb from dts, and changes the method of access the cpld related registers through syscon. Signed-off-by: Daode Huang Signed-off-by: Yisen Zhuang --- change log:

[PATCH v2 net-next 05/13] net: hns: add syscon operation for dsaf

2016-04-23 Thread Yisen Zhuang
This patch provides the read/write function for dsaf to access the registers through syscon methods. Signed-off-by: Daode Huang Signed-off-by: Yisen Zhuang --- drivers/net/ethernet/hisilicon/hns/hns_dsaf_reg.h | 14 ++ 1 file