[PATCH net v3] virtio_net: fix virtnet_open and virtnet_probe competing for try_fill_recv

In function virtnet_open() and virtnet_probe(), func try_fill_recv() may be executed at the same time. VQ in virtqueue_add() has not been protected well and BUG_ON will be triggered when virito_net.ko being removed. Signed-off-by: Yunjian Wang Acked-by: Jason Wang

Re: [PATCH] vxlan: Accept user specified MTU value when create new vxlan link

On Sat, May 28, 2016 at 8:22 AM, oc wrote: > 1. vxlan_dev_configure function check conf->mtu to determine if it need to > change value of dev->mtu. > The logical looks better to get conf->mtu from IFLA_MTU directly. Fair enough, Acked-by: Cong Wang

Re: [PATCH V2 2/2] vhost_net: conditionally enable tx polling

On 2016年05月30日 23:55, Michael S. Tsirkin wrote: On Mon, May 30, 2016 at 02:47:54AM -0400, Jason Wang wrote: We always poll tx for socket, this is sub optimal since: - it will be only used when we exceed the sndbuf of the socket. - since we use two independent polls for tx and vq, this will

Re: [PATCH V2 1/2] vhost_net: stop polling socket during rx processing

On 2016年05月30日 23:47, Michael S. Tsirkin wrote: On Mon, May 30, 2016 at 02:47:53AM -0400, Jason Wang wrote: We don't stop rx polling socket during rx processing, this will lead unnecessary wakeups from under layer net devices (E.g sock_def_readable() form tun). Rx will be slowed down in this

Re: [PATCH v5 0/2] skb_array: array based FIFO for skbs

On 2016年05月30日 23:37, Michael S. Tsirkin wrote: On Mon, May 30, 2016 at 05:59:33PM +0800, Jason Wang wrote: On 2016年05月23日 18:43, Michael S. Tsirkin wrote: This is in response to the proposal by Jason to make tun rx packet queue lockless using a circular buffer. My testing seems to show

Re: [PATCH v2] fib_rules: Added NLM_F_EXCL support to fib_nl_newrule

On 5/30/16 3:17 AM, Mateusz Bajorski wrote: When adding rule with NLM_F_EXCL flag then check if the same rule exist. If yes then exit with -EEXIST. This is already implemented in iproute2: if (cmd == RTM_NEWRULE) { req.n.nlmsg_flags |= NLM_F_CREATE|NLM_F_EXCL;

[PATCH iproute2 net-next v2 3/5] bridge: add json support for bridge fdb show

From: Anuradha Karuppiah Sample output: $bridge -j fdb show [{ "mac": "44:38:39:00:69:88", "dev": "swp2s0", "vlan": 2, "master": "br0", "state": "permanent" },{ "mac": "00:02:00:00:00:01", "dev": "swp2s0",

[PATCH iproute2 net-next v2 1/5] json_writer: allow base json data type to be array or object

From: Anuradha Karuppiah This patch adds a type qualifier to json_writer. Type can be a json object or array. This can be extended to other types like json-string, json-number etc in the future. Signed-off-by: Anuradha Karuppiah ---

[PATCH iproute2 net-next v2 4/5] bridge: add json schema for bridge fdb show

From: Anuradha Karuppiah we think storing the schema file for the json format will be useful. Signed-off-by: Anuradha Karuppiah --- schema/bridge_fdb_schema.json | 62 +++ 1 file changed, 62

[PATCH iproute2 net-next v2 0/5] bridge: json support for fdb and vlan show

From: Roopa Prabhu This patch series adds json support for a few bridge show commands. We plan to follow up with json support for additional commands soon. Anuradha Karuppiah (3): json_writer: allow base json data type to be array or object bridge: add json

[PATCH iproute2 net-next v2 2/5] bridge: add json support for bridge vlan show

From: Roopa Prabhu $bridge -c vlan show portvlan ids swp1 1 PVID Egress Untagged 10-13 swp2 1 PVID Egress Untagged 10-13 br0 1 PVID Egress Untagged $bridge -json vlan show { "swp1": [{ "vlan": 1,

[PATCH iproute2 net-next v2 5/5] bridge: update man page

From: Roopa Prabhu Signed-off-by: Roopa Prabhu --- man/man8/bridge.8 | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/man/man8/bridge.8 b/man/man8/bridge.8 index 08e8a5b..abaee63 100644 --- a/man/man8/bridge.8

Re: [PATCH iproute2 net-next 2/5] bridge: add json support for bridge vlan show

On 5/29/16, 5:43 PM, Toshiaki Makita wrote: > On 2016/05/28 13:37, Roopa Prabhu wrote: >> From: Roopa Prabhu >> >> $bridge -c vlan show >> port vlan ids >> swp1 1 PVID Egress Untagged >> 10-13 >> >> swp2 1 PVID Egress Untagged >> 10-13 >> >> br0 1 PVID

Re: [PATCH 0/2] macvlan: Avoid unnecessary multicast cloning

On Mon, May 30, 2016 at 07:27:59PM +0300, Lennert Buytenhek wrote: > > That and stack switches to kworker threads and serialisation on > the bc_queue queue lock. My patch should resolve these problems too since the packet is discarded if nobody is interested in it. Cheers, -- Email: Herbert Xu

[PATCH 4.4 18/86] asix: Fix offset calculation in asix_rx_fixup() causing slow transmissions

4.4-stable review patch. If anyone has any objections, please let me know. -- From: John Stultz commit cd9e2e5d3ff148be9ea210f622ce3e8e8292fcd6 upstream. In testing with HiKey, we found that since commit 3f30b158eba5 ("asix: On RX avoid creating bad

[PATCH 4.5 15/87] asix: Fix offset calculation in asix_rx_fixup() causing slow transmissions

4.5-stable review patch. If anyone has any objections, please let me know. -- From: John Stultz commit cd9e2e5d3ff148be9ea210f622ce3e8e8292fcd6 upstream. In testing with HiKey, we found that since commit 3f30b158eba5 ("asix: On RX avoid creating bad

Re: [PATCH v2] ethernet:arc: Fix racing of TX ring buffer

Hi Shuyu, On 28.05.2016 08:43, Shuyu Wei wrote: > > After some stress testing, it worked well most of the time. > But there is a chance that it may get stuck when I use 2 nc process > to send TCP packects at full speed. Only when a new rx packet > arrive can trigger it to run again. This

Re: [PATCH net-next] ravb: Add ESF in RCR for enabling separation filter

On 05/30/2016 05:30 PM, Sergei Shtylyov wrote: From: Masaru Nagai This patch adds enabling separation filter(ESF) is setting value of B'11. This setting filter for separating AVB stream frames from non-AVB stream frames is enabled. Non-matching frames from a

[PATCH 4.6 014/100] asix: Fix offset calculation in asix_rx_fixup() causing slow transmissions

4.6-stable review patch. If anyone has any objections, please let me know. -- From: John Stultz commit cd9e2e5d3ff148be9ea210f622ce3e8e8292fcd6 upstream. In testing with HiKey, we found that since commit 3f30b158eba5 ("asix: On RX avoid creating bad

Re: [PATCH] iwlwifi: mvm: avoid harmless -Wmaybe-uninialized warning

On Fri, 2016-05-27 at 15:07 +0200, Arnd Bergmann wrote: > gcc is apparently unablel to track the state of the local 'resp_v2' > variable across the kzalloc() function, and warns about the response > variable being used without an initialization: > > drivers/net/wireless/intel/iwlwifi/mvm/nvm.c:

Re: usbnet: smsc95xx: fix link detection for disabled autonegotiation

On Sun, 2016-05-29 at 22:30 -0700, David Miller wrote: > From: Christoph Fritz > Date: Thu, 26 May 2016 04:06:47 +0200 > > > @@ -1695,6 +1745,7 @@ static int smsc95xx_resume(struct usb_interface *intf) > > > > /* do this first to ensure it's cleared even in error

[iproute PATCH] man: ip, ip-link: Fix ip option location

This patch drops the redundant description of some of ip's options in ip-link.8's description of the 'show' subcommand, preserving the description of -iec (but appending it to the list in ip.8 with minor fixes). Signed-off-by: Phil Sutter --- man/man8/ip-link.8.in | 21

Re: linux-next: Tree for May 30

On Monday 30 May 2016 08:52 AM, Stephen Rothwell wrote: Hi all, Changes since 20160527: Hi All, I have just built and booted with next-20160530 and my dmesg is full of warnings from ath9k. Last kernel tested was v4.6 and there was no problem with that. The traces are like: Call Trace

Re: [PATCHv2 net] sctp: sctp_diag should dump sctp socket type

On Sun, May 29, 2016 at 05:42:13PM +0800, Xin Long wrote: > Now we cannot distinguish that one sk is a udp or sctp style when > we use ss to dump sctp_info. it's necessary to dump it as well. > > For sctp_diag, ss support is not officially available, thus there > are no official users of this

RE: [PATCH] qed: fix qed_fill_link() error handling

> + if (IS_ENABLED(CONFIG_QED_SRIOV) && !IS_PF(hwfn->cdev)) { > + qed_vf_get_link_params(hwfn, params); > + qed_vf_get_link_state(hwfn, link); > + qed_vf_get_link_caps(hwfn, link_caps); > + > + return 0; > + } The IS_ENABLED here seems a bit

Re: [PATCH 0/2] macvlan: Avoid unnecessary multicast cloning

On Mon, May 30, 2016 at 04:17:52PM +0800, Herbert Xu wrote: > > Commit 412ca1550cbecb2c ("macvlan: Move broadcasts into a work queue") > > moved processing of all macvlan multicasts into a work queue. This > > causes a noticable performance regression when there is heavy multicast > > traffic on

Re: [net v3] veth: advertise peer link once both links are tied together

Le 30/05/2016 18:01, Vincent Bernat a écrit : > ❦ 30 mai 2016 17:58 CEST, Vincent Bernat : > >> + >> +rtmsg_ifinfo(RTM_NEWLINK, peer, IFF_SLAVE, GFP_KERNEL); > > Maybe ~0U would be better than hijacking IFF_SLAVE? IFF_SLAVE is wrong. It's a flag here, that will be put in

Re: [PATCH] rtlwifi: fix error handling in *_read_adapter_info()

On 05/30/2016 10:26 AM, Arnd Bergmann wrote: There are nine copies of the _rtl88ee_read_adapter_info() function, and most but not all of them cause a build warning in some configurations: rtl8192de/hw.c: In function '_rtl92de_read_adapter_info': rtl8192de/hw.c:1767:12: error: 'hwinfo' may be

Re: [net v3] veth: advertise peer link once both links are tied together

❦ 30 mai 2016 17:58 CEST, Vincent Bernat  : > + > + rtmsg_ifinfo(RTM_NEWLINK, peer, IFF_SLAVE, GFP_KERNEL); Maybe ~0U would be better than hijacking IFF_SLAVE? -- Anyone who has had a bull by the tail knows five or six more things than someone who hasn't.

[net v3] veth: advertise peer link once both links are tied together

When the peer link is created, its "iflink" information is not advertised through Netlink. Once created, the local device is advertised with this information but if a user is maintaining a cache from all updates, it will still miss the iflink for the peer link: 2: veth0@NONE:

Re: [PATCH V2 2/2] vhost_net: conditionally enable tx polling

On Mon, May 30, 2016 at 02:47:54AM -0400, Jason Wang wrote: > We always poll tx for socket, this is sub optimal since: > > - it will be only used when we exceed the sndbuf of the socket. > - since we use two independent polls for tx and vq, this will slightly > increase the waitqueue traversing

Re: [PATCH V2 1/2] vhost_net: stop polling socket during rx processing

On Mon, May 30, 2016 at 02:47:53AM -0400, Jason Wang wrote: > We don't stop rx polling socket during rx processing, this will lead > unnecessary wakeups from under layer net devices (E.g > sock_def_readable() form tun). Rx will be slowed down in this > way. This patch avoids this by stop polling

Re: [PATCH] veth: delay peer link configuration after interfaces are tied

Le 30/05/2016 17:26, Vincent Bernat a écrit : > ❦ 30 mai 2016 17:19 CEST, Nicolas Dichtel : > > priv = netdev_priv(peer); > rcu_assign_pointer(priv->peer, dev); > + > + err = rtnl_configure_link(peer, ifmp); > + if (err < 0) > +

[PATCH] qed: fix qed_fill_link() error handling

gcc warns about qed_fill_link possibly accessing uninitialized data: drivers/net/ethernet/qlogic/qed/qed_main.c: In function 'qed_fill_link': drivers/net/ethernet/qlogic/qed/qed_main.c:1170:35: error: 'link_caps' may be used uninitialized in this function [-Werror=maybe-uninitialized] While

[PATCH] rtlwifi: fix error handling in *_read_adapter_info()

There are nine copies of the _rtl88ee_read_adapter_info() function, and most but not all of them cause a build warning in some configurations: rtl8192de/hw.c: In function '_rtl92de_read_adapter_info': rtl8192de/hw.c:1767:12: error: 'hwinfo' may be used uninitialized in this function

Re: [PATCH v5 0/2] skb_array: array based FIFO for skbs

On Mon, May 30, 2016 at 05:59:33PM +0800, Jason Wang wrote: > > > On 2016年05月23日 18:43, Michael S. Tsirkin wrote: > >This is in response to the proposal by Jason to make tun > >rx packet queue lockless using a circular buffer. > >My testing seems to show that at least for the common usecase >

Re: [PATCH] veth: delay peer link configuration after interfaces are tied

❦ 30 mai 2016 17:19 CEST, Nicolas Dichtel  : priv = netdev_priv(peer); rcu_assign_pointer(priv->peer, dev); + + err = rtnl_configure_link(peer, ifmp); + if (err < 0) + goto err_configure_peer; >> >>> You should fix the

Re: [PATCH 3/7] binding: mdio-mux: Add DT binding doc for Broadcom MDIO bus mutiplexer

On Mon, May 30, 2016 at 12:40:47PM +0530, Pramod Kumar wrote: > Add DT binding doc for Broadcom MDIO bus mutiplexer driver. > > Signed-off-by: Pramod Kumar > --- > .../bindings/net/brcm,mdio-mux-iproc.txt | 64 > ++ > 1 file changed, 64

Re: [PATCH] veth: delay peer link configuration after interfaces are tied

Le 30/05/2016 12:13, Vincent Bernat a écrit : > When the peer link is created, its "iflink" information is not > advertised through netlink. If a user is maintaining a cache from all > updates, it will miss this information: > > 2: veth0@NONE: mtu 1500 qdisc noop state

Re: [PATCH] veth: delay peer link configuration after interfaces are tied

Le 30/05/2016 12:11, Vincent Bernat a écrit : > ❦ 30 mai 2016 11:23 CEST, Nicolas Dichtel : > >>> @@ -466,6 +462,10 @@ static int veth_newlink(struct net *src_net, struct >>> net_device *dev, >>> >>> priv = netdev_priv(peer); >>>

Re: [PATCH 1/4] base: soc: introduce soc_device_match() interface

On Monday, May 30, 2016 3:14:38 PM CEST Arnd Bergmann wrote: > We keep running into cases where device drivers want to know the exact > version of the SoC a they are currently running on. In the past, this > has usually been done through a vendor specific API that can be called > by a driver, or

Re: [PATCH RFT 1/2] phylib: add device reset GPIO support

On Thu, May 26, 2016 at 9:00 PM, Uwe Kleine-König wrote: > On Thu, May 26, 2016 at 11:00:55AM +0200, Linus Walleij wrote: >> On Thu, May 12, 2016 at 8:42 PM, Uwe Kleine-König >> wrote: >> >> > [added Linus Walleij to Cc, there is a

RE: [PATCH 5/7] net:mdio-mux: Add MDIO mux driver for iProc SoCs

Hi Andrew, Thanks for reviewing. Please see my comment inline. > -Original Message- > From: Andrew Lunn [mailto:and...@lunn.ch] > Sent: 30 May 2016 19:05 > To: Pramod Kumar > Cc: Rob Herring; Pawel Moll; Mark Rutland; Ian Campbell; Kumar Gala; Catalin > Marinas; Will Deacon; Kishon Vijay

Re: [PATCH net-next] ravb: Add ESF in RCR for enabling separation filter

On 05/29/2016 11:25 PM, Yoshihiro Kaneko wrote: From: Masaru Nagai This patch adds enabling separation filter(ESF) is setting value of B'11. This setting filter for separating AVB stream frames from non-AVB stream frames is enabled. Non-matching frames from a

Re: [PATCH net-next] ravb: Add SET_RUNTIME_PM_OPS macro

Hello. On 05/29/2016 11:25 PM, Yoshihiro Kaneko wrote: From: Kazuya Mizuguchi Use SET_RUNTIME_PM_OPS macro instead of assigning a member of dev_pm_ops directly. Signed-off-by: Kazuya Mizuguchi Signed-off-by: Yoshihiro Kaneko

Re: [PATCH net] net: dsa: mv88e6xxx: Fix port forwarding mask

Hi Wojciech, David, Wojciech Dubowik writes: > Port's vlan table is specified by bit mask and not by number. > Only 4.4.x kernels are affected. > > Signed-off-by: Wojciech Dubowik > --- > drivers/net/dsa/mv88e6xxx.c | 2 +- > 1 file

[PATCH iproute2] Added support for selection of new HSR version

A new HSR version was added in 4.7 that can be enabled via iproute2. Per default the old version is selected, however, with "ip link add [..] type hsr [..] version 1" the newer version can be enabled. Signed-off-by: Peter Heise --- ip/iplink_hsr.c | 13 +++-- 1

Re: [PATCH 5/7] net:mdio-mux: Add MDIO mux driver for iProc SoCs

On Mon, May 30, 2016 at 12:40:49PM +0530, Pramod Kumar wrote: > iProc based SoCs supports the integrated mdio multiplexer which > has the bus selection as well as mdio transaction generation logic > inside. Hi Pramod Great to see you using the existing MDIO framework. Thanks. > +static int

[PATCH 4/4] Revert "powerpc/fsl: Move fsl_guts.h out of arch/powerpc"

All users of this driver are PowerPC specific and the header file has no business in the global include/linux/ hierarchy, so move it back before anyone starts using it on ARM. This reverts commit 948486544713492f00ac8a9572909101ea892cb0. Signed-off-by: Arnd Bergmann --- This part

[PATCH 3/4] mmc: sdhci-of-esdhc: fix host version for T4240-R1.0-R2.0

This is a rewrite of an earlier patch from Yangbo Lu, adding a quirk for the NXP QorIQ T4240 in the detection of the host device version. Unfortunately, this device cannot be detected using the compatible string, as we have to support existing DTS files that use the generic "fsl,t4240-esdhc"

[PATCH 2/4] soc: fsl: add GUTS driver for QorIQ platforms

From: Yangbo Lu The global utilities block controls power management, I/O device enabling, power-onreset(POR) configuration monitoring, alternate function selection for multiplexed signals,and clock control. This patch adds GUTS driver to manage and access global utilities

[PATCH 1/4] base: soc: introduce soc_device_match() interface

We keep running into cases where device drivers want to know the exact version of the SoC a they are currently running on. In the past, this has usually been done through a vendor specific API that can be called by a driver, or by directly accessing some kind of version register that is not part

Re: [v10, 7/7] mmc: sdhci-of-esdhc: fix host version for T4240-R1.0-R2.0

On Thursday, May 26, 2016 9:44:10 AM CEST Ulf Hansson wrote: > On 26 May 2016 at 06:05, Yangbo Lu wrote: > > Hi Uffe, > > > > Could we merge this patchset? ... > > It has been a long time to wait for Arnd's response... > > > > Thanks a lot. > > > > > > As we are still in the

[PATCH net] bnx2x: avoid leaking memory on bnx2x_init_one() failures

bnx2x_init_bp() allocates memory with bnx2x_alloc_mem_bp() so if we fail later in bnx2x_init_one() we need to free this memory with bnx2x_free_mem_bp() to avoid leakages. E.g. I'm observing memory leaks reported by kmemleak when a failure (unrelated) happens in bnx2x_vfpf_acquire().

[PATCH v3 net-next 10/13] net: hns: dsaf adds support of acpi

From: Kejian Yan Dsaf needs to get configuration parameter by ACPI, so this patch add support of ACPI. Signed-off-by: Kejian Yan Reviewed-by: Andy Shevchenko Signed-off-by: Yisen Zhuang

[PATCH v3 net-next 00/13] net: hns: add support of ACPI

From: Kejian Yan This series adds HNS support of acpi. The routine will call some ACPI helper functions, like acpi_dev_found() and acpi_evaluate_dsm(), which are not included in other cases. In order to make system compile successfully in other cases except ACPI, it needs

[PATCH v3 net-next 01/13] ACPI: bus: add stub acpi_dev_found() to linux/acpi.h

From: Kejian Yan acpi_dev_found() will be used to detect if a given ACPI device is in the system. It will be compiled in non-ACPI case, but the function is in acpi_bus.h and acpi_bus.h can only be used in ACPI case, so this patch add the stub function to linux/acpi.h to

[PATCH v3 net-next 08/13] net: hns: add uniform interface for phy connection

From: Kejian Yan As device_node is only used by DT case, HNS needs to treat the other cases including ACPI. It needs to use uniform ways to handle both of DT and ACPI. This patch chooses phy_device, and of_phy_connect and of_phy_attach are only used by DT case. It needs to

[PATCH v3 net-next 02/13] ACPI: bus: add stub acpi_evaluate_dsm() to linux/acpi.h

From: Kejian Yan acpi_evaluate_dsm() will be used to handle the _DSM method in ACPI case. It will be compiled in non-ACPI case, but the function is in acpi_bus.h and acpi_bus.h can only be used in ACPI case, so this patch add the stub function to linux/acpi.h to make

[PATCH v3 net-next 06/13] net: hns: use platform_get_irq instead of irq_of_parse_and_map

From: Kejian Yan As irq_of_parse_and_map is only used by DT case, it is excepted to use a uniform interface. So it is used platform_get_irq() instead. Signed-off-by: Kejian Yan Signed-off-by: Yisen Zhuang ---

[PATCH v3 net-next 04/13] net: hisilicon: add support of acpi for hns-mdio

From: Kejian Yan hns-mdio needs to register itself to mii-bus. The info of the device can be read by both DT and ACPI. HNS tries to call Linux PHY driver to help access PHY-devices, the HNS hardware topology is as below. The MDIO controller may control several PHY-devices,

[PATCH v3 net-next 11/13] net: hns: register phy device in each mac initial sequence

From: Kejian Yan In ACPI case, there is no interface to register phy device to mdio-bus. Phy device has to be registered itself to mdio-bus, and then enet can get the phy device's info so that it can config the phy-device to help to trasmit and receive data. HNS hardware

[PATCH v3 net-next 05/13] net: hns: use device_* APIs instead of of_* APIs

From: Kejian Yan OF series functions can be used only for DT case. Use unified device property function instead to support both DT and ACPI. Signed-off-by: Kejian Yan Signed-off-by: Yisen Zhuang ---

[PATCH v3 net-next 13/13] net: hns: net: hns: enet adds support of acpi

From: Kejian Yan Enet needs to get configration parameter by acpi. This patch adds support of ACPI for enet. The configuration parameter will be configed in BIOS. Signed-off-by: Kejian Yan Signed-off-by: Yisen Zhuang ---

[PATCH v3 net-next 07/13] net: hns: enet specify a reference to dsaf by fwnode_handle

From: Kejian Yan As device_node is only used by DT case, it is expected to find uniform ways. So fwnode_handle is the suitable method. Signed-off-by: Kejian Yan Reviewed-by: Andy Shevchenko Signed-off-by: Yisen

[PATCH v3 net-next 12/13] net: hns: implement the miscellaneous operation by asl

From: Kejian Yan The miscellaneous operation is implemented in BIOS, the kernel can call _DSM method help to call the implementation in ACPI case. Here is a patch to do that. Signed-off-by: Kejian Yan Reviewed-by: Andy Shevchenko

[PATCH v3 net-next 09/13] net: hns: add dsaf misc operation method

From: Kejian Yan The misc operation for different hw platform may be different, if using current implementation, it will add a new branch on each function for every new hw platform, so we add a method for this operation. Signed-off-by: Kejian Yan

[PATCH v3 net-next 03/13] net: hisilicon: cleanup to prepare for other cases

From: Kejian Yan Hns-mdio only supports DT case now. do some cleanup to prepare for introducing other cases later, no functional change. Signed-off-by: Kejian Yan Signed-off-by: Yisen Zhuang ---

Re: [PATCH] veth: delay peer link configuration after interfaces are tied

❦ 30 mai 2016 12:12 CEST, Vincent Bernat  : > When the peer link is created, its "iflink" information is not [...] And that's the wrong patch... Please, ignore this one. -- Don't stop with your first draft. - The Elements of Programming Style (Kernighan &

Re: [PATCH] veth: delay peer link configuration after interfaces are tied

❦ 30 mai 2016 11:23 CEST, Nicolas Dichtel  : >> @@ -466,6 +462,10 @@ static int veth_newlink(struct net *src_net, struct >> net_device *dev, >> >> priv = netdev_priv(peer); >> rcu_assign_pointer(priv->peer, dev); >> + >> +err =

[PATCH] veth: delay peer link configuration after interfaces are tied

When the peer link is created, its "iflink" information is not advertised through netlink. If a user is maintaining a cache from all updates, it will miss this information: 2: veth0@NONE: mtu 1500 qdisc noop state DOWN group default link/ether ae:0e:08:af:fb:a0

[PATCH] veth: delay peer link configuration after interfaces are tied

When the peer link is created, its "iflink" information is not advertised through netlink. If a user is maintaining a cache from all updates, it will miss this information: 2: veth0@NONE: mtu 1500 qdisc noop state DOWN group default link/ether ae:0e:08:af:fb:a0

Re: [PATCH v5 0/2] skb_array: array based FIFO for skbs

On 2016年05月23日 18:43, Michael S. Tsirkin wrote: This is in response to the proposal by Jason to make tun rx packet queue lockless using a circular buffer. My testing seems to show that at least for the common usecase in networking, which isn't lockless, circular buffer with indices does not

Re: [PATCH 0/8] mwifiex: Fix some error handling issues in mwifiex_sdio_probe() function

Hi Javier, 2016-05-27 16:18 GMT+02:00 Javier Martinez Canillas : > Hello, > > While booting a system with a mwifiex WiFi card, I noticed the following > missleading error message: > > [ 12.480042] mwifiex_sdio mmc2:0001:1: sdio platform data not available > > This error

[PATCH net] net: dsa: mv88e6xxx: Fix port forwarding mask

Port's vlan table is specified by bit mask and not by number. Only 4.4.x kernels are affected. Signed-off-by: Wojciech Dubowik --- drivers/net/dsa/mv88e6xxx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/dsa/mv88e6xxx.c

Re: [PATCH] nf_queue: Make the queue_handler pernet

On Fri, May 13, 2016 at 09:18:52PM -0500, Eric W. Biederman wrote: > > Florian Weber reported: > > Under full load (unshare() in loop -> OOM conditions) we can > > get kernel panic: > > > > BUG: unable to handle kernel NULL pointer dereference at 0008 > > IP: []

Re: [PATCH] veth: delay peer link configuration after interfaces are tied

Le 29/05/2016 13:17, Vincent Bernat a écrit : [snip] > diff --git a/drivers/net/veth.c b/drivers/net/veth.c > index f37a6e61d4ad..9726c4dbf659 100644 > --- a/drivers/net/veth.c > +++ b/drivers/net/veth.c > @@ -432,10 +432,6 @@ static int veth_newlink(struct net *src_net, struct > net_device *dev,

[PATCH v2] fib_rules: Added NLM_F_EXCL support to fib_nl_newrule

When adding rule with NLM_F_EXCL flag then check if the same rule exist. If yes then exit with -EEXIST. This is already implemented in iproute2: if (cmd == RTM_NEWRULE) { req.n.nlmsg_flags |= NLM_F_CREATE|NLM_F_EXCL; req.r.rtm_type = RTN_UNICAST; }

[PATCH 2/2] macvlan: Avoid unnecessary multicast cloning

Currently we always queue a multicast packet for further processing, even if none of the macvlan devices are subscribed to the address. This patch optimises this by adding a global multicast filter for a macvlan_port. Note that this patch doesn't handle the broadcast addresses of the individual

Re: [patch v2 net-next 00/13] net: hns: add support of ACPI

On Mon, 2016-05-30 at 10:10 +0800, Kejian Yan wrote: > This series adds HNS support of acpi. The routine will call some ACPI > helper functions, like acpi_dev_found() and acpi_evaluate_dsm(), which > are not included in other cases. In order to make system compile > successfully in other cases

Re: [patch v2 net-next 12/13] net: hns: implement the miscellaneous operation by asl

On Mon, 2016-05-30 at 10:10 +0800, Kejian Yan wrote: > The miscellaneous operation is implemented in BIOS, the kernel can > call > _DSM method help to call the implementation in ACPI case. Here is a > patch > to do that. > > +static phy_interface_t hns_mac_get_phy_if_acpi(struct hns_mac_cb >

[PATCH 1/2] macvlan: Fix potential use-after free for broadcasts

When we postpone a broadcast packet we save the source port in the skb if it is local. However, the source port can disappear before we get a chance to process the packet. This patch fixes this by holding a ref count on the netdev. It also delays the skb->cb modification until after we allocate

[PATCH 0/2] macvlan: Avoid unnecessary multicast cloning

On Fri, May 27, 2016 at 02:44:33AM +0300, Lennert Buytenhek wrote: > Commit 412ca1550cbecb2c ("macvlan: Move broadcasts into a work queue") > moved processing of all macvlan multicasts into a work queue. This > causes a noticable performance regression when there is heavy multicast > traffic on

linux-4.7-rc1/drivers/isdn/capi/capidrv.c:1707]: (style) Redundant condition

Hello there, linux-4.7-rc1/drivers/isdn/capi/capidrv.c:1707]: (style) Redundant condition: If 'EXPR == ' '', the comparison 'EXPR' is always true. Source code is while (*s && *s == ' ') s++; Suggest new code while (*s == ' ') s++; Regards David Binderman

Re: [PATCH v1 5/6] dtb: xgene: Remove clock nodes

On 27/05/16 09:22, Iyappan Subramanian wrote: Since the MDIO will be responsible for clock reset, removing the clock nodes from shadowcat xge0 and storm sgenet1. Signed-off-by: Iyappan Subramanian Tested-by: Fushen Chen Tested-by: Toan Le

[PATCH 5/7] net:mdio-mux: Add MDIO mux driver for iProc SoCs

iProc based SoCs supports the integrated mdio multiplexer which has the bus selection as well as mdio transaction generation logic inside. This mutiplexer has child buses for PCIe, SATA, USB and ETH. These buses could be internal or external to SOC where PHYs are attached. These buses could use

[PATCH 3/7] binding: mdio-mux: Add DT binding doc for Broadcom MDIO bus mutiplexer

Add DT binding doc for Broadcom MDIO bus mutiplexer driver. Signed-off-by: Pramod Kumar --- .../bindings/net/brcm,mdio-mux-iproc.txt | 64 ++ 1 file changed, 64 insertions(+) create mode 100644

[PATCH 4/7] DT:mdio-mux: Add mdio multiplexer driver node

Add integrated MDIO multiplexer driver node which contains two mux PCIe bus and one ethernet bus along with phys lying on these bus. Signed-off-by: Pramod Kumar --- arch/arm64/boot/dts/broadcom/ns2-svk.dts | 12 arch/arm64/boot/dts/broadcom/ns2.dtsi|

[PATCH 6/7] Binding:PHY: Binding doc for NS2 PCIe PHYs.

Binding doc for NS2 PCIe PHYs. Signed-off-by: Jon Mason Signed-off-by: Pramod Kumar --- .../bindings/phy/brcm,mdio-mux-bus-pci.txt | 27 ++ 1 file changed, 27 insertions(+) create mode 100644

[PATCH 0/7] Add MDIO bus multiplexer support for iProc SoCs

Broadcom iProc based SoCs use a MDIO bus multiplexer where child buses could be internal as well external to SoCs. These buses could supports MDIO transaction compatible to C-22/C-45. Broadcom MDIO bus mulitplexer is an integrated multiplexer where child bus selection and mdio transaction logic

[PATCH 7/7] phy: Add Northstar2 PCI Phy support

Add PCI Phy support for Broadcom Northstar2 SoCs. This driver uses the interface from the iproc mdio mux driver to enable the devices respective phys. Signed-off-by: Jon Mason Signed-off-by: Pramod Kumar --- drivers/phy/Kconfig|

[PATCH 2/7] DT: phy.txt: Add mdio-integrated-mux property

This property is used by integrated MDIO multiplexer which has bus selection and mdio transaction generation logic, integrated inside. Signed-off-by: Pramod Kumar --- Documentation/devicetree/bindings/net/mdio-mux.txt | 9 - 1 file changed, 8 insertions(+), 1

[PATCH 1/7] mdio:mux: Enhanced MDIO mux framework for integrated multiplexers

An integrated multiplexer uses same address space for "muxed bus selection" and "generation of mdio transaction" hence its good to register parent bus from mux driver. Hence added a mechanism where mux driver could register a parent bus and pass it down to framework via mdio_mux_init api. Below

Re: [PATCH] net: l2tp: Make l2tp_ip6 namespace aware

From: Shmulik Ladkani Date: Thu, 26 May 2016 20:16:36 +0300 > l2tp_ip6 tunnel and session lookups were still using init_net, although > the l2tp core infrastructure already supports lookups keyed by 'net'. > > As a result, l2tp_ip6_recv discarded packets for

Re: [PATCH v2] net: alx: use custom skb allocator

Hi Eric, On Thu, May 26, 2016 at 06:08:22AM -0700, Eric Dumazet wrote: > On Thu, 2016-05-26 at 16:41 +0800, Feng Tang wrote: > > On Wed, May 25, 2016 at 07:53:41PM -0400, David Miller wrote: > > > > > > > But now that we have at least two instances of this code we really > > > need to put a

Re: [PATCH v2 03/10] nl80211: Prefer ether_addr_copy

> This looks right to me, but doesn't ether_addr_copy() have alignment > requirements? Could someone more familiar with that review these > changes to ensure they're met? Thanks for catching this. The requirement is to be __aligned(2). I've added 4 instances of ether_addr_copy with 8 addresses as

[PATCH V2 0/2] vhost_net polling optimization

Hi: This series tries to optimize vhost_net polling at two points: - Stop rx polling for reduicng the unnecessary wakeups during handle_rx(). - Conditonally enable tx polling for reducing the unnecessary traversing and spinlock touching. Test shows about 17% improvement on rx pps. Please

[PATCH V2 2/2] vhost_net: conditionally enable tx polling

We always poll tx for socket, this is sub optimal since: - it will be only used when we exceed the sndbuf of the socket. - since we use two independent polls for tx and vq, this will slightly increase the waitqueue traversing time and more important, vhost could not benefit from commit

[PATCH V2 1/2] vhost_net: stop polling socket during rx processing

We don't stop rx polling socket during rx processing, this will lead unnecessary wakeups from under layer net devices (E.g sock_def_readable() form tun). Rx will be slowed down in this way. This patch avoids this by stop polling socket during rx processing. A small drawback is that this introduces

Re: [PATCH v2 06/10] nl80211: Various checkpatch.pl spacing fixes

Hi All, On Mon, May 30, 2016 at 12:53 PM, Kirtika Ruchandani wrote: > This patch fixes the following spacing issues reported > by checkpatch.pl - > - space preferred around that > - no space needed after cast. > - Alignment should match open parenthesis > - suspect

  1   2   >