Re: [PATCH net-next V3 0/6] switch to use tx skb array in tun

On Thu, Jun 30, 2016 at 11:52:53AM +0800, Jason Wang wrote: > Hi all: > > This series tries to switch to use skb array in tun. This is used to > eliminate the spinlock contention between producer and consumer. The > conversion was straightforward: just introdce a tx skb array and use > it instead

Re: [PATCH net-next V3 5/6] net: introduce NETDEV_CHANGE_TX_QUEUE_LEN

On 2016年06月30日 12:56, John Fastabend wrote: On 16-06-29 08:52 PM, Jason Wang wrote: This patch introduces a new event - NETDEV_CHANGE_TX_QUEUE_LEN, this will be triggered when tx_queue_len. It could be used by net device who want to do some processing at that time. An example is tun who may

Re: [PATCH V2 4/4] net-next: mediatek: add support for IRQ grouping

Hi, [auto build test ERROR on net/master] [also build test ERROR on next-20160629] [cannot apply to net-next/master v4.7-rc5] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/John-Crispin/net

Re: [PATCH net-next V3 5/6] net: introduce NETDEV_CHANGE_TX_QUEUE_LEN

On 16-06-29 08:52 PM, Jason Wang wrote: > This patch introduces a new event - NETDEV_CHANGE_TX_QUEUE_LEN, this > will be triggered when tx_queue_len. It could be used by net device > who want to do some processing at that time. An example is tun who may > want to resize tx array when tx_queue_len

[PATCH net-next V3 3/6] ptr_ring: support resizing multiple queues

From: "Michael S. Tsirkin" Sometimes, we need support resizing multiple queues at once. This is because it was not easy to recover to recover from a partial failure of multiple queues resizing. Signed-off-by: Michael S. Tsirkin Signed-off-by: Jason Wang

Re: [PATCH net-next 08/16] net/devlink: Add E-Switch mode control

On 16-06-29 08:35 PM, John Fastabend wrote: > On 16-06-29 03:09 PM, John Fastabend wrote: >> On 16-06-29 02:33 PM, Or Gerlitz wrote: >>> On Wed, Jun 29, 2016 at 7:35 PM, John Fastabend >>> wrote: On 16-06-29 07:48 AM, Or Gerlitz wrote: > On 6/28/2016 10:31 PM,

[PATCH net-next V3 2/6] skb_array: minor tweak

Signed-off-by: Michael S. Tsirkin Signed-off-by: Jason Wang --- include/linux/skb_array.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/linux/skb_array.h b/include/linux/skb_array.h index 678bfbf..2dd0d1e 100644 ---

[PATCH net-next V3 5/6] net: introduce NETDEV_CHANGE_TX_QUEUE_LEN

This patch introduces a new event - NETDEV_CHANGE_TX_QUEUE_LEN, this will be triggered when tx_queue_len. It could be used by net device who want to do some processing at that time. An example is tun who may want to resize tx array when tx_queue_len is changed. Signed-off-by: Jason Wang

[PATCH net-next V3 1/6] ptr_ring: support zero length ring

Sometimes, we need zero length ring. But current code will crash since we don't do any check before accessing the ring. This patch fixes this. Signed-off-by: Jason Wang --- include/linux/ptr_ring.h | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git

[PATCH net-next V3 4/6] skb_array: add wrappers for resizing

Signed-off-by: Michael S. Tsirkin Signed-off-by: Jason Wang --- include/linux/skb_array.h | 9 + 1 file changed, 9 insertions(+) diff --git a/include/linux/skb_array.h b/include/linux/skb_array.h index 2dd0d1e..f4dfade 100644 ---

[PATCH net-next V3 0/6] switch to use tx skb array in tun

Hi all: This series tries to switch to use skb array in tun. This is used to eliminate the spinlock contention between producer and consumer. The conversion was straightforward: just introdce a tx skb array and use it instead of sk_receive_queue. A minor issue is to keep the tx_queue_len

[PATCH net-next V3 6/6] tun: switch to use skb array for tx

We used to queue tx packets in sk_receive_queue, this is less efficient since it requires spinlocks to synchronize between producer and consumer. This patch tries to address this by: - switch from sk_receive_queue to a skb_array, and resize it when tx_queue_len was changed. - introduce a new

Re: [PATCH v2 net-next] tcp: md5: use kmalloc() backed scratch areas

On Wed, Jun 29, 2016 at 03:39:37PM -0700, Andy Lutomirski wrote: > > I don't care about TCP MD5 performance at all. Ease of maintenance is > nice, though, and maybe there are other places in the kernel where > performance does matter. TCP MD5 is using ahash because it touches SG lists. Touching

Re: [PATCH net-next 08/16] net/devlink: Add E-Switch mode control

On 16-06-29 03:09 PM, John Fastabend wrote: > On 16-06-29 02:33 PM, Or Gerlitz wrote: >> On Wed, Jun 29, 2016 at 7:35 PM, John Fastabend >> wrote: >>> On 16-06-29 07:48 AM, Or Gerlitz wrote: On 6/28/2016 10:31 PM, John Fastabend wrote: > On 16-06-28 12:12 PM,

Re: [PATCH net-next V2] tun: introduce tx skb ring

On 2016年06月28日 15:09, Michael S. Tsirkin wrote: On Thu, Jun 23, 2016 at 01:14:07PM +0800, Jason Wang wrote: On 2016年06月23日 02:18, Michael S. Tsirkin wrote: On Fri, Jun 17, 2016 at 03:41:20AM +0300, Michael S. Tsirkin wrote: Would it help to have ptr_ring_resize that gets an array of rings

Re: [PATCH net-next 9/9] net: hns: get reset registers from DT

On 2016/6/29 17:11, David Miller wrote: > From: Yisen Zhuang > Date: Mon, 27 Jun 2016 17:54:15 +0800 > >> @@ -361,9 +371,10 @@ static int hns_mdio_reset(struct mii_bus *bus) >> return -ENODEV; >> } >> >> +sc_reg = _dev->sc_reg; >>

linux-next: manual merge of the net-next tree with Linus' tree

Hi all, Today's linux-next merge of the net-next tree got a conflict in: drivers/net/phy/fixed_phy.c between commit: 69fc58a57e56 ("net: phy: Manage fixed PHY address space using IDA") from Linus' tree and commit: bf7afb29d545 ("phy: improve safety of fixed-phy MII register reading")

[net-next PATCH 0/5] HFSC patches, part 1

Hi, It's revised version of part of the patches I submitted really, really long time ago (back then I asked Patrick to ignore them as I found some issues shortly after submitting). Anyway this is the first set with very simple fixes/changes though some of them relatively subtle (I tried to do

[net-next PATCH 5/5] net/sched/sch_hfsc.c: anchor virtual curve at proper vt in hfsc_change_fsc()

cl->cl_vt alone is relative only to the current backlog period, while the curve operates on cumulative virtual time. This patch adds missing cl->cl_vtoff. Signed-off-by: Michal Soltys --- net/sched/sch_hfsc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[net-next PATCH 2/5] net/sched/sch_hfsc.c: add unlikely() in qdisc_peek_len()

The condition can only succeed on wrong configurations. Signed-off-by: Michal Soltys --- net/sched/sch_hfsc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/sched/sch_hfsc.c b/net/sched/sch_hfsc.c index 6d6df6b..e2244bb 100644 --- a/net/sched/sch_hfsc.c

[net-next PATCH 1/5] net/sched/sch_hfsc.c: handle corner cases where head may change invalidating calculated deadline

Realtime scheduling implemented in HFSC uses head of the queue to make the decision about which packet to schedule next. But in case of any head drop, the deadline calculated for the previous head is not necessarily correct for the next head (unless both packets have the same length). Thanks to

[net-next PATCH 3/5] net/sched/sch_hfsc.c: remove leftover dlist and droplist

This is update to: commit a09ceb0e08140a ("sched: remove qdisc->drop") That commit removed qdisc->drop, but left alone dlist and droplist that no longer serve any meaningful purpose. Signed-off-by: Michal Soltys --- net/sched/sch_hfsc.c | 8 1 file changed, 8

[net-next PATCH 4/5] net/sched/sch_hfsc.c: go passive after vt update

When a class is going passive, it should update its cl_vt first to be consistent with the last dequeue operation. Otherwise its cl_vt will be one packet behind and parent's cvtmax might not be updated as well. One possible side effect is if some class goes passive and subsequently goes active

Re: [iproute PATCH 1/2] ip-address: Support filtering by slave type, too

On Tue, 28 Jun 2016 15:07:16 +0200 Phil Sutter wrote: > +static int match_link_kind(struct rtattr **tb, char *kind, bool slave) const char *kind ?? > +{ > + if (!tb[IFLA_LINKINFO]) > + return -1; > + > + return strcmp(parse_link_kind(tb[IFLA_LINKINFO], slave),

[PATCH 0/1] qlcnic: add wmb() call in transmit data path.

0001-qlcnic-add-wmb-call-in-transmit-data-path.patch This patch adds a wmb() call in the Tx data path to ensure writes are completed before hardware fetches updated Tx descriptors. Please apply to net. Thanks, Sony

[PATCH 1/1] qlcnic: add wmb() call in transmit data path.

Call wmb() to ensure writes are complete before hardware fetches updated Tx descriptors. Signed-off-by: Sony Chacko --- drivers/net/ethernet/qlogic/qlcnic/qlcnic_io.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git

Re: [PATCH v2 net-next] tcp: md5: use kmalloc() backed scratch areas

On Wed, Jun 29, 2016 at 2:44 PM, Eric Dumazet wrote: > On Wed, 2016-06-29 at 09:41 -0700, Andy Lutomirski wrote: > >> Overall, it looks like there's overhead of something like 50ns for >> each ahash invocation vs the shash equivalent. It's not huge, but >> it's there.

Re: [PATCH net-next 08/16] net/devlink: Add E-Switch mode control

On 16-06-29 02:33 PM, Or Gerlitz wrote: > On Wed, Jun 29, 2016 at 7:35 PM, John Fastabend > wrote: >> On 16-06-29 07:48 AM, Or Gerlitz wrote: >>> On 6/28/2016 10:31 PM, John Fastabend wrote: On 16-06-28 12:12 PM, Jiri Pirko wrote: > > Why?! Please, leave legacy

Re: [PATCH v2 net-next] tcp: md5: use kmalloc() backed scratch areas

On Wed, 2016-06-29 at 09:41 -0700, Andy Lutomirski wrote: > Overall, it looks like there's overhead of something like 50ns for > each ahash invocation vs the shash equivalent. It's not huge, but > it's there. (This is cache-hot. I bet it's considerably worse if > cache-cold, because ahash will

Re: [net] e1000e: keep VLAN interfaces functional after rxvlan off

David Miller wrote: From: Jeff Kirsher Date: Tue, 28 Jun 2016 20:41:31 -0700 From: Jarod Wilson I've got a bug report about an e1000e interface, where a VLAN interface is set up on top of it: $ ip link add link ens1f0 name ens1f0.99 type vlan id

Re: [PATCH] ipv4: Fix ip_skb_dst_mtu to use the sk passed by ip_finish_output

On Wed, Jun 29, 2016, at 20:47, Shmulik Ladkani wrote: > ip_skb_dst_mtu uses skb->sk, assuming it is an AF_INET socket (e.g. it > calls ip_sk_use_pmtu which casts sk as an inet_sk). > > However, in the case of UDP tunneling, the skb->sk is not necessarily an > inet socket (could be AF_PACKET

[net-next 06/15] ixgbe: Error handler for duplicate filter locations in hardware for cls_u32 offloads

From: Amritha Nambiar For u32 classifier filters, avoid overwriting existing filter in a hardware location without removing it first, to clean up inconsistencies due to duplicate values for filter location. Verified with the following filters: Create child hash

[net-next 05/15] ixgbe: Fix deleting link filters for cls_u32 offloads

From: Amritha Nambiar On deleting filters which are links to a child hash table, the filters in the child hash table must be cleared from the hardware if there is no link between the parent and child hash table. Verified with the following filters: Create a child

[net-next 01/15] fm10k: don't use BIT() macro where the value isn't a bitmask

From: Jacob Keller The FM10K_MAX_DATA_PER_TXD is really just using a bitshift as a power of 2 operation in an efficient manner. We shouldn't represent this as a BIT() because that obscures the intention of the operation. Signed-off-by: Jacob Keller

[net-next 02/15] fm10k: Align Rx buffers to 512B blocks

From: Alexander Duyck While reviewing the i40e driver changes to support page based receive I realized that I had overlooked the fact that the fm10k hardware required a 512 byte alignment for Rx buffers. This patch is meant to address that by changing the alignment for Rx

Re: [PATCH net-next 08/16] net/devlink: Add E-Switch mode control

On Wed, Jun 29, 2016 at 7:35 PM, John Fastabend wrote: > On 16-06-29 07:48 AM, Or Gerlitz wrote: >> On 6/28/2016 10:31 PM, John Fastabend wrote: >>> On 16-06-28 12:12 PM, Jiri Pirko wrote: Why?! Please, leave legacy be legacy. Use the new mode for implementing

[net-next 09/15] igb: re-use igb_ptp_reset in igb_ptp_init

From: Jacob Keller Modify igb_ptp_init to take advantage of igb_ptp_reset, and remove duplicated work that was occurring in both igb_ptp_reset and igb_ptp_init. In total, resetting the TSAUXC register, and resetting the system time both happen in igb_ptp_reset already.

[net-next 08/15] igb: introduce IGB_PTP_OVERFLOW_CHECK flag

From: Jacob Keller Don't continue to use complex MAC type checks for handling various cases where we have overflow check code. Make this code more obvious by introducing a flag which is enabled for hardware that needs these checks. Signed-off-by: Jacob Keller

[net-next 07/15] igb: introduce ptp_flags variable and use it to replace IGB_FLAG_PTP

From: Jacob Keller Upcoming patches will introduce new PTP specific flags. To avoid cluttering the normal flags variable, introduce PTP specific "ptp_flags" variable for this purpose, and move IGB_FLAG_PTP to become IGB_PTP_ENABLED. Signed-off-by: Jacob Keller

[net-next 04/15] e1000e: prevent division by zero if TIMINCA is zero

From: Denys Vlasenko Users report that under VMWare, er32(TIMINCA) returns zero. This causes division by zero at init time as follows: ==> incvalue = er32(TIMINCA) & E1000_TIMINCA_INCVALUE_MASK; for (i = 0; i < E1000_MAX_82574_SYSTIM_REREADS; i++) {

[net-next 12/15] fm10k: Remove create_workqueue

From: Bhaktipriya Shridhar alloc_workqueue replaces deprecated create_workqueue(). A dedicated workqueue has been used since the workitem (viz fm10k_service_task, which manages and runs other subtasks) is involved in normal device operation and requires forward progress

[net-next 13/15] ixgbe: Correct reporting of timestamping for x550

From: Tony Nguyen Update ixgbe_ethtool_get_ts_info() to show that x550 supports hardware timestamping of all packets. Reported-by: Guy Harris Signed-off-by: Tony Nguyen Signed-off-by: Jacob Keller

[net-next 00/15][pull request] Intel Wired LAN Driver Updates 2016-06-29

This series contains updates and fixes to e1000e, igb, ixgbe and fm10k. A true smorgasbord of changes. Jake cleans up some obscurity by not using the BIT() macro on bitshift operation and also fixed the calculated index when looping through the indir array. Fixes the issue with igb's workqueue

[net-next 03/15] fm10k: fix incorrect index calculation in fm10k_write_reta

From: Jacob Keller The index calculated when looping through the indir array passed to fm10k_write_reta was incorrectly calculated as the first part i needs to be multiplied by 4. Fixes: 0cfea7a65738 ("fm10k: fix possible null pointer deref after kcalloc", 2016-04-13)

[net-next 14/15] ixgbe: fix spoofed packets with macvlans

From: Emil Tantilov When setting spoofing, both VLAN and MAC need to be set together. This change resolves an issue where MAC-VLANs on the VF fail to pass traffic due to spoofed packets. Signed-off-by: Emil Tantilov Tested-by: Andrew Bowers

[net-next 11/15] igb: call igb_ptp_suspend during suspend/resume cycle

From: Jacob Keller Properly stop the extra workqueue items and ensure that we resume cleanly. This is better than using igb_ptp_init and igb_ptp_stop since these functions destroy the PHC device, which will cause other problems if we do so. Since igb_ptp_reset now

[net-next 15/15] igb: Only DMA sync frame length

From: Andrew Lunn On some platforms, syncing a buffer for DMA is expensive. Rather than sync the whole 2K receive buffer, only synchronise the length of the frame, which will typically be the MTU, or a much smaller TCP ACK. For an IMX6Q, this gives around 6% increased TCP

[net-next 10/15] igb: implement igb_ptp_suspend

From: Jacob Keller Make igb_ptp_stop take advantage of this new function to reduce code duplication. Signed-off-by: Jacob Keller Tested-by: Aaron Brown Signed-off-by: Jeff Kirsher ---

[PATCH net-next 0/3] nfp: few code improvements

Hi! Three small patches for net-next. First and second patches improve the code quality by spelling things correctly and removing unused parameters. Third patch hooks-in standard kernel implementation of .get_link() in ethtool ops. Jakub Kicinski (3): nfp: correct name of control BAR define

[PATCH net-next 2/3] nfp: remove unused parameter from nfp_net_write_mac_addr()

nfp_net_write_mac_addr() always writes to the BAR the current device address taken from netdev struct. The address given as parameter is actually ignored. Since all callers pass netdev->dev_addr simply remove the parameter. While at it improve the function's kdoc a bit. Signed-off-by: Jakub

[PATCH net-next 3/3] nfp: implement ethtool .get_link() callback

Point the ethtool .get_link() callback to the standard ethtool_op_get_link() implementation. Signed-off-by: Jakub Kicinski --- drivers/net/ethernet/netronome/nfp/nfp_net_ethtool.c | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCH net-next 1/3] nfp: correct name of control BAR define

Spell abbreviation of control as ctrl not crtl. Signed-off-by: Jakub Kicinski --- drivers/net/ethernet/netronome/nfp/nfp_net.h| 2 +- drivers/net/ethernet/netronome/nfp/nfp_netvf_main.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git

Re: Question on i40e PCIe relaxed ordering (RO)

On Wed, 2016-06-29 at 13:18 -0700, Greg wrote: > On Wed, 2016-06-29 at 13:05 -0700, tndave wrote: > > Hi, > >  > > Running iperf tcp test on 2 sparc systems with i40e connected back to > > back, I see huge number of 'port.rx_dropped' (on iperf server). Based > on > > past experience with ixgbe,

Re: [RFC 3/7] net: ethernet: bgmac: move BCMA MDIO Phy code into a separate file

On Wed, Jun 29, 2016 at 4:15 PM, Andrew Lunn wrote: > On Wed, Jun 29, 2016 at 04:08:20PM -0400, Jon Mason wrote: >> On Wed, Jun 29, 2016 at 2:46 PM, Andrew Lunn wrote: >> > On Wed, Jun 29, 2016 at 11:35:28AM -0700, Florian Fainelli wrote: >> >> On 06/29/2016 07:13

Re: Question on i40e PCIe relaxed ordering (RO)

On Wed, 2016-06-29 at 13:05 -0700, tndave wrote: > Hi, > > Running iperf tcp test on 2 sparc systems with i40e connected back to > back, I see huge number of 'port.rx_dropped' (on iperf server). Based on > past experience with ixgbe, this could very well because of PCIe RO > (relaxed ordering)

Re: [PATCH net-next v3] tcp: use RFC6298 compliant TCP RTO calculation

BD R Y -- mean TCPRecovLat 3s -7% +39% +38% mean TCPRecovLat252s +1% -11% -11% This is indeed very interesting and somewhat unexpected. Do

Re: [PATCH] [v6] net: emac: emac gigabit ethernet controller driver

Arnd Bergmann wrote: Sure, but in theory, my for-loop is correct, right? Wouldn't there be some value in setting a 36-bit or 40-bit DMA mask if it works? We have a platform where memory starts at a 40-bit address, so some devices have a 44-bit address bus. If a 64-bit mask doesn't work, then

Re: [RFC 3/7] net: ethernet: bgmac: move BCMA MDIO Phy code into a separate file

On Wed, Jun 29, 2016 at 04:08:20PM -0400, Jon Mason wrote: > On Wed, Jun 29, 2016 at 2:46 PM, Andrew Lunn wrote: > > On Wed, Jun 29, 2016 at 11:35:28AM -0700, Florian Fainelli wrote: > >> On 06/29/2016 07:13 AM, Andrew Lunn wrote: > >> > Hi Jon > >> > > >> > I know you are just

Re: [RFC 1/7] net: ethernet: bgmac: change bgmac_* prints to dev_* prints

On Tue, Jun 28, 2016 at 3:43 PM, Joe Perches wrote: > On Tue, 2016-06-28 at 15:34 -0400, Jon Mason wrote: >> The bgmac_* print wrappers call dev_* prints with the dev pointer from >> the bcma core. In anticipation of removing the bcma requirement for >> this driver, these must

Re: [RFC 3/7] net: ethernet: bgmac: move BCMA MDIO Phy code into a separate file

On Wed, Jun 29, 2016 at 2:46 PM, Andrew Lunn wrote: > On Wed, Jun 29, 2016 at 11:35:28AM -0700, Florian Fainelli wrote: >> On 06/29/2016 07:13 AM, Andrew Lunn wrote: >> > Hi Jon >> > >> > I know you are just refactoring code, but at some point it would be >> > good to take a

Question on i40e PCIe relaxed ordering (RO)

Hi, Running iperf tcp test on 2 sparc systems with i40e connected back to back, I see huge number of 'port.rx_dropped' (on iperf server). Based on past experience with ixgbe, this could very well because of PCIe RO (relaxed ordering) not enabled. I am trying to confirm RO is enabled. i40e

[net-next PATCH v2 2/2] net: samples: pktgen mode samples/tests for qdisc layer

This adds samples for pktgen to use with new mode to inject pkts into the qdisc layer. This also doubles as nice test cases to test any patches against qdisc layer. Signed-off-by: John Fastabend --- .../pktgen/pktgen_bench_xmit_mode_queue_xmit.sh| 70

[net-next PATCH v2 1/2] net: pktgen: support injecting packets for qdisc testing

Add another xmit_mode to pktgen to allow testing xmit functionality of qdiscs. The new mode "queue_xmit" injects packets at __dev_queue_xmit() so that qdisc is called. Signed-off-by: John Fastabend --- net/core/pktgen.c | 42

Re: [PATCH 0/2] brcmfmac: support removing AP interfaces with new fw

On 29 June 2016 at 21:54, Rafał Miłecki wrote: > This is the latest patchset needed to get brcmfmac working reasonably well > with BCM4366. > > Both patches were already sent as V2 RFC (10 days ago), there were no more > comments since then and this is the same code as in V2

[PATCH 2/2] brcmfmac: support removing AP interfaces with "interface_remove"

New firmwares (e.g. 10.10.69.36 for BCM4366) support "interface_remove" for removing interfaces. Try to use this method on cfg80211 request. In case of older firmwares (e.g. 7.35.177.56 for BCM43602 as I tested) this will just result in firmware rejecting command and this won't change any

[PATCH 1/2] brcmfmac: delete interface directly in code that sent fw request

So far when receiving event about in-firmware-interface removal our event worker was notifying listener and afterwards it was removing Linux interface. First of all it was resulting in slightly unexpected order. The listener (del_virtual_intf callback) was (usually) returning with success before

Re: [PATCH] [v6] net: emac: emac gigabit ethernet controller driver

On Wednesday, June 29, 2016 10:46:23 AM CEST Timur Tabi wrote: > Arnd Bergmann wrote: > > Usually drivers try 64-bit mask and 32-bit masks, and the 32 bit > > mask is practically guaranteed to succeed. > > Sure, but in theory, my for-loop is correct, right? Wouldn't there be > some value in

[net-next PATCH 2/2] net: samples: pktgen mode samples/tests for qdisc layer

This adds samples for pktgen to use with new mode to inject pkts into the qdisc layer. This also doubles as nice test cases to test any patches against qdisc layer. Signed-off-by: John Fastabend --- .../pktgen/pktgen_bench_xmit_mode_queue_xmit.sh| 67

[net-next PATCH 1/2] net: pktgen: support injecting packets for qdisc testing

Add another xmit_mode to pktgen to allow testing xmit functionality of qdiscs. The new mode "queue_xmit" injects packets at __dev_queue_xmit() so that qdisc is called. Signed-off-by: John Fastabend --- net/core/pktgen.c | 42

Re: [PATCH v4] fib_rules: Added NLM_F_EXCL support to fib_nl_newrule

On 6/29/16 1:22 AM, Mateusz Bajorski wrote: When adding rule with NLM_F_EXCL flag then check if the same rule exist. If yes then exit with -EEXIST. This is already implemented in iproute2: if (cmd == RTM_NEWRULE) { req.n.nlmsg_flags |= NLM_F_CREATE|NLM_F_EXCL;

[PATCH iproute2] bridge: man: fix STP LISTENING description

Correct the unclear and poorly conjugated STP LISTENING documentation. Signed-off-by: Vivien Didelot --- man/man8/bridge.8 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/man/man8/bridge.8 b/man/man8/bridge.8 index ac42118..8a39673 100644

[PATCH iproute2] bridge: man: fix BPUD typo

s/BPUD/BPDU/ in guard description. Signed-off-by: Vivien Didelot --- man/man8/bridge.8 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/man/man8/bridge.8 b/man/man8/bridge.8 index 8a39673..ef4f83e 100644 --- a/man/man8/bridge.8 +++

net.git commit 3bb549ae4c51

Hi, I'm getting ready with the next installment of changes to rds-tcp for mprds, and I noticed that commit 3bb549ae4c51 ("RDS: TCP: rds_tcp_accept_one() should transition socket from RESETTING to UP") has not made its way to net-next. I also noticed that (even though this is a one-liner), this

[PATCH net v3] usbnet: Stop RX Q on MTU change

When MTU is changed unlink_urbs() flushes RX Q but mean while usbnet_bh() can fill up the Q at the same time. Depends on which HCD is down there unlink takes long time then the flush never ends. Signed-off-by: Soohoon Lee Reviewed-by: Kimball Murray ---

Re: [RFC 0/7] net: ethernet: bgmac: Add platform device support

On 06/28/2016 12:34 PM, Jon Mason wrote: > I'm sending out this RFC to see if this is the direction the maintainers > would like to go to add support for other, non-bcma iProc SoC's to the > bgmac driver. Specifically, we are interested in adding support for the > NSP, Cygnus, and NS2 families

Re: [RFC 5/7] net: ethernet: bgmac: Add platform device support

On 06/28/2016 12:34 PM, Jon Mason wrote: > The bcma portion of the driver has been split off into a bcma specific > driver. This has been mirrored for the platform driver. The last > references to the bcma core struct have been changed into a generic > function call. These function calls are

[PATCH] ipv4: Fix ip_skb_dst_mtu to use the sk passed by ip_finish_output

ip_skb_dst_mtu uses skb->sk, assuming it is an AF_INET socket (e.g. it calls ip_sk_use_pmtu which casts sk as an inet_sk). However, in the case of UDP tunneling, the skb->sk is not necessarily an inet socket (could be AF_PACKET socket, or AF_UNSPEC if arriving from tun/tap). OTOH, the sk passed

Re: [RFC 3/7] net: ethernet: bgmac: move BCMA MDIO Phy code into a separate file

On Wed, Jun 29, 2016 at 11:35:28AM -0700, Florian Fainelli wrote: > On 06/29/2016 07:13 AM, Andrew Lunn wrote: > > Hi Jon > > > > I know you are just refactoring code, but at some point it would be > > good to take a closer look at this MDIO bus driver. > And, to re-iterate all of your points

[PATCH net v2.3] usbnet: Stop RX Q on MTU change

When MTU is changed unlink_urbs() flushes RX Q but mean while usbnet_bh() can fill up the Q at the same time. Depends on which HCD is down there unlink takes long time then the flush never ends. Signed-off-by: Soohoon Lee Reviewed-by: Kimball Murray ---

Re: [RFC 6/7] dt-bindings: net: bgmac: add bindings documentation for bgmac

On 06/28/2016 12:34 PM, Jon Mason wrote: > Signed-off-by: Jon Mason > --- > .../devicetree/bindings/net/brcm,bgmac-enet.txt | 21 > + > 1 file changed, 21 insertions(+) > create mode 100644

Re: [RFC 3/7] net: ethernet: bgmac: move BCMA MDIO Phy code into a separate file

On 06/29/2016 07:13 AM, Andrew Lunn wrote: > Hi Jon > > I know you are just refactoring code, but at some point it would be > good to take a closer look at this MDIO bus driver. > > The MDIO bus driver should be generic, allowing access to all 32 > addresses on the bus, if that makes sense. You

[PATCH v4 iproute2 2/6] ip link/addr: Add support for vrf keyword

Add vrf keyword to 'ip link' and 'ip addr' commands (common list code). Allows: 1. Adding a link to a VRF $ ip link set NAME vrf NAME Removing a link from a VRF still uses 'ip link set NAME nomaster' 2. Showing links associated with a VRF: $ ip link show vrf NAME 3. List

[PATCH v4 iproute2 4/6] ip route: Change type mask to bitmask

Allow option to select multiple route types to show or exlude specific route types. Signed-off-by: David Ahern --- ip/iproute.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/ip/iproute.c b/ip/iproute.c index 8224d7ffa94b..aae693d17be8

[PATCH v4 iproute2 0/6] Add support for vrf keyword

Currently the syntax for VRF related commands is rather kludgy and inconsistent from one subcommand to another. This set adds support for the VRF keyword to the link, address, neigh, and route commands to improve the user experience listing data associated with vrfs, modifying routes or doing a

[PATCH v4 iproute2 6/6] ip route: Add support for vrf keyword

Add vrf keyword to 'ip route' commands. Allows: 1. Users can list routes by VRF name: $ ip route show vrf NAME VRF tables have all routes including local and broadcast routes. The VRF keyword filters LOCAL and BROADCAST routes; to see all routes the table option can be used. Or to

[PATCH v4 iproute2 3/6] ip neigh: Add support for keyword

Add vrf keyword to 'ip neigh' commands. Allows listing neighbor entries for all links associated with a given VRF. Signed-off-by: David Ahern --- ip/ipneigh.c| 14 +- man/man8/ip-neighbour.8 | 8 +++- 2 files changed, 20 insertions(+), 2

[PATCH v4 iproute2 5/6] ip vrf: Add ipvrf_get_table

Add ipvrf_get_table to lookup table id for device name. Returns 0 on any error or if name is not a VRF device. Signed-off-by: David Ahern --- ip/ip_common.h | 1 + ip/iplink_vrf.c | 63 + 2 files changed, 64

[PATCH v4 iproute2 1/6] ip vrf: Add name_is_vrf

Add name_is_vrf function to determine if given name corresponds to a VRF device. Signed-off-by: David Ahern --- ip/ip_common.h | 2 ++ ip/iplink_vrf.c | 50 ++ 2 files changed, 52 insertions(+) diff --git

[PATCH v3 iproute2 1/6] ip vrf: Add name_is_vrf

Add name_is_vrf function to determine if given name corresponds to a VRF device. Signed-off-by: David Ahern --- ip/ip_common.h | 2 ++ ip/iplink_vrf.c | 50 ++ 2 files changed, 52 insertions(+) diff --git

[PATCH v3 iproute2 2/6] ip link/addr: Add support for vrf keyword

Add vrf keyword to 'ip link' and 'ip addr' commands (common list code). Allows: 1. Adding a link to a VRF $ ip link set NAME vrf NAME Removing a link from a VRF still uses 'ip link set NAME nomaster' 2. Showing links associated with a VRF: $ ip link show vrf NAME 3. List

[PATCH v3 iproute2 0/6] Add support for vrf keyword

Currently the syntax for VRF related commands is rather kludgy and inconsistent from one subcommand to another. This set adds support for the VRF keyword to the link, address, neigh, and route commands to improve the user experience listing data associated with vrfs, modifying routes or doing a

[PATCH v3 iproute2 4/6] ip route: Change type mask to bitmask

Allow option to select multiple route types to show or exlude specific route types. Signed-off-by: David Ahern --- ip/iproute.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/ip/iproute.c b/ip/iproute.c index 8224d7ffa94b..aae693d17be8

[PATCH v3 iproute2 5/6] ip vrf: Add ipvrf_get_table

Add ipvrf_get_table to lookup table id for device name. Returns 0 on any error or if name is not a VRF device. Signed-off-by: David Ahern --- ip/ip_common.h | 1 + ip/iplink_vrf.c | 66 + 2 files changed, 67

[PATCH v3 iproute2 6/6] ip route: Add support for vrf keyword

Add vrf keyword to 'ip route' commands. Allows: 1. Users can list routes by VRF name: $ ip route show vrf NAME VRF tables have all routes including local and broadcast routes. The VRF keyword filters LOCAL and BROADCAST routes; to see all routes the table option can be used. Or to

[PATCH v3 iproute2 3/6] ip neigh: Add support for keyword

Add vrf keyword to 'ip neigh' commands. Allows listing neighbor entries for all links associated with a given VRF. Signed-off-by: David Ahern --- ip/ipneigh.c| 14 +- man/man8/ip-neighbour.8 | 8 +++- 2 files changed, 20 insertions(+), 2

Re: [PATCH v2 iproute2 0/6] Add support for vrf keyword

On 6/29/16 9:07 AM, Stephen Hemminger wrote: On Mon, 27 Jun 2016 11:50:55 -0700 David Ahern wrote: Currently the syntax for VRF related commands is rather kludgy and inconsistent from one subcommand to another. This set adds support for the VRF keyword to the link,

Re: [PATCH iproute2 1/6] ip vrf: Add name_is_vrf

On 6/29/16 9:06 AM, Stephen Hemminger wrote: On Mon, 27 Jun 2016 11:50:56 -0700 David Ahern wrote: diff --git a/ip/ip_common.h b/ip/ip_common.h index e8da9e034b15..410eb135774a 100644 --- a/ip/ip_common.h +++ b/ip/ip_common.h @@ -90,6 +90,8 @@ struct link_util

Re: [PATCH v2 net-next] tcp: md5: use kmalloc() backed scratch areas

On Wed, Jun 29, 2016 at 8:38 AM, Herbert Xu wrote: > On Wed, Jun 29, 2016 at 08:26:43AM -0700, Andy Lutomirski wrote: >> >> Two reasons: >> >> 1. Code like tcp md5 would be simpler if it could pass a scatterlist >> to hash the skb but use a virtual address for the

Re: [PATCH net-next 08/16] net/devlink: Add E-Switch mode control

On 16-06-29 07:48 AM, Or Gerlitz wrote: > On 6/28/2016 10:31 PM, John Fastabend wrote: >> On 16-06-28 12:12 PM, Jiri Pirko wrote: >>> >>> Why?! Please, leave legacy be legacy. Use the new mode for >>> implementing new features. Don't make things any more complicated :( >>> >> OK so how I read this

Re: [net 2/2] ixgbevf: ixgbevf_write/read_posted_mbx should use IXGBE_ERR_MBX to initialize ret_val

On Wed, 2016-06-29 at 09:30 -0700, Jeff Kirsher wrote: > From: Xin Long > > Now ixgbevf_write/read_posted_mbx use -IXGBE_ERR_MBX as the initiative > return value, but it's incorrect, cause in ixgbevf_vlan_rx_add_vid(), > it use err == IXGBE_ERR_MBX, the err returned from

  1   2   3   >