Re: [PATCH v5 05/11] drivers: net: phy: xgene: Add MDIO driver

On July 7, 2016 4:02:53 PM MST, Iyappan Subramanian wrote: >Currently, SGMII based 1G rely on the hardware registers for link state >and sometimes it's not reliable. To get most accurate link state, this >interface has to use the MDIO bus to poll the PHY. > >In X-Gene SoC,

Re: XDP seeking input from NIC hardware vendors

On Thu, Jul 07, 2016 at 09:05:29PM -0700, John Fastabend wrote: > On 16-07-07 07:22 PM, Alexei Starovoitov wrote: > > On Thu, Jul 07, 2016 at 03:18:11PM +, Fastabend, John R wrote: > >> Hi Jesper, > >> > >> I have done some previous work on proprietary systems where we > >> used hardware to do

Re: [PATCH v6 12/12] net/mlx4_en: add prefetch in xdp rx path

On Fri, Jul 08, 2016 at 05:56:31AM +0200, Eric Dumazet wrote: > On Thu, 2016-07-07 at 19:15 -0700, Brenden Blanco wrote: > > XDP programs read and/or write packet data very early, and cache miss is > > seen to be a bottleneck. > > > > Add prefetch logic in the xdp case 3 packets in the future.

Re: XDP seeking input from NIC hardware vendors

On 16-07-07 07:22 PM, Alexei Starovoitov wrote: > On Thu, Jul 07, 2016 at 03:18:11PM +, Fastabend, John R wrote: >> Hi Jesper, >> >> I have done some previous work on proprietary systems where we >> used hardware to do the classification/parsing then passed a cookie to the >> software which

Re: [RFC 5/7] net: Add allocation flag to rtnl_unicast()

On Fri, 2016-07-08 at 12:15 +0900, Masashi Honma wrote: = > Thanks for comment. > > I have selected GFP flags based on existing code. > > I have selected GFP_ATOMIC in inet6_netconf_get_devconf() because > skb was allocated with GFP_ATOMIC. Point is : we should remove GFP_ATOMIC uses as much as

Re: [PATCH v6 12/12] net/mlx4_en: add prefetch in xdp rx path

On Thu, 2016-07-07 at 19:15 -0700, Brenden Blanco wrote: > XDP programs read and/or write packet data very early, and cache miss is > seen to be a bottleneck. > > Add prefetch logic in the xdp case 3 packets in the future. Throughput > improved from 10Mpps to 12.5Mpps. LLC misses as reported by

[PATCH net-next] ipv6: do not abuse GFP_ATOMIC in inet6_netconf_notify_devconf()

From: Eric Dumazet All inet6_netconf_notify_devconf() callers are in process context, so we can use GFP_KERNEL allocations if we take care of not holding a rwlock while not needed in ip6mr (we hold RTNL there) Fixes: d67b8c616b48 ("netconf: advertise mc_forwarding status")

RE: [PATCH 2/4] soc: fsl: add GUTS driver for QorIQ platforms

Hi Arnd, > -Original Message- > From: Arnd Bergmann [mailto:a...@arndb.de] > Sent: Thursday, July 07, 2016 4:30 PM > To: Yangbo Lu > Cc: Scott Wood; linuxppc-...@lists.ozlabs.org; Mark Rutland; Ulf Hansson; > linux-ker...@vger.kernel.org; linux-...@vger.kernel.org; linux- >

[PATCH net-next] ipv4: do not abuse GFP_ATOMIC in inet_netconf_notify_devconf()

From: Eric Dumazet inet_forward_change() runs with RTNL held. We are allowed to sleep if required. If we use __in_dev_get_rtnl() instead of __in_dev_get_rcu(), we no longer have to use GFP_ATOMIC allocations in inet_netconf_notify_devconf(), meaning we are less likely to

Re: [RFC 5/7] net: Add allocation flag to rtnl_unicast()

On 2016年07月08日 11:56, Eric Dumazet wrote: Managing to mix GFP_ATOMIC and GFP_KERNEL almost randomly as you did in this patch is definitely not good. Further more, RTNL is a mutex, held in control path, designed to allow schedules and waiting for memory under pressure. We do not want to

Re: [PATCH v11 00/22] Add HiSilicon RoCE driver

在 2016/7/2 17:39, Lijun Ou 写道: > The HiSilicon Network Substem is a long term evolution IP which is > supposed to be used in HiSilicon ICT SoCs. HNS (HiSilicon Network > Sybsystem) also has a hardware support of performing RDMA with > RoCEE. > The driver for HiSilicon RoCEE(RoCE Engine) is a

Re: [RFC 5/7] net: Add allocation flag to rtnl_unicast()

On Wed, 2016-07-06 at 09:28 +0900, Masashi Honma wrote: > Signed-off-by: Masashi Honma > --- > diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c > index a1f6b7b..2b0b994 100644 > --- a/net/ipv6/addrconf.c > +++ b/net/ipv6/addrconf.c > @@ -628,7 +628,7 @@ static int

Re: XDP seeking input from NIC hardware vendors

On Thu, Jul 07, 2016 at 03:18:11PM +, Fastabend, John R wrote: > Hi Jesper, > > I have done some previous work on proprietary systems where we used hardware > to do the classification/parsing then passed a cookie to the software which > used the cookie to lookup a program to run on the

[PATCH v6 08/12] net/mlx4_en: break out tx_desc write into separate function

In preparation for writing the tx descriptor from multiple functions, create a helper for both normal and blueflame access. Signed-off-by: Brenden Blanco --- drivers/infiniband/hw/mlx4/qp.c| 11 +-- drivers/net/ethernet/mellanox/mlx4/en_tx.c | 127

[PATCH v6 05/12] Add sample for adding simple drop program to link

Add a sample program that only drops packets at the BPF_PROG_TYPE_XDP_RX hook of a link. With the drop-only program, observed single core rate is ~20Mpps. Other tests were run, for instance without the dropcnt increment or without reading from the packet header, the packet rate was mostly

[PATCH v6 11/12] bpf: add sample for xdp forwarding and rewrite

Add a sample that rewrites and forwards packets out on the same interface. Observed single core forwarding performance of ~10Mpps. Since the mlx4 driver under test recycles every single packet page, the perf output shows almost exclusively just the ring management and bpf program work. Slowdowns

[PATCH v6 09/12] net/mlx4_en: add xdp forwarding and data write support

A user will now be able to loop packets back out of the same port using a bpf program attached to xdp hook. Updates to the packet contents from the bpf program is also supported. For the packet write feature to work, the rx buffers are now mapped as bidirectional when the page is allocated. This

[PATCH v6 02/12] net: add ndo to set xdp prog in adapter rx

Add two new set/check netdev ops for drivers implementing the BPF_PROG_TYPE_XDP filter. Signed-off-by: Brenden Blanco --- include/linux/netdevice.h | 14 ++ net/core/dev.c| 30 ++ 2 files changed, 44 insertions(+) diff

[PATCH v6 10/12] bpf: enable direct packet data write for xdp progs

For forwarding to be effective, XDP programs should be allowed to rewrite packet data. This requires that the drivers supporting XDP must all map the packet memory as TODEVICE or BIDIRECTIONAL before invoking the program. Signed-off-by: Brenden Blanco ---

[PATCH v6 06/12] net/mlx4_en: add page recycle to prepare rx ring for tx support

The mlx4 driver by default allocates order-3 pages for the ring to consume in multiple fragments. When the device has an xdp program, this behavior will prevent tx actions since the page must be re-mapped in TODEVICE mode, which cannot be done if the page is still shared. Start by making the

[PATCH v6 12/12] net/mlx4_en: add prefetch in xdp rx path

XDP programs read and/or write packet data very early, and cache miss is seen to be a bottleneck. Add prefetch logic in the xdp case 3 packets in the future. Throughput improved from 10Mpps to 12.5Mpps. LLC misses as reported by perf stat reduced from ~14% to ~7%. Prefetch values of 0 through 5

[PATCH v6 04/12] net/mlx4_en: add support for fast rx drop bpf program

Add support for the BPF_PROG_TYPE_XDP hook in mlx4 driver. In tc/socket bpf programs, helpers linearize skb fragments as needed when the program touchs the packet data. However, in the pursuit of speed, XDP programs will not be allowed to use these slower functions, especially if it involves

[PATCH v6 07/12] bpf: add XDP_TX xdp_action for direct forwarding

XDP enabled drivers must transmit received packets back out on the same port they were received on when a program returns this action. Signed-off-by: Brenden Blanco --- include/uapi/linux/bpf.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/uapi/linux/bpf.h

[PATCH v6 03/12] rtnl: add option for setting link xdp prog

Sets the bpf program represented by fd as an early filter in the rx path of the netdev. The fd must have been created as BPF_PROG_TYPE_XDP. Providing a negative value as fd clears the program. Getting the fd back via rtnl is not possible, therefore reading of this value merely provides a bool

[PATCH v6 01/12] bpf: add XDP prog type for early driver filter

Add a new bpf prog type that is intended to run in early stages of the packet rx path. Only minimal packet metadata will be available, hence a new context type, struct xdp_md, is exposed to userspace. So far only expose the packet start and end pointers, and only in read mode. An XDP program must

[PATCH v6 00/12] Add driver bpf hook for early packet drop and forwarding

This patch set introduces new infrastructure for programmatically processing packets in the earliest stages of rx, as part of an effort others are calling eXpress Data Path (XDP) [1]. Start this effort by introducing a new bpf program type for early packet filtering, before even an skb has been

Re: [PATCH net] bonding: fix 802.3ad aggregator reselection

Veli-Matti Lintu wrote: >2016-07-06 0:20 GMT+03:00 Jay Vosburgh : >> Veli-Matti Lintu wrote: >> >>>2016-06-30 14:15 GMT+03:00 Veli-Matti Lintu : 2016-06-29 18:59 GMT+03:00 Jay

Re: linux-next: build warning after merge of the wireless-drivers-next tree

Hi all, On Fri, 8 Jul 2016 11:32:14 +1000 Stephen Rothwell wrote: > > After merging the wireless-drivers-next tree, today's linux-next build > (arm multi_v7_defconfig, x86_64 allmodconfig) produced this warning: > > drivers/net/wireless/marvell/mwifiex/scan.c: In

linux-next: build warning after merge of the wireless-drivers-next tree

Hi all, After merging the wireless-drivers-next tree, today's linux-next build (arm multi_v7_defconfig, x86_64 allmodconfig) produced this warning: drivers/net/wireless/marvell/mwifiex/scan.c: In function 'mwifiex_cancel_scan': drivers/net/wireless/marvell/mwifiex/scan.c:2031:44: warning:

Re: [PATCH 2/2] net: ethernet: bcmgenet: use phy_ethtool_{get|set}_link_ksettings

On 07/05/2016 02:07 PM, Philippe Reynes wrote: > Hi Florian, > > On 05/07/16 06:30, Florian Fainelli wrote: >> Le 04/07/2016 16:03, David Miller a écrit : >>> From: Philippe Reynes >>> Date: Sun, 3 Jul 2016 17:33:57 +0200 >>> There are two generics functions

Re: [PATCH net-next 00/10] NCSI Support

On Thu, Jul 07, 2016 at 10:32:12AM -0700, Florian Fainelli wrote: >On 07/02/2016 10:32 PM, Gavin Shan wrote: >> This series rebases on David's linux-net git repo ("master" branch). It's >> to support NCSI stack on net/farady/ftgmac100.c >> >> The following figure gives an example about how NCSI

RE: [Intel-wired-lan] [PATCH] (resend) ixgbe: always initialize setup_fc

>-Original Message- >From: Intel-wired-lan [mailto:intel-wired-lan-boun...@lists.osuosl.org] On >Behalf Of Rustad, Mark D >Sent: Wednesday, July 06, 2016 4:01 PM >To: Patrick McLean >Cc: netdev ; intel-wired-lan l...@lists.osuosl.org> >Subject:

[PATCH v2 2/2] libxt_hashlimit: Create revision 2 of xt_hashlimit to support higher pps rates

* Added two tests for 100pps support to libxt_hashlimit.t * cfg_copy returns -EINVAL and all callers of cfg_copy will look for the error value -- libxt_hashlimit: Create revision 2 of xt_hashlimit to support higher pps rates Create a new revision for the hashlimit iptables extension

[PATCH v2 1/2] libxt_hashlimit: Prepare libxt_hashlimit.c for revision 2

I am planning to add a revision 2 for the hashlimit xtables module to support higher packets per second rates. This patch renames all the functions and variables related to revision 1 by adding _v1 at the end of the names. Signed-off-by: Vishwanath Pai Signed-off-by: Joshua Hunt

[PATCH v2 2/2] netfilter: Create revision 2 of xt_hashlimit to support higher pps rates

Removed the call to BUG() in cfg_copy, we return -EINVAL instead and all calls to cfg_copy check for this -- netfilter: Create revision 2 of xt_hashlimit to support higher pps rates Create a new revision for the hashlimit iptables extension module. Rev 2 will support higher pps of upto 1

[PATCH v2 1/2] netfilter: Prepare xt_hashlimit.c for revision 2

I am planning to add a revision 2 for the hashlimit xtables module to support higher packets per second rates. This patch renames all the functions and variables related to revision 1 by adding _v1 at the end of the names. Signed-off-by: Vishwanath Pai Signed-off-by: Joshua Hunt

Re: Resurrecting due to huge ipoib perf regression - [BUG] skb corruption and kernel panic at forwarding with fragmentation

On Thu, Jul 07, 2016 at 03:01:40PM -0700, Roland Dreier wrote: > The reason we moved to the cb storage is that in the past, trying to > hide some data in the actual skb buffer that we don't actually send We have neighbour_priv, and ndo_neigh_construct/destruct now .. A first blush that would

[PATCH v2 4/6] net: ethernet: bgmac: convert to feature flags

The bgmac driver is using the bcma provides device ID and revision, as well as the SoC ID and package, to determine which features are necessary to enable, reset, etc in the driver. In anticipation of removing the bcma requirement for this driver, these must be changed to not reference that

[PATCH v2 5/6] net: ethernet: bgmac: Add platform device support

The bcma portion of the driver has been split off into a bcma specific driver. This has been mirrored for the platform driver. The last references to the bcma core struct have been changed into a generic function call. These function calls are wrappers to either the original bcma code or new

[PATCH v2 0/6] net: ethernet: bgmac: Add platform device support

David Miller, Please consider including patches 1-5 in net-next Florian Fainelli, Please consider including patches 6 & 7 in devicetree/next Changes in v2: * Made device tree binding changes suggested by Sergei Shtylyov, Ray Jui, Rob Herring, Florian Fainelli, and Arnd Bergmann * Removed

[PATCH v2 6/6] dt-bindings: net: bgmac: add bindings documentation for bgmac

Signed-off-by: Jon Mason --- .../devicetree/bindings/net/brcm,amac.txt | 24 ++ .../devicetree/bindings/net/brcm,bgmac-nsp.txt | 24 ++ 2 files changed, 48 insertions(+) create mode 100644

[PATCH v2 1/6] net: ethernet: bgmac: change bgmac_* prints to dev_* prints

The bgmac_* print wrappers call dev_* prints with the dev pointer from the bcma core. In anticipation of removing the bcma requirement for this driver, these must be changed to not reference that struct. So, simply change all of the bgmac_* prints to their dev_* counterparts. In some cases

[PATCH v2 2/6] net: ethernet: bgmac: add dma_dev pointer

The dma buffer allocation, etc references a dma_dev device pointer from the bcma core. In anticipation of removing the bcma requirement for this driver, these must be changed to not reference that struct. Add a dma_dev device pointer to the bgmac stuct and reference that instead. Signed-off-by:

[PATCH v2 3/6] net: ethernet: bgmac: move BCMA MDIO Phy code into a separate file

Move the BCMA MDIO phy into a separate file, as it is very tightly coupled with the BCMA bus. This will help with the upcoming BCMA removal from the bgmac driver. Optimally, this should be moved into phy drivers, but it is too tightly coupled with the bgmac driver to effectively move it without

[PATCH v5 06/11] drivers: net: xgene: Add backward compatibility

This patch adds xgene_enet_check_phy_hanlde() function that checks whether MDIO driver is probed successfully and sets pdata->mdio_driver to true. If MDIO driver is not probed, ethernet driver falls back to backward compatibility mode. Since enum xgene_enet_cmd is used by MDIO driver, removing

[PATCH v5 11/11] MAINTAINERS: xgene: Add driver and documentation path

Added path to the MDIO driver and Documentation file. Signed-off-by: Iyappan Subramanian --- MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 6374be2..a2ce997 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -839,7 +839,9 @@ M:

[PATCH v5 09/11] dtb: xgene: Add MDIO node

Added mdio node for mdio driver. Also added phy-handle reference to the ethernet nodes. Removed unused mdio subnode within storm menet ethernet node. Removed unused clock node from storm sgenet1. Signed-off-by: Iyappan Subramanian Tested-by: Fushen Chen

[PATCH v5 08/11] drivers: net: xgene: ethtool: Use phy_ethtool_gset and sset

Changed SGMII 1G get_settings to use phy_ethtool_gset. Changed SGMII 1G set_settings to use phy_ethtool_sset. Signed-off-by: Iyappan Subramanian Tested-by: Fushen Chen Tested-by: Toan Le --- .../net/ethernet/apm/xgene/xgene_enet_ethtool.c

[PATCH v5 04/11] drivers: net: xgene: Fix module unload crash - clkrst sequence

This patch fixes clock reset sequence. - Added clock reset sequence for ACPI - Added delay in clock reset sequence to make sure pulse is generated - Added clk_unprepare_disable() in port shutdown to make sure clock increment/decrement counts are matching - Removed MII_MGMT_CONFIG programming,

[PATCH v5 10/11] Documentation: dtb: xgene: Add MDIO node

Signed-off-by: Iyappan Subramanian Tested-by: Fushen Chen Tested-by: Toan Le Tested-by: Matthias Brugger --- .../devicetree/bindings/net/apm-xgene-mdio.txt | 37 ++ 1 file changed, 37 insertions(+)

[PATCH v5 07/11] drivers: net: xgene: Enable MDIO driver

This patch enables MDIO driver by, - Selecting MDIO_XGENE - Changed open and close to use phy_start and phy_stop - Changed to use mac_ops->tx(rx)_enable and tx(rx)_disable Signed-off-by: Iyappan Subramanian Tested-by: Fushen Chen Tested-by: Toan Le

[PATCH v5 03/11] drivers: net: xgene: Fix module unload crash - change sw sequence

When the driver is configured as kernel module and when it gets unloaded and reloaded, kernel crash was observed. This patch addresses the software cleanup by doing the following, - Moved register_netdev call after hardware is ready - Since ndev is not ready, added set_irq_name to set irq name -

[PATCH v5 05/11] drivers: net: phy: xgene: Add MDIO driver

Currently, SGMII based 1G rely on the hardware registers for link state and sometimes it's not reliable. To get most accurate link state, this interface has to use the MDIO bus to poll the PHY. In X-Gene SoC, MDIO bus is shared across RGMII and SGMII based 1G interfaces, so adding this driver to

[PATCH v5 02/11] drivers: net: xgene: Fix module unload crash - hw resource cleanup

When the driver is configured as kernel module and when it gets unloaded and reloaded, kernel crash was observed. This patch address the hardware resource cleanups by doing the following, - Added mac_ops->clear() to do prefetch buffer clean up - Fixed delete freepool buffers logic - Reordered

[PATCH v5 01/11] drivers: net: xgene: Separate set_speed from mac_init

Since mac_init is too heavy to be called when the link changes, moved the speed_set configuration to a new function and added mac_ops->set_speed function pointer. This function will be called from adjust_link callback. Added cases for 10/100 support for SGMII based 1G interface. Signed-off-by:

[PATCH v5 00/11] drivers: net: xgene: Fix module crash and 1G hot-plug

This patchset addresses the following issues, 1. Fixes the kernel crash when the driver loaded as an kernel module - by fixing hardware cleanups and rearrange kernel API calls 2. Hot-plug issue on the SGMII 1G interface - by adding a driver for MDIO management Signed-off-by:

Re: [PATCH v2 3/5] drivers: net: phy: Add MDIO driver

Hi Russell, On Thu, Jul 7, 2016 at 7:14 AM, Russell King - ARM Linux wrote: > On Thu, Jul 07, 2016 at 04:03:02PM +0200, Andrew Lunn wrote: >> > Wed, Jul 06, 2016 at 04:44:44PM -0700, Iyappan Subramanian wrote: >> > Hi Andrew, >> > >> > On Tue, Jul 5, 2016 at 6:49 AM,

Re: [RFC PATCH v2] net: sched: convert qdisc linked list to hashtable

On Thu, Jul 7, 2016 at 4:36 PM, Jiri Kosina wrote: > From: Jiri Kosina > > Convert the per-device linked list into a hashtable. The primary > motivation for this change is that currently, we're not tracking all the > qdiscs in hierarchy (e.g. excluding default

Re: Resurrecting due to huge ipoib perf regression - [BUG] skb corruption and kernel panic at forwarding with fragmentation

On Thu, Jul 7, 2016 at 3:01 PM, Roland Dreier wrote: >>> struct skb_gso_cb { >>> int mac_offset; >>> int encap_level; >>> __u16 csum_start; >>> }; > >> This is based on an out-dated version of this struct. The 4.7 RC >> kernel has a few

Re: [PATCH v2 3/5] drivers: net: phy: Add MDIO driver

Hi Andrew, On Thu, Jul 7, 2016 at 7:03 AM, Andrew Lunn wrote: >> Wed, Jul 06, 2016 at 04:44:44PM -0700, Iyappan Subramanian wrote: >> Hi Andrew, >> >> On Tue, Jul 5, 2016 at 6:49 AM, Andrew Lunn wrote: >> > On Mon, Jun 06, 2016 at 10:12:35AM -0700, Iyappan

Re: [PATCH 6/7] dt-bindings: net: bgmac: add bindings documentation for bgmac

On Wed, Jul 6, 2016 at 3:34 AM, Arnd Bergmann wrote: > On Tuesday, July 5, 2016 7:18:45 PM CEST Jon Mason wrote: >> > >> > Ok, then I'd suggest making the compatible string here >> > >> > compatible = "brcm,nsp-amac", "brcm,amac"; >> >> It is called GMAC in the NS and NSP

Re: [PATCH net-next 00/10] NCSI Support

On Thu, 2016-07-07 at 10:32 -0700, Florian Fainelli wrote: > > I know nothing about NCSI, pretty much like Jon Snow, but from a cursory > look at your patches, is not there a way to make the NCSCI capable > network devices strictly adhere to the net_device APIs and calling > conventions? They

Re: Resurrecting due to huge ipoib perf regression - [BUG] skb corruption and kernel panic at forwarding with fragmentation

>> struct skb_gso_cb { >> int mac_offset; >> int encap_level; >> __u16 csum_start; >> }; > This is based on an out-dated version of this struct. The 4.7 RC > kernel has a few more fields that were added to support local checksum > offload for encapsulated

Re: XDP seeking input from NIC hardware vendors

On 16-07-07 10:53 AM, Tom Herbert wrote: > On Thu, Jul 7, 2016 at 9:12 AM, Jakub Kicinski > wrote: >> On Thu, 7 Jul 2016 15:18:11 +, Fastabend, John R wrote: >>> The other interesting thing would be to do more than just packet >>> steering but actually run a more

[PATCH v2] Add support for configuring Infiniband GUIDs

Add two NLA's that allow configuration of Infiniband node or port GUIDs by referencing the IPoIB net device set over the physical function. The format to be used is as follows: ip link set dev ib0 vf 0 node_guid 00:02:c9:03:00:21:6e:70 ip link set dev ib0 vf 0 port_guid 00:02:c9:03:00:21:6e:78

Re: [ovs-dev] [PATCH net-next v11 5/6] openvswitch: add layer 3 flow/port support

On Wed, Jul 6, 2016 at 10:59 AM, Simon Horman wrote: > From: Lorand Jakab > > Implementation of the pop_eth and push_eth actions in the kernel, and > layer 3 flow support. > > This doesn't actually do anything yet as no layer 2 tunnel ports are >

Re: [ovs-dev] [PATCH net-next v11 4/6] openvswitch: add support to push and pop mpls for layer3 packets

On Wed, Jul 6, 2016 at 10:59 AM, Simon Horman wrote: > Allow push and pop mpls actions to act on layer 3 packets by teaching > them not to access non-existent L2 headers of such packets. > > Signed-off-by: Simon Horman > --- > v11 > * group

Re: [ovs-dev] [PATCH net-next v11 3/6] openvswitch: set skb protocol and mac_len when receiving on internal device

On Wed, Jul 6, 2016 at 10:59 AM, Simon Horman wrote: > * Set skb protocol based on contents of packet. I have observed this is > necessary to get actual protocol of a packet when it is injected into an > internal device e.g. by libnet in which case skb protocol

Re: [ovs-dev] [PATCH net-next v11 2/6] gre: unset mac header for non-TEB packets received by ipgre device

On Wed, Jul 6, 2016 at 10:59 AM, Simon Horman wrote: > unset rather than reset mach header for non-TEB packets received by an > ipgre device. This allows skb_transport_header_was_set to be subsequently > used to differentiate TEB and non-TEB packets recieved on an

Re: [ovs-dev] [PATCH net-next v11 1/6] net: introduce skb_transport_header_was_set()

On Wed, Jul 6, 2016 at 10:59 AM, Simon Horman wrote: > This helper resets the mac_header of an skb to a state where > skb_transport_header_was_set() will return false. > > This is intended to be used with packets received on > ARPHRD_NONE devices without an Ethernet

Re: [PATCH 2/4] soc: fsl: add GUTS driver for QorIQ platforms

On Thu, 2016-07-07 at 10:30 +0200, Arnd Bergmann wrote: > On Thursday, July 7, 2016 2:35:33 AM CEST Yangbo Lu wrote: > > > > Hi Arnd, > > > > Could you reply when you see the email? > > If your method doesn’t resolve the problem, we still want to use our old > > patchset. > > > > This guts

[RFC PATCH v2] net: sched: convert qdisc linked list to hashtable

From: Jiri Kosina Convert the per-device linked list into a hashtable. The primary motivation for this change is that currently, we're not tracking all the qdiscs in hierarchy (e.g. excluding default qdiscs), as the lookup performed over the linked list by

Re: [PATCH net] bonding: fix 802.3ad aggregator reselection

2016-07-06 0:20 GMT+03:00 Jay Vosburgh : > Veli-Matti Lintu wrote: > >>2016-06-30 14:15 GMT+03:00 Veli-Matti Lintu : >>> 2016-06-29 18:59 GMT+03:00 Jay Vosburgh : Veli-Matti

Re: [PATCH net-next 2/4] net/mlx4: Preparation for VST QinQ

On Wed, Jul 6, 2016 at 3:29 PM, Tariq Toukan wrote: > From: Moshe Shemesh > > Check device capability to support VST QinQ mode. > Add vport attribute vlan protocol. > Init vport vlan protocol by default to 802.1Q. > Add update QP support for VST QinQ. >

Re: [PATCH net-next 4/4] net/mlx4_core: Add an option to configure SVLAN TPID

On Wed, Jul 6, 2016 at 3:29 PM, Tariq Toukan wrote: > From: Moshe Shemesh > > Expose mlx4_config_svlan_tpid, that checks for feature support > in device capabilities and sets the Service Tag TPID accordingly. I Googled for service tag TPID and I

Re: [PATCH] mwifiex: mask PCIe interrupts before removal

Brian Norris writes: > Hi, > > On Thu, Jun 30, 2016 at 03:21:02PM -0700, Brian Norris wrote: >> The PCIe driver didn't mask the host interrupts before trying to tear >> down. This causes lockups at reboot or rmmod when using MSI-X on 8997, >> since the MSI handler gets

Re: [PATCH net 3/4] ibmvnic: simplify and improve driver probe function

On 07/06/2016 03:35 PM, Thomas Falcon wrote: > @@ -3560,6 +3608,7 @@ static const struct file_operations ibmvnic_dump_ops = { > > static int ibmvnic_probe(struct vio_dev *dev, const struct vio_device_id *id) > { > + unsigned long timeout = msecs_to_jiffies(3); > struct

Re: [PATCH net-next 1/4] net/mlx4_core: Fix QUERY FUNC CAP flags

On Wed, Jul 6, 2016 at 3:29 PM, Tariq Toukan wrote: > From: Moshe Shemesh > > Separate QUERY_FUNC_CAP flags0 from QUERY_FUNC_CAP flags. > Remove QUERY_FUNC_CAP port_flags field which was not in use. The patch title says "Fix ..." but the change log

Re: [PATCH net-next 3/4] net: Add VST QinQ support

On Wed, Jul 6, 2016 at 3:29 PM, Tariq Toukan wrote: > From: Moshe Shemesh > Enable activating VST QinQ mode by IP Link tool. > Add parameter vlan protocol to the function ndo_set_vf_vlan. > Vlan protocol by default is 802.1Q, setting vf vlan protocol to

[PATCH nf-next] ipvs: count pre-established TCP states as active

From: Michal Kubecek Some users observed that "least connection" distribution algorithm doesn't handle well bursts of TCP connections from reconnecting clients after a node or network failure. This is because the algorithm counts active connection as worth 256 inactive ones

Re: Removing lots of IS_ERR_VALUE abuses and compilation warning.

Yes, You are right, -Now Return type of 'qe_muram_alloc' is 'unsigned long', That Was trying to assigned in member of this structure 'ucc_geth_private' . This structure variable are 'unsigned int'. So before assignment need a proper type casting. -Passing value in IS_ERR_VALUE() is wrong.

Re: Resurrecting due to huge ipoib perf regression - [BUG] skb corruption and kernel panic at forwarding with fragmentation

On Wed, Jul 6, 2016 at 11:25 PM, Roland Dreier wrote: > On Thu, Jan 7, 2016 at 3:00 AM, Konstantin Khlebnikov > wrote: >> Or just shift GSO CB and add couple checks like >> BUILD_BUG_ON(sizeof(SKB_GSO_CB(skb)->room) < sizeof(*IPCB(skb))); > >

[GIT PULL nf-next] IPVS Updates for v4.8

Hi Pablo, please consider these enhancements to the IPVS. This alters the behaviour of the "least connection" schedulers such that pre-established connections are included in the active connection count. This avoids overloading servers when a large number of new connections arrive in a short

[PATCH] Need proper type casting before assignment, Remove compilation Warning.

-Return type of 'qe_muram_alloc' is 'unsigned long', That Was trying to assigned in ucc_fast_tx_virtual_fifo_base_offset and ucc_fast_rx_virtual_fifo_base_offset. These variable are 'unsigned int'. So before assginment need a proper type casting. -Passing value in IS_ERR_VALUE() is wrong, as they

[PATCH nf] ipvs: fix bind to link-local mcast IPv6 address in backup

From: Quentin Armitage When using HEAD from https://git.kernel.org/cgit/utils/kernel/ipvsadm/ipvsadm.git/, the command: ipvsadm --start-daemon backup --mcast-interface eth0.60 \ --mcast-group ff02::1:81 fails with the error message: Argument list too long whereas

[GIT PULL nf] Second Round of IPVS Fixes for v4.7

Hi Pablo, please consider this IPVS fix for v4.7. The fix from Quentin Armitage allows the backup sync daemon to be bound to a link-local mcast IPv6 address as is already the case for IPv4. The following changes since commit 62131e5d735226074cba53095545d76b491e5003: netfilter: nft_meta: set

Re: [PATCH] mwifiex: mask PCIe interrupts before removal

Hi, On Thu, Jun 30, 2016 at 03:21:02PM -0700, Brian Norris wrote: > The PCIe driver didn't mask the host interrupts before trying to tear > down. This causes lockups at reboot or rmmod when using MSI-X on 8997, > since the MSI handler gets confused and locks up the system. > > Also tested on

Re: [PATCH net-next v2 3/4] net: dsa: Suffix function manipulating device_node with _dn

On 07/05/2016 06:59 PM, Vivien Didelot wrote: > Hi, > > Florian Fainelli writes: > >> On 07/05/2016 03:36 PM, Andrew Lunn wrote: >>> On Tue, Jul 05, 2016 at 03:07:12PM -0700, Florian Fainelli wrote: Make it clear that these functions take a device_node structure

Re: XDP seeking input from NIC hardware vendors

On Thu, Jul 7, 2016 at 9:12 AM, Jakub Kicinski wrote: > On Thu, 7 Jul 2016 15:18:11 +, Fastabend, John R wrote: >> The other interesting thing would be to do more than just packet >> steering but actually run a more complete XDP program. Netronome >> supports

Re: [PATCH net-next 00/10] NCSI Support

On 07/02/2016 10:32 PM, Gavin Shan wrote: > This series rebases on David's linux-net git repo ("master" branch). It's > to support NCSI stack on net/farady/ftgmac100.c > > The following figure gives an example about how NCSI is deployed: The NCSI is > specified by DSP0222, which can be downloaded

Re: [iproute PATCH 0/2] Netns performance improvements

On 07/07/2016 09:34 AM, Eric W. Biederman wrote: Rick Jones writes: 300 routers is far from the upper limit/goal. Back in HP Public Cloud, we were running as many as 700 routers per network node (*), and more than four network nodes. (back then it was just the one

Re: Removing lots of IS_ERR_VALUE abuses and compilation warning.

On Thu, Jul 07, 2016 at 09:30:14PM +0530, Arvind Yadav wrote: > Passing value in IS_ERR_VALUE() is wrong, as they pass an 'int' > into a function that takes an 'unsigned long' argument.This happens > to work because the type is sign-extended on 64-bit architectures > before it gets converted into

Re: [RFC PATCH] net: sched: convert qdisc linked list to hashtable (was Re: Deleting child qdisc doesn't reset parent to default qdisc?)

On Thu, 2016-07-07 at 18:32 +0200, Jiri Kosina wrote: > On Thu, 7 Jul 2016, Eric Dumazet wrote: > > > > @@ -1440,6 +1441,7 @@ static int tc_dump_qdisc_root(struct Qdisc *root, > > > struct sk_buff *skb, > > > { > > > int ret = 0, q_idx = *q_idx_p; > > > struct Qdisc *q; > > > + int b; > > >

Re: [iproute PATCH 0/2] Netns performance improvements

Rick Jones writes: > On 07/07/2016 08:48 AM, Phil Sutter wrote: >> On Thu, Jul 07, 2016 at 02:59:48PM +0200, Nicolas Dichtel wrote: >>> Le 07/07/2016 13:17, Phil Sutter a écrit : >>> [snip] The issue came up during OpenStack Neutron testing, see this ticket for

Re: [PATCH net-next 00/10] NCSI Support

On Thu, Jul 07, 2016 at 04:44:02PM +0300, Or Gerlitz wrote: >On Thu, Jul 7, 2016 at 12:17 PM, Benjamin Herrenschmidt > wrote: >> On Thu, 2016-07-07 at 12:12 +0300, Or Gerlitz wrote: >>> On Tue, Jul 5, 2016 at 8:44 PM, Alexei Starovoitov >>>

Re: [RFC PATCH] net: sched: convert qdisc linked list to hashtable (was Re: Deleting child qdisc doesn't reset parent to default qdisc?)

On Thu, 7 Jul 2016, Eric Dumazet wrote: > > @@ -1440,6 +1441,7 @@ static int tc_dump_qdisc_root(struct Qdisc *root, > > struct sk_buff *skb, > > { > > int ret = 0, q_idx = *q_idx_p; > > struct Qdisc *q; > > + int b; > > > > if (!root) > > return 0; > > @@ -1454,7

Re: [iproute PATCH 0/2] Netns performance improvements

On 07/07/2016 08:48 AM, Phil Sutter wrote: On Thu, Jul 07, 2016 at 02:59:48PM +0200, Nicolas Dichtel wrote: Le 07/07/2016 13:17, Phil Sutter a écrit : [snip] The issue came up during OpenStack Neutron testing, see this ticket for reference: https://bugzilla.redhat.com/show_bug.cgi?id=1310795

Re: [PATCH net-next 3/4] vxlan: remove gro_cell support

On Thu, 2016-07-07 at 17:58 +0200, Paolo Abeni wrote: > GRO is now handled entirely by the udp_offload layer and there is no need > for trying it again at the device level. We can drop gro_cell usage, > simplifying the driver a bit, while maintaining the same performance for > TCP and improving

Re: XDP seeking input from NIC hardware vendors

On Thu, 7 Jul 2016 15:18:11 +, Fastabend, John R wrote: > The other interesting thing would be to do more than just packet > steering but actually run a more complete XDP program. Netronome > supports this right. The question I have though is this a stacked of > XDP programs one or more

Re: [PATCH v14 net-next 1/1] hv_sock: introduce Hyper-V Sockets

On Thu, Jun 30, Dexuan Cui wrote: > +/* The MTU is 16KB per the host side's design. */ > +struct hvsock_recv_buf { > + unsigned int data_len; > + unsigned int data_offset; > + > + struct vmpipe_proto_header hdr; > + u8 buf[PAGE_SIZE * 4]; Please use some macro related to the

  1   2   >