Re: [RFC PATCH] net: flush the softnet backlog in process context

On Wed, 2016-07-27 at 12:37 +0200, Paolo Abeni wrote: > Currently in process_backlog(), the process_queue dequeuing is > performed with local IRQ disabled, to protect against > flush_backlog(), which runs in hard IRQ context. Thanks guys, patch looks fine to me.

Re: [e1000_netpoll] BUG: sleeping function called from invalid context at kernel/irq/manage.c:110

On Wed, 2016-07-27 at 14:38 -0700, Jeff Kirsher wrote: > On Tue, 2016-07-26 at 11:14 +0200, Eric Dumazet wrote: > > Could you try this ? > > > > diff --git a/drivers/net/ethernet/intel/e1000/e1000_main.c > > b/drivers/net/ethernet/intel/e1000/e1000_main.c > > index > >

Re: [PATCH RFC 1/1] xfrm: dst lookup doesn't account for fwmark

On Fri, Jul 22, 2016 at 03:50:43PM -0600, Doug Applegate wrote: > If route table includes routing based on fwmark, xfrm will not take it > into account when routing ipsec traffic. We address this issue by adding > fwmark information before calling route lookup. > > Signed-off-by: Doug Applegate

Re: [PATCH RFC 0/1] xfrm: dst lookup doesn't account for fwmark

On Fri, Jul 22, 2016 at 03:50:30PM -0600, Doug Applegate wrote: > I ran into an issue trying to route outgoing ipsec traffic from an > ipsec responder hub that uses fwmark to route out a specific > interface. The fwmark points to a route table that contains a default > route out a specific

Re: [RFC PATCH] xfrm: Add option to reset oif in xfrm lookup

On Mon, Jul 25, 2016 at 06:34:32PM -0600, Subash Abhinov Kasiviswanathan wrote: > We are seeing incorrect routing when tunneling packets over an > interface and sending it over another interface. This scenario > worked on 3.18 (and earlier) and failed on 4.4 kernel. The rules > / routes / policies

Re: [PATCH] xfrm: use printk instead of WARN for bad policy reporting

On Wed, Jul 27, 2016 at 08:44:15AM +0200, Vegard Nossum wrote: > On 07/27/2016 08:31 AM, Herbert Xu wrote: > >On Wed, Jul 27, 2016 at 08:20:57AM +0200, Vegard Nossum wrote: > >> > >>Here's another patch to remove that too. > >> > >>I don't actually *use* this code myself and I feel the

Re: [PATCH] xfrm: use printk instead of WARN for bad policy reporting

On Wed, Jul 27, 2016 at 08:03:18AM +0200, Vegard Nossum wrote: > Subject: [PATCH] xfrm: get rid of incorrect WARN > > AFAICT this message is just printed whenever input validation fails. > This is a normal failure and we shouldn't be dumping the stack over it. > > Looks like it was originally a

[PATCH -next] drivers: net: phy: xgene: Remove redundant dev_err call in xgene_mdio_probe()

There is a error message within devm_ioremap_resource already, so remove the dev_err call to avoid redundant error message. Signed-off-by: Wei Yongjun --- drivers/net/phy/mdio-xgene.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git

[PATCH -next] tipc: fix imbalance read_unlock_bh in __tipc_nl_add_monitor()

In the error handling case of nla_nest_start() failed read_unlock_bh() is called to unlock a lock that had not been taken yet. sparse warns about the context imbalance as the following: net/tipc/monitor.c:799:23: warning: context imbalance in '__tipc_nl_add_monitor' - different lock contexts

Re: PROBLEM: network data corruption (bisected to e5a4b0bb803b)

On Wed, Jul 27, 2016 at 08:26:48PM -0400, alexmcwhir...@triadic.us wrote: > I'm going to go ahead and say this is where my issue and the op's issue > begin to branch apart from one another. He's seeing this on all incoming > data, whereas i am only seeing it on ssl data and not on sun4v. > > At

Re: [PATCH 1/1] rps: Inspect PPTP encapsulated by GRE to get flow hash

Inline... On 07/27/2016 06:04 PM, Tom Herbert wrote: On Wed, Jul 27, 2016 at 4:42 PM, wrote: From: Gao Feng The PPTP is encapsulated by GRE header with that GRE_VERSION bits must contain one. But current GRE RPS needs the GRE_VERSION must be zero. So RPS

Re: [PATCH 06/15] ethernet: hisilicon: hns: hns_dsaf_mac: add missing of_node_put after calling of_parse_phandle

在 2016/7/27 10:20, Peter Chen 写道: > of_node_put needs to be called when the device node which is got > from of_parse_phandle has finished using. > > Signed-off-by: Peter Chen > --- > drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.c | 9 ++--- > 1 file changed, 6

Re: PROBLEM: network data corruption (bisected to e5a4b0bb803b)

On 2016-07-27 20:31, Al Viro wrote: On Wed, Jul 27, 2016 at 04:45:43PM -0700, David Miller wrote: > I highly expect both my issue and OP's issue to revolve not around > commit e5a4b0bb803b specifically, but around other code that no longer > behaves as expected because of it. Indeed, and that

Re: [PATCH 1/1] rps: Inspect PPTP encapsulated by GRE to get flow hash

Hi Tom, I think maybe it is not good idea to consolidate these codes with the version 0 path. Because I need to check the flags strictly like this "!(hdr->flags & (GRE_CSUM | GRE_ROUTING | GRE_STRICT | GRE_REC | GRE_FLAGS))". These flag must be zero with PPTP GRE according to the RFC, but

Re: PROBLEM: network data corruption (bisected to e5a4b0bb803b)

On Wed, Jul 27, 2016 at 04:45:43PM -0700, David Miller wrote: > > I highly expect both my issue and OP's issue to revolve not around > > commit e5a4b0bb803b specifically, but around other code that no longer > > behaves as expected because of it. > > Indeed, and that fault address rounding bug

Re: [PATCH 1/1] rps: Inspect PPTP encapsulated by GRE to get flow hash

Thanks Tom, I append some inline comments. BTW, forgive me reply the email by gmail because the original mail server doesn't support kernel email format. I will send the update later. Best Regards Feng On Thu, Jul 28, 2016 at 8:04 AM, Tom Herbert wrote: > > On Wed, Jul

Darlehen anbieten

Guter Tag zu Ihnen, Sie haben um finanzielle Unterstützung benötigen? ein berechtigtes Kredit für Zinsen nötig? Sie benötigen einen Business-Darlehen? Brauchen Sie noch einen Kredit, um ein Haus, Auto zu kaufen, zahlen Sie Ihre Rechnungen und Schulden? Brauchen Sie Geld Probleme zu lösen?

Re: [PATCH 1/1] rps: Inspect PPTP encapsulated by GRE to get flow hash

On Wed, Jul 27, 2016 at 4:42 PM, wrote: > From: Gao Feng > > The PPTP is encapsulated by GRE header with that GRE_VERSION bits > must contain one. But current GRE RPS needs the GRE_VERSION must be > zero. So RPS does not work for PPTP traffic. > > In my test

[PATCH 1/1] rps: Inspect PPTP encapsulated by GRE to get flow hash

From: Gao Feng The PPTP is encapsulated by GRE header with that GRE_VERSION bits must contain one. But current GRE RPS needs the GRE_VERSION must be zero. So RPS does not work for PPTP traffic. In my test environment, there are four MIPS cores, and all traffic are passed

Re: PROBLEM: network data corruption (bisected to e5a4b0bb803b)

From: alexmcwhir...@triadic.us Date: Wed, 27 Jul 2016 19:02:40 -0400 > On 2016-07-27 14:04, alexmcwhir...@triadic.us wrote: >> Just to add some more information to this, the corruption seems to >> effect ssh as well. >> Using a sun hme interface, occasionally upon an ssh connection it will >>

Re: PROBLEM: network data corruption (bisected to e5a4b0bb803b)

On 2016-07-27 14:04, alexmcwhir...@triadic.us wrote: Just to add some more information to this, the corruption seems to effect ssh as well. Using a sun hme interface, occasionally upon an ssh connection it will refuse to authenticate a client with either password or cert authentication. Using

Re: [PATCH net 1/3] r8169:fix kernel log spam when set or get hardware wol setting.

Chunhao Lin : [...] > diff --git a/drivers/net/ethernet/realtek/r8169.c > b/drivers/net/ethernet/realtek/r8169.c > index 0e62d74..f07604f 100644 > --- a/drivers/net/ethernet/realtek/r8169.c > +++ b/drivers/net/ethernet/realtek/r8169.c > @@ -1749,13 +1749,21 @@ static u32

Re: [PATCH net 1/3] r8169:fix kernel log spam when set or get hardware wol setting.

Chunhao Lin : [...] > diff --git a/drivers/net/ethernet/realtek/r8169.c > b/drivers/net/ethernet/realtek/r8169.c > index 0e62d74..f07604f 100644 > --- a/drivers/net/ethernet/realtek/r8169.c > +++ b/drivers/net/ethernet/realtek/r8169.c [...] > @@ -1852,12 +1863,17 @@ static int

Re: [e1000_netpoll] BUG: sleeping function called from invalid context at kernel/irq/manage.c:110

On Tue, 2016-07-26 at 11:14 +0200, Eric Dumazet wrote: > Could you try this ? > > diff --git a/drivers/net/ethernet/intel/e1000/e1000_main.c > b/drivers/net/ethernet/intel/e1000/e1000_main.c > index > f42129d09e2c23ba9fdb5cde890d50ecb7166a42..a53c41c4c4f7d1fe52f95a2cab8784a > 938b3820b 100644 >

Re: [PATCH 05/15] ethernet: cavium: octeon: add missing of_node_put after calling of_parse_phandle

On 07/26/2016 07:20 PM, Peter Chen wrote: of_node_put needs to be called when the device node which is got from of_parse_phandle has finished using. Signed-off-by: Peter Chen NAK. --- drivers/net/ethernet/cavium/octeon/octeon_mgmt.c | 1 + 1 file changed, 1

RE: [Intel-wired-lan] [PATCH net-next v3 1/2] e1000e: factor out systim sanitization

>> This is prepatory work for an expanding list of adapter families that have >> occasional ~10 hour clock jumps when being used for PTP. Factor out the >> sanitization function and convert to using a feature (bug) flag, per >> suggestion from Jesse Brandeburg. >> >> Littering functional code

[PATCH net-next 2/3] kcm: Use stream parser

Adapt KCM to use the stream parser. This mostly involves removing the RX handling and setting up the strparser using the interface. Signed-off-by: Tom Herbert --- include/net/kcm.h | 37 + net/kcm/Kconfig | 1 + net/kcm/kcmproc.c | 41 +++-- net/kcm/kcmsock.c |

[PATCH net-next 1/3] strparser: Stream parser for messages

This patch introduces a utility for parsing application layer protocol messages in a TCP stream. This is a generalization of the mechanism implemented of Kernel Connection Multiplexor. The API includes a context structure, a set of callbacks, utility functions, and a data ready function. A

[PATCH net-next 0/3] strp: Stream parser for messages

This patch set introduces a utility for parsing application layer protocol messages in a TCP stream. This is a generalization of the mechanism implemented of Kernel Connection Multiplexor. This patch set adapts KCM to use the strparser. We expect that kTLS can use this mechanism also. RDS would

[PATCH net-next 3/3] strparser: Documentation

Signed-off-by: Tom Herbert --- Documentation/networking/strparser.txt | 147 + 1 file changed, 147 insertions(+) create mode 100644 Documentation/networking/strparser.txt diff --git a/Documentation/networking/strparser.txt

Re: linux-next: manual merge of the net-next tree with the arm-soc tree

On Tue, Jul 26, 2016 at 7:53 PM, Stephen Rothwell wrote: > Hi all, > > Today's linux-next merge of the net-next tree got a conflict in: > > arch/arm64/boot/dts/apm/apm-shadowcat.dtsi > > between commit: > > cafc4cd0c8b8 ("arm64: dts: apm: Use lowercase consistently for

Re: [PATCH 1/2] SUNRPC: accept() may return sockets that are still in SYN_RECV

Hi Eric, > On Jul 27, 2016, at 14:59, Eric Dumazet wrote: > > On Wed, 2016-07-27 at 14:48 -0400, Fields Bruce James wrote: >> On Tue, Jul 26, 2016 at 04:08:29PM +, Trond Myklebust wrote: >>> On Jul 26, 2016, at 11:43, J. Bruce Fields

Re: PROBLEM: TPROXY and DNAT broken (bisected to 079096f103fa)

On Wed, 2016-07-27 at 18:19 +, Brandon Cazander wrote: > [1.] One line summary of the problem: > Using TPROXY together with a DNAT rule (working on older kernels) fails to > work on newer kernels as of commit 079096f103fa > > [2.] Full description of the problem/report: > I performed a git

Re: [PATCH 1/2] SUNRPC: accept() may return sockets that are still in SYN_RECV

On Wed, 2016-07-27 at 14:48 -0400, Fields Bruce James wrote: > On Tue, Jul 26, 2016 at 04:08:29PM +, Trond Myklebust wrote: > > > > > On Jul 26, 2016, at 11:43, J. Bruce Fields wrote: > > > > > > On Tue, Jul 26, 2016 at 09:51:19AM -0400, Trond Myklebust wrote: > > >>

PROBLEM: TPROXY and DNAT broken (bisected to 079096f103fa)

[1.] One line summary of the problem: Using TPROXY together with a DNAT rule (working on older kernels) fails to work on newer kernels as of commit 079096f103fa [2.] Full description of the problem/report: I performed a git bisect using a qemu image to test my example below, and the bisect

Re: [e1000_netpoll] BUG: sleeping function called from invalid context at kernel/irq/manage.c:110

On Wed, 2016-07-27 at 23:01 +0800, Fengguang Wu wrote: > On Tue, Jul 26, 2016 at 06:28:33PM +0200, Eric Dumazet wrote: > >On Tue, 2016-07-26 at 23:32 +0800, Fengguang Wu wrote: > >> Hi Eric, > >> > >> It works! > >> > >> On Tue, Jul 26, 2016 at 11:14:52AM +0200, Eric Dumazet wrote: > >> >On Tue,

Re: [PATCH 1/2] SUNRPC: accept() may return sockets that are still in SYN_RECV

On Tue, Jul 26, 2016 at 04:08:29PM +, Trond Myklebust wrote: > > > On Jul 26, 2016, at 11:43, J. Bruce Fields wrote: > > > > On Tue, Jul 26, 2016 at 09:51:19AM -0400, Trond Myklebust wrote: > >> We're seeing traces of the following form: > >> > >> [10952.396347] svc:

[PATCH net] 8139too:fix system hang when there is a tx timeout event.

If tx timeout event occur, kernel will call rtl8139_tx_timeout_task() to reset hardware. But in this function, driver does not stop tx and rx function before reset hardware, that will cause system hang. In this patch, add stop tx and rx function before reset hardware. Signed-off-by: Chunhao Lin

Re: [iproute PATCH 0/3] improve MACsec support

On Tue, 26 Jul 2016 15:44:39 +0200 Sabrina Dubroca wrote: > 2016-07-26, 11:03:17 +0200, Davide Caratti wrote: > > parsing of 'cipher' and 'icvlen' arguments has been improved; while at it, > > a couple of missing printouts have been added to usage() functions in > > "ip

Re: [PATCH 2/2] net: davinci_cpdma: reduce time holding chan->lock in cpdma_chan_submit

On 27.07.16 17:08, Grygorii Strashko wrote: On 07/27/2016 10:12 AM, Uwe Kleine-König wrote: Hello, On Tue, Jul 26, 2016 at 05:25:58PM +0300, Grygorii Strashko wrote: On 07/26/2016 03:02 PM, Uwe Kleine-König wrote: Allocating and preparing a dma descriptor doesn't need to happen under the

Re: [PATCH v10 12/12] bpf: add sample for xdp forwarding and rewrite

On Tue, 19 Jul 2016 15:05:37 -0700 Alexei Starovoitov wrote: > On Tue, Jul 19, 2016 at 12:16:57PM -0700, Brenden Blanco wrote: > > Add a sample that rewrites and forwards packets out on the same > > interface. Observed single core forwarding performance of ~10Mpps.

Re: PROBLEM: network data corruption (bisected to e5a4b0bb803b)

Just to add some more information to this, the corruption seems to effect ssh as well. Using a sun hme interface, occasionally upon an ssh connection it will refuse to authenticate a client with either password or cert authentication. Using wireshark to capture and decrypt the packets

Re: [PATCH net-next V2 5/5] net/mlx4: Add VST QinQ support

On 16-07-26 07:23 AM, Tariq Toukan wrote: > Hi John, > > Currently we support one tag set to a VF by the administrator, with the > new interface can be either C-VLAN or S-VLAN. > Once S-VLAN is set by administrator, the VM can set the C-VLANs it wants > to use. > > S-VLAN + C-VLAN per vf

Forwarded Message

USA Internet Command Protocol 2016 has selected your e-mail ID as lucky winner of US$800,000.00 out of US$350,000.000.00 shared worldwide for 100.000 e-mail subscribers. Forward your lucky number USAL77720 to the mandated payment center in REP'Du Benin by E-mail : me...@yahoo.com ,CC:

Re: [v3] UCC_GETH/UCC_FAST: Use IS_ERR_VALUE_U32 API to avoid IS_ERR_VALUE abuses.

I am also agree with Arnd Bergmann. We should use 'static inline function' instead of macro to deal with error check. On Tuesday 26 July 2016 05:09 PM, Arnd Bergmann wrote: On Saturday, July 23, 2016 11:35:51 PM CEST Arvind Yadav wrote: diff --git a/include/linux/err.h b/include/linux/err.h

[PATCH net 0/3] r8169:fix 3 runtime pm related issues.

This series of patches fix 3 runtime pm related issues that are listed below. Chunhao Lin (3): r8169:fix kernel log spam when set or get hardware wol setting. r8169:add checking driver's runtime pm status in rtl8169_get_ethtool_stats() r8169:fix nic may not work after changing the mac

[PATCH net 3/3] r8169:fix nic may not work after changing the mac address.

When there is no AC power, NIC may not work after changing the mac address. Please refer to following link. http://www.spinics.net/lists/netdev/msg356572.html This issue is caused by runtime power management. When there is no AC power, if we put NIC down (ifconfig down), the driver will in

[PATCH net 2/3] r8169:add checking driver's runtime pm status in rtl8169_get_ethtool_stats()

Not to call rtl8169_update_counters() to dump tally counter when driver is in runtime suspend state. Signed-off-by: Chunhao Lin --- drivers/net/ethernet/realtek/r8169.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git

[PATCH net 1/3] r8169:fix kernel log spam when set or get hardware wol setting.

NIC will be put into D3 state during runtime suspend state. When set or get hardware wol setting, driver will write or read hardware register. If we set or get hardware wol setting in runtime suspend state, because NIC will in D3 state, the register value read by driver will return all 0xff. That

Re: [PATCH net] sit: Correctly return -ENOMEM from SIOCGETPRL ioctl.

On Wed, Jul 27, 2016 at 6:57 AM, Phil Turnbull wrote: > -ENOMEM is never returned because the 'out' path unconditionally sets > 'ret' to zero. Remove the 'out' path and return directly when the > allocation fails. > > Fixes: 300aaeeaab5f ("[IPV6] SIT: Add SIOCGETPRL

CPU utilization with kvm / vhost, differences 3.14 / 4.4 / 4.6

Hi, I'm stumped by a weird development in measured CPU utilization when testing an upgrade path from 3.14.70 to 4.4.14. I'm running, on identical hardware (2 4-core Xeon E5420), a HA (active/standby) pair of firewall/loadbalancer VMs. The OS on the host and the VM is identical - openSUSE 13.1

Patch: fix rotting packet OKI PCH_GBE switch

This is against torvalds 4.7.0 repo This resolves a rotting SYN-ACK packet issue with the OKI PCH_GBE switch. The problem showed up intermittently where a client would attempt to establish a TCP connection to the host on an otherwise quiet network. No other activity had occurred for a

RE: [PATCH 15/15] ethernet: ti: davinci_emac: add missing of_node_put after calling of_parse_phandle

>On Wednesday 27 July 2016 07:50 AM, Peter Chen wrote: >> of_node_put needs to be called when the device node which is got from >> of_parse_phandle has finished using. >> >> Signed-off-by: Peter Chen >> --- >> drivers/net/ethernet/ti/davinci_emac.c | 1 + >> 1 file changed,

Re: [e1000_netpoll] BUG: sleeping function called from invalid context at kernel/irq/manage.c:110

On Tue, Jul 26, 2016 at 06:28:33PM +0200, Eric Dumazet wrote: On Tue, 2016-07-26 at 23:32 +0800, Fengguang Wu wrote: Hi Eric, It works! On Tue, Jul 26, 2016 at 11:14:52AM +0200, Eric Dumazet wrote: >On Tue, 2016-07-26 at 11:50 +0800, Fengguang Wu wrote: >> Greetings, >> >> This BUG message

Re: [Intel-wired-lan] [PATCH net-next v3 1/2] e1000e: factor out systim sanitization

On Wed, Jul 27, 2016 at 02:09:13PM +, Avargil, Raanan wrote: >> This is prepatory work for an expanding list of adapter families that have >> occasional ~10 hour clock jumps when being used for PTP. Factor out the >> sanitization function and convert to using a feature (bug) flag, per >>

Re: [PATCH 0/2] net: davinci_cpdma: reduce latency on -rt

Hello, On Wed, Jul 27, 2016 at 05:11:54PM +0300, Grygorii Strashko wrote: > On 07/27/2016 10:03 AM, Uwe Kleine-König wrote: > > On Tue, Jul 26, 2016 at 05:36:49PM +0300, Grygorii Strashko wrote: > >> On 07/26/2016 03:02 PM, Uwe Kleine-König wrote: > >>> Hello, > >>> > >>> these patches are based

Re: [PATCH 0/2] net: davinci_cpdma: reduce latency on -rt

On 07/27/2016 10:03 AM, Uwe Kleine-König wrote: > On Tue, Jul 26, 2016 at 05:36:49PM +0300, Grygorii Strashko wrote: >> On 07/26/2016 03:02 PM, Uwe Kleine-König wrote: >>> Hello, >>> >>> these patches are based on next-20160726. I didn't check yet how latency >>> improves by using these patches,

RE: [Intel-wired-lan] [PATCH net-next v3 1/2] e1000e: factor out systim sanitization

This is prepatory work for an expanding list of adapter families that have occasional ~10 hour clock jumps when being used for PTP. Factor out the sanitization function and convert to using a feature (bug) flag, per suggestion from Jesse Brandeburg. Littering functional code with

Re: [PATCH 2/2] net: davinci_cpdma: reduce time holding chan->lock in cpdma_chan_submit

On 07/27/2016 10:12 AM, Uwe Kleine-König wrote: > Hello, > > On Tue, Jul 26, 2016 at 05:25:58PM +0300, Grygorii Strashko wrote: >> On 07/26/2016 03:02 PM, Uwe Kleine-König wrote: >>> Allocating and preparing a dma descriptor doesn't need to happen under >>> the channel's lock. So do this before

[no subject]

Greeting, Did you receive the fund letter i send you last? from Grace Bunyan

[PATCH net] sit: Correctly return -ENOMEM from SIOCGETPRL ioctl.

-ENOMEM is never returned because the 'out' path unconditionally sets 'ret' to zero. Remove the 'out' path and return directly when the allocation fails. Fixes: 300aaeeaab5f ("[IPV6] SIT: Add SIOCGETPRL ioctl to get/dump PRL.") Signed-off-by: Phil Turnbull ---

Re: [net-next] neigh: allow admin to set NUD_STALE

On Wed, 27 Jul 2016 09:56:50 +0300, Julian Anastasov wrote: > Admin should be able to set any state. Currently, this fails > when lladdr is not changed and state is changed from > NUD_CONNECTED to NUD_STALE: > > ip neigh add 192.168.8.1 lladdr 00:11:22:33:44:55 nud perm dev wlan0 >

[PATCH net 6/6] qed: Prevent over-usage of vlan credits by PF

Each PF/VF has a limited number of vlan filters for configuration purposes; This information is passed to qede and is used to prevent over-usage - once a vlan is to be configured and no filter credit is available, the driver would switch into working in vlan-promisc mode. Problem is the credit

[PATCH net 5/6] qed: Correct min bandwidth for 100g

Driver uses reverse logic when checking if minimum bandwidth configuration applied, causing it to configure the guarantee only on the first hw-function. Fixes: a0d26d5a4fc8 ("qed*: Don't reset statistics on inner reload") Signed-off-by: Yuval Mintz ---

[PATCH net 4/6] qede: Reset statistics on explicit down

Adding the necessary logic to prevet statistics reset on inner-reload introduced a bug, and now statistics are reset only when re-probing the driver. Fixes: a0d26d5a4fc8e ("qed*: Don't reset statistics on inner reload") Signed-off-by: Yuval Mintz ---

[PATCH net 0/6] qed*: Small fixes series

Hi Dave, This contains several small [and straight-forward] fixes to qed* drivers. Please consider applying this to `net'. Thanks, Yuval Yuval Mintz (6): qede: Don't try removing unconfigured vlans qed: Fix removal of spoof checking for VFs qed: Don't over-do producer cleanup for Rx

[PATCH net 3/6] qed: Don't over-do producer cleanup for Rx

Before requesting the firmware to start Rx queues, driver goes and sets the queue producer in the device to 0. But while the producer is 32-bit, the driver currently clears 64 bits, effectively zeroing an additional CID's producer as well. Signed-off-by: Yuval Mintz ---

[PATCH net 1/6] qede: Don't try removing unconfigured vlans

As part of ndo_vlan_rx_kill_vid() implementation, qede is requesting firmware to remove the vlan filter. This currently happens even if the vlan wasn't previously added [In case device ran out of vlan credits]. For PFs this doesn't cause any issues as the firmware would simply ignore the removal

[PATCH net 2/6] qed: Fix removal of spoof checking for VFs

Driver has reverse logic for checking the result of the spoof-checking configuration. As a result, it would log that the configuration failed [even though it succeeded], and will no longer do anything when requested to remove the configuration, as it's accounting of the feature will be incorrect.

Re: [PATCH 12/15] ethernet: renesas: sh_eth: add missing of_node_put after calling of_parse_phandle

On 7/27/2016 5:20 AM, Peter Chen wrote: of_node_put needs to be called when the device node which is got from of_parse_phandle has finished using. Signed-off-by: Peter Chen Acked-by: Sergei Shtylyov MBR, Sergei

Re: [PATCH 11/15] ethernet: renesas: ravb_main: add missing of_node_put after calling of_parse_phandle

On 7/27/2016 5:20 AM, Peter Chen wrote: of_node_put needs to be called when the device node which is got from of_parse_phandle has finished using. Signed-off-by: Peter Chen Acked-by: Sergei Shtylyov MBR, Sergei

[RFC PATCH] net: flush the softnet backlog in process context

Currently in process_backlog(), the process_queue dequeuing is performed with local IRQ disabled, to protect against flush_backlog(), which runs in hard IRQ context. This patch moves the flush operation to a work queue and runs the callback with bottom half disabled to protect the process_queue

Re: PROBLEM: network data corruption (bisected to e5a4b0bb803b)

Al Viro wrote: > > Another thing (and if that works, it's *NOT* a proper fix - it would be > papering over the problem, but at least it would show where to look for > it) - try (on top of mainline) the following delta: I tried it on top of v4.6.4 and on top of the very recent v4.7-2509-g59ebc44

[net-next PATCH 3/4] be2net: Avoid unnecessary firmware updates of multicast list

From: Sriharsha Basavapatna Eachtime the ndo_set_rx_mode() routine is called, the driver programs the multicast list in the adapter without checking if there are any changes to the list. This leads to a flood of RX_FILTER cmds when a number of vlan interfaces

[net-next PATCH 4/4] be2net: replace polling with sleeping in the FW completion path

The ndo_set_rx_mode() and ndo_add/del_vxlan_port() calls may be called with BHs disabled. The driver currently issues the required cmds to the FW in these contexts and polls on completions from the FW, while BHs remain disabled. This can cause either packet loss or packet reception to be delayed

[net-next PATCH 0/4] be2net: patch set

Hi David, pls consider applying this patch-set to the net-next tree. Patch 1 fixes the driver to workaournd a bug in the Lancer FW in the vlan-config cmd processing. The FW in some cases clears the vlan-promisc setting even if it cannot apply the vlan filter. The driver has no means of knowing if

[net-next PATCH 2/4] be2net: do not remove vids from driver table if be_vid_config() fails.

The driver currently removes a new vid from the adapter->vids[] array if be_vid_config() returns an error, which occurs when there is an error in HW/FW. This is wrong. After the HW/FW error is recovered from, we need the complete vids[] array to re-program the vlan list. Signed-off-by: Sathya

[net-next PATCH 1/4] be2net: clear vlan-promisc setting before programming the vlan list

From: Somnath Kotur The Lancer FW has a bug due to which in some cases vlan-promisc setting is cleared eventhough the vlan-list programming did not succeed (via VLAN_CONFIG) cmd. The driver has no way of knowing if the vlan-promisc mode was cleared or not when this cmd

RE: [PATCH v18 net-next 1/1] hv_sock: introduce Hyper-V Sockets

> From: David Miller [mailto:da...@davemloft.net] > Sent: Wednesday, July 27, 2016 1:45 > To: Dexuan Cui > > From: Dexuan Cui > Date: Tue, 26 Jul 2016 07:09:41 + > > > I googled "S390 hypervisor socket" but didn't find anything related (I > >

gpf in p9_client_read

Hi, I was fuzzing with trinity in qemu via the virtme script, i.e. using these opts: virtme-run --kdir /home/vbabka/wrk/linus.git --rwdir /home/vbabka/tmp/trinity/ --dry-run --show-command --qemu-opts --smp 8 -drive file=/home/vbabka/tmp/trinity.img,if=ide,format=raw,media=disk

RE: [PATCH v18 net-next 1/1] hv_sock: introduce Hyper-V Sockets

> From: netdev-ow...@vger.kernel.org [mailto:netdev- > ow...@vger.kernel.org] On Behalf Of Dexuan Cui > Sent: Tuesday, July 26, 2016 21:22 > ... > This is because, the design of AF_HYPERV in the Hyper-V host side is > suboptimal IMHO (the current host side design requires the least > change in the

Re: [net-next PATCH 4/4] be2net: replace polling with sleeping in the FW completion path

From: Sathya Perla Date: Wed, 27 Jul 2016 13:33:19 +0530 >> -Original Message- >> From: Sathya Perla [mailto:sathya.pe...@broadcom.com] >> > > >> > > > @@ -4477,6 +4551,22 @@ static int be_if_create(struct be_adapter >> > *adapter) >> > > >u32 cap_flags

Re: [RFC PATCH v2 1/4] Documentation: DT: net: Add Xilinx gmiitorgmii converter device tree binding documentation

Hi Appana Here is roughly what i was thinking: struct priv { phy_device *master; phy_device *slave; struct phy_driver *slave_drv; }; phy_status_clone(phy_device *master, phy_device *slave) { master->speed = slave->speed; master->duplex = slave->duplex;

Re: [PATCH net-next v2 2/3] bnxt_en: Log a message, if enabling NTUPLE filtering fails.

On Wed, Jul 27, 2016 at 12:31 AM, zhuyj wrote: > + if (vnics > pf->max_rsscos_ctxs || vnics > pf->max_vnics) { ><-Does this happen very rarely? If so, > > if (unlikely(vnics > pf->max_rsscos_ctxs || vnics > pf->max_vnics) { is > better? This is not in the

RE: [net-next PATCH 4/4] be2net: replace polling with sleeping in the FW completion path

> -Original Message- > From: Sathya Perla [mailto:sathya.pe...@broadcom.com] > > > > > > > @@ -4477,6 +4551,22 @@ static int be_if_create(struct be_adapter > > *adapter) > > > > u32 cap_flags = be_if_cap_flags(adapter); > > > > int status; > > > > > > > > + /* alloc

RE: [PATCH] qed: Add and use specific logging functions to reduce object size

> Current DP_ macros generate a lot of code. > Using functions with vsprintf extension %pV helps reduce that size. > > drivers/net/ethernet/qlogic/qed/Makefile | 2 +- > drivers/net/ethernet/qlogic/qed/qed_util.c | 82 > ++ > include/linux/qed/qed_if.h

RE: [PATCH] qed: Add and use specific logging functions to reduce object size

> > Current DP_ macros generate a lot of code. > > Using functions with vsprintf extension %pV helps reduce that size. > > Yuval, I used the same KERN_ output types, but it is unusual > that DP_INFO outputs at KERN_NOTICE. > > Was that a copy/paste defect or should it be emitted at KERN_INFO and

Re: [PATCH net-next v2 2/3] bnxt_en: Log a message, if enabling NTUPLE filtering fails.

+ if (vnics > pf->max_rsscos_ctxs || vnics > pf->max_vnics) { <-Does this happen very rarely? If so, if (unlikely(vnics > pf->max_rsscos_ctxs || vnics > pf->max_vnics) { is better? + netdev_warn(bp->dev, + "Not enough resources to support

RE: [PATCH v4 5/7] thunderbolt: Networking state machine

On Mon, Jul 25 2016, 01:36 AM, Lukas Wunner wrote: > On Mon, Jul 18, 2016 at 01:00:38PM +0300, Amir Levy wrote: > > + const unique_id_be proto_uuid = > APPLE_THUNDERBOLT_IP_PROTOCOL_UUID; > > + > > + if (memcmp(proto_uuid, hdr->apple_tbt_ip_proto_uuid, > > + sizeof(proto_uuid)) !=

Re: [PATCH 2/2] net: davinci_cpdma: reduce time holding chan->lock in cpdma_chan_submit

Hello, On Tue, Jul 26, 2016 at 05:25:58PM +0300, Grygorii Strashko wrote: > On 07/26/2016 03:02 PM, Uwe Kleine-König wrote: > > Allocating and preparing a dma descriptor doesn't need to happen under > > the channel's lock. So do this before taking the channel's lock. The only > > down side is

Re: problem with MPLS and TSO/GSO

On Wed, Jul 27, 2016 at 03:02:24PM +0800, zhuyj wrote: > On ubuntu16.04 server 64 bit > The attached script is run, the following will appear. > > Error: either "to" is duplicate, or "encap" is a garbage. Looks like your installed iproute2 package doesn't grok MPLS.

Re: [PATCH 0/2] net: davinci_cpdma: reduce latency on -rt

On Tue, Jul 26, 2016 at 05:36:49PM +0300, Grygorii Strashko wrote: > On 07/26/2016 03:02 PM, Uwe Kleine-König wrote: > >Hello, > > > >these patches are based on next-20160726. I didn't check yet how latency > >improves by using these patches, but even if the improvment is small, > >it's still a

[PATCH net-next] neigh: allow admin to set NUD_STALE

Admin should be able to set any state. Currently, this fails when lladdr is not changed and state is changed from NUD_CONNECTED to NUD_STALE: ip neigh add 192.168.8.1 lladdr 00:11:22:33:44:55 nud perm dev wlan0 ip neigh show to 192.168.8.1 192.168.8.1 dev wlan0 lladdr 00:11:22:33:44:55 PERMANENT

Re: linux-next: build warning after merge of the net-next tree

On Tue, Jul 26, 2016 at 11:35 PM, Stephen Rothwell wrote: > Hi David, > > On Tue, 26 Jul 2016 23:19:59 -0700 (PDT) David Miller > wrote: >> >> Fixed thusly: >> >> >> From 36232012344b8db67052432742deaf17f82e70e6 Mon Sep 17

Re: [PATCH] xfrm: use printk instead of WARN for bad policy reporting

On 07/27/2016 08:31 AM, Herbert Xu wrote: On Wed, Jul 27, 2016 at 08:20:57AM +0200, Vegard Nossum wrote: Here's another patch to remove that too. I don't actually *use* this code myself and I feel the justification I've given for removing the WARN to be a bit weak, so if you don't take the

Re: PROBLEM: network data corruption (bisected to e5a4b0bb803b)

alexmcwhir...@triadic.us writes: > On 2016-07-26 09:59, Christian Lamparter wrote: >> Thanks, I gave the program a try with my WNDA3100 and a WN821N v2 >> devices. >> I did not see any corruptions in any of the tests though. Can you >> tell me >> something about your wireless network too? I would

Re: linux-next: build warning after merge of the net-next tree

Hi David, On Tue, 26 Jul 2016 23:19:59 -0700 (PDT) David Miller wrote: > > Fixed thusly: > > > From 36232012344b8db67052432742deaf17f82e70e6 Mon Sep 17 00:00:00 2001 > From: "David S. Miller" > Date: Tue, 26 Jul 2016 23:19:29

Re: [PATCH] xfrm: use printk instead of WARN for bad policy reporting

On Wed, Jul 27, 2016 at 08:20:57AM +0200, Vegard Nossum wrote: > > Here's another patch to remove that too. > > I don't actually *use* this code myself and I feel the justification > I've given for removing the WARN to be a bit weak, so if you don't take > the patch I'll just keep it in my local

Re: [PATCH] xfrm: use printk instead of WARN for bad policy reporting

On 07/27/2016 05:01 AM, Herbert Xu wrote: On Wed, Jul 20, 2016 at 01:53:12PM +0200, Vegard Nossum wrote: Just FYI I'm also running into the // reset the timers here? WARN(1, "Don't know what to do with soft policy expire\n"); in xfrm_add_pol_expire() from the same commit, but that looks

Re: [PATCH net] be2net: perform temperature query in adapter regardless of its interface state

From: "Guilherme G. Piccoli" Date: Tue, 26 Jul 2016 17:39:42 -0300 > The be2net driver performs fw temperature queries on be_worker() routine, > which is executed each second for each be_adapter. There is a frequency > threshold to avoid fw query to happens at each

  1   2   >