Re: [PATCH 24/29] drivers: convert iblock_req.pending from atomic_t to refcount_t

Hi Elena, On Mon, 2017-03-06 at 16:21 +0200, Elena Reshetova wrote: > refcount_t type and corresponding API should be > used instead of atomic_t when the variable is used as > a reference counter. This allows to avoid accidental > refcounter overflows that might lead to use-after-free >

Re: [PATCH v3] {net,IB}/{rxe,usnic}: Utilize generic mac to eui32 function

On Tue, Mar 07, 2017 at 09:31:58PM +0200, Yuval Shaia wrote: > This logic seems to be duplicated in (at least) three separate files. > Move it to one place so code can be re-use. > > Signed-off-by: Yuval Shaia > --- > v0 -> v1: > * Add missing #include > *

Re: [PATCH net 0/3] rds: tcp: fix various rds-tcp issues during netns create/delete sequences

From: Sowmini Varadhan Date: Sat, 4 Mar 2017 08:57:32 -0800 > Dmitry Vyukov reported some syszkaller panics during netns deletion. ... Series applied, thanks!

Re: linux-next: build failure after merge of the rcu tree

On Wed, Mar 08, 2017 at 12:16:05PM +1100, Stephen Rothwell wrote: > Hi Paul, > > On Mon, 13 Feb 2017 17:43:24 +1100 Stephen Rothwell > wrote: > > > > On Sun, 12 Feb 2017 20:37:48 -0800 "Paul E. McKenney" > > wrote: > > > > > > I chickened out

[PATCH v4 net-next 5/6] drivers: net: xgene-v2: Add transmit and receive

This patch adds, - Transmit - Transmit completion poll - Receive poll - NAPI handler and enables the driver. Signed-off-by: Iyappan Subramanian Signed-off-by: Keyur Chudgar --- drivers/net/ethernet/apm/Kconfig | 1 +

[PATCH net 0/2] bpf: htab fixes

Two bpf hashtable fixes. See individual patches for details. Alexei Starovoitov (2): bpf: fix struct htab_elem layout bpf: convert htab map to hlist_nulls include/linux/list_nulls.h| 5 ++ include/linux/rculist_nulls.h | 14 + kernel/bpf/hashtab.c | 119

[PATCH net 1/2] bpf: fix struct htab_elem layout

when htab_elem is removed from the bucket list the htab_elem.hash_node.next field should not be overridden too early otherwise we have a tiny race window between lookup and delete. The bug was discovered by manual code analysis and reproducible only with explicit udelay() in lookup_elem_raw().

[PATCH net 2/2] bpf: convert htab map to hlist_nulls

when all map elements are pre-allocated one cpu can delete and reuse htab_elem while another cpu is still walking the hlist. In such case the lookup may miss the element. Convert hlist to hlist_nulls to avoid such scenario. When bucket lock is taken there is no need to take such precautions, so

Re: [PATCH v4 net-next 4/6] drivers: net: xgene-v2: Add base driver

Hi, One minor comment: The return type of xge_init_hw() should be changed to be void, as the method xge_port_reset() always returns 0; and also the return type of xge_port_reset() should be changed to be void, it never fails; see in [PATCH v4 net-next 3/6] drivers: net: xgene-v2: Add ethernet

Re: [PATCH net-next RFC 3/4] vhost: interrupt coalescing support

On 2017年03月07日 01:31, Willem de Bruijn wrote: On Mon, Mar 6, 2017 at 4:28 AM, Jason Wang wrote: On 2017年03月03日 22:39, Willem de Bruijn wrote: +void vhost_signal(struct vhost_dev *dev, struct vhost_virtqueue *vq); +static enum hrtimer_restart vhost_coalesce_timer(struct

Re: [PATCH net] tcp: fix various issues for sockets morphing to listen state

From: Eric Dumazet Date: Fri, 03 Mar 2017 14:08:21 -0800 > From: Eric Dumazet > > Dmitry Vyukov reported a divide by 0 triggered by syzkaller, exploiting > tcp_disconnect() path that was never really considered and/or used > before syzkaller ;) > >

Re: [PATCH net] rxrpc: Call state should be read with READ_ONCE() under some circumstances

From: David Howells Date: Sat, 04 Mar 2017 00:01:41 + > The call state may be changed at any time by the data-ready routine in > response to received packets, so if the call state is to be read and acted > upon several times in a function, READ_ONCE() must be used unless

Re: [PATCH] net: initialize msg.msg_flags in recvfrom

On Tue, Mar 7, 2017 at 3:26 PM, Eric Dumazet wrote: > On Tue, 2017-03-07 at 14:58 +0100, Alexander Potapenko wrote: >> KMSAN (KernelMemorySanitizer, a new error detection tool) reports use >> of uninitialized memory in put_cmsg()): > > I would prefer that you do not put

Re: please add some examples to the ip man page

On 3/7/17 6:25 PM, Stephen Hemminger wrote: > On Wed, 08 Mar 2017 08:46:01 +0800 > 積丹尼 Dan Jacobson wrote: > >>> "SH" == Stephen Hemminger writes: >> >> SH> Sure. Submit a patch. >> >> If only I could figure out how to use the command. >

Re: [PATCH v4 net-next 4/6] drivers: net: xgene-v2: Add base driver

On 03/07/2017 05:08 PM, Iyappan Subramanian wrote: > This patch adds, > > - probe, remove, shutdown > - open, close and stats > - create and delete ring > - request and delete irq > > Signed-off-by: Iyappan Subramanian > Signed-off-by: Keyur Chudgar

[PATCH v4 net-next 0/6] drivers: net: xgene-v2: Add RGMII based 1G driver

This patch set adds support for RGMII based 1GbE hardware which uses a linked list of DMA descriptor architecture (v2) for APM X-Gene SoCs. Signed-off-by: Iyappan Subramanian --- v4: Address review comments from v3 - fixed local variable declarations to reverse

[PATCH v4 net-next 4/6] drivers: net: xgene-v2: Add base driver

This patch adds, - probe, remove, shutdown - open, close and stats - create and delete ring - request and delete irq Signed-off-by: Iyappan Subramanian Signed-off-by: Keyur Chudgar --- drivers/net/ethernet/apm/xgene-v2/main.c | 510

[PATCH v4 net-next 6/6] MAINTAINERS: Add entry for APM X-Gene SoC Ethernet (v2) driver

This patch adds a MAINTAINERS entry for the ethernet driver for the on-chip ethernet interface which uses a linked list of DMA descriptor architecture (v2) for APM X-Gene SoCs. Signed-off-by: Iyappan Subramanian Signed-off-by: Keyur Chudgar ---

Re: linux-next: build failure after merge of the rcu tree

Hi Paul, On Mon, 13 Feb 2017 17:43:24 +1100 Stephen Rothwell wrote: > > On Sun, 12 Feb 2017 20:37:48 -0800 "Paul E. McKenney" > wrote: > > > > I chickened out on that commit for this merge window, so it will come > > back at -rc1. But I will

[PATCH v4 net-next 3/6] drivers: net: xgene-v2: Add ethernet hardware configuration

This patch adds functions to configure ethernet hardware. Signed-off-by: Iyappan Subramanian Signed-off-by: Keyur Chudgar --- drivers/net/ethernet/apm/xgene-v2/enet.c | 71 drivers/net/ethernet/apm/xgene-v2/enet.h | 43

Re: please add some examples to the ip man page

On Wed, 08 Mar 2017 08:46:01 +0800 積丹尼 Dan Jacobson wrote: > > "SH" == Stephen Hemminger writes: > > SH> Sure. Submit a patch. > > If only I could figure out how to use the command. $ ip link show $ ip addr show $ ip route

Question on ixgbe flow director

Hi, I have few questions regarding ixgbe flow director. As per my understanding flow director in ixgbe can work in 2 exclusive ways, a. Using ATR filters - where flow director is setup in HW by driver identifying transmit traffic. And based on that, receive traffic of the same flow get

[PATCH v4 net-next 2/6] drivers: net: xgene-v2: Add mac configuration

This patch adds functions to configure and control mac. This patch also adds helper functions to get/set registers. Signed-off-by: Iyappan Subramanian Signed-off-by: Keyur Chudgar --- drivers/net/ethernet/apm/xgene-v2/mac.c | 116

[PATCH v4 net-next 1/6] drivers: net: xgene-v2: Add DMA descriptor

This patch adds DMA descriptor setup and interrupt enable/disable functions. Signed-off-by: Iyappan Subramanian Signed-off-by: Keyur Chudgar --- drivers/net/ethernet/apm/xgene-v2/main.h | 74 +++ drivers/net/ethernet/apm/xgene-v2/ring.c

[PATCH net-next v2 2/2] mpls: allow TTL propagation from IP packets to be configured

Allow TTL propagation from IP packets to MPLS packets to be configured. Add a new optional LWT attribute, MPLS_IPTUNNEL_TTL, which allows the TTL to be set in the resulting MPLS packet, with the value of 0 having the semantics of enabling propagation of the TTL from the IP header (i.e. non-zero

[PATCH net-next v2 1/2] mpls: allow TTL propagation to IP packets to be configured

Provide the ability to control on a per-route basis whether the TTL value from an MPLS packet is propagated to an IPv4/IPv6 packet when the last label is popped as per the theoretical model in RFC 3443 through a new route attribute, RTA_TTL_PROPAGATE which can be 0 to mean disable propagation and

[PATCH net-next v2 0/2] mpls: allow TTL propagation to/from IP packets to be configured

It is sometimes desirable to present an MPLS transport network as a single hop to traffic transiting it because it prevents confusion when diagnosing failures. An example of where confusion can be generated is when addresses used in the provider network overlap with addresses in the overlay

[RFC net-next sample action optimization 3/3] openvswitch: Optimize sample action for the clone use cases

With the introduction of open flow 'clone' action, the OVS user space can now translate the 'clone' action into kernel datapath 'sample' action, with 100% probability, to ensure that the clone semantics, which is that the packet seen by the clone action is the same as the packet seen by the action

Re: please add some examples to the ip man page

> "SH" == Stephen Hemminger writes: SH> Sure. Submit a patch. If only I could figure out how to use the command.

[RFC net-next sample action optimization 2/3] openvswitch: Refactor recirc key allocation.

The logic of allocating and copy key for each 'exec_actions_level' was specific to execute_recirc(). However, future patches will reuse as well. Refactor the logic into its own function clone_key(). Signed-off-by: Andy Zhou --- net/openvswitch/actions.c | 72

[RFC net-next sample action optimization 0/3]

The sample action can be used for translating Openflow 'clone' action. However its implementation has not been sufficiently optimized for this use case. This series attempts to close the gap. Patch 3 commit message has more details on the specific optimizations implemented. Andy Zhou (3):

[RFC net-next sample action optimization 1/3] openvswitch: deferred fifo api change

add_deferred_actions() API currently requires actions to be passed in as a fully encoded netlink message. So far both 'sample' and 'recirc' actions happens to carry actions as fully encoded netlink messages. However, this requirement is more restrictive than necessary, future patch will need to

[PATCH net-next] net: stmicro: replace kzalloc with devm_kzalloc

The axi variable was not being freed upon device removal. With devm_kzalloc it ensures that it is properly freed. Signed-off-by: Joao Pinto --- drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH] net: via: via-rhine: use new api ethtool_{get|set}_link_ksettings

The ethtool api {get|set}_settings is deprecated. We move this driver to new api {get|set}_link_ksettings. As I don't have the hardware, I'd be very pleased if someone may test this patch. Signed-off-by: Philippe Reynes --- drivers/net/ethernet/via/via-rhine.c | 14

Re: [PATCH net 0/7] bnx2x: PTP crash, VF VLAN fixes

From: Michal Schmidt Date: Fri, 3 Mar 2017 17:08:27 +0100 > here are fixes for a crash with PTP, a crash in setting of VF multicast > addresses, and non-working VLAN filters configuration from the VF side. Series applied, thanks.

Re: [RFC PATCH] uapi: fix linux/packet_diag.h userspace compilation error

From: "Dmitry V. Levin" Date: Tue, 7 Mar 2017 23:28:02 +0300 > On Tue, Mar 07, 2017 at 12:16:49PM -0800, David Miller wrote: >> From: "Dmitry V. Levin" >> Date: Tue, 28 Feb 2017 04:39:30 +0300 >> >> > Replace MAX_ADDR_LEN with its numeric value to fix the

Re: pull request (net): ipsec 2017-03-06

From: Steffen Klassert Date: Mon, 6 Mar 2017 07:57:25 +0100 > 1) Fix lockdep splat on xfrm policy subsystem initialization. >From Florian Westphal. > > 2) When using socket policies on IPv4-mapped IPv6 addresses, >we access the flow informations of the

Re: [Patch net] ipv6: reorder icmpv6_init() and ip6_mr_init()

From: Cong Wang Date: Sun, 5 Mar 2017 12:34:53 -0800 > Andrey reported the following kernel crash: ... > This is because net->ipv6.mr6_tables is not initialized at that point, > ip6mr_rules_init() is not called yet, therefore on the error path when > we iterator the

Re: net: heap out-of-bounds in fib6_clean_node/rt6_fill_node/fib6_age/fib6_prune_clone

On 3/7/17 1:43 AM, Dmitry Vyukov wrote: > This is on c1ae3cfa0e89fa1a7ecc4c99031f5e9ae99d9201. No other kernel > output from your patch (pr_err). Is the below supposed to be from the same qemu instance at the time of the crash? cpu1 and cpu2 are both supposedly doing a route insert? > >

Re: [PATCH] fjes: Do not load fjes driver if system does not have extended socket device.

From: Yasuaki Ishimatsu Date: Thu, 2 Mar 2017 11:56:44 -0500 > + > /* fjes_init_module - Driver Registration Routine */ > static int __init fjes_init_module(void) > { > int result; > + bool found = false; > + Please order local variable declarations from

Re: [PATCH v3 net-next 2/6] drivers: net: xgene-v2: Add mac configuration

From: Iyappan Subramanian Date: Fri, 3 Mar 2017 17:09:28 -0800 > +void xge_mac_set_station_addr(struct xge_pdata *pdata) > +{ > + u32 addr0, addr1; > + u8 *dev_addr = pdata->ndev->dev_addr; Please order local variable declarations from longest to shortest line.

Re: [PATCH net] dccp: fix use-after-free in dccp_feat_activate_values

From: Eric Dumazet Date: Sun, 05 Mar 2017 10:52:16 -0800 > From: Eric Dumazet > > Dmitry reported crashes in DCCP stack [1] > > Problem here is that when I got rid of listener spinlock, I missed the > fact that DCCP stores a complex state in struct

Re: [PATCH] udp: avoid ufo handling on IP payload compression packets

From: Alexey Kodanev Date: Fri, 3 Mar 2017 15:37:32 +0300 > diff --git a/net/ipv4/ip_output.c b/net/ipv4/ip_output.c > index b67719f..18383ef 100644 > --- a/net/ipv4/ip_output.c > +++ b/net/ipv4/ip_output.c > @@ -960,7 +960,10 @@ static int __ip_append_data(struct

Re: [PATCH] arp: Race condition in gratuitous ARP reception handling.

From: Date: Thu, 2 Mar 2017 14:59:47 +0100 > @@ -836,19 +843,30 @@ static int arp_process(struct net *net, struct sock > *sk, struct sk_buff *skb) > n = __neigh_lookup(_tbl, , dev, 0); > > if (IN_DEV_ARP_ACCEPT(in_dev)) { > - unsigned int

Re: net: BUG in unix_notinflight

On Tue, Mar 7, 2017 at 12:37 AM, Dmitry Vyukov wrote: > On Mon, Mar 6, 2017 at 11:34 PM, Cong Wang wrote: >> The problem here is there is no lock protecting concurrent unix_detach_fds() >> even though unix_notinflight() is already serialized, if we

[PATCH v2] net: intel: ixgbe: use new api ethtool_{get|set}_link_ksettings

The ethtool api {get|set}_settings is deprecated. We move this driver to new api {get|set}_link_ksettings. As I don't have the hardware, I'd be very pleased if someone may test this patch. Signed-off-by: Philippe Reynes --- Changelog: v2: - fix compilation (thanks andrewx

Re: net: BUG in unix_notinflight

On Wed, Mar 08, 2017 at 12:23:56AM +0200, Nikolay Borisov wrote: > > >> > >> > >> New report from linux-next/c0b7b2b33bd17f7155956d0338ce92615da686c9 > >> > >> [ cut here ] > >> kernel BUG at net/unix/garbage.c:149! > >> invalid opcode: [#1] SMP KASAN > >> Dumping

Re: net: BUG in unix_notinflight

>> >> >> New report from linux-next/c0b7b2b33bd17f7155956d0338ce92615da686c9 >> >> [ cut here ] >> kernel BUG at net/unix/garbage.c:149! >> invalid opcode: [#1] SMP KASAN >> Dumping ftrace buffer: >>(ftrace buffer empty) >> Modules linked in: >> CPU: 0 PID: 1806

Re: [PATCH net 0/2] net: fix possible sock_hold() misuses

From: Eric Dumazet Date: Fri, 3 Mar 2017 21:01:01 -0800 > skb_complete_wifi_ack() and skb_complete_tx_timestamp() currently > call sock_hold() on sockets that might have transitioned their sk_refcnt > to zero already. Series applied and queued up for -stable, thanks.

Re: [PATCH 1/2 net] ibmvnic: Fix overflowing firmware/hardware TX queue

From: Thomas Falcon Date: Sun, 5 Mar 2017 12:18:41 -0600 > Use a counter to track the number of outstanding transmissions sent > that have not received completions. If the counter reaches the maximum > number of queue entries, stop transmissions on that queue. As we

Re: [PATCH 2/2 net] ibmvnic: Allocate number of rx/tx buffers agreed on by firmware

From: Thomas Falcon Date: Sun, 5 Mar 2017 12:18:42 -0600 > The amount of TX/RX buffers that the vNIC driver currently allocates > is different from the amount agreed upon in negotiation with firmware. > Correct that by allocating the requested number of buffers

Re: please add some examples to the ip man page

On Wed, 08 Mar 2017 03:10:32 +0800 積丹尼 Dan Jacobson wrote: > $ man ip > should have some usage examples. Even one would be fine. Sure. Submit a patch.

Re: [PATCH] net/sched: act_skbmod: remove unneeded rcu_read_unlock in tcf_skbmod_dump

From: Alexey Khoroshilov Date: Sun, 5 Mar 2017 03:01:55 +0300 > Found by Linux Driver Verification project (linuxtesting.org). > > Signed-off-by: Alexey Khoroshilov Applied and queued up for -stable, thanks.

Re: [PATCH net-next 1/1] decnet: Use TCP nagle macro instead of literal number in decnet

From: f...@ikuai8.com Date: Sat, 4 Mar 2017 22:10:28 +0800 > From: Gao Feng > > Use existing TCP nagle macro TCP_NAGLE_OFF and TCP_NAGLE_CORK instead > of the literal number 1 and 2 in the current decnet codes. > > Signed-off-by: Gao Feng Applied.

Re: net: heap out-of-bounds in fib6_clean_node/rt6_fill_node/fib6_age/fib6_prune_clone

On Tue, Mar 7, 2017 at 8:02 PM, Dmitry Vyukov wrote: > On Tue, Mar 7, 2017 at 7:43 PM, David Ahern wrote: >> On 3/7/17 11:13 AM, Dmitry Vyukov wrote: on this warning: /* dst.next really should not be set at this point */ if

Re: [PATCH v2 2/2] can: spi: hi311x: Add Holt HI-311x CAN driver

On 01/17/2017 02:22 PM, Akshay Bhat wrote: > This patch adds support for the Holt HI-311x CAN controller. The HI311x > CAN controller is capable of transmitting and receiving standard data > frames, extended data frames and remote frames. The HI311x interfaces > with the host over SPI. > >

[PATCH] uapi: fix linux/packet_diag.h userspace compilation error

Replace MAX_ADDR_LEN with its numeric value to fix the following linux/packet_diag.h userspace compilation error: /usr/include/linux/packet_diag.h:67:17: error: 'MAX_ADDR_LEN' undeclared here (not in a function) __u8 pdmc_addr[MAX_ADDR_LEN]; This is not the first case in the UAPI where the

Re: [PATCH] net: toshiba: ps3_genic_net: use new api ethtool_{get|set}_link_ksettings

On 03/05/2017 02:21 PM, Philippe Reynes wrote: The ethtool api {get|set}_settings is deprecated. We move this driver to new api {get|set}_link_ksettings. As I don't have the hardware, I'd be very pleased if someone may test this patch. I tested this applied to v4.11-rc1 and it seems to work

Re: [RFC PATCH] uapi: fix linux/packet_diag.h userspace compilation error

On Tue, Mar 07, 2017 at 12:16:49PM -0800, David Miller wrote: > From: "Dmitry V. Levin" > Date: Tue, 28 Feb 2017 04:39:30 +0300 > > > Replace MAX_ADDR_LEN with its numeric value to fix the following > > linux/packet_diag.h userspace compilation error: > > > >

Re: [PATCH v1 net-next] net: dwc-xlgmac: Initial driver for DesignWare Enterprise Ethernet

From: Jie Deng Date: Wed, 1 Mar 2017 12:00:25 +0800 > +static int xlgmac_init(struct xlgmac_pdata *pdata) > +{ > + struct net_device *netdev = pdata->netdev; > + struct xlgmac_hw_ops *hw_ops = >hw_ops; Please order local variable declarations from longest to

Re: [PATCH] net: qcom/emac: optimize QDF2400 SGMII RX/TX impedence values

From: Timur Tabi Date: Tue, 28 Feb 2017 17:16:02 -0600 > Adjust the impedance values of the RX and TX lanes in the SGMII block > so that they are closer to optimal values. > > Signed-off-by: Timur Tabi Applied to net-next, thanks.

Re: [PATCH] net/mlx5e: add IPV6 dependency

From: Arnd Bergmann Date: Tue, 28 Feb 2017 22:12:04 +0100 > The ethernet support now calls directly into the ipv6 core code, which > fails if IPV6 is a loadable module but mlx5 is built-in: > > drivers/net/ethernet/mellanox/mlx5/core/en_tc.o: In function >

Re: [PATCH net-next 1/1] net: rmnet_data: Initial implementation

From: Subash Abhinov Kasiviswanathan Date: Thu, 23 Feb 2017 20:30:54 -0700 > +struct rmnet_nl_msg_s { > + uint16_t reserved; > + uint16_t message_type; > + uint16_t reserved2:14; > + uint16_t crd:2; Inside the kernel you should use "u32", "u16", "u8",

Re: [PATCH v2] dt: emac: document device-tree based phy discovery and setup

From: Christian Lamparter Date: Mon, 27 Feb 2017 21:54:50 +0100 > This patch adds documentation for a new "phy-handle" property, > "fixed-link" and "mdio" sub-node. These allows the enumeration > of PHYs which are supported by the phy library under drivers/net/phy. > >

Re: [RFC PATCH] uapi: fix linux/packet_diag.h userspace compilation error

From: "Dmitry V. Levin" Date: Tue, 28 Feb 2017 04:39:30 +0300 > Replace MAX_ADDR_LEN with its numeric value to fix the following > linux/packet_diag.h userspace compilation error: > > /usr/include/linux/packet_diag.h:67:17: error: 'MAX_ADDR_LEN' undeclared here > (not in a

Re: net: heap out-of-bounds in fib6_clean_node/rt6_fill_node/fib6_age/fib6_prune_clone

On Tue, Mar 7, 2017 at 8:30 PM, Dmitry Vyukov wrote: >>> On 3/7/17 11:13 AM, Dmitry Vyukov wrote: > on this warning: > > /* dst.next really should not be set at this point */ > if (rt->dst.next && rt->dst.next->ops->family != AF_INET6) { >

Re: [PATCH net] net/tunnel: set inner protocol in network gro hooks

On Tue, Mar 7, 2017 at 9:33 AM, Paolo Abeni wrote: > The gso code of several tunnels type (gre and udp tunnels) > takes for granted that the skb->inner_protocol is properly > initialized and drops the packet elsewhere. > > On the forwarding path no one is initializing such

[PATCH net-next] liquidio: add support for XPS

From: Rick Farrington Add support for XPS. Signed-off-by: Rick Farrington Signed-off-by: Felix Manlunas Signed-off-by: Derek Chickles Signed-off-by: Satanand Burla

Re: [PATCH v2 0/6] Updates for Marvell Switch SoCs

Hi Gregory, On 08/03/17 06:10, Gregory CLEMENT wrote: > Hi Chris, > > On jeu., févr. 16 2017, Chris Packham > wrote: > >> Shortly after I posted my last series I got access to a more recent >> Marvell SDK which had some device tree support for the switch SoCs

Re: [PATCH 1/1] rds: ib: add error handle

On 3/6/2017 11:48 PM, Zhu Yanjun wrote: In the function rds_ib_setup_qp, the error handle is missing. When some error occurs, it is possible that memory leak occurs. As such, error handle is added. Cc: Joe Jin Reviewed-by: Junxiao Bi Reviewed-by:

RE: [PATCH net 3/7 v2] bnx2x: fix possible overrun of VFPF multicast addresses array

> It is too late to check for the limit of the number of VF multicast addresses > after they have already been copied to the req->multicast[] array, possibly > overflowing it. > > Do the check before copying. > > Checking early also avoids having to (and forgetting to) unlock vf2pf_mutex. > >

[PATCH v3] {net,IB}/{rxe,usnic}: Utilize generic mac to eui32 function

This logic seems to be duplicated in (at least) three separate files. Move it to one place so code can be re-use. Signed-off-by: Yuval Shaia --- v0 -> v1: * Add missing #include * Rename to genaddrconf_ifid_eui48 v1 -> v2: * Reset eui[0] to default

Re: [PATCH v2] {net,IB}/{rxe,usnic}: Utilize generic mac to eui32 function

On Tue, Mar 07, 2017 at 04:27:11PM +0200, Leon Romanovsky wrote: > On Mon, Mar 06, 2017 at 08:54:06PM +0200, Yuval Shaia wrote: > > This logic seems to be duplicated in (at least) three separate files. > > Move it to one place so code can be re-use. > > > > Signed-off-by: Yuval Shaia

Re: netlink: GPF in netlink_unicast

On Tue, Mar 7, 2017 at 1:44 PM, Paul Moore wrote: > On Tue, Mar 7, 2017 at 10:55 AM, Richard Guy Briggs wrote: >> On 2017-03-07 09:29, Paul Moore wrote: >>> On Mon, Mar 6, 2017 at 11:03 PM, Richard Guy Briggs wrote: >>> > On 2017-03-06

[PATCH ethtool] ethtool: print hash function with ethtool -x|--show-rxfh-indir

Make ethtool -x|--show-rxfh-indir print the RSS hash function name. Signed-off-by: Jakub Kicinski --- ethtool.8.in | 3 ++- ethtool.c| 31 +++ 2 files changed, 33 insertions(+), 1 deletion(-) diff --git a/ethtool.8.in

Re: [PATCH 10/29] drivers, md: convert stripe_head.count from atomic_t to refcount_t

On Mon, Mar 06, 2017 at 04:20:57PM +0200, Elena Reshetova wrote: > refcount_t type and corresponding API should be > used instead of atomic_t when the variable is used as > a reference counter. This allows to avoid accidental > refcounter overflows that might lead to use-after-free > situations. >

Re: net: heap out-of-bounds in fib6_clean_node/rt6_fill_node/fib6_age/fib6_prune_clone

On Tue, Mar 7, 2017 at 7:43 PM, David Ahern wrote: > On 3/7/17 11:13 AM, Dmitry Vyukov wrote: >>> on this warning: >>> >>> /* dst.next really should not be set at this point */ >>> if (rt->dst.next && rt->dst.next->ops->family != AF_INET6) { >>>

please add some examples to the ip man page

$ man ip should have some usage examples. Even one would be fine.

Re: [PATCH 08/29] drivers, md: convert mddev.active from atomic_t to refcount_t

On Mon, Mar 06, 2017 at 04:20:55PM +0200, Elena Reshetova wrote: > refcount_t type and corresponding API should be > used instead of atomic_t when the variable is used as > a reference counter. This allows to avoid accidental > refcounter overflows that might lead to use-after-free > situations.

Re: [PATCH RFC net-next v2 1/4] skbuff: add stub to help computing crc32c on SCTP packets

On Mon, Mar 6, 2017 at 1:51 PM, Davide Caratti wrote: > On Tue, 2017-02-28 at 14:46 -0800, Alexander Duyck wrote: >> On Tue, Feb 28, 2017 at 2:32 AM, Davide Caratti wrote: >> > >> > sctp_compute_checksum requires crc32c symbol (provided by libcrc32c), so

Re: net: heap out-of-bounds in fib6_clean_node/rt6_fill_node/fib6_age/fib6_prune_clone

On 3/7/17 11:13 AM, Dmitry Vyukov wrote: >> on this warning: >> >> /* dst.next really should not be set at this point */ >> if (rt->dst.next && rt->dst.next->ops->family != AF_INET6) { >> pr_warn("fib6_add: adding rt with bad next -- family %d dst >> flags %x\n", >>

Re: netlink: GPF in netlink_unicast

On Tue, Mar 7, 2017 at 10:55 AM, Richard Guy Briggs wrote: > On 2017-03-07 09:29, Paul Moore wrote: >> On Mon, Mar 6, 2017 at 11:03 PM, Richard Guy Briggs wrote: >> > On 2017-03-06 10:10, Cong Wang wrote: >> >> On Mon, Mar 6, 2017 at 2:54 AM, Dmitry Vyukov

Re: net: heap out-of-bounds in fib6_clean_node/rt6_fill_node/fib6_age/fib6_prune_clone

On 3/7/17 1:43 AM, Dmitry Vyukov wrote: > This is on c1ae3cfa0e89fa1a7ecc4c99031f5e9ae99d9201. No other kernel > output from your patch (pr_err). > > [ cut here ] > WARNING: CPU: 1 PID: 30179 at net/ipv6/ip6_fib.c:158 > rt6_rcu_free+0x61/0x70 net/ipv6/ip6_fib.c:158 >

Re: [PATCHv3 net-next 21/22] net: mvpp2: set dma mask and coherent dma mask on PPv2.2

Hello, On Tue, 7 Mar 2017 17:24:21 +, David Laight wrote: > Are the coherent mappings just used for ring structures? > If it might be reasonable to allocate them as a single entity, > thus guaranteeing they all reside in a single 4G region. Do we have the guarantee that a DMA coherent

Re: net: heap out-of-bounds in fib6_clean_node/rt6_fill_node/fib6_age/fib6_prune_clone

On Tue, Mar 7, 2017 at 7:03 PM, David Ahern wrote: > On 3/7/17 2:21 AM, Dmitry Vyukov wrote: >> I've commented that warning just to see I can obtain more information. >> Then I also got this: >> >> [ cut here ] >> WARNING: CPU: 2 PID: 3990 at

Re: net: heap out-of-bounds in fib6_clean_node/rt6_fill_node/fib6_age/fib6_prune_clone

On 3/7/17 2:21 AM, Dmitry Vyukov wrote: > I've commented that warning just to see I can obtain more information. > Then I also got this: > > [ cut here ] > WARNING: CPU: 2 PID: 3990 at net/ipv6/ip6_fib.c:991 > fib6_add+0x2e12/0x3290 net/ipv6/ip6_fib.c:991

Re: net: heap out-of-bounds in fib6_clean_node/rt6_fill_node/fib6_age/fib6_prune_clone

On Tue, Mar 7, 2017 at 6:17 PM, 'David Ahern' via syzkaller wrote: > On 3/7/17 1:43 AM, Dmitry Vyukov wrote: >> This is on c1ae3cfa0e89fa1a7ecc4c99031f5e9ae99d9201. No other kernel >> output from your patch (pr_err). > > Is the below supposed to be from the same qemu

[PATCH net] net/tunnel: set inner protocol in network gro hooks

The gso code of several tunnels type (gre and udp tunnels) takes for granted that the skb->inner_protocol is properly initialized and drops the packet elsewhere. On the forwarding path no one is initializing such field, so gro encapsulated packets are dropped on forward. Since commit

RE: [PATCHv3 net-next 21/22] net: mvpp2: set dma mask and coherent dma mask on PPv2.2

From: Thomas Petazzoni > Sent: 07 March 2017 15:53 > On PPv2.2, the streaming mappings can be anywhere in the first 40 bits > of the physical address space. However, for the coherent mappings, we > still need them to be in the first 32 bits of the address space, > because all BM pools share a

hello

hi

Re: [PATCH v2 0/6] Updates for Marvell Switch SoCs

Hi Chris, On jeu., févr. 16 2017, Chris Packham wrote: > Shortly after I posted my last series I got access to a more recent > Marvell SDK which had some device tree support for the switch SoCs I'd > been wanting. It was still based on an older kernel but

Re: [4.9.13] use after free in ipv4_mtu

On Tue, 2017-03-07 at 08:29 -0800, Stephen Hemminger wrote: > + WARN_ONCE(strcmp(default_qdisc_ops->id, "fq"), > + "TCP BBR should only be used with FQ qdisc\n"); > + > Why would that be needed, especially for people that properly setup their qdisc ? Maybe they do not

[PATCH RESEND v1] qed: Fix copy of uninitialized memory

In qed_ll2_start_ooo() the ll2_info variable is uninitialized and then passed to qed_ll2_acquire_connection() where it is copied into a new memory space. This shouldn't cause any issue as long as non of the copied memory is every read. But the potential for a bug being introduced by reading this

Re: [4.9.13] use after free in ipv4_mtu

On Mon, 06 Mar 2017 08:20:03 -0800 Eric Dumazet wrote: > On Mon, 2017-03-06 at 05:45 -0800, Eric Dumazet wrote: > > On Mon, 2017-03-06 at 14:33 +0800, Daniel J Blueman wrote: > > > > I do change the network queueing discipline and related at runtime [1] > > > which may

Re: [PATCH net 0/3] rds: tcp: fix various rds-tcp issues during netns create/delete sequences

On 3/7/2017 12:28 AM, Dmitry Vyukov wrote: On Tue, Mar 7, 2017 at 2:04 AM, santosh.shilim...@oracle.com wrote: On 3/4/17 8:57 AM, Sowmini Varadhan wrote: Dmitry Vyukov reported some syszkaller panics during netns deletion. While I have not been able to

Re: [PATCH] PCI: Add pci reset quirk for Cavium VNIC

On 07/03/17 15:04, Radoslaw Biernacki wrote: > From: Radoslaw Biernacki > > PCI reset quirk is needed for Cavium Function NIC since it does not > handle a function level reset. > This cause problems when VNIC is used from userspace by vfio. > If application (or VM)

Re: netlink: GPF in netlink_unicast

On 2017-03-07 09:29, Paul Moore wrote: > On Mon, Mar 6, 2017 at 11:03 PM, Richard Guy Briggs wrote: > > On 2017-03-06 10:10, Cong Wang wrote: > >> On Mon, Mar 6, 2017 at 2:54 AM, Dmitry Vyukov wrote: > >> > Hello, > >> > > >> > I've got the following crash

[PATCHv3 net-next 22/22] net: mvpp2: finally add the PPv2.2 compatible string

Now that the mvpp2 driver has been modified to accommodate the support for PPv2.2, we can finally advertise this support by adding the appropriate compatible string. At the same time, we update the Kconfig description of the MVPP2 driver. Signed-off-by: Thomas Petazzoni

[PATCHv3 net-next 15/22] net: mvpp2: handle register mapping and access for PPv2.2

This commit adjusts the mvpp2 driver register mapping and access logic to support PPv2.2, to handle a number of differences. Due to how the registers are laid out in memory, the Device Tree binding for the "reg" property is different: - On PPv2.1, we had a first area for the packet processor

[PATCHv3 net-next 17/22] net: mvpp2: add AXI bridge initialization for PPv2.2

The PPv2.2 unit is connected to an AXI bus on Armada 7K/8K, so this commit adds the necessary initialization of the AXI bridge. Signed-off-by: Thomas Petazzoni --- drivers/net/ethernet/marvell/mvpp2.c | 85 1 file

  1   2   >