[PATCH] net: ibm: emac: remove unused sysrq handler for 'c' key

2017-04-03 Thread Eric Biggers
From: Eric Biggers Since commit d6580a9f1523 ("kexec: sysrq: simplify sysrq-c handler"), the sysrq handler for the 'c' key has been sysrq_crash_op. Debugging code in the ibm_emac driver also tries to register a handler for the 'c' key, but this has no effect because

[PATCH net] sctp: get sock from transport in sctp_transport_update_pmtu

2017-04-03 Thread Xin Long
This patch is almost to revert commit 02f3d4ce9e81 ("sctp: Adjust PMTU updates to accomodate route invalidation."). As t->asoc can't be NULL in sctp_transport_update_pmtu, it could get sk from asoc, and no need to pass sk into that function. It is also to remove some duplicated codes from that

Re: [PATCH net-next v4 1/2] New kernel function to get IP overhead on a socket.

2017-04-03 Thread David Miller
From: "R. Parameswaran" Date: Mon, 3 Apr 2017 19:12:20 -0700 (PDT) > > > Hi Dave, > > Please see inline: > > On Mon, 3 Apr 2017, David Miller wrote: > >> From: "R. Parameswaran" >> Date: Mon, 3 Apr 2017 13:28:11 -0700 (PDT) >> >> > Can

Re: [PATCH net-next 0/5] qed: QM & ILT changes

2017-04-03 Thread David Miller
From: Yuval Mintz Date: Mon, 3 Apr 2017 12:21:08 +0300 > Please consider applying this series to 'net-next'. Series applied, thanks.

Re: [PATCH net-next v4 1/2] New kernel function to get IP overhead on a socket.

2017-04-03 Thread R. Parameswaran
Hi Dave, Please see inline: On Mon, 3 Apr 2017, David Miller wrote: > From: "R. Parameswaran" > Date: Mon, 3 Apr 2017 13:28:11 -0700 (PDT) > > > Can I take this to mean that we do need to factor in IP options in > > the L2TP device MTU setup (i.e approach in the

Re: [PATCHv4] net: usbnet: support 64bit stats

2017-04-03 Thread David Miller
From: Greg Ungerer Date: Mon, 3 Apr 2017 15:50:03 +1000 > Add support for the net stats64 counters to the usbnet core. With that > in place put the hooks into every usbnet driver to use it. > > This is a strait forward addition of 64bit counters for RX and TX packet > and

Re: [PATCH] soreuseport: use "unsigned int" in __reuseport_alloc()

2017-04-03 Thread David Miller
From: Alexey Dobriyan Date: Mon, 3 Apr 2017 01:18:23 +0300 > Number of sockets is limited by 16-bit, so 64-bit allocation will never > happen. > > 16-bit ops are the worst code density-wise on x86_64 because of > additional prefix (66). > > Space savings: > >

Re: [PATCH v2 2/3] flowcache: make flow_cache_hash_size() return "unsigned int"

2017-04-03 Thread David Miller
From: Alexey Dobriyan Date: Mon, 3 Apr 2017 00:52:29 +0300 > Hash size can't negative so "unsigned int" is logically correct. > > Propagate "unsigned int" to loop counters. > > Space savings: > > add/remove: 0/0 grow/shrink: 2/2 up/down: 6/-18 (-12) > function

Re: [PATCH v2 3/3] flowcache: more "unsigned int"

2017-04-03 Thread David Miller
From: Alexey Dobriyan Date: Mon, 3 Apr 2017 00:53:15 +0300 > Make ->hash_count, ->low_watermark and ->high_watermark unsigned int > and propagate unsignedness to other variables. > > This change doesn't change code generation because these fields aren't > used in 64-bit

Re: [PATCH v2 1/3] flowcache: make flow_key_size() return "unsigned int"

2017-04-03 Thread David Miller
From: Alexey Dobriyan Date: Mon, 3 Apr 2017 00:51:50 +0300 > Flow keys aren't 4GB+ numbers so 64-bit arithmetic is excessive. > > Space savings (I'm not sure what CSWTCH is): > > add/remove: 0/0 grow/shrink: 0/2 up/down: 0/-48 (-48) > function

Re: [patch net-next] net/faraday: Add missing include of of.h

2017-04-03 Thread David Miller
From: Andrew Lunn Date: Sun, 2 Apr 2017 20:20:47 +0200 > Breaking the include loop netdevice.h, dsa.h, devlink.h broke this > driver, it depends on includes brought in by these headers. Adding > linux/of.h fixes it. > > Fixes: ed0e39e97d34 ("net: break include loop netdevice.h,

Re: [PATCH net-next v4] vxlan: fix ND proxy when skb doesn't have transport header offset

2017-04-03 Thread David Miller
From: Vincent Bernat Date: Sun, 2 Apr 2017 11:00:06 +0200 > When an incoming frame is tagged or when GRO is disabled, the skb > handled to vxlan_xmit() doesn't contain a valid transport header > offset. This makes ND proxying fail. > > We combine two changes: replace use of

Re: [PATCH net] tcp: minimize false-positives on TCP/GRO check

2017-04-03 Thread David Miller
From: Marcelo Ricardo Leitner Date: Sat, 1 Apr 2017 11:00:21 -0300 > Markus Trippelsdorf reported that after commit dcb17d22e1c2 ("tcp: warn > on bogus MSS and try to amend it") the kernel started logging the > warning for a NIC driver that doesn't even support GRO. >

[PATCH next] bonding: fix active-backup transition

2017-04-03 Thread Mahesh Bandewar
From: Mahesh Bandewar Earlier patch c4adfc822bf5 ("bonding: make speed, duplex setting consistent with link state") made an attempt to keep slave state consistent with speed and duplex settings. Unfortunately link-state transition is used to change the active link especially

linux-next: manual merge of the net-next tree with the net tree

2017-04-03 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the net-next tree got a conflict in: net/core/flow_dissector.c between commit: ac6a3722fed6 ("flow dissector: correct size of storage for ARP") from the net tree and commit: 9bf881ffc5c0 ("flow_dissector: Move ARP dissection into a separate

[PATCH net-next] netlink/diag: report flags for netlink sockets

2017-04-03 Thread Andrei Vagin
From: Andrey Vagin cb_running is reported in /proc/self/net/netlink and it is reported by the ss tool, when it gets information from the proc files. sock_diag is a new interface which is used instead of proc files, so it looks reasonable that this interface has to report no

Re: [PATCH net] sctp: check for dst and pathmtu update in sctp_packet_config

2017-04-03 Thread David Miller
From: Xin Long Date: Sat, 1 Apr 2017 17:15:59 +0800 > This patch is to move sctp_transport_dst_check into sctp_packet_config > from sctp_packet_transmit and add pathmtu check in sctp_packet_config. > > With this fix, sctp can update dst or pathmtu before appending chunks,

Re: [PATCHv2 net-next] sctp: add SCTP_PR_STREAM_STATUS sockopt for prsctp

2017-04-03 Thread David Miller
From: Xin Long Date: Sat, 1 Apr 2017 17:07:46 +0800 > Before when implementing sctp prsctp, SCTP_PR_STREAM_STATUS wasn't > added, as it needs to save abandoned_(un)sent for every stream. > > After sctp stream reconf is added in sctp, assoc has structure > sctp_stream_out

Re: [PATCH V4 net-next 00/18] net: hns: Misc. HNS Bug Fixes & Code Improvements

2017-04-03 Thread David Miller
From: Salil Mehta Date: Sat, 1 Apr 2017 12:03:30 +0100 > This patch set introduces various HNS bug fixes, optimizations and code > improvements. Series applied, thanks.

Re: [PATCH net] flow dissector: correct size of storage for ARP

2017-04-03 Thread David Miller
From: Simon Horman Date: Mon, 3 Apr 2017 15:42:58 -0400 > The last argument to __skb_header_pointer() should be a buffer large > enough to store struct arphdr. This can be a pointer to a struct arphdr > structure. The code was previously using a pointer to a pointer

HELP ME PLEASE

2017-04-03 Thread abdoul issouf
Dear Friend I am Mr. Abdoul Issouf ,I work for BOA bank Ouagadougou Burkina Faso. I have a business proposal which concerns the transfer of $13.5 Million USD, into a foreign account. Everything about this transaction shall be legally done without any problem. If you are interested to help me,

Re: [PATCH net-next v4 1/2] New kernel function to get IP overhead on a socket.

2017-04-03 Thread David Miller
From: "R. Parameswaran" Date: Mon, 3 Apr 2017 13:28:11 -0700 (PDT) > Can I take this to mean that we do need to factor in IP options in > the L2TP device MTU setup (i.e approach in the posted patch is okay)? > > If yes, please let me know if I can keep the socket IP

Re: [PATCH net-next v4 1/2] New kernel function to get IP overhead on a socket.

2017-04-03 Thread R. Parameswaran
Hi James, Dave, Sorry for the delay (was away), please see inline: On Fri, 24 Mar 2017, James Chapman wrote: > On 24/03/17 01:51, R. Parameswaran wrote: > > Hi Dave, > > > > Please see inline: > > > > On Thu, 23 Mar 2017, David Miller wrote: > > > >> From: "R. Parameswaran"

[PATCH net] flow dissector: correct size of storage for ARP

2017-04-03 Thread Simon Horman
The last argument to __skb_header_pointer() should be a buffer large enough to store struct arphdr. This can be a pointer to a struct arphdr structure. The code was previously using a pointer to a pointer to struct arphdr. By my counting the storage available both before and after is 8 bytes on

RE: linux-4.11-rc5/drivers/net/wireless/ath/wil6210/pmc.c: 2 * poor place for limits check ?

2017-04-03 Thread qca_dlansky
From: David Binderman [mailto:dcb...@hotmail.com] Sent: Monday, April 3, 2017 2:16 PM > > Hello there, > > 1. > > linux-4.11-rc5/drivers/net/wireless/ath/wil6210/pmc.c:188]: (style) Array > index 'i' is used before limits check. Thanks for letting us know. We'll upload a fix soon. Thanks,

Re: [next-queue v6 PATCH 5/7] i40e: Add TX and RX support over port netdev's in switchdev mode

2017-04-03 Thread Samudrala, Sridhar
On 3/30/2017 2:26 AM, Or Gerlitz wrote: On Thu, Mar 30, 2017 at 3:22 AM, Sridhar Samudrala wrote: Any frames sent via port netdevs are sent as directed transmits to the corresponding VFs. okay, cool In switchdev mode, broadcasts from VFs are received by the PF

Re: [PATCH -next] liquidio: clear the correct memory

2017-04-03 Thread Felix Manlunas
From: Dan Carpenter Date: Mon, 2017-Apr-03 21:18:27 +0300 > There is a cut and paste bug here so we accidentally clear the first > few bytes of "resp" a second time instead clearing "ctx". > > Fixes: 50c0add534d2 ("liquidio: refactor interrupt moderation code") >

Re: [PATCH -next] net: sched: choke: remove some dead code

2017-04-03 Thread Jiri Pirko
Mon, Apr 03, 2017 at 08:18:41PM CEST, dan.carpen...@oracle.com wrote: >We accidentally left this dead code behind after commit 5952fde10c35 >("net: sched: choke: remove dead filter classify code"). > >Signed-off-by: Dan Carpenter Reviewed-by: Jiri Pirko

[PATCH -next] qed: Add a missing error code

2017-04-03 Thread Dan Carpenter
We should be returning -ENOMEM if qed_mcp_cmd_add_elem() fails. The current code returns success. Fixes: 4ed1eea82a21 ("qed: Revise MFW command locking") Signed-off-by: Dan Carpenter diff --git a/drivers/net/ethernet/qlogic/qed/qed_mcp.c

[PATCH -next] net: sched: choke: remove some dead code

2017-04-03 Thread Dan Carpenter
We accidentally left this dead code behind after commit 5952fde10c35 ("net: sched: choke: remove dead filter classify code"). Signed-off-by: Dan Carpenter diff --git a/net/sched/sch_choke.c b/net/sched/sch_choke.c index 040625fdc82b..f11f8732b0d5 100644 ---

[PATCH -next] liquidio: clear the correct memory

2017-04-03 Thread Dan Carpenter
There is a cut and paste bug here so we accidentally clear the first few bytes of "resp" a second time instead clearing "ctx". Fixes: 50c0add534d2 ("liquidio: refactor interrupt moderation code") Signed-off-by: Dan Carpenter diff --git

Re: [PATCH] net: ipv4: fix multipath RTM_GETROUTE behavior when iif is given

2017-04-03 Thread Florian Larysch
On Mon, Apr 03, 2017 at 01:33:39PM -0400, David Ahern wrote: > that function no longer exists since Nik's recent work > (bf4e0a3db97eb882368fd82980b3b1fa0b5b9778) Didn't notice that as I was looking at Linus' tree. Thanks. > So does the problem you noted still exist? Yes. And in fact, that

[PATCH net] netfilter: xt_TCPMSS: add more sanity tests on tcph->doff

2017-04-03 Thread Eric Dumazet
From: Eric Dumazet Denys provided an awesome KASAN report pointing to an use after free in xt_TCPMSS I have provided three patches to fix this issue, either in xt_TCPMSS or in xt_tcpudp.c. It seems xt_TCPMSS patch has the smallest possible impact. Signed-off-by: Eric

Re: [PATCH net-next] liquidio: use meaningful names for IRQs

2017-04-03 Thread Sunil Kovvuri
On Mon, Apr 3, 2017 at 8:33 PM, Ricardo Farrington wrote: > Hi Sunil - this implementation was verified with multiple adapters installed. > In this case, the field serves to differentiate the adapter. > >> LiquidIO--- > > Rick > No, what I was referring to

Re: [PATCH] net: ipv4: fix multipath RTM_GETROUTE behavior when iif is given

2017-04-03 Thread David Ahern
On 4/3/17 10:46 AM, Florian Larysch wrote: > inet_rtm_getroute synthesizes a skeletal ICMP skb, which is passed to > ip_route_input when iif is given. If a multipath route is present for > the designated destination, ip_multipath_icmp_hash ends up being called, that function no longer exists

Re: skb_over_panic using UDP and 6lowpan / fakelb

2017-04-03 Thread Cong Wang
(Cc'ing netdev and maintainers) On Mon, Mar 27, 2017 at 2:16 AM, David Palma wrote: > > Hi, > > Sending a simple UDP packet (39 bytes long), over a 6lowpan interface > (using fakelb), creates a kernel panic (skb_over_panic). > > Steps to reproduce, and more details, can be

Re: [B.A.T.M.A.N.] [PATCH] net: batman-adv: use new api ethtool_{get|set}_link_ksettings

2017-04-03 Thread Sven Eckelmann
On Samstag, 1. April 2017 08:40:54 CEST Sven Eckelmann wrote: [...] > Btw. the code you are modifying will most likely be dropped. Your patch will > get rejected because of this. But thanks for submitting the api conversion > patch (even when it will be rejected). The patch was now marked as

[PATCH net-next] net: stmmac: rx queue to dma channel mapping fix

2017-04-03 Thread Joao Pinto
In hardware configurations where multiple queues are active, the rx queue needs to be mapped into a dma channel, even if a single rx queue is used. Signed-off-by: Joao Pinto --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH] net: ipv4: fix multipath RTM_GETROUTE behavior when iif is given

2017-04-03 Thread Florian Larysch
inet_rtm_getroute synthesizes a skeletal ICMP skb, which is passed to ip_route_input when iif is given. If a multipath route is present for the designated destination, ip_multipath_icmp_hash ends up being called, which uses the source/destination addresses within the skb to calculate a hash.

RE: [PATCH net-next] liquidio: use meaningful names for IRQs

2017-04-03 Thread Ricardo Farrington
Hi Sunil - this implementation was verified with multiple adapters installed. In this case, the field serves to differentiate the adapter. > LiquidIO--- Rick -Original Message- From: Sunil Kovvuri [mailto:sunil.kovv...@gmail.com] Sent: Monday, April 03, 2017 2:56 AM To:

xilinx_axienet: No interrupts asserted in Tx path?

2017-04-03 Thread Alvaro G. M.
Hi I'm trying to use tri_mode_ethernet_mac & axi_dma cores from Vivado 2016.2, but I'm facing several problems that I believe are related to the linux' driver for these modules, xilinx_axienet_main.c First of all, I've noticed that __axienet_device_reset is called twice (once for TX and once

[Netdev conf Announce]: Keynote by David Miller

2017-04-03 Thread Jamal Hadi Salim
The tech committee is pleased to announce David Miller, Netdev Maintainer. David's keynote is titled "XDP Mythbusters". Come one, come all. David will sift out the fake from real news. cheers, jamal

RE: [PATCH net-next 2/5] qed: Fix TM block ILT allocation

2017-04-03 Thread Mintz, Yuval
> > + /* Timers is a special case -> we don't count how many cids require > > S/is/are/. CIDs? What's implicitly meant here is the 'Timer[s] HW block'. I understand it creates an odd looking English sentence, though. Assuming there'll be a V2 for this we'd revise the comment; Otherwise

Re: [PATCH] soreuseport: use "unsigned int" in __reuseport_alloc()

2017-04-03 Thread Craig Gallek
On Sun, Apr 2, 2017 at 6:18 PM, Alexey Dobriyan wrote: > Number of sockets is limited by 16-bit, so 64-bit allocation will never > happen. > > 16-bit ops are the worst code density-wise on x86_64 because of > additional prefix (66). So this boils down to a compiled code

[PATCH net-next] macb: Add hardware PTP support.

2017-04-03 Thread Rafal Ozieblo
This patch is based on original Harini's patch and Andrei's patch, implemented in aseparate file to ease the review/maintanance and integration with other platforms. In case that macb is compiled as a module, it has been renamed to cadence-macb.ko to avoid naming confusion in Makefile. This

Re: [PATCH net-next 1/1] net: tcp: Define the TCP_MAX_WSCALE instead of literal number 14

2017-04-03 Thread Neal Cardwell
On Mon, Apr 3, 2017 at 9:26 AM, Gao Feng wrote: >> >> Looks OK to me. >> >> IMHO this is a nice direction, since there is a proposal to increase the >> maximum >> shift factor from 14 to 15: >> https://tools.ietf.org/html/draft-nishida-tcpm-maxwin-03 > > Do you mean

Re: [PATCH] selftests: add a generic testsuite for ethernet device

2017-04-03 Thread Andrew Lunn
> By ifnum, you mean by the order that "ip link" gives ? I've not checked if it remains in order as interfaces are hot plugged/unplugged. But i guess you are running tests direct after boot, and unplugs/replugs are unlikely? Andrew

RE: [PATCH net-next 1/1] net: tcp: Define the TCP_MAX_WSCALE instead of literal number 14

2017-04-03 Thread Gao Feng
> -Original Message- > From: Neal Cardwell [mailto:ncardw...@google.com] > Sent: Monday, April 3, 2017 2:59 AM > To: gfree.w...@foxmail.com > Cc: David Miller ; Alexey Kuznetsov > ; James Morris ; Patrick McHardy >

Re: [PATCH 1/2] wireless: ath9k_htc: fix NULL-deref at probe

2017-04-03 Thread Johan Hovold
On Mon, Apr 03, 2017 at 01:21:08PM +, Kalle Valo wrote: > Johan Hovold writes: > > > On Mon, Apr 03, 2017 at 01:02:28PM +, Kalle Valo wrote: > >> Kalle Valo writes: > >> > >> > Johan Hovold writes: > >> > > >> >> On Mon, Mar

Re: Adding support for VRF traffic passed by mangle table

2017-04-03 Thread David Ahern
On 4/2/17 10:57 PM, Jack Ma wrote: > diff --git a/net/ipv4/netfilter.c b/net/ipv4/netfilter.c > index c0cc6aa..07168d4 100644 > --- a/net/ipv4/netfilter.c > +++ b/net/ipv4/netfilter.c > @@ -46,6 +46,14 @@ int ip_route_me_harder(struct net *net, struct sk_buff > *skb, unsigned int addr_t >

Re: [PATCH RFC v4 07/10] dt-bindings: net: add binding for QCA7000 UART

2017-04-03 Thread Rob Herring
On Tue, Mar 28, 2017 at 06:18:03PM +0200, Stefan Wahren wrote: > Am 27.03.2017 um 22:30 schrieb Rob Herring: > > On Mon, Mar 27, 2017 at 8:37 AM, Stefan Wahren > > wrote: > >> This is the serdev binding for the QCA7000 UART driver (Ethernet over > >> UART). > >> > >>

Re: [PATCH 1/2] wireless: ath9k_htc: fix NULL-deref at probe

2017-04-03 Thread Kalle Valo
Johan Hovold writes: > On Mon, Apr 03, 2017 at 01:02:28PM +, Kalle Valo wrote: >> Kalle Valo writes: >> >> > Johan Hovold writes: >> > >> >> On Mon, Mar 13, 2017 at 01:44:20PM +0100, Johan Hovold wrote: >> >>> Make sure to check

Re: [PATCH 1/2] wireless: ath9k_htc: fix NULL-deref at probe

2017-04-03 Thread Johan Hovold
On Mon, Apr 03, 2017 at 01:02:28PM +, Kalle Valo wrote: > Kalle Valo writes: > > > Johan Hovold writes: > > > >> On Mon, Mar 13, 2017 at 01:44:20PM +0100, Johan Hovold wrote: > >>> Make sure to check the number of endpoints to avoid dereferencing a >

Re: [PATCH] selftests: add a generic testsuite for ethernet device

2017-04-03 Thread Corentin Labbe
On Fri, Mar 31, 2017 at 04:12:41PM +0200, Andrew Lunn wrote: > On Fri, Mar 31, 2017 at 02:57:52PM +0200, Corentin Labbe wrote: > > This patch add a generic testsuite for testing ethernet network device > > driver. > > > > Signed-off-by: Corentin Labbe > > --- > >

Re: linux-next: manual merge of the net-next tree with the net tree

2017-04-03 Thread Daniel Borkmann
On 04/03/2017 04:07 AM, Stephen Rothwell wrote: Hi all, Today's linux-next merge of the net-next tree got conflicts in: tools/testing/selftests/bpf/Makefile tools/testing/selftests/bpf/test_verifier.c between commit: 02ea80b1850e ("bpf: add various verifier test cases for

Re: [PATCH] [net-next] stmmac: use netif_set_real_num_{rx,tx}_queues

2017-04-03 Thread Joao Pinto
Hello Peppe, Às 2:07 PM de 4/3/2017, Giuseppe CAVALLARO escreveu: > Hello Joao > > On 3/30/2017 6:42 PM, Joao Pinto wrote: >> Às 5:35 PM de 3/30/2017, Niklas Cassel escreveu: >>> On 03/30/2017 04:34 PM, Thierry Reding wrote: On Thu, Mar 30, 2017 at 09:45:36AM +0200, Corentin Labbe wrote:

Re: [PATCH] [net-next] stmmac: use netif_set_real_num_{rx,tx}_queues

2017-04-03 Thread Giuseppe CAVALLARO
Hello Joao On 3/30/2017 6:42 PM, Joao Pinto wrote: Às 5:35 PM de 3/30/2017, Niklas Cassel escreveu: On 03/30/2017 04:34 PM, Thierry Reding wrote: On Thu, Mar 30, 2017 at 09:45:36AM +0200, Corentin Labbe wrote: On Tue, Mar 28, 2017 at 06:01:05PM -0700, David Miller wrote: From: Arnd Bergmann

Re: [PATCH 1/2] wireless: ath9k_htc: fix NULL-deref at probe

2017-04-03 Thread Kalle Valo
Kalle Valo writes: > Johan Hovold writes: > >> On Mon, Mar 13, 2017 at 01:44:20PM +0100, Johan Hovold wrote: >>> Make sure to check the number of endpoints to avoid dereferencing a >>> NULL-pointer or accessing memory beyond the endpoint array should a

Re: [PATCH] can: rcar_can: Do not print virtual addresses

2017-04-03 Thread Sergei Shtylyov
On 04/03/2017 01:11 PM, Geert Uytterhoeven wrote: During probe, the rcar_can driver prints: rcar_can e6e8.can: device registered (regs @ e08bc000, IRQ76) The "regs" value is a virtual address, exposing internal information, hence stop printing it. The (useful) physical address is

Re: [PATCH v3 01/20] net: stmmac: export stmmac_set_mac_addr/stmmac_get_mac_addr

2017-04-03 Thread Giuseppe CAVALLARO
Hello Alex do you can check if this has to be done for ST platforms? I do not remember that it was necessary when build as module so I cannot expect this should be only for dwmac-sun8i. Regards peppe On 4/3/2017 11:14 AM, Corentin Labbe wrote: Thoses symbol will be needed for the

Re: [PATCH v3 02/20] net: stmmac: add optional setup function

2017-04-03 Thread Giuseppe CAVALLARO
Hello Corentin On 4/3/2017 11:14 AM, Corentin Labbe wrote: Instead of adding more ifthen logic for adding a new mac_device_info setup function, it is easier to add a function pointer to the function needed. Signed-off-by: Corentin Labbe ---

Re: KASAN, xt_TCPMSS finally found nasty use-after-free bug? 4.10.8

2017-04-03 Thread Eric Dumazet
On Mon, 2017-04-03 at 15:14 +0300, Denys Fedoryshchenko wrote: > On 2017-04-03 15:09, Eric Dumazet wrote: > > On Mon, 2017-04-03 at 11:10 +0300, Denys Fedoryshchenko wrote: > > > >> I modified patch a little as: > >> if (th->doff * 4 < sizeof(_tcph)) { > >> par->hotdrop = true; > >>

Re: KASAN, xt_TCPMSS finally found nasty use-after-free bug? 4.10.8

2017-04-03 Thread Denys Fedoryshchenko
On 2017-04-03 15:09, Eric Dumazet wrote: On Mon, 2017-04-03 at 11:10 +0300, Denys Fedoryshchenko wrote: I modified patch a little as: if (th->doff * 4 < sizeof(_tcph)) { par->hotdrop = true; WARN_ON_ONCE(!tcpinfo->option); return false; } And it did triggered WARN once at morning, and

Re: KASAN, xt_TCPMSS finally found nasty use-after-free bug? 4.10.8

2017-04-03 Thread Eric Dumazet
On Mon, 2017-04-03 at 11:10 +0300, Denys Fedoryshchenko wrote: > I modified patch a little as: > if (th->doff * 4 < sizeof(_tcph)) { > par->hotdrop = true; > WARN_ON_ONCE(!tcpinfo->option); > return false; > } > > And it did triggered WARN once at morning, and didn't hit KASAN. I will >

Re: in_irq_or_nmi() and RFC patch

2017-04-03 Thread Mel Gorman
On Thu, Mar 30, 2017 at 05:07:08PM +0200, Jesper Dangaard Brouer wrote: > On Thu, 30 Mar 2017 14:04:36 +0100 > Mel Gorman wrote: > > > On Wed, Mar 29, 2017 at 09:44:41PM +0200, Jesper Dangaard Brouer wrote: > > > > Regardless or using in_irq() (or in combi with

[PATCH] net: ethernet: ti: cpsw: fix race condition during open()

2017-04-03 Thread Sekhar Nori
TI's cpsw driver handles both OF and non-OF case for phy connect. Unfortunately of_phy_connect() returns NULL on error while phy_connect() returns ERR_PTR(). To handle this, cpsw_slave_open() overrides the return value from phy_connect() to make it NULL or error. This leaves a small window,

Re: [PATCH net-next 2/5] qed: Fix TM block ILT allocation

2017-04-03 Thread Sergei Shtylyov
On 4/3/2017 12:21 PM, Yuval Mintz wrote: From: Michal Kalderon When configuring the HW timers block we should set the number of CIDs up until the last CID that require timers, instead of only those CIDs whose protocol needs timers support. Today, the protocols

Re: [PATCH 16/16] drivers, net, intersil: convert request_context.refcount from atomic_t to refcount_t

2017-04-03 Thread Kalle Valo
Elena Reshetova writes: > refcount_t type and corresponding API should be > used instead of atomic_t when the variable is used as > a reference counter. This allows to avoid accidental > refcounter overflows that might lead to use-after-free > situations. > >

Re: [PATCH v3 20/20] ARM: sunxi: Enable dwmac-sun8i driver on multi_v7_defconfig

2017-04-03 Thread Maxime Ripard
On Mon, Apr 03, 2017 at 11:14:44AM +0200, Corentin Labbe wrote: > Enable the dwmac-sun8i driver in the multi_v7 default configuration Your prefix should be arm: multi_v7: Maxime -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com signature.asc

Re: [PATCH v3 16/20] ARM: dts: sun50i-a64: enable dwmac-sun8i on pine64

2017-04-03 Thread Maxime Ripard
On Mon, Apr 03, 2017 at 11:14:40AM +0200, Corentin Labbe wrote: > The dwmac-sun8i hardware is present on the pine64 > It uses an external PHY via RMII. > > Signed-off-by: Corentin Labbe Looks fine, but please use "arm64: allwinner: pine64: " as your title prefix. It

Re: [PATCH 15/16] drivers, net, intersil: convert hostap_cmd_queue.usecnt from atomic_t to refcount_t

2017-04-03 Thread Kalle Valo
Elena Reshetova writes: > refcount_t type and corresponding API should be > used instead of atomic_t when the variable is used as > a reference counter. This allows to avoid accidental > refcounter overflows that might lead to use-after-free > situations. > >

Re: [PATCH v3 12/20] ARM: dts: sun8i: Enable dwmac-sun8i on the Orange Pi plus

2017-04-03 Thread Maxime Ripard
On Mon, Apr 03, 2017 at 11:14:36AM +0200, Corentin Labbe wrote: > The dwmac-sun8i hardware is present on the Orange PI plus. > It uses an external PHY rtl8211e via RGMII. > > This patch create the needed regulator, emac and phy nodes. > > Signed-off-by: Corentin Labbe

Re: [PATCH net] sctp: check for dst and pathmtu update in sctp_packet_config

2017-04-03 Thread Neil Horman
On Sat, Apr 01, 2017 at 05:15:59PM +0800, Xin Long wrote: > This patch is to move sctp_transport_dst_check into sctp_packet_config > from sctp_packet_transmit and add pathmtu check in sctp_packet_config. > > With this fix, sctp can update dst or pathmtu before appending chunks, > which can void

pull-request: wireless-drivers-next 2017-04-03

2017-04-03 Thread Kalle Valo
Hi Dave, here few really small fixes. I'm hoping this to be the last pull request for 4.11. Please let me if there are any problems. Kalle The following changes since commit 6be3b6cce1e225f189b68b4e84fc711d19b4277b: ath10k: fix incorrect wlan_mac_base in qca6174_regs (2017-03-20 17:11:31

[PATCH net] l2tp: fix PPP pseudo-wire auto-loading

2017-04-03 Thread Guillaume Nault
PPP pseudo-wire type is 7 (11 is L2TP_PWTYPE_IP). Fixes: f1f39f911027 ("l2tp: auto load type modules") Signed-off-by: Guillaume Nault --- net/l2tp/l2tp_ppp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/l2tp/l2tp_ppp.c b/net/l2tp/l2tp_ppp.c index

Re: [PATCH v3 04/20] ARM: sun8i: dt: Add DT bindings documentation for Allwinner syscon

2017-04-03 Thread Maxime Ripard
On Mon, Apr 03, 2017 at 11:14:28AM +0200, Corentin Labbe wrote: > Signed-off-by: Corentin Labbe > --- > .../devicetree/bindings/misc/allwinner,syscon.txt | 19 > +++ > 1 file changed, 19 insertions(+) > create mode 100644 >

Re: [PATCH v3 03/20] dt-bindings: net: Add DT bindings documentation for Allwinner dwmac-sun8i

2017-04-03 Thread Maxime Ripard
On Mon, Apr 03, 2017 at 11:14:27AM +0200, Corentin Labbe wrote: > This patch adds documentation for Device-Tree bindings for the > Allwinner dwmac-sun8i driver. > > Signed-off-by: Corentin Labbe > Acked-by: Rob Herring > --- >

[PATCH v3] tracing/kprobes: expose maxactive for kretprobe in kprobe_events

2017-04-03 Thread Alban Crequy
From: Alban Crequy When a kretprobe is installed on a kernel function, there is a maximum limit of how many calls in parallel it can catch (aka "maxactive"). A kernel module could call register_kretprobe() and initialize maxactive (see example in

ethtool-4.8.tar.gz checksum change

2017-04-03 Thread Paul Barker
Hi, It looks like the checksum of the following file has changed recently: https://www.kernel.org/pub/software/network/ethtool/ethtool-4.8.tar.gz Original checksum from around 23/10/2016: md5sum = 28c4a4d85c33f573c49ff6d81ec094fd sha256sum =

[PATCH] bnx2x: fix spelling mistake in macros HW_INTERRUT_ASSERT_SET_*

2017-04-03 Thread Colin King
From: Colin Ian King Trival fix, rename HW_INTERRUT_ASSERT_SET_* to HW_INTERRUPT_ASSERT_SET_* Signed-off-by: Colin Ian King --- drivers/net/ethernet/broadcom/bnx2x/bnx2x.h | 6 +++--- drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c |

[PATCH] can: rcar_can: Do not print virtual addresses

2017-04-03 Thread Geert Uytterhoeven
During probe, the rcar_can driver prints: rcar_can e6e8.can: device registered (regs @ e08bc000, IRQ76) The "regs" value is a virtual address, exposing internal information, hence stop printing it. The (useful) physical address is already printed as part of the device name. Fixes:

[PATCH net] l2tp: take reference on sessions being dumped

2017-04-03 Thread Guillaume Nault
Take a reference on the sessions returned by l2tp_session_find_nth() (and rename it l2tp_session_get_nth() to reflect this change), so that caller is assured that the session isn't going to disappear while processing it. For procfs and debugfs handlers, the session is held in the .start()

Re: [PATCH net-next] liquidio: use meaningful names for IRQs

2017-04-03 Thread Sunil Kovvuri
On Tue, Mar 14, 2017 at 1:28 AM, Felix Manlunas wrote: > From: Rick Farrington > > All IRQs owned by the PF and VF drivers share the same nondescript name > "octeon"; this makes it difficult to setup interrupt affinity. > > Change the IRQ

[PATCH][V2] wlcore: fix spelling mistakes in wl1271_warning

2017-04-03 Thread Colin King
From: Colin Ian King trivial fix to spelling mistakes in wl1271_warning error message, change iligal to invalid and opperation to operation. Signed-off-by: Colin Ian King --- drivers/net/wireless/ti/wlcore/debugfs.c | 2 +- 1 file changed, 1

Re: [PATCH] wlcore: fix spelling mistake in wl1271_warning 'iligal' -> 'illegal'

2017-04-03 Thread Colin Ian King
On 03/04/17 10:20, Joe Perches wrote: > On Mon, 2017-04-03 at 10:15 +0100, Colin King wrote: >> From: Colin Ian King >> >> trivial fix to spelling mistake in wl1271_warning error message >> >> Signed-off-by: Colin Ian King >> --- >>

Re: [PATCH 1/2] wireless: ath9k_htc: fix NULL-deref at probe

2017-04-03 Thread Kalle Valo
Johan Hovold writes: > On Mon, Mar 13, 2017 at 01:44:20PM +0100, Johan Hovold wrote: >> Make sure to check the number of endpoints to avoid dereferencing a >> NULL-pointer or accessing memory beyond the endpoint array should a >> malicious device lack the expected endpoints. >>

[PATCH v3 02/20] net: stmmac: add optional setup function

2017-04-03 Thread Corentin Labbe
Instead of adding more ifthen logic for adding a new mac_device_info setup function, it is easier to add a function pointer to the function needed. Signed-off-by: Corentin Labbe --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 4 +++- include/linux/stmmac.h

[PATCH v3 00/20] net-next: stmmac: add dwmac-sun8i ethernet driver

2017-04-03 Thread Corentin Labbe
Hello This patch series add the driver for dwmac-sun8i which handle the Ethernet MAC present on Allwinner H3/H5/A83T/A64 SoCs. This driver is the continuation of the sun8i-emac driver. During the development, it appeared that in fact the hardware was a modified version of some dwmac. So the

[PATCH v3 01/20] net: stmmac: export stmmac_set_mac_addr/stmmac_get_mac_addr

2017-04-03 Thread Corentin Labbe
Thoses symbol will be needed for the dwmac-sun8i ethernet driver. For letting it to be build as module, they need to be exported. Signed-off-by: Corentin Labbe --- drivers/net/ethernet/stmicro/stmmac/dwmac_lib.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)

[PATCH v3 03/20] dt-bindings: net: Add DT bindings documentation for Allwinner dwmac-sun8i

2017-04-03 Thread Corentin Labbe
This patch adds documentation for Device-Tree bindings for the Allwinner dwmac-sun8i driver. Signed-off-by: Corentin Labbe Acked-by: Rob Herring --- .../devicetree/bindings/net/dwmac-sun8i.txt| 77 ++ 1 file changed, 77

[PATCH v3 04/20] ARM: sun8i: dt: Add DT bindings documentation for Allwinner syscon

2017-04-03 Thread Corentin Labbe
Signed-off-by: Corentin Labbe --- .../devicetree/bindings/misc/allwinner,syscon.txt | 19 +++ 1 file changed, 19 insertions(+) create mode 100644 Documentation/devicetree/bindings/misc/allwinner,syscon.txt diff --git

[PATCH v3 06/20] ARM: dts: sunxi-h3-h5: Add dt node for the syscon control module

2017-04-03 Thread Corentin Labbe
This patch add the dt node for the syscon register present on the Allwinner H3/H5 Only two register are present in this syscon and the only one useful is the one dedicated to EMAC clock.. Signed-off-by: Corentin Labbe --- arch/arm/boot/dts/sunxi-h3-h5.dtsi | 6 ++

[PATCH v3 10/20] ARM: dts: sun8i: Enable dwmac-sun8i on the Orange Pi 2

2017-04-03 Thread Corentin Labbe
The dwmac-sun8i hardware is present on the Orange PI 2. It uses the internal PHY. This patch create the needed emac node. Signed-off-by: Corentin Labbe --- arch/arm/boot/dts/sun8i-h3-orangepi-2.dts | 8 1 file changed, 8 insertions(+) diff --git

[PATCH v3 11/20] ARM: dts: sun8i: Enable dwmac-sun8i on the Orange PI One

2017-04-03 Thread Corentin Labbe
The dwmac-sun8i hardware is present on the Orange PI One. It uses the internal PHY. This patch create the needed emac node. Signed-off-by: Corentin Labbe --- arch/arm/boot/dts/sun8i-h3-orangepi-one.dts | 8 1 file changed, 8 insertions(+) diff --git

[PATCH v3 05/20] net: stmmac: Add dwmac-sun8i

2017-04-03 Thread Corentin Labbe
The dwmac-sun8i is a heavy hacked version of stmmac hardware by allwinner. In fact the only common part is the descriptor management and the first register function. Signed-off-by: Corentin Labbe --- drivers/net/ethernet/stmicro/stmmac/Kconfig| 11 +

[PATCH net-next 4/5] qed: RoCE doesn't need to use SRC

2017-04-03 Thread Yuval Mintz
As RoCE doesn't need to use the SRC, allocating ILT memory on behalf of RoCE is wasting available ILT lines. Signed-off-by: Yuval Mintz --- drivers/net/ethernet/qlogic/qed/qed_cxt.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git

[PATCH net-next 5/5] qed: Manage with less memory regions for RoCE

2017-04-03 Thread Yuval Mintz
From: Ram Amrani It's possible some configurations would prevent driver from utilizing all the Memory Regions due to a lack of ILT lines. In such a case, calculate how many memory regions would have to be dropped due to limit, and manage without those. Signed-off-by: Ram

[PATCH net-next 0/5] qed: QM & ILT changes

2017-04-03 Thread Yuval Mintz
This series introduces several changes and improvements to existing queue manager and ILT configurations done during initialization. Notice some of the patches are actually future fixes, I.e., bugs that can't be triggered with exisiting driver but are needed for some future functionality. Patch

[PATCH v3 12/20] ARM: dts: sun8i: Enable dwmac-sun8i on the Orange Pi plus

2017-04-03 Thread Corentin Labbe
The dwmac-sun8i hardware is present on the Orange PI plus. It uses an external PHY rtl8211e via RGMII. This patch create the needed regulator, emac and phy nodes. Signed-off-by: Corentin Labbe --- arch/arm/boot/dts/sun8i-h3-orangepi-plus.dts | 36

[PATCH net-next 2/5] qed: Fix TM block ILT allocation

2017-04-03 Thread Yuval Mintz
From: Michal Kalderon When configuring the HW timers block we should set the number of CIDs up until the last CID that require timers, instead of only those CIDs whose protocol needs timers support. Today, the protocols that require HW timers' support have their CIDs

  1   2   >