[PATCH net-next] ipv4: route: restore skb_dst_set in inet_rtm_getroute

2017-05-31 Thread Roopa Prabhu
From: Roopa Prabhu recent updates to inet_rtm_getroute dropped skb_dst_set in inet_rtm_getroute. This patch restores it because it is needed to release the dst correctly. Fixes: 3765d35ed8b9 ("net: ipv4: Convert inet_rtm_getroute to rcu versions of route lookup")

Re: [PATCH linux-firmware] Mellanox: Add firmware for mlxsw_spectrum

2017-05-31 Thread Yotam Gigi
On 05/30/2017 10:22 PM, Kyle McMartin wrote: > On Mon, May 29, 2017 at 01:42:28PM +0300, Yotam Gigi wrote: >> Add first firmware for the Mellanox Spectrum switch, as a followup to the >> recently added commit: >> 6b7421992b8d ("mlxsw: spectrum: Validate firmware revision on init") >> >> The

RE: [PATCH v2] net: fec: add post PHY reset delay DT property

2017-05-31 Thread Andy Duan
From: Florian Fainelli Sent: Thursday, June 01, 2017 9:53 AM >To: Andy Duan ; Rob Herring ; >Quentin Schulz >Cc: mark.rutl...@arm.com; netdev@vger.kernel.org; >devicet...@vger.kernel.org;

Re: [PATCH] b43legacy: Fix a sleep-in-atomic bug in b43legacy_op_bss_info_changed

2017-05-31 Thread Michael Büsch
On Wed, 31 May 2017 19:07:15 -0500 Larry Finger wrote: > On 05/31/2017 10:32 AM, Michael Büsch wrote: > > On Wed, 31 May 2017 13:26:43 +0300 > > Kalle Valo wrote: > > > >> Jia-Ju Bai writes: > >> > >>> The driver may

Re: [PATCH] b43legacy: Fix a sleep-in-atomic bug in b43legacy_op_bss_info_changed

2017-05-31 Thread Michael Büsch
On Thu, 01 Jun 2017 07:27:20 +0300 Kalle Valo wrote: > Michael Büsch writes: > > >> > --- a/drivers/net/wireless/broadcom/b43legacy/main.c > >> > +++ b/drivers/net/wireless/broadcom/b43legacy/main.c > >> > @@ -2859,7 +2859,9 @@ static void

Re: [PATCH] xfrm: fix xfrm_dev_event() missing when compile without CONFIG_XFRM_OFFLOAD

2017-05-31 Thread kbuild test robot
Hi Hangbin, [auto build test ERROR on ipsec/master] [also build test ERROR on v4.12-rc3 next-20170531] [cannot apply to ipsec-next/master] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Hangbin

Re: [PATCH net-next v2 4/8] net: ipv4: Convert inet_rtm_getroute to rcu versions of route lookup

2017-05-31 Thread Roopa Prabhu
On Wed, May 31, 2017 at 2:48 PM, David Ahern wrote: > On 5/31/17 2:11 PM, John Fastabend wrote: >>> @@ -2721,14 +2724,14 @@ static int inet_rtm_getroute(struct sk_buff >>> *in_skb, struct nlmsghdr *nlh, >>> skb->protocol = htons(ETH_P_IP); >>>

Re: [PATCH] b43legacy: Fix a sleep-in-atomic bug in b43legacy_op_bss_info_changed

2017-05-31 Thread Kalle Valo
Michael Büsch writes: >> > --- a/drivers/net/wireless/broadcom/b43legacy/main.c >> > +++ b/drivers/net/wireless/broadcom/b43legacy/main.c >> > @@ -2859,7 +2859,9 @@ static void b43legacy_op_bss_info_changed(struct >> > ieee80211_hw *hw, >> >b43legacy_write32(dev,

Re: [PATCH] b43legacy: Fix a sleep-in-atomic bug in b43legacy_attr_interfmode_store

2017-05-31 Thread Kalle Valo
Jia-Ju Bai writes: >> Did you actually observe the attempt to sleep under the spin lock, >> or did you discover this using some tool? In other words, have >> either of your patches been tested? > > In fact, my reported bugs are found by a static analysis tool written > by

[PATCH net-next] bpf: Take advantage of stack_depth tracking in sparc64 JIT

2017-05-31 Thread David Miller
Signed-off-by: David S. Miller --- Committed to net-next. arch/sparc/net/bpf_jit_comp_64.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/arch/sparc/net/bpf_jit_comp_64.c b/arch/sparc/net/bpf_jit_comp_64.c index 4a52d34..098874a 100644 ---

[PATCH] cw1200: Fix a sleep-in-atomic bug in cw1200_tx_confirm_cb and cw1200_cqm_bssloss_sm

2017-05-31 Thread Jia-Ju Bai
The driver may sleep under a spin lock, and the function call path is: cw1200_tx_confirm_cb (acquire the lock by spin_lock) __cw1200_cqm_bssloss_sm cancel_work_sync --> may sleep cw1200_cqm_bssloss_sm __cw1200_cqm_bssloss_sm cancel_work_sync --> may sleep To fix it, the lock is

Re: [PATCH v2 net-next 0/8] Introduce bpf ID

2017-05-31 Thread Jakub Kicinski
On Wed, 31 May 2017 11:58:54 -0700, Martin KaFai Lau wrote: > This patch series: > 1) Introduce ID for both bpf_prog and bpf_map. > 2) Add bpf commands to iterate the prog IDs and map >IDs of the system. > 3) Add bpf commands to get a prog/map fd from an ID > 4) Add bpf command to get prog/map

Re: [PATCH v2] net: fec: add post PHY reset delay DT property

2017-05-31 Thread Florian Fainelli
Le 05/31/17 à 18:39, Andy Duan a écrit : > From: Rob Herring Sent: Thursday, June 01, 2017 12:44 AM >> On Tue, May 23, 2017 at 11:48:08AM +0200, Quentin Schulz wrote: >>> Some PHY require to wait for a bit after the reset GPIO has been >>> toggled. This adds support for the DT

RE: [PATCH v2] net: fec: add post PHY reset delay DT property

2017-05-31 Thread Andy Duan
From: Rob Herring Sent: Thursday, June 01, 2017 12:44 AM >On Tue, May 23, 2017 at 11:48:08AM +0200, Quentin Schulz wrote: >> Some PHY require to wait for a bit after the reset GPIO has been >> toggled. This adds support for the DT property `phy-reset-post-delay` >> which gives

linux-next: manual merge of the net-next tree with the net tree

2017-05-31 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the net-next tree got a conflict in: drivers/net/phy/marvell.c between commit: 898805e0cdf7 ("net: phy: fix marvell phy status reading") from the net tree and commit: e1dde8dc5b27 ("net: phy: marvell: Refactor some bigger functions") from the

[PATCH V4] neigh: Really delete an arp/neigh entry on "ip neigh delete" or "arp -d"

2017-05-31 Thread Sowmini Varadhan
The command # arp -s 62.2.0.1 a:b:c:d:e:f dev eth2 adds an entry like the following (listed by "arp -an") ? (62.2.0.1) at 0a:0b:0c:0d:0e:0f [ether] PERM on eth2 but the symmetric deletion command # arp -i eth2 -d 62.2.0.1 does not remove the PERM entry from the table, and instead leaves

Re: [PATCH V3] neigh: Really delete an arp/neigh entry on "ip neigh delete" or "arp -d"

2017-05-31 Thread Sowmini Varadhan
On (06/01/17 01:41), Julian Anastasov wrote: > Another problem is that neigh_update() changes the > state but before we go and unlink the entry another CPU > can reactivate the entry, i.e. NUD_INCOMPLETE entered > in __neigh_event_send(). So, there will be always some > small window where

Re: net/ipv6: use-after-free in ip6_dst_ifdown

2017-05-31 Thread David Ahern
On 5/31/17 4:49 PM, Cong Wang wrote: == BUG: KASAN: use-after-free in ip6_dst_ifdown+0x3cc/0x400 net/ipv6/route.c:422 Read of size 8 at addr 88006afa4ad8 by task syz-executor6/23554 >>> >>> >>> This one is

[PATCH net-next v2 1/2] bpf: Allow CGROUP_SKB eBPF program to access sk_buff

2017-05-31 Thread Chenbo Feng
From: Chenbo Feng This allows cgroup eBPF program to classify packet based on their protocol or other detail information. Currently program need CAP_NET_ADMIN privilege to attach a cgroup eBPF program, and A process with CAP_NET_ADMIN can already see all packets on the system,

[PATCH net-next v2 2/2] bpf: Remove the capability check for cgroup skb eBPF program

2017-05-31 Thread Chenbo Feng
From: Chenbo Feng Currently loading a cgroup skb eBPF program require a CAP_SYS_ADMIN capability while attaching the program to a cgroup only requires the user have CAP_NET_ADMIN privilege. We can escape the capability check when load the program just like socket filter program

[PATCH net-next v2] bpf: Remove the capability check for cgroup skb eBPF program

2017-05-31 Thread Chenbo Feng
From: Chenbo Feng Currently loading a cgroup skb eBPF program require a CAP_SYS_ADMIN capability while attaching the program to a cgroup only requires the user have CAP_NET_ADMIN privilege. We can escape the capability check when load the program just like socket filter program

Re: [PATCH] b43legacy: Fix a sleep-in-atomic bug in b43legacy_op_bss_info_changed

2017-05-31 Thread Jia-Ju Bai
On 06/01/2017 08:07 AM, Larry Finger wrote: On 05/31/2017 10:32 AM, Michael Büsch wrote: On Wed, 31 May 2017 13:26:43 +0300 Kalle Valo wrote: Jia-Ju Bai writes: The driver may sleep under a spin lock, and the function call path is:

Re: [PATCH] b43legacy: Fix a sleep-in-atomic bug in b43legacy_attr_interfmode_store

2017-05-31 Thread Jia-Ju Bai
On 06/01/2017 01:33 AM, Larry Finger wrote: On 05/31/2017 05:29 AM, Jia-Ju Bai wrote: The driver may sleep under a spin lock, and the function call path is: b43legacy_attr_interfmode_store (acquire the lock by spin_lock_irqsave) b43legacy_radio_set_interference_mitigation

Re: [PATCH v5 net-next 0/5] dsa: add Microchip KSZ9477 DSA driver

2017-05-31 Thread David Miller
From: Date: Wed, 31 May 2017 20:19:00 + > From: Woojung Huh > > This series of patches is for Microchip KSZ9477 DSA driver. > KSZ9477 is 7 ports GigE switch with numerous advanced features. > 5 ports are 10/100/1000 Mbps internal PHYs

[PATCH] xfrm: fix xfrm_dev_event() missing when compile without CONFIG_XFRM_OFFLOAD

2017-05-31 Thread Hangbin Liu
In commit d77e38e612a0 ("xfrm: Add an IPsec hardware offloading API") we make xfrm_device.o only compiled when enable option CONFIG_XFRM_OFFLOAD. But this will make xfrm_dev_event() missing if we only enable default XFRM options. So when we set down and unregister an interface with IPsec on it.

Re: [PATCH net-next] liquidio: Fix checkpatch errors with references crossing single line

2017-05-31 Thread Joe Perches
On Wed, 2017-05-31 at 10:45 -0700, Felix Manlunas wrote: > > From: Satanand Burla > > > Signed-off-by: Satanand Burla > > Signed-off-by: Derek Chickles > > Signed-off-by: Felix Manlunas

RE: [PATCH net-next 2/2] bpf: Remove the capability check for cgroup skb eBPF program

2017-05-31 Thread YUAN Linyu
hi > -Original Message- > From: netdev-ow...@vger.kernel.org [mailto:netdev-ow...@vger.kernel.org] > On Behalf Of Chenbo Feng > Sent: Thursday, June 01, 2017 2:07 AM > To: netdev@vger.kernel.org; David Miller > Cc: Lorenzo Colitti; Chenbo Feng > Subject: [PATCH net-next 2/2] bpf: Remove

Re: net/ipv4: use-after-free in add_grec

2017-05-31 Thread Eric Dumazet
On Wed, 2017-05-31 at 16:55 -0700, Eric Dumazet wrote: > The issue here is the timer firing while ip_mc_clear_src() has been > already called. > > My patch should fix the problem. > > Or another one using del_timer_sync() instead of del_timer() in > igmp_stop_timer(), but such a change would be

Re: [PATCH] b43legacy: Fix a sleep-in-atomic bug in b43legacy_op_bss_info_changed

2017-05-31 Thread Larry Finger
On 05/31/2017 10:32 AM, Michael Büsch wrote: On Wed, 31 May 2017 13:26:43 +0300 Kalle Valo wrote: Jia-Ju Bai writes: The driver may sleep under a spin lock, and the function call path is: b43legacy_op_bss_info_changed (acquire the lock by

Re: net/ipv4: use-after-free in add_grec

2017-05-31 Thread Eric Dumazet
On Wed, May 31, 2017 at 4:49 PM, Cong Wang wrote: > On Wed, May 31, 2017 at 9:12 AM, Eric Dumazet wrote: >> On Wed, 2017-05-31 at 11:46 +0200, Andrey Konovalov wrote: >>> Hi, >>> >>> I've got the following error report while fuzzing the kernel

Re: net/ipv4: use-after-free in add_grec

2017-05-31 Thread Cong Wang
On Wed, May 31, 2017 at 9:12 AM, Eric Dumazet wrote: > On Wed, 2017-05-31 at 11:46 +0200, Andrey Konovalov wrote: >> Hi, >> >> I've got the following error report while fuzzing the kernel with syzkaller. >> >> On commit 5ed02dbb497422bf225783f46e6eadd237d23d6b (4.12-rc3).

Re: [PATCH v2 net-next 0/8] Introduce bpf ID

2017-05-31 Thread David Miller
From: Martin KaFai Lau Date: Wed, 31 May 2017 11:58:54 -0700 > This patch series: > 1) Introduce ID for both bpf_prog and bpf_map. > 2) Add bpf commands to iterate the prog IDs and map >IDs of the system. > 3) Add bpf commands to get a prog/map fd from an ID > 4) Add bpf

Re: [PATCH net-next 6/9] bpf: fix stack_depth usage by test_bpf.ko

2017-05-31 Thread David Miller
From: Alexei Starovoitov Date: Wed, 31 May 2017 15:41:09 -0700 > On 5/31/17 11:45 AM, Alexei Starovoitov wrote: >> On 5/31/17 11:43 AM, David Miller wrote: >>> From: Alexei Starovoitov >>> Date: Wed, 31 May 2017 11:39:37 -0700 >>> On 5/31/17 11:15 AM, David Miller

Re: [PATCH net-next 0/9] bpf: stack depth tracking

2017-05-31 Thread David Miller
From: Alexei Starovoitov Date: Tue, 30 May 2017 13:31:26 -0700 > Introduce tracking of bpf program stack depth in the verifier and use that > info to reduce bpf program stack consumption in the interpreter and x64 JIT. > Other JITs can take advantage of it as well in the future. >

Re: [PATCH V3] neigh: Really delete an arp/neigh entry on "ip neigh delete" or "arp -d"

2017-05-31 Thread David Miller
From: Sowmini Varadhan Date: Tue, 30 May 2017 16:52:26 -0700 Just as a side note in the future, if you could fix the date and time on your computer, that would be awesome :-)

Re: [PATCH net-next 1/1] netvsc: Add #include's for csum_* function declarations

2017-05-31 Thread David Miller
From: Joe Perches Date: Wed, 31 May 2017 15:59:31 -0700 > On Wed, 2017-05-31 at 13:59 -0400, David Miller wrote: >> From: Michael Kelley >> Date: Tue, 30 May 2017 10:43:04 -0700 >> >> > Add direct #include statements for declarations of

Re: loosing netdevices with namespaces and unshare?

2017-05-31 Thread Harald Welte
Hi Cong, On Wed, May 31, 2017 at 03:40:33PM -0700, Cong Wang wrote: > But you have other choices than using the physical interface > directly in non-root ns, for example, creating a virtual pair and > connect it with the physical one with a bridge. There are various > ways to achieve this. Yes,

Re: [PATCH net-next 1/1] netvsc: Add #include's for csum_* function declarations

2017-05-31 Thread Joe Perches
On Wed, 2017-05-31 at 13:59 -0400, David Miller wrote: > From: Michael Kelley > Date: Tue, 30 May 2017 10:43:04 -0700 > > > Add direct #include statements for declarations of csum_tcpudp_magic() > > and csum_ipv6_magic(). While the needed #include's are picked up > >

Re: net/ipv6: use-after-free in ip6_dst_ifdown

2017-05-31 Thread Cong Wang
On Wed, May 31, 2017 at 9:55 AM, Eric Dumazet wrote: > On Wed, May 31, 2017 at 9:45 AM, Cong Wang wrote: >> On Wed, May 31, 2017 at 2:42 AM, Andrey Konovalov >> wrote: >>> Hi, >>> >>> I've got the following error report

Re: [PATCH V3] neigh: Really delete an arp/neigh entry on "ip neigh delete" or "arp -d"

2017-05-31 Thread Julian Anastasov
Hello, On Wed, 31 May 2017, Sowmini Varadhan wrote: > On (06/01/17 00:41), Julian Anastasov wrote: > > > > So, we do not hold reference to neigh while accessing > > its fields. I suspect we need to move the table lock from > > neigh_remove_one here, for example: > > good point,

Re: [PATCH net-next 6/9] bpf: fix stack_depth usage by test_bpf.ko

2017-05-31 Thread Alexei Starovoitov
On 5/31/17 11:45 AM, Alexei Starovoitov wrote: On 5/31/17 11:43 AM, David Miller wrote: From: Alexei Starovoitov Date: Wed, 31 May 2017 11:39:37 -0700 On 5/31/17 11:15 AM, David Miller wrote: From: Alexei Starovoitov Date: Tue, 30 May 2017 13:31:32 -0700

Re: loosing netdevices with namespaces and unshare?

2017-05-31 Thread Cong Wang
On Wed, May 31, 2017 at 11:11 AM, Harald Welte wrote: > I mean, what is the *use case* for loosing any refrence to a physical > network device and unregistering it from the stack? Is there any API by > which a new netdevice structure can be instantiated on the actual >

Re: [PATCH V3] neigh: Really delete an arp/neigh entry on "ip neigh delete" or "arp -d"

2017-05-31 Thread Sowmini Varadhan
On (06/01/17 00:41), Julian Anastasov wrote: > > So, we do not hold reference to neigh while accessing > its fields. I suspect we need to move the table lock from > neigh_remove_one here, for example: Another thought is to have neigh_remove_one to remove a neigh only if it is NUD_FAILED -

Re: [PATCH net-next 0/9] nfp: move BPF offload code into app

2017-05-31 Thread David Miller
From: Jakub Kicinski Date: Wed, 31 May 2017 08:06:42 -0700 > This series moves the eBPF offload code out of netdev/vNIC handling and > starts building the nfp_app. Port init is moved into the apps as well > because various apps associate vNICs, representors with

Re: [net-next 00/15][pull request] 10GbE Intel Wired LAN Driver Updates 2017-05-31

2017-05-31 Thread David Miller
From: Jeff Kirsher Date: Wed, 31 May 2017 14:19:21 -0700 > This series contains updates to ixgbe and ixgbevf only. Pulled, thanks Jeff.

Re: [net-next 0/9][pull request] 40GbE Intel Wired LAN Driver Updates 2017-05-31

2017-05-31 Thread David Miller
From: Jeff Kirsher Date: Wed, 31 May 2017 03:48:47 -0700 > This series contains updates to i40e and i40evf only. > > Jesse provides a couple of fixes, starting with cleaning up duplicate > lines of code. Fixed a missing line which enables RSS as a negotiated >

Re: [PATCH v2 1/2] ARM: dts: imx6ul-14x14-evk: Add ksz8081 phy properties

2017-05-31 Thread Florian Fainelli
On 05/31/2017 03:29 AM, Leonard Crestez wrote: > Right now mach-imx6ul registers a fixup for the ksz8081 phy. The same > register values can be set through the micrel phy driver by using dts > properties. > > This seems preferable and allows cleanly fixing suspend/resume. > > Signed-off-by:

Re: [PATCH v2 net 2/2] net: phy: micrel: Restore led_mode and clk_sel on resume

2017-05-31 Thread Florian Fainelli
On 05/31/2017 03:29 AM, Leonard Crestez wrote: > These bits seem to be lost after a suspend/resume cycle so just set them > again. Do this by splitting the handling of these bits into a function > that is also called on resume. > > This patch fixes ethernet suspend/resume on imx6ul-14x14-evk

Re: [PATCH net-next v2 4/8] net: ipv4: Convert inet_rtm_getroute to rcu versions of route lookup

2017-05-31 Thread David Ahern
On 5/31/17 2:11 PM, John Fastabend wrote: >> @@ -2721,14 +2724,14 @@ static int inet_rtm_getroute(struct sk_buff *in_skb, >> struct nlmsghdr *nlh, >> skb->protocol = htons(ETH_P_IP); >> skb->dev= dev; >> skb->mark = mark; >> -err

Re: [PATCH V3] neigh: Really delete an arp/neigh entry on "ip neigh delete" or "arp -d"

2017-05-31 Thread Sowmini Varadhan
On (06/01/17 00:41), Julian Anastasov wrote: > > So, we do not hold reference to neigh while accessing > its fields. I suspect we need to move the table lock from > neigh_remove_one here, for example: good point, let me think over your suggestion carefully (it sounds right, I want to make

Re: [i40e] regression on TCP stream and TCP maerts, kernel-4.12.0-0.rc2

2017-05-31 Thread Alexander Duyck
On Wed, May 31, 2017 at 6:48 AM, Adrian Tomasov wrote: > On Tue, 2017-05-30 at 18:27 -0700, Alexander Duyck wrote: >> On Tue, May 30, 2017 at 8:41 AM, Alexander Duyck >> wrote: >> > >> > On Tue, May 30, 2017 at 6:43 AM, Adam Okuliar

Re: [PATCH V3] neigh: Really delete an arp/neigh entry on "ip neigh delete" or "arp -d"

2017-05-31 Thread Julian Anastasov
Hello, On Tue, 30 May 2017, Sowmini Varadhan wrote: > @@ -1650,6 +1689,7 @@ static int neigh_delete(struct sk_buff *skb, struct > nlmsghdr *nlh, > NEIGH_UPDATE_F_ADMIN, > NETLINK_CB(skb).portid); > neigh_release(neigh); > +

Re: [PATCH v4 2/2] dt-bindings: net: Add Cortina device tree bindings

2017-05-31 Thread Rob Herring
On Mon, May 29, 2017 at 09:11:31AM +, Bogdan Purcareata wrote: > Add device tree description info for Cortina 10G phy devices. > > Signed-off-by: Bogdan Purcareata > --- > v3 -> v4: > - Consistency nit between phy label and reg value. > - Add CORTINNA trademark

[net-next 07/15] ixgbe: Resolve truncation warning for q_vector->name

2017-05-31 Thread Jeff Kirsher
From: Tony Nguyen The following warning is now shown as a result of new checks added for gcc 7: drivers/net/ethernet/intel/ixgbe/ixgbe_main.c: In function ‘ixgbe_open’: drivers/net/ethernet/intel/ixgbe/ixgbe_main.c:3118:13: warning: ‘%d’ directive output may be

[net-next 11/15] ixgbe: correct CS4223/7 PHY identification

2017-05-31 Thread Jeff Kirsher
From: Emil Tantilov Previous method was unreliable. Use a different register to differentiate between the SKUs. Signed-off-by: Emil Tantilov Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher

[net-next 12/15] ixgbe: add write flush when configuring CS4223/7

2017-05-31 Thread Jeff Kirsher
From: Emil Tantilov Make sure the writes are processed immediately. Without the flush it is possible for operations on one port to spill over the other as the resource is shared. Signed-off-by: Emil Tantilov Tested-by: Andrew Bowers

[net-next 03/15] ixgbe: Remove MAC X550EM_X 1Gbase-t led_[on|off] support

2017-05-31 Thread Jeff Kirsher
From: Paul Greenwalt Since FW configures the PHY and MAC X550EM_X has no PHY access, led_[on|off] is not supported with the 1Gbase-t design. Removed MAC X550EM_X 1Gbase-t led_[on|off] support by setting function pointers to NULL and added NULL pointer checks. Also set

[net-next 00/15][pull request] 10GbE Intel Wired LAN Driver Updates 2017-05-31

2017-05-31 Thread Jeff Kirsher
This series contains updates to ixgbe and ixgbevf only. Scott enables support for TSO & GSO for MPLS encapsulated packets for both ixgbe and ixgbevf. Liwei Song fixes an issue where seqcount/seqlock in ixgbe_get_stats64() are not initialized in time, so move the initialization into probe routine

[net-next 09/15] ixgbevf: Resolve truncation warning for q_vector->name

2017-05-31 Thread Jeff Kirsher
From: Tony Nguyen The following warning is now shown as a result of new checks added for gcc 7: drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c: In function ‘ixgbevf_open’: drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c:1363:13: warning: ‘%d’ directive output

[net-next 05/15] ixgbe: Correct thermal sensor event check

2017-05-31 Thread Jeff Kirsher
From: Mark Rustad The thermal sensor event logic is messed up, because it can execute the code when there is no thermal event. The current logic is that it will exit when !capable && !event whereas it really should exit when !capable || !event. For one thing, it means

[net-next 04/15] ixgbe: enable L3/L4 filtering for Tx switched packets

2017-05-31 Thread Jeff Kirsher
From: Emil Tantilov This will ensure that VF-to-VF traffic on the same PF is filtered to allow RSS operation. Signed-off-by: Emil Tantilov Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher

[net-next 10/15] ixgbevf: Resolve warnings for -Wimplicit-fallthrough

2017-05-31 Thread Jeff Kirsher
From: Tony Nguyen Additions to gcc 7 now warn whenever a switch statement falls through implicitly. This patch adds explicit fall through comments to address the following warnings: drivers/net/ethernet/intel/ixgbevf/vf.c: In function ‘ixgbevf_get_reta_locked’:

[net-next 15/15] ixgbe: fix incorrect status check

2017-05-31 Thread Jeff Kirsher
From: Emil Tantilov Check for ret_val instead of !ret_val to allow the rest of the code to execute and configure the speed properly. Signed-off-by: Emil Tantilov Tested-by: Krishneil Singh Signed-off-by: Jeff

[net-next 01/15] ixgbe/ixgbevf: Enables TSO for MPLS encapsulated packets

2017-05-31 Thread Jeff Kirsher
From: Scott Peterson This patch advertises TSO & GSO features in netdev->mpls_features. In ixgbe(vf)_tso() where we set up segmentation offload, the IP header will be the inner network header when eth_p_mpls() indicates the Ethernet protocol is MPLS (UC or MC).

[net-next 14/15] ixgbe: add missing configuration for rate select 1

2017-05-31 Thread Jeff Kirsher
From: Emil Tantilov Add RS1 configuration to ixgbe_set_soft_rate_select_speed() Signed-off-by: Emil Tantilov Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher ---

[net-next 02/15] ixgbe: initialize u64_stats_sync structures early at ixgbe_probe

2017-05-31 Thread Jeff Kirsher
From: Liwei Song Fix the following CallTrace: INFO: trying to register non-static key. the code is fine but needs lockdep annotation. turning off the locking correctness validator. CPU: 71 PID: 1 Comm: swapper/0 Not tainted 4.8.8-WR9.0.0.1_standard #11 Hardware name:

[net-next 08/15] ixgbe: Resolve warnings for -Wimplicit-fallthrough

2017-05-31 Thread Jeff Kirsher
From: Tony Nguyen This patch adds/changes fall through comments to address new warnings produced by gcc 7. Fixed formatting on a couple of comments in the function. Signed-off-by: Tony Nguyen Tested-by: Andrew Bowers

[net-next 13/15] ixgbe: always call setup_mac_link for multispeed fiber

2017-05-31 Thread Jeff Kirsher
From: Emil Tantilov Remove the logic which would previously skip the link configuration in the case where we are already at the requested speed in ixgbe_setup_mac_link_multispeed_fiber(). By exiting early we are skipping the link configuration and as such the driver

[net-next 06/15] ixgbe: Add error checking to setting VF MAC

2017-05-31 Thread Jeff Kirsher
From: Tony Nguyen Currently, when setting a VF MAC address there are no error checks to ensure that the MAC filter was successfully added. This patch adds additional error checks, reporting, and propagation of errors. It also will not set the MAC address unless

Re: [PATCH net] ibmvnic: Update module author

2017-05-31 Thread David Miller
From: Thomas Falcon Date: Wed, 31 May 2017 15:35:31 -0500 > Update the module author to be one of the original co-maintainers > of the driver. The original author left the project long ago and > so far has not responded to emails sent to the listed address. > >

Re: [PATCH 1/2] ip: include libc headers first

2017-05-31 Thread Baruch Siach
Hi Stephen, On Tue, May 30, 2017 at 05:31:51PM -0700, Stephen Hemminger wrote: > On Mon, 22 May 2017 16:27:53 +0300 > Baruch Siach wrote: > > > Including libc headers first helps as a workaround to redefinition of struct > > ethhdr with a suitably patched musl libc that

[PATCH net] ibmvnic: Update module author

2017-05-31 Thread Thomas Falcon
Update the module author to be one of the original co-maintainers of the driver. The original author left the project long ago and so far has not responded to emails sent to the listed address. Signed-off-by: John Allen Signed-off-by: Thomas Falcon

Re: [PATCH V6 net-next iproute] ip: Add support for netdev events to monitor

2017-05-31 Thread Vlad Yasevich
On 05/30/2017 02:26 PM, Vlad Yasevich wrote: > On 05/30/2017 01:12 PM, Stephen Hemminger wrote: >> On Sat, 27 May 2017 10:14:36 -0400 >> Vladislav Yasevich wrote: >> >>> >>> +static const char *netdev_events[] = {"NONE", >>> + "REBOOT", >>> +

Re: [PATCH v5 net-next 3/5] dsa: add DSA switch driver for Microchip KSZ9477

2017-05-31 Thread Andrew Lunn
On Wed, May 31, 2017 at 08:19:19PM +, woojung@microchip.com wrote: > From: Woojung Huh > > The KSZ9477 is a fully integrated layer 2, managed, 7 ports GigE switch > with numerous advanced features. 5 ports incorporate 10/100/1000 Mbps PHYs. > The other 2 ports

Re: [PATCH nf-next] netns: add and use net_ns_barrier

2017-05-31 Thread Joe Stringer
On 31 May 2017 at 11:13, Eric W. Biederman wrote: > Florian Westphal writes: > >> Quoting Joe Stringer: >> If a user loads nf_conntrack_ftp, sends FTP traffic through a network >> namespace, destroys that namespace then unloads the FTP helper module, >>

[PATCH v5 net-next 3/5] dsa: add DSA switch driver for Microchip KSZ9477

2017-05-31 Thread Woojung.Huh
From: Woojung Huh The KSZ9477 is a fully integrated layer 2, managed, 7 ports GigE switch with numerous advanced features. 5 ports incorporate 10/100/1000 Mbps PHYs. The other 2 ports have interfaces that can be configured as SGMII, RGMII, MII or RMII. Either of these

[PATCH v5 net-next 5/5] dsa: add maintainer of Microchip KSZ switches

2017-05-31 Thread Woojung.Huh
From: Woojung Huh Adding maintainer of Microchip KSZ switches. Reviewed-by: Andrew Lunn Reviewed-by: Florian Fainelli Signed-off-by: Woojung Huh --- MAINTAINERS | 10 ++ 1 file changed, 10

[PATCH v5 net-next 2/5] phy: micrel: add Microchip KSZ 9477 Switch PHY support

2017-05-31 Thread Woojung.Huh
From: Woojung Huh Adding Microchip 9477 Phy included in KSZ9477 Switch. Reviewed-by: Andrew Lunn Reviewed-by: Florian Fainelli Signed-off-by: Woojung Huh --- drivers/net/phy/micrel.c | 11

[PATCH v5 net-next 1/5] dsa: add support for Microchip KSZ tail tagging

2017-05-31 Thread Woojung.Huh
From: Woojung Huh Adding support for the Microchip KSZ switch family tail tagging. Reviewed-by: Andrew Lunn Reviewed-by: Florian Fainelli Signed-off-by: Woojung Huh --- include/net/dsa.h | 1 +

[PATCH v5 net-next 0/5] dsa: add Microchip KSZ9477 DSA driver

2017-05-31 Thread Woojung.Huh
From: Woojung Huh This series of patches is for Microchip KSZ9477 DSA driver. KSZ9477 is 7 ports GigE switch with numerous advanced features. 5 ports are 10/100/1000 Mbps internal PHYs and 2 ports have Interfaces to SGMII, RGMII, MII or RMII. This patch supports VLAN,

Re: [PATCH net-next v2 4/8] net: ipv4: Convert inet_rtm_getroute to rcu versions of route lookup

2017-05-31 Thread John Fastabend
On 05/25/2017 10:42 AM, Roopa Prabhu wrote: > From: David Ahern > > Convert inet_rtm_getroute to use ip_route_input_rcu and > ip_route_output_key_hash_rcu passing the fib_result arg to both. > The rcu lock is held through the creation of the response, so the > rtable/dst does

Re: [PATCH net-next] net: phy: use of_mdio_parse_addr

2017-05-31 Thread Florian Fainelli
On 05/31/2017 12:43 PM, Jon Mason wrote: > use of_mdio_parse_addr() in place of an OF read of reg and a bounds > check (which is litterally the exact same thing that > of_mdio_parse_addr() does) > > Signed-off-by: Jon Mason Reviewed-by: Florian Fainelli

Re: [PATCH net-next] net: phy: use of_mdio_parse_addr

2017-05-31 Thread Andrew Lunn
On Wed, May 31, 2017 at 03:43:30PM -0400, Jon Mason wrote: > use of_mdio_parse_addr() in place of an OF read of reg and a bounds > check (which is litterally the exact same thing that > of_mdio_parse_addr() does) > > Signed-off-by: Jon Mason Reviewed-by: Andrew Lunn

Re: [PATCH net] tcp: disallow cwnd undo when switching congestion control

2017-05-31 Thread Yuchung Cheng
On Wed, May 31, 2017 at 11:47 AM, Stephen Hemminger wrote: > > On Wed, 31 May 2017 11:21:27 -0700 > Yuchung Cheng wrote: > > > When the sender switches its congestion control during loss > > recovery, if the recovery is spurious then it may

[PATCH net-next] mdio: mux: make child bus walking more permissive and errors more verbose

2017-05-31 Thread Jon Mason
If any errors are encountered while walking the device tree structure of the MDIO bus for children, the code may silently continue, silently exit, or throw an error and exit. This make it difficult for device tree writers to know there is an error. Also, it makes any error in a child entry of

[PATCH net-next] net: phy: use of_mdio_parse_addr

2017-05-31 Thread Jon Mason
use of_mdio_parse_addr() in place of an OF read of reg and a bounds check (which is litterally the exact same thing that of_mdio_parse_addr() does) Signed-off-by: Jon Mason --- drivers/net/phy/mdio_bus.c | 15 ++- 1 file changed, 2 insertions(+), 13

Re: [ISSUE: sky2 - rx error] Link stops working under heavy traffic load connected to a mv88e6176

2017-05-31 Thread Andrew Lunn
On Fri, May 26, 2017 at 12:13:03PM +0200, Rafa Corvillo wrote: > As modifying sky2 code I have not could get any solution, then I > have modified some parameters on the ethernet interface and using a > MTU = 1503 and disabling TSO (TCP Segmentation Offload) mechanism > all communication errors

[PATCH] net: ethernet: stmmac: Fix altr_tse_pcs SGMII Initialization

2017-05-31 Thread thor . thayer
From: Thor Thayer Fix NETDEV WATCHDOG timeout on startup by adding missing register writes that properly setup SGMII. Signed-off-by: Thor Thayer --- drivers/net/ethernet/stmicro/stmmac/altr_tse_pcs.c | 6 +- 1 file changed, 5

[PATCH V3] neigh: Really delete an arp/neigh entry on "ip neigh delete" or "arp -d"

2017-05-31 Thread Sowmini Varadhan
The command # arp -s 62.2.0.1 a:b:c:d:e:f dev eth2 adds an entry like the following (listed by "arp -an") ? (62.2.0.1) at 0a:0b:0c:0d:0e:0f [ether] PERM on eth2 but the symmetric deletion command # arp -i eth2 -d 62.2.0.1 does not remove the PERM entry from the table, and instead leaves

[PATCH v2 net-next 8/8] bpf: Test for bpf ID

2017-05-31 Thread Martin KaFai Lau
Add test to exercise the bpf_prog/map id generation, bpf_(prog|map)_get_next_id(), bpf_(prog|map)_get_fd_by_id() and bpf_get_obj_info_by_fd(). Signed-off-by: Martin KaFai Lau Acked-by: Alexei Starovoitov Acked-by: Daniel Borkmann ---

[PATCH v2 net-next 3/8] bpf: Add BPF_(PROG|MAP)_GET_NEXT_ID command

2017-05-31 Thread Martin KaFai Lau
This patch adds BPF_PROG_GET_NEXT_ID and BPF_MAP_GET_NEXT_ID to allow userspace to iterate all bpf_prog IDs and bpf_map IDs. The API is trying to be consistent with the existing BPF_MAP_GET_NEXT_KEY. It is currently limited to CAP_SYS_ADMIN which we can consider to lift it in followup patches.

[PATCH v2 net-next 2/8] bpf: Introduce bpf_map ID

2017-05-31 Thread Martin KaFai Lau
This patch generates an unique ID for each created bpf_map. The approach is similar to the earlier patch for bpf_prog ID. It is worth to note that the bpf_map's ID and bpf_prog's ID are in two independent ID spaces and both have the same valid range: [1, INT_MAX). Signed-off-by: Martin KaFai Lau

[PATCH v2 net-next 4/8] bpf: Add BPF_PROG_GET_FD_BY_ID

2017-05-31 Thread Martin KaFai Lau
Add BPF_PROG_GET_FD_BY_ID command to allow user to get a fd from a bpf_prog's ID. bpf_prog_inc_not_zero() is added and is called with prog_idr_lock held. __bpf_prog_put() is also added which has the 'bool do_idr_lock' param to decide if the prog_idr_lock should be acquired when freeing the

[PATCH v2 net-next 0/8] Introduce bpf ID

2017-05-31 Thread Martin KaFai Lau
This patch series: 1) Introduce ID for both bpf_prog and bpf_map. 2) Add bpf commands to iterate the prog IDs and map IDs of the system. 3) Add bpf commands to get a prog/map fd from an ID 4) Add bpf command to get prog/map info from a fd. The prog/map info is a jump start in this patchset

[PATCH v2 net-next 6/8] bpf: Add jited_len to struct bpf_prog

2017-05-31 Thread Martin KaFai Lau
Add jited_len to struct bpf_prog. It will be useful for the struct bpf_prog_info which will be added in the later patch. Signed-off-by: Martin KaFai Lau Acked-by: Alexei Starovoitov Acked-by: Daniel Borkmann --- arch/arm64/net/bpf_jit_comp.c

[PATCH v2 net-next 7/8] bpf: Add BPF_OBJ_GET_INFO_BY_FD

2017-05-31 Thread Martin KaFai Lau
A single BPF_OBJ_GET_INFO_BY_FD cmd is used to obtain the info for both bpf_prog and bpf_map. The kernel can figure out the fd is associated with a bpf_prog or bpf_map. The suggested struct bpf_prog_info and struct bpf_map_info are not meant to be a complete list and it is not the goal of this

[PATCH v2 net-next 5/8] bpf: Add BPF_MAP_GET_FD_BY_ID

2017-05-31 Thread Martin KaFai Lau
Add BPF_MAP_GET_FD_BY_ID command to allow user to get a fd from a bpf_map's ID. bpf_map_inc_not_zero() is added and is called with map_idr_lock held. __bpf_map_put() is also added which has the 'bool do_idr_lock' param to decide if the map_idr_lock should be acquired when freeing the map->id.

[PATCH v2 net-next 1/8] bpf: Introduce bpf_prog ID

2017-05-31 Thread Martin KaFai Lau
This patch generates an unique ID for each BPF_PROG_LOAD-ed prog. It is worth to note that each BPF_PROG_LOAD-ed prog will have a different ID even they have the same bpf instructions. The ID is generated by the existing idr_alloc_cyclic(). The ID is ranged from [1, INT_MAX). It is allocated in

RE: [PATCH v5 net-next 0/5] dsa: add Microchip KSZ9477 DSA driver

2017-05-31 Thread Woojung.Huh
> Unfortunately, I had to revert, you didn't add MODULE_LICENSE() tags > to the new drivers. > > WARNING: modpost: missing MODULE_LICENSE() in > drivers/net/dsa/microchip/ksz_common.o > see include/linux/module.h for more information > WARNING: modpost: missing MODULE_LICENSE() in >

Re: [PATCH v5 net-next 0/5] dsa: add Microchip KSZ9477 DSA driver

2017-05-31 Thread Andrew Lunn
On Wed, May 31, 2017 at 02:47:32PM -0400, David Miller wrote: > From: David Miller > Date: Wed, 31 May 2017 14:28:30 -0400 (EDT) > > > From: > > Date: Wed, 31 May 2017 00:00:34 + > > > >> From: Woojung Huh > >> >

  1   2   3   >