RE: [RFC] Support for SGMII 2500

2017-11-27 Thread Bhaskar Upadhaya
+ Anji, Calvin, Prabhakar, Poonam. -Original Message- From: Madalin-cristian Bucur Sent: Tuesday, November 28, 2017 12:56 PM To: Andrew Lunn ; f.faine...@gmail.com; netdev@vger.kernel.org Cc: Bhaskar Upadhaya ; Shengzhou Liu ; York Sun ; u-b...@lists.denx.de Subject: [RFC] Support for SG

[RFC] Support for SGMII 2500

2017-11-27 Thread Madalin-cristian Bucur
Hi, There is a disconnect between the SGMII 2500 support in u-boot and Linux. Bhaskar is trying to add support for a SGMII interface working at 2.5Gbps by using the PHY connection type "sgmii-2500" in the device tree: phy-connection-type = "sgmii-2500"; This is supported by u-boot, in in

Re: [PATCH 2/2] [RFC] packet: experimental support for 64-bit timestamps

2017-11-27 Thread Björn Töpel
2017-11-27 21:51 GMT+01:00 Arnd Bergmann : [...] >> There already is an effort to come up with a new AF_PACKET V4 [1]. >> We should make sure that any new interface does not have the >> Y2038/Y2106 issue. But, if a new version is being developed and >> that subsumes all existing use cases, then the

Re: [PATCH v2 22/35] nds32: Device tree support

2017-11-27 Thread Greentime Hu
2017-11-27 22:30 GMT+08:00 Arnd Bergmann : > On Mon, Nov 27, 2017 at 1:28 PM, Greentime Hu wrote: >> @@ -0,0 +1,55 @@ >> +/dts-v1/; >> +/ { >> + compatible = "nds32 ae3xx"; > > The compatible string doesn't seem to match the binding, it should always have > vendor prefix. Sorry I forgot to

[PATCH] net: gianfar: add ethtool eee support

2017-11-27 Thread Yangbo Lu
From: Shaohui Xie Gianfar does not support EEE, but it can connect to a PHY which supports EEE and the PHY advertises EEE by default, and its link partner also advertises EEE, so the PHY enters low power mode when traffic rate is low, which causes packet loss if an application's traffic rate is l

[PATCH net-next 1/1] forcedeth: optimize the xmit with unlikely

2017-11-27 Thread Zhu Yanjun
In xmit, it is very impossible that TX_ERROR occurs. So using unlikely optimizes the xmit process. CC: Srinivas Eeda CC: Joe Jin CC: Junxiao Bi Signed-off-by: Zhu Yanjun --- drivers/net/ethernet/nvidia/forcedeth.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drive

Re: [PATCH] atm: eni: fix several indentation issues

2017-11-27 Thread Joe Perches
On Mon, 2017-11-27 at 13:15 +, Colin King wrote: > drivers/atm/eni.c Aren't all those ++ variables unused? They seem to be emitted in an #if 0 printk(...) #endif Maybe these should be removed or changed to something like: #if 0 #define DEBUG_INCR(var) do { (var)++ } while (0) #else

Re: [PATCH] openvswitch: use ktime_get_ts64() instead of ktime_get_ts()

2017-11-27 Thread Pravin Shelar
On Mon, Nov 27, 2017 at 5:11 PM, Arnd Bergmann wrote: > timespec is deprecated because of the y2038 overflow, so let's convert > this one to ktime_get_ts64(). The code is already safe even on 32-bit > architectures, since it uses monotonic times. On 64-bit architectures, > nothing changes, while o

Re: [PATCH v2 10/35] nds32: Atomic operations

2017-11-27 Thread Vincent Chen
2017-11-27 21:57 GMT+08:00 Mark Rutland : > Hi, > > On Mon, Nov 27, 2017 at 08:27:57PM +0800, Greentime Hu wrote: >> +static inline void arch_spin_unlock(arch_spinlock_t * lock) >> +{ >> + asm volatile( >> + "xor$r15, $r15, $r15\n" >> + "swi$r15, [%0]\n" >> +

[PATCH net] net/packet: fix a race in packet_bind() and packet_notifier()

2017-11-27 Thread Eric Dumazet
From: Eric Dumazet syzbot reported crashes [1] and provided a C repro easing bug hunting. When/if packet_do_bind() calls __unregister_prot_hook() and releases po->bind_lock, another thread can run packet_notifier() and process an NETDEV_UP event. This calls register_prot_hook() and hook again t

Re: [PATCH 1/3] ath9k: remove stray backslash in Makefile

2017-11-27 Thread Jakub Kicinski
On Mon, 27 Nov 2017 18:56:21 +0100, Matthias Schiffer wrote: > Signed-off-by: Matthias Schiffer > --- > drivers/net/wireless/ath/ath9k/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/wireless/ath/ath9k/Makefile > b/drivers/net/wireless/ath/ath9k/Mak

Re: [kernel-hardening] Re: [RFC 0/3] kallsyms: don't leak address when printing symbol

2017-11-27 Thread Kaiwan N Billimoria
On Tue, Nov 28, 2017 at 7:20 AM, Tobin C. Harding wrote: > > Noob question: how do we _know_ this. In other words how do we know no > userland tools rely on the current behaviour? No stress to answer Kees, > this is a pretty general kernel dev question. Perhaps I'm reading this wrong, but anyway:

Re: Regression in throughput between kvm guests over virtual bridge

2017-11-27 Thread Wei Xu
On Tue, Nov 28, 2017 at 09:36:37AM +0800, Jason Wang wrote: > > > On 2017年11月28日 00:21, Wei Xu wrote: > > On Mon, Nov 20, 2017 at 02:25:17PM -0500, Matthew Rosato wrote: > > > On 11/14/2017 03:11 PM, Matthew Rosato wrote: > > > > On 11/12/2017 01:34 PM, Wei Xu wrote: > > > > > On Sat, Nov 11, 201

Re: [PATCH v2 29/35] dt-bindings: nds32 CPU Bindings

2017-11-27 Thread Greentime Hu
2017-11-27 21:42 GMT+08:00 Mark Rutland : > Him > > On Mon, Nov 27, 2017 at 08:28:16PM +0800, Greentime Hu wrote: >> From: Greentime Hu >> >> This patch adds nds32 CPU binding documents. >> >> Signed-off-by: Vincent Chen >> Signed-off-by: Rick Chen >> Signed-off-by: Zong Li >> Signed-off-by: Gr

Re: [PATCH v2 30/35] net: faraday add nds32 support.

2017-11-27 Thread Greentime Hu
2017-11-27 22:15 GMT+08:00 Arnd Bergmann : > On Mon, Nov 27, 2017 at 1:28 PM, Greentime Hu wrote: >> From: Greentime Hu >> >> Signed-off-by: Greentime Hu > > This is missing a patch description. > Thanks. Sorry. I miss it. I will add the commit messages in the next version patch. >> diff --git

Re: [PATCH v2 34/35] clocksource/drivers/Kconfig: Support andestech atcpit100 timer

2017-11-27 Thread Greentime Hu
2017-11-27 22:11 GMT+08:00 Arnd Bergmann : > On Mon, Nov 27, 2017 at 1:28 PM, Greentime Hu wrote: >> From: Rick Chen >> >> Add CLKSRC_ATCPIT100 for Andestech atcpit100 timer selection. >> It often be used in Andestech AE3XX platform. >> >> Signed-off-by: Rick Chen >> Signed-off-by: Greentime Hu

Re: Regression in throughput between kvm guests over virtual bridge

2017-11-27 Thread Matthew Rosato
On 11/27/2017 08:36 PM, Jason Wang wrote: > > > On 2017年11月28日 00:21, Wei Xu wrote: >> On Mon, Nov 20, 2017 at 02:25:17PM -0500, Matthew Rosato wrote: >>> On 11/14/2017 03:11 PM, Matthew Rosato wrote: On 11/12/2017 01:34 PM, Wei Xu wrote: > On Sat, Nov 11, 2017 at 03:59:54PM -0500, Matth

Re: [PATCH v2 18/35] nds32: Debugging support

2017-11-27 Thread Vincent Chen
2017-11-27 22:34 GMT+08:00 Arnd Bergmann : > On Mon, Nov 27, 2017 at 1:28 PM, Greentime Hu wrote: >> +struct user_pt_regs { >> + long uregs[26]; >> + long fp; >> + long gp; >> + long lp; >> + long sp; >> + long ipc; >> +#if defined(CONFIG_HWZOL) >> + long

Re: [PATCH v2 16/35] nds32: Signal handling support

2017-11-27 Thread Vincent Chen
2017-11-27 22:37 GMT+08:00 Arnd Bergmann : > On Mon, Nov 27, 2017 at 1:28 PM, Greentime Hu wrote: > >> +#ifndef _ASMNDS32_SIGNAL_H >> +#define _ASMNDS32_SIGNAL_H >> + >> +#define SA_RESTORER0x0400 >> + >> +#include >> +#endif > > As documented in asm-generic/signal.h, new architectures sh

Re: [PATCH v2 14/35] nds32: System calls handling

2017-11-27 Thread Vincent Chen
2017-11-27 22:46 GMT+08:00 Arnd Bergmann : > On Mon, Nov 27, 2017 at 1:28 PM, Greentime Hu wrote: > >> diff --git a/arch/nds32/include/asm/syscalls.h >> b/arch/nds32/include/asm/syscalls.h >> new file mode 100644 >> index 000..741ccdc >> --- /dev/null >> +++ b/arch/nds32/include/asm/syscalls.

Re: [PATCH RFC 2/2] veth: propagate bridge GSO to peer

2017-11-27 Thread David Ahern
On 11/27/17 6:42 PM, Solio Sarabia wrote: > On Mon, Nov 27, 2017 at 01:15:02PM -0800, Stephen Hemminger wrote: >> On Mon, 27 Nov 2017 12:14:19 -0800 >> Solio Sarabia wrote: >> >>> On Sun, Nov 26, 2017 at 11:07:25PM -0800, Stephen Hemminger wrote: On Sun, 26 Nov 2017 20:13:39 -0700 David

Re: [RFC 0/3] kallsyms: don't leak address when printing symbol

2017-11-27 Thread Tobin C. Harding
On Mon, Nov 27, 2017 at 04:52:21PM -0800, Kees Cook wrote: > On Mon, Nov 27, 2017 at 2:30 PM, Tobin C. Harding wrote: > > This is an RFC for two reasons. > > > > 1) I don't know who this patch set may break? > > 2) Patch set includes a function that is not called. Function is there > >to facil

Re: [PATCH RFC 2/2] veth: propagate bridge GSO to peer

2017-11-27 Thread Solio Sarabia
On Mon, Nov 27, 2017 at 01:15:02PM -0800, Stephen Hemminger wrote: > On Mon, 27 Nov 2017 12:14:19 -0800 > Solio Sarabia wrote: > > > On Sun, Nov 26, 2017 at 11:07:25PM -0800, Stephen Hemminger wrote: > > > On Sun, 26 Nov 2017 20:13:39 -0700 > > > David Ahern wrote: > > > > > > > On 11/26/17 1

Re: Regression in throughput between kvm guests over virtual bridge

2017-11-27 Thread Jason Wang
On 2017年11月28日 00:21, Wei Xu wrote: On Mon, Nov 20, 2017 at 02:25:17PM -0500, Matthew Rosato wrote: On 11/14/2017 03:11 PM, Matthew Rosato wrote: On 11/12/2017 01:34 PM, Wei Xu wrote: On Sat, Nov 11, 2017 at 03:59:54PM -0500, Matthew Rosato wrote: This case should be quite similar with pkgt

RE: [PATCH] e1000: Fix off-by-one in debug message

2017-11-27 Thread Brown, Aaron F
> From: netdev-ow...@vger.kernel.org [mailto:netdev- > ow...@vger.kernel.org] On Behalf Of Ahmad Fatoum > Sent: Saturday, November 18, 2017 12:54 PM > To: Kirsher, Jeffrey T > Cc: intel-wired-...@lists.osuosl.org; netdev@vger.kernel.org; Ahmad > Fatoum > Subject: [PATCH] e1000: Fix off-by-one in

Re: [PATCH v5 next 5/5] net: modules: use request_module_cap() to load 'netdev-%s' modules

2017-11-27 Thread Kees Cook
On Mon, Nov 27, 2017 at 3:14 PM, Linus Torvalds wrote: > On Mon, Nov 27, 2017 at 2:59 PM, Kees Cook wrote: >> >> I don't disagree that a global should be avoided, but I'm struggling >> to see another option here. We can't break userspace by default so we >> can't restrict cap-less loading by defa

Re: [RFC 0/3] kallsyms: don't leak address when printing symbol

2017-11-27 Thread Kees Cook
On Mon, Nov 27, 2017 at 2:30 PM, Tobin C. Harding wrote: > This is an RFC for two reasons. > > 1) I don't know who this patch set may break? > 2) Patch set includes a function that is not called. Function is there >to facilitate fixing breakages. > > _If_ no one gets broken then we can remove

Re: [PATCH v5 next 0/5] Improve Module autoloading infrastructure

2017-11-27 Thread James Morris
On Mon, 27 Nov 2017, Kees Cook wrote: > > if (WARN_ON_ONCE(!capable(CAP_SYS_MODULE) || > > !capable(CAP_SYS_ADMIN) || > > !capable(CAP_NET_ADMIN) || > > !unprivileged_autoload(module_name))) (Side note: the capable

Re: [PATCH v5 next 5/5] net: modules: use request_module_cap() to load 'netdev-%s' modules

2017-11-27 Thread Linus Torvalds
On Mon, Nov 27, 2017 at 3:19 PM, Kees Cook wrote: > > What about exporting this entirely to userspace, giving it as much > context as possible? i.e. inform modprobe about the user doing it, > maybe the subsystem, etc? Yeah, except for the fact that we don't trust user-mode? We used to do that ex

Re: [PATCH net-next] bridge: ebtables: Avoid resetting limit rule state

2017-11-27 Thread Pablo Neira Ayuso
Hi Linus, On Sat, Nov 25, 2017 at 08:44:18AM +0100, Linus Lüssing wrote: > So far any changes with ebtables will reset the state of limit rules, > leading to spikes in traffic. This is especially noticeable if changes > are done frequently, for instance via a daemon. > > This patch fixes this by

Re: [PATCH v5 next 5/5] net: modules: use request_module_cap() to load 'netdev-%s' modules

2017-11-27 Thread Kees Cook
On Mon, Nov 27, 2017 at 3:14 PM, Linus Torvalds wrote: > On Mon, Nov 27, 2017 at 2:59 PM, Kees Cook wrote: >> >> I don't disagree that a global should be avoided, but I'm struggling >> to see another option here. We can't break userspace by default so we >> can't restrict cap-less loading by defa

Re: [PATCH net] bpf: offload: add a license header

2017-11-27 Thread Daniel Borkmann
On 11/27/2017 09:10 PM, Jakub Kicinski wrote: > I forgot to add a license on kernel/bpf/offload.c. Luckily I'm > still the only author so make it explicitly GPLv2. > > Signed-off-by: Jakub Kicinski > Reviewed-by: Simon Horman Applied to bpf tree, thanks Jakub.

Re: [PATCH v5 next 5/5] net: modules: use request_module_cap() to load 'netdev-%s' modules

2017-11-27 Thread Linus Torvalds
On Mon, Nov 27, 2017 at 2:59 PM, Kees Cook wrote: > > I don't disagree that a global should be avoided, but I'm struggling > to see another option here. We can't break userspace by default so we > can't restrict cap-less loading by default. But we can allow userspace > to _choose_ to break itself,

Re: [PATCH v5 next 0/5] Improve Module autoloading infrastructure

2017-11-27 Thread Kees Cook
On Mon, Nov 27, 2017 at 2:31 PM, James Morris wrote: > On Tue, 28 Nov 2017, David Miller wrote: > >> From: Linus Torvalds >> Date: Mon, 27 Nov 2017 10:41:30 -0800 >> >> > What are the real life use-cases for normal users having modules >> > auto-load? >> >> User opens SCTP socket, SCTP protocol m

Re: [PATCH v5 next 5/5] net: modules: use request_module_cap() to load 'netdev-%s' modules

2017-11-27 Thread Kees Cook
On Mon, Nov 27, 2017 at 2:04 PM, Linus Torvalds wrote: > On Mon, Nov 27, 2017 at 1:41 PM, Djalal Harouni wrote: >> >> However, we are trying hard to abstract some semantics that are easy >> to grasp, we are mutating capabilities and seccomp to have an >> abstracted "yes/no" options for our enduse

Re: [PATCH v5 next 0/5] Improve Module autoloading infrastructure

2017-11-27 Thread James Morris
On Tue, 28 Nov 2017, David Miller wrote: > From: Linus Torvalds > Date: Mon, 27 Nov 2017 10:41:30 -0800 > > > What are the real life use-cases for normal users having modules > > auto-load? > > User opens SCTP socket, SCTP protocol module loads. > > People build test cases via namespaces, and

[RFC 0/3] kallsyms: don't leak address when printing symbol

2017-11-27 Thread Tobin C. Harding
This is an RFC for two reasons. 1) I don't know who this patch set may break? 2) Patch set includes a function that is not called. Function is there to facilitate fixing breakages. _If_ no one gets broken then we can remove the unused function. Thanks for looking at this. Currently if a poin

[RFC 1/3] kallsyms: don't leak address when symbol not found

2017-11-27 Thread Tobin C. Harding
Currently if kallsyms_lookup() fails to find the symbol then the address is printed. This potentially leaks sensitive information. Instead of printing the address we can return an error, giving the calling code the option to print the address or print some sanitized message. Return error instead o

[RFC 3/3] trace: print address if symbol not found

2017-11-27 Thread Tobin C. Harding
Fixes behaviour modified by: commit bd6b239cdbb2 ("kallsyms: don't leak address when symbol not found") Previous patch changed behaviour of kallsyms function sprint_symbol() to return an error code instead of printing the address if a symbol was not found. Ftrace relies on the original behaviour.

[RFC 2/3] vsprintf: print if symbol not found

2017-11-27 Thread Tobin C. Harding
Depends on: commit bd6b239cdbb2 ("kallsyms: don't leak address when symbol not found") Currently vsprintf for specifiers %p[SsB] relies on the behaviour of kallsyms (sprint_symbol()) and prints the actual address if a symbol is not found. Previous patch changes this behaviour so tha sprint_symbol(

Re: [PATCH v5 next 5/5] net: modules: use request_module_cap() to load 'netdev-%s' modules

2017-11-27 Thread Linus Torvalds
On Mon, Nov 27, 2017 at 1:41 PM, Djalal Harouni wrote: > > However, we are trying hard to abstract some semantics that are easy > to grasp, we are mutating capabilities and seccomp to have an > abstracted "yes/no" options for our endusers. Yes. Sadly, it looks like we actually do have users that

Re: [PATCH] rxrpc: sendmsg: Fix variable overwrite in rxrpc_queue_packet

2017-11-27 Thread Gustavo A. R. Silva
Quoting David Howells : Gustavo A. R. Silva wrote: - resend_at = now + rxrpc_resend_timeout; + resend_at += now; Yep. :-) Great! What about this one: https://lkml.org/lkml/2017/11/27/810 applies the same? Thanks -- Gustavo A. R. Silva

Re: [PATCH] net-sysfs: export gso_max_size attribute

2017-11-27 Thread Solio Sarabia
On Fri, Nov 24, 2017 at 10:32:49AM -0800, Eric Dumazet wrote: > On Fri, 2017-11-24 at 10:14 -0700, David Ahern wrote: > > > > This should be added to rtnetlink rather than sysfs. > > This is already exposed by rtnetlink [1] > > Please lets not add yet another net-sysfs knob. > > [1] c70ce028e83

[PATCH v2] rxrpc: sendmsg: Fix variable overwrite in rxrpc_queue_packet

2017-11-27 Thread Gustavo A. R. Silva
Value assigned to variable resend_at is overwritten before it can be used. The correct fix here is to add _now_ to the previously computed value in resend_at. Addresses-Coverity-ID: 1462262 Fixes: beb8e5e4f38c ("rxrpc: Express protocol timeouts in terms of RTT") Link: https://marc.info/?i=17004.1

Re: [PATCH v5 next 5/5] net: modules: use request_module_cap() to load 'netdev-%s' modules

2017-11-27 Thread Djalal Harouni
Hi Linus, On Mon, Nov 27, 2017 at 7:44 PM, Linus Torvalds wrote: > On Mon, Nov 27, 2017 at 9:18 AM, Djalal Harouni wrote: >> This uses the new request_module_cap() facility to directly propagate >> CAP_NET_ADMIN capability and the 'netdev' module prefix to the >> capability subsystem as it was s

Re: [PATCH v5 next 1/5] modules:capabilities: add request_module_cap()

2017-11-27 Thread Djalal Harouni
Hi Randy, On Mon, Nov 27, 2017 at 7:48 PM, Randy Dunlap wrote: > Hi, > > Mostly typos/spellos... > > > On 11/27/2017 09:18 AM, Djalal Harouni wrote: >> Cc: Serge Hallyn >> Cc: Andy Lutomirski >> Suggested-by: Rusty Russell >> Suggested-by: Kees Cook >> Signed-off-by: Djalal Harouni >> --- >>

Re: [test_rht_init] INFO: task swapper/0:1 blocked for more than 120 seconds.

2017-11-27 Thread Linus Torvalds
On Tue, Nov 21, 2017 at 3:52 AM, Fengguang Wu wrote: > Here is a different call trace related to rhashtable. > > It occurs in 17 out of 90 boots. > > [ 342.666234] Writes: Total: 4 Max/Min: 0/0 Fail: 0 > [ 381.918047] INFO: task swapper/0:1 blocked for more than 120 seconds. This looks very

Re: [rht_deferred_worker] BUG: workqueue lockup - pool cpus=0 node=0 flags=0x0 nice=0 stuck for 62s!

2017-11-27 Thread Linus Torvalds
On Tue, Nov 21, 2017 at 3:19 AM, Fengguang Wu wrote: > > FYI this happens in mainline kernel 4.14.0-10859-gcf9b077. > It at least dates back to v4.5 . Hmm. This seems to be doing some concurrent rhashtable stress testing, while at the same time doing the RCU stress testing. All with a ton of othe

Re: [PATCH v5 next 0/5] Improve Module autoloading infrastructure

2017-11-27 Thread Djalal Harouni
Hi Linus, On Mon, Nov 27, 2017 at 8:12 PM, Linus Torvalds wrote: > On Mon, Nov 27, 2017 at 11:02 AM, Linus Torvalds > wrote: >> >> Now, the above will not necessarily work with a legacy /dev/ directory >> where al the nodes have been pre-populated, and opening the device >> node is supposed to l

Re: [PATCH RFC 2/2] veth: propagate bridge GSO to peer

2017-11-27 Thread Stephen Hemminger
On Mon, 27 Nov 2017 12:14:19 -0800 Solio Sarabia wrote: > On Sun, Nov 26, 2017 at 11:07:25PM -0800, Stephen Hemminger wrote: > > On Sun, 26 Nov 2017 20:13:39 -0700 > > David Ahern wrote: > > > > > On 11/26/17 11:17 AM, Stephen Hemminger wrote: > > > > This allows veth device in containers t

Re: [PATCH net] cls_bpf: don't decrement net's refcount when offload fails

2017-11-27 Thread Daniel Borkmann
On 11/27/2017 08:11 PM, Jakub Kicinski wrote: > When cls_bpf offload was added it seemed like a good idea to > call cls_bpf_delete_prog() instead of extending the error > handling path, since the software state is fully initialized > at that point. This handling of errors without jumping to > the

Re: [PATCH v1] brcmfmac: Avoid build error with make W=1

2017-11-27 Thread Arend van Spriel
On 23-11-17 16:57, Andy Shevchenko wrote: When I run make W=1 on gcc (Debian 7.2.0-16) 7.2.0 I got an error for the first run, all next ones are okay. CC [M] drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.o drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c:2078: error: Cannot

Re: [PATCH] rxrpc: sendmsg: Fix variable overwrite in rxrpc_queue_packet

2017-11-27 Thread David Howells
Gustavo A. R. Silva wrote: > - resend_at = now + rxrpc_resend_timeout; > + resend_at += now; Yep. :-) David

Re: [PATCH 2/2] [RFC] packet: experimental support for 64-bit timestamps

2017-11-27 Thread Arnd Bergmann
On Mon, Nov 27, 2017 at 9:35 PM, Willem de Bruijn wrote: > On Mon, Nov 27, 2017 at 11:59 AM, Jiri Pirko wrote: >> Mon, Nov 27, 2017 at 05:19:25PM CET, a...@arndb.de wrote: >>>I tried to figure out what it would take to do a version 4 mmap packet >>>socket interface to completely avoid the y2106 o

Re: general protection fault in __rds_rdma_map

2017-11-27 Thread Santosh Shilimkar
On 11/27/2017 10:30 AM, syzbot wrote: Hello, syzkaller hit the following crash on e1d1ea549b57790a3d8cf6300e6ef86118d692a3 git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/master compiler: gcc (GCC) 7.1.1 20170620 .config is attached Raw console output is attached. C reproducer

Re: [PATCH] rxrpc: sendmsg: Fix variable overwrite in rxrpc_queue_packet

2017-11-27 Thread Gustavo A. R. Silva
Hi David, Quoting David Howells : Gustavo A. R. Silva wrote: Value assigned to variable resend_at is overwritten before it can be used. Fix this by removing the value overwrite as it seems that this is a leftover code. NAK. Your fix will actually cause the code to break. The resend_at v

Re: [PATCH 2/2] [RFC] packet: experimental support for 64-bit timestamps

2017-11-27 Thread Willem de Bruijn
On Mon, Nov 27, 2017 at 11:59 AM, Jiri Pirko wrote: > Mon, Nov 27, 2017 at 05:19:25PM CET, a...@arndb.de wrote: >>I tried to figure out what it would take to do a version 4 mmap packet >>socket interface to completely avoid the y2106 overflow problem. This is >>what I came up with, reusing most of

Re: [PATCH iproute2] tc: police: fix control action parsing

2017-11-27 Thread Stephen Hemminger
On Mon, 27 Nov 2017 19:00:14 +0100 Michal Privoznik wrote: > parse_action_control helper does advancing of the arg inside. So don't > do it outside. > > Fixes: e67aba559581 ("tc: actions: add helpers to parse and print control > actions") > Signed-off-by: Michal Privoznik The helpers are not

Re: [PATCH 1/2] [net-next] packet: clarify timestamp overflow

2017-11-27 Thread Willem de Bruijn
On Mon, Nov 27, 2017 at 11:17 AM, Arnd Bergmann wrote: > The memory mapped packet socket data structure in version 1 through 3 > all contain 32-bit second values for the packet time stamps, which makes > them suffer from the overflow of time_t in y2038 or y2106 (depending > on whether user space i

Re: [PATCH RFC 2/2] veth: propagate bridge GSO to peer

2017-11-27 Thread Solio Sarabia
On Sun, Nov 26, 2017 at 11:07:25PM -0800, Stephen Hemminger wrote: > On Sun, 26 Nov 2017 20:13:39 -0700 > David Ahern wrote: > > > On 11/26/17 11:17 AM, Stephen Hemminger wrote: > > > This allows veth device in containers to see the GSO maximum > > > settings of the actual device being used for o

[PATCH net] bpf: offload: add a license header

2017-11-27 Thread Jakub Kicinski
I forgot to add a license on kernel/bpf/offload.c. Luckily I'm still the only author so make it explicitly GPLv2. Signed-off-by: Jakub Kicinski Reviewed-by: Simon Horman --- kernel/bpf/offload.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/kernel/bpf/offload.c b/kernel/

Re: [PATCH net 0/3] a couple of fixes for chunks abandoned in prsctp

2017-11-27 Thread David Miller
From: Xin Long Date: Sat, 25 Nov 2017 21:18:33 +0800 > Now when abandoning chunks in prsctp, it doesn't consider for frags in > one msg, which would cause peer can never receive the whole frags for > one msg to get them reassembled, these pieces of this msg will stay in > the reasm queue forever

Re: [net 1/1] tipc: eliminate access after delete in group_filter_msg()

2017-11-27 Thread David Miller
From: Jon Maloy Date: Mon, 27 Nov 2017 20:13:39 +0100 > KASAN revealed another access after delete in group.c. This time > it found that we read the header of a received message after the > buffer has been released. > > Signed-off-by: Jon Maloy Looks good, applied, thanks Jon.

Re: [RFC net-next 4/6] netdevsim: add software driver for testing offloads

2017-11-27 Thread Jakub Kicinski
On Tue, 28 Nov 2017 04:30:26 +0900 (KST), David Miller wrote: > From: Jakub Kicinski > Date: Thu, 23 Nov 2017 18:36:11 -0800 > > > The dummy driver have previously been extended to test SR-IOV, > > but the general consensus seems to be against adding further > > features to it. > > I guess thi

[PATCH 2/4] sctp: Add ip option support

2017-11-27 Thread Richard Haines
Add ip option support to allow LSM security modules to utilise CIPSO/IPv4 and CALIPSO/IPv6 services. Signed-off-by: Richard Haines --- include/net/sctp/structs.h | 2 ++ net/sctp/chunk.c | 13 - net/sctp/ipv6.c| 42 +++--- ne

Re: [e1000_shutdown] e1000 0000:00:03.0: disabling already-disabled device

2017-11-27 Thread Tushar Dave
On 11/23/2017 04:43 AM, Fengguang Wu wrote: On Wed, Nov 22, 2017 at 03:40:52AM +0530, Tushar Dave wrote: On 11/21/2017 06:11 PM, Fengguang Wu wrote: Hello, FYI this happens in mainline kernel 4.14.0-01330-g3c07399. It happens since 4.13 . It occurs in 3 out of 162 boots. [   44.637743]

[PATCH 4/4] selinux: Add SCTP support

2017-11-27 Thread Richard Haines
The SELinux SCTP implementation is explained in: Documentation/security/SELinux-sctp.rst Signed-off-by: Richard Haines --- Documentation/security/SELinux-sctp.rst | 104 security/selinux/hooks.c| 278 +--- security/selinux/include/classmap

[PATCH 3/4] sctp: Add LSM hooks

2017-11-27 Thread Richard Haines
Add security hooks to allow security modules to exercise access control over SCTP. Signed-off-by: Richard Haines --- include/net/sctp/structs.h | 10 include/uapi/linux/sctp.h | 1 + net/sctp/sm_make_chunk.c | 12 + net/sctp/sm_statefuns.c| 18 ++ net/sctp/so

Re: [RFC net-next 4/6] netdevsim: add software driver for testing offloads

2017-11-27 Thread David Miller
From: Jakub Kicinski Date: Thu, 23 Nov 2017 18:36:11 -0800 > The dummy driver have previously been extended to test SR-IOV, > but the general consensus seems to be against adding further > features to it. I guess this is fine, but then is it going to be the case that every time we want to add a

[PATCH 0/4] Add SELinux SCTP protocol support

2017-11-27 Thread Richard Haines
The kernel patches have been built on Fedora 27 with kernel 4.13.12 plus the following userspace patches to enable testing: 1) Updates to libsepol 2.7 to support the sctp portcon statement. The patch is available from: http://arctic.selinuxproject.org/~rhaines/selinux-sctp/ se

[PATCH 1/4] security: Add support for SCTP security hooks

2017-11-27 Thread Richard Haines
The SCTP security hooks are explained in: Documentation/security/LSM-sctp.rst Signed-off-by: Richard Haines --- Documentation/security/LSM-sctp.rst | 194 include/linux/lsm_hooks.h | 35 +++ include/linux/security.h| 25 + secu

Re: [PATCH v2] net: sched: crash on blocks with goto chain action

2017-11-27 Thread Cong Wang
On Fri, Nov 24, 2017 at 3:27 AM, Roman Kapl wrote: > > Fixes: 822e86d997 ("net_sched: remove tcf_block_put_deferred()") You blame a wrong commit here. Commit 822e86d997 was correct at that time, it is the patchset which includes commit e4b95c41df36befcfd11721 makes it buggy again.

Re: [PATCHv2] xen-netfront: remove warning when unloading module

2017-11-27 Thread David Miller
From: Eduardo Otubo Date: Thu, 23 Nov 2017 15:18:35 +0100 > v2: > * Replace busy wait with wait_event()/wake_up_all() > * Cannot garantee that at the time xennet_remove is called, the >xen_netback state will not be XenbusStateClosed, so added a >condition for that > * There's a small c

[Patch net] xfrm: check id proto in validate_tmpl()

2017-11-27 Thread Cong Wang
syzbot reported a kernel warning in xfrm_state_fini(), which indicates that we have entries left in the list net->xfrm.state_all whose proto is zero. And xfrm_id_proto_match() doesn't consider them as a match with IPSEC_PROTO_ANY in this case. Proto with value 0 is probably not a valid value, at l

Re: [PATCH v5 next 0/5] Improve Module autoloading infrastructure

2017-11-27 Thread David Miller
From: Linus Torvalds Date: Mon, 27 Nov 2017 10:41:30 -0800 > What are the real life use-cases for normal users having modules > auto-load? User opens SCTP socket, SCTP protocol module loads. People build test cases via namespaces, and in that namespaces normal users can setup virtual tunnel dev

Re: [PATCH v2 22/35] nds32: Device tree support

2017-11-27 Thread Rob Herring
On Mon, Nov 27, 2017 at 1:07 PM, Rob Herring wrote: > On Mon, Nov 27, 2017 at 6:28 AM, Greentime Hu wrote: >> From: Greentime Hu >> >> This patch adds support for device tree. >> >> Signed-off-by: Vincent Chen >> Signed-off-by: Greentime Hu >> --- >> arch/nds32/boot/dts/Makefile |8

[net 1/1] tipc: eliminate access after delete in group_filter_msg()

2017-11-27 Thread Jon Maloy
KASAN revealed another access after delete in group.c. This time it found that we read the header of a received message after the buffer has been released. Signed-off-by: Jon Maloy --- net/tipc/group.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/tipc/group.c b/net/tip

Re: [PATCH v5 next 0/5] Improve Module autoloading infrastructure

2017-11-27 Thread Linus Torvalds
On Mon, Nov 27, 2017 at 11:02 AM, Linus Torvalds wrote: > > Now, the above will not necessarily work with a legacy /dev/ directory > where al the nodes have been pre-populated, and opening the device > node is supposed to load the module. So _historically_ we did indeed > load modules as normal us

[PATCH net] cls_bpf: don't decrement net's refcount when offload fails

2017-11-27 Thread Jakub Kicinski
When cls_bpf offload was added it seemed like a good idea to call cls_bpf_delete_prog() instead of extending the error handling path, since the software state is fully initialized at that point. This handling of errors without jumping to the end of the function is error prone, as proven by later c

Re: Linux 4.14 - regression: broken tun/tap / bridge network with virtio - bisected

2017-11-27 Thread Andreas Hartmann
On 11/27/2017 at 05:55 PM Michal Kubecek wrote: > On Mon, Nov 27, 2017 at 05:46:14PM +0100, Andreas Hartmann wrote: >> >> Using virtio not just breaks the network completely as described above, >> it even leaves a never stoppable or restartable qemu process (even kill >> -9 doesn't work). It's abso

Re: [PATCH v2 22/35] nds32: Device tree support

2017-11-27 Thread Rob Herring
On Mon, Nov 27, 2017 at 6:28 AM, Greentime Hu wrote: > From: Greentime Hu > > This patch adds support for device tree. > > Signed-off-by: Vincent Chen > Signed-off-by: Greentime Hu > --- > arch/nds32/boot/dts/Makefile |8 ++ > arch/nds32/boot/dts/ae3xx.dts | 55 +++

Re: [PATCH v5 next 0/5] Improve Module autoloading infrastructure

2017-11-27 Thread Linus Torvalds
On Mon, Nov 27, 2017 at 10:41 AM, Linus Torvalds wrote: > > What are the real life use-cases for normal users having modules auto-load? Well, I could do some testing. One case is apparently both bluetoothd and ip6tables that have been converted to indeed use CAP_NET_ADMIN. Annoying. Still, can'

Re: [PATCH] rxrpc: sendmsg: Fix variable overwrite in rxrpc_queue_packet

2017-11-27 Thread David Howells
Gustavo A. R. Silva wrote: > Value assigned to variable resend_at is overwritten before it can be used. > > Fix this by removing the value overwrite as it seems that this is a > leftover code. NAK. Your fix will actually cause the code to break. The resend_at value used for the timer must be

Re: Linux ECN Handling

2017-11-27 Thread Steve Ibanez
Hi Neal, I tried out your new suggested patches and indeed it looks like it is working. The duration of the freezes looks like it has reduced from an RTO to 10ms (tcp probe reports SRTT measurements of about 200us just before the freeze). So the PTO value seems to be correctly set to max(2*SRTT, 1

Re: [PATCH v5 next 1/5] modules:capabilities: add request_module_cap()

2017-11-27 Thread Randy Dunlap
Hi, Mostly typos/spellos... On 11/27/2017 09:18 AM, Djalal Harouni wrote: > Cc: Serge Hallyn > Cc: Andy Lutomirski > Suggested-by: Rusty Russell > Suggested-by: Kees Cook > Signed-off-by: Djalal Harouni > --- > include/linux/kmod.h | 65 > ++---

Re: [PATCH v5 next 5/5] net: modules: use request_module_cap() to load 'netdev-%s' modules

2017-11-27 Thread Linus Torvalds
On Mon, Nov 27, 2017 at 9:18 AM, Djalal Harouni wrote: > This uses the new request_module_cap() facility to directly propagate > CAP_NET_ADMIN capability and the 'netdev' module prefix to the > capability subsystem as it was suggested. This is the kind of complexity that I wonder if it's worth it

Re: [PATCH v5 next 0/5] Improve Module autoloading infrastructure

2017-11-27 Thread Linus Torvalds
On Mon, Nov 27, 2017 at 9:18 AM, Djalal Harouni wrote: > > The sysctl flag is available at "/proc/sys/kernel/modules_autoload_mode" > > When modules_autoload_mode is set to (0), the default, there are no > restrictions. So quick question: do we actually need this? Yes, it may be the current defa

[PATCH] rxrpc: call_event: Fix variable overwrite in __rxrpc_propose_ACK

2017-11-27 Thread Gustavo A. R. Silva
Value assigned to variable ack_at is overwritten before it can be used. Fix this by removing the value overwrite as it seems that this is a leftover code. Addresses-Coverity-ID: 1462263 Addresses-Coverity-ID: 1462264 Fixes: beb8e5e4f38c ("rxrpc: Express protocol timeouts in terms of RTT") Signed-

Re: DMA coalescing - ethtool vs. kernel

2017-11-27 Thread Jeff Kirsher
On Thu, 2017-11-23 at 13:31 +0100, Michal Kubecek wrote: > Hello, > > while digging through the interface between ethtool and kernel, > I noticed that ethtool commit 5dd7bfbc5079 ("ethtool: Add DMA > Coalescing > support") added new member dmac into struct ethtool_coalesce which is > part of kerne

Re: [PATCH][v4] uprobes/x86: emulate push insns for uprobe on x86

2017-11-27 Thread Yonghong Song
Hi, Ingo and Peter, This patch has been reviewed by Oleg Nesterov. Could you take a look and help merge it upstream? Thanks! Yonghong On 11/20/17 10:25 AM, Yonghong Song wrote: On 11/20/17 8:41 AM, Oleg Nesterov wrote: On 11/17, Yonghong Song wrote: On 11/17/17 9:25 AM, Oleg Nesterov wr

[PATCH 1/3] ath9k: remove stray backslash in Makefile

2017-11-27 Thread Matthias Schiffer
Signed-off-by: Matthias Schiffer --- drivers/net/wireless/ath/ath9k/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/ath9k/Makefile b/drivers/net/wireless/ath/ath9k/Makefile index 36a40ffdce15..90e4a341076c 100644 --- a/drivers/net/wireless/at

[PATCH 3/3] ath10k: move spectral scan support under a separate config symbol

2017-11-27 Thread Matthias Schiffer
At the moment, spectral scan support, and with it RELAY, is always enabled with ATH10K_DEBUGFS. Spectral scan support is currently the only user of RELAY in ath10k, and it unconditionally reserves a relay channel. Having debugfs support in ath10k is often useful even on very small embedded routers

[PATCH 2/3] ath9k: move spectral scan support under a separate config symbol

2017-11-27 Thread Matthias Schiffer
At the moment, spectral scan support, and with it RELAY, is always enabled with ATH9K[_HTC]_DEBUGFS. Spectral scan support is currently the only user of RELAY in ath9k, and it unconditionally reserves a relay channel. Having debugfs support in ath9k is often useful even on very small embedded rout

[PATCH] rxrpc: sendmsg: Fix variable overwrite in rxrpc_queue_packet

2017-11-27 Thread Gustavo A. R. Silva
Value assigned to variable resend_at is overwritten before it can be used. Fix this by removing the value overwrite as it seems that this is a leftover code. Addresses-Coverity-ID: 1462262 Fixes: beb8e5e4f38c ("rxrpc: Express protocol timeouts in terms of RTT") Signed-off-by: Gustavo A. R. Silva

[PATCH] tc: police: fix control action parsing

2017-11-27 Thread Michal Privoznik
parse_action_control helper does advancing of the arg inside. So don't do it outside. Fixes: e67aba559581 ("tc: actions: add helpers to parse and print control actions") Signed-off-by: Michal Privoznik --- tc/m_police.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/t

Re: WARNING in xfrm_state_fini

2017-11-27 Thread Cong Wang
On Mon, Nov 27, 2017 at 3:55 AM, Steffen Klassert wrote: > On Tue, Nov 21, 2017 at 06:44:04PM -0800, Cong Wang wrote: >> User-space uses proto==0 as a wildcard, but xfrm_id_proto_match() >> doesn't consider it as a match with IPSEC_PROTO_ANY, in this case >> it should match all. Not sure if the fo

[patch net resend] net: sched: cbq: create block for q->link.block

2017-11-27 Thread Jiri Pirko
From: Jiri Pirko q->link.block is not initialized, that leads to EINVAL when one tries to add filter there. So initialize it properly. This can be reproduced by: $ tc qdisc add dev eth0 root handle 1: cbq avpkt 1000 rate 1000Mbit bandwidth 1000Mbit $ tc filter add dev eth0 parent 1: protocol ip

Re: [patch net] net: sched: cbq: create block for q->link.block

2017-11-27 Thread Jiri Pirko
Mon, Nov 27, 2017 at 06:30:43PM CET, marcelo.leit...@gmail.com wrote: >On Mon, Nov 27, 2017 at 06:22:59PM +0100, Jiri Pirko wrote: >> From: Jiri Pirko >> >> q->link.block is not initialized, that leads to EINVAL when one tries to >> add filter there. So initialize it properly. >> >> This can be

Re: [patch net] net: sched: cbq: create block for q->link.block

2017-11-27 Thread Marcelo Ricardo Leitner
On Mon, Nov 27, 2017 at 06:22:59PM +0100, Jiri Pirko wrote: > From: Jiri Pirko > > q->link.block is not initialized, that leads to EINVAL when one tries to > add filter there. So initialize it properly. > > This can be reproduced by: By...? :-) > > Reported-by: Jaroslav Aster > Reported-by:

Re: pull request: Cavium Octeon III firmware

2017-11-27 Thread David Daney
On 11/22/2017 05:40 PM, Ben Hutchings wrote: On Tue, 2017-10-31 at 17:05 -0500, Steven J. Hill wrote: Hello. Would like to add firmware for our Octeon III PKI driver. Thanks. Where is this driver? I don't see any reference to the file in linux- next. Several versions of the patch set were

  1   2   3   >