From: YueHaibing
Date: Wed, 5 Sep 2018 11:44:10 +
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c: In function
> 'bnxt_tc_parse_flow':
> drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c:186:6: warning:
> variable 'addr_type' set but not used
From: Yi-Hung Wei
Date: Tue, 4 Sep 2018 15:33:41 -0700
> Currently, OVS only parses the IP protocol number for the first
> IPv6 fragment, but sets the IP protocol number for the later fragments
> to be NEXTHDF_FRAGMENT. This patch tries to derive the IP protocol
> number for the IPV6 later
On Thu, Sep 06, 2018 at 09:18:47PM -0700, Cong Wang wrote:
> On Wed, Sep 5, 2018 at 12:04 PM Al Viro wrote:
> >
> > From: Al Viro
> >
> > unused
> >
> > Signed-off-by: Al Viro
> > ---
> > net/sched/cls_u32.c | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/net/sched/cls_u32.c
On Tue, Sep 4, 2018 at 3:37 PM Yi-Hung Wei wrote:
>
> Currently, OVS only parses the IP protocol number for the first
> IPv6 fragment, but sets the IP protocol number for the later fragments
> to be NEXTHDF_FRAGMENT. This patch tries to derive the IP protocol
> number for the IPV6 later frags so
On Wed, Sep 5, 2018 at 12:04 PM Al Viro wrote:
>
> From: Al Viro
>
> unused
>
> Signed-off-by: Al Viro
> ---
> net/sched/cls_u32.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/net/sched/cls_u32.c b/net/sched/cls_u32.c
> index 8a1a573487bd..be9240ae1417 100644
> ---
On Thu, Sep 6, 2018 at 8:50 PM Al Viro wrote:
>
> On Thu, Sep 06, 2018 at 08:23:36PM -0700, Cong Wang wrote:
>
> > Pretty sure there is a 'tp' in u32_set_parms() parameter list.
> >
> > Are you saying it is not what you want? If so, why?
> >
> > More importantly, why this information is again
On Thu, Sep 06, 2018 at 08:23:36PM -0700, Cong Wang wrote:
> Pretty sure there is a 'tp' in u32_set_parms() parameter list.
>
> Are you saying it is not what you want? If so, why?
>
> More importantly, why this information is again missing in your
> changelog? This patch is definitely not
On Thu, Sep 6, 2018 at 2:10 AM, Patrick Ruddy
wrote:
> Some userspace applications need to know about IGMP joins from the
> kernel for 2 reasons:
> 1. To allow the programming of multicast MAC filters in hardware
> 2. To form a multicast FORUS list for non link-local multicast
>groups to be
On Thu, Sep 6, 2018 at 8:04 PM Al Viro wrote:
>
> On Thu, Sep 06, 2018 at 07:57:25PM -0700, Cong Wang wrote:
>
> > > - if (root_ht == ht) {
> > > + if (ht->is_root) {
> >
> >
> > What's wrong with comparing pointers with root ht?
>
> The fact that there may be more than one tcf_proto
On Thu, Sep 06, 2018 at 07:57:25PM -0700, Cong Wang wrote:
> > - if (root_ht == ht) {
> > + if (ht->is_root) {
>
>
> What's wrong with comparing pointers with root ht?
The fact that there may be more than one tcf_proto sharing tp->data.
> >
On Thu, Sep 6, 2018 at 3:59 AM Al Viro wrote:
>
> diff --git a/net/sched/cls_u32.c b/net/sched/cls_u32.c
> index 3f985f29ef30..d14048e38b5c 100644
> --- a/net/sched/cls_u32.c
> +++ b/net/sched/cls_u32.c
> @@ -84,6 +84,7 @@ struct tc_u_hnode {
> int refcnt;
>
On Thu, Sep 06, 2018 at 06:21:09AM -0400, Jamal Hadi Salim wrote:
> For networking patches, subject should be reflective of tree and
> subsystem. Example for this one:
> "[PATCH net 1/7]:net: sched: cls_u32: fix hnode refcounting"
> Also useful to have a cover letter summarizing the patchset
> in
On 09/06/2018 07:24 AM, Edward Cree wrote:
> This series listifies part of GRO processing, in a manner which allows those
> packets which are not GROed (i.e. for which dev_gro_receive returns
> GRO_NORMAL) to be passed on to the listified regular receive path.
> I have not listified
On 09/06/2018 07:26 AM, Edward Cree wrote:
> Signed-off-by: Edward Cree
Lack of changelog here ?
I do not know what is a good packet.
You are adding a lot of conditional expressions, that cpu
will mispredict quite often.
Typical micro benchmarks wont really notice.
On 9/5/18 12:00 PM, D'Souza, Nelson wrote:
> Just following up would you be able to confirm that this is a Linux VRF
> issue?
I can confirm that I can reproduce the problem. Need to find time to dig
into it.
The support to dump program array and map_in_map maps
for bpffs and bpftool is added. Patch #1 added bpffs support
and Patch #2 added bpftool support. Please see
individual patches for example output.
Yonghong Song (2):
bpf: add bpffs pretty print for program array map
tools/bpf: bpftool:
Currently, prog array map and map of maps are not supported
in bpftool. This patch added the support.
Different from other map types, for prog array map and
map of maps, the key returned bpf_get_next_key() may not
point to a valid value. So for these two map types,
no error will be printed out
Added bpffs pretty print for program array map. For a particular
array index, if the program array points to a valid program,
the ": " will be printed out like
0: 6
which means bpf program with id "6" is installed at index "0".
Signed-off-by: Yonghong Song
---
kernel/bpf/arraymap.c | 25
On Mon, Sep 3, 2018 at 1:54 PM, Petar Penkov wrote:
>
> On Sun, Sep 2, 2018 at 2:03 PM, Daniel Borkmann wrote:
> > On 08/30/2018 08:22 PM, Petar Penkov wrote:
> >> From: Petar Penkov
> >>
> >> Adds a hook for programs of type BPF_PROG_TYPE_FLOW_DISSECTOR and
> >> attach type BPF_FLOW_DISSECTOR
Hi Stephen,
On Thu, Sep 06, 2018 at 02:00:53PM +0100, Stephen Hemminger wrote:
> > @@ -164,6 +168,10 @@ static void print_mdb_entry(FILE *f, int ifindex,
> > const struct br_mdb_entry *e,
> > print_string(PRINT_ANY, "timer", " %s",
> > format_timer(timer));
>
On Fri, Aug 31, 2018 at 11:25:48PM +0200, Mauricio Vasquez B wrote:
> In some applications this is needed have a pool of free elements, like for
> example the list of free L4 ports in a SNAT. None of the current maps allow
> to do it as it is not possibleto get an any element without having they
From: YueHaibing
Date: Thu, 6 Sep 2018 11:22:09 +
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/net/ethernet/cavium/liquidio/cn23xx_vf_device.c: In function
> 'cn23xx_setup_octeon_vf_device':
> drivers/net/ethernet/cavium/liquidio/cn23xx_vf_device.c:619:20: warning:
>
From: Felix Manlunas
Date: Wed, 5 Sep 2018 18:40:56 -0700
> From: Weilin Chang
>
> 1. Provide the API to set/unset the spoof checking feature.
> 2. Add a function to periodically provide the count of found
>packets with spoof VF MAC address.
> 3. Prevent VF MAC address changing while the
From: Saeed Mahameed
Date: Wed, 5 Sep 2018 21:33:22 -0700
> This pull request provides some updates to mlx5 ethernet driver.
>
> For more information please see tag log below.
>
> Please pull and let me know if there's any problem.
Pulled, thank you.
When nla_put*() fails after nla_nest_start(), we need
to call nla_nest_cancel() to cancel the message, otherwise
we end up calling nla_nest_end() like a success.
Fixes: 0ed5269f9e41 ("net/sched: add tunnel option support to act_tunnel_key")
Cc: Davide Caratti
Cc: Simon Horman
Signed-off-by:
On 09/06/2018 02:11 PM, Hauke Mehrtens wrote:
> On 09/03/2018 09:54 PM, Florian Fainelli wrote:
>>
>>
>> On 9/1/2018 5:05 AM, Hauke Mehrtens wrote:
>>> This adds the DSA driver for the GSWIP Switch found in the VRX200 SoC.
>>> This switch is integrated in the DSL SoC, this SoC uses a GSWIP version
On 09/03/2018 09:54 PM, Florian Fainelli wrote:
>
>
> On 9/1/2018 5:05 AM, Hauke Mehrtens wrote:
>> This adds the DSA driver for the GSWIP Switch found in the VRX200 SoC.
>> This switch is integrated in the DSL SoC, this SoC uses a GSWIP version
>> 2.1, there are other SoCs using different
From: Caleb Raitto
Print the name of the argument that wasn't understood.
Signed-off-by: Caleb Raitto
---
tc/q_mqprio.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/tc/q_mqprio.c b/tc/q_mqprio.c
index 89b46002..7cd18ae1 100644
--- a/tc/q_mqprio.c
+++ b/tc/q_mqprio.c
On Thu, Sep 6, 2018 at 4:14 AM Vlad Buslov wrote:
> > Isn't a concurrent tcf_idr_check_alloc() able to livelock here with
> > your change?
> >
> > idr_for_each_entry_ul{
> >spin_lock(>lock);
> >idr_remove();
> >spin_unlock(>lock);
> > // tcf_idr_check_alloc() jumps in,
> >
On Thu, Sep 6, 2018 at 9:58 AM Vincent Whitchurch
wrote:
>
> According to the documentation in msg_zerocopy.rst, the SO_ZEROCOPY
> flag was introduced because send(2) ignores unknown message flags and
> any legacy application which was accidentally passing the equivalent of
> MSG_ZEROCOPY earlier
2018-09-07 3:23 GMT+09:00 Eric Dumazet :
> On Thu, Sep 6, 2018 at 11:06 AM Eric Dumazet wrote:
>>
>> On Thu, Sep 6, 2018 at 10:51 AM Taehee Yoo wrote:
>> >
>> > A kernel crash occurrs when defragmented packet is fragmented
>> > in ip_do_fragment().
>> > In defragment routine, skb_orphan() is
On Thu, Sep 6, 2018 at 11:06 AM Eric Dumazet wrote:
>
> On Thu, Sep 6, 2018 at 10:51 AM Taehee Yoo wrote:
> >
> > A kernel crash occurrs when defragmented packet is fragmented
> > in ip_do_fragment().
> > In defragment routine, skb_orphan() is called and
> > skb->ip_defrag_offset is set. but
On Wed, Sep 05, 2018 at 04:58:02PM -0700, Yonghong Song wrote:
> As bpf usage becomes more pervasive, people starts to worry
> about their cpu and memory cost. On a particular host,
> people often wanted to know all running bpf programs
> and their attachment context. So they can relate
> a
On Thu, Sep 6, 2018 at 10:51 AM Taehee Yoo wrote:
>
> A kernel crash occurrs when defragmented packet is fragmented
> in ip_do_fragment().
> In defragment routine, skb_orphan() is called and
> skb->ip_defrag_offset is set. but skb->sk and
> skb->ip_defrag_offset are same union member. so that
>
On Mon, Sep 03, 2018 at 09:54:52AM +0200, Jesper Dangaard Brouer wrote:
> This patchset contains XDP micro optimizations for the redirect core.
> These are not functional changes. The optimizations revolve around
> getting the compiler to layout the code in a way that reflect how XDP
> redirect
A kernel crash occurrs when defragmented packet is fragmented
in ip_do_fragment().
In defragment routine, skb_orphan() is called and
skb->ip_defrag_offset is set. but skb->sk and
skb->ip_defrag_offset are same union member. so that
frag->sk is not NULL.
Hence crash occurrs in skb->sk check routine
On Thu, Sep 6, 2018 at 7:09 AM, Leon Romanovsky wrote:
> On Thu, Sep 06, 2018 at 12:37:17AM +0300, Or Gerlitz wrote:
>> On Wed, Sep 5, 2018 at 9:11 PM, Leon Romanovsky wrote:
>> > On Wed, Sep 05, 2018 at 10:38:00AM -0600, Jason Gunthorpe wrote:
>> >> On Wed, Sep 05, 2018 at 08:10:25AM +0300,
tls_sw_sendmsg() allocates plaintext and encrypted SG entries using
function sk_alloc_sg(). In case the number of SG entries hit
MAX_SKB_FRAGS, sk_alloc_sg() returns -ENOSPC and sets the variable for
current SG index to '0'. This leads to calling of function
tls_push_record() with
Change flower in_hw_count type to fixed-size u32 and dump it as
TCA_FLOWER_IN_HW_COUNT. This change is necessary to properly test shared
blocks and re-offload functionality.
Signed-off-by: Vlad Buslov
Acked-by: Jiri Pirko
---
include/net/sch_generic.h| 2 +-
include/uapi/linux/pkt_cls.h |
The output of vlan show was broken previous change to use json_print.
Clean the code up and return to original format.
Note: the JSON syntax has changed to make the bridge vlan
show more like other outputs (e.g. ip -j li show).
Signed-off-by: Stephen Hemminger
---
bridge/br_common.h | 2 +-
Rather than using is_json_context(), use the print_string functions
which handle both cases.
Signed-off-by: Stephen Hemminger
---
bridge/mdb.c | 11 ++-
1 file changed, 2 insertions(+), 9 deletions(-)
diff --git a/bridge/mdb.c b/bridge/mdb.c
index 9bdef0262c54..cc1b4547865c 100644
---
Get port ifname once rather than on both sides of if(is_json_context).
Signed-off-by: Stephen Hemminger
---
bridge/mdb.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/bridge/mdb.c b/bridge/mdb.c
index f38dc67c849a..9bdef0262c54 100644
--- a/bridge/mdb.c
+++
From: Saeed Mahameed
Date: Wed, 5 Sep 2018 21:09:42 -0700
> This pull request contains some fixes for mlx5 etherent netdevice and
> core driver.
Pulled.
>
> For -stable v4.9:
> ('net/mlx5: Fix debugfs cleanup in the device init/remove flow')
>
> For -stable v4.12:
> ("net/mlx5: E-Switch,
Some tools may currently be using only the deprecated attribute;
let's print an elaborate and clear deprecation notice to kmsg.
To do that, we have to replace the whole sysfs file, since we inherit
the original one from netdev.
Signed-off-by: Arseny Maslennikov
---
The sysfs field was introduced 4 years ago along with fixes to various
drivers that erroneously used `dev_id' for that purpose, but it was not
properly documented anywhere.
See commit v3.14-rc3-739-g3f85944fe207.
Signed-off-by: Arseny Maslennikov
---
Documentation/ABI/testing/sysfs-class-net |
Pre-3.15 userspace had trouble distinguishing different ports
of a NIC on a single PCI bus/device/function. To solve this,
a sysfs field `dev_port' was introduced quite a while ago
(commit v3.14-rc3-739-g3f85944fe207), and some relevant device
drivers were fixed to use it, but not in case of
From: Florian Fainelli
Date: Wed, 5 Sep 2018 12:42:10 -0700
> This patch series adds support for the SerDes found on NorthStar Plus
> (NSP) which allows us to use the SFP port on the BCM958625HR board (and
> other similar designs).
>
> Changes in v3:
>
> - properly hunk the
Some InfiniBand network devices have multiple ports on the same PCI
function. This initializes the `dev_port' sysfs field of those
network interfaces with their port number.
Prior to this the kernel erroneously used the `dev_id' sysfs
field of those network interfaces to convey the port number to
From: Denis Bolotin
Date: Wed, 5 Sep 2018 18:35:55 +0300
> This patch adds a new qed firmware with fixes and support for new features.
>
> Fixes:
> - Fix a rare case of device crash with iWARP, iSCSI or FCoE offload.
> - Fix GRE tunneled traffic when iWARP offload is enabled.
> - Fix RoCE
On 9/6/18 6:57 AM, Hangbin Liu wrote:
> When receive a redirect message and call rt6_do_redirect(), we allocate
> a new rt6_info and set new flags and gateway info, but not update these
> info to fib6_info.
>
> Then if a user try to get the route info via `ip route get`, he will still
> get the
Signed-off-by: Edward Cree
---
include/linux/netdevice.h | 4 +--
include/net/ip.h | 4 +--
include/net/ipv6.h| 4 +--
net/core/dev.c| 63 +--
net/ipv4/ip_input.c | 39 ++---
Allows GRO-using drivers to get the benefits of batching for non-GROable
traffic.
Signed-off-by: Edward Cree
---
net/core/dev.c | 19 ---
1 file changed, 16 insertions(+), 3 deletions(-)
diff --git a/net/core/dev.c b/net/core/dev.c
index 69e2819994e4..9a937d2ac83b 100644
---
Signed-off-by: Edward Cree
---
drivers/net/ethernet/sfc/efx.c| 11 +--
drivers/net/ethernet/sfc/net_driver.h | 1 +
drivers/net/ethernet/sfc/rx.c | 16 +---
3 files changed, 23 insertions(+), 5 deletions(-)
diff --git a/drivers/net/ethernet/sfc/efx.c
Also export napi_frags_skb() so that drivers using the napi_gro_frags()
interface can prepare their SKBs properly for submitting on such a list.
Signed-off-by: Edward Cree
---
include/linux/netdevice.h | 2 ++
net/core/dev.c| 28 +++-
2 files changed, 29
This series listifies part of GRO processing, in a manner which allows those
packets which are not GROed (i.e. for which dev_gro_receive returns
GRO_NORMAL) to be passed on to the listified regular receive path.
I have not listified dev_gro_receive() itself, or the per-protocol GRO
callback,
According to the documentation in msg_zerocopy.rst, the SO_ZEROCOPY
flag was introduced because send(2) ignores unknown message flags and
any legacy application which was accidentally passing the equivalent of
MSG_ZEROCOPY earlier should not see any new behaviour.
Before commit f214f915e7db
On Thu, Sep 06, 2018 at 04:05:58PM +0300, Igor Russkikh wrote:
> From: Yana Esina
>
> Add WOL support. Currently only magic packet
> (ethtool -s wol g) feature is implemented.
>
> Remove hw_set_power and move that to FW_OPS set_power:
> because WOL configuration behaves differently on 1x and
On Thu, Sep 06, 2018 at 04:06:01PM +0300, Igor Russkikh wrote:
> From: Nikita Danilov
>
> Removed extra characters from the names of structures to unify prefixes
> used through the driver code (we normally use hw_atl for hw specifics).
> HW_ATL_B0_ and HW_ATL_A0_ are the same and useless copies.
On Sat, 1 Sep 2018, Jason A. Donenfeld wrote:
> On Sat, Sep 1, 2018 at 2:32 PM Andy Lutomirski wrote:
> > I tend to think the right approach is to merge Jason's code and then
> > make it better later. Even with a totally perfect lazy FPU restore
> > implementation on x86, we'll probably still
On Thu, Sep 06, 2018 at 04:06:00PM +0300, Igor Russkikh wrote:
> From: Nikita Danilov
>
> Removed extra spaces, corrected alignment.
>
> Signed-off-by: Nikita Danilov
> Signed-off-by: Igor Russkikh
Reviewed-by: Andrew Lunn
Andrew
On Thu, Sep 06, 2018 at 04:05:58PM +0300, Igor Russkikh wrote:
> From: Yana Esina
>
> Add WOL support. Currently only magic packet
> (ethtool -s wol g) feature is implemented.
>
> Remove hw_set_power and move that to FW_OPS set_power:
> because WOL configuration behaves differently on 1x and
It was possible to crash ip-route by adding an IPv6 route with 37
nexthop statements. A simple reproducer is:
| for i in `seq 37`; do
| nhs="nexthop via ::$i "$nhs
| done
| ip -6 route add ::/64 $nhs
The related code was broken in multiple ways:
* parse_one_nh() assumed that rta
On Thu, Sep 06, 2018 at 04:05:57PM +0300, Igor Russkikh wrote:
> From: Yana Esina
Hi Igor, Yana
> @@ -134,13 +132,36 @@ struct __packed hw_aq_atl_utils_fw_rpc {
> u32 pattern_offset;
> u32 pattern_size;
>
Hey guys,
I finally got some time to do a bisect and we narrowed the problem down to:
b838d5e1c5b6e57b10ec8af2268824041e3ea911 is the first bad commit
commit b838d5e1c5b6e57b10ec8af2268824041e3ea911
Author: Wei Wang
Date: Sat Jun 17 10:42:32 2017 -0700
ipv4: mark DST_NOGC and remove the
From: Yana Esina
Support of Energy-Efficient Ethernet to aQuantia NIC's via ethtool
(according to the IEEE 802.3az specifications)
Signed-off-by: Yana Esina
Signed-off-by: Nikita Danilov
Tested-by: Nikita Danilov
Signed-off-by: Igor Russkikh
---
From: Nikita Danilov
Removed extra spaces, corrected alignment.
Signed-off-by: Nikita Danilov
Signed-off-by: Igor Russkikh
---
.../net/ethernet/aquantia/atlantic/aq_ethtool.c| 4 +--
drivers/net/ethernet/aquantia/atlantic/aq_nic.c| 12
This is v2 of WOL/EEE functionality patch for atlantic driver.
Sorry for long gap, I was on vacation.
In this patchset Yana Esina and Nikita Danilov implemented:
- Upload function to interact with FW memory
- Definitions and structures necessary for the correct operation of Wake ON Lan
- The
From: Nikita Danilov
Removed extra characters from the names of structures to unify prefixes
used through the driver code (we normally use hw_atl for hw specifics).
HW_ATL_B0_ and HW_ATL_A0_ are the same and useless copies.
Signed-off-by: Nikita Danilov
Signed-off-by: Igor Russkikh
---
Signed-off-by: Igor Russkikh
---
drivers/net/ethernet/aquantia/atlantic/ver.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/aquantia/atlantic/ver.h
b/drivers/net/ethernet/aquantia/atlantic/ver.h
index 94efc6477bdc..b48260114da3 100644
---
From: Yana Esina
Added definitions and structures needed to support WOL.
Signed-off-by: Yana Esina
Signed-off-by: Nikita Danilov
Tested-by: Nikita Danilov
Signed-off-by: Igor Russkikh
---
drivers/net/ethernet/aquantia/atlantic/aq_nic.h| 3 +
.../aquantia/atlantic/hw_atl/hw_atl_utils.h
From: Yana Esina
Add WOL support. Currently only magic packet
(ethtool -s wol g) feature is implemented.
Remove hw_set_power and move that to FW_OPS set_power:
because WOL configuration behaves differently on 1x and 2x
firmwares
Signed-off-by: Yana Esina
Signed-off-by: Nikita Danilov
From: Yana Esina
This patch fixes the upload function, which worked incorrectly with
some chips.
Signed-off-by: Yana Esina
Signed-off-by: Nikita Danilov
Tested-by: Nikita Danilov
Signed-off-by: Igor Russkikh
---
.../ethernet/aquantia/atlantic/hw_atl/hw_atl_llh.c | 8 +
On Thu, Sep 06, 2018 at 10:04:33AM +0300, Arseny Maslennikov wrote:
> On Wed, Sep 05, 2018 at 04:50:35PM +0300, Leon Romanovsky wrote:
> > On Mon, Sep 03, 2018 at 07:13:16PM +0300, Arseny Maslennikov wrote:
> > > Signed-off-by: Arseny Maslennikov
> > > ---
> > >
On Wed, 5 Sep 2018 11:33:43 +0800
Hangbin Liu wrote:
> The bridge mdb show is broken on current iproute2. e.g.
> ]# bridge mdb show
> 34: br0 veth0_br 224.1.1.2 temp 34: br0 veth0_br 224.1.1.1 temp
>
> After fix:
> ]# bridge mdb show
> 34: br0 veth0_br 224.1.1.2 temp
> 34: br0
When receive a redirect message and call rt6_do_redirect(), we allocate
a new rt6_info and set new flags and gateway info, but not update these
info to fib6_info.
Then if a user try to get the route info via `ip route get`, he will still
get the old default gateway, because inet6_rtm_getroute()
On Thu, Sep 06, 2018 at 10:26:56AM +0300, Arseny Maslennikov wrote:
> On Wed, Sep 05, 2018 at 04:47:27PM +0100, Stephen Hemminger wrote:
> > On Mon, 3 Sep 2018 19:13:16 +0300
> > Arseny Maslennikov wrote:
> >
> > > + if (ndev->dev_id == ndev->dev_port) {
> > > + netdev_info_once(ndev,
>
Hi,
On Tue, Sep 04, 2018 at 07:15:44PM +0200, Phil Sutter wrote:
[...]
> diff --git a/ip/iproute.c b/ip/iproute.c
> index 30833414a3f7f..9e5ae48c0715c 100644
> --- a/ip/iproute.c
> +++ b/ip/iproute.c
[...]
> @@ -1036,15 +1044,18 @@ static int parse_nexthops(struct nlmsghdr *n, struct
> rtmsg *r,
GMAC >= 4 also supports CBS. Lets enable the TC Ops for these versions.
Signed-off-by: Jose Abreu
Cc: David S. Miller
Cc: Joao Pinto
Cc: Giuseppe Cavallaro
Cc: Alexandre Torgue
---
drivers/net/ethernet/stmicro/stmmac/hwif.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff
2018-09-05, 21:57:43 +0530, Vakul Garg wrote:
> tls_sw_sendmsg() allocates plaintext and encrypted SG entries using
> function sk_alloc_sg(). In case the number of SG entries hit
> MAX_SKB_FRAGS, sk_alloc_sg() returns -ENOSPC and sets the variable for
> current SG index to '0'. This leads to
On Wed 05 Sep 2018 at 20:32, Cong Wang wrote:
> On Wed, Sep 5, 2018 at 12:05 AM Vlad Buslov wrote:
>>
>>
>> On Tue 04 Sep 2018 at 22:41, Cong Wang wrote:
>> > On Mon, Sep 3, 2018 at 1:33 PM Vlad Buslov wrote:
>> >>
>> >>
>> >> On Mon 03 Sep 2018 at 18:50, Cong Wang wrote:
>> >> > On Mon,
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/net/ethernet/cavium/liquidio/cn23xx_vf_device.c: In function
'cn23xx_setup_octeon_vf_device':
drivers/net/ethernet/cavium/liquidio/cn23xx_vf_device.c:619:20: warning:
variable 'ring_flag' set but not used [-Wunused-but-set-variable]
On 2018-09-06 6:59 a.m., Al Viro wrote:
On Thu, Sep 06, 2018 at 06:34:00AM -0400, Jamal Hadi Salim wrote:
On 2018-09-06 6:28 a.m., Jamal Hadi Salim wrote:
[..]
Point, and that one is IMO enough to give up on using ->flags for
that. How about simply
diff --git a/net/sched/cls_u32.c
On Thu, Sep 06, 2018 at 06:34:00AM -0400, Jamal Hadi Salim wrote:
> On 2018-09-06 6:28 a.m., Jamal Hadi Salim wrote:
> > On 2018-09-05 3:04 p.m., Al Viro wrote:
> > > From: Al Viro
> > >
> > > ... and disallow deleting or linking to such
> > >
> > > Signed-off-by: Al Viro
> >
> > Same comment
And a bunch of indentations...
cheers,
jamal
diff --git a/net/sched/cls_u32.c b/net/sched/cls_u32.c
index 6d45ec4c218c..cb3bee12af78 100644
--- a/net/sched/cls_u32.c
+++ b/net/sched/cls_u32.c
@@ -485,7 +485,8 @@ static void u32_clear_hw_hnode(struct tcf_proto *tp, struct tc_u_hnode *h,
struct
On Wed, 5 Sep 2018 13:24:19 -0700
Caleb Raitto wrote:
> From: Caleb Raitto
>
> Print the name of the argument that wasn't understood, and also print
> the usage string.
>
> Signed-off-by: Caleb Raitto
The standard code pattern in iproute2 is to use invarg().
Why not use that?
On 2018-09-05 3:04 p.m., Al Viro wrote:
From: Al Viro
* calculate key *once*, not for each hash chain element
* let tc_u_hash() return the pointer to chain head rather than index -
callers are cleaner that way.
Signed-off-by: Al Viro
Acked-by: Jamal Hadi Salim
cheers,
jamal
On 2018-09-05 3:04 p.m., Al Viro wrote:
From: Al Viro
unused
Signed-off-by: Al Viro
Acked-by: Jamal Hadi Salim
cheers,
jamal
On 2018-09-05 3:04 p.m., Al Viro wrote:
From: Al Viro
not used anymore
Signed-off-by: Al Viro
Acked-by: Jamal Hadi Salim
cheers,
jamal
On 2018-09-05 3:04 p.m., Al Viro wrote:
From: Al Viro
Signed-off-by: Al Viro
Acked-by: Jamal Hadi Salim
cheers,
jamal
On 2018-09-06 6:28 a.m., Jamal Hadi Salim wrote:
On 2018-09-05 3:04 p.m., Al Viro wrote:
From: Al Viro
... and disallow deleting or linking to such
Signed-off-by: Al Viro
Same comment as other one in regards to subject
Since the flag space is coming from htnode which is
exposed via uapi
On 2018-09-05 3:04 p.m., Al Viro wrote:
From: Al Viro
Signed-off-by: Al Viro
Acked-by: Jamal Hadi Salim
cheers,
jamal
On 2018-09-05 3:04 p.m., Al Viro wrote:
From: Al Viro
... and disallow deleting or linking to such
Signed-off-by: Al Viro
Same comment as other one in regards to subject
Since the flag space is coming from htnode which is
exposed via uapi it makes sense to keep this one here
because it is
On 2018-09-05 3:04 p.m., Al Viro wrote:
From: Al Viro
cls_u32.c misuses refcounts for struct tc_u_hnode - it counts references via
->hlist and via ->tp_root together. u32_destroy() drops the former and, in
case when there had been links, leaves the sucker on the list. As the result,
there's
On 06.09.2018 08:24, Saeed Mahameed wrote:
On Sun, Sep 2, 2018 at 2:55 AM, Konstantin Khlebnikov
wrote:
On 02.09.2018 12:29, Tariq Toukan wrote:
On 31/08/2018 2:29 PM, Konstantin Khlebnikov wrote:
XOR (MLX5_RX_HASH_FN_INVERTED_XOR8) gives only 8 bits.
It seems not enough for RFS. All
On 09/06/2018 02:23 AM, Vlad Buslov wrote:
>
> On Thu 06 Sep 2018 at 08:39, Kirill Tkhai wrote:
>> On 06.09.2018 11:30, Eric Dumazet wrote:
>>>
>>>
>>> On 09/06/2018 12:58 AM, Vlad Buslov wrote:
>>>
>>> ...
>>>
diff --git a/include/net/sch_generic.h b/include/net/sch_generic.h
index
On Thu 06 Sep 2018 at 08:39, Kirill Tkhai wrote:
> On 06.09.2018 11:30, Eric Dumazet wrote:
>>
>>
>> On 09/06/2018 12:58 AM, Vlad Buslov wrote:
>>
>> ...
>>
>>> diff --git a/include/net/sch_generic.h b/include/net/sch_generic.h
>>> index 18e22a5a6550..239c73f29471 100644
>>> ---
On 09/06/2018 01:39 AM, Kirill Tkhai wrote:
> On 06.09.2018 11:30, Eric Dumazet wrote:
>>
>>
>> On 09/06/2018 12:58 AM, Vlad Buslov wrote:
>>
>> ...
>>
>>> diff --git a/include/net/sch_generic.h b/include/net/sch_generic.h
>>> index 18e22a5a6550..239c73f29471 100644
>>> ---
Some userspace applications need to know about MLD joins from the
kernel for 2 reasons:
1. To allow the programming of multicast MAC filters in hardware
2. To form a multicast FORUS list for non link-local multicast
groups to be sent to the kernel and from there to the interested
party.
(1)
Some userspace applications need to know about IGMP joins from the
kernel for 2 reasons:
1. To allow the programming of multicast MAC filters in hardware
2. To form a multicast FORUS list for non link-local multicast
groups to be sent to the kernel and from there to the interested
party.
(1)
On 06.09.2018 11:30, Eric Dumazet wrote:
>
>
> On 09/06/2018 12:58 AM, Vlad Buslov wrote:
>
> ...
>
>> diff --git a/include/net/sch_generic.h b/include/net/sch_generic.h
>> index 18e22a5a6550..239c73f29471 100644
>> --- a/include/net/sch_generic.h
>> +++ b/include/net/sch_generic.h
>> @@ -90,6
1 - 100 of 120 matches
Mail list logo
