Re: [PATCH net] ipv6: use rt6_info members when dst is set in rt6_fill_node

2018-09-10 Thread Hangbin Liu
Hi David, On Mon, Sep 10, 2018 at 08:39:34PM -0600, David Ahern wrote: > On 9/10/18 7:04 PM, Hangbin Liu wrote: > > > diff --git a/net/ipv6/route.c b/net/ipv6/route.c > > index 18e00ce..62621b4 100644 > > --- a/net/ipv6/route.c > > +++ b/net/ipv6/route.c > > @@ -998,6 +998,21 @@ static void

Re: [PATCH net] ipv6: use rt6_info members when dst is set in rt6_fill_node

2018-09-10 Thread David Ahern
On 9/10/18 7:04 PM, Hangbin Liu wrote: > diff --git a/net/ipv6/route.c b/net/ipv6/route.c > index 18e00ce..62621b4 100644 > --- a/net/ipv6/route.c > +++ b/net/ipv6/route.c > @@ -998,6 +998,21 @@ static void ip6_rt_copy_init(struct rt6_info *rt, struct > fib6_info *ort) > rt->rt6i_prefsrc =

Re: [Patch net v2] rds: fix two RCU related problems

2018-09-10 Thread Santosh Shilimkar
On 9/10/2018 6:27 PM, Cong Wang wrote: When a rds sock is bound, it is inserted into the bind_hash_table which is protected by RCU. But when releasing rds sock, after it is removed from this hash table, it is freed immediately without respecting RCU grace period. This could cause some

[Patch net v2] rds: fix two RCU related problems

2018-09-10 Thread Cong Wang
When a rds sock is bound, it is inserted into the bind_hash_table which is protected by RCU. But when releasing rds sock, after it is removed from this hash table, it is freed immediately without respecting RCU grace period. This could cause some use-after-free as reported by syzbot. Mark the rds

[PATCHv2 iproute2] bridge/mdb: fix missing new line when show bridge mdb

2018-09-10 Thread Hangbin Liu
The bridge mdb show is broken on current iproute2. e.g. ]# bridge mdb show 34: br0 veth0_br 224.1.1.2 temp 34: br0 veth0_br 224.1.1.1 temp After fix: ]# bridge mdb show 34: br0 veth0_br 224.1.1.2 temp 34: br0 veth0_br 224.1.1.1 temp v2: use json print lib as Stephen suggested.

Re: [PATCH net-next] virtio_net: ethtool tx napi configuration

2018-09-10 Thread Willem de Bruijn
> >> I cook a fixup, and it looks works in my setup: > >> > >> diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c > >> index b320b6b14749..9181c3f2f832 100644 > >> --- a/drivers/net/virtio_net.c > >> +++ b/drivers/net/virtio_net.c > >> @@ -2204,10 +2204,17 @@ static int

Re: [RFC PATCH bpf-next v2 0/4] Implement bpf queue/stack maps

2018-09-10 Thread Alexei Starovoitov
On Fri, Sep 7, 2018 at 1:40 PM, Mauricio Vasquez wrote: > > I read the Joe's proposal and using that for this problem looks like a nice > solution. > > I think a good trade-off for now would be to go ahead with a queue/stack map > without preallocating support (or maybe include it having always

Re: [PATCH net] ipv6: use rt6_info members when dst is set in rt6_fill_node

2018-09-10 Thread Hangbin Liu
On Mon, Sep 10, 2018 at 01:07:11PM -0600, David Ahern wrote: > On 9/10/18 11:55 AM, Xin Long wrote: > > On Tue, Sep 11, 2018 at 12:13 AM David Ahern > > wrote: > >> > >> On 9/9/18 12:29 AM, Xin Long wrote: > > diff --git a/net/ipv6/route.c b/net/ipv6/route.c > > index 18e00ce..e554922

[PATCH][net-next][v2] netlink: remove hash::nelems check in netlink_insert

2018-09-10 Thread Li RongQing
The type of hash::nelems has been changed from size_t to atom_t which in fact is int, so not need to check if BITS_PER_LONG, that is bit number of size_t, is bigger than 32 and rht_grow_above_max() will be called to check if hashtable is too big, ensure it can not bigger than 1<<31

Re: [Patch net] rds: mark bound socket with SOCK_RCU_FREE

2018-09-10 Thread Cong Wang
On Mon, Sep 10, 2018 at 5:56 PM Santosh Shilimkar wrote: > > On 9/10/2018 5:45 PM, Cong Wang wrote: > > On Mon, Sep 10, 2018 at 5:26 PM Santosh Shilimkar > > wrote: > >> Would you mind posting an updated patch please with call_rcu and > >> above extended RCU grace period with rcu_read_lock.

Re: [Patch net] rds: mark bound socket with SOCK_RCU_FREE

2018-09-10 Thread Santosh Shilimkar
On 9/10/2018 5:45 PM, Cong Wang wrote: On Mon, Sep 10, 2018 at 5:26 PM Santosh Shilimkar wrote: Would you mind posting an updated patch please with call_rcu and above extended RCU grace period with rcu_read_lock. Thanks !! If you prefer to fix _two_ problems in one patch, sure. For the

Re: [net-next, PATCH 2/2, v1] net: socionext: add AF_XDP support

2018-09-10 Thread Toshiaki Makita
On 2018/09/11 1:21, Ilias Apalodimas wrote: >>> @@ -707,6 +731,26 @@ static int netsec_process_rx(struct netsec_priv *priv, >>> int budget) >>> if (unlikely(!buf_addr)) >>> break; >>> >>> + if (xdp_prog) { >>> + xdp_result =

Re: [PATCH net-next] virtio_net: ethtool tx napi configuration

2018-09-10 Thread Jason Wang
On 2018年09月10日 21:35, Willem de Bruijn wrote: On Mon, Sep 10, 2018 at 2:01 AM Jason Wang wrote: On 2018年09月10日 06:44, Willem de Bruijn wrote: From: Willem de Bruijn Implement ethtool .set_coalesce (-C) and .get_coalesce (-c) handlers. Interrupt moderation is currently not supported, so

Re: [Patch net] rds: mark bound socket with SOCK_RCU_FREE

2018-09-10 Thread Cong Wang
On Mon, Sep 10, 2018 at 5:26 PM Santosh Shilimkar wrote: > Would you mind posting an updated patch please with call_rcu and > above extended RCU grace period with rcu_read_lock. Thanks !! If you prefer to fix _two_ problems in one patch, sure. For the record, the bug this patch fixes is NOT

Re: [Patch net] rds: mark bound socket with SOCK_RCU_FREE

2018-09-10 Thread Cong Wang
On Mon, Sep 10, 2018 at 5:24 PM Sowmini Varadhan wrote: > > On (09/10/18 17:16), Cong Wang wrote: > > > > > > On (09/10/18 16:51), Cong Wang wrote: > > > > > > > > __rds_create_bind_key(key, addr, port, scope_id); > > > > - rs = rhashtable_lookup_fast(_hash_table, key, ht_parms); >

Re: unexpected GRO/veth behavior

2018-09-10 Thread Toshiaki Makita
On 2018/09/10 23:56, Eric Dumazet wrote: > On 09/10/2018 07:44 AM, Paolo Abeni wrote: >> hi all, >> >> while testing some local patches I observed that the TCP tput in the >> following scenario: >> >> # the following enable napi on veth0, so that we can trigger the >> # GRO path with namespaces >>

Re: [Patch net] rds: mark bound socket with SOCK_RCU_FREE

2018-09-10 Thread Santosh Shilimkar
On 9/10/2018 5:16 PM, Cong Wang wrote: On Mon, Sep 10, 2018 at 5:04 PM Sowmini Varadhan wrote: On (09/10/18 16:51), Cong Wang wrote: __rds_create_bind_key(key, addr, port, scope_id); - rs = rhashtable_lookup_fast(_hash_table, key, ht_parms); + rcu_read_lock(); +

Re: [Patch net] rds: mark bound socket with SOCK_RCU_FREE

2018-09-10 Thread Sowmini Varadhan
On (09/10/18 17:16), Cong Wang wrote: > > > > On (09/10/18 16:51), Cong Wang wrote: > > > > > > __rds_create_bind_key(key, addr, port, scope_id); > > > - rs = rhashtable_lookup_fast(_hash_table, key, ht_parms); > > > + rcu_read_lock(); > > > + rs =

[PATCH net-next] scsi: libcxgbi: fib6_ino reference in rt6_info is rcu protected

2018-09-10 Thread dsahern
From: David Ahern The fib6_info reference in rt6_info is rcu protected. Add a helper to extract prefsrc from and update cxgbi_check_route6 to use it. Fixes: 0153167aebd0 ("net/ipv6: Remove rt6i_prefsrc") Reported-by: kbuild test robot Signed-off-by: David Ahern ---

Re: [Patch net] rds: mark bound socket with SOCK_RCU_FREE

2018-09-10 Thread Cong Wang
On Mon, Sep 10, 2018 at 5:04 PM Sowmini Varadhan wrote: > > On (09/10/18 16:51), Cong Wang wrote: > > > > __rds_create_bind_key(key, addr, port, scope_id); > > - rs = rhashtable_lookup_fast(_hash_table, key, ht_parms); > > + rcu_read_lock(); > > + rs =

Re: [Patch net] rds: mark bound socket with SOCK_RCU_FREE

2018-09-10 Thread Sowmini Varadhan
On (09/10/18 16:51), Cong Wang wrote: > > __rds_create_bind_key(key, addr, port, scope_id); > - rs = rhashtable_lookup_fast(_hash_table, key, ht_parms); > + rcu_read_lock(); > + rs = rhashtable_lookup(_hash_table, key, ht_parms); > if (rs &&

Re: [Patch net] rds: mark bound socket with SOCK_RCU_FREE

2018-09-10 Thread Cong Wang
On Mon, Sep 10, 2018 at 4:30 PM Sowmini Varadhan wrote: > > On (09/10/18 15:43), Santosh Shilimkar wrote: > > On 9/10/2018 3:24 PM, Cong Wang wrote: > > >When a rds sock is bound, it is inserted into the bind_hash_table > > >which is protected by RCU. But when releasing rd sock, after it > > >is

Re: [PATCH v2 net-next 05/12] net: ethernet: genet: Fix speed selection

2018-09-10 Thread Florian Fainelli
On 09/10/2018 02:52 PM, Andrew Lunn wrote: > The phy supported speed is being used to determine if the MAC should > be configured to 100 or 1G. The masking logic is broken. Instead, look > 1G supported speeds to enable 1G MAC support. > > Signed-off-by: Andrew Lunn Acked-by: Florian Fainelli

Re: [Patch net] rds: mark bound socket with SOCK_RCU_FREE

2018-09-10 Thread Sowmini Varadhan
On (09/10/18 15:43), Santosh Shilimkar wrote: > On 9/10/2018 3:24 PM, Cong Wang wrote: > >When a rds sock is bound, it is inserted into the bind_hash_table > >which is protected by RCU. But when releasing rd sock, after it > >is removed from this hash table, it is freed immediately without >

Re: [PATCH v2 net-next 11/12] net: ethernet: Add helper for set_pauseparam for Pause

2018-09-10 Thread Florian Fainelli
On 09/10/2018 02:52 PM, Andrew Lunn wrote: > ethtool can be used to enable/disable pause. Add a helper to configure > the PHY when Pause is supported. > > Signed-off-by: Andrew Lunn Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH v2 net-next 10/12] net: ethernet: Add helper for set_pauseparam for Asym Pause

2018-09-10 Thread Florian Fainelli
On 09/10/2018 02:52 PM, Andrew Lunn wrote: > ethtool can be used to enable/disable pause. Add a helper to configure > the PHY when asym pause is supported. > > Signed-off-by: Andrew Lunn Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH v2 net-next 01/12] net: phy: ste10Xp: Remove wrong SUPPORTED_Pause

2018-09-10 Thread Florian Fainelli
On 09/10/2018 02:52 PM, Andrew Lunn wrote: > The PHY driver should not indicate that Pause is supported. It is upto > the MAC drive enable it, if it supports Pause frames. So remove it > from the ste10Xp driver. > > Signed-off-by: Andrew Lunn Reviewed-by: Florian Fainelli -- Florian

Re: [Patch net] rds: mark bound socket with SOCK_RCU_FREE

2018-09-10 Thread Santosh Shilimkar
On 9/10/2018 3:24 PM, Cong Wang wrote: When a rds sock is bound, it is inserted into the bind_hash_table which is protected by RCU. But when releasing rd sock, after it is removed from this hash table, it is freed immediately without respecting RCU grace period. This could cause some

Re: [Patch net] rds: mark bound socket with SOCK_RCU_FREE

2018-09-10 Thread Sowmini Varadhan
On (09/10/18 15:24), Cong Wang wrote: > > When a rds sock is bound, it is inserted into the bind_hash_table > which is protected by RCU. But when releasing rd sock, after it > is removed from this hash table, it is freed immediately without > respecting RCU grace period. This could cause some

[Patch net] rds: mark bound socket with SOCK_RCU_FREE

2018-09-10 Thread Cong Wang
When a rds sock is bound, it is inserted into the bind_hash_table which is protected by RCU. But when releasing rd sock, after it is removed from this hash table, it is freed immediately without respecting RCU grace period. This could cause some use-after-free as reported by syzbot. Mark the rds

Re: [PATCH v3 net-next 5/6] dt-bindings: net: dsa: Add lantiq,xrx200-gswip DT bindings

2018-09-10 Thread Andrew Lunn
> > +See Documentation/devicetree/bindings/net/dsa/dsa.txt for a list of > > +additional required and optional properties. > > + > > + snip > > + #address-cells = <1>; > > + #size-cells = <0>; > > + compatible = "lantiq,xrx200-gswip"; > > + reg = < 0xE108000 0x3000 /* switch */ > > +

Re: [PATCH v3 net-next 5/6] dt-bindings: net: dsa: Add lantiq,xrx200-gswip DT bindings

2018-09-10 Thread Rob Herring
On Sun, Sep 09, 2018 at 10:20:27PM +0200, Hauke Mehrtens wrote: > This adds the binding for the GSWIP (Gigabit switch) core found in the > xrx200 / VR9 Lantiq / Intel SoC. > > This part takes care of the switch, MDIO bus, and loading the FW into > the embedded GPHYs. > > Signed-off-by: Hauke

[PATCH v2 net-next 12/12] net: ethernet: Add helper to determine if pause configuration is supported

2018-09-10 Thread Andrew Lunn
Rather than have MAC drivers open code the test, add a helper in phylib. This will help when we change the type of phydev->supported. Signed-off-by: Andrew Lunn Reviewed-by: Florian Fainelli --- .../ethernet/apm/xgene/xgene_enet_ethtool.c | 4 +--- drivers/net/ethernet/broadcom/tg3.c

[PATCH v2 net-next 10/12] net: ethernet: Add helper for set_pauseparam for Asym Pause

2018-09-10 Thread Andrew Lunn
ethtool can be used to enable/disable pause. Add a helper to configure the PHY when asym pause is supported. Signed-off-by: Andrew Lunn --- v2: Also trigger autoneg if the advertising settings have changed. --- .../ethernet/apm/xgene/xgene_enet_ethtool.c | 26 ++

[PATCH v2 net-next 11/12] net: ethernet: Add helper for set_pauseparam for Pause

2018-09-10 Thread Andrew Lunn
ethtool can be used to enable/disable pause. Add a helper to configure the PHY when Pause is supported. Signed-off-by: Andrew Lunn --- v2: Rename phy_set_pause() to phy_set_sym_pause() Use the bcm63xx_enet.c logic, not fec_main.c --- drivers/net/ethernet/broadcom/bcm63xx_enet.c | 7 ++-

[PATCH v2 net-next 02/12] net: phy: et1011c: Remove incorrect missing 1000 Half

2018-09-10 Thread Andrew Lunn
The driver indicates it can do 10/100 full and half duplex, plus 1G Full. The datasheet indicates 1G half is also supported. So make use of the standard PHY_GBIT_FEATURES. It could be, this was added because there is a MAC which does not support 1G half. Bit this is the wrong place to enforce

[PATCH v2 net-next 08/12] net: ethernet: Add helper for MACs which support asym pause

2018-09-10 Thread Andrew Lunn
Rather than have the MAC drivers manipulate phydev members to indicate they support Asym Pause, add a helper function. Signed-off-by: Andrew Lunn Reviewed-by: Florian Fainelli --- v2: Fixup bad indentation in tg3.c --- drivers/net/ethernet/amd/xgbe/xgbe-phy-v2.c | 4 ++--

[PATCH v2 net-next 01/12] net: phy: ste10Xp: Remove wrong SUPPORTED_Pause

2018-09-10 Thread Andrew Lunn
The PHY driver should not indicate that Pause is supported. It is upto the MAC drive enable it, if it supports Pause frames. So remove it from the ste10Xp driver. Signed-off-by: Andrew Lunn --- drivers/net/phy/ste10Xp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH v2 net-next 09/12] net: ethernet: Add helper for MACs which support pause

2018-09-10 Thread Andrew Lunn
Rather than have the MAC drivers manipulate phydev members, add a helper function for MACs supporting Pause, but not Asym Pause. Signed-off-by: Andrew Lunn Reviewed-by: Florian Fainelli --- v2: rename phy_support_pause() to phy_support_sym_pause() ---

[PATCH v2 net-next 05/12] net: ethernet: genet: Fix speed selection

2018-09-10 Thread Andrew Lunn
The phy supported speed is being used to determine if the MAC should be configured to 100 or 1G. The masking logic is broken. Instead, look 1G supported speeds to enable 1G MAC support. Signed-off-by: Andrew Lunn --- drivers/net/ethernet/broadcom/genet/bcmmii.c | 7 +++ 1 file changed, 3

[PATCH v2 net-next 04/12] net: ethernet: Use phy_set_max_speed() to limit advertised speed

2018-09-10 Thread Andrew Lunn
Many Ethernet MAC drivers want to limit the PHY to only advertise a maximum speed of 100Mbs or 1Gbps. Rather than using a mask, make use of the helper function phy_set_max_speed(). Signed-off-by: Andrew Lunn Reviewed-by: Florian Fainelli --- drivers/net/ethernet/8390/ax88796.c |

[PATCH v2 net-next 06/12] net: ethernet: Fix up drivers masking pause support

2018-09-10 Thread Andrew Lunn
PHY drivers don't indicate they support pause. They expect MAC drivers to enable its support if the MAC has the needed hardware. Thus MAC drivers should not mask Pause support, but enable it. Change a few ANDs to ORs. Signed-off-by: Andrew Lunn Reviewed-by: Florian Fainelli ---

[PATCH v2 net-next 00/12] Preparing for phylib limkmodes

2018-09-10 Thread Andrew Lunn
phylib currently makes us of a u32 bitmap for advertising, supported, and link partner capabilities. For a long time, this has been sufficient, for devices up to 1Gbps. With more MAC/PHY combinations now supporting speeds greater than 1Gbps, we have run out of bits. There is the need to replace

[PATCH v2 net-next 07/12] net: ethernet: Add helper to remove a supported link mode

2018-09-10 Thread Andrew Lunn
Some MAC hardware cannot support a subset of link modes. e.g. often 1Gbps Full duplex is supported, but Half duplex is not. Add a helper to remove such a link mode. Signed-off-by: Andrew Lunn Reviewed-by: Florian Fainelli --- drivers/net/ethernet/apm/xgene/xgene_enet_hw.c | 6 +++---

[PATCH v2 net-next 03/12] net: phy: bcm63xx: Allow to be built with COMPILE_TEST

2018-09-10 Thread Andrew Lunn
There is nothing in this driver which prevents it to be compiled for other architectures. Add COMPILE_TEST so we get better compile test coverage. Signed-off-by: Andrew Lunn Reviewed-by: Florian Fainelli --- drivers/net/phy/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

Re: [PATCH v3 net-next 3/6] dt-bindings: net: Add lantiq,xrx200-net DT bindings

2018-09-10 Thread Rob Herring
On Sun, Sep 09, 2018 at 10:16:44PM +0200, Hauke Mehrtens wrote: > This adds the binding for the PMAC core between the CPU and the GSWIP > switch found on the xrx200 / VR9 Lantiq / Intel SoC. > > Signed-off-by: Hauke Mehrtens > Cc: devicet...@vger.kernel.org > --- >

[net-next:master 89/93] drivers/scsi/cxgbi/libcxgbi.c:787:43: sparse: incorrect type in argument 1 (different address spaces)

2018-09-10 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master head: 11957be20ff68d7670cb979a1c3ea5482a44b370 commit: 0153167aebd0808fb90031dba07d4e696557474c [89/93] net/ipv6: Remove rt6i_prefsrc reproduce: # apt-get install sparse git checkout

Re: [PATCH net-next 02/15] sch_netem: Move private queue handler to generic location.

2018-09-10 Thread Stephen Hemminger
On Sat, 08 Sep 2018 13:10:01 -0700 (PDT) David Miller wrote: > By hand copies of SKB list handlers do not belong in individual packet > schedulers. > > Signed-off-by: David S. Miller Thanks for cleaning this up. Signed-off-by: Stephen Hemminger

ksoftirqd takes 100% of a core with ixgbe and netconsole (netpoll)

2018-09-10 Thread Song Liu
We are debugging an issue with netconsole and ixgbe, that ksoftirqd takes 100% of a core. It happens with both current net and net-next. To reproduce the issue: 1. Setup server with ixgbe and netconsole. We bind each queue to a separate core via smp_affinity; 2. Start simple netperf

Re: [PATCH net-next v2 1/2] net: stmmac: Rework coalesce timer and fix multi-queue races

2018-09-10 Thread Florian Fainelli
On 09/10/2018 02:14 AM, Jose Abreu wrote: > This follows David Miller advice and tries to fix coalesce timer in > multi-queue scenarios. > > We are now using per-queue coalesce values and per-queue TX timer. > > Coalesce timer default values was changed to 1ms and the coalesce frames > to 25. >

Re: [iproute PATCH v2] ip-route: Fix segfault with many nexthops

2018-09-10 Thread Stephen Hemminger
On Thu, 6 Sep 2018 15:31:51 +0200 Phil Sutter wrote: > It was possible to crash ip-route by adding an IPv6 route with 37 > nexthop statements. A simple reproducer is: > > | for i in `seq 37`; do > | nhs="nexthop via ::$i "$nhs > | done > | ip -6 route add ::/64 $nhs > > The

Re: [PATCH iproute2 v2] tc/mqprio: Print extra info on invalid args.

2018-09-10 Thread Stephen Hemminger
On Thu, 6 Sep 2018 14:01:17 -0700 Caleb Raitto wrote: > From: Caleb Raitto > > Print the name of the argument that wasn't understood. > > Signed-off-by: Caleb Raitto That is simpler, thanks. Applied

Re: [PATCH net] ipv6: use rt6_info members when dst is set in rt6_fill_node

2018-09-10 Thread David Ahern
On 9/10/18 11:55 AM, Xin Long wrote: > On Tue, Sep 11, 2018 at 12:13 AM David Ahern wrote: >> >> On 9/9/18 12:29 AM, Xin Long wrote: > diff --git a/net/ipv6/route.c b/net/ipv6/route.c > index 18e00ce..e554922 100644 > --- a/net/ipv6/route.c > +++ b/net/ipv6/route.c > @@

Fw: [Bug 201063] New: kernel panic on heavy network use

2018-09-10 Thread Stephen Hemminger
Begin forwarded message: Date: Sun, 09 Sep 2018 13:45:28 + From: bugzilla-dae...@bugzilla.kernel.org To: step...@networkplumber.org Subject: [Bug 201063] New: kernel panic on heavy network use https://bugzilla.kernel.org/show_bug.cgi?id=201063 Bug ID: 201063

Fw: [Bug 201071] New: Creating a vxlan in state 'up' does not give proper RTM_NEWLINK message

2018-09-10 Thread Stephen Hemminger
Begin forwarded message: Date: Mon, 10 Sep 2018 04:04:37 + From: bugzilla-dae...@bugzilla.kernel.org To: step...@networkplumber.org Subject: [Bug 201071] New: Creating a vxlan in state 'up' does not give proper RTM_NEWLINK message https://bugzilla.kernel.org/show_bug.cgi?id=201071

Re: [PATCH net-next v2 2/2] net: stmmac: Fixup the tail addr setting in xmit path

2018-09-10 Thread Florian Fainelli
On 09/10/2018 02:14 AM, Jose Abreu wrote: > Currently we are always setting the tail address of descriptor list to > the end of the pre-allocated list. > > According to databook this is not correct. Tail address should point to > the last available descriptor + 1, which means we have to update

Re: [net-next, v2, 1/2] net: stmmac: Rework coalesce timer and fix multi-queue races

2018-09-10 Thread Neil Armstrong
Hi Jose, On 10/09/2018 18:21, Jose Abreu wrote: > On 10-09-2018 16:49, Neil Armstrong wrote: >> Hi Jose, >> >> On 10/09/2018 16:44, Jose Abreu wrote: >>> On 10-09-2018 14:46, Neil Armstrong wrote: hi Jose, On 10/09/2018 14:55, Jose Abreu wrote: > On 10-09-2018 13:52, Jose Abreu

Re: [PATCH can-next] can: ucan: remove duplicated include from ucan.c

2018-09-10 Thread Martin Elshuber
Thank you for the fix Reviewed-by: Martin Elshuber Am 29.08.18 um 03:25 schrieb YueHaibing: > Remove duplicated include. > > Signed-off-by: YueHaibing > --- > drivers/net/can/usb/ucan.c | 4 > 1 file changed, 4 deletions(-) > > diff --git a/drivers/net/can/usb/ucan.c

Re: [PATCH net] ipv6: use rt6_info members when dst is set in rt6_fill_node

2018-09-10 Thread Xin Long
On Tue, Sep 11, 2018 at 12:13 AM David Ahern wrote: > > On 9/9/18 12:29 AM, Xin Long wrote: > >>> diff --git a/net/ipv6/route.c b/net/ipv6/route.c > >>> index 18e00ce..e554922 100644 > >>> --- a/net/ipv6/route.c > >>> +++ b/net/ipv6/route.c > >>> @@ -4670,20 +4670,33 @@ static int

Re: [PATCH net] qmi_wwan: Support dynamic config on Quectel EP06

2018-09-10 Thread David Miller
From: Kristian Evensen Date: Sat, 8 Sep 2018 13:50:48 +0200 > Quectel EP06 (and EM06/EG06) supports dynamic configuration of USB > interfaces, without the device changing VID/PID or configuration number. > When the configuration is updated and interfaces are added/removed, the > interface

Re: [Patch net-next] htb: use anonymous union for simplicity

2018-09-10 Thread David Miller
From: Cong Wang Date: Fri, 7 Sep 2018 13:29:14 -0700 > cl->leaf.q is slightly more readable than cl->un.leaf.q. > > Cc: Jamal Hadi Salim > Signed-off-by: Cong Wang Applied.

Re: [Patch net-next] net_sched: remove redundant qdisc lock classes

2018-09-10 Thread David Miller
From: Cong Wang Date: Fri, 7 Sep 2018 13:29:13 -0700 > We no longer take any spinlock on RX path for ingress qdisc, > so this lockdep annotation is no longer needed. > > Cc: Jamal Hadi Salim > Signed-off-by: Cong Wang Applied.

Re: [PATCH net-next v2] net: sched: cls_flower: dump offload count value

2018-09-10 Thread David Miller
From: Vlad Buslov Date: Fri, 7 Sep 2018 17:22:21 +0300 > Change flower in_hw_count type to fixed-size u32 and dump it as > TCA_FLOWER_IN_HW_COUNT. This change is necessary to properly test shared > blocks and re-offload functionality. > > Signed-off-by: Vlad Buslov > Acked-by: Jiri Pirko

[PATCH net-next v1] net/tls: Fixed return value when tls_complete_pending_work() fails

2018-09-10 Thread Vakul Garg
In tls_sw_sendmsg() and tls_sw_sendpage(), the variable 'ret' has been set to return value of tls_complete_pending_work(). This allows return of proper error code if tls_complete_pending_work() fails. Fixes: 3c4d7559159b ("tls: kernel TLS support") Signed-off-by: Vakul Garg --- net/tls/tls_sw.c

Re: unexpected GRO/veth behavior

2018-09-10 Thread Eric Dumazet
On 09/10/2018 08:22 AM, Paolo Abeni wrote: in this already heavy cost engine. > > Yup, even if I do not see any measurable cost added by the posted code. Sure, micro bench marks wont show anything. Now, if GRO receives one packet every 100 usec, as many hosts in the wild do, there is an

Re: [PATCH net-next] net/ipv6: Remove rt6i_prefsrc

2018-09-10 Thread David Miller
From: dsah...@kernel.org Date: Mon, 10 Sep 2018 09:11:28 -0700 > From: David Ahern > > After the conversion to fib6_info, rt6i_prefsrc has a single user that > reads the value and otherwise it is only set. The one reader can be > converted to use rt->from so rt6i_prefsrc can be removed,

Re: [net-next, v2, 1/2] net: stmmac: Rework coalesce timer and fix multi-queue races

2018-09-10 Thread Jose Abreu
On 10-09-2018 16:49, Neil Armstrong wrote: > Hi Jose, > > On 10/09/2018 16:44, Jose Abreu wrote: >> On 10-09-2018 14:46, Neil Armstrong wrote: >>> hi Jose, >>> >>> On 10/09/2018 14:55, Jose Abreu wrote: On 10-09-2018 13:52, Jose Abreu wrote: > Can you please try attached follow-up patch ?

Re: [net-next, PATCH 2/2, v1] net: socionext: add AF_XDP support

2018-09-10 Thread Ilias Apalodimas
> > @@ -707,6 +731,26 @@ static int netsec_process_rx(struct netsec_priv *priv, > > int budget) > > if (unlikely(!buf_addr)) > > break; > > > > + if (xdp_prog) { > > + xdp_result = netsec_run_xdp(desc, priv, xdp_prog, > > +

Re: [PATCH net] ipv6: use rt6_info members when dst is set in rt6_fill_node

2018-09-10 Thread David Ahern
On 9/9/18 12:29 AM, Xin Long wrote: >>> diff --git a/net/ipv6/route.c b/net/ipv6/route.c >>> index 18e00ce..e554922 100644 >>> --- a/net/ipv6/route.c >>> +++ b/net/ipv6/route.c >>> @@ -4670,20 +4670,33 @@ static int rt6_fill_node(struct net *net, struct >>> sk_buff *skb, >>>

[PATCH net-next] net/ipv6: Remove rt6i_prefsrc

2018-09-10 Thread dsahern
From: David Ahern After the conversion to fib6_info, rt6i_prefsrc has a single user that reads the value and otherwise it is only set. The one reader can be converted to use rt->from so rt6i_prefsrc can be removed, reducing rt6_info by another 20 bytes. Signed-off-by: David Ahern ---

Re: [net-next, v2, 1/2] net: stmmac: Rework coalesce timer and fix multi-queue races

2018-09-10 Thread Neil Armstrong
Hi Jose, On 10/09/2018 16:44, Jose Abreu wrote: > On 10-09-2018 14:46, Neil Armstrong wrote: >> hi Jose, >> >> On 10/09/2018 14:55, Jose Abreu wrote: >>> On 10-09-2018 13:52, Jose Abreu wrote: Can you please try attached follow-up patch ? >>> Oh, please apply the whole series otherwise this

Re: unexpected GRO/veth behavior

2018-09-10 Thread Paolo Abeni
On Mon, 2018-09-10 at 07:56 -0700, Eric Dumazet wrote: > > On 09/10/2018 07:44 AM, Paolo Abeni wrote: > > hi all, > > > > while testing some local patches I observed that the TCP tput in the > > following scenario: > > > > # the following enable napi on veth0, so that we can trigger the > > #

Re: [PATCH] cxgb4: fix abort_req_rss6 struct

2018-09-10 Thread Steve Wise
(sorry for the late reply, I was out all last week) On 9/5/2018 5:55 PM, Jason Gunthorpe wrote: > On Fri, Aug 31, 2018 at 11:52:00AM -0700, Steve Wise wrote: >> Remove the incorrect WR_HDR field which can cause a misinterpretation >> of this CPL by ULDs. > > What does that mean? > It means

Re: unexpected GRO/veth behavior

2018-09-10 Thread Eric Dumazet
On 09/10/2018 07:44 AM, Paolo Abeni wrote: > hi all, > > while testing some local patches I observed that the TCP tput in the > following scenario: > > # the following enable napi on veth0, so that we can trigger the > # GRO path with namespaces > ip netns add test > ip link add type veth >

unexpected GRO/veth behavior

2018-09-10 Thread Paolo Abeni
hi all, while testing some local patches I observed that the TCP tput in the following scenario: # the following enable napi on veth0, so that we can trigger the # GRO path with namespaces ip netns add test ip link add type veth ip link set dev veth0 netns test ip -n test link set lo up ip -n

Re: [net-next, v2, 1/2] net: stmmac: Rework coalesce timer and fix multi-queue races

2018-09-10 Thread Jose Abreu
On 10-09-2018 14:46, Neil Armstrong wrote: > hi Jose, > > On 10/09/2018 14:55, Jose Abreu wrote: >> On 10-09-2018 13:52, Jose Abreu wrote: >>> Can you please try attached follow-up patch ? >> Oh, please apply the whole series otherwise this will not apply >> cleanly. > Indeed, it helps! > > With

Re: [PATCH net] qmi_wwan: Support dynamic config on Quectel EP06

2018-09-10 Thread Dan Williams
On Sat, 2018-09-08 at 16:12 +0200, Bjørn Mork wrote: > Kristian Evensen writes: > > > Quectel EP06 (and EM06/EG06) supports dynamic configuration of USB > > interfaces, without the device changing VID/PID or configuration > > number. > > When the configuration is updated and interfaces are

Re: [PATCH net-next v3 4/7] net: aquantia: implement EEE support

2018-09-10 Thread Andrew Lunn
On Mon, Sep 10, 2018 at 12:39:31PM +0300, Igor Russkikh wrote: > From: Yana Esina > > Support of Energy-Efficient Ethernet to aQuantia NIC's via ethtool > (according to the IEEE 802.3az specifications) > > Signed-off-by: Yana Esina > Signed-off-by: Nikita Danilov > Tested-by: Nikita Danilov

Re: [PATCH net-next v3 3/7] net: aquantia: implement WOL support

2018-09-10 Thread Andrew Lunn
On Mon, Sep 10, 2018 at 12:39:30PM +0300, Igor Russkikh wrote: > From: Yana Esina > > Add WOL support. Currently only magic packet > (ethtool -s wol g) feature is implemented. > > Remove hw_set_power and move that to FW_OPS set_power: > because WOL configuration behaves differently on 1x and

Re: [PATCH net-next v3 2/7] net: aquantia: definitions for WOL

2018-09-10 Thread Andrew Lunn
On Mon, Sep 10, 2018 at 12:39:29PM +0300, Igor Russkikh wrote: > From: Yana Esina > > Added definitions and structures needed to support WOL. > > Signed-off-by: Yana Esina > Signed-off-by: Nikita Danilov > Tested-by: Nikita Danilov > Signed-off-by: Igor Russkikh Reviewed-by: Andrew Lunn

Re: [net-next, v2, 1/2] net: stmmac: Rework coalesce timer and fix multi-queue races

2018-09-10 Thread Neil Armstrong
hi Jose, On 10/09/2018 14:55, Jose Abreu wrote: > On 10-09-2018 13:52, Jose Abreu wrote: >> >> Can you please try attached follow-up patch ? > > Oh, please apply the whole series otherwise this will not apply > cleanly. Indeed, it helps! With the fixups, it fails later, around 15s instead of

Re: [PATCH can-next] can: ucan: remove set but not used variable 'udev'

2018-09-10 Thread Martin Elshuber
Thank you for the fix Reviewed-by: Martin Elshuber > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/net/can/usb/ucan.c: In function 'ucan_disconnect': > drivers/net/can/usb/ucan.c:1578:21: warning: > variable 'udev' set but not used [-Wunused-but-set-variable] > struct

Re: [PATCH net-next] virtio_net: ethtool tx napi configuration

2018-09-10 Thread Willem de Bruijn
On Mon, Sep 10, 2018 at 2:01 AM Jason Wang wrote: > > > > On 2018年09月10日 06:44, Willem de Bruijn wrote: > > From: Willem de Bruijn > > > > Implement ethtool .set_coalesce (-C) and .get_coalesce (-c) handlers. > > Interrupt moderation is currently not supported, so these accept and > > display

Re: [PATCH v3 net-next 6/6] net: dsa: Add Lantiq / Intel DSA driver for vrx200

2018-09-10 Thread Andrew Lunn
On Sun, Sep 09, 2018 at 10:20:39PM +0200, Hauke Mehrtens wrote: > +static void gswip_phylink_validate(struct dsa_switch *ds, int port, > +unsigned long *supported, > +struct phylink_link_state *state) > +{ > +

Re: [net-next, v2, 1/2] net: stmmac: Rework coalesce timer and fix multi-queue races

2018-09-10 Thread Jose Abreu
On 10-09-2018 13:52, Jose Abreu wrote: > > Can you please try attached follow-up patch ? Oh, please apply the whole series otherwise this will not apply cleanly. Thanks and Best Regards, Jose Miguel Abreu

Re: [PATCH v3 net-next 3/6] dt-bindings: net: Add lantiq,xrx200-net DT bindings

2018-09-10 Thread Andrew Lunn
On Sun, Sep 09, 2018 at 10:16:44PM +0200, Hauke Mehrtens wrote: > This adds the binding for the PMAC core between the CPU and the GSWIP > switch found on the xrx200 / VR9 Lantiq / Intel SoC. > > Signed-off-by: Hauke Mehrtens > Cc: devicet...@vger.kernel.org > --- >

Re: [net-next, v2, 1/2] net: stmmac: Rework coalesce timer and fix multi-queue races

2018-09-10 Thread Jose Abreu
Hi Neil, On 10-09-2018 12:43, Neil Armstrong wrote: > Hi Jose, > > On 10/09/2018 11:14, Jose Abreu wrote: >> This follows David Miller advice and tries to fix coalesce timer in >> multi-queue scenarios. >> >> We are now using per-queue coalesce values and per-queue TX timer. >> >> Coalesce timer

Re: [PATCH v2 net] MIPS: lantiq: dma: add dev pointer

2018-09-10 Thread Andrew Lunn
On Sun, Sep 09, 2018 at 09:26:23PM +0200, Hauke Mehrtens wrote: > dma_zalloc_coherent() now crashes if no dev pointer is given. > Add a dev pointer to the ltq_dma_channel structure and fill it in the > driver using it. > > This fixes a bug introduced in kernel 4.19. > > Signed-off-by: Hauke

Re: Offloaded u32 classifier tables WAS (Re: [PATCH net 00/13] cls_u32 cleanups and fixes.

2018-09-10 Thread Jamal Hadi Salim
On 2018-09-10 8:25 a.m., Jamal Hadi Salim wrote: On 2018-09-09 11:48 a.m., Al Viro wrote: BTW, shouldn't we issue u32_clear_hw_hnode() every time we destroy an hnode?  It's done on u32_delete(), it's done (for root ht) on u32_destroy(), but it's not done for any other hnodes when you remove

Offloaded u32 classifier tables WAS (Re: [PATCH net 00/13] cls_u32 cleanups and fixes.

2018-09-10 Thread Jamal Hadi Salim
On 2018-09-09 11:48 a.m., Al Viro wrote: BTW, shouldn't we issue u32_clear_hw_hnode() every time we destroy an hnode? It's done on u32_delete(), it's done (for root ht) on u32_destroy(), but it's not done for any other hnodes when you remove the entire (not shared) filter. Looks fishy...

Re: [PATCH iproute2 3/3] bridge: fix vlan show formatting

2018-09-10 Thread Tobias Jungel
Hi Stephen, I just have seen this patch, hence please ignore the "bridge: Correct json output" I sent. This one solves the issue in a way more elegant manor. I tested the JSON output in this series and it works as intended. Thanks Reviewed-by: Tobias Jungel On Thu, 2018-09-06 at 16:30

Re: [net-next, v2, 1/2] net: stmmac: Rework coalesce timer and fix multi-queue races

2018-09-10 Thread Neil Armstrong
Hi Jose, On 10/09/2018 11:14, Jose Abreu wrote: > This follows David Miller advice and tries to fix coalesce timer in > multi-queue scenarios. > > We are now using per-queue coalesce values and per-queue TX timer. > > Coalesce timer default values was changed to 1ms and the coalesce frames > to

Re: [PATCH net 00/13] cls_u32 cleanups and fixes.

2018-09-10 Thread Jamal Hadi Salim
On 2018-09-09 10:15 a.m., Al Viro wrote: [..] Umm... Interesting - TCA_U32_SEL is not the only thing that gets ignored there; TCA_U32_MARK gets the same treatment. And then there's a lovely question what to do with n->pf - it's an array of n->sel.nkeys counters, and apparently we want (at

Re: [net-next, PATCH 2/2, v1] net: socionext: add AF_XDP support

2018-09-10 Thread Ilias Apalodimas
On Mon, Sep 10, 2018 at 07:56:49PM +0900, Toshiaki Makita wrote: > On 2018/09/10 17:24, Ilias Apalodimas wrote: > > Add basic AF_XDP support without zero-copy > > > > Signed-off-by: Ilias Apalodimas > > --- > ... > > @@ -707,6 +731,26 @@ static int netsec_process_rx(struct netsec_priv *priv, >

Re: [net-next, PATCH 2/2, v1] net: socionext: add AF_XDP support

2018-09-10 Thread Toshiaki Makita
On 2018/09/10 17:24, Ilias Apalodimas wrote: > Add basic AF_XDP support without zero-copy > > Signed-off-by: Ilias Apalodimas > --- ... > @@ -707,6 +731,26 @@ static int netsec_process_rx(struct netsec_priv *priv, > int budget) > if (unlikely(!buf_addr)) >

Re: kernels > v4.12 oops/crash with ipsec-traffic: bisected to b838d5e1c5b6e57b10ec8af2268824041e3ea911: ipv4: mark DST_NOGC and remove the operation of dst_free()

2018-09-10 Thread Wolfgang Walter
Am Montag, 10. September 2018, 10:18:47 schrieb Kristian Evensen: > Hi, > > Thanks everyone for all the effort in debugging this issue. > > On Mon, Sep 10, 2018 at 8:39 AM Steffen Klassert > > wrote: > > The easy fix that could be backported to stable would be > > to check skb->dst for NULL

Re: [net-next, PATCH 0/2, v1] net: socionext: add AF_XDP support

2018-09-10 Thread Björn Töpel
Den mån 10 sep. 2018 kl 10:26 skrev Ilias Apalodimas : > > This patch series adds AF_XDP support socionext netsec driver > > - patch [1/2]: Use a different allocation scheme for Rx DMA buffers to prepare > the driver for AF_XDP support > - patch [2/2]: Add AF_XDP support without zero-copy > >

[afaerber:lora-next 14445/14606] net//smc/smc_ib.c:152:2: warning: 'ib_query_gid' is deprecated (declared at include/rdma/ib_cache.h:139)

2018-09-10 Thread kbuild test robot
tree: git://github.com/afaerber/linux lora-next head: 51325f8cd6dd80cba7ac6e881fe523ad0475c927 commit: 6a991b35a2fa0b75d99f03c564b40b6b9a5d2aed [14445/14606] Merge remote-tracking branch 'net-next/master' config: i386-randconfig-j0-09101243 (attached as .config) compiler: gcc-4.9 (Debian

[PATCH net-next v3 0/7] net: aquantia: implement WOL and EEE support

2018-09-10 Thread Igor Russkikh
This is v3 of WOL/EEE functionality patch for atlantic driver. In this patchset Yana Esina and Nikita Danilov implemented: - Upload function to interact with FW memory - Definitions and structures necessary for the correct operation of Wake ON Lan - The functionality Wake On Lan via ethtool

[PATCH net-next v3 2/7] net: aquantia: definitions for WOL

2018-09-10 Thread Igor Russkikh
From: Yana Esina Added definitions and structures needed to support WOL. Signed-off-by: Yana Esina Signed-off-by: Nikita Danilov Tested-by: Nikita Danilov Signed-off-by: Igor Russkikh --- drivers/net/ethernet/aquantia/atlantic/aq_nic.h| 3 + .../aquantia/atlantic/hw_atl/hw_atl_utils.h

  1   2   >