From: Ariel Elior
Date: Tue, 23 Oct 2018 08:35:43 +0300
> Please consider applying to net-next.
Sorry, net-next is closed.
Most of the doorbelling entities are outside of the core module.
L2 queues, Roce queues, iscsi and fcoe all need to register.
Make the APIs available for these drivers.
Signed-off-by: Ariel Elior
Signed-off-by: Michal Kalderon
Signed-off-by: Tomer Tayar
---
drivers/net/ethernet/qlogic/qed/qed_
Add the database used to register doorbelling entities, and APIs for adding
and deleting entries, and logic for traversing the database and doorbelling
once on behalf of all entities.
Signed-off-by: Ariel Elior
Signed-off-by: Michal Kalderon
Signed-off-by: Tomer Tayar
---
drivers/net/ethernet/
All L2 queues funnel through this flow, so this would cover the
regular RSS queues, as well queues created for VFs, mqos queues,
xdp queues, etc.
Signed-off-by: Ariel Elior
Signed-off-by: Michal Kalderon
Signed-off-by: Tomer Tayar
---
drivers/net/ethernet/qlogic/qede/qede_main.c | 9 +
Slow path queue is a doorbelling entity. Register it with the overflow
mechanism.
Signed-off-by: Ariel Elior
Signed-off-by: Michal Kalderon
Signed-off-by: Tomer Tayar
---
drivers/net/ethernet/qlogic/qed/qed_sp.h | 4 ++-
drivers/net/ethernet/qlogic/qed/qed_spq.c | 47 +++
Light L2 queues are doorbelling entities. Modify the implementation
to keep the doorbell data necessary for doorbelling in well known
location instead of recomputing every time. Register the LL2 queue
with doorbell recovery mechanism.
Signed-off-by: Ariel Elior
Signed-off-by: Michal Kalderon
Sig
In case of an attention from the doorbell queue block, analyze the HW
indications. In case of a doorbell overflow, execute a doorbell recovery.
Since there can be spurious indications (race conditions between multiple PFs),
schedule a periodic task for checking whether a doorbell overflow may have
Doorbell Overflow
If sufficient CPU cores will send doorbells at a sufficiently high rate, they
can cause an overflow in the doorbell queue block message fifo. When fill level
reaches maximum, the device stops accepting all doorbells from that PF until a
recovery procedure has taken place.
Doorbel
>
> > +#ifndef writeq
> > +#define writeq writeq
> > +static inline void writeq(u64 val, void __iomem *reg)
> > +{
> > + writel(val & 0x, reg);
> > + writel(val >> 32, reg + 0x4UL);
> > +}
> > +#endif
>
> Please use the appropriate generic header file to achieve this, do not
> reim
Hi Ariel,
I love your patch! Yet something to improve:
[auto build test ERROR on net-next/master]
url:
https://github.com/0day-ci/linux/commits/Ariel-Elior/qed-Doorbell-overflow-recovery/20181022-212749
config: i386-allyesconfig (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
On Mon, May 15, 2017 at 11:01:42AM +0200, Paolo Abeni wrote:
> And update __sk_queue_drop_skb() to work on the specified queue.
> This will help the udp protocol to use an additional private
> rx queue in a later patch.
>
> Signed-off-by: Paolo Abeni
> ---
> include/linux/skbuff.h | 7
> i
Please do not submit net-next changes until that tree opens back
up again after the merge window.
Thank you.
From:
Date: Mon, 22 Oct 2018 19:26:04 -0700
> This series of patches is to modify the original KSZ9477 DSA driver so
> that other KSZ switch drivers can be added and use the common code.
This doesn't apply cleanly to net-next.
And the net-next tree is now closed due to the merge window, please
From: Dave Watson
Date: Mon, 22 Oct 2018 19:36:37 +
> Add John and Daniel as additional tls co-maintainers to help review
> patches and fix syzbot reports.
>
> Acked-by: John Fastabend
> Acked-by: Daniel Borkmann
> Signed-off-by: Dave Watson
Applied.
From: sunil.kovv...@gmail.com
Date: Mon, 22 Oct 2018 23:25:47 +0530
> From: Sunil Goutham
>
> This patchset is a continuation to earlier submitted two patch
> series to add a new driver for Marvell's OcteonTX2 SOC's
> Resource virtualization unit (RVU) admin function driver.
>
> 1. octeontx2-a
From: Ariel Elior
Date: Mon, 22 Oct 2018 19:40:40 +0300
>
> +#ifndef writeq
> +#define writeq writeq
> +static inline void writeq(u64 val, void __iomem *reg)
> +{
> + writel(val & 0x, reg);
> + writel(val >> 32, reg + 0x4UL);
> +}
> +#endif
Please use the appropriate generic he
From: Eric Dumazet
Date: Mon, 22 Oct 2018 09:24:27 -0700
> syzkaller triggered a use-after-free [1], caused by a combination of
> skb_get() in llc_conn_state_process() and usage of sk_eat_skb()
>
> sk_eat_skb() is assuming the skb about to be freed is only used by
> the current thread. TCP/DCCP
From: Christian Lamparter
Date: Mon, 22 Oct 2018 13:04:12 +0200
> @@ -1452,8 +1509,49 @@ static inline u16 emac_tx_vlan(struct emac_instance
> *dev, struct sk_buff *skb)
> return 0;
> }
>
> +static netdev_tx_t
> +emac_start_xmit_sg(struct sk_buff *skb, struct net_device *ndev);
> +
> +s
From:
Date: Sun, 21 Oct 2018 18:07:14 +0300
> From: Arthur Kiyanovski
>
> linux/prefetch.h is never explicitly included in ena_com, although
> functions from it, such as prefetchw(), are used throughout ena_com.
> This is an inclusion bug, and we fix it here by explicitly including
> linux/pref
From: Or Gerlitz
Date: Sun, 21 Oct 2018 14:05:49 +0300
> From: Dan Carpenter
>
> FDB_MAX_CHAIN is three. We wanted to allocate enough memory to hold four
> structs but there are missing parentheses so we only allocate enough
> memory for three structs and the first byte of the fourth one.
>
>
From: Davide Caratti
Date: Sat, 20 Oct 2018 23:33:06 +0200
> the following command:
>
> # tc actions add action police rate 1mbit burst 1k conform-exceed \
> > pass / goto chain 42
>
> generates a NULL pointer dereference when packets exceed the configured
> rate. Similarly, the following com
From: Andrew Lunn
Date: Sat, 20 Oct 2018 22:41:28 +0200
> When indicating the MAC supports Symmetric Pause, clear the Asymmetric
> Pause bit, which could of been already set is the PHY supports it.
>
> Reported-by: Labbe Corentin
> Fixes: c306ad36184f ("net: ethernet: Add helper for MACs which
From: Dan Carpenter
Date: Fri, 19 Oct 2018 23:11:11 +0300
> These functions are supposed to return one on failure and zero on
> success. Returning a zero here could cause uninitialized variable
> bugs in several of the callers. For example:
>
> drivers/scsi/cxgbi/cxgb4i/cxgb4i.c:1660 get_i
From: David Ahern
Date: Fri, 19 Oct 2018 12:45:26 -0700
> From: David Ahern
>
> Use the recently added kernel side filter infrastructure to add support
> for dumping addresses only for a specific device.
>
> Patch 1 creates an IPv4 version similar to IPv6's in6_dump_addrs function.
>
> Patch
From: YueHaibing
Date: Fri, 19 Oct 2018 12:51:28 +
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/net/ethernet/marvell/octeontx2/af/rvu_npa.c: In function
> 'rvu_npa_init':
> drivers/net/ethernet/marvell/octeontx2/af/rvu_npa.c:446:20: warning:
> variable 'block' set but not u
From: Jon Maloy
Date: Fri, 19 Oct 2018 19:55:40 +0200
> We have seen the following race scenario:
> 1) named_distribute() builds a "bulk" message, containing a PUBLISH
>item for a certain publication. This is based on the contents of
>the binding tables's 'cluster_scope' list.
> 2) tipc_n
From: YueHaibing
Date: Fri, 19 Oct 2018 13:03:06 +
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/net/ethernet/marvell/octeontx2/af/rvu.c: In function
> 'rvu_detach_rsrcs':
> drivers/net/ethernet/marvell/octeontx2/af/rvu.c:855:6: warning:
> variable 'devnum' set but not used
From: Tristram Ha
Rename ksz_spi.c to ksz9477_spi.c and update Kconfig in preparation to add
more KSZ switch drivers.
Signed-off-by: Tristram Ha
Reviewed-by: Woojung Huh
Reviewed-by: Pavel Machek
Reviewed-by: Florian Fainelli
Reviewed-by: Andrew Lunn
---
drivers/net/dsa/microchip/Kconfig
From: Tristram Ha
Initialize mutex before use.
Signed-off-by: Tristram Ha
---
drivers/net/dsa/microchip/ksz_common.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/net/dsa/microchip/ksz_common.c
b/drivers/net/dsa/microchip/ksz_common.c
index 8c5853e..88e8d2a 10
From: Tristram Ha
Replace license with GPL.
Signed-off-by: Tristram Ha
Reviewed-by: Woojung Huh
Reviewed-by: Andrew Lunn
---
drivers/net/dsa/microchip/ksz_9477_reg.h | 23 ---
drivers/net/dsa/microchip/ksz_common.c | 23 ---
drivers/net/dsa/microchip
From: Tristram Ha
Rename ksz_9477_reg.h to ksz9477_reg.h for consistency as the product
name is always KSZ.
Signed-off-by: Tristram Ha
Reviewed-by: Woojung Huh
Reviewed-by: Andrew Lunn
---
drivers/net/dsa/microchip/ksz9477.c | 2 +-
drivers/net/dsa/microchip/{ksz_
From: Tristram Ha
Break KSZ9477 DSA driver into two files in preparation to add more KSZ
switch drivers.
Add common functions in ksz_common.h so that other KSZ switch drivers
can access code in ksz_common.c.
Add ksz_spi.h for common functions used by KSZ switch SPI drivers.
Signed-off-by: Tristr
From: Tristram Ha
Add switch offload forwarding support.
Signed-off-by: Tristram Ha
---
drivers/net/dsa/microchip/ksz9477.c | 3 +++
net/dsa/tag_ksz.c | 2 ++
2 files changed, 5 insertions(+)
diff --git a/drivers/net/dsa/microchip/ksz9477.c
b/drivers/net/dsa/microchip/ksz94
From: Tristram Ha
Rename some functions with ksz9477 prefix to separate chip specific code
from common code.
Signed-off-by: Tristram Ha
Reviewed-by: Woojung Huh
Reviewed-by: Pavel Machek
Reviewed-by: Florian Fainelli
Reviewed-by: Andrew Lunn
---
drivers/net/dsa/microchip/ksz_common.c | 116
From: Tristram Ha
This series of patches is to modify the original KSZ9477 DSA driver so
that other KSZ switch drivers can be added and use the common code.
There are several steps to accomplish this achievement. First is to
rename some function names with a prefix to indicate chip specific
fun
From: Tristram Ha
Modify tag_ksz.c so that tail tag code can be used by other KSZ switch
drivers.
Signed-off-by: Tristram Ha
Reviewed-by: Woojung Huh
---
drivers/net/dsa/microchip/Kconfig | 2 +-
drivers/net/dsa/microchip/ksz9477.c | 2 +-
include/net/dsa.h | 2 +-
net/
On 10/22/2018 07:12 PM, Jeff Barnhill wrote:
> icmp6_send() function is expensive on systems with a large number of
> interfaces. Every time it’s called, it has to verify that the source
> address does not correspond to an existing anycast address by looping
> through every device and every anyc
From: Tristram Ha
Add MIB counter reading support.
Signed-off-by: Tristram Ha
Reviewed-by: Woojung Huh
---
drivers/net/dsa/microchip/ksz9477.c| 121 ++---
drivers/net/dsa/microchip/ksz_common.c | 101 +++
drivers/net/dsa/microchip/ksz_co
From: Tristram Ha
Prepare PHY for proper advertisement and get link status for the port.
Signed-off-by: Tristram Ha
Reviewed-by: Woojung Huh
---
drivers/net/dsa/microchip/ksz9477.c| 13 +
drivers/net/dsa/microchip/ksz_common.c | 17 +
drivers/net/dsa/microchip/
icmp6_send() function is expensive on systems with a large number of
interfaces. Every time it’s called, it has to verify that the source
address does not correspond to an existing anycast address by looping
through every device and every anycast address on the device. This can
result in significa
On Fri, Oct 19, 2018 at 04:52:13PM +, Keller, Jacob E wrote:
> Nice! I think this is good. I'd love to see some data to back it up, but it
> makes sense to me.
+1
On Fri, Oct 19, 2018 at 11:51:37AM +0200, Miroslav Lichvar wrote:
> A solution to this would be a new driver function that wraps the
> latching register read with readings of the system clock and return
> three timestamps instead of one. For example:
>
> ktime_get_real_ts64(&sys_ts1);
>
Hi Netanel,
FYI, the error/warning still remains.
tree: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git
master
head: 21ea1d36f6dfcb1d59184937c672022d5d01902a
commit: 8c590f9776386b8f697fd0b7ed6142ae6e3de79e [451/481] net: ena: Fix
Kconfig dependency on X86
config: microbl
Hi Cong,
>
> 1. Create veth pair devices by its own. The most important thing for
> tc-tests is to automate everything, it is not friendly for users to
> create their own veth pair named v0p0 to just run the tests. tc-tests
> should be able to create a veth pair with random names and clean up
> th
Sat, Oct 20, 2018 at 11:33:08PM CEST, dcara...@redhat.com wrote:
>in the following command:
>
> # tc action add action police rate burst conform-exceed /
>
>'goto chain x' is allowed only for c1: setting it for c2 makes the kernel
>crash with NULL pointer dereference, since TC core doesn't initia
Sat, Oct 20, 2018 at 11:33:07PM CEST, dcara...@redhat.com wrote:
>in the following command:
>
> # tc action add action random
>
>'goto chain x' is allowed only for c1: setting it for c2 makes the kernel
>crash with NULL pointer dereference, since TC core doesn't initialize the
>chain handle.
>
> -Original Message-
> From: Intel-wired-lan [mailto:intel-wired-lan-boun...@osuosl.org] On
> Behalf Of Shannon Nelson
> Sent: Thursday, October 4, 2018 4:29 PM
> To: intel-wired-...@lists.osuosl.org; Kirsher, Jeffrey T
>
> Cc: netdev@vger.kernel.org
> Subject: [Intel-wired-lan] [PATCH] ix
Add John and Daniel as additional tls co-maintainers to help review
patches and fix syzbot reports.
Acked-by: John Fastabend
Acked-by: Daniel Borkmann
Signed-off-by: Dave Watson
---
MAINTAINERS | 2 ++
1 file changed, 2 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 7f1399ac028e..
On 2018-10-19 08:25, Paolo Abeni wrote:
In some scenarios, the GRO engine can assemble an UDP GRO packet
that ultimately lands on a non GRO-enabled socket.
This patch tries to address the issue explicitly checking for the UDP
socket features before enqueuing the packet, and eventually segmenting
On 2018-10-20 5:33 p.m., Davide Caratti wrote:
the following command:
# tc actions add action police rate 1mbit burst 1k conform-exceed \
> pass / goto chain 42
generates a NULL pointer dereference when packets exceed the configured
rate. Similarly, the following command:
# tc actions ad
From: Stanislaw Kardach
Add LMAC channel info like Rx/Tx channel base and count to
NIXLF_ALLOC mailbox message response. This info is used by
NIXLF attached RVU PF/VF to configure SQ's default channel,
TL3_TL2_LINKX_CFG and to install MCAM rules in NPC based
on matching ingress channel number.
S
From: Sunil Goutham
Upon NIXLF_ALLOC install a unicast forwarding rule in NPC MCAM
like below
- Match pkt DMAC with NIXLF attached PF/VF's MAC address.
- Ingress channel
- Action is UCAST
- Forward to PF_FUNC of this NIXLF
And broadcast pkt forwarding rule as
- Match L2B bit in MCAM search k
From: Sunil Goutham
This patch adds some minimal configuration for NPC MCAM and
LDATA extraction which is sufficient enough to install
ucast/bcast/promiscuous forwarding rules. Below is the
config done
- LDATA extraction config to extract DMAC from pkt
to offset 64bit in MCAM search key.
- Set
On Thu, 2018-10-18 at 23:53 +0200, Toke Høiland-Jørgensen wrote:
> Saeed Mahameed writes:
>
> > I think that the mlx5 driver doesn't know how to tell the other
> > device
> > to stop transmitting to it while it is resetting.. Maybe tariq or
> > Jesper know more about this ?
> > I will look at thi
From: Sunil Goutham
Configure NIX RX flowkey algorithm configuration to support
RSS (receive side scaling). Currently support for only L3/L4
2-tuple and 4-tuple hash of IPv4/v6/TCP/UDP/SCTP is added.
HW supports upto 32 different flowkey algorithms which SW
can define, this patch defines 9. NPC R
From: Sunil Goutham
This patch adds support for a RVU PF/VF to change
NIX Rx flowkey algorithm index in NPC RX RSS_ACTION.
eg: a ethtool command changing RSS algorithm for a netdev
interface would trigger this change in NPC.
If PF/VF doesn't specify any MCAM entry index then default
UCAST entry
From: Sunil Goutham
Added a new mailbox message for a PF/VF to set/update
it's NIXLF's MAC address. Also updates unicast NPC
MCAM entry with this address as matching DMAC.
Signed-off-by: Sunil Goutham
---
drivers/net/ethernet/marvell/octeontx2/af/mbox.h | 8 ++-
drivers/net/ethernet/mar
From: Sunil Goutham
By default NIXLF is set in UCAST mode. This patch adds a new
mailbox message which when sent by a RVU PF changes this default
mode. When promiscuous mode is needed, the reserved promisc entry
for each of RVU PF is setup to match against ingress channel number
only, so that all
From: Sunil Goutham
This patch adds support for a PF/VF driver to configure
NIX transmit scheduler queues via mbox. Since PF/VF doesn't
know the absolute HW index of the NIXLF attached to it, AF
traps the register config and overwrites with the correct
NIXLF index.
HW supports shaping, colouring
From: Sunil Goutham
Added support for a PF/VF to allocate or free NIX transmit
scheduler queues via mbox. For setting up pkt transmission
priorities between queues, the scheduler queues have to be
contiguous w.r.t their HW indices. So both contiguous and
non-contiguous allocations are supported.
From: Sunil Goutham
This patch configures all 16 KPUs and iKPU (pkinds) with
the KPU parser profile defined in npc_profile.h. Each KPU
engine has a 128 entry CAM, only CAM entries which are listed
in the profile are enabled and rest are left disabled.
Also
- Memory is allocated for pkind's bitma
From: Sunil Goutham
Upon NIXLF ALLOC/FREE, add or remove corresponding PF_FUNC from
the broadcast packet replication list of the CGX LMAC mapped
RVU PF.
Signed-off-by: Sunil Goutham
---
.../net/ethernet/marvell/octeontx2/af/rvu_nix.c| 133 +
1 file changed, 133 insertio
From: Vamsi Attunuru
Added support for PF/VF drivers to configure NIX to
capture and/or strip VLAN tag from ingress packets.
Signed-off-by: Vamsi Attunuru
Signed-off-by: Sunil Goutham
---
drivers/net/ethernet/marvell/octeontx2/af/mbox.h | 35 -
drivers/net/ethernet/marvell/octeo
From: Sunil Goutham
Allocate memory for mcast/bcast/mirror replication entry
contexts, replication buffers (used by HW) and config HW
with corresponding memory bases. Added support for installing
MCEs via NIX AQ mbox.
For now support is restricted to broadcast pkt replication,
hence MCE table si
From: Hao Zheng
NPC block is responsible for parsing and forwarding
packets to different NIXLFs. NPC has 16 KPU engines
(Kangaroo parse engine) and one iKPU which represents
pkinds. Each physical port either CGX/LBK is assigned
a pkind and upon receiving a packet HW takes that port's
pkind and st
From: Vamsi Attunuru
This patch adds a new mailbox message to reset
a NIXLF's receive and transmit HW stats.
Signed-off-by: Vamsi Attunuru
Signed-off-by: Sunil Goutham
---
drivers/net/ethernet/marvell/octeontx2/af/mbox.h | 3 ++-
drivers/net/ethernet/marvell/octeontx2/af/rvu.h| 2 ++
From: Geetha sowjanya
For each CGX LMAC that is mapped to a RVU PF, allocate
a pkind and config the same in CGX. For a received packet
at CGX LMAC interface this pkind is used by NPC block
to start parsing of packet.
Signed-off-by: Geetha sowjanya
Signed-off-by: Sunil Goutham
---
drivers/net/
From: Sunil Goutham
Config NPC layer info from KPU profile into protocol
checker to identify outer L2/IPv4/TCP/UDP headers in a
packet. And enable IPv4 checksum validation.
L3/L4 and L4 CSUM validation will be enabled by PF/VF
drivers by configuring NIX_AF_LF(0..127)_RX_CFG via mbox
i.e 'nix_lf_
From: Sunil Goutham
This patchset is a continuation to earlier submitted two patch
series to add a new driver for Marvell's OcteonTX2 SOC's
Resource virtualization unit (RVU) admin function driver.
1. octeontx2-af: Add RVU Admin Function driver
https://www.spinics.net/lists/netdev/msg528272.
On Mon, Oct 22, 2018 at 09:56:23AM -0700, Stephen Hemminger wrote:
> On Fri, 19 Oct 2018 17:42:55 +0200
> Phil Sutter wrote:
>
> > Value of 'default' is assumed to be hexadecimal when parsing, so
> > consequently it should be printed in hex as well. This is a regression
> > introduced when adding
On 10/22/18 8:48 AM, Russell King - ARM Linux wrote:
> On Mon, Oct 22, 2018 at 01:47:48PM +0100, Jose Abreu wrote:
>> Hello,
>>
>> On 22-10-2018 13:28, Andrew Lunn wrote:
EXPORT_SYMBOL_GPL(gen10g_resume);
@@ -327,7 +381,7 @@ struct phy_driver genphy_10g_driver = {
.phy_id
On 10/22/18 3:32 AM, Jose Abreu wrote:
> If PHY is in force state and we have a C45 phy we need to use the
> standard C45 helpers and not the C22 ones.
>
> Signed-off-by: Jose Abreu
> Cc: Andrew Lunn
> Cc: Florian Fainelli
> Cc: "David S. Miller"
> Cc: Joao Pinto
> ---
> drivers/net/phy/phy.
On Mon, 22 Oct 2018 19:03:41 +0200
Petr Vorel wrote:
> Hi Stephen,
>
> > Applied, it seem to have gotten lost somewhere between my laptop and the
> > repo.
> Thanks a lot for merging :).
>
> There is a patchset "Minor shell code cleanup", which has state Accepted, but
> not in git
> https://
On Mon, 22 Oct 2018 11:00:27 +0100
Quentin Monnet wrote:
> 2018-10-21 23:04 UTC+0200 ~ Jesper Dangaard Brouer
> > On Sun, 21 Oct 2018 16:37:08 +0100
> > Quentin Monnet wrote:
> >
> >> 2018-10-21 11:57 UTC+0200 ~ Jesper Dangaard Brouer
> >>> On Sat, 20 Oct 2018 23:00:24 +0100
> >>> Quentin
On Thu, 18 Oct 2018 15:48:48 +0200
Phil Sutter wrote:
> All these assignments are later overwritten without reading in between,
> so just drop them.
>
> Fixes: 485d0c6001c4a ("tc: Add batchsize feature for filter and actions")
> Signed-off-by: Phil Sutter
Applied
On Thu, 18 Oct 2018 15:48:09 +0200
Phil Sutter wrote:
> Although initialized by call to libmnl, the variable is used only in a
> call to sizeof(). Drop it and call sizeof with its type instead.
>
> Fixes: f043759dd4928 ("tipc: add new TIPC configuration tool")
> Signed-off-by: Phil Sutter
Appl
On Thu, 18 Oct 2018 15:44:14 +0200
Phil Sutter wrote:
> In case caller did not specify 'segs' parameter, parse_srh() would read
> garbage while iterating over 'segbuf'. Avoid this by initializing
> 'segbuf' to an empty string.
>
> Fixes: e8493916a8ede ("iproute: add support for SR-IPv6 lwtunnel
On 10/21/18 9:22 PM, Pankaj Bansal wrote:
>
>> -Original Message-
>> From: Pankaj Bansal
>> Sent: Thursday, October 18, 2018 10:00 AM
>> To: Florian Fainelli ; Andrew Lunn
>> Cc: netdev@vger.kernel.org
>> Subject: RE: [PATCH v2 1/2] dt-bindings: net: add MDIO bus multiplexer
>> driven by
On Thu, 18 Oct 2018 14:35:50 +0200
Phil Sutter wrote:
> Variables 'src_port' and 'dst_port' are initialized only if attributes
> RDMA_NLDEV_ATTR_RES_SRC_ADDR or RDMA_NLDEV_ATTR_RES_DST_ADDR are
> present. Make sure to pass them over to rd_check_is_filtered() only if
> that is the case.
>
> Fixes
On 10/21/18 1:00 PM, Wolfram Sang wrote:
> I got tired of fixing this in Renesas drivers manually, so I took the big
> hammer. Remove this cumbersome code pattern which got copy-pasted too much
> already:
>
> - struct platform_device *pdev = to_platform_device(dev);
> - struct ep93xx_keypa
On Thu, 18 Oct 2018 13:41:54 +0200
Phil Sutter wrote:
> With 'name' field defined as array in struct filters, it will always
> contain a value irrespective of whether a name was assigned or not.
>
> Fix this by turning the field into a const char pointer.
>
> Fixes: 8cd644095842a ("devlink: Add
On Thu, 18 Oct 2018 14:30:31 +0200
Phil Sutter wrote:
> If call to rta_addattr_l() failed, parse_encap_seg6() would leak memory.
> Fix this by making sure calls to free() are not skipped.
>
> Fixes: bd59e5b1517b0 ("ip-route: Fix segfault with many nexthops")
> Signed-off-by: Phil Sutter
Applie
Hi Stephen,
> Applied, it seem to have gotten lost somewhere between my laptop and the repo.
Thanks a lot for merging :).
There is a patchset "Minor shell code cleanup", which has state Accepted, but
not in git
https://patchwork.ozlabs.org/project/netdev/list/?series=67063&state=*
Did they got lo
On Sat, 20 Oct 2018 15:42:33 +0200
Tobias Jungel wrote:
> The output of -statistics vlan show was broken previous change for json
> output. This aligns the format to vlan show.
>
> Signed-off-by: Tobias Jungel
This patch causes new warning:
CC vlan.o
vlan.c: In function ‘print_vlan_s
On Fri, 19 Oct 2018 17:42:55 +0200
Phil Sutter wrote:
> Value of 'default' is assumed to be hexadecimal when parsing, so
> consequently it should be printed in hex as well. This is a regression
> introduced when adding JSON output.
>
> Fixes: f354fa6aa5ff0 ("tc: jsonify htb qdisc")
> Signed-off-
On Tue, 25 Sep 2018 14:49:56 +0200
Petr Vorel wrote:
> make check from top level Makefile defines several flags which break
> building generate_nlmsg:
>
> $ make check
> make -C tools
> gcc -Wall -Wstrict-prototypes -Wmissing-prototypes -Wmissing-declarations
> -Wold-style-definition -Wformat
On Sat, 20 Oct 2018 15:42:33 +0200
Tobias Jungel wrote:
> The output of -statistics vlan show was broken previous change for json
> output. This aligns the format to vlan show.
>
> Signed-off-by: Tobias Jungel
Applied, thanks
Doorbell Overflow
If sufficient CPU cores will send doorbells at a sufficiently high rate, they
can cause an overflow in the doorbell queue block message fifo. When fill level
reaches maximum, the device stops accepting all doorbells from that PF until a
recovery procedure has taken place.
Doorbel
Most of the doorbelling entities are outside of the core module.
L2 queues, Roce queues, iscsi and fcoe all need to register.
Make the APIs available for these drivers.
Signed-off-by: Ariel Elior
Signed-off-by: Michal Kalderon
Signed-off-by: Tomer Tayar
---
drivers/net/ethernet/qlogic/qed/qed_
Slow path queue is a doorbelling entity. Register it with the overflow
mechanism.
Signed-off-by: Ariel Elior
Signed-off-by: Michal Kalderon
Signed-off-by: Tomer Tayar
---
drivers/net/ethernet/qlogic/qed/qed_sp.h | 4 ++-
drivers/net/ethernet/qlogic/qed/qed_spq.c | 47 +++
Light L2 queues are doorbelling entities. Modify the implementation
to keep the doorbell data necessary for doorbelling in well known
location instead of recomputing every time. Register the LL2 queue
with doorbell recovery mechanism.
Signed-off-by: Ariel Elior
Signed-off-by: Michal Kalderon
Sig
Add the database used to register doorbelling entities, and APIs for adding
and deleting entries, and logic for traversing the database and doorbelling
once on behalf of all entities.
Signed-off-by: Ariel Elior
Signed-off-by: Michal Kalderon
Signed-off-by: Tomer Tayar
---
drivers/net/ethernet/
In case of an attention from the doorbell queue block, analyze the HW
indications. In case of a doorbell overflow, execute a doorbell recovery.
Since there can be spurious indications (race conditions between multiple PFs),
schedule a periodic task for checking whether a doorbell overflow may have
All L2 queues funnel through this flow, so this would cover the
regular RSS queues, as well queues created for VFs, mqos queues,
xdp queues, etc.
Signed-off-by: Ariel Elior
Signed-off-by: Michal Kalderon
Signed-off-by: Tomer Tayar
---
drivers/net/ethernet/qlogic/qede/qede_main.c | 9 +
On Fri, 19 Oct 2018 13:44:18 -0700
David Ahern wrote:
> From: David Ahern
>
> No command, filter, or print function uses the sockaddr_nl arg,
> so just drop it.
>
> Signed-off-by: David Ahern
Acked-by: Stephen Hemminger
syzkaller triggered a use-after-free [1], caused by a combination of
skb_get() in llc_conn_state_process() and usage of sk_eat_skb()
sk_eat_skb() is assuming the skb about to be freed is only used by
the current thread. TCP/DCCP stacks enforce this because current
thread holds the socket lock.
ll
On Sat, Oct 20, 2018 at 2:33 PM Davide Caratti wrote:
>
> in the following command:
>
> # tc action add action police rate burst conform-exceed /
>
> 'goto chain x' is allowed only for c1: setting it for c2 makes the kernel
> crash with NULL pointer dereference, since TC core doesn't initialize
On Sat, Oct 20, 2018 at 2:33 PM Davide Caratti wrote:
>
> in the following command:
>
> # tc action add action random
>
> 'goto chain x' is allowed only for c1: setting it for c2 makes the kernel
> crash with NULL pointer dereference, since TC core doesn't initialize the
> chain handle.
>
> S
Hi Sunil,
I love your patch! Yet something to improve:
[auto build test ERROR on net-next/master]
[also build test ERROR on next-20181019]
[cannot apply to v4.19]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-
On Fri, Oct 19, 2018 at 10:30 AM Paolo Abeni wrote:
>
> The *encap_needed static keys are enabled by UDP tunnels
> and several UDP encapsulations type, but they are never
> turned off. This can cause unneeded overall performance
> degradation for systems where such features are used
> transiently.
1 - 100 of 146 matches
Mail list logo
