Re: [RFC PATCH 0/3] acpi: Add acpi mdio support code

2018-11-12 Thread Wang, Dongsheng
Hello Rafael, On 2018/11/13 1:19, Andrew Lunn wrote: >>> I'm just trying to ensure whatever is defined is flexible enough that >>> we really can later support everything which DT does. We have PHYs on >>> MDIO busses, inside switches, which are on MDIO busses, which are >>> inside Ethernet

Re: [PATCH net-next 0/4] sctp: add subscribe per asoc and sockopt SCTP_EVENT

2018-11-12 Thread Xin Long
On Tue, Nov 13, 2018 at 1:26 AM Xin Long wrote: > > This patchset mainly adds the Event Subscription sockopt described in > rfc6525#section-6.2: > > Subscribing to events as described in [RFC6458] uses a setsockopt() > call with the SCTP_EVENT socket option. This option takes the > following

[PATCHv2 net-next 2/4] sctp: add subscribe per asoc

2018-11-12 Thread Xin Long
The member subscribe should be per asoc, so that sockopt SCTP_EVENT in the next patch can subscribe a event from one asoc only. Signed-off-by: Xin Long --- include/net/sctp/structs.h | 2 ++ net/sctp/associola.c | 2 ++ net/sctp/chunk.c | 6 ++ net/sctp/socket.c

[PATCHv2 net-next 4/4] sctp: add sockopt SCTP_EVENT

2018-11-12 Thread Xin Long
This patch adds sockopt SCTP_EVENT described in rfc6525#section-6.2. With this sockopt users can subscribe to an event from a specified asoc. Signed-off-by: Xin Long --- include/uapi/linux/sctp.h | 7 net/sctp/socket.c | 89 +++ 2 files

[PATCHv2 net-next 1/4] sctp: define subscribe in sctp_sock as __u16

2018-11-12 Thread Xin Long
The member subscribe in sctp_sock is used to indicate to which of the events it is subscribed, more like a group of flags. So it's better to be defined as __u16 (2 bytpes), instead of struct sctp_event_subscribe (13 bytes). Note that sctp_event_subscribe is an UAPI struct, used on sockopt calls,

[PATCHv2 net-next 3/4] sctp: rename enum sctp_event to sctp_event_type

2018-11-12 Thread Xin Long
sctp_event is a structure name defined in RFC for sockopt SCTP_EVENT. To avoid the conflict, rename it. Signed-off-by: Xin Long --- include/net/sctp/constants.h | 2 +- include/net/sctp/sm.h| 4 ++-- net/sctp/primitive.c | 2 +- net/sctp/sm_sideeffect.c | 12 ++--

[PATCHv2 net-next 0/4] sctp: add subscribe per asoc and sockopt SCTP_EVENT

2018-11-12 Thread Xin Long
This patchset mainly adds the Event Subscription sockopt described in rfc6525#section-6.2: "Subscribing to events as described in [RFC6458] uses a setsockopt() call with the SCTP_EVENT socket option. This option takes the following structure, which specifies the association, the event type

Re: [PATCH net-next 2/2] r8169: use proper constant for PCI vendor USR instead of numerical id

2018-11-12 Thread kbuild test robot
Hi Heiner, Thank you for the patch! Yet something to improve: [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Heiner-Kallweit/r8169-add-USR-PCI-vendor-id/2018-13 config: x86_64-allmodconfig (attached as .config) compiler: gcc-7 (Debian

Re: [PATCH bpf-next v2] bpftool: make libbfd optional

2018-11-12 Thread Quentin Monnet
2018-11-12 14:02 UTC-0800 ~ Jakub Kicinski > On Mon, 12 Nov 2018 13:44:10 -0800, Stanislav Fomichev wrote: >> Make it possible to build bpftool without libbfd. libbfd and libopcodes are >> typically provided in dev/dbg packages (binutils-dev in debian) which we >> usually don't have installed on

[Patch net-next] net: remove unused skb_send_sock()

2018-11-12 Thread Cong Wang
Signed-off-by: Cong Wang --- include/linux/skbuff.h | 1 - net/core/skbuff.c | 13 - 2 files changed, 14 deletions(-) diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h index 7dcfb5591dc3..9f5bd97a26bd 100644 --- a/include/linux/skbuff.h +++ b/include/linux/skbuff.h

Re: [PATCH v2] net: Add trace events for all receive exit points

2018-11-12 Thread Steven Rostedt
On Mon, 12 Nov 2018 15:46:53 -0500 (EST) Mathieu Desnoyers wrote: > I also notice that in two cases, a "gro_result_t" is implicitly cast > to "int". I usually frown upon this kind of stuff, because it's asking > for trouble if gro_result_t typedef to something else than "int" in the > future. >

[PATCH][net-next] net: slightly optimize eth_type_trans

2018-11-12 Thread Li RongQing
netperf udp stream shows that eth_type_trans takes certain cpu, so adjust the mac address check order, and firstly check if it is device address, and only check if it is multicast address only if not the device address. After this change: To unicast, and skb dst mac is device mac, this is most of

[PATCH][net-next][v2] net: remove BUG_ON from __pskb_pull_tail

2018-11-12 Thread Li RongQing
if list is NULL pointer, and the following access of list will trigger panic, which is same as BUG_ON Signed-off-by: Li RongQing --- net/core/skbuff.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/net/core/skbuff.c b/net/core/skbuff.c index 396fcb3baad0..d69503d66021 100644 ---

Re: [iproute PATCH] man: ip-route.8: Document nexthop limit

2018-11-12 Thread David Ahern
On 11/12/18 2:21 PM, Phil Sutter wrote: > diff --git a/man/man8/ip-route.8.in b/man/man8/ip-route.8.in > index a33ce1f0f4006..383178c11331e 100644 > --- a/man/man8/ip-route.8.in > +++ b/man/man8/ip-route.8.in > @@ -589,6 +589,13 @@ argument lists: > route reflecting its relative bandwidth or

[Patch net-next] net: get rid of __tcp_checksum_complete()

2018-11-12 Thread Cong Wang
__tcp_checksum_complete() is 100% same with __skb_checksum_complete() and there is no other caller except tcp_checksum_complete(). So, just use __skb_checksum_complete() there. Signed-off-by: Cong Wang --- include/net/tcp.h | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git

[PATCH net] net_sched: sch_fq: ensure maxrate fq parameter applies to EDT flows

2018-11-12 Thread Eric Dumazet
When EDT conversion happened, fq lost the ability to enfore a maxrate for all flows. It kept it for non EDT flows. This commit restores the functionality. Tested: tc qd replace dev eth0 root fq maxrate 500Mbit netperf -P0 -H host -- -O THROUGHPUT 489.75 Fixes: ab408b6dc744 ("tcp: switch tcp

[net-next PATCH v4] net: sched: cls_flower: Classify packets using port ranges

2018-11-12 Thread Amritha Nambiar
Added support in tc flower for filtering based on port ranges. Example: 1. Match on a port range: - $ tc filter add dev enp4s0 protocol ip parent :\ prio 1 flower ip_proto tcp dst_port range 20-30 skip_hw\ action drop $ tc -s filter show dev enp4s0 parent :

Re: [net-next PATCH v3] net: sched: cls_flower: Classify packets using port ranges

2018-11-12 Thread Nambiar, Amritha
On 11/9/2018 11:14 PM, Jiri Pirko wrote: > Sat, Nov 10, 2018 at 01:11:10AM CET, amritha.namb...@intel.com wrote: > > [...] > >> @@ -1026,8 +1122,7 @@ static void fl_init_dissector(struct flow_dissector >> *dissector, >> FLOW_DISSECTOR_KEY_IPV4_ADDRS, ipv4); >>

Re: [PATCH bpf-next] selftests/bpf: Fix uninitialized duration warning

2018-11-12 Thread Martin Lau
On Fri, Nov 09, 2018 at 10:18:16AM -0800, Joe Stringer wrote: > Daniel Borkmann reports: > > test_progs.c: In function ‘main’: > test_progs.c:81:3: warning: ‘duration’ may be used uninitialized in this > function [-Wmaybe-uninitialized] >printf("%s:PASS:%s %d nsec\n", __func__, tag,

[PATCH bpf-next] bpf: libbpf: Fix bpf_program__next() API

2018-11-12 Thread Martin KaFai Lau
This patch restores the behavior in commit eac7d84519a3 ("tools: libbpf: don't return '.text' as a program for multi-function programs") such that bpf_program__next() does not return pseudo programs in ".text". Fixes: 0c19a9fbc9cd ("libbpf: cleanup after partial failure in bpf_object__pin")

Re: [PATCH v5 bpf-next 2/7] libbpf: cleanup after partial failure in bpf_object__pin

2018-11-12 Thread Martin Lau
On Mon, Nov 12, 2018 at 03:29:25PM -0800, Stanislav Fomichev wrote: > On 11/12, Martin Lau wrote: > > On Mon, Nov 12, 2018 at 02:10:11PM -0800, Stanislav Fomichev wrote: > > > On 11/12, Martin Lau wrote: > > > > On Fri, Nov 09, 2018 at 08:21:41AM -0800, Stanislav Fomichev wrote: > > > > [ ... ] >

Re: [PATCH v5 bpf-next 2/7] libbpf: cleanup after partial failure in bpf_object__pin

2018-11-12 Thread Stanislav Fomichev
On 11/12, Martin Lau wrote: > On Mon, Nov 12, 2018 at 02:10:11PM -0800, Stanislav Fomichev wrote: > > On 11/12, Martin Lau wrote: > > > On Fri, Nov 09, 2018 at 08:21:41AM -0800, Stanislav Fomichev wrote: > > > [ ... ] > > > > @@ -1918,23 +2160,20 @@ void *bpf_object__priv(struct bpf_object *obj) >

Re: [PATCH v5 bpf-next 2/7] libbpf: cleanup after partial failure in bpf_object__pin

2018-11-12 Thread Martin Lau
On Mon, Nov 12, 2018 at 02:10:11PM -0800, Stanislav Fomichev wrote: > On 11/12, Martin Lau wrote: > > On Fri, Nov 09, 2018 at 08:21:41AM -0800, Stanislav Fomichev wrote: > > [ ... ] > > > @@ -1918,23 +2160,20 @@ void *bpf_object__priv(struct bpf_object *obj) > > > } > > > > > > static struct

Hello, this is the second times am sending you this mail and you refused to reply to my email why?

2018-11-12 Thread KATIE HIGGINS

[PATCH net-next 01/13] nfp: abm: rename qdiscs -> red_qdiscs

2018-11-12 Thread Jakub Kicinski
Rename qdiscs member to red_qdiscs. One of following patches will use the name qdiscs for tracking all qdisc types. Signed-off-by: Jakub Kicinski Reviewed-by: John Hurley --- drivers/net/ethernet/netronome/nfp/abm/main.c | 11 +++--- drivers/net/ethernet/netronome/nfp/abm/main.h | 4 +-

[PATCH net-next 05/13] nfp: abm: remember which Qdisc is root

2018-11-12 Thread Jakub Kicinski
Keep track of which Qdisc is currently root. We need to implement TC_SETUP_ROOT_QDISC handling, and for completeness also clear the root Qdisc pointer when it's freed. TC_SETUP_ROOT_QDISC isn't always sent when device is dismantled. Remembering the root Qdisc will allow us to build the entire

[PATCH net-next 10/13] net: sched: red: notify drivers about RED's limit parameter

2018-11-12 Thread Jakub Kicinski
RED qdisc's limit parameter changes the behaviour of the qdisc, for instance if it's set to 0 qdisc will drop all the packets. When replace operation happens and parameter is set to non-0 a new fifo qdisc will be instantiated and replace the old child qdisc which will be destroyed. Drivers need

[PATCH net-next 07/13] net: sched: red: offload a graft notification

2018-11-12 Thread Jakub Kicinski
Drivers offloading Qdiscs should have reasonable certainty the offloaded behaviour matches the SW path. This is impossible if the driver does not know about all Qdiscs or when Qdiscs move and are reused. Send a graft notification from RED. The drivers are expected to simply stop offloading the

[PATCH net-next 03/13] nfp: abm: track all offload-enabled qdiscs

2018-11-12 Thread Jakub Kicinski
Allocate an object corresponding to any offloaded qdisc we are informed about by the kernel. Not only the qdiscs we have a chance of offloading. The count of created objects will be used to decide whether the ethtool TC offload can be disabled, since otherwise we may miss destroy commands.

[PATCH net-next 04/13] net: sched: provide notification for graft on root

2018-11-12 Thread Jakub Kicinski
Drivers are currently not notified when a Qdisc is grafted as root. This requires special casing Qdiscs added with parent = TC_H_ROOT in the driver. Also there is no notification sent to the driver when an existing Qdisc is grafted as root. Add this very simple notifications, drivers should now

[PATCH net-next 06/13] nfp: abm: allocate Qdisc child table

2018-11-12 Thread Jakub Kicinski
To keep track of Qdisc hierarchy allocate a table for children for each Qdisc. RED Qdisc can only have one child. Signed-off-by: Jakub Kicinski Reviewed-by: John Hurley --- drivers/net/ethernet/netronome/nfp/abm/main.h | 6 + .../net/ethernet/netronome/nfp/abm/qdisc.c| 25

[PATCH net-next 12/13] nfp: abm: save RED's parameters

2018-11-12 Thread Jakub Kicinski
Use the new driver Qdisc structure to keep track of parameters of RED Qdiscs. This way as the Qdisc moves around in the hierarchy we will be able to configure the HW appropriately. Signed-off-by: Jakub Kicinski Reviewed-by: John Hurley --- drivers/net/ethernet/netronome/nfp/abm/main.h | 14

[PATCH net-next 00/13] nfp: abm: track all Qdiscs

2018-11-12 Thread Jakub Kicinski
Hi! Our Qdisc offload so far has been very simplistic. We held and array of marking thresholds and statistics sized to the number of PF queues. This was sufficient since the only configuration we supported was single layer of RED Qdiscs (on top of MQ or not, but MQ isn't really about queuing).

[PATCH net-next 02/13] nfp: abm: keep track of all RED thresholds

2018-11-12 Thread Jakub Kicinski
Instead of writing the threshold out when Qdisc is configured and not remembering it move to a scheme where we remember all thresholds. When configuration changes parse the offloaded Qdiscs and set thresholds appropriately. This will help future extensions. Signed-off-by: Jakub Kicinski

[PATCH net-next 13/13] nfp: abm: restructure Qdisc handling

2018-11-12 Thread Jakub Kicinski
In preparation of handling more Qdisc types switch to a different offload strategy. We have now recreated the Qdisc hierarchy in the driver. Every time the hierarchy changes parse it, and update the configuration of the HW accordingly. While at it drop the support of pretending that we can

[PATCH net-next 11/13] nfp: abm: reset RED's child based on limit

2018-11-12 Thread Jakub Kicinski
RED qdisc will replace its child Qdisc with a new FIFO queue if it is reconfigured and the limit parameter is not 0. This means that when it's created with limit of 0 it will have no FIFO, and all packets will be dropped. If it's changed and limit is specified it will loose its existing child

[PATCH net-next 08/13] net: sched: mq: offload a graft notification

2018-11-12 Thread Jakub Kicinski
Drivers offloading Qdiscs should have reasonable certainty the offloaded behaviour matches the SW path. This is impossible if the driver does not know about all Qdiscs or when Qdiscs move and are reused. Send a graft notification from MQ. Signed-off-by: Jakub Kicinski Reviewed-by: John Hurley

[PATCH net-next 09/13] nfp: abm: build full Qdisc hierarchy based on graft notifications

2018-11-12 Thread Jakub Kicinski
Using graft notifications recreate in the driver the full Qdisc hierarchy. Keep track of how many times each Qdisc is attached to the hierarchy to make sure we don't offload Qdiscs which are attached multiple times (device queues can't be shared). For graft events of Qdiscs we don't know exist

[Patch net-next v2] net: dump more useful information in netdev_rx_csum_fault()

2018-11-12 Thread Cong Wang
Currently netdev_rx_csum_fault() only shows a device name, we need more information about the skb for debugging csum failures. Sample output: ens3: hw csum failure dev features: 0x00014b89 skb len=84 data_len=0 pkt_type=0 gso_size=0 gso_type=0 nr_frags=0 ip_summed=0 csum=0

Re: [Patch net-next] net: dump more useful information in netdev_rx_csum_fault()

2018-11-12 Thread Cong Wang
On Fri, Nov 9, 2018 at 8:16 PM David Miller wrote: > > Didn't you move this function into net/core/skbuff.c? :-) At the time when I created this patch, that patch didn't hit net-next yet. :) > > Please respin. Sure. I will send v2, as I need to cleanup the mixed commas and spaces too. Thanks.

[iproute PATCH] man: ip-route.8: Document nexthop limit

2018-11-12 Thread Phil Sutter
Add a note to 'nexthop' description stating the maximum number of nexthops per command and pointing at 'append' command as a workaround. Signed-off-by: Phil Sutter --- man/man8/ip-route.8.in | 7 +++ 1 file changed, 7 insertions(+) diff --git a/man/man8/ip-route.8.in

Re: [PATCH v5 bpf-next 2/7] libbpf: cleanup after partial failure in bpf_object__pin

2018-11-12 Thread Stanislav Fomichev
On 11/12, Martin Lau wrote: > On Fri, Nov 09, 2018 at 08:21:41AM -0800, Stanislav Fomichev wrote: > [ ... ] > > @@ -1918,23 +2160,20 @@ void *bpf_object__priv(struct bpf_object *obj) > > } > > > > static struct bpf_program * > > -__bpf_program__next(struct bpf_program *prev, struct bpf_object

Re: [PATCH bpf-next v2] bpftool: make libbfd optional

2018-11-12 Thread Jakub Kicinski
On Mon, 12 Nov 2018 13:44:10 -0800, Stanislav Fomichev wrote: > Make it possible to build bpftool without libbfd. libbfd and libopcodes are > typically provided in dev/dbg packages (binutils-dev in debian) which we > usually don't have installed on the fleet machines and we'd like a way to have >

Re: [PATCH v5 bpf-next 2/7] libbpf: cleanup after partial failure in bpf_object__pin

2018-11-12 Thread Martin Lau
On Fri, Nov 09, 2018 at 08:21:41AM -0800, Stanislav Fomichev wrote: [ ... ] > @@ -1918,23 +2160,20 @@ void *bpf_object__priv(struct bpf_object *obj) > } > > static struct bpf_program * > -__bpf_program__next(struct bpf_program *prev, struct bpf_object *obj) > +__bpf_program__iter(struct

[PATCH bpf-next v2] bpftool: make libbfd optional

2018-11-12 Thread Stanislav Fomichev
Make it possible to build bpftool without libbfd. libbfd and libopcodes are typically provided in dev/dbg packages (binutils-dev in debian) which we usually don't have installed on the fleet machines and we'd like a way to have bpftool version that works without installing any additional packages.

Re: [PATCH bpf-next] bpftool: make libbfd optional

2018-11-12 Thread Stanislav Fomichev
On 11/12, Jakub Kicinski wrote: > On Mon, 12 Nov 2018 11:58:27 -0800, Stanislav Fomichev wrote: > > On 11/12, Jakub Kicinski wrote: > > > On Mon, 12 Nov 2018 10:53:28 -0800, Stanislav Fomichev wrote: > > > > diff --git a/tools/bpf/bpftool/main.h b/tools/bpf/bpftool/main.h > > > > index

Re: [PATCH v2] net: Add trace events for all receive exit points

2018-11-12 Thread Mathieu Desnoyers
- On Nov 12, 2018, at 3:46 PM, Mathieu Desnoyers mathieu.desnoy...@efficios.com wrote: > - On Nov 12, 2018, at 3:40 PM, rostedt rost...@goodmis.org wrote: > >> On Mon, 12 Nov 2018 15:20:55 -0500 (EST) >> Mathieu Desnoyers wrote: >> >>> >>> Hrm, looking at this again, I notice that

Re: [PATCH v2] net: Add trace events for all receive exit points

2018-11-12 Thread Mathieu Desnoyers
- On Nov 12, 2018, at 3:40 PM, rostedt rost...@goodmis.org wrote: > On Mon, 12 Nov 2018 15:20:55 -0500 (EST) > Mathieu Desnoyers wrote: > >> >> Hrm, looking at this again, I notice that there is a single DEFINE_EVENT >> using net_dev_template_simple. >> >> We could simply turn

Re: [PATCH mlx5-next 00/10] Collection of ODP fixes

2018-11-12 Thread Leon Romanovsky
On Thu, Nov 08, 2018 at 09:10:07PM +0200, Leon Romanovsky wrote: > From: Leon Romanovsky > > Hi, > > This is collection of fixes to mlx5_core and mlx5_ib ODP logic. > There are two main reasons why we decided to forward it to mlx5-next > and not to rdma-rc or net like our other fixes. > > 1. We

Re: [PATCH v2] net: Add trace events for all receive exit points

2018-11-12 Thread Steven Rostedt
On Mon, 12 Nov 2018 15:20:55 -0500 (EST) Mathieu Desnoyers wrote: > > Hrm, looking at this again, I notice that there is a single DEFINE_EVENT > using net_dev_template_simple. > > We could simply turn netif_receive_skb_list_exit into a TRACE_EVENT(), > remove the net_dev_template_simple, and

Re: [PATCH v2] net: Add trace events for all receive exit points

2018-11-12 Thread Mathieu Desnoyers
- On Nov 12, 2018, at 3:20 PM, Mathieu Desnoyers mathieu.desnoy...@efficios.com wrote: > - On Nov 12, 2018, at 3:09 PM, Mathieu Desnoyers > mathieu.desnoy...@efficios.com wrote: > >> - On Nov 12, 2018, at 2:44 PM, Geneviève Bastien gbast...@versatic.net >> wrote: >> >>> Trace

Re: [PATCH bpf-next] bpftool: make libbfd optional

2018-11-12 Thread Jakub Kicinski
On Mon, 12 Nov 2018 11:58:27 -0800, Stanislav Fomichev wrote: > On 11/12, Jakub Kicinski wrote: > > On Mon, 12 Nov 2018 10:53:28 -0800, Stanislav Fomichev wrote: > > > diff --git a/tools/bpf/bpftool/main.h b/tools/bpf/bpftool/main.h > > > index 61d82020af58..ec1bc2ae3c71 100644 > > > ---

Re: [PATCH v2] net: Add trace events for all receive exit points

2018-11-12 Thread Steven Rostedt
On Mon, 12 Nov 2018 14:44:05 -0500 Geneviève Bastien wrote: > Trace events are already present for the receive entry points, to indicate > how the reception entered the stack. > > This patch adds the corresponding exit trace events that will bound the > reception such that all events occurring

Re: [PATCH net-next] net: phy: check for implementation of both callbacks in phy_drv_supports_irq

2018-11-12 Thread Florian Fainelli
On 11/12/18 12:16 PM, Heiner Kallweit wrote: > Now that the icplus driver has been fixed all PHY drivers supporting > interrupts have both callbacks (config_intr and ack_interrupt) > implemented - as it should be. Therefore phy_drv_supports_irq() > can be changed now to check for both callbacks

Re: [PATCH v2] net: Add trace events for all receive exit points

2018-11-12 Thread Mathieu Desnoyers
- On Nov 12, 2018, at 3:09 PM, Mathieu Desnoyers mathieu.desnoy...@efficios.com wrote: > - On Nov 12, 2018, at 2:44 PM, Geneviève Bastien gbast...@versatic.net > wrote: > >> Trace events are already present for the receive entry points, to indicate >> how the reception entered the

[PATCH net-next] net: phy: check for implementation of both callbacks in phy_drv_supports_irq

2018-11-12 Thread Heiner Kallweit
Now that the icplus driver has been fixed all PHY drivers supporting interrupts have both callbacks (config_intr and ack_interrupt) implemented - as it should be. Therefore phy_drv_supports_irq() can be changed now to check for both callbacks being implemented. Signed-off-by: Heiner Kallweit ---

Re: [PATCH v2] net: Add trace events for all receive exit points

2018-11-12 Thread Mathieu Desnoyers
- On Nov 12, 2018, at 2:44 PM, Geneviève Bastien gbast...@versatic.net wrote: > Trace events are already present for the receive entry points, to indicate > how the reception entered the stack. > > This patch adds the corresponding exit trace events that will bound the > reception such that

Re: [PATCH bpf-next] bpftool: make libbfd optional

2018-11-12 Thread Stanislav Fomichev
On 11/12, Jakub Kicinski wrote: > On Mon, 12 Nov 2018 10:53:28 -0800, Stanislav Fomichev wrote: > > Make it possible to build bpftool without libbfd. This excludes support for > > disassembling jit-ted code and prints an error if the user tries to use > > these features. > > > > Tested by: > >

[PATCH v2] net: Add trace events for all receive exit points

2018-11-12 Thread Geneviève Bastien
Trace events are already present for the receive entry points, to indicate how the reception entered the stack. This patch adds the corresponding exit trace events that will bound the reception such that all events occurring between the entry and the exit can be considered as part of the

Re: [PATCH bpf-next] bpftool: make libbfd optional

2018-11-12 Thread Jakub Kicinski
On Mon, 12 Nov 2018 10:53:28 -0800, Stanislav Fomichev wrote: > Make it possible to build bpftool without libbfd. This excludes support for > disassembling jit-ted code and prints an error if the user tries to use > these features. > > Tested by: > cat > FEATURES_DUMP.bpftool < feature-libbfd=0 >

Re: Kernel 4.19 network performance - forwarding/routing normal users traffic

2018-11-12 Thread Paweł Staszewski
W dniu 11.11.2018 o 09:56, Jesper Dangaard Brouer pisze: On Sat, 10 Nov 2018 22:53:53 +0100 Paweł Staszewski wrote: Now im messing with ring configuration for connectx5 nics. And after reading that paper:

Re: [PATCH net-next] net: phy: switch to lockdep_assert_held in phylib

2018-11-12 Thread Florian Fainelli
On 11/12/18 9:44 AM, Andrew Lunn wrote: > On Sun, Nov 11, 2018 at 10:33:08PM +0100, Heiner Kallweit wrote: >> diff --git a/drivers/net/phy/mdio_bus.c b/drivers/net/phy/mdio_bus.c >> index 2e59a8419..5cb06f021 100644 >> --- a/drivers/net/phy/mdio_bus.c >> +++ b/drivers/net/phy/mdio_bus.c >> @@

Re: [PATCH net-next] net: phy: icplus: add config_intr callback

2018-11-12 Thread Florian Fainelli
On 11/11/18 12:49 PM, Heiner Kallweit wrote: > Move IRQ configuration for IP101A/G from config_init to config_intr > callback. Reasons: > > 1. This allows phylib to disable interrupts if needed. > 2. Icplus was the only driver supporting interrupts w/o defining a >config_intr callback. Now we

[PATCH bpf-next] bpftool: make libbfd optional

2018-11-12 Thread Stanislav Fomichev
Make it possible to build bpftool without libbfd. This excludes support for disassembling jit-ted code and prints an error if the user tries to use these features. Tested by: cat > FEATURES_DUMP.bpftool < --- tools/bpf/bpftool/Makefile | 13 +++-- tools/bpf/bpftool/jit_disasm.c | 7

Re: [PATCH bpf-next] filter: add BPF_ADJ_ROOM_DATA mode to bpf_skb_adjust_room()

2018-11-12 Thread Martin Lau
On Sun, Nov 11, 2018 at 12:43:27AM +0100, Nicolas Dichtel wrote: > Le 09/11/2018 à 19:51, Martin Lau a écrit : > > On Thu, Nov 08, 2018 at 04:11:37PM +0100, Nicolas Dichtel wrote: > [snip] > >> +static int bpf_skb_data_shrink(struct sk_buff *skb, u32 len) > >> +{ > >> + unsigned short hhlen =

[PATCHv2 net-net] net: dsa: mv88e6xxx: Work around mv886e6161 SERDES missing MII_PHYSID2

2018-11-12 Thread Andrew Lunn
We already have a workaround for a couple of switches whose internal PHYs only have the Marvel OUI, but no model number. We detect such PHYs and give them the 6390 ID as the model number. However the mv88e6161 has two SERDES interfaces in the same address range as its internal PHYs. These suffer

[PATCHv2] MAINTAINERS: Replace Vince Bridgers as Altera TSE maintainer

2018-11-12 Thread thor . thayer
From: Thor Thayer Vince has moved to a different role. Replace him as Altera TSE maintainer. Signed-off-by: Thor Thayer Acked-by: Vince Bridgers Acked-by: Alan Tull --- v2 Include netdev and David Miller --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH net-next] net: phy: switch to lockdep_assert_held in phylib

2018-11-12 Thread Andrew Lunn
On Sun, Nov 11, 2018 at 10:33:08PM +0100, Heiner Kallweit wrote: > diff --git a/drivers/net/phy/mdio_bus.c b/drivers/net/phy/mdio_bus.c > index 2e59a8419..5cb06f021 100644 > --- a/drivers/net/phy/mdio_bus.c > +++ b/drivers/net/phy/mdio_bus.c > @@ -541,7 +541,7 @@ int __mdiobus_read(struct mii_bus

Re: [PATCH net-next] net: phy: icplus: add config_intr callback

2018-11-12 Thread Andrew Lunn
On Sun, Nov 11, 2018 at 09:49:12PM +0100, Heiner Kallweit wrote: > Move IRQ configuration for IP101A/G from config_init to config_intr > callback. Reasons: > > 1. This allows phylib to disable interrupts if needed. > 2. Icplus was the only driver supporting interrupts w/o defining a >

Re: [PATCH net-next 17/17] net: sched: unlock rules update API

2018-11-12 Thread David Miller
From: Vlad Buslov Date: Mon, 12 Nov 2018 09:55:46 +0200 > Register netlink protocol handlers for message types RTM_NEWTFILTER, > RTM_DELTFILTER, RTM_GETTFILTER as unlocked. Set rtnl_held variable that > tracks rtnl mutex state to be false by default. This whole conditional locking mechanism is

Re: [PATCH net-next 02/17] net: sched: protect block state with spinlock

2018-11-12 Thread David Miller
From: Vlad Buslov Date: Mon, 12 Nov 2018 09:55:31 +0200 > +#define ASSERT_BLOCK_LOCKED(block) \ > + WARN_ONCE(!spin_is_locked(&(block)->lock), \ > + "BLOCK: assertion failed at %s (%d)\n", __FILE__, __LINE__) spin_is_locked() is

Re: [PATCH net-next 01/17] net: sched: refactor mini_qdisc_pair_swap() to use workqueue

2018-11-12 Thread David Miller
From: Vlad Buslov Date: Mon, 12 Nov 2018 09:55:30 +0200 > +void mini_qdisc_pair_swap(struct mini_Qdisc_pair *miniqp, > + struct tcf_proto *tp_head) > +{ > + xchg(>tp_head, tp_head); If you are not checking the return value of xchg(), then this is simply a store with

Re: [RFC PATCH 1/3] acpi: Add acpi mdio support code

2018-11-12 Thread Andrew Lunn
On Thu, Nov 08, 2018 at 03:22:16PM +0800, Wang Dongsheng wrote: > Add support for parsing the ACPI data node for PHY devices on an MDIO bus. > The current implementation depend on mdio bus scan. > With _DSD device properties we can finally do this: > > Device (MDIO) { > Name (_DSD,

Re: [RFC PATCH 0/3] acpi: Add acpi mdio support code

2018-11-12 Thread Andrew Lunn
> > I'm just trying to ensure whatever is defined is flexible enough that > > we really can later support everything which DT does. We have PHYs on > > MDIO busses, inside switches, which are on MDIO busses, which are > > inside Ethernet interfaces, etc. > > I think it can be satisfied. See the

Re: [PATCHv2 net-next 0/3] sctp: add support for sk_reuseport

2018-11-12 Thread David Miller
From: Xin Long Date: Mon, 12 Nov 2018 18:27:14 +0800 > sctp sk_reuseport allows multiple socks to listen on the same port and > addresses, as long as these socks have the same uid. This works pretty > much as TCP/UDP does, the only difference is that sctp is multi-homing > and all the bind_addrs

[PATCH net] l2tp: fix a sock refcnt leak in l2tp_tunnel_register

2018-11-12 Thread Xin Long
This issue happens when trying to add an existent tunnel. It doesn't call sock_put() before returning -EEXIST to release the sock refcnt that was held by calling sock_hold() before the existence check. This patch is to fix it by holding the sock after doing the existence check. Fixes:

Re: [RFC PATCH 2/6] phy: armada38x: add common phy support

2018-11-12 Thread Andrew Lunn
> +static int a38x_comphy_poll(struct a38x_comphy_lane *lane, > + unsigned int offset, u32 mask, u32 value) > +{ > + unsigned int timeout = 10; > + u32 val; > + > + while (1) { > + val = readl_relaxed(lane->base + offset); > + if ((val &

Re: [PATCH][net-next] net: remove BUG_ON from __pskb_pull_tail

2018-11-12 Thread David Miller
From: Li RongQing Date: Mon, 12 Nov 2018 17:26:13 +0800 > do { > - BUG_ON(!list); > Please get rid of the empty line afterwards as well. Thank you.

Re: [PATCH net v2 1/1] bnx2x: Assign unique DMAE channel number for FW DMAE transactions.

2018-11-12 Thread David Miller
From: Sudarsana Reddy Kalluru Date: Sun, 11 Nov 2018 18:27:34 -0800 > Driver assigns DMAE channel 0 for FW as part of START_RAMROD command. FW > uses this channel for DMAE operations (e.g., TIME_SYNC implementation). > Driver also uses the same channel 0 for DMAE operations for some of the PFs >

Re: [PATCH net-next 3/3] tcp: get rid of tcp_tso_should_defer() dependency on HZ/jiffies

2018-11-12 Thread Yuchung Cheng
On Sun, Nov 11, 2018 at 11:06 AM, Neal Cardwell wrote: > On Sun, Nov 11, 2018 at 9:41 AM Eric Dumazet wrote: >> >> tcp_tso_should_defer() first heuristic is to not defer >> if last send is "old enough". >> >> Its current implementation uses jiffies and its low granularity. >> >> TSO autodefer

Re: [PATCH iproute2] testsuite: ss: Fix spacing in expected output for ssfilter.t

2018-11-12 Thread Stephen Hemminger
On Sat, 10 Nov 2018 22:48:44 +0100 Phil Sutter wrote: > Hi Stefano, > > On Sat, Nov 10, 2018 at 10:21:59AM +0100, Stefano Brivio wrote: > > Since commit 00240899ec0b ("ss: Actually print left delimiter for > > columns") changes spacing in ss output, we also need to adjust for that in > > the ss

[PATCH iproute2] testsuite: colorize test result output

2018-11-12 Thread Stephen Hemminger
When running testsuite it is easy as a human to miss failure. Add symbol colorizing to SKIPED/PASS/FAIL output. Signed-off-by: Stephen Hemminger --- testsuite/Makefile | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/testsuite/Makefile b/testsuite/Makefile index

[PATCH net-next 3/4] sctp: rename enum sctp_event to sctp_event_type

2018-11-12 Thread Xin Long
sctp_event is a structure name defined in RFC for sockopt SCTP_EVENT. To avoid the conflict, rename it. Signed-off-by: Xin Long --- include/net/sctp/constants.h | 2 +- include/net/sctp/sm.h| 4 ++-- net/sctp/primitive.c | 2 +- net/sctp/sm_sideeffect.c | 12 ++--

[PATCH net-next 4/4] sctp: add sockopt SCTP_EVENT

2018-11-12 Thread Xin Long
This patch adds sockopt SCTP_EVENT described in rfc6525#section-6.2. With this sockopt users can subscribe to an event from a specified asoc. Signed-off-by: Xin Long --- include/uapi/linux/sctp.h | 7 net/sctp/socket.c | 89 +++ 2 files

[PATCH net-next 0/4] sctp: add subscribe per asoc and sockopt SCTP_EVENT

2018-11-12 Thread Xin Long
This patchset mainly adds the Event Subscription sockopt described in rfc6525#section-6.2: Subscribing to events as described in [RFC6458] uses a setsockopt() call with the SCTP_EVENT socket option. This option takes the following structure, which specifies the association, the event type (using

[PATCH net 1/1] s390/ism: clear dmbe_mask bit before SMC IRQ handling

2018-11-12 Thread Ursula Braun
SMC-D stress workload showed connection stalls. Since the firmware decides to skip raising an interrupt if the SBA DMBE mask bit is still set, this SBA DMBE mask bit should be cleared before the IRQ handling in the SMC code runs. Otherwise there are small windows possible with missing interrupts

[PATCH net 5/5] net/smc: use after free fix in smc_wr_tx_put_slot()

2018-11-12 Thread Ursula Braun
From: Ursula Braun In smc_wr_tx_put_slot() field pend->idx is used after being cleared. That means always idx 0 is cleared in the wr_tx_mask. This results in a broken administration of available WR send payload buffers. Signed-off-by: Ursula Braun --- net/smc/smc_wr.c | 4 +++- 1 file

[PATCH net 3/5] net/smc: add SMC-D shutdown signal

2018-11-12 Thread Ursula Braun
From: Hans Wippel When a SMC-D link group is freed, a shutdown signal should be sent to the peer to indicate that the link group is invalid. This patch adds the shutdown signal to the SMC code. Signed-off-by: Hans Wippel Signed-off-by: Ursula Braun --- net/smc/smc_core.c | 10 --

[PATCH net 2/5] net/smc: use queue pair number when matching link group

2018-11-12 Thread Ursula Braun
From: Karsten Graul When searching for an existing link group the queue pair number is also to be taken into consideration. When the SMC server sends a new number in a CLC packet (keeping all other values equal) then a new link group is to be created on the SMC client side. Signed-off-by:

[PATCH net 0/5] net/smc: fixes 2018-11-12

2018-11-12 Thread Ursula Braun
From: Ursula Braun here are some fixes in different areas of the smc code for the net tree. Thanks, Ursula Hans Wippel (2): net/smc: abort CLC connection in smc_release net/smc: add SMC-D shutdown signal Karsten Graul (1): net/smc: use queue pair number when matching link group Ursula

[PATCH net 1/5] net/smc: abort CLC connection in smc_release

2018-11-12 Thread Ursula Braun
From: Hans Wippel In case of a non-blocking SMC socket, the initial CLC handshake is performed over a blocking TCP connection in a worker. If the SMC socket is released, smc_release has to wait for the blocking CLC socket operations (e.g., kernel_connect) inside the worker. This patch aborts a

[PATCH net 4/5] net/smc: atomic SMCD cursor handling

2018-11-12 Thread Ursula Braun
Running uperf tests with SMCD on LPARs results in corrupted cursors. SMCD cursors should be treated atomically to fix cursor corruption. Signed-off-by: Ursula Braun --- net/smc/smc_cdc.c | 24 ++-- net/smc/smc_cdc.h | 56

[PATCH net-next v2 1/6] net: aquantia: add rx-flow filter definitions

2018-11-12 Thread Igor Russkikh
From: Dmitry Bogdanov Add missing register definitions and the functions accessing them related to rx-flow filters. Signed-off-by: Dmitry Bogdanov Signed-off-by: Igor Russkikh --- .../ethernet/aquantia/atlantic/hw_atl/hw_atl_llh.c | 109 +

[PATCH net-next v2 2/6] net: aquantia: add infrastructure for ntuple rules

2018-11-12 Thread Igor Russkikh
From: Dmitry Bogdanov Add infrastructure to support ntuple filter configuration. Add rule, remove rule, reapply on interface up. Signed-off-by: Dmitry Bogdanov Signed-off-by: Igor Russkikh --- drivers/net/ethernet/aquantia/atlantic/Makefile| 1 +

[PATCH net-next v2 4/6] net: aquantia: add vlan id to rx flow filters

2018-11-12 Thread Igor Russkikh
From: Dmitry Bogdanov The VLAN filter (VLAN id) is compared against 16 filters. VLAN id must be accompanied by mask 0xF000. That is to distinguish VLAN filter from L2 Ethertype filter with UserPriority since both User Priority and VLAN ID are passed in the same 'vlan' parameter. Flow type may be

[PATCH net-next v2 5/6] net: aquantia: add ethertype and PCP to rx flow filters

2018-11-12 Thread Igor Russkikh
From: Dmitry Bogdanov L2 EtherType filters allows to filter packet by EtherType field or both EtherType and User Priority (PCP) field of 802.1Q. UserPriority (vlan) parameter must be accompanied by mask 0x1FFF. That is to distinguish VLAN filter from L2 Ethertype filter with UserPriority since

[PATCH net-next v2 6/6] net: aquantia: add support of rx-vlan-filter offload

2018-11-12 Thread Igor Russkikh
From: Dmitry Bogdanov Since it uses the same NIC table as rx flow vlan filter therefore rx-flow vlan filter accepts only vlans that present on the interface in case of rx-vlan-filter is on. Signed-off-by: Dmitry Bogdanov Signed-off-by: Igor Russkikh ---

[PATCH net-next v2 3/6] net: aquantia: add support of L3/L4 ntuple filters

2018-11-12 Thread Igor Russkikh
From: Dmitry Bogdanov Add support of L3/L4 5-tuple {protocol, src-ip, dst-ip, src-port, dst-port} filters. Mask is not supported. Src-port and dst-port are only compared for TCP/UDP/SCTP packets. Both IPv4 and IPv6 are supported. The supported actions are the drop and the queue assignment. Due

[PATCH net-next v2 0/6] net: aquantia: add rx-flow filter support

2018-11-12 Thread Igor Russkikh
In this patchset the rx-flow filters functionality and vlan filter offloads are implemented. The rules in NIC hardware have fixed order and priorities. To support this, the locations of filters from ethtool perspective are also fixed: * Locations 0 - 15 for VLAN ID filters * Locations 16 - 31

Re: [PATCH net-next 0/6] net: aquantia: add rx-flow filter support

2018-11-12 Thread Igor Russkikh
On 12.11.2018 18:02, Igor Russkikh wrote: > In this patchset the rx-flow filters functionality and vlan filter offloads > are implemented. > > The rules in NIC hardware have fixed order and priorities. > To support this, the locations of filters from ethtool perspective are also > fixed: > Hi

  1   2   >