Re: [net-next 10/16] net/mlx5: Support PCIe buffer congestion handling via Devlink

2018-07-30 Thread Bjorn Helgaas
On Mon, Jul 30, 2018 at 08:02:48AM -0700, Alexander Duyck wrote: > On Mon, Jul 30, 2018 at 7:07 AM, Bjorn Helgaas wrote: > > On Sun, Jul 29, 2018 at 03:00:28PM -0700, Alexander Duyck wrote: > >> On Sun, Jul 29, 2018 at 2:23 AM, Moshe Shemesh > >> wrote: > >&g

Re: [net-next 10/16] net/mlx5: Support PCIe buffer congestion handling via Devlink

2018-07-31 Thread Bjorn Helgaas
On Mon, Jul 30, 2018 at 08:19:50PM -0700, Alexander Duyck wrote: > On Mon, Jul 30, 2018 at 7:33 PM, Bjorn Helgaas wrote: > > On Mon, Jul 30, 2018 at 08:02:48AM -0700, Alexander Duyck wrote: > >> On Mon, Jul 30, 2018 at 7:07 AM, Bjorn Helgaas wrote: > >> > On Sun, Ju

[PATCH v1 0/4] PCI: Remove unnecessary includes of

2018-07-25 Thread Bjorn Helgaas
Remove includes of from files that don't need it. I'll apply all these via the PCI tree unless there's objection. --- Bjorn Helgaas (4): igb: Remove unnecessary include of ath9k: Remove unnecessary include of iwlwifi: Remove unnecessary include of PCI: Remove

[PATCH v1 1/4] igb: Remove unnecessary include of

2018-07-25 Thread Bjorn Helgaas
From: Bjorn Helgaas The igb driver doesn't need anything provided by pci-aspm.h, so remove the unnecessary include of it. Signed-off-by: Bjorn Helgaas --- drivers/net/ethernet/intel/igb/igb_main.c |1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ethernet/intel/igb/igb_main.c

[PATCH v1 4/4] PCI: Remove unnecessary include of

2018-07-25 Thread Bjorn Helgaas
From: Bjorn Helgaas Several PCI core files include pci-aspm.h even though they don't need anything provided by that file. Remove the unnecessary includes of it. Signed-off-by: Bjorn Helgaas --- drivers/pci/pci-sysfs.c |1 - drivers/pci/pci.c |1 - drivers/pci/probe.c |1

[PATCH v1 3/4] iwlwifi: Remove unnecessary include of

2018-07-25 Thread Bjorn Helgaas
From: Bjorn Helgaas This part of the iwlwifi driver doesn't need anything provided by pci-aspm.h, so remove the unnecessary include of it. Signed-off-by: Bjorn Helgaas --- drivers/net/wireless/intel/iwlwifi/pcie/drv.c |1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/wireless

[PATCH v1 2/4] ath9k: Remove unnecessary include of

2018-07-25 Thread Bjorn Helgaas
From: Bjorn Helgaas The ath9k driver doesn't need anything provided by pci-aspm.h, so remove the unnecessary include of it. Signed-off-by: Bjorn Helgaas --- drivers/net/wireless/ath/ath9k/pci.c |1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/wireless/ath/ath9k/pci.c b

Re: [PATCH v1 0/4] PCI: Remove unnecessary includes of

2018-07-25 Thread Bjorn Helgaas
On Wed, Jul 25, 2018 at 01:33:23PM -0700, Sinan Kaya wrote: > On 7/25/2018 12:52 PM, Bjorn Helgaas wrote: > > emove includes of from files that don't need > > it. I'll apply all these via the PCI tree unless there's objection. > > > > --- > > > > Bj

Re: [PATCH v5 05/14] PCI: Add pcie_print_link_status() to log link speed and whether it's limited

2018-04-13 Thread Bjorn Helgaas
On Thu, Apr 12, 2018 at 09:32:49PM -0700, Jakub Kicinski wrote: > On Fri, 30 Mar 2018 16:05:18 -0500, Bjorn Helgaas wrote: > > + if (bw_avail >= bw_cap) > > + pci_info(dev, "%d Mb/s available bandwidth (%s x%d link)\n", > > +

Re: [PATCH] PCI: Add PCIe to pcie_print_link_status() messages

2018-04-20 Thread Bjorn Helgaas
On Fri, Apr 13, 2018 at 11:16:38AM -0700, Jakub Kicinski wrote: > Currently the pcie_print_link_status() will print PCIe bandwidth > and link width information but does not mention it is pertaining > to the PCIe. Since this and related functions are used exclusively > by networking drivers today

Re: [pci PATCH v8 0/4] Add support for unmanaged SR-IOV

2018-04-21 Thread Bjorn Helgaas
On Fri, Apr 20, 2018 at 12:28:08PM -0400, Alexander Duyck wrote: > This series is meant to add support for SR-IOV on devices when the VFs are > not managed by the kernel. Examples of recent patches attempting to do this > include: > virto - https://patchwork.kernel.org/patch/10241225/ > pci-stub -

Re: [PATCH net-next 1/2] PCI: Add two more values for PCIe Max_Read_Request_Size

2018-04-16 Thread Bjorn Helgaas
ails, e.g., PCI: Add #defines for 2K and 4K Max Read Request Size Acked-by: Bjorn Helgaas <bhelg...@google.com> I suspect conflicts are more likely in r8169.c so it might make more sense to route these through the netdev tree. I'd also be happy to take them, so let me know if you wan

Re: [pci PATCH v8 0/4] Add support for unmanaged SR-IOV

2018-04-24 Thread Bjorn Helgaas
On Sat, Apr 21, 2018 at 05:22:27PM -0700, Alexander Duyck wrote: > On Sat, Apr 21, 2018 at 1:34 PM, Bjorn Helgaas <helg...@kernel.org> wrote: > > For example, I'm not sure what you mean by "devices where the PF is > > not capable of managing VF resources." > &g

[PATCH v5 12/14] fm10k: Report PCIe link properties with pcie_print_link_status()

2018-03-30 Thread Bjorn Helgaas
From: Bjorn Helgaas <bhelg...@google.com> Use pcie_print_link_status() to report PCIe link speed and possible limitations instead of implementing this in the driver itself. Note that pcie_get_minimum_link() can return misleading information because it finds the slowest link and the nar

[PATCH v5 11/14] cxgb4: Report PCIe link properties with pcie_print_link_status()

2018-03-30 Thread Bjorn Helgaas
From: Bjorn Helgaas <bhelg...@google.com> Use pcie_print_link_status() to report PCIe link speed and possible limitations instead of implementing this in the driver itself. Note that pcie_get_minimum_link() can return misleading information because it finds the slowest link and the nar

[PATCH v5 09/14] bnx2x: Report PCIe link properties with pcie_print_link_status()

2018-03-30 Thread Bjorn Helgaas
From: Bjorn Helgaas <bhelg...@google.com> Use pcie_print_link_status() to report PCIe link speed and possible limitations instead of implementing this in the driver itself. Note that pcie_get_minimum_link() can return misleading information because it finds the slowest link and the nar

[PATCH v5 13/14] ixgbe: Report PCIe link properties with pcie_print_link_status()

2018-03-30 Thread Bjorn Helgaas
From: Bjorn Helgaas <bhelg...@google.com> Use pcie_print_link_status() to report PCIe link speed and possible limitations instead of implementing this in the driver itself. Note that pcie_get_minimum_link() can return misleading information because it finds the slowest link and the nar

[PATCH v5 14/14] PCI: Remove unused pcie_get_minimum_link()

2018-03-30 Thread Bjorn Helgaas
From: Bjorn Helgaas <bhelg...@google.com> In some cases pcie_get_minimum_link() returned misleading information because it found the slowest link and the narrowest link without considering the total bandwidth of the link. For example, if the path contained a 16 GT/s x1 link and a 2.5 GT

[PATCH v5 10/14] bnxt_en: Report PCIe link properties with pcie_print_link_status()

2018-03-30 Thread Bjorn Helgaas
From: Bjorn Helgaas <bhelg...@google.com> Use pcie_print_link_status() to report PCIe link speed and possible limitations instead of implementing this in the driver itself. Note that pcie_get_minimum_link() can return misleading information because it finds the slowest link and the nar

[PATCH v5 07/14] net/mlx5: Report PCIe link properties with pcie_print_link_status()

2018-03-30 Thread Bjorn Helgaas
From: Tal Gilboa <ta...@mellanox.com> Use pcie_print_link_status() to report PCIe link speed and possible limitations. Signed-off-by: Tal Gilboa <ta...@mellanox.com> [bhelgaas: changelog] Signed-off-by: Bjorn Helgaas <bhelg...@google.com> Reviewed-by: Tariq Toukan &l

[PATCH v5 08/14] net/mlx5e: Use pcie_bandwidth_available() to compute bandwidth

2018-03-30 Thread Bjorn Helgaas
bw() wrapper altogether] Signed-off-by: Bjorn Helgaas <bhelg...@google.com> Reviewed-by: Tariq Toukan <tar...@mellanox.com> --- drivers/net/ethernet/mellanox/mlx5/core/en_main.c | 32 + 1 file changed, 1 insertion(+), 31 deletions(-) diff --git a/drivers/net/eth

[PATCH v5 06/14] net/mlx4_core: Report PCIe link properties with pcie_print_link_status()

2018-03-30 Thread Bjorn Helgaas
changelog] Signed-off-by: Bjorn Helgaas <bhelg...@google.com> --- drivers/net/ethernet/mellanox/mlx4/main.c | 81 - 1 file changed, 1 insertion(+), 80 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlx4/main.c b/drivers/net/ethernet/mellanox/mlx4/m

[PATCH v5 01/14] PCI: Add pcie_get_speed_cap() to find max supported link speed

2018-03-30 Thread Bjorn Helgaas
don't export outside drivers/pci] Signed-off-by: Bjorn Helgaas <bhelg...@google.com> Reviewed-by: Tariq Toukan <tar...@mellanox.com> --- drivers/pci/pci-sysfs.c | 28 ++-- drivers/pci/pci.c | 44 driver

[PATCH v5 03/14] PCI: Add pcie_bandwidth_capable() to compute max supported link bandwidth

2018-03-30 Thread Bjorn Helgaas
) signatures, don't export outside drivers/pci] Signed-off-by: Bjorn Helgaas <bhelg...@google.com> Reviewed-by: Tariq Toukan <tar...@mellanox.com> --- drivers/pci/pci.c | 21 + drivers/pci/pci.h |9 + 2 files changed, 30 insertions(+) diff --git a/dri

[PATCH v5 02/14] PCI: Add pcie_get_width_cap() to find max supported link width

2018-03-30 Thread Bjorn Helgaas
don't export outside drivers/pci] Signed-off-by: Bjorn Helgaas <bhelg...@google.com> Reviewed-by: Tariq Toukan <tar...@mellanox.com> --- drivers/pci/pci-sysfs.c | 10 ++ drivers/pci/pci.c | 18 ++ drivers/pci/pci.h |1 + 3 files changed, 21 in

[PATCH v5 04/14] PCI: Add pcie_bandwidth_available() to compute bandwidth available to device

2018-03-30 Thread Bjorn Helgaas
y: Tal Gilboa <ta...@mellanox.com> [bhelgaas: changelog, leave pcie_get_minimum_link() alone for now, return bw directly, use pci_upstream_bridge(), check "next_bw <= bw" to find uppermost limiting device, return speed/width of the limiting device] Signed-off-by: Bjorn Hel

Re: [PATCH v5 03/14] PCI: Add pcie_bandwidth_capable() to compute max supported link bandwidth

2018-04-02 Thread Bjorn Helgaas
On Mon, Apr 02, 2018 at 10:34:58AM +0300, Tal Gilboa wrote: > On 4/2/2018 3:40 AM, Bjorn Helgaas wrote: > > On Sun, Apr 01, 2018 at 11:38:53PM +0300, Tal Gilboa wrote: > > > On 3/31/2018 12:05 AM, Bjorn Helgaas wrote: > > > > From: Tal Gilboa <ta...@m

Re: [PATCH v5 03/14] PCI: Add pcie_bandwidth_capable() to compute max supported link bandwidth

2018-04-02 Thread Bjorn Helgaas
On Mon, Apr 02, 2018 at 04:00:16PM +, Keller, Jacob E wrote: > > -Original Message- > > From: Tal Gilboa [mailto:ta...@mellanox.com] > > Sent: Monday, April 02, 2018 7:34 AM > > To: Bjorn Helgaas <helg...@kernel.org> > > Cc: Tariq Toukan &l

Re: [PATCH v5 05/14] PCI: Add pcie_print_link_status() to log link speed and whether it's limited

2018-04-02 Thread Bjorn Helgaas
On Mon, Apr 02, 2018 at 04:25:17PM +, Keller, Jacob E wrote: > > -Original Message- > > From: Bjorn Helgaas [mailto:helg...@kernel.org] > > Sent: Friday, March 30, 2018 2:05 PM > > To: Tal Gilboa <ta...@mellanox.com> > > Cc: Tariq Toukan &l

Re: [PATCH v5 12/14] fm10k: Report PCIe link properties with pcie_print_link_status()

2018-04-02 Thread Bjorn Helgaas
On Mon, Apr 02, 2018 at 03:56:06PM +, Keller, Jacob E wrote: > > -Original Message- > > From: Bjorn Helgaas [mailto:helg...@kernel.org] > > Sent: Friday, March 30, 2018 2:06 PM > > To: Tal Gilboa <ta...@mellanox.com> > > Cc: Tariq Toukan &l

Re: [PATCH v5 04/14] PCI: Add pcie_bandwidth_available() to compute bandwidth available to device

2018-04-01 Thread Bjorn Helgaas
On Sun, Apr 01, 2018 at 11:41:42PM +0300, Tal Gilboa wrote: > On 3/31/2018 12:05 AM, Bjorn Helgaas wrote: > > From: Tal Gilboa <ta...@mellanox.com> > > > > Add pcie_bandwidth_available() to compute the bandwidth available to a > > device. This may be limited by

Re: [PATCH v5 03/14] PCI: Add pcie_bandwidth_capable() to compute max supported link bandwidth

2018-04-01 Thread Bjorn Helgaas
On Sun, Apr 01, 2018 at 11:38:53PM +0300, Tal Gilboa wrote: > On 3/31/2018 12:05 AM, Bjorn Helgaas wrote: > > From: Tal Gilboa <ta...@mellanox.com> > > > > Add pcie_bandwidth_capable() to compute the max link bandwidth supported by > > a device, based on the m

Re: [PATCH v5 03/14] PCI: Add pcie_bandwidth_capable() to compute max supported link bandwidth

2018-04-03 Thread Bjorn Helgaas
On Mon, Apr 02, 2018 at 05:30:54PM -0700, Jacob Keller wrote: > On Mon, Apr 2, 2018 at 7:05 AM, Bjorn Helgaas <helg...@kernel.org> wrote: > > +/* PCIe speed to Mb/s reduced by encoding overhead */ > > +#define PCIE_SPEED2MBS_ENC(speed) \ > > + ((speed) == PCIE_SPE

[PATCH v5 05/14] PCI: Add pcie_print_link_status() to log link speed and whether it's limited

2018-03-30 Thread Bjorn Helgaas
oa <ta...@mellanox.com> [bhelgaas: changelog, reword log messages, print device capabilities when not limited] Signed-off-by: Bjorn Helgaas <bhelg...@google.com> --- drivers/pci/pci.c | 29 + include/linux/pci.h |1 + 2 files changed, 30 insertions(+) di

[PATCH v5 00/14] Report PCI device link status

2018-03-30 Thread Bjorn Helgaas
://lkml.kernel.org/r/1522394086-3555-1-git-send-email-ta...@mellanox.com --- Bjorn Helgaas (6): bnx2x: Report PCIe link properties with pcie_print_link_status() bnxt_en: Report PCIe link properties with pcie_print_link_status() cxgb4: Report PCIe link properties with pcie_print_link_status

Re: [PATCH v3] PCI: Reprogram bridge prefetch registers on resume

2018-09-27 Thread Bjorn Helgaas
[+cc LKML] On Tue, Sep 18, 2018 at 04:32:44PM -0500, Bjorn Helgaas wrote: > On Thu, Sep 13, 2018 at 11:37:45AM +0800, Daniel Drake wrote: > > On 38+ Intel-based Asus products, the nvidia GPU becomes unusable > > after S3 suspend/resume. The affected products include multiple

<    1   2