Re: [PATCH 1/2] AFS: Fix interminable loop in afs_write_back_from_locked_page()

2007-05-11 Thread David Howells
Andrew Morton [EMAIL PROTECTED] wrote: Yes, it's a shame that there doesn't seem to be a fine-grained way of turning on -W's useful bits. You can turn off -W's undesirable bits. For net/rxrpc/ and fs/afs/ at least, adding: CFLAGS += -W -Wno-unused-parameter to the Makefile generates

Re: [PATCH 1/2] AFS: Fix interminable loop in afs_write_back_from_locked_page()

2007-05-11 Thread David Howells
Andrew Morton [EMAIL PROTECTED] wrote: Following bug was uncovered by compiling with '-W' flag: gcc -W finds a number of fairly scary bugs. Do you mean in my code specifically? Or in the kernel in general? As far as I can tell -W only finds an eye-glazingly large quantity of 'unused

Re: [PATCH 1/2] AFS: Fix interminable loop in afs_write_back_from_locked_page()

2007-05-11 Thread David Howells
Andrew Morton [EMAIL PROTECTED] wrote: More than one would expect, given that it is recommended in Documentation/SubmitChecklist, which everyone reads ;) Which states incorrectly: | 22: Newly-added code has been compiled with `gcc -W'. This will generate | lots of noise, but is good for

[PATCH] AF_RXRPC: AF_RXRPC depends on IPv4

2007-05-14 Thread David Howells
Add a dependency for CONFIG_AF_RXRPC on CONFIG_INET. This fixes this error: net/built-in.o: In function `rxrpc_get_peer': (.text+0x42824): undefined reference to `ip_route_output_key' Signed-off-by: David Howells [EMAIL PROTECTED] --- net/rxrpc/Kconfig |2 +- 1 files changed, 1 insertions

[PATCH] AF_RXRPC: Make call state names available if CONFIG_PROC_FS=n

2007-05-14 Thread David Howells
Make the call state names array available even if CONFIG_PROC_FS is disabled as it's used in other places (such as debugging statements) too. Signed-off-by: David Howells [EMAIL PROTECTED] --- net/rxrpc/ar-call.c | 19 +++ net/rxrpc/ar-proc.c | 19 --- 2

Re: [2.6 patch] net/rxrpc/ar-connection.c: fix NULL dereference

2007-06-18 Thread David Howells
Adrian Bunk [EMAIL PROTECTED] wrote: This patch fixes a NULL dereference spotted by the Coverity checker. Signed-off-by: Adrian Bunk [EMAIL PROTECTED] Acked-by: David Howells [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message

Re: [RFC: 2.6 patch] net/rxrpc/ar-output.c: remove dead code

2007-06-18 Thread David Howells
Adrian Bunk [EMAIL PROTECTED] wrote: This patch removes dead code spotted by the Coverity checker. This is the wrong solution. 'copied' should be updated. David - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info

[PATCH] AF_RXRPC: Return the number of bytes buffered in rxrpc_send_data()

2007-06-18 Thread David Howells
Return the number of bytes buffered in rxrpc_send_data(). Signed-off-by: David Howells [EMAIL PROTECTED] --- net/rxrpc/ar-output.c |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/net/rxrpc/ar-output.c b/net/rxrpc/ar-output.c index 591c442..cc9102c 100644 --- a/net

[PATCH] FRV: Fix {dis,en}able_irq_lockdep_irqrestore compile error

2006-09-05 Thread David Howells
Fix the lack of certain non-LOCKDEP stub functions in linux/interrupt.h and also provide FRV with LOCKDEP variants. This is to be applied to -mm kernel since not all of the functions added exist in the main kernel. Signed-Off-By: David Howells [EMAIL PROTECTED] --- warthogdiffstat -p1 frv-irq

[PATCH] FRV: do_gettimeofday() should no longer use tickadj

2006-09-05 Thread David Howells
Stop do_gettimeofday() on FRV from using tickadj, and model it after ARM instead. This patch also provides a placeholder macro for getting hardware timer data to be filled in when such is available. Signed-Off-By: David Howells [EMAIL PROTECTED] --- warthogdiffstat -p1 frv-tickadj-2618rc5mm1

[PATCH] NOMMU: Provide page_mkclean() for NOMMU

2006-09-05 Thread David Howells
Provide a page_mkclean() implementation for NOMMU. This doesn't do anything except return successfully as there are no PTEs for it to play with. This is only relevant to the -mm kernels. Signed-Off-By: David Howells [EMAIL PROTECTED] --- warthogdiffstat -p1 nommu-page_mkclean-2618rc5mm1.diff

[PATCH] NOMMU: Make lib/ioremap.c conditional

2006-09-05 Thread David Howells
Make lib/ioremap.c conditional on !CONFIG_MMU. It plays with PTEs which don't exist under NOMMU conditions. Signed-Off-By: David Howells [EMAIL PROTECTED] --- warthogdiffstat -p1 nommu-ioremap-2618rc5mm1.diff lib/Makefile |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff -urp

[PATCH] NOMMU: Move the fallback arch_vma_name() to a sensible place

2006-09-05 Thread David Howells
Move the fallback arch_vma_name() to a sensible place (kernel/signal.c). Currently it's in fs/proc/task_mmu.c, a file that is dependent on both CONFIG_PROC_FS and CONFIG_MMU being enabled, but it's used from kernel/signal.c from where it is called unconditionally. Signed-Off-By: David Howells

Re: [PATCH] FRV: do_gettimeofday() should no longer use tickadj

2006-09-06 Thread David Howells
john stultz [EMAIL PROTECTED] wrote: From this patch it looks like the FRV arch could be trivially converted to GENERIC_TIME. Would you consider the following, totally untested patch? It certainly looks interesting. I'll have to study the clocksource stuff - some FRV CPUs have an effective

Re: [PATCH] FRV: do_gettimeofday() should no longer use tickadj

2006-09-06 Thread David Howells
Ingo Molnar [EMAIL PROTECTED] wrote: btw., would be nice to convert it to genirq (and irqchips) too =B-) That would solve the kind of disable_irq_lockdep() breakage that was reported recently. I can think of reasons for not using that stuff also. (1) Passing struct pt_regs *regs around is

Re: [PATCH] FRV: do_gettimeofday() should no longer use tickadj

2006-09-07 Thread David Howells
Ingo Molnar [EMAIL PROTECTED] wrote: So, again, why _should_ I use the generic IRQ stuff? [...] To have shared code between architectures? That's reasonable as far as it goes, the algorithms are similar per-arch, but the PICs are quite ofter quite different. My FRV board here has three

Re: [PATCH] FRV: do_gettimeofday() should no longer use tickadj

2006-09-07 Thread David Howells
Benjamin Herrenschmidt [EMAIL PROTECTED] wrote: Well, genirq gives you more flexibility than the current mecanism so ... No, it doesn't because the FRV arch contains its own mechanism and I can do what ever I like in it. genirq's flexibility comes at a price. Count the number of hooks in

Re: [PATCH] FRV: do_gettimeofday() should no longer use tickadj

2006-09-06 Thread David Howells
Ingo Molnar [EMAIL PROTECTED] wrote: we'll get rid of that pt_regs thing centrally, from all drivers at once - there's upstream buy-in for that already, and Thomas already generated a test-patch for that a few months ago. But it's not a big issue right now. Yay! Can you give me a pointer

Re: [PATCH] FRV: do_gettimeofday() should no longer use tickadj

2006-09-08 Thread David Howells
Benjamin Herrenschmidt [EMAIL PROTECTED] wrote: No, you do a chain handler. Look at how I do it in arch/powerpc/platform/pseries/setup.c for example. It's actually trivial. You install a special flow handler (which means that there is very little overhead, almost none, from the toplevel irq

Re: [PATCH] FRV: do_gettimeofday() should no longer use tickadj

2006-09-08 Thread David Howells
Benjamin Herrenschmidt [EMAIL PROTECTED] wrote: Please update Documentation/DocBook/genericirq.tmpl. That doesn't mention it. I must admit I haven't read the documentation :) I looked at the code/patches when genirq was posted and did my powerpc implementation based on my understanding

Re: [PATCH] FRV: do_gettimeofday() should no longer use tickadj

2006-09-08 Thread David Howells
Benjamin Herrenschmidt [EMAIL PROTECTED] wrote: Now, if you have funky cascades, then you can always group them into a virtual irq cascade line and have a special chained flow handler that does all the figuring out off those... it's up to you. You make it sound so easy, but it's

Re: [PATCH] FRV: do_gettimeofday() should no longer use tickadj

2006-09-11 Thread David Howells
Ingo Molnar [EMAIL PROTECTED] wrote: i cannot find Thomas' recent 2.6 one (Thomas, do you have a link to it?), but i did one 5 years ago: http://people.redhat.com/mingo/irq-rewrite-patches/irq-cleanup-2.4.15-B1.bz2 in general it's a large but otherwise pretty dumb patch. I wrote my own

Re: [PATCH 0/59] Cleanup sysctl

2007-01-16 Thread David Howells
The FRV bits look okay. I can't test them until I get back from Australia in Feb. David - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 25/59] sysctl: C99 convert arch/frv/kernel/pm.c

2007-01-24 Thread David Howells
Fine by me. Acked-By: David Howells [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [2.6 patch] kill net/rxrpc/rxrpc_syms.c

2006-11-27 Thread David Howells
Adrian Bunk [EMAIL PROTECTED] wrote: This patch moves the EXPORT_SYMBOL's from net/rxrpc/rxrpc_syms.c to the files with the actual functions. You can if you like. Can you slap a blank line before each EXPORT_SYMBOL() though please? David - To unsubscribe from this list: send the line

Re: [2.6 patch] kill net/rxrpc/rxrpc_syms.c

2006-11-28 Thread David Howells
Adrian Bunk [EMAIL PROTECTED] wrote: This patch moves the EXPORT_SYMBOL's from net/rxrpc/rxrpc_syms.c to the files with the actual functions. You can if you like. Can you slap a blank line before each EXPORT_SYMBOL() though please? Updated patch below. Acked-By: David Howells

[PATCH 2/9] AF_RXRPC: Move generic skbuff stuff from XFRM code to generic code

2007-04-02 Thread David Howells
Move generic skbuff stuff from XFRM code to generic code so that AF_RXRPC can use it too. The kdoc comments I've attached to the functions needs to be checked by whoever wrote them as I had to make some guesses about the workings of these functions. Signed-Off-By: David Howells [EMAIL PROTECTED

[PATCH 1/9] AF_RXRPC: Add blkcipher accessors for using kernel data directly

2007-04-02 Thread David Howells
, on the other hand, is done through the scatter-gather list interface as the amount of data is sufficient that the expense of doing virtual address to page calculations is sufficiently small by comparison. Signed-Off-By: David Howells [EMAIL PROTECTED] --- crypto/blkcipher.c |2 + crypto/pcbc.c

[PATCH 3/9] AF_RXRPC: Make it possible to merely try to cancel timers and delayed work

2007-04-02 Thread David Howells
Export try_to_del_timer_sync() for use by the RxRPC module. Add a try_to_cancel_delayed_work() so that it is possible to merely attempt to cancel a delayed work timer. Signed-Off-By: David Howells [EMAIL PROTECTED] --- include/linux/workqueue.h | 21 + kernel/timer.c

[PATCH 4/9] AF_RXRPC: Key facility changes for AF_RXRPC

2007-04-02 Thread David Howells
-Off-By: David Howells [EMAIL PROTECTED] --- Documentation/keys.txt | 12 include/linux/key.h |2 ++ security/keys/keyring.c |2 ++ 3 files changed, 16 insertions(+), 0 deletions(-) diff --git a/Documentation/keys.txt b/Documentation/keys.txt index 60c665d..81d9aa0

[PATCH 7/9] AF_RXRPC: Add an interface to the AF_RXRPC module for the AFS filesystem to use

2007-04-02 Thread David Howells
the error number from a local or network error message. int rxrpc_kernel_get_error_number(struct sk_buff *skb); This is used to extract the error number from a message indicating either a local error occurred or a network error occurred. Signed-Off-By: David Howells [EMAIL PROTECTED

Re: [PATCH 1/9] AF_RXRPC: Add blkcipher accessors for using kernel data directly

2007-04-03 Thread David Howells
Herbert Xu [EMAIL PROTECTED] wrote: Would it be possible to just use the existing scatterlist interface for now? We can simplify it later when things settle down. I'll apply the attached patch for now and drop the bypass patch. It's a bit messy, but it does let me use the sg-list interface.

[PATCH 1/8] AF_RXRPC: Move generic skbuff stuff from XFRM code to generic code [try #2]

2007-04-03 Thread David Howells
Move generic skbuff stuff from XFRM code to generic code so that AF_RXRPC can use it too. The kdoc comments I've attached to the functions needs to be checked by whoever wrote them as I had to make some guesses about the workings of these functions. Signed-Off-By: David Howells [EMAIL PROTECTED

[PATCH 2/8] AF_RXRPC: Make it possible to merely try to cancel timers and delayed work [try #2]

2007-04-03 Thread David Howells
Export try_to_del_timer_sync() for use by the RxRPC module. Add a try_to_cancel_delayed_work() so that it is possible to merely attempt to cancel a delayed work timer. Signed-Off-By: David Howells [EMAIL PROTECTED] --- include/linux/workqueue.h | 21 + kernel/timer.c

[PATCH 0/8] AF_RXRPC socket family and AFS rewrite [try #2]

2007-04-03 Thread David Howells
The first of these patches together provide secure client-side RxRPC connectivity as a Linux kernel socket family. Only the RxRPC transport/session side is supplied - the presentation side (marshalling the data) is left to the client. Copies of the patches can be found here:

[PATCH 6/8] AF_RXRPC: Add an interface to the AF_RXRPC module for the AFS filesystem to use [try #2]

2007-04-03 Thread David Howells
the error number from a local or network error message. int rxrpc_kernel_get_error_number(struct sk_buff *skb); This is used to extract the error number from a message indicating either a local error occurred or a network error occurred. Signed-Off-By: David Howells [EMAIL PROTECTED

[PATCH 3/8] AF_RXRPC: Key facility changes for AF_RXRPC [try #2]

2007-04-03 Thread David Howells
-Off-By: David Howells [EMAIL PROTECTED] --- Documentation/keys.txt | 12 include/linux/key.h |2 ++ security/keys/keyring.c |2 ++ 3 files changed, 16 insertions(+), 0 deletions(-) diff --git a/Documentation/keys.txt b/Documentation/keys.txt index 60c665d..81d9aa0

Re: [PATCH] CONFIG_PACKET_MMAP should depend on MMU

2007-04-10 Thread David Howells
Robin Getz [EMAIL PROTECTED] wrote: David - I know you have been reworking the noMMU vma handling - is there a solution to vm_insert_page? The reason vm_insert_page() is being called, I imagine, is because packet_mmap() has to insert mappings to an already existing buffer. All it does is

[PATCH 0/8] AFS: Add security support and fix bugs

2007-04-11 Thread David Howells
These patches build on the patchset labelled AF_RXRPC socket family and AFS rewrite. The patches are also available for http download. Firstly, the patches fix a number of bugs in AF_RXRPC: http://people.redhat.com/~dhowells/rxrpc/09-af_rxrpc-own-workqueues.diff

[PATCH 3/8] AFS: Fix callback aggregator work item deadlock

2007-04-11 Thread David Howells
Fix a deadlock in the give-up-callback aggregator dispatcher work item whereby the aggregator runs on keventd as does timed autounmount, thus leading to the unmount blocking keventd whilst waiting for keventd to run the aggregator when the give-up-callback buffer is full. Signed-Off-By: David

[PATCH 1/8] AF_RXRPC: Use own workqueues

2007-04-11 Thread David Howells
-By: David Howells [EMAIL PROTECTED] --- net/rxrpc/af_rxrpc.c | 17 ++--- net/rxrpc/ar-accept.c | 12 ++-- net/rxrpc/ar-ack.c| 10 +- net/rxrpc/ar-call.c | 16 net/rxrpc/ar-connection.c |8 net/rxrpc/ar

[PATCH 2/8] AF_RXRPC: Lower dead call timeout and fix available call counting on connections

2007-04-11 Thread David Howells
that was supposed to have one available and didn't. In association with this, more assertions have been added to check this. Signed-Off-By: David Howells [EMAIL PROTECTED] --- net/rxrpc/ar-call.c | 59 + net/rxrpc/ar-connection.c | 20

[PATCH 7/8] AFS: Permit key to be cached in nameidata

2007-04-11 Thread David Howells
be useful for NFS and CIFS. Signed-Off-By: David Howells [EMAIL PROTECTED] --- fs/namei.c|5 + fs/open.c |7 +-- include/linux/namei.h |1 + 3 files changed, 11 insertions(+), 2 deletions(-) diff --git a/fs/namei.c b/fs/namei.c index ee60cc4..7a59d12

[PATCH 5/8] AFS: Handle multiple mounts of an AFS superblock correctly

2007-04-11 Thread David Howells
from sb-s_flags. Signed-Off-By: David Howells [EMAIL PROTECTED] --- fs/afs/super.c | 26 -- 1 files changed, 16 insertions(+), 10 deletions(-) diff --git a/fs/afs/super.c b/fs/afs/super.c index efc4fe6..77e6875 100644 --- a/fs/afs/super.c +++ b/fs/afs/super.c @@ -212,7

[PATCH 6/8] AFS: AF_RXRPC key changes

2007-04-11 Thread David Howells
-By: David Howells [EMAIL PROTECTED] --- include/keys/rxrpc-type.h | 22 ++ net/rxrpc/af_rxrpc.c |2 ++ net/rxrpc/ar-key.c| 10 +- net/rxrpc/ar-output.c |6 +- 4 files changed, 38 insertions(+), 2 deletions(-) diff --git a/include/keys/rxrpc

[PATCH 4/8] AFS: Correctly alter relocation state after update and show state in /proc

2007-04-11 Thread David Howells
Correctly alter the relocation state after update is complete by switching it from Updating to Valid. Also display the record state in the vlocation database proc file. Signed-Off-By: David Howells [EMAIL PROTECTED] --- fs/afs/proc.c | 15 +-- fs/afs/vlocation.c |4

Re: [PATCH 8/8] AFS: Add security support

2007-04-11 Thread David Howells
J. Bruce Fields [EMAIL PROTECTED] wrote: Just curious--when is the actual crypto done? There doesn't seem to be any in this patch. See AF_RXRPC patch: http://people.redhat.com/~dhowells/rxrpc/04-af_rxrpc.diff You turn on CONFIG_RXKAD and load the rxkad module thus built (assuming

Re: Getting a network interface list from within the kernel

2007-04-13 Thread David Howells
David Miller [EMAIL PROTECTED] wrote: Issue a RTM_GETLINK rtnetlink request, and parse the response. Okay, I've managed to find code that does this. However, RTM_GETLINK does not appear to return any IPv4 addressing information. It does, however, contain the MTU details which is one of the

Can netlink_recvmsg not truncate messages unless asked to?

2007-04-13 Thread David Howells
Would it be feasible to make netlink_recvmsg() _not_ truncate message unless it is asked to by having MSG_TRUNC passed to it? Unless netlink data packets are limited to PAGE_SIZE or less, it's entirely possible that the kernel can be in a situation where it can't guarantee to get a buffer large

Possible bug in netlink_recvmsg()

2007-04-13 Thread David Howells
As I understand it, according to the recvmsg() manual page, if the packet being returned is larger than the buffer provided, and the protocol does not support piecemeal reception of data, then: (1) the buffer should be filled, (2) MSG_TRUNC should be set in msg_flags, and (3) the length of

[PATCH] AF_NETLINK: Support MSG_TRUNC passed to recvmsg()

2007-04-13 Thread David Howells
on netlink sockets as recvmsg() there just discards any of the packet that won't fit in the buffer. Signed-Off-By: David Howells [EMAIL PROTECTED] --- net/netlink/af_netlink.c | 15 +-- 1 files changed, 9 insertions(+), 6 deletions(-) diff --git a/net/netlink/af_netlink.c b/net/netlink

Re: [PATCH] CONFIG_PACKET_MMAP should depend on MMU

2007-04-17 Thread David Howells
Robin Getz [EMAIL PROTECTED] wrote: David - Does this give you what you need? Possibly. I'll have a look at it tomorrow. David - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [PATCH] CONFIG_PACKET_MMAP should depend on MMU

2007-04-18 Thread David Howells
-mode. David --- [PATCH] NOMMU: Support mmap() on AF_PACKET sockets From: David Howells [EMAIL PROTECTED] Support mmap() on AF_PACKET sockets in NOMMU-mode kernels. Signed-Off-By: David Howells [EMAIL PROTECTED] --- include/linux/net.h|7 +++ include/net/sock.h |8 +++ net/core

Re: [PATCH] CONFIG_PACKET_MMAP should depend on MMU

2007-04-19 Thread David Howells
Aubrey Li [EMAIL PROTECTED] wrote: Yes, it's reasonable for me, as long as your host IP is 192.168.2.128 and target IP is 192.168.2.141 That is correct, yes:-) I expect it's an NFS packet as my board is using an NFS root at the moment. David - To unsubscribe from this list:

Getting the new RxRPC patches upstream

2007-04-19 Thread David Howells
Eric W. Biederman [EMAIL PROTECTED] wrote: What is the ETA on your patches? That depends on Dave Miller now, I think. I'm assuming they need to go through the network GIT tree to get to Linus. Certainly Andrew Morton seems to think so. David - To unsubscribe from this list: send the line

Re: Possible bug in netlink_recvmsg()

2007-04-19 Thread David Howells
David Miller [EMAIL PROTECTED] wrote: See this fix in my net-2.6.22 tree: commit ad495d7b6cfcd1bc2eaf06c42699be0bb5d84234 Author: David S. Miller [EMAIL PROTECTED] Date: Tue Mar 6 17:02:35 2007 -0800 Ummm... That seems to conflict with something in your net-2.6 tree. Which one should I

Re: Getting the new RxRPC patches upstream

2007-04-19 Thread David Howells
Eric W. Biederman [EMAIL PROTECTED] wrote: Ok. I don't see any patches in -mm so I was assuming these patches have not been queued up anywhere. They haven't been quite yet. Is it your intention to kill these features in 2.6.22? David - To unsubscribe from this list: send the line

Re: [PATCH] CONFIG_PACKET_MMAP should depend on MMU

2007-04-20 Thread David Howells
Aubrey Li [EMAIL PROTECTED] wrote: The patch works properly on my side. But 1) I'm not sure why you re-wrote alloc/free_pg_vec function, doesn't the current implement work for NOMMU? I know you want to allocate the entire data buffer as one contiguous lump, but is it really necessary? Yes.

Re: Getting the new RxRPC patches upstream

2007-04-20 Thread David Howells
David Miller [EMAIL PROTECTED] wrote: I applied already the patches I thought were appropriate, you had some crypto layer changes that you need to work out with Herbert Xu before the rest can be applied. Should the rest of it go via Andrew's tree then? David - To unsubscribe from this list:

Re: [PATCH] CONFIG_PACKET_MMAP should depend on MMU

2007-04-20 Thread David Howells
Aubrey Li [EMAIL PROTECTED] wrote: as checked in packet_set_ring, buffer size must be a multiple of PAGE_SIZE, packet_set_ring if (unlikely(req-tp_block_size (PAGE_SIZE - 1))) So why not use __get_free_pages rather than kmalloc, Because

Re: Getting the new RxRPC patches upstream

2007-04-20 Thread David Howells
David Miller [EMAIL PROTECTED] wrote: Now that Herbert cleared up the crypto layer issues the only problem left is that there are generic changes in there which are not strictly networking but which your subsequent networking changes depend upon. This is a mess, and makes merging your work

Re: [PATCH] CONFIG_PACKET_MMAP should depend on MMU

2007-04-20 Thread David Howells
Eric Dumazet [EMAIL PROTECTED] wrote: Is it really possible to allocate an order-10 page, then release part of it (say an order-8 subpage) ? Yes. David - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: Getting the new RxRPC patches upstream

2007-04-23 Thread David Howells
We only care when del_timer() returns true. In that case, if the timer function still runs (possible for single-threaded wqs), it has already passed __queue_work(). Why do you assume that? David - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to

Re: Getting the new RxRPC patches upstream

2007-04-24 Thread David Howells
Oleg Nesterov [EMAIL PROTECTED] wrote: We only care when del_timer() returns true. In that case, if the timer function still runs (possible for single-threaded wqs), it has already passed __queue_work(). Why do you assume that? Sorry, I should have been more clear. I meant the

Re: Getting the new RxRPC patches upstream

2007-04-24 Thread David Howells
Oleg Nesterov [EMAIL PROTECTED] wrote: The current code uses del_timer_sync(). It will also return 0. However, it will spin waiting for timer-function() to complete. So we are just wasting CPU. That's my objection to using cancel_delayed_work() as it stands, although in most cases

Re: Getting the new RxRPC patches upstream

2007-04-24 Thread David Howells
Oleg Nesterov [EMAIL PROTECTED] wrote: Sure, I'll grep for cancel_delayed_work(). But unless I missed something, this change should be completely transparent for all users. Otherwise, it is buggy. I guess you will have to make sure that cancel_delayed_work() is always followed by a flush of

Re: Getting the new RxRPC patches upstream

2007-04-25 Thread David Howells
Oleg Nesterov [EMAIL PROTECTED] wrote: Yes sure. Note that this is documented: /* * Kill off a pending schedule_delayed_work(). Note that the work callback * function may still be running on return from cancel_delayed_work(). Run * flush_workqueue() or

Re: Getting the new RxRPC patches upstream

2007-04-25 Thread David Howells
Oleg Nesterov [EMAIL PROTECTED] wrote: Ah yes, it says nothing about what the returned value means... Yeah... If you could amend that as part of your patch, that'd be great. David - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED]

[PATCH 00/16] AF_RXRPC socket family and AFS rewrite [try #3]

2007-04-25 Thread David Howells
The first of these patches together provide secure client-side RxRPC connectivity as a Linux kernel socket family. Only the RxRPC transport/session side is supplied - the presentation side (marshalling the data) is left to the client. Copies of the patches can be found here:

[PATCH 03/16] AF_RXRPC: Key facility changes for AF_RXRPC [try #3]

2007-04-25 Thread David Howells
-Off-By: David Howells [EMAIL PROTECTED] --- Documentation/keys.txt | 12 include/linux/key.h |2 ++ security/keys/keyring.c |2 ++ 3 files changed, 16 insertions(+), 0 deletions(-) diff --git a/Documentation/keys.txt b/Documentation/keys.txt index 60c665d..81d9aa0

[PATCH 01/16] AF_RXRPC: Move generic skbuff stuff from XFRM code to generic code [try #3]

2007-04-25 Thread David Howells
Move generic skbuff stuff from XFRM code to generic code so that AF_RXRPC can use it too. The kdoc comments I've attached to the functions needs to be checked by whoever wrote them as I had to make some guesses about the workings of these functions. Signed-Off-By: David Howells [EMAIL PROTECTED

[PATCH 02/16] cancel_delayed_work: use del_timer() instead of del_timer_sync() [try #3]

2007-04-25 Thread David Howells
-By: David Howells [EMAIL PROTECTED] --- include/linux/workqueue.h |7 --- 1 files changed, 4 insertions(+), 3 deletions(-) diff --git a/include/linux/workqueue.h b/include/linux/workqueue.h index 2a7b38d..b8abfc7 100644 --- a/include/linux/workqueue.h +++ b/include/linux/workqueue.h

[PATCH 10/16] AFS: Handle multiple mounts of an AFS superblock correctly [try #3]

2007-04-25 Thread David Howells
from sb-s_flags. Signed-Off-By: David Howells [EMAIL PROTECTED] --- fs/afs/super.c | 26 -- 1 files changed, 16 insertions(+), 10 deletions(-) diff --git a/fs/afs/super.c b/fs/afs/super.c index efc4fe6..77e6875 100644 --- a/fs/afs/super.c +++ b/fs/afs/super.c @@ -212,7

[PATCH 13/16] commit ad495d7b6cfcd1bc2eaf06c42699be0bb5d84234 [try #3]

2007-04-25 Thread David Howells
[NETLINK]: Mirror UDP MSG_TRUNC semantics. If the user passes MSG_TRUNC in via msg_flags, return the full packet size not the truncated size. Idea from Herbert Xu and Thomas Graf. Signed-off-by: David S. Miller [EMAIL PROTECTED] --- net/netlink/af_netlink.c |3 +++ 1 files

[PATCH 15/16] AFS: Implement the CB.InitCallBackState3 operation [try #3]

2007-04-25 Thread David Howells
Implement the CB.InitCallBackState3 operation for the fileserver to call. This reduces the amount of network traffic because if this op is aborted, the fileserver will then attempt an CB.InitCallBackState operation. Signed-Off-By: David Howells [EMAIL PROTECTED] --- fs/afs/AFS_CM.h|1

[PATCH 14/16] AFS: Add support for the CB.GetCapabilities operation [try #3]

2007-04-25 Thread David Howells
through all the network interfaces using RTNETLINK to pull out the MAC address of the lowest index interface to use in UUID construction. Signed-Off-By: David Howells [EMAIL PROTECTED] --- fs/afs/AFS_CM.h|3 fs/afs/Makefile|1 fs/afs/cmservice.c | 98

[PATCH 12/16] AFS: Update the AFS fs documentation [try #3]

2007-04-25 Thread David Howells
Update the AFS fs documentation. Signed-Off-By: David Howells [EMAIL PROTECTED] --- Documentation/filesystems/afs.txt | 214 +++-- 1 files changed, 154 insertions(+), 60 deletions(-) diff --git a/Documentation/filesystems/afs.txt b/Documentation/filesystems

Re: [PATCH 00/16] AF_RXRPC socket family and AFS rewrite [try #3]

2007-04-25 Thread David Howells
Andrew Morton [EMAIL PROTECTED] wrote: I'm ducking all feature and cleanup patches now, and probably shall continue to do so for some weeks. The priority (which I believe to be increasingly urgent) is to fix the 2.6.21 regressions and to stabilise the things which we presently have queued

Re: Getting the new RxRPC patches upstream

2007-04-25 Thread David Howells
David Miller [EMAIL PROTECTED] wrote: Is it possible for your changes to be purely networking and not need those changes outside of the networking? See my latest patchset release. I've reduced the dependencies on non-networking changes to: (1) Oleg Nesterov's patch to change

[PATCH 00/16] AF_RXRPC socket family and AFS rewrite [try #4]

2007-04-25 Thread David Howells
The first of these patches together provide secure client-side RxRPC connectivity as a Linux kernel socket family. Only the RxRPC transport/session side is supplied - the presentation side (marshalling the data) is left to the client. Copies of the patches can be found here:

[PATCH 02/16] cancel_delayed_work: use del_timer() instead of del_timer_sync() [try #4]

2007-04-25 Thread David Howells
-By: David Howells [EMAIL PROTECTED] --- include/linux/workqueue.h |7 --- 1 files changed, 4 insertions(+), 3 deletions(-) diff --git a/include/linux/workqueue.h b/include/linux/workqueue.h index 2a7b38d..b8abfc7 100644 --- a/include/linux/workqueue.h +++ b/include/linux/workqueue.h

[PATCH 01/16] AF_RXRPC: Move generic skbuff stuff from XFRM code to generic code [try #4]

2007-04-25 Thread David Howells
Move generic skbuff stuff from XFRM code to generic code so that AF_RXRPC can use it too. The kdoc comments I've attached to the functions needs to be checked by whoever wrote them as I had to make some guesses about the workings of these functions. Signed-Off-By: David Howells [EMAIL PROTECTED

[PATCH 03/16] AF_RXRPC: Key facility changes for AF_RXRPC [try #4]

2007-04-25 Thread David Howells
-Off-By: David Howells [EMAIL PROTECTED] --- Documentation/keys.txt | 12 include/linux/key.h |2 ++ security/keys/keyring.c |2 ++ 3 files changed, 16 insertions(+), 0 deletions(-) diff --git a/Documentation/keys.txt b/Documentation/keys.txt index 60c665d..81d9aa0

[PATCH 10/16] AFS: Handle multiple mounts of an AFS superblock correctly [try #4]

2007-04-25 Thread David Howells
from sb-s_flags. Signed-Off-By: David Howells [EMAIL PROTECTED] --- fs/afs/super.c | 26 -- 1 files changed, 16 insertions(+), 10 deletions(-) diff --git a/fs/afs/super.c b/fs/afs/super.c index efc4fe6..77e6875 100644 --- a/fs/afs/super.c +++ b/fs/afs/super.c @@ -212,7

[PATCH 15/16] AFS: Implement the CB.InitCallBackState3 operation [try #4]

2007-04-25 Thread David Howells
Implement the CB.InitCallBackState3 operation for the fileserver to call. This reduces the amount of network traffic because if this op is aborted, the fileserver will then attempt an CB.InitCallBackState operation. Signed-Off-By: David Howells [EMAIL PROTECTED] --- fs/afs/afs_cm.h|1

[PATCH 13/16] commit ad495d7b6cfcd1bc2eaf06c42699be0bb5d84234 [try #4]

2007-04-25 Thread David Howells
[NETLINK]: Mirror UDP MSG_TRUNC semantics. If the user passes MSG_TRUNC in via msg_flags, return the full packet size not the truncated size. Idea from Herbert Xu and Thomas Graf. Signed-off-by: David S. Miller [EMAIL PROTECTED] --- net/netlink/af_netlink.c |3 +++ 1 files

[PATCH 14/16] AFS: Add support for the CB.GetCapabilities operation [try #4]

2007-04-25 Thread David Howells
through all the network interfaces using RTNETLINK to pull out the MAC address of the lowest index interface to use in UUID construction. Signed-Off-By: David Howells [EMAIL PROTECTED] --- fs/afs/Makefile|1 fs/afs/afs_cm.h|3 fs/afs/cmservice.c | 98

[PATCH 12/16] AFS: Update the AFS fs documentation [try #4]

2007-04-25 Thread David Howells
Update the AFS fs documentation. Signed-Off-By: David Howells [EMAIL PROTECTED] --- Documentation/filesystems/afs.txt | 214 +++-- 1 files changed, 154 insertions(+), 60 deletions(-) diff --git a/Documentation/filesystems/afs.txt b/Documentation/filesystems

[PATCH 04/16] AF_RXRPC: Make it possible to merely try to cancel timers from a module [try #4]

2007-04-25 Thread David Howells
Export try_to_del_timer_sync() for use by the AF_RXRPC module. Signed-Off-By: David Howells [EMAIL PROTECTED] --- kernel/timer.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/kernel/timer.c b/kernel/timer.c index dd6c2c1..b22bd39 100644 --- a/kernel/timer.c +++ b

Re: [PATCH 00/16] AF_RXRPC socket family and AFS rewrite [try #3]

2007-04-25 Thread David Howells
David Miller [EMAIL PROTECTED] wrote: Then please generate your patches against my net-2.6.21 GIT tree. Most of your initial patches in the series (the SKB routine one for example) are already in my tree. Do you mean your net-2.6.22 GIT tree? Do you want me to make it available as a GIT

Transforming code to using ICMP packet accessors

2007-04-26 Thread David Howells
How do I convert: addr = *(__be32 *)(skb-nh.raw + serr-addr_offset); to use the ICMP accessor macros now that skb-nh is no longer available? I was using this to pluck an address out of the ICMP packet payload, but void rxrpc_UDP_error_report(struct sock *sk) {

Re: Transforming code to using ICMP packet accessors

2007-04-26 Thread David Howells
Arnaldo Carvalho de Melo [EMAIL PROTECTED] wrote: Yes, as this is the only use in this function. Thanks! David - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH 01/14] cancel_delayed_work: use del_timer() instead of del_timer_sync() [net-2.6]

2007-04-26 Thread David Howells
-By: David Howells [EMAIL PROTECTED] --- include/linux/workqueue.h |7 --- 1 files changed, 4 insertions(+), 3 deletions(-) diff --git a/include/linux/workqueue.h b/include/linux/workqueue.h index 2a7b38d..b8abfc7 100644 --- a/include/linux/workqueue.h +++ b/include/linux/workqueue.h

[PATCH 00/14] AF_RXRPC socket family and AFS rewrite [net-2.6]

2007-04-26 Thread David Howells
[This set of patches is built against Dave Miller's net-2.6 GIT tree] The first of these patches together provide secure client-side RxRPC connectivity as a Linux kernel socket family. Only the RxRPC transport/session side is supplied - the presentation side (marshalling the data) is left to

[PATCH 02/14] AF_RXRPC: Key facility changes for AF_RXRPC [net-2.6]

2007-04-26 Thread David Howells
-Off-By: David Howells [EMAIL PROTECTED] --- Documentation/keys.txt | 12 include/linux/key.h |2 ++ security/keys/keyring.c |2 ++ 3 files changed, 16 insertions(+), 0 deletions(-) diff --git a/Documentation/keys.txt b/Documentation/keys.txt index 60c665d..81d9aa0

[PATCH 03/14] AF_RXRPC: Make it possible to merely try to cancel timers from a module [net-2.6]

2007-04-26 Thread David Howells
Export try_to_del_timer_sync() for use by the AF_RXRPC module. Signed-Off-By: David Howells [EMAIL PROTECTED] --- kernel/timer.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/kernel/timer.c b/kernel/timer.c index dd6c2c1..b22bd39 100644 --- a/kernel/timer.c +++ b

[PATCH 09/14] AFS: Handle multiple mounts of an AFS superblock correctly [net-2.6]

2007-04-26 Thread David Howells
from sb-s_flags. Signed-Off-By: David Howells [EMAIL PROTECTED] --- fs/afs/super.c | 26 -- 1 files changed, 16 insertions(+), 10 deletions(-) diff --git a/fs/afs/super.c b/fs/afs/super.c index efc4fe6..77e6875 100644 --- a/fs/afs/super.c +++ b/fs/afs/super.c @@ -212,7

[PATCH 11/14] AFS: Update the AFS fs documentation [net-2.6]

2007-04-26 Thread David Howells
Update the AFS fs documentation. Signed-Off-By: David Howells [EMAIL PROTECTED] --- Documentation/filesystems/afs.txt | 214 +++-- 1 files changed, 154 insertions(+), 60 deletions(-) diff --git a/Documentation/filesystems/afs.txt b/Documentation/filesystems

[PATCH 12/14] AFS: Add support for the CB.GetCapabilities operation [net-2.6]

2007-04-26 Thread David Howells
through all the network interfaces using RTNETLINK to pull out the MAC address of the lowest index interface to use in UUID construction. Signed-Off-By: David Howells [EMAIL PROTECTED] --- fs/afs/Makefile|1 fs/afs/afs_cm.h|3 fs/afs/cmservice.c | 98

[PATCH 13/14] AFS: Implement the CB.InitCallBackState3 operation [net-2.6]

2007-04-26 Thread David Howells
Implement the CB.InitCallBackState3 operation for the fileserver to call. This reduces the amount of network traffic because if this op is aborted, the fileserver will then attempt an CB.InitCallBackState operation. Signed-Off-By: David Howells [EMAIL PROTECTED] --- fs/afs/afs_cm.h|1

  1   2   3   4   5   6   7   8   9   >