Re: [PATCH RFC 19/28] net: dsa: bcm_sf2: make it a real platform driver

Hi Andrew, Le 23/12/2015 04:56, Andrew Lunn a écrit : > diff --git a/Documentation/devicetree/bindings/net/dsa/broadcom.txt > b/Documentation/devicetree/bindings/net/dsa/broadcom.txt > new file mode 100644 > index ..bd92be0ef2c8 > --- /dev/null > +++

Re: [PATCH RFC 21/28] net: dsa: Add some debug prints for error cases

Le 23/12/2015 04:56, Andrew Lunn a écrit : > Due to the complexity it can be hard to know why DSA fails to probe. > Add some debug prints for the common error cases. > > Signed-off-by: Andrew Lunn <and...@lunn.ch> Acked-by: Florian Fainelli <f.faine...@gmail.com> I ha

Re: [PATCH RFC 12/28] net: dsa: Make dsa,mii-bus optional

Le 23/12/2015 04:56, Andrew Lunn a écrit : > When all the switches are devices and register to the DSA framework, > having a dsa,mii-bus property is not required. > > Signed-off-by: Andrew Lunn <and...@lunn.ch> Acked-by: Florian Fainelli <f.faine...@gmail.com> -- Floria

Re: [PATCH RFC 06/28] net: dsa: Have the switch driver allocate there own private memory

= devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL); > + if (!priv) > + return -ENOMEM; This looks fine overall, except that part, there is an earlier priv = ds_to_priv() in the function so we might be missing a ds->priv = priv here once the allocation is successful. With t

Re: [PATCH RFC 07/28] net: dsa: Remove allocation of driver private memory

Le 23/12/2015 04:56, Andrew Lunn a écrit : > The drivers now allocate their own memory for private usage. Remove > the allocation from the core code. > > Signed-off-by: Andrew Lunn <and...@lunn.ch> Acked-by: Florian Fainelli <f.faine...@gmail.com> -- Florian -- To un

Re: [PATCH RFC 08/28] net: dsa: Keep the mii bus and address in the private structure

Le 23/12/2015 04:56, Andrew Lunn a écrit : > Rather than looking up the mii bus and address every time, do it once > and setup, and keep it in the private structure. > > Signed-off-by: Andrew Lunn <and...@lunn.ch> Acked-by: Florian Fainelli <f.faine...@gmail.com> -- F

Re: [PATCH RFC 25/28] Documentation: DSA: Describe how probe of DSA and switches work.

Le 23/12/2015 04:56, Andrew Lunn a écrit : > With the introduction of switches as linux devices and the use of the > component framework, probing has become more complex. Add some > documentation. > > Signed-off-by: Andrew Lunn > --- > Documentation/networking/dsa/dsa.txt | 48

Re: [PATCH RFC 24/28] net: dsa: If a switch fails to probe, defer probing

<and...@lunn.ch> Acked-by: Florian Fainelli <f.faine...@gmail.com> -- Florian -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH net-next] net: phy: bcm7xxx: Add entry for Broadcom BCM7435

Add a PHY entry for the Broadcom BCM7435 chips, this is a 40nm generation Ethernet PHY which is analogous to its 7425 and 7429 counter parts. Signed-off-by: Florian Fainelli <f.faine...@gmail.com> --- drivers/net/phy/bcm7xxx.c | 14 ++ include/linux/brcmphy.h | 1 + 2

[PATCH net-next] MAINTAINERS: PHY: Change maintainer to reviewer

Now that there is a reviewer role, add myself as reviewer since the PHY library code is maintained via the networking tree. Signed-off-by: Florian Fainelli <f.faine...@gmail.com> --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS

Re: bridge-utils: wrong sysfs path odds

On 25/11/15 01:21, Richard Weinberger wrote: > Am 25.11.2015 um 01:37 schrieb Stephen Hemminger: >> On Wed, 25 Nov 2015 01:24:47 +0100 >> Richard Weinberger wrote: >> >>> Am 25.11.2015 um 01:15 schrieb Richard Weinberger: Hi! Today I was hunting down an issue where

Re: [PATCH net-next] MAINTAINERS: PHY: Change maintainer to reviewer

On 25/11/15 08:36, David Miller wrote: > From: Joe Perches <j...@perches.com> > Date: Tue, 24 Nov 2015 17:04:11 -0800 > >> On Tue, 2015-11-24 at 15:29 -0800, Florian Fainelli wrote: >>> Now that there is a reviewer role, add myself as reviewer since the PHY >

Re: [PATCH 00/13] mvneta Buffer Management and enhancements

On 21/11/15 23:53, Marcin Wojtas wrote: > > 4. Buffer manager (BM) support with two preparatory commits. As it is a > separate block, common for all network ports, a new driver is introduced, > which configures it and exposes API to the main network driver. It is > throughly described in binding

Re: [RFC 2/8] net-next: phy: dont auto handle carrier state when multiple phys are attached

for the same reasons? > > Signed-off-by: John Crispin <blo...@openwrt.org> > Signed-off-by: Felix Fietkau <n...@openwrt.org> > Signed-off-by: Michael Lee <igv...@gmail.com> > Cc: Florian Fainelli <f.faine...@gmail.com> > --- > drivers/net/phy/phy.c |9

Re: [PATCH net-next 2/2] dsa: mv88e6xxx.c: Hardware reset the chip if available

On 18/11/15 15:29, Andrew Lunn wrote: > The device tree binding now allows a gpio to be specified which is > attached to the switch chips reset line. If it is defined, perform > a hardware reset on the switch during setup. > > Signed-off-by: Andrew Lunn > --- >

Re: [PATCH] net: tulip: turn compile-time warning into dev_warn()

On 19/11/15 04:26, Will Deacon wrote: > On Thu, Nov 19, 2015 at 11:42:26AM +0100, Arnd Bergmann wrote: >> The tulip driver causes annoying build-time warnings for allmodconfig >> builds for all recent architectures: >> >> dec/tulip/winbond-840.c:910:2: warning: #warning Processor architecture >>

Re: [PATCH] net: tulip: update MAINTAINER status to Orphan

On 19/11/15 17:56, Grant Grundler wrote: > From: Grant Grundler > > I haven't had any PCI tulip HW for the past ~5 years. I have > been reviewing tulip patches and can continue doing that. > > Signed-off-by: Grant Grundler > --- > I'm also

Re: [PATCH net-next 01/17] net: dsa: slave: chip data is optional, don't dereference NULL

lunn.ch> Reviewed-by: Florian Fainelli <f.faine...@gmail.com> -- Florian

Re: [PATCH net-next 03/17] net: dsa: slave: Remove MDIO address from switch MDIO bus name

. The switch index is sufficient to make the > name unique, so drop the MDIO address. > > Signed-off-by: Andrew Lunn <and...@lunn.ch> Reviewed-by: Florian Fainelli <f.faine...@gmail.com> -- Florian

[PATCH net-next 2/2] bgmac: Add support for ethtool statistics

Read the statistics from the BGMAC's builtin MAC and return them to user-space using the standard ethtool helpers. Signed-off-by: Florian Fainelli <f.faine...@gmail.com> --- drivers/net/ethernet/broadcom/bgmac.c | 125 ++ drivers/net/ethernet/broadcom/b

[PATCH net-next 1/2] bgmac: Bind net_device with backing device structure

In preparation for allowing different helpers to be utilized against network devices created by the bgmac driver, make sure that we bind the net_device with core->dev. Signed-off-by: Florian Fainelli <f.faine...@gmail.com> --- drivers/net/ethernet/broadcom/bgmac.c | 1 + 1 file c

[PATCH net-next 0/2] net: bgmac: Misc improvements

is useful for debugging Thanks Florian Fainelli (2): bgmac: Bind net_device with backing device structure bgmac: Add support for ethtool statistics drivers/net/ethernet/broadcom/bgmac.c | 126 ++ drivers/net/ethernet/broadcom/bgmac.h | 4 +- 2 files changed, 128

Re: [PATCH net-next 2/2] bgmac: Add support for ethtool statistics

On 06/03/2016 10:57 AM, Ben Hutchings wrote: > On Fri, 2016-06-03 at 10:07 -0700, Florian Fainelli wrote: > [...] >> +static void bgmac_get_strings(struct net_device *dev, u32 stringset, >> + u8 *data) >> +{ >> +int i; >> + &

Re: [PATCH net-next 04/17] net: dsa: tag_{e}dsa.c: Remove dependency on platform data

nding allows holes in the dst->ds[] array, > so also ensure ensure there is a valid dsa_switch for this packet. > > Signed-off-by: Andrew Lunn <and...@lunn.ch> Reviewed-by: Florian Fainelli <f.faine...@gmail.com> -- Florian

Re: [PATCH net-next 11/17] net: dsa: Refactor selection of tag ops into a function

by: Andrew Lunn <and...@lunn.ch> Reviewed-by: Florian Fainelli <f.faine...@gmail.com> -- Florian

Re: [PATCH net-next 00/17] New DSA bind, switches as devices

, but a quick smoke test here on a BCM7445 with bcm_sf2 gives me all thumbs up. Tested-by: Florian Fainelli <f.faine...@gmail.com> Thanks! > > Since RFC: > > * Split the mv88e6xxx MDIO refactor into a rename patch and a refactor > patch. > * Extend commit message with comm

Re: [PATCH net-next 05/17] net: dsa: Add a ports structure and use it in the switch structure

On 06/03/2016 09:44 AM, Andrew Lunn wrote: > There are going to be more per-port members added to the switch > structure. So add a port structure and move the netdev into it. > > Signed-off-by: Andrew Lunn <and...@lunn.ch> Reviewed-by: Florian Fainelli <f.faine...@gmail.com> -- Florian

Re: [PATCH net-next 06/17] net: dsa: Move port device node into port structure

f-by: Andrew Lunn <and...@lunn.ch> Reviewed-by: Florian Fainelli <f.faine...@gmail.com> -- Florian

Re: [PATCH net-next 09/17] net: dsa: Split up creating/destroying of DSA and CPU ports

put the of node. They should be released at the end > along with the normal ports. > > Signed-off-by: Andrew Lunn <and...@lunn.ch> Reviewed-by: Florian Fainelli <f.faine...@gmail.com> -- Florian

Re: [PATCH net-next 08/17] net: dsa: Copy the routing table into the switch structure

ff-by: Andrew Lunn <and...@lunn.ch> Reviewed-by: Florian Fainelli <f.faine...@gmail.com> -- Florian

Re: [PATCH net-next 10/17] net: dsa: mv88e6xxx: Only support EDSA tagging

On 06/03/2016 09:44 AM, Andrew Lunn wrote: > The merged driver no longer offers the option to use DSA tagging. So > remove the code to setup the switch to do DSA tagging and hard code > the use of EDSA. > > Signed-off-by: Andrew Lunn <and...@lunn.ch> Reviewed-by: Flor

Re: [PATCH net-next 02/17] net: dsa: mv88e6xxx: fix circular lock in PPU work

; r5:9f5f2e80 r4:9e5e9cb0 > [4.816910] [<8013a5ec>] (process_one_work) from [<8013ac54>] > (worker_thread+0x64/0x528) > [4.825010] r10:9f5f2e80 r9:0008 r8:80e0dc80 r7:80e0a1fc > r6:80e0a1c8 r5:9f5f2e98 > [4.832933] r4:80e0a1c8 > [4.835510] [<8013abf0>] (worker_thread) from [<801409e8>] > (kthread+0xec/0x100) > [4.842827] r10: r9: r8: r7:8013abf0 > r6:9f5f2e80 r5:9ec15740 > [4.850749] r4: > [4.853327] [<801408fc>] (kthread) from [<80108f30>] > (ret_from_fork+0x14/0x24) > [4.860557] r7: r6: r5:801408fc r4:9ec15740 > > Signed-off-by: Vivien Didelot <vivien.dide...@savoirfairelinux.com> Reviewed-by: Florian Fainelli <f.faine...@gmail.com> -- Florian

Re: [PATCH net-next 07/17] net: dsa: Remove dynamic allocate of routing table

On 06/03/2016 09:44 AM, Andrew Lunn wrote: > With a maximum of four switches, the size of the routing table is the > same as the pointer to it. Removing it makes the code simpler. > > Signed-off-by: Andrew Lunn <and...@lunn.ch> Reviewed-by: Florian Fainelli <f.faine...@gmail.com> -- Florian

Re: [PATCH net-next 15/17] net: dsa: Add new binding implementation

al, and does not really represent hardware. > > Implement a new binding which can be embedded into any type of node on > a bus to represent one switch device, and its links to other switches. > > Signed-off-by: Andrew Lunn <and...@lunn.ch> > Signed-off-by: Florian Fainelli <

[PATCH net-next v4 0/6] net: dsa: misc improvements

e right place and right time (ethtool ops, slave MDIO bus - fixed a few typos here and there Changes in v4: - removed superfluous dst agrument to dsa_cpu_port_ethtool_{setup,restore} Florian Fainelli (6): net: dsa: Provide unique DSA slave MII bus names net: dsa: Initialize ds->enabled_

[PATCH net-next v4 4/6] net: dsa: Add initialization helper for CPU port ethtool_ops

ide...@savoirfairelinux.com> Signed-off-by: Florian Fainelli <f.faine...@gmail.com> --- net/dsa/dsa_priv.h | 1 + net/dsa/slave.c| 14 -- 2 files changed, 9 insertions(+), 6 deletions(-) diff --git a/net/dsa/dsa_priv.h b/net/dsa/dsa_priv.h index b42f1a5f95f3..106a9f067f94 100644 --- a/net/ds

[PATCH net-next v4 3/6] net: dsa: Provide a slave MII bus if needed

Mimic what net/dsa/dsa.c does and provide a slave MII bus by default which will be created if the driver implements a phy_read method. Reviewed-by: Andrew Lunn <and...@lunn.ch> Reviewed-by: Vivien Didelot <vivien.dide...@savoirfairelinux.com> Signed-off-by: Florian Fainelli <f.fai

[PATCH net-next v4 2/6] net: dsa: Initialize ds->enabled_port_mask and ds->phys_mii_mask

Some drivers rely on these two bitmasks to contain the correct values for them to successfully probe and initialize at drv->setup() time, calculate correct values to put in both masks as early as possible in dsa_get_ports_dn(). Reviewed-by: Andrew Lunn <and...@lunn.ch> Signed-off-by

[PATCH net-next v4 1/6] net: dsa: Provide unique DSA slave MII bus names

In case we have multiples trees and switches with the same index, we need to add another discriminating id: the switch tree. Reviewed-by: Andrew Lunn <and...@lunn.ch> Reviewed-by: Vivien Didelot <vivien.dide...@savoirfairelinux.com> Signed-off-by: Florian Fainelli <f.faine...@gmai

[PATCH net-next v4 6/6] net: dsa: bcm_sf2: Register our slave MDIO bus

;vivien.dide...@savoirfairelinux.com> Signed-off-by: Florian Fainelli <f.faine...@gmail.com> --- drivers/net/dsa/bcm_sf2.c | 215 +- drivers/net/dsa/bcm_sf2.h | 6 ++ 2 files changed, 140 insertions(+), 81 deletions(-) diff --git a/drivers/net/dsa/bcm_sf

[PATCH net-next v4 5/6] net: dsa: Initialize CPU port ethtool ops per tree

the Ethernet driver) Signed-off-by: Florian Fainelli <f.faine...@gmail.com> --- include/net/dsa.h | 1 + net/dsa/dsa.c | 41 + net/dsa/dsa2.c | 6 ++ net/dsa/dsa_priv.h | 2 ++ net/dsa/slave.c| 10 -- 5 files chang

Re: [PATCH net-next v2 5/5] net: dsa: bcm_sf2: Register our slave MDIO bus

On 06/07/2016 12:11 PM, Vivien Didelot wrote: > Hi Andrew, > > Andrew Lunn writes: > With the legacy interface it is tricky. When would you call such a remove/tairdown function when using the old binding? >>> >>> That'd go in dsa_switch_destroy I guess, but it just

[PATCH net-next v3 6/6] net: dsa: bcm_sf2: Register our slave MDIO bus

;vivien.dide...@savoirfairelinux.com> Signed-off-by: Florian Fainelli <f.faine...@gmail.com> --- drivers/net/dsa/bcm_sf2.c | 215 +- drivers/net/dsa/bcm_sf2.h | 6 ++ 2 files changed, 140 insertions(+), 81 deletions(-) diff --git a/drivers/net/dsa/bcm_sf

[PATCH net-next v3 5/6] net: dsa: Initialize CPU port ethtool ops per tree

the Ethernet driver) Signed-off-by: Florian Fainelli <f.faine...@gmail.com> --- include/net/dsa.h | 1 + net/dsa/dsa.c | 43 +++ net/dsa/dsa2.c | 6 ++ net/dsa/dsa_priv.h | 4 net/dsa/slave.c| 10 -- 5 files chang

[PATCH net-next v3 0/6] net: dsa: misc improvements

e right place and right time (ethtool ops, slave MDIO bus - fixed a few typos here and there Florian Fainelli (6): net: dsa: Provide unique DSA slave MII bus names net: dsa: Initialize ds->enabled_port_mask and ds->phys_mii_mask net: dsa: Provide a slave MII bus if needed net: dsa:

[PATCH net-next v3 2/6] net: dsa: Initialize ds->enabled_port_mask and ds->phys_mii_mask

Some drivers rely on these two bitmasks to contain the correct values for them to successfully probe and initialize at drv->setup() time, calculate correct values to put in both masks as early as possible in dsa_get_ports_dn(). Signed-off-by: Florian Fainelli <f.faine...@gmail.com> ---

[PATCH net-next v3 1/6] net: dsa: Provide unique DSA slave MII bus names

In case we have multiples trees and switches with the same index, we need to add another discriminating id: the switch tree. Reviewed-by: Andrew Lunn <and...@lunn.ch> Reviewed-by: Vivien Didelot <vivien.dide...@savoirfairelinux.com> Signed-off-by: Florian Fainelli <f.faine...@gmai

[PATCH net-next v3 3/6] net: dsa: Provide a slave MII bus if needed

Mimic what net/dsa/dsa.c does and provide a slave MII bus by default which will be created if the driver implements a phy_read method. Signed-off-by: Florian Fainelli <f.faine...@gmail.com> --- net/dsa/dsa2.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/net/dsa/ds

[PATCH net-next v3 4/6] net: dsa: Add initialization helper for CPU port ethtool_ops

Add a helper function: dsa_cpu_port_ethtool_init() which initializes a custom ethtool_ops structure with custom DSA ethtool operations for CPU ports. This is a preliminary change to move the initialization outside of net/dsa/slave.c. Signed-off-by: Florian Fainelli <f.faine...@gmail.com> --

[PATCH net-next v2 1/3] bgmac: Bind net_device with backing device structure

In preparation for allowing different helpers to be utilized against network devices created by the bgmac driver, make sure that we bind the net_device with core->dev. Signed-off-by: Florian Fainelli <f.faine...@gmail.com> --- drivers/net/ethernet/broadcom/bgmac.c | 1 + 1 file c

[PATCH net-next v2 2/3] bgmac: Add support for ethtool statistics

Read the statistics from the BGMAC's builtin MAC and return them to user-space using the standard ethtool helpers. Signed-off-by: Florian Fainelli <f.faine...@gmail.com> --- Changes in v2: - use strlcpy() - properly fix the latching of the hi/lo reads - remove redundant cast drive

[PATCH net-next v2 0/3] net: bgmac: Misc improvements

is useful for debugging - add netdev statistics throughout the TX/RX path to know what is going on Thanks Florian Fainelli (3): bgmac: Bind net_device with backing device structure bgmac: Add support for ethtool statistics bgmac: Maintain some netdev statistics drivers/net/ethernet/broadcom

[PATCH net-next v2 3/3] bgmac: Maintain some netdev statistics

Add a few netdev statistics to report transmitted and received bytes and packets and a few obvious errors. Signed-off-by: Florian Fainelli <f.faine...@gmail.com> --- drivers/net/ethernet/broadcom/bgmac.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/drivers/net/et

Re: [PATCH net-next v3 5/6] net: dsa: Initialize CPU port ethtool ops per tree

On 06/07/2016 02:51 PM, Andrew Lunn wrote: >> +int dsa_cpu_port_ethtool_setup(struct dsa_switch_tree *dst, >> + struct dsa_switch *ds) >> +{ >> +struct net_device *master; >> +struct ethtool_ops *cpu_ops; >> + >> +master = ds->dst->master_netdev; > > You pass

Re: [PATCH v4 7/7] phy: Add Northstar2 PCI Phy support

On 06/06/2016 05:41 AM, Pramod Kumar wrote: > Add PCI Phy support for Broadcom Northstar2 SoCs. This driver uses the > interface from the iproc mdio mux driver to enable the devices > respective phys. > > Reviewed-by: Andrew Lunn > Signed-off-by: Jon Mason

Re: [PATCH v4 3/7] binding: mdio-mux: Add DT binding doc for Broadcom MDIO bus multiplexer

On 06/06/2016 05:41 AM, Pramod Kumar wrote: > Add DT binding doc for Broadcom MDIO bus multiplexer driver. > > Reviewed-by: Andrew Lunn <and...@lunn.ch> > Signed-off-by: Pramod Kumar <pramod.ku...@broadcom.com> Reviewed-by: Florian Fainelli <f.faine...@

Re: [PATCH v4 4/7] dt: mdio-mux: Add mdio multiplexer driver node

On 06/06/2016 05:41 AM, Pramod Kumar wrote: > Add integrated MDIO multiplexer driver node which contains > two mux PCIe bus and one ethernet bus along with phys > lying on these bus. > > Signed-off-by: Pramod Kumar > --- > + mdio_mux_iproc:

Re: [PATCH v4 1/7] mdio: mux: Enhanced MDIO mux framework for integrated multiplexers

river could register a > parent bus and pass it down to framework via mdio_mux_init api. > > Signed-off-by: Pramod Kumar <pramod.ku...@broadcom.com> Reviewed-by: Florian Fainelli <f.faine...@gmail.com> > diff --git a/include/linux/mdio-mux.h b/include/linux/mdio-mux.h >

Re: [PATCH 1/5] ethernet: add sun8i-emac driver

On 06/03/2016 02:56 AM, LABBE Corentin wrote: > This patch add support for sun8i-emac ethernet MAC hardware. > It could be found in Allwinner H3/A83T/A64 SoCs. > > It supports 10/100/1000 Mbit/s speed with half/full duplex. > It can use an internal PHY (MII 10/100) or an external PHY > via

Re: [PATCH v4 5/7] net: mdio-mux: Add MDIO mux driver for iProc SoCs

could be internal or external to SOC where PHYs are attached. > These buses could use C-45 or C-22 mdio transaction. > > Signed-off-by: Pramod Kumar <pramod.ku...@broadcom.com> Reviewed-by: Florian Fainelli <f.faine...@gmail.com> -- Florian

Re: [PATCH net-next 2/9] net: dsa: Add support for parsing the old binding

On 06/05/2016 08:19 PM, Andrew Lunn wrote: >> How much support do we want to have for the old binding for in tree >> platforms? Is the plan to migrate them all to the new binding? > > I think there are three cases to consider. > > 1) There are some old boards using setup.c files which have a

Re: [PATCH 1/5] ethernet: add sun8i-emac driver

Le 09/06/2016 02:44, LABBE Corentin a écrit : > Hello > > I agree to all your comments, but for some I have additionnal questions > > On Mon, Jun 06, 2016 at 11:25:15AM -0700, Florian Fainelli wrote: >> On 06/03/2016 02:56 AM, LABBE Corentin wrote: >> >> [sni

Re: [PATCH net-next 4/4] net: dsa: bcm_sf2: Add VLAN support

On 06/10/2016 05:00 AM, Andrew Lunn wrote: >> @@ -148,6 +155,9 @@ struct bcm_sf2_priv { >> struct device_node *master_mii_dn; >> struct mii_bus *slave_mii_bus; >> struct mii_bus *master_mii_bus; >> + >> +/* Cache of programmed VLANs

Re: [PATCH net-next 1/5] net: dsa: b53: Add support for Broadcom RoboSwitch

On 06/10/2016 05:11 AM, Andrew Lunn wrote: >> +static void b53_switch_reset_gpio(struct b53_device *dev) >> +{ >> +int gpio = dev->reset_gpio; >> + >> +if (gpio < 0) >> +return; >> + >> +/* Reset sequence: RESET low(50ms)->high(20ms) >> + */ >> +gpio_set_value(gpio,

[PATCH net-next 3/4] net: dsa: bcm_sf2: Add VLAN registers definitions

Add the definitions for the VLAN registers that we are going to manipulate in subsequent patches. Signed-off-by: Florian Fainelli <f.faine...@gmail.com> --- drivers/net/dsa/bcm_sf2_regs.h | 70 ++ 1 file changed, 70 insertions(+) diff --git a/drive

[PATCH net-next 1/4] net: dsa: bcm_sf2: Split fast age into a helper function

Add a helper function to fast age something that is controlled by the caller: port, VLAN. We will use this to implement a VLAN fast age operation. Signed-off-by: Florian Fainelli <f.faine...@gmail.com> --- drivers/net/dsa/bcm_sf2.c | 20 +--- 1 file changed, 13 insertions

[PATCH net-next 5/5] net: dsa: b53: Plug in VLAN support

-off-by: Florian Fainelli <f.faine...@gmail.com> --- drivers/net/dsa/b53/b53_common.c | 256 +++ drivers/net/dsa/b53/b53_priv.h | 13 +- 2 files changed, 243 insertions(+), 26 deletions(-) diff --git a/drivers/net/dsa/b53/b53_common.c b/drivers/net/d

[PATCH net-next 0/5] net: dsa: Broadcom BCM53xx switches support

supported which have different tag formats, but the plan is to enable them later on. Support for different HW features will be added later: EEE, Compact Field Processor (TCAM) once this initial cut gets accepted. Testing and bug reports welcome! Florian Fainelli (5): net: dsa: b53: Add support

[PATCH net-next 4/5] net: dsa: b53: Add bridge support

Add support for HW bridging by tying the ports together in the same port VLAN mask when they belong to the same bridge, and isolating them to be alone with the CPU port when they are not. Propagate STP states from the bridge layer to the switch's HW mapping when requested. Signed-off-by: Florian

[PATCH net-next 4/4] net: dsa: bcm_sf2: Add VLAN support

Add support for configuring VLANs on the Broadcom Starfigther2 switch. This is all done through the bridge vlan facility just like other DSA drivers. Signed-off-by: Florian Fainelli <f.faine...@gmail.com> --- drivers/net/dsa/bcm_sf2.c | 266 +- d

[PATCH net-next 2/4] net: dsa: bcm_sf2: Move setup function at the far end

Re-order the bcm_sf2_sw_setup() function so that it is at the far end of the driver to avoid any kind of forward declarations. Signed-off-by: Florian Fainelli <f.faine...@gmail.com> --- drivers/net/dsa/bcm_sf2.c | 238 +++--- 1 file changed, 119 inse

[PATCH net-next 0/4] net: dsa: bcm_sf2: add VLAN support

it to receive all 802.1q frames so we utiliez the "Join all VLAN" feature of the switch to perform that Thanks! Florian Fainelli (4): net: dsa: bcm_sf2: Split fast age into a helper function net: dsa: bcm_sf2: Move setup function at the far end net: dsa: bcm_sf2: Add VLAN registers d

[PATCH net-next 1/5] net: dsa: b53: Add support for Broadcom RoboSwitch

. Signed-off-by: Florian Fainelli <f.faine...@gmail.com> --- Documentation/devicetree/bindings/net/dsa/b53.txt | 90 ++ MAINTAINERS |8 + drivers/net/dsa/Kconfig |2 + drivers/net/dsa/Makefile

[PATCH net-next 2/5] net: dsa: b53: Add BCM7445 quirk

. Add a small quirk which just defers probing until we are sitting on the slave DSA MDIO bus, which will allow us to intercept reads/writes and funnel them through the SF2 internal MDIO master (which happens to disconnect its pseudo PHY). Signed-off-by: Florian Fainelli <f.faine...@gmail.

[PATCH net-next 3/5] net: dsa: b53: Implement ARL add/del/dump operations

register. Signed-off-by: Florian Fainelli <f.faine...@gmail.com> --- drivers/net/dsa/b53/b53_common.c | 261 +++ drivers/net/dsa/b53/b53_priv.h | 57 + drivers/net/dsa/b53/b53_regs.h | 64 ++ 3 files changed, 382 insertions(+) diff

[PATCH net-next] net: dsa: Provide CPU port statistics to master netdev

look like this now: statistics p<2 digits cpu port number>_ Signed-off-by: Florian Fainelli <f.faine...@gmail.com> --- Changes from RFC: - prepend the CPU port as a prefix to make it clear what the stats are about, master netdev interface stats are unchanged include/net/dsa.h |

[PATCH net-next 1/9] net: dsa: Prepare to support legacy DT binding

In preparation for supporting the legacy DT binding, call dsa_get_ports() early on to allow two different parsing code paths to be called. Signed-off-by: Florian Fainelli <f.faine...@gmail.com> --- net/dsa/dsa2.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff

[PATCH net-next 0/9] net: dsa: misc improvements

no longer assume a single tree is supported - finally conver the bcm_sf2 driver to be a true platform device driver and slightly rework its internal vs. external MDIO bus indirect read/writes to be cleaner Florian Fainelli (9): net: dsa: Prepare to support legacy DT binding net: dsa: A

[PATCH net-next 7/7] net: dsa: bcm_sf2: Register our slave MDIO bus

-by: Florian Fainelli <f.faine...@gmail.com> --- drivers/net/dsa/bcm_sf2.c | 141 -- drivers/net/dsa/bcm_sf2.h | 6 ++ 2 files changed, 106 insertions(+), 41 deletions(-) diff --git a/drivers/net/dsa/bcm_sf2.c b/drivers/net/dsa/bcm_sf2.c index 8dac74

[PATCH net-next 5/9] net: dsa: Export suspend/resume functions

In preparation for allowing switch drivers to implement system-wide suspend/resume functions, export dsa_switch_suspend and dsa_switch_resume() such that these are callable from the appropriate driver specific suspend/resume functions. Signed-off-by: Florian Fainelli <f.faine...@gmail.

[PATCH net-next 4/9] net: dsa: Initialize ds->enabled_port_mask and ds->phys_mii_mask

which is mostly useful for the case where we probe using the legacy binding which has properties/nodes in different places and does not use dsa_dst_parse(). Signed-off-by: Florian Fainelli <f.faine...@gmail.com> --- net/dsa/dsa2.c | 59 ++

Re: [PATCH net-next] net: dsa: bcm_sf2: Implement FDB operations

On 06/03/2016 05:05 PM, Florian Fainelli wrote: > Add support for the FDB add, delete, and dump operations. The add and > delete operations are implemented using directed ARL operations using > the specified MAC address and consist in a read operation, write and > readback operation. &

Re: [PATCH net-next 0/9] net: dsa: misc improvements

On 06/03/2016 05:05 PM, Florian Fainelli wrote: > Hi all, > > This patch series builds on top of Andrew's "New DSA bind, switches as > devices" > patch set and does the following: > > - add support for the old DSA binding with the new dsa_register_switch()

[PATCH net-next] net: dsa: bcm_sf2: Implement FDB operations

filtering entries which are not for the desired port. Signed-off-by: Florian Fainelli <f.faine...@gmail.com> --- drivers/net/dsa/bcm_sf2.c | 236 + drivers/net/dsa/bcm_sf2.h | 56 ++ drivers/net/dsa/bcm_sf2_regs.h | 43 3

[PATCH net-next 6/9] net: dsa: Add initialization helper for CPU port ethtool_ops

Add a helper function: dsa_cpu_port_ethtool_init() which initializes a custom ethtool_ops structure with custom DSA ethtool operations for CPU ports. This is a preliminary change to move the initialization outside of net/dsa/slave.c. Signed-off-by: Florian Fainelli <f.faine...@gmail.com> --

[PATCH net-next 7/9] net: dsa: Initialize CPU port ethtool ops per tree

be comparing addresses anymore to determine first time initialization versus any other times, just move this to dsa.c and dsa2.c where the remainder of the dst/ds initialization happens. Signed-off-by: Florian Fainelli <f.faine...@gmail.com> --- net/dsa/dsa.c | 28 +++

[PATCH net-next 2/9] net: dsa: Add support for parsing the old binding

Extend dsa2.c to support parsing for the old binding, which mostly means looking for more or less the same properties in different places. Signed-off-by: Florian Fainelli <f.faine...@gmail.com> --- net/dsa/dsa2.c | 142 ++--- 1 file c

[PATCH net-next 9/9] net: dsa: bcm_sf2: Register our slave MDIO bus

-by: Florian Fainelli <f.faine...@gmail.com> --- drivers/net/dsa/bcm_sf2.c | 141 -- drivers/net/dsa/bcm_sf2.h | 6 ++ 2 files changed, 106 insertions(+), 41 deletions(-) diff --git a/drivers/net/dsa/bcm_sf2.c b/drivers/net/dsa/bcm_sf2.c index 8dac74

Re: [PATCH net-next] net: dsa: Provide CPU port statistics to master netdev

On 06/03/2016 05:05 PM, Florian Fainelli wrote: > This patch overloads the DSA master netdev, aka CPU Ethernet MAC to also > include switch-side statistics, which is useful for debugging purposes, > when the switch is not properly connected to the Ethernet MAC (duplex > misma

[PATCH net-next 3/9] net: dsa: Provide unique DSA slave MII bus names

In case we have multiples trees and switches with the same index, we need to add another discriminating id: the switch tree. Signed-off-by: Florian Fainelli <f.faine...@gmail.com> --- net/dsa/slave.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/net/dsa/slave.c b/n

[PATCH net-next 6/7] net: dsa: bcm_sf2: Make it a real platform device driver

in moving what bcm_sf2_sw_setup() did into the platform driver probe function. Signed-off-by: Florian Fainelli <f.faine...@gmail.com> --- drivers/net/dsa/bcm_sf2.c | 251 -- net/dsa/dsa.c | 1 - 2 files changed, 151 insertions(+

[PATCH net-next 8/9] net: dsa: bcm_sf2: Make it a real platform device driver

in moving what bcm_sf2_sw_setup() did into the platform driver probe function. Signed-off-by: Florian Fainelli <f.faine...@gmail.com> --- drivers/net/dsa/bcm_sf2.c | 251 -- net/dsa/dsa.c | 1 - 2 files changed, 151 insertions(+

Re: [PATCH net-next 12/17] net: dsa: Make mdio bus optional

On 06/03/2016 09:44 AM, Andrew Lunn wrote: > The switch may want to instantiate its own MDIO bus. Only do it > centrally if the switch has not already created one, and the read op > is implemented. > > Signed-off-by: Andrew Lunn <and...@lunn.ch> Reviewed-by: Flor

[PATCH net v2 0/3] Documentation: dsa: misc fixes

Hi David, Here are some miscelaneous documentation fixes for DSA, I targeted "net" because these are not functional code changes, but still documentation fixes per-se. Changes in v2: - reword what the port_vlan_filtering is about based on feedback from Vivien and Ido Florian F

[PATCH net v2 1/3] Documentation: networking: dsa: Remove poll_link description

This function has been removed in 4baee937b8d5 ("net: dsa: remove DSA link polling") in favor of using the PHYLIB polling mechanism. Reviewed-by: Vivien Didelot <vivien.dide...@savoirfairelinux.com> Signed-off-by: Florian Fainelli <f.faine...@gmail.com> --- Documentation/

[PATCH net v2 2/3] Documentation: networking: dsa: Remove priv_size description

We no longer have a priv_size structure member since 5feebd0a8a79 ("net: dsa: Remove allocation of driver private memory") Reviewed-by: Vivien Didelot <vivien.dide...@savoirfairelinux.com> Signed-off-by: Florian Fainelli <f.faine...@gmail.com> --- Documentation/networking

[PATCH net v2 3/3] Documentation: networking: dsa: Describe port_vlan_filtering

Described what the port_vlan_filtering function is supposed to accomplish. Fixes: fb2dabad69f0 ("net: dsa: support VLAN filtering switchdev attr") Signed-off-by: Florian Fainelli <f.faine...@gmail.com> --- Documentation/networking/dsa/dsa.txt | 10 ++ 1 file change

Re: [PATCH net-next v4 0/7] vmxnet3: upgrade to version 3

On 06/14/2016 11:52 AM, Shrikrishna Khare wrote: > This patchset upgrades vmxnet3 to version 3. > > Changes in v2: > - Following patch is updated. See that patch for details: >vmxnet3: add support for get_coalesce, set_coalesce ethtool > > Changes in v3: > - fix subject line to use

Re: [PATCH 04/15] drivers: net: cpsw: ethtool: fix accessing to suspended device

On 06/15/2016 04:55 AM, Grygorii Strashko wrote: > The CPSW might be suspended by RPM if all ethX interfaces are down, > but it still could be accesible through ethtool interfce. In this case > ethtool operations, requiring registers access, will cause L3 errors and > CPSW crash. > > Hence, fix

[PATCH net-next v2 5/5] net: dsa: bcm_sf2: Register our slave MDIO bus

to register it by the time we are able to get access to our memory mapped registers, which is not until drv->setup() time. In order to avoid forward declarations, we need to re-order the function bodies a bit. Signed-off-by: Florian Fainelli <f.faine...@gmail.com> --- drivers/net/dsa/bcm_sf

<    1   2   3   4   5   6   7   8   9   10   >