Re: Disable setting speed outside the ethtool

2015-07-09 Thread Francois Romieu
Marian Corcodel : > Set speed only on ethtool..Driver is r8169 . Why ? You should also elaborate why it's supposed to be regression-free. -- Ueimor -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: Disable executions commands outside net_device_ops structure

2015-07-09 Thread Francois Romieu
> diff --git a/drivers/net/ethernet/realtek/r8169.c > b/drivers/net/ethernet/realtek/r8169.c > index 3df51fa..840a2ec 100644 > --- a/drivers/net/ethernet/realtek/r8169.c > +++ b/drivers/net/ethernet/realtek/r8169.c [...] > @@ -6881,7 +6881,7 @@ static void r8169_csum_workaround(struct > rtl8169_p

Re: Why can't we SNAT (or inverse DNAT) in PREROUTING?

2015-06-27 Thread Francois Romieu
Andy Lutomirski : > On Fri, Jun 26, 2015 at 3:48 PM, Francois Romieu wrote: > > Andy Lutomirski : [...] > >> Shouldn't the order of operations be: > >> > >> 1. Check rp_filter. > >> 2. Handle NAT. > >> 3. Routing decision. > >>

Re: macb napi strange behavior

2015-06-26 Thread Francois Romieu
Nicolae Rosia : [...] > I gave it a shot. Can you please take a look? > I don't know how to deal with multiple queues since Zynq 7000 has one > queue per interface. macb_interrupt knows the queue. macb_poll doesn't. Either you store it somewhere or you go for per queue napi struct. -- Ueimor --

Re: Why can't we SNAT (or inverse DNAT) in PREROUTING?

2015-06-26 Thread Francois Romieu
Andy Lutomirski : > [re-add netdev -- I assume you meant to reply all] Thanks. Late friday. > On Fri, Jun 26, 2015 at 1:32 PM, Francois Romieu wrote: > > Andy Lutomirski : > > [...] > >> Could we add some option to do SNAT and inverse DNAT before routing? > &g

Re: macb napi strange behavior

2015-06-20 Thread Francois Romieu
Florian Fainelli : [...] > Typically, NAPI is used at the receive side of the Ethernet NIC/driver > to lower the hard/soft interrupt context switch, although there is > nothing that prevent you to implement a similar scheme for the > transmit side. Usually, for transmit you will be submitting one

Re: [PATCH] wan: dscc4: use msecs_to_jiffies for conversions

2015-06-07 Thread Francois Romieu
David Miller : [...] > Whoever wrote these things probably wanted whatever this amounts > to when HZ=100, so that is the only valid transformation you can > make to fix this up here. It's linux kernel illiterate style from 13 years ago but I commented dscc4_pci_reset. wait_ack_cec and xpr_ack ar

[PATCH net-next #3 3/8] via-rhine: gotoize rhine_open error path.

2015-05-01 Thread Francois Romieu
Signed-off-by: Francois Romieu --- drivers/net/ethernet/via/via-rhine.c | 16 ++-- 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/drivers/net/ethernet/via/via-rhine.c b/drivers/net/ethernet/via/via-rhine.c index aa398ea..91661e0 100644 --- a/drivers/net/ethernet/via

Re: [RFC] r8169 DMA failure with iommu=off

2015-05-01 Thread Francois Romieu
Stephen Hemminger : > This only fixes the Rx side, what about Tx? > > I think maybe just removing the whole use_dac flag completely ? Something simple would be welcome but I doubt it should be that simple. The problems that the use_dac comment (MODULE_PARM_DESC) relates to are 2003 ~ 2004, plai

Re: Resource usages in Linux drivers

2015-04-23 Thread Francois Romieu
Sergei Shtylyov : > On 4/23/2015 1:08 PM, Jia-Ju Bai wrote: [...] > >I also find many drivers do not use these managed APIs, especially in > >ethernet > >card drivers (like e100, r8169). Is it possible to change them? > >Patches welcome. :-) I respectfully disagree. If someone believes bas

Re: [git patches] net driver fixes

2008-02-20 Thread Francois Romieu
David Miller <[EMAIL PROTECTED]> : [...] > Because it forces me to pull Linus's upstream into net-2.6, > I don't have any choice in the matter. Jeff's choice is a bit surprizing. That being said, it would had been nice to fast-forward net-2.6 from a442585952f137bd4cdb1f2f3166e4157d383b82 to Linus'

[PATCH 1/1] sis190: read the mac address from the eeprom first

2008-02-18 Thread Francois Romieu
Reading a serie of zero from the cmos sram area do not work well with is_valid_ether_addr(). Let's read the mac address from the eeprom first as it seems more reliable. Fix for http://bugzilla.kernel.org/show_bug.cgi?id=9831 Signed-off-by: Francois Romieu <[EMAIL PROTECTED]> ---

Re: r8169 auto-negotiation problem

2008-02-12 Thread Francois Romieu
fgnijuhhu guduggurehug <[EMAIL PROTECTED]> : > > fgnijuhhu guduggurehug : > > [...] > >> I already posted my problem and what I did to solve it on > >> http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=461429. > > > > Have you tried anything more recent than a 2.6.18 based kernel ? > > No, but if

Re: [PATCH 07/24 for-2.6.25] DM9000: Add initial ethtool support

2008-02-06 Thread Francois Romieu
Ben Dooks <[EMAIL PROTECTED]> : [...] > The next patch in the series changes the locking. Do you mean patch #08 ? If so it does not fix this bug: the very first line in dm9000_phy_read includes a spinlock statement. -- Ueimor -- To unsubscribe from this list: send the line "unsubscribe netdev"

Re: [PATCH 01/24 for-2.6.25] DM9000: Fix endian-ness of data accesses. Patch from: Laurent Pinchart

2008-02-05 Thread Francois Romieu
Ben Dooks <[EMAIL PROTECTED]> : > This patch splits the receive status in 8bit wide fields and convert the > packet length from little endian to CPU byte order. > > Signed-off-by: Laurent Pinchart <[EMAIL PROTECTED]> > Signed-off-by: Ben Dooks <[EMAIL PROTECTED]> > > Index: linux-2.6.24-git5-dm9k

Re: [PATCH 07/24 for-2.6.25] DM9000: Add initial ethtool support

2008-02-05 Thread Francois Romieu
Ben Dooks <[EMAIL PROTECTED]> : > Add support for ethtool operations for the DM9000. > > Signed-off-by: Ben Dooks <[EMAIL PROTECTED]> > > Index: linux-2.6.24-quilt3/drivers/net/dm9000.c > === > --- linux-2.6.24-quilt3.orig/drivers/ne

Pull request for 'r6040' branch

2008-02-05 Thread Francois Romieu
Please pull from branch 'r6040' in repository git://git.kernel.org/pub/scm/linux/kernel/git/romieu/netdev-2.6.git r6040 to get the changes below. I have simply rebased the r6040 branch from december on top of Linus's latest head and given each patch a compile test. The content is identical to Fl

Re: FW: r8169 auto-negotiation problem

2008-02-03 Thread Francois Romieu
fgnijuhhu guduggurehug <[EMAIL PROTECTED]> : [...] > I already posted my problem and what I did to solve it on > http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=461429. Have you tried anything more recent than a 2.6.18 based kernel ? -- Ueimor -- To unsubscribe from this list: send the line "un

Re: [PATCH] sis190: fix compile error section type conflict

2008-02-02 Thread Francois Romieu
your s-o-b to it ? Subject: [PATCH] sis190: fix section type conflict The driver already contains __devinitdata which is not const. Signed-off-by: Sam Ravnborg <[EMAIL PROTECTED]> Signed-off-by: Francois Romieu <[EMAIL PROTECTED]> Cc: Michael D. Setzer II <[EMAIL PROTECTED]> Cc:

Re: R8101 driver link issue

2008-02-01 Thread Francois Romieu
Switact - Thomas Roes <[EMAIL PROTECTED]> : [...] > Recently I got problems with a new motherbord using the Realtek RTL8101E > PCI Express Fast Ethernet controller. > > This card is recognised by the r8169 driver but it always gives me > "link down". Can you send the output of 'lspci -vvxxx'

Re: [git patches] net driver fixes

2008-01-30 Thread Francois Romieu
Sam Ravnborg <[EMAIL PROTECTED]> : [...] > > -static struct pci_device_id sis190_pci_tbl[] __devinitdata = { > > +static struct pci_device_id sis190_pci_tbl[] = { > > { PCI_DEVICE(PCI_VENDOR_ID_SI, 0x0190), 0, 0, 0 }, > > { PCI_DEVICE(PCI_VENDOR_ID_SI, 0x0191), 0, 0, 1 }, > > { 0, }, >

[PATCH 1/1] sis190: silence section type conflict

2008-01-29 Thread Francois Romieu
CC [M] drivers/net/sis190.o drivers/net/sis190.c:329: error: sis190_pci_tbl causes a section type conflict make[5]: *** [drivers/net/sis190.o] Error 1 Signed-off-by: Francois Romieu <[EMAIL PROTECTED]> Reported-by: Maximilian Attems <[EMAIL PROTECTED]> diff --git a/drivers/ne

Re: sis190 build breakage

2008-01-29 Thread Francois Romieu
maximilian attems <[EMAIL PROTECTED]> : [...] > probably i should to get interesting info. Don't bother. $ less +/devinitdata Documentation/pci.txt [...] Tips on when/where to use the above attributes: o The module_init()/module_exit() functions (and all initialization functions

Re: sis190 build breakage

2008-01-29 Thread Francois Romieu
maximilian attems <[EMAIL PROTECTED]> : > CC [M] drivers/net/sis190.o > drivers/net/sis190.c:329: error: sis190_pci_tbl causes a section type > conflict > make[5]: *** [drivers/net/sis190.o] Error 1 > > gcc --version > gcc (GCC) 4.1.2 20061115 (prerelease) (Debian 4.1.1-21) Are you buildi

Re: Slow OOM in netif_RX function

2008-01-24 Thread Francois Romieu
Ivan H. Dichev <[EMAIL PROTECTED]> : [...] > Any other ideas appreciated. Plot the slab values and the counters of the iptables rules against time ? -- Ueimor -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info a

Pull request for 'ipg-fixes' branch (try #2)

2008-01-17 Thread Francois Romieu
letions(-) Shortlog ---- Francois Romieu (4): ipg: balance locking in irq handler ipg: plug Tx completion leak ipg: fix queue stop condition in the xmit handler ipg: fix Tx completion irq request Patch - diff --git a/drivers/net/ipg.c b/drivers/net/ipg.c index dbd

Re: [PATCH 1/3] drivers/net/ipg.c: Fix skbuff leak

2008-01-14 Thread Francois Romieu
David Miller <[EMAIL PROTECTED]> : > From: Francois Romieu <[EMAIL PROTECTED]> > > > > I should be able to test your r8169 NAPI changes tomorrow. > > Thank you. (sorry for the delay) I think that the r8169 part should be reverted. . With it, my 8169 oopsed un

Re: [PATCH 0/4] Pull request for 'ipg-fixes' branch

2008-01-13 Thread Francois Romieu
Francois Romieu <[EMAIL PROTECTED]> : > Jeff Garzik <[EMAIL PROTECTED]> : > > Francois Romieu wrote: > [...] > >> Distance from 'net-2.6/master' (27d1cba21fcc50c37eef5042c6be9fa7135e88fc) > >> -

Re: [PATCH 0/4] Pull request for 'ipg-fixes' branch

2008-01-13 Thread Francois Romieu
Jeff Garzik <[EMAIL PROTECTED]> : > Francois Romieu wrote: [...] >> Distance from 'net-2.6/master' (27d1cba21fcc50c37eef5042c6be9fa7135e88fc) >> - [...] > hrm... tried to pull this, but recei

Re: [PATCH 0/4] Pull request for 'ipg-fixes' branch

2008-01-11 Thread Francois Romieu
[EMAIL PROTECTED] <[EMAIL PROTECTED]> : [...] > I notice that the vendor-supplied driver doesn't have these bugs. The M in POMS stands for "my". [...] > Would you be interested in some cleanup patches ? Yes. > In particular, I think I can get rid of tx->lock entirely, or at least > take it off

[PATCH 3/4] ipg: fix queue stop condition in the xmit handler

2008-01-10 Thread Francois Romieu
Signed-off-by: Francois Romieu <[EMAIL PROTECTED]> --- drivers/net/ipg.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/ipg.c b/drivers/net/ipg.c index 9752902..b234b29 100644 --- a/drivers/net/ipg.c +++ b/drivers/net/ipg.c @@ -1994,7 +1994,7 @@ stat

[PATCH 4/4] ipg: fix Tx completion irq request

2008-01-10 Thread Francois Romieu
The current logic will only request an ack for the first pending packet. No irq is triggered as soon as the CPU submits a few packets a bit quickly. Let's request an irq for every packet instead. Signed-off-by: Francois Romieu <[EMAIL PROTECTED]> --- drivers/net/ipg.c |5 +--

[PATCH 2/4] ipg: plug Tx completion leak

2008-01-10 Thread Francois Romieu
oller. The xmit handler suggests that it is done through the IPG_TFC_TFDDONE bit. Remove the former "curr" computing: it does not produce anything usable in its current form. Signed-off-by: Francois Romieu <[EMAIL PROTECTED]> --- drivers/net/ipg.c | 19 +-- 1 files

[PATCH 0/4] Pull request for 'ipg-fixes' branch

2008-01-10 Thread Francois Romieu
d42f3afc953f9c99ffe84667a3ecf0d3b69f3d64 358bf4b8e8cbde5d6411b219e93a61728c892685 a58cceed4464ba8ae94294184c15f43e92a5de89 Diffstat drivers/net/ipg.c | 36 1 files changed, 12 insertions(+), 24 deletions(-) Shortlog Francois Romieu (4):

[PATCH 1/4] ipg: balance locking in irq handler

2008-01-10 Thread Francois Romieu
Spotted-by: <[EMAIL PROTECTED]> Signed-off-by: Francois Romieu <[EMAIL PROTECTED]> --- drivers/net/ipg.c | 10 +- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/net/ipg.c b/drivers/net/ipg.c index dbd23bb..cd1650e 100644 --- a/drivers/net/ipg.c +++ b

Re: [PATCH 1/3] drivers/net/ipg.c: Fix skbuff leak

2008-01-09 Thread Francois Romieu
David Miller <[EMAIL PROTECTED]> : [...] > all resolved. All of that code cleanup stuff needs to wait > until later, let's fix bugs before adding new ones. :-) Yes. I should be able to test your r8169 NAPI changes tomorrow. -- Ueimor -- To unsubscribe from this list: send the line "unsubscribe

Re: [PATCH 1/3] drivers/net/ipg.c: Fix skbuff leak

2008-01-09 Thread Francois Romieu
[EMAIL PROTECTED] <[EMAIL PROTECTED]> : [...] > That doesn't seem to do it. Not entirely, at least. After downloading > and partially re-uploading an 800M file, slabtop reports: Ok, enjoy this one. It is definitely better wrt the current problem. More work tomorrow. diff --git a/drivers/net/ip

Re: [PATCH 1/3] drivers/net/ipg.c: Fix skbuff leak

2008-01-08 Thread Francois Romieu
David Miller <[EMAIL PROTECTED]> : [...] > Same kind of bug as the RX side :-) I bet this fixes his > problem... I am not sure but the Rx side is probably just here to distract from the real problem. Please don't ask... :o) Anyway I'll poke an adapter in the test computer and give it a try tomor

Re: [PATCH 1/3] drivers/net/ipg.c: Fix skbuff leak

2008-01-08 Thread Francois Romieu
[EMAIL PROTECTED] <[EMAIL PROTECTED]> : > I take that back. This patch does NOT fix the leak, at least if > ping: sendmsg: No buffer space available > is any indication... Can you try the patch below ? diff --git a/drivers/net/ipg.c b/drivers/net/ipg.c index dbd23bb..c304e5c 100644 --- a/drivers

Re: [PATCH 3/3] drivers/net/ipg.c: fix horrible mdio_read and _write

2008-01-08 Thread Francois Romieu
[EMAIL PROTECTED] <[EMAIL PROTECTED]> : [...] > diff --git a/drivers/net/ipg.c b/drivers/net/ipg.c > index 3860fcd..b3d3fc8 100644 > --- a/drivers/net/ipg.c > +++ b/drivers/net/ipg.c > @@ -202,12 +202,31 @@ static u16 read_phy_bit(void __iomem * ioaddr, u8 > phyctrlpolarity) > } > > /* > + * T

Re: 2.6.23-rc8 network problem. Mem leak? ip1000a?

2008-01-08 Thread Francois Romieu
David Miller <[EMAIL PROTECTED]> : [...] > I invested 30 seconds of code reading to figure out the leak. A much > better investment of time than adding bogus comments to the Kconfig > help text don't you think? :-) Thanks for the hint David. I'll roll up a patch for it after the day work. -- U

Re: [PATCH] via-velocity big-endian support

2008-01-07 Thread Francois Romieu
Al Viro <[EMAIL PROTECTED]> : [...] > Point taken... > > * kill multibyte bitfields > * annotate > * add missing conversions > * fix a couple of brainos in zerocopy stuff (fortunately, it's ifdef'ed out) > > Signed-off-by: Al Viro <[EMAIL PROTECTED]> Thanks a lot. After the usual xmas delay, spl

[PATCH 1/1] r8169: fix missing loop variable increment

2008-01-03 Thread Francois Romieu
Spotted-by: Citizen Lee <[EMAIL PROTECTED]> Signed-off-by: Francois Romieu <[EMAIL PROTECTED]> --- drivers/net/r8169.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/r8169.c b/drivers/net/r8169.c index 5863190..6ee9db1 100644 --- a/drivers/net/r

Re: [PATCH 0/4] Pull request for 'sis190' branch

2007-12-26 Thread Francois Romieu
Jeff Garzik <[EMAIL PROTECTED]> : [...] >> Shortlog >> ---- >> >> Francois Romieu (4): >> sis190: add cmos ram access code for the SiS19x/968 chipset pair >> sis190: remove duplicate INIT_WORK >> sis190: mdio operation f

Re: [PATCH] via-velocity big-endian support

2007-12-25 Thread Francois Romieu
Al Viro <[EMAIL PROTECTED]> : [...] > > Can we avoid using cpu_to_leXY here for consistency sake within the driver > > (and among different drivers as well) ? > > ??? I admit that it is a bit late for the Xmas wishlist. Compare it with: @@ -1409,31 +1409,33 @@ static int velocity_rx_srv(struct v

Re: [PATCH] via-velocity big-endian support

2007-12-25 Thread Francois Romieu
Al Viro <[EMAIL PROTECTED]> : [...] > diff --git a/drivers/net/via-velocity.h b/drivers/net/via-velocity.h > index aa91796..e0ec5d4 100644 > --- a/drivers/net/via-velocity.h > +++ b/drivers/net/via-velocity.h > @@ -196,26 +196,29 @@ > * Receive descriptor > */ > > +#define DESC_OWNER cpu_to

Re: [2.6 patch] drivers/net/sis190.c section fix

2007-12-12 Thread Francois Romieu
Adrian Bunk <[EMAIL PROTECTED]> : > This patch fixes the following section mismatch with CONFIG_HOTPLUG=n: [...] > WARNING: vmlinux.o(.init.text.20+0x4cb25): Section mismatch: reference to > .exit.text:sis190_mii_remove (between 'sis190_init_one' and 'read_eeprom') Thanks. Applied at: git://git.

Re: [PATCH] r6040 various cleanups

2007-12-12 Thread Francois Romieu
Florian Fainelli <[EMAIL PROTECTED]> : [r6040 changes] > - remove unused private structure members > - functions to allocate/free TX and RX buffers > - recover from transmit timeout > - use netdev_alloc_skb instead of dev_alloc_skb > - do not use a private stats structure to store statistics > - br

Re: [2.6 patch] drivers/net/ipg.c: add __devexit annotation

2007-12-11 Thread Francois Romieu
Adrian Bunk <[EMAIL PROTECTED]> : > ipg_remove() can become __devexit. > > Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> I'll add it to the pending ipg queue. -- Ueimor -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More major

Re: net-2.6.25 being rebased...

2007-12-11 Thread Francois Romieu
Francois Romieu <[EMAIL PROTECTED]> : [...] > [remote "origin"] > url = git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-2.6.git ^^^ "net-2.6.25", sorry. While reading the ans

Re: net-2.6.25 being rebased...

2007-12-11 Thread Francois Romieu
Joe Perches <[EMAIL PROTECTED]> : [...] > I have an earlier unmodified git repository of net-2.6.25. > Does anyone know the appropriate git commands to resync > to the rebased content? > > $ git branch > * master > $ git-pull > [...] > Automatic merge failed; fix conflicts and then commit the resu

[PATCH 4/4] sis190: scheduling while atomic error

2007-12-10 Thread Francois Romieu
sis190_tx_timeout -> sis190_hw_start -> sis190_soft_reset -> msleep *splat* PCI transactions are correctly flushed here. The msleep() is probably useless. Signed-off-by: Francois Romieu <[EMAIL PROTECTED]> Cc: K.M. Liu <[EMAIL PROTECTED]> --- drivers/net/sis190

[PATCH 1/4] sis190: add cmos ram access code for the SiS19x/968 chipset pair

2007-12-10 Thread Francois Romieu
More work is needed to handle correctly the PHY of the new devices when connected to a 10Mb link but this change already helps some users as is. Fix for: http://bugzilla.kernel.org/show_bug.cgi?id=9467 Signed-off-by: Francois Romieu <[EMAIL PROTECTED]> Cc: K.M. Liu <[EMAIL PROTECTE

[PATCH 2/4] sis190: remove duplicate INIT_WORK

2007-12-10 Thread Francois Romieu
It is already done in sis190_init_one. Signed-off-by: Francois Romieu <[EMAIL PROTECTED]> Cc: K.M. Liu <[EMAIL PROTECTED]> --- drivers/net/sis190.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/drivers/net/sis190.c b/drivers/net/sis190.c index 51bbb60..f6

[PATCH 3/4] sis190: mdio operation failure is not correctly detected

2007-12-10 Thread Francois Romieu
i ranges from 0 to 100 in the 'for' loop a few lines above. Reported by davem. Signed-off-by: Francois Romieu <[EMAIL PROTECTED]> Cc: K.M. Liu <[EMAIL PROTECTED]> --- drivers/net/sis190.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/

[PATCH 0/4] Pull request for 'sis190' branch

2007-12-10 Thread Francois Romieu
letions(-) Shortlog ---- Francois Romieu (4): sis190: add cmos ram access code for the SiS19x/968 chipset pair sis190: remove duplicate INIT_WORK sis190: mdio operation failure is not correctly detected sis190: scheduling while atomic error Patch - diff --git a/dr

Re: SIS190 Ethernet Driver check for ISA bridge on "SiS968" MotherBoards...

2007-12-09 Thread Francois Romieu
do not behave the same (see http://bugzilla.kernel.org/show_bug.cgi?id=9386 for instance). >From 38c4947eb946db4b5daea0fb37c1ca515ab803d6 Mon Sep 17 00:00:00 2001 From: Francois Romieu <[EMAIL PROTECTED]> Date: Tue, 4 Dec 2007 22:58:41 +0100 Subject: [PATCH] sis190: add cmos ram access c

Re: Reproducible data corruption with sendfile+vsftp - splice regression?

2007-12-06 Thread Francois Romieu
Holger Hoffstaette <[EMAIL PROTECTED]> : [...] > Maybe turning off sendfile or NAPI just lead to random success - so far it > really looks like tso on the r8169 is the common cause. TSO on the r8169 is the magic switch but the regression makes imvho more sense from a VM pov: - the corrupted file

Re: Reproducible data corruption with sendfile+vsftp - splice regression?

2007-12-05 Thread Francois Romieu
Francois Romieu <[EMAIL PROTECTED]> : > Holger Hoffstaette <[EMAIL PROTECTED]> : > [...] > > Should I file this in bugzilla? > > Yes. 5326 5585327 5585328 5585329 5585330 5585331 5585332 5585333 5585334 5585335 558 5336 5585337 5585338 5585339 5585340 5585341 55853

Re: Reproducible data corruption with sendfile+vsftp - splice regression?

2007-12-05 Thread Francois Romieu
Holger Hoffstaette <[EMAIL PROTECTED]> : [...] > Should I file this in bugzilla? Yes. -- Ueimor -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: Pull request for 'ipg' branch

2007-12-05 Thread Francois Romieu
Joe Perches <[EMAIL PROTECTED]> : [...] > > - if ((sp->LED_Mode & 0x01) == 1) > > + if ((sp->led_mode & 0x01) == 1) > > I think the use of hex and decimal constants is odd. > I think "if (sp->led_mode & 0x01)" is better. Yes, the whole context of this code in the driver is a bit special. [..

Pull request for 'ipg' branch

2007-12-04 Thread Francois Romieu
Please pull from branch 'ipg' in repository git://git.kernel.org/pub/scm/linux/kernel/git/romieu/netdev-2.6.git ipg to get the changes below. Distance from 'upstream' (558f08ed31c6909d3c9ae5d6dbf81220ede4b54a) --- 4918e9ebf74735bb8

[PATCH 4/4] r6040: cleanups

2007-11-28 Thread Francois Romieu
- whitespaces vs tabs - use 80 cols - use if_mii - use netdev_priv - remove useless cast to void * - PCI device id does not need to be globally available Signed-off-by: Francois Romieu <[EMAIL PROTECTED]> --- drivers/net/r6040.c | 33 + include

[PATCH 2/4] r6040: remove virt_to_bus

2007-11-28 Thread Francois Romieu
Signed-off-by: Francois Romieu <[EMAIL PROTECTED]> --- drivers/net/r6040.c | 103 +-- 1 files changed, 50 insertions(+), 53 deletions(-) diff --git a/drivers/net/r6040.c b/drivers/net/r6040.c index 6a6329e..a106add 100644 --- a/drivers/net/r

[PATCH 3/4] r6040: erroneous dev->priv

2007-11-28 Thread Francois Romieu
Signed-off-by: Francois Romieu <[EMAIL PROTECTED]> --- drivers/net/r6040.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/r6040.c b/drivers/net/r6040.c index a106add..71aa478 100644 --- a/drivers/net/r6040.c +++ b/drivers/net/r6040.c @@ -674,7

[PATCH 1/4] r6040: compile error

2007-11-28 Thread Francois Romieu
drivers/net/r6040.c: In function 'rx_buf_alloc': drivers/net/r6040.c:262: warning: passing argument 2 of 'pci_map_single' makes pointer from integer without a cast Signed-off-by: Francois Romieu <[EMAIL PROTECTED]> --- drivers/net/r6040.c |2 +- 1 files changed, 1

Pull request for 'r6040' branch

2007-11-28 Thread Francois Romieu
lude/linux/pci_ids.h |1 - 2 files changed, 64 insertions(+), 75 deletions(-) Shortlog ---- Francois Romieu (4): r6040: compile error r6040: remove virt_to_bus r6040: erroneous dev->priv r6040: cleanups Patch - diff --git a/drivers/net/r6040.c b/drivers/ne

Re: [PATCH 12/21] r8169: confusion between hardware and IP header alignment

2007-11-26 Thread Francois Romieu
Martin Michlmayr <[EMAIL PROTECTED]> : > * Francois Romieu <[EMAIL PROTECTED]> [2007-11-26 00:05]: > > > I'd like to backport the fix to the 2.6.18 kernel that is in our > > > stable release and have a couple of questions: > > > - Does your later

Re: [PATCH 12/21] r8169: confusion between hardware and IP header alignment

2007-11-25 Thread Francois Romieu
Martin Michlmayr <[EMAIL PROTECTED]> : [...] > I'd like to backport the fix to the 2.6.18 kernel that is in our > stable release and have a couple of questions: > - Does your later patch "align the IP header when there is no DMA >constraint" fix any bugs or is it merely an improvement? It fix

Re: 2.6.24-rc3, 4GB RAM, swiotlb, r8169, out of space

2007-11-24 Thread Francois Romieu
Francois Romieu <[EMAIL PROTECTED]> : > Alistair John Strachan <[EMAIL PROTECTED]> : > [...] > > The "choke" affects other devices on the system too, notably libata, which > > does not recover gracefully. In my logs, I see a stream of: > > > >

Re: 2.6.24-rc3, 4GB RAM, swiotlb, r8169, out of space

2007-11-24 Thread Francois Romieu
Alan Cox <[EMAIL PROTECTED]> : [...] > You seem to have a leak, which actually isn't suprising > > rtl8169_xmit_frags allocates a set of maps for a fragmented packet > > rtl8169_start_xmit allocates a buffer > > When we finish the transit we free the main buffer (always using skb->le

Re: 2.6.24-rc3, 4GB RAM, swiotlb, r8169, out of space

2007-11-24 Thread Francois Romieu
Alistair John Strachan <[EMAIL PROTECTED]> : [...] > The "choke" affects other devices on the system too, notably libata, which > does not recover gracefully. In my logs, I see a stream of: > > DMA: Out of SW-IOMMU space for 7222 bytes at device :04:00.0 > DMA: Out of SW-IOMMU space for 7222

Re: r8169 crash

2007-11-19 Thread Francois Romieu
On Sun, 18 Nov 2007 22:00:38 +0100, Francois Romieu wrote > > Denys <[EMAIL PROTECTED]> : [...] > > I'll take care of it once I am done with the sis190 watchdog failure > > (nothing hard, simply ugly). Actually I lack a reliable indication that the Tx process is stuck.

Re: r8169 crash

2007-11-18 Thread Francois Romieu
Denys <[EMAIL PROTECTED]> : > > Before it happens on 2.6.22, i tried to attach good cable, plug-unplug, > whatever, interface up/down - card still remains dead. A few things have changed since 2.6.22 but I'll take that it is a real bug and that 2.6.23 would not recover either. Can you fill a PR

Re: r8169 crash

2007-11-17 Thread Francois Romieu
Denys <[EMAIL PROTECTED]> : [...] > After that i have. > Nov 15 22:11:37 vzone NETDEV WATCHDOG: eth1: transmit timed out > Nov 15 22:11:49 vzone NETDEV WATCHDOG: eth1: transmit timed out > Nov 15 22:12:01 vzone NETDEV WATCHDOG: eth1: transmit timed out > Nov 15 22:12:13 vzone NETDEV WATCHDOG: eth1:

Re: [Bugme-new] [Bug 9386] New: sis190 network driver crash

2007-11-15 Thread Francois Romieu
David Miller <[EMAIL PROTECTED]> : [...] > I wonder if somehow sis190_phy_task() is creating some kind > of deadlock when handling the link down and up events. I should be able to test it during the week end if nobody beats me The sis190 stands headless in the kitchen. Given the current situation

Re: [PATCH] ipconfig.c : implement DHCP Class-identifier

2007-11-14 Thread Francois Romieu
Rainer Jochem <[EMAIL PROTECTED]> : [...] > --- net/ipv4/ipconfig.c.orig 2007-11-14 09:16:15.800566536 +0100 > +++ net/ipv4/ipconfig.c 2007-11-14 10:34:22.471219274 +0100 > @@ -139,6 +139,8 @@ __be32 ic_servaddr = NONE;/* Boot serve > __be32 root_server_addr = NONE; /* Address

Re: Problems with ULI 526x driver

2007-11-13 Thread Francois Romieu
Timur Tabi <[EMAIL PROTECTED]> : [...] > Update: I can ping anything on my subnet, but nothing else. Also, it looks > like my MAC address is hosed: [...] > It turns out that the driver is getting the MAC address from the ID table: > > if(((u16 *) db->srom)[0] == 0x || ((u16 *) db->srom

Re: SIS190.c

2007-11-09 Thread Francois Romieu
j gleacher <[EMAIL PROTECTED]> : [sorry for the delay, I was busy] > I'm not sure how to properly send you this information about subject, > but with a new Acer Desktop I needed to add 0x0968 to the below to > get the eth0 recognized. Ok. Can you check the patch below against 2.6.24-rc2 ? diff --

[PATCH 02/05] r8169: do not enable the TBI for the 8168 and the 81x0

2007-11-08 Thread Francois Romieu
The 8168c and the 8100e choke on it. I have not seen an indication nor received a report that the TBI is being actively used on the remaining 8168b and 8110. Let's disable it for now until someone complains. Signed-off-by: Francois Romieu <[EMAIL PROTECTED]> Cc: Matthias Winkler <[E

[PATCH 04/05] r8169: revert 7da97ec96a0934319c7fbedd3d38baf533e20640 (bis repetita)

2007-11-08 Thread Francois Romieu
RTL_GIGA_MAC_VER_17 breaks as well. Signed-off-by: Mark Lord <[EMAIL PROTECTED]> Signed-off-by: Francois Romieu <[EMAIL PROTECTED]> Cc: Edward Hsu <[EMAIL PROTECTED]> --- drivers/net/r8169.c | 16 1 files changed, 0 insertions(+), 16 deletions(-) diff -

[PATCH 03/05] r8169: revert 7da97ec96a0934319c7fbedd3d38baf533e20640 (partly)

2007-11-08 Thread Francois Romieu
Various symptoms depending on the .config options: - the card stops working after some (short) time - the card does not work at all - the card disappears (nothing in lspci/dmesg) A real power-off is needed to recover the card. Signed-off-by: Mark Lord <[EMAIL PROTECTED]> Signed-off-by: Fr

[PATCH 05/05] r8169: prevent bit sign expansion error in mdio_write

2007-11-08 Thread Francois Romieu
Oops. The current code does not like being given an u16 with the highest bit set as an argument to mdio_write. Let's enforce a correct range of values for both the register address and value (resp. 5 and 16 bits). The callers are currently left as-is. Signed-off-by: Francois Romieu &l

[PATCH 00/05] pull request for 'upstream-jeff' branch

2007-11-08 Thread Francois Romieu
76ea471a69883455 db1470271c581050dcacc6ed681b9166d30bdba0 Diffstat drivers/net/r8169.c | 26 +++--- 1 files changed, 7 insertions(+), 19 deletions(-) Shortlog Ciaran McCreesh (1): r8169: add PCI ID for the 8168 in the Abit Fatal1ty F-190HD motherboard Francois Romieu (2):

[PATCH 01/05] r8169: add PCI ID for the 8168 in the Abit Fatal1ty F-190HD motherboard

2007-11-08 Thread Francois Romieu
Signed-off-by: Ciaran McCreesh <[EMAIL PROTECTED]> Signed-off-by: Francois Romieu <[EMAIL PROTECTED]> Cc: Edward Hsu <[EMAIL PROTECTED]> --- drivers/net/r8169.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers/net/r8169.c b/drivers/net/r81

Re: [PATCH 01/02] r8169: add PCI ID for the 8168 in the Abit Fatal1ty F-190HD motherboard

2007-11-06 Thread Francois Romieu
Stephen Hemminger <[EMAIL PROTECTED]> : [...] > Really, vendor_id is 1 ? Yes, the bug seems to be commonly set in hardware. > How about a comment about which board this is. B3w4r3 0f Th3 3v1l Fatal1ty M0b0 ? Imho 'git log/blame' will provide enough information for this hack. -- Ueimor - To un

[PATCH 01/02] r8169: add PCI ID for the 8168 in the Abit Fatal1ty F-190HD motherboard

2007-11-06 Thread Francois Romieu
Signed-off-by: Ciaran McCreesh <[EMAIL PROTECTED]> Signed-off-by: Francois Romieu <[EMAIL PROTECTED]> Cc: Edward Hsu <[EMAIL PROTECTED]> --- drivers/net/r8169.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers/net/r8169.c b/drivers/net/r81

[PATCH 02/02] r8169: do not enable the TBI for the 8168 and the 81x0

2007-11-06 Thread Francois Romieu
The 8168c and the 8100e choke on it. I have not seen an indication nor received a report that the TBI is being actively used on the remaining 8168b and 8110. Let's disable it for now until someone complains. Signed-off-by: Francois Romieu <[EMAIL PROTECTED]> Cc: Matthias Winkler <[E

[PATCH 00/02] pull request for 'upstream-jeff' branch

2007-11-06 Thread Francois Romieu
bit Fatal1ty F-190HD motherboard Francois Romieu (1): r8169: do not enable the TBI for the 8168 and the 81x0 Patch - diff --git a/drivers/net/r8169.c b/drivers/net/r8169.c index b94fa7e..9dbab3f 100644 --- a/drivers/net/r8169.c +++ b/drivers/net/r8169.c @@ -171,6 +171,8 @@ static

Re: [PATCH]: Fix IP1000 config dependencies.

2007-10-31 Thread Francois Romieu
David Miller <[EMAIL PROTECTED]> : [...] > Noticed during some randconfig runs. > > [NET]: IP1000 driver needs MII. It is fixed as of bbd82f956e0db6190b16a8a00d3ed5d979f488e8. -- Ueimor - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTEC

Re: 2.6.24-rc1 kills onboard r8169 (rtl8111b) NIC

2007-10-28 Thread Francois Romieu
Sergey S. Kostyliov <[EMAIL PROTECTED]> : [...] > After booting 2.6.24-rc1 on my home machine I lost onboard rtl8111b > network card. It is neither functional nor even visible by lspci > anymore. > > Moreover rebooting to previous 2.6.23-rc9 didn't fix it - card was > still not available. It shou

[PATCH 04/04] ipg: Kconfig whitepaces/tab damages

2007-10-28 Thread Francois Romieu
Signed-off-by: Francois Romieu <[EMAIL PROTECTED]> Cc: Avuton Olrich <[EMAIL PROTECTED]> Cc: Jesse Huang <[EMAIL PROTECTED]> Cc: Sorbica Shieh <[EMAIL PROTECTED]> --- drivers/net/Kconfig | 12 ++-- 1 files changed, 6 insertions(+), 6 deletions(-) diff --git

[PATCH 03/04] ipg: missing Kconfig dependency

2007-10-28 Thread Francois Romieu
' drivers/built-in.o: In function `ipg_set_settings': drivers/net/ipg.c:2193: undefined reference to `mii_ethtool_sset' drivers/built-in.o: In function `ipg_nway_reset': drivers/net/ipg.c:2205: undefined reference to `mii_nway_restart' make: *** [.tmp_vmlinux1] Error 1

[PATCH 02/04] r8169: remove poll_locked logic

2007-10-28 Thread Francois Romieu
Disabling napi polling early is well enough. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> Signed-off-by: Francois Romieu <[EMAIL PROTECTED]> Cc: Edward Hsu <[EMAIL PROTECTED]> --- drivers/net/r8169.c | 12 1 files changed, 4 insertions(+), 8 deletion

[PATCH 01/04] r8169: napi config

2007-10-28 Thread Francois Romieu
Don't call napi_disable if not configured and make sure that any misuse of napi_xxx in future fails with a compile error. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> Signed-off-by: Francois Romieu <[EMAIL PROTECTED]> Cc: Edward Hsu <[EMAIL PROTECTED]> --- dri

[PATCH 00/04] pull request for 'upstream-jeff' branch

2007-10-28 Thread Francois Romieu
anged, 13 insertions(+), 12 deletions(-) Shortlog ---- Francois Romieu (2): ipg: missing Kconfig dependency ipg: Kconfig whitepaces/tab damages Stephen Hemminger (2): r8169: napi config r8169: remove poll_locked logic Patch - diff --git a/drivers/net/Kconfig b

Re: [PATCH] r8169: don't call napi_disable if not doing NAPI

2007-10-26 Thread Francois Romieu
emminger <[EMAIL PROTECTED]> Acked-off-by: Francois Romieu <[EMAIL PROTECTED]> -- Ueimor - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: Fried r8169.

2007-10-25 Thread Francois Romieu
Tom Prince <[EMAIL PROTECTED]> : > While testing Linux v2.6.24-rc1, I noticed that my onboard r8169 had > disappeared, and the it remained gone when I rebooted to v2.6.23 and v2.6.22, > where it had previously worked. [...] > I am running x86_64 ASUS Z92T laptop (an OEM version of the A6T). > > I

Re: [PATCH 13/13] r8169: more phy init for the 8168

2007-10-24 Thread Francois Romieu
Glen Gray <[EMAIL PROTECTED]> : > Are any of these likely to fix the Ethernet multicast issues a few of us > have seen with 8110sc cards ? No, this serie is not expected to. I have planned to work on it again during the bugfix phase of 2.6.24-rc. Is it still an option for you to use the old rea

[PATCH 06/13] r8169: use the existing symbolic name of vendor PCI ID 0x1259

2007-10-18 Thread Francois Romieu
Signed-off-by: Francois Romieu <[EMAIL PROTECTED]> Cc: Edward Hsu <[EMAIL PROTECTED]> --- drivers/net/r8169.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/r8169.c b/drivers/net/r8169.c index 951c56e..c290aa5 100644 --- a/drivers/net/r8169.c +

<    1   2   3   4   5   6   7   8   9   >