On Wed, Jan 03, 2007 at 09:07:11AM +0100, Jarek Poplawski wrote:
On Tue, Jan 02, 2007 at 03:35:39PM -0800, David Stevens wrote:
I've looked at this a little too -- it'd be nice to know who holds
the write lock.
If you mean mc_list_lock - probably nobody - it's
not initialized (so
On Tue, Jan 02, 2007 at 03:32:01PM +, Sid Boyce wrote:
Jarek Poplawski wrote:
...
If you could send full ifconfig, route -n (or ip route
if you use additional tables) and tcpdump (all packets)
from both boxes while pinging each other and a few words
how it is connected (other cards, other
On Thu, Jan 04, 2007 at 07:29:30PM +1100, Herbert Xu wrote:
On Thu, Jan 04, 2007 at 09:03:51AM +0100, Jarek Poplawski wrote:
I doubt this is the right solution. It certainly
could fix this particular situation but my main
point was packets shouldn't get into kernel
receive queues
On Thu, Jan 04, 2007 at 09:27:07PM +1100, Herbert Xu wrote:
On Thu, Jan 04, 2007 at 09:50:14AM +0100, Jarek Poplawski wrote:
Could you explain? I can see some inet_rtm_newaddr
interrupted. For me it could be e.g.:
after
vconfig add eth0 9
ip addr add dev eth0.9 ...
Whether
return NULL so check is needed in device_cmp.
Signed-off-by: Jarek Poplawski [EMAIL PROTECTED]
---
diff -Nurp linux-2.6.20-rc3-/net/ipv4/netfilter/ipt_MASQUERADE.c
linux-2.6.20-rc3/net/ipv4/netfilter/ipt_MASQUERADE.c
--- linux-2.6.20-rc3-/net/ipv4/netfilter/ipt_MASQUERADE.c 2006-12-18
09
On Thu, Jan 04, 2007 at 12:33:33PM -0800, David Miller wrote:
From: Herbert Xu [EMAIL PROTECTED]
Date: Thu, 04 Jan 2007 17:26:27 +1100
David Stevens [EMAIL PROTECTED] wrote:
You're right, I don't know whether it'll fix the problem Ben saw
or not, but it looks like the original
On Wed, Jan 03, 2007 at 04:53:58PM +, Sid Boyce wrote:
...
It seems =2.6.19 and the SuSEfirewall are incompatible.
Actually, many programs could be incomapatible with
newer kernel versions, so sometimes upgrades or at
least recompilations are needed.
...
There is still the problem where
On Wed, Jan 03, 2007 at 11:16:59PM +, Jon Maloy wrote:
See my comments below.
Regards
///jon
Jarek Poplawski wrote:
..
Maybe I misinterpret this but, IMHO lockdep
complains about locks acquired in different
order: tipc_ref_acquire() gets ref_table_lock
On Thu, Jan 04, 2007 at 04:16:20PM +, Jon Maloy wrote:
Regards
///jon
Jarek Poplawski wrote:
I know lockdep is sometimes
too careful but nevertheless some change is needed
to fix a real bug or give additional information
to lockdep.
I don't know lockdep well enough yet
On Fri, Jan 05, 2007 at 08:38:47PM +1100, Herbert Xu wrote:
On Fri, Jan 05, 2007 at 07:38:44AM +0100, Jarek Poplawski wrote:
I'd only suggest to change goto out; to
return NULL; at the end of inetdev_init because
now RCU is engaged unnecessarily.
I agree. The RCU assignment should
On Fri, Jan 05, 2007 at 10:23:53PM +1100, Herbert Xu wrote:
On Fri, Jan 05, 2007 at 12:19:10PM +0100, Jarek Poplawski wrote:
Why me? (I didn't spoil this!)
You spotted the problem, so it's only fair that you get the credit :)
Strange... It recalls me the army now! (many years ago)
Jarek
On Thu, Jan 04, 2007 at 09:04:29AM -0800, Ben Greear wrote:
Jarek Poplawski wrote:
On Thu, Jan 04, 2007 at 09:27:07PM +1100, Herbert Xu wrote:
On Thu, Jan 04, 2007 at 09:50:14AM +0100, Jarek Poplawski wrote:
Could you explain? I can see some inet_rtm_newaddr
interrupted. For me
On Fri, Jan 05, 2007 at 12:33:43PM -0800, Ben Greear wrote:
...
So, I do believe this was the problem we were hitting, and it seems fixed.
Congratulations!
But I can see one strange thing in vlan.c:
/* Must be invoked with RCU read lock (no preempt) */
static struct vlan_group
On Thu, Jan 04, 2007 at 02:51:55PM +0100, Jarek Poplawski wrote:
Hello,
Below I attach a patch proposal.
It seems I wasted some time...
I wonder if there is any reason to forward netfilter
bugs to netdev if patches from netfilter aren't cc-d
here? It seems netfilter is really independent
On 04-01-2007 21:04, Paul Moore wrote:
...
+++ net-2.6.20_bugfix_2/net/ipv4/af_inet.c
@@ -305,7 +305,7 @@ lookup_protocol:
sk-sk_reuse = 1;
inet = inet_sk(sk);
- inet-is_icsk = INET_PROTOSW_ICSK answer_flags;
+ inet-is_icsk = (INET_PROTOSW_ICSK answer_flags)
On Mon, Jan 08, 2007 at 10:03:50AM -0800, Stephen Hemminger wrote:
On Mon, 08 Jan 2007 08:57:10 -0800
Ben Greear [EMAIL PROTECTED] wrote:
Jarek Poplawski wrote:
On Fri, Jan 05, 2007 at 12:33:43PM -0800, Ben Greear wrote:
...
So, I do believe this was the problem we were
On Mon, Jan 08, 2007 at 09:47:29AM -0500, Paul Moore wrote:
...
I guess it all depends on who is reading it ;)
Sure! I only had a feeling your way is maybe slightly
less often used so I wanted some opinion.
Personally, I don't care too
much either way as long as it is fixed.
Yes, you've
On Tue, Jan 09, 2007 at 11:56:59AM +0100, Thibaut VARENE wrote:
...
I'm suspecting the driver, but I'm not a specialist :)
No problem, me also!
I've also suspected the driver, looked at the
code, found nothing yet (as expected), but this
info about exception in malloc, introduces some
doubts...
On Tue, Jan 09, 2007 at 11:27:59AM +0100, Thibaut VARENE wrote:
...
I suspected both and changed both the disk and the ram for quality
parts, that I tested afterwards. Both passed thorough tests.
Finally, using the other NIC on the box (a VIA Rhine II, 100Mbps),
works absolutely fine.
If
On Tue, Jan 09, 2007 at 09:10:45AM +0100, Jarek Poplawski wrote:
On Mon, Jan 08, 2007 at 10:03:50AM -0800, Stephen Hemminger wrote:
...
* Must be invoked with RCU read lock (no preempt)
*/
struct net_device *__find_vlan_dev(struct net_device *real_dev,
...
But later
On Tue, Jan 09, 2007 at 09:26:46AM -0500, Paul Moore wrote:
On Tuesday 09 January 2007 3:43 am, Jarek Poplawski wrote:
... But if you consider this code will probably become classical
and will be read, quoted and teached next 1000 years, then the style
could matter...
This from the guy
On Wed, Jan 10, 2007 at 10:04:11AM +0100, Jarek Poplawski wrote:
...
It looks like you're talking about the right thing
and I'm a fool again! Now I try to find why I even
had to pay for this. I read again and again adequate
chapters from R. Love and C. Benvenuti's books, see
a lot about
On Wed, Jan 10, 2007 at 08:13:57AM -0500, Paul Moore wrote:
On Wednesday 10 January 2007 5:01 am, Jarek Poplawski wrote:
On Tue, Jan 09, 2007 at 09:26:46AM -0500, Paul Moore wrote:
On Tuesday 09 January 2007 3:43 am, Jarek Poplawski wrote:
... But if you consider this code will probably
On Wed, Jan 10, 2007 at 12:01:23PM -0800, Stephen Hemminger wrote:
...
Don't rely on books too heavily, they can get out of date
with a simple code change.
I've tried to find this in the code at the beginning
and got mislead by the path with PREEMPT_BKL.
I think the books are necessary to get
On Wed, Jan 10, 2007 at 11:40:35PM -0800, David Miller wrote:
From: Jarek Poplawski [EMAIL PROTECTED]
Date: Thu, 11 Jan 2007 08:24:28 +0100
Yesterday I did what I should do earlier - checked
this simple way, with printk, and now I have no doubts
it's a bug: if you add or remove vlan
On Thu, Jan 11, 2007 at 09:29:58AM +0100, Jarek Poplawski wrote:
On Wed, Jan 10, 2007 at 11:40:35PM -0800, David Miller wrote:
From: Jarek Poplawski [EMAIL PROTECTED]
Date: Thu, 11 Jan 2007 08:24:28 +0100
Yesterday I did what I should do earlier - checked
this simple way, with printk
On Thu, Jan 11, 2007 at 09:35:26AM +0100, Jarek Poplawski wrote:
On Thu, Jan 11, 2007 at 09:29:58AM +0100, Jarek Poplawski wrote:
On Wed, Jan 10, 2007 at 11:40:35PM -0800, David Miller wrote:
From: Jarek Poplawski [EMAIL PROTECTED]
Date: Thu, 11 Jan 2007 08:24:28 +0100
Yesterday I
to do
the test with a kernel compiled without PREEMPT and SMP,
but if irqs nothing should change...
Regards,
Jarek P.
PS: alas I didn't even check compiling - I had no time to
find all compile dependencies of this driver
---
Signed-off-by: Jarek Poplawski [EMAIL PROTECTED]
---
diff -Nurp linux
On Thu, Jan 11, 2007 at 01:27:55AM -0800, David Miller wrote:
From: Jarek Poplawski [EMAIL PROTECTED]
Date: Thu, 11 Jan 2007 09:39:34 +0100
Sure, but is this even legal to be preempted during
reading or modifying rcu list or be blocked while
holding rcu protected pointer? Doesn't
On Thu, Jan 11, 2007 at 09:42:13AM -0800, Stephen Hemminger wrote:
Paul McKenney has given lots of talks on RCU see:
http://www.rdrop.com/users/paulmck/RCU/
and look in Documentation/RCU
I've read a lot of this but it's sometimes confusing e.g.:
From Documentation/RCU/checklist.txt:
On 10-01-2007 01:23, Bernhard Schmidt wrote:
On Tue, Jan 09, 2007 at 08:36:24PM +0100, Bernhard Schmidt wrote:
...
I'm having a really ugly problem I'm trying to pinpoint, but failed so
far. I'm neither completely convinced it is not related to my local
setup(s), nor do I have any clue how
On 09-01-2007 17:08, [EMAIL PROTECTED] wrote:
Hello,
I have been trying to get the RED qdisc and ECN to work for the past few weeks
and all my experiments have failed. Here is the setup I am using.
Src -- R1 -- R2 -- Dst
Between Src and R1 is a 100Mbps link and between R1 and R2 a
On 10-01-2007 11:01, Patrick McHardy wrote:
[IPROUTE]: Replace usec by time in function names
Rename functions containing usec since they don't necessarily return
usec units anymore.
Signed-off-by: Patrick McHardy [EMAIL PROTECTED]
---
...
diff --git a/tc/q_cbq.c b/tc/q_cbq.c
index
On 10-01-2007 11:01, Patrick McHardy wrote:
[IPROUTE]: Introduce tc_calc_xmitsize and use where appropriate
Add tc_calc_xmitsize() as complement to tc_calc_xmittime(), which calculates
the size that can be transmitted at a given rate during a given time.
Replace all expressions of the form
On 10-01-2007 11:01, Patrick McHardy wrote:
[IPROUTE]: Use tc_calc_xmittime where appropriate
Replace expressions of the form 100 * size/rate by tc_calc_xmittime().
The CBQ case deserves an extra comment: when called with bnwd=rate
tc_cbq_calc_maxidle behaves identical to
On Tue, Jan 16, 2007 at 11:19:34AM +0100, Patrick McHardy wrote:
...
Right, this changes it from long (tc_core_usec2tick) to unsigned
int. It doesn't make any difference though, ...
... if we count out reading_time_2tick, of course.
Jarek P.
-
To unsubscribe from this list: send the line
On Tue, Jan 16, 2007 at 01:28:52PM +0100, Patrick McHardy wrote:
Jarek Poplawski wrote:
On Tue, Jan 16, 2007 at 11:19:34AM +0100, Patrick McHardy wrote:
...
Right, this changes it from long (tc_core_usec2tick) to unsigned
int. It doesn't make any difference though, ...
... if we
On Thu, Jan 11, 2007 at 02:08:16PM +0100, Bernhard Schmidt wrote:
Jarek Poplawski wrote:
ip -6 route:
2001:4ca0:0:f000::/64 dev eth0 proto kernel metric 256 expires
86322sec mtu 1500 advmss 1440 fragtimeout 4294967295
fe80::/64 dev eth0 metric 256 expires 21225804sec mtu 1500 advmss
On Wed, Jan 17, 2007 at 09:14:20AM +0100, Jarek Poplawski wrote:
...
I've a look at this once more and have one more doubt:
probably it's some other ip6 trick again, but why this
default router doesn't have normal address in the
same segment (2001:4ca0:.../64)?
Sorry, I see it's OK (except
of ip_summed field from collapsed
skb. This patch reverts this change.
All substantial work including heavy testing and diagnosing by:
Michael Tokarev [EMAIL PROTECTED]
Signed-off-by: Jarek Poplawski [EMAIL PROTECTED]
---
diff -Nurp linux-2.6.19-/net/ipv4/tcp_output.c
linux-2.6.19/net/ipv4/tcp_output.c
On Fri, Jan 19, 2007 at 04:20:01PM +0300, Michael Tokarev wrote:
...
Well.. I just tried it - with this patch applied, no more bad checksums
are shown. Tried from the network that triggers it most reliable - and
wasn't able to reproduce the bad behavior.
I'm running a tcpdump right now,
On Fri, Jan 19, 2007 at 01:14:52PM +0100, Patrick McHardy wrote:
Jarek Poplawski wrote:
Here is my patch proposal. If I'm not totally wrong,
there is a possibility that, during collapsing, empty
skb with FIN is added to normal packet and changes
its ip_summed field to CHECKSUM_NONE
On Sat, Jan 20, 2007 at 08:10:27AM +1100, Herbert Xu wrote:
On Fri, Jan 19, 2007 at 12:06:41PM +0100, Jarek Poplawski wrote:
[PATCH][NET] tcp_output: rare bad TCP checksum with 2.6.19
The patch Replace CHECKSUM_HW by CHECKSUM_PARTIAL/CHECKSUM_COMPLETE
changed to unconditional copying
On Fri, Jan 19, 2007 at 03:08:20PM +0100, Jarek Poplawski wrote:
...
You are welcome! But you probably didn't read this with
attention: if it works, you should thank mainly to that
other guy...
Btw. I can't remember I've seen such ferocious testing
ever!
After checking in the dictionary I
On Mon, Jan 22, 2007 at 10:19:18AM +0300, Michael Tokarev wrote:
...
I was only running tcpdump - yes, it was running almost the
whole day, with different options. I did almost nothing.
You over-estimate my contribution, really ;)
The very good thing is that this bug is now found, and
On Mon, Jan 22, 2007 at 06:45:57PM +1100, Herbert Xu wrote:
On Mon, Jan 22, 2007 at 07:52:14AM +0100, Jarek Poplawski wrote:
I was so impressed by the amount of work done by Michael
that I magnified his merit and forgot to mention the role
of Patrick and Herbert, particularly here
On Sun, Jan 21, 2007 at 02:02:15PM +0100, Thibaut VARENE wrote:
On 1/21/07, Thibaut VARENE [EMAIL PROTECTED] wrote:
...
Hmm, I think this is guaranteed not to work. In between those lines
the lock is released, while data in the mp structure is still being
accessed. It seems that this bit of
is called mostly while
mp-tx_desc_count == 0 or 1.
- Patch follows -
From: Dale Farnsworth [EMAIL PROTECTED]
mv643xx_eth: Fix race condition in mv643xx_eth_free_tx_descs
The bug was found and isolated by Thibaut VARENE [EMAIL PROTECTED]
and Jarek Poplawski [EMAIL PROTECTED
,
Jarek P.
---
[PATCH][NET_SCHED] sch_htb: htb_class optimization
htb_class_leaf and htb_class_inner are separated from
main htb_class structure to use memory more effectively.
Signed-off-by: Jarek Poplawski [EMAIL PROTECTED]
---
diff -Nurp linux-2.6.20-rc5-/net/sched/sch_htb.c
linux-2.6.20
On 26-01-2007 04:37, Masayuki Nakagawa wrote:
This patch simply replaces __kfree_skb() in exit path with kfree_skb().
In tcp_rcv_state_process(), generally skbs should be destroyed only when
the ref count is zero.
That is the way things are supposed to be done in the kernel.
This change
On Fri, Jan 26, 2007 at 08:16:06PM +1100, Herbert Xu wrote:
On Fri, Jan 26, 2007 at 09:28:38AM +0100, Jarek Poplawski wrote:
So maybe for some time there should be added skb-users
test with a warning to reveal this?
Or just replace __kfree_skb by kfree_skb. The atomic operation
On Fri, Jan 26, 2007 at 08:52:51PM +1100, Herbert Xu wrote:
On Fri, Jan 26, 2007 at 10:49:50AM +0100, Jarek Poplawski wrote:
How do we know about those improper deals?
I understand there should be no other users here
if it's __kfree_skb now. So I mean to test and warn
before kfree_skb
On Fri, Jan 26, 2007 at 09:45:18PM +1100, Herbert Xu wrote:
On Fri, Jan 26, 2007 at 11:18:38AM +0100, Jarek Poplawski wrote:
I don't mean it's necessary. I mean now skb is freed
unconditionally and after this patch, if there is some
error in counting, skb will stay. I thought Masayuki
On Fri, Jan 26, 2007 at 12:02:35PM +0100, Jarek Poplawski wrote:
On Fri, Jan 26, 2007 at 09:45:18PM +1100, Herbert Xu wrote:
On Fri, Jan 26, 2007 at 11:18:38AM +0100, Jarek Poplawski wrote:
I don't mean it's necessary. I mean now skb is freed
unconditionally and after this patch
On Fri, Jan 26, 2007 at 02:18:08PM +0100, Jarek Poplawski wrote:
...
I've only now read the original thread of this problem
and this long note about security. I need more time to
understand this, but now I'm not sure Masayuki's server
isn't doing something against the policy of this note
On Fri, Jan 26, 2007 at 09:45:18PM +1100, Herbert Xu wrote:
On Fri, Jan 26, 2007 at 11:18:38AM +0100, Jarek Poplawski wrote:
I don't mean it's necessary. I mean now skb is freed
unconditionally and after this patch, if there is some
error in counting, skb will stay. I thought Masayuki
On Mon, Jan 29, 2007 at 09:26:16AM +0100, Jarek Poplawski wrote:
...
So this patch is changing it to ipv6 way. It seems to
be quite brave. I think there was some reason to do
this old way and I hope consequences were analyzed.
...
But since Alexey Kuznetsov accepted this change too
Hello,
This patch adds a dump_stats callback to enable
printing of basic statistics of prio classes.
Signed-off-by: Jarek Poplawski [EMAIL PROTECTED]
---
diff -Nurp linux-2.6.20-rc6-/net/sched/sch_prio.c
linux-2.6.20-rc6/net/sched/sch_prio.c
--- linux-2.6.20-rc6-/net/sched/sch_prio.c
On 30-01-2007 16:04, Alexey Dobriyan wrote:
On Tue, Jan 30, 2007 at 03:34:18AM -0800, David Stevens wrote:
I think you're correct-- looks like it needs:
if (!skb)
return NULL;
just before the skb_put(), since an allocation (and failure)
could occur in either
On Wed, Jan 31, 2007 at 02:47:55PM +0100, Patrick McHardy wrote:
Jarek Poplawski wrote:
This patch adds a dump_stats callback to enable
printing of basic statistics of prio classes.
diff -Nurp linux-2.6.20-rc6-/net/sched/sch_prio.c
linux-2.6.20-rc6/net/sched/sch_prio.c
--- linux
(Take 2)
This patch adds a dump_stats callback to enable
printing of basic statistics of prio classes.
Signed-off-by: Jarek Poplawski [EMAIL PROTECTED]
---
diff -Nurp linux-2.6.20-rc6-/net/sched/sch_prio.c
linux-2.6.20-rc6/net/sched/sch_prio.c
--- linux-2.6.20-rc6-/net/sched/sch_prio.c
On Wed, Jan 31, 2007 at 03:37:25PM +0100, Patrick McHardy wrote:
Jarek Poplawski wrote:
+static int prio_dump_class_stats(struct Qdisc *sch, unsigned long cl,
+struct gnet_dump *d)
+{
+ struct prio_sched_data *q = qdisc_priv(sch);
+ struct Qdisc *cl_q
On Wed, Jan 31, 2007 at 04:06:05PM +0100, Patrick McHardy wrote:
Jarek Poplawski wrote:
From sch_api.c:
if (cl_ops-dump cl_ops-dump(q, cl, skb, tcm) 0)
goto rtattr_failure;
if (gnet_stats_start_copy_compat(skb, TCA_STATS2, TCA_STATS
(Take 3)
This patch adds a dump_stats callback to enable
printing of basic statistics of prio classes.
(With help of Patrick McHardy).
Signed-off-by: Jarek Poplawski [EMAIL PROTECTED]
---
diff -Nurp linux-2.6.20-rc6-/net/sched/sch_prio.c
linux-2.6.20-rc6/net/sched/sch_prio.c
--- linux-2.6.20
On 02-02-2007 12:53, Fagyal Csongor wrote:
Thomas Glanzmann wrote:
...
Next time sky2 hangs on me I'll try to reset the PHY and see if that
helps. I can usually trigger the hang by doing a couple of ifconfig
up/down on the interface, though I'm not getting any error message
from the driver
On Fri, Feb 02, 2007 at 02:43:11PM +0100, Jarek Poplawski wrote:
On 02-02-2007 12:53, Fagyal Csongor wrote:
Thomas Glanzmann wrote:
...
Is this with this yesterday sky2-tx-recover.patch applied?
I mean hung-ups - not ethtool.
Regards,
Jarek P.
-
To unsubscribe from this list: send the line
On 01-02-2007 12:30, Andi Kleen wrote:
Simon Lodal [EMAIL PROTECTED] writes:
Memory is generally not an issue, but CPU is, and you can not beat the CPU
efficiency of plain array lookup (always faster, and constant time).
Probably for some old (or embedded) lean boxes used for
small network
After hlist_del() next and pprev pointers are not NULL
so hlist_unhashed() doesn't work properly.
Signed-off-by: Jarek Poplawski [EMAIL PROTECTED]
---
diff -Nurp linux-2.6.19-rc4-git10-/net/sched/sch_htb.c
linux-2.6.19-rc4-git10/net/sched/sch_htb.c
--- linux-2.6.19-rc4-git10-/net/sched
On Mon, Nov 06, 2006 at 09:44:49AM -0800, Stephen Hemminger wrote:
On Mon, 6 Nov 2006 12:33:53 +0100
Jarek Poplawski [EMAIL PROTECTED] wrote:
After hlist_del() next and pprev pointers are not NULL
so hlist_unhashed() doesn't work properly.
Signed-off-by: Jarek Poplawski [EMAIL
On Tue, Nov 07, 2006 at 09:50:07AM -0800, Stephen Hemminger wrote:
On Tue, 7 Nov 2006 07:49:43 +0100
Jarek Poplawski [EMAIL PROTECTED] wrote:
...
Your patch duplicated the code in hlist_del_init(). Why not do:
--- a/net/sched/sch_htb.c 2006-11-07 09:48:22.0 -0800
+++ b/net
On 10-11-2006 07:08, Paul Moore wrote:
...
An Introduction To Using Generic Netlink
===
...
Here is a proposal of small adjustments.
Maybe some of them will be useful.
Best regards,
Jarek P.
---
--- netlink.txt-
On Fri, Nov 10, 2006 at 06:36:42PM +0100, Thomas Graf wrote:
* Jarek Poplawski [EMAIL PROTECTED] 2006-11-10 14:24
@@ -449,7 +449,7 @@
The second step is to define the operations for the family, which we do by
creating at least one instance of the genl_ops structure which we
On Fri, Nov 10, 2006 at 06:36:42PM +0100, Thomas Graf wrote:
* Jarek Poplawski [EMAIL PROTECTED] 2006-11-10 14:24
@@ -449,7 +449,7 @@
The second step is to define the operations for the family, which we do by
creating at least one instance of the genl_ops structure which we
On Mon, Nov 13, 2006 at 02:58:17PM -0500, Paul Moore wrote:
Jarek Poplawski wrote:
@@ -586,7 +586,7 @@
goto failure;
}
/* add a DOC_EXMPL_A_MSG attribute */
- rc = nla_put_string(skb, DOC_EXMPL_A_MSG, Generic Netlink Rocks);
+ rc = nla_put_string(skb, DOC_EXMPL_A_MSG
Hello,
With great astonishment I've found none of
these networking names in the CREDITS file:
Stephen Hemminger, Thomas Graf, Alexey Kuznetsov,
Andrew Morton, Pedro Roque, Jamal Hadi Salim,
Herbert Xu etc.
IMHO there is something wrong with the hitherto
way of updating this file and probably
On Thu, Nov 16, 2006 at 11:25:01PM -0800, Linus Torvalds wrote:
On Fri, 17 Nov 2006, Jarek Poplawski wrote:
With great astonishment I've found none of
these networking names in the CREDITS file:
Stephen Hemminger, Thomas Graf, Alexey Kuznetsov,
Andrew Morton, Pedro Roque, Jamal
(for consistency with htb_delete and htb_destroy) - my own suggestion
PS: qdisc_reset added to htb_delete by P. McHardy's patch: perform qlen
adjustment immediately in -delete should be reconsidered.
Signed-off-by: Jarek Poplawski [EMAIL PROTECTED]
---
diff -Nurp linux-2.6.19-rc6-/net/sched/sch_htb.c
On Mon, Nov 27, 2006 at 10:55:39AM +0100, Patrick McHardy wrote:
Jarek Poplawski wrote:
Here are some fixes proposals suggested by Patrick McHardy.
[NET_SCHED] sch_cbq:
- deactivating of active classes when grafting
- purging of queue/q.qlen adjustment when deleting an active
On Mon, Nov 27, 2006 at 11:12:23AM +0100, Patrick McHardy wrote:
Jarek Poplawski wrote:
Here is a trial to do something suggested by Patrick McHardy.
[NET_SCHED] sch_htb:
- turn intermediate classes into leaves again when their last child is
deleted
(qdisc of deleted class
[NET_SCHED] sch_htb:
[PATCH 2.6.19-rc6 with Fix endless loops set of patches]
- turn intermediate classes into leaves again when their
last child is deleted (struct htb_class changed)
Signed-off-by: Jarek Poplawski [EMAIL PROTECTED]
---
diff -Nurp linux-2.6.19-rc6-endless-/net/sched
On 29-11-2006 05:25, David Miller wrote:
...
commit 93e3a20d6c67a09b867431e7d5b3e7bc97154fab
Author: David S. Miller [EMAIL PROTECTED]
Date: Tue Nov 28 20:24:10 2006 -0800
[NET]: Fix MAX_HEADER setting.
MAX_HEADER is either set to LL_MAX_HEADER or LL_MAX_HEADER + 48, and
On 29-11-2006 08:49, Herbert Xu wrote:
Peter Zijlstra [EMAIL PROTECTED] wrote:
=
[ INFO: possible irq lock inversion dependency detected ]
2.6.19-rc6 #4
-
nc/1854 just changed the
On Thu, Nov 30, 2006 at 01:26:34PM +0100, Patrick McHardy wrote:
Jarek Poplawski wrote:
[NET_SCHED] sch_htb:
[PATCH 2.6.19-rc6 with Fix endless loops set of patches]
- turn intermediate classes into leaves again when their
last child is deleted (struct htb_class changed)
Looks
On Wed, Nov 29, 2006 at 04:16:06PM +0100, Krzysztof Halasa wrote:
Krzysztof Halasa [EMAIL PROTECTED] writes:
I wound't care less btw.
s/wound/couldn/, eh those foreign languages...
So, you say, you don't care about David Miller's credits?
It isn't nice. He could be very disappointed...
On 04-12-2006 16:34, Patrick McHardy wrote:
Fix a regression from my nfmark mask patch for cls_fw.
Thomas, Jamal, do you have an idea what this old method stuff
is used for? It seems it is only used during the below mentioned
race.
Sorry for eavesdropping, but have a look at htb_classify
these functions.
I also hope Yuriy could test this patch (this should apply to
2.6.21-rc4 or later, CONFIG_PROVE_LOCKING = y), thanks.
Reported tested by: Yuriy N. Shkandybin [EMAIL PROTECTED]
Signed-off-by: Jarek Poplawski [EMAIL PROTECTED]
(don't apply without above mentioned acks)
---
diff -Nurp 2.6.21
On 27-03-2007 14:38, Thomas Graf wrote:
The results of FIB rules lookups are cached in the routing cache
except for IPv6 as no such cache exists. So far, it was the
responsibility of the user to flush the cache after modifying any
rules. This lead to many false bug reports due to
On Wed, Mar 28, 2007 at 09:34:36PM +0200, Thomas Graf wrote:
* David Miller [EMAIL PROTECTED] 2007-03-28 11:24
Another idea Thomas and I tossed around was to have some kind of way
for the rule insertion to indicate that the flush should be deferred
and I kind of prefer that explicitness.
On Thu, Mar 29, 2007 at 12:03:26PM +0200, Jarek Poplawski wrote:
...
rt_cache_flush - it's not for all (I know - we don't like
multipath - but untill it's here...)[...]
Sorry, I forgot it's already not there...
Jarek P.
-
To unsubscribe from this list: send the line unsubscribe netdev
On Tue, Apr 03, 2007 at 04:19:46PM +0100, Christian Kujau wrote:
On Tue, 3 Apr 2007, Jarek Poplawski wrote:
Did you try with 8139cp instead of 8139too?
Tried that, 8139cp could not be loaded :(
Sorry for misleading!
(Maybe even try some other card to narrow the problem?)
You could also
On Wed, Apr 04, 2007 at 02:20:23PM +0100, Christian Kujau wrote:
On Wed, 4 Apr 2007, Jarek Poplawski wrote:
So, it's a lot sooner than before. (BTW, isn't there anything
in debug log?)
No, nothing. I've set up remote-syslgging to the other node (node1
logging to node2 and vice versa
On Wed, Apr 11, 2007 at 12:52:28PM +0400, Yuriy N. Shkandybin wrote:
...
On Wed, 11 Apr 2007 09:57:33 +0400 Yuriy N. Shkandybin [EMAIL PROTECTED]
wrote:
I've tested 2.6.21-rc6-mm1
Linux vpn1 2.6.21-rc6-mm1 #4 SMP Wed Apr 11 03:34:26 MSD 2007 x86_64
Intel(R) Pentium(R) D CPU 2.80GHz
On Fri, Apr 06, 2007 at 07:19:25PM +0100, Christian Kujau wrote:
On Wed, 4 Apr 2007, Christian Kujau wrote:
Maybe it's a real locking problem. Here are some more
suggestions for testing (if you don't find anything better):
- try without SMP, so: 'acpi=off lapic nosmp'
We were able to have
On Tue, Apr 17, 2007 at 08:26:32AM -0500, Michal Ostrowski wrote:
The xmit function of a PPP channel is a synchronous operation. If the
transmission fails, we must notify the caller and let them re-submit the
skb later. The return status of dev_queue_xmit is needed to determine
the return
Hi,
I didn't analyse this bug report but probably it
is nearly connected with one of the bugs visible in
a log from this submit:
http://bugzilla.kernel.org/show_bug.cgi?id=8132
On 15-04-2007 02:50, Paul Mackerras wrote:
David Miller writes:
Here is Patrick McHardy's patch:
So this
On Tue, Apr 17, 2007 at 09:37:44AM +0200, Jarek Poplawski wrote:
...
Yuriy - thanks for testing my patch ...(pause) Not!
It seems this patch is not visible in this version - probably
...
Sorry! It was only something with my eyes.
(Probably too much of Pamela!).
Jarek P.
-
To unsubscribe from
On Fri, Apr 20, 2007 at 04:35:15PM -0700, David Miller wrote:
From: Jarek Poplawski [EMAIL PROTECTED]
Date: Mon, 12 Mar 2007 11:24:03 +0100
the ipcomp handler is xfrm6_rcv(), which calls xfrm6_rcv_spi(), which
contrary
to all other handlers returns -1 instead of 0 after calling
On Mon, Apr 23, 2007 at 08:44:16AM +0200, Jarek Poplawski wrote:
On Fri, Apr 20, 2007 at 04:35:15PM -0700, David Miller wrote:
From: Jarek Poplawski [EMAIL PROTECTED]
Date: Mon, 12 Mar 2007 11:24:03 +0100
the ipcomp handler is xfrm6_rcv(), which calls xfrm6_rcv_spi(), which
On Wed, Apr 25, 2007 at 10:27:59AM +0200, Eric Sesterhenn / Snakebyte wrote:
* Herbert Xu ([EMAIL PROTECTED]) wrote:
Jarek Poplawski [EMAIL PROTECTED] wrote:
My proposal is: maybe Eric could change this in
xfrm6_tunnel_rcv() from xfrm6_tunnel.c e.g. like this:
return
(before vlan_netdev_xmit_lock_key) and
lockdep should be notified about this.
Reported tested by: Yuriy N. Shkandybin [EMAIL PROTECTED]
Signed-off-by: Jarek Poplawski [EMAIL PROTECTED]
Cc: Paul Mackerras [EMAIL PROTECTED]
Signed-off-by: Andrew Morton [EMAIL PROTECTED]
I believe
101 - 200 of 612 matches
Mail list logo
