pull-request: wireless-drivers 2016-08-29

Cathy Luo (1): mwifiex: fix large amsdu packets causing firmware hang Felix Fietkau (2): ath9k: fix client mode beacon configuration ath9k: fix using sta->drv_priv before initializing it Kalle Valo (1): Merge ath-current from ath.git mhira...@kernel.org

Re: [PATCH v4] brcmfmac: add missing header dependencies

> increases a noise and patchwork handles this just fine, see: > https://patchwork.kernel.org/patch/9303285/ > https://patchwork.kernel.org/patch/9303285/mbox/ > > > Do I need to resend a patch that fixes two typos(build/add)? or you modify > them > on your way? I can fix those when I commit the patch. -- Kalle Valo

Re: [PATCH v4 2/4] wcn36xx: Transition driver to SMD client

Bjorn Andersson <bjorn.anders...@linaro.org> writes: > On Thu, Sep 8, 2016 at 5:16 AM, Kalle Valo <kv...@codeaurora.org> wrote: >> Bjorn Andersson <bjorn.anders...@linaro.org> writes: >> >>> The wcn36xx wifi driver follows the life cycle of the WL

Re: [1/2] carl9170: Fix wrong completion usage

Daniel Wagner wrote: > From: Daniel Wagner > > carl9170_usb_stop() is used from several places to flush and cleanup any > pending work. The normal pattern is to send a request and wait for the > irq handler to call complete(). The completion is not

Re: [06/26] ath: constify local structures

Julia Lawall wrote: > For structure types defined in the same file or local header files, find > top-level static structure declarations that have the following > properties: > 1. Never reassigned. > 2. Address never taken > 3. Not passed to a top-level macro call > 4. No

Re: [PATCH v4 2/4] wcn36xx: Transition driver to SMD client

just afraid that the hassle would outweight the benefit. > Or we can wait till -rc1 To keep things simple I prefer this option. Of course it means waiting few more extra weeks, but when working with new subsystems that can happen. The crystall ball[1] says that 4.9-rc1 would be released on 2016-10-16 so it's not that far away. [1] http://phb-crystal-ball.org/ -- Kalle Valo

Re: ath10k: remove unused variable ar_pci

Chaehyun Lim wrote: > Trival fix to remove unused variable ar_pci in ath10k_pci_tx_pipe_cleanup > when building with W=1: > drivers/net/wireless/ath/ath10k/pci.c:1696:21: warning: variable > 'ar_pci' set but not used [-Wunused-but-set-variable] > > Signed-off-by: Chaehyun

Re: [V2] ath10k: fix memory leak on caldata on error exit path

Colin Ian King <colin.k...@canonical.com> wrote: > From: Colin Ian King <colin.k...@canonical.com> > > caldata is not being free'd on the error exit path, causing > a memory leak and data definitely should not be freed. Free > caldata instead of data. > >

Re: [PATCH] mwifiex: fix memory leak on regd when chan is zero

211_band band; > > chan = *buf++; > - if (!chan) > + if (!chan) { > + kfree(regd); > return NULL; > + } Bob sent a similar fix and he also did more: mwifiex: fix error handling in mwifiex_create_custom_regdomain https://patchwork.kernel.org/patch/9331337/ -- Kalle Valo

pull-request: wireless-drivers-next 2016-09-15

evice on module unload if still attached Julia Lawall (3): ath: constify local structures iwlegacy: constify local structures rtlwifi: rtl818x: constify local structures Kalle Valo (3): Merge tag 'iwlwifi-next-for-kalle-2016-08-30-2' of git://git.kernel.org/.../iwlwifi/iw

Re: [PATCH] mwifiex: fix null pointer deference when adapter is null

t; >drivers/net/wireless/marvell/mwifiex/main.c: In function > 'mwifiex_shutdown_sw': >>> drivers/net/wireless/marvell/mwifiex/main.c:1433:1: warning: label >>> 'exit_remove' defined but not used [-Wunused-label] > exit_remove: > ^~~ Looks like a valid warning to me, so please resend. -- Kalle Valo

Re: mwifiex: scan: Simplify code

Christophe Jaillet wrote: > This patch: >- improves code layout >- removes a useless memset(0) for some memory allocated with kzalloc >- removes a useless if. We know that 'if (chan_band_tlv)' will succeed > because it has been tested a few lines

Re: [PATCH] brcmfmac: fix memory leak in brcmf_fill_bss_param

ORKING DRIVERS)" in the CC list, I have to edit them away everytime I reply. Does anyone have any ideas why that's happening just to me? -- Kalle Valo

Re: brcmfmac: fix memory leak in brcmf_fill_bss_param

Rafał Miłecki wrote: > From: Rafał Miłecki > > This function is called from get_station callback which means that every > time user space was getting/dumping station(s) we were leaking 2 KiB. > > Signed-off-by: Rafał Miłecki > Fixes: 1f0dc59a6de ("brcmfmac:

Re: hostap: Delete an unnecessary jump label in prism2_ioctl_priv_hostapd()

gt; Reason: The benefit is not clear. > > How do you think about to reduce the source code a bit at these places? hostap is an obsolete driver, it's waste of time doing style fixes to it as nobody maintains it anymore. -- Kalle Valo

Re: brcmfmac: drop unused fields from struct brcmf_pub

Rafał Miłecki wrote: > From: Rafał Miłecki > > They seem to be there from the first day. We calculate these values but > never use them. > > Signed-off-by: Rafał Miłecki Patch applied to wireless-drivers-next.git, thanks. 2df86ad959c9 brcmfmac: drop unused

Re: hostap: Delete an unnecessary jump label in prism2_ioctl_priv_hostapd()

Joe Perches <j...@perches.com> writes: > On Mon, 2016-09-26 at 21:01 +0300, Kalle Valo wrote: >> hostap is an obsolete driver, it's waste of time doing style fixes to it >> as nobody maintains it anymore. > > Dunno know if Jouni is still maintaining this at all >

Re: [2/3] hostap: Delete an unnecessary jump label in prism2_ioctl_priv_hostapd()

SF Markus Elfring wrote: > From: Markus Elfring > Date: Sat, 20 Aug 2016 18:21:29 +0200 > > Remove a jump label which is unneeded in this function at the end. > > Signed-off-by: Markus Elfring 2

pull-request: wireless-drivers-next 2016-09-29

Malinen (1): MAINTAINERS: hostap: Mark the Host AP driver obsolete Kalle Valo (4): Merge tag 'iwlwifi-next-for-kalle-2016-09-15-2' of git://git.kernel.org/.../iwlwifi/iwlwifi-next Merge tag 'iwlwifi-next-for-kalle-2016-09-19-2' of git://git.kernel.org/.../iwlwifi/iwlwifi-next Merge ta

Re: pull-request: wireless-drivers-next 2016-09-29

Aaron Conole <acon...@redhat.com> writes: > David Miller <da...@davemloft.net> writes: > >> From: Kalle Valo <kv...@codeaurora.org> >> Date: Thu, 29 Sep 2016 19:57:28 +0300 >> > ... >>> Or actually I had one problem. While doing a test mer

Re: [v2] mwifiex: report wakeup for wowlan

Rajat Jain <raja...@google.com> writes: > Hello Kalie, > > On Mon, Oct 3, 2016 at 6:04 AM, Kalle Valo <kv...@codeaurora.org> wrote: >> Rajat Jain <raja...@google.com> wrote: >>> Enable notifying wakeup source to the PM core in case of >>> a wak

pull-request: wireless-drivers 2016-09-20

frames Beni Lev (1): iwlwifi: mvm: update TX queue before making a copy of the skb Kalle Valo (1): Merge tag 'iwlwifi-for-kalle-2016-09-15' of git://git.kernel.org/.../iwlwifi/iwlwifi-fixes drivers/net/wireless/intel

Re: [BUGFIX, 1/2] brcmfmac: Check rtnl_lock is locked when removing interface

mhira...@kernel.org wrote: > Check rtnl_lock is locked in brcmf_p2p_ifp_removed() by passing > rtnl_locked flag. Actually the caller brcmf_del_if() checks whether > the rtnl_lock is locked, but doesn't pass it to brcmf_p2p_ifp_removed(). > > Without this fix, wpa_supplicant goes softlockup with

Re: [PATCH] fix:gpio: mark symbols static where possible

io.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) The commit title should be: ath9k: mark ath_fill_led_pin() static Check the wiki how to create titles: https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#subject_name -- Kalle Valo

Re: [PATCH 4.9] brcmfmac: use correct skb freeing helper when deleting flowring

;> I'd like to get it for 4.9 however, as this fixes bug that could lead >> to WARNING on every add_key/del_key call. We was struggling with these >> WARNINGs for some time and this fixes one of two problems causing them. Ok, I'll queue this for 4.9. > Please mark it for stable as well. I can add that. Any ideas how old releases stable releases should this go to? -- Kalle Valo

Re: [1/3] ath10k: use devm_clk_get() instead of clk_get()

Masahiro Yamada wrote: > Use the managed variant of clk_get() to simplify the failure path > and the .remove callback. > > Signed-off-by: Masahiro Yamada 3 patches applied to ath-next branch of ath.git, thanks. 828662753d60 ath10k:

Re: ath10k: Spelling and miscellaneous neatening

Joe Perches wrote: > Correct some trivial comment typos. > Remove unnecessary parentheses in a long line. > Convert a return; before the end of a void function definition to just ; > > Signed-off-by: Joe Perches > Reviewed-by: Julian Calaby

Re: [PATCH 4.9] brcmfmac: use correct skb freeing helper when deleting flowring

nt idea but no luck: Signed-off-by: Rafa? Mi?ecki <ra...@milecki.pl> Acked-by: Arend van Spriel <ar...@broadcom.com> I'll add this to my patchwork wishlist though, I think it would be a really useful feature to have. (The question marks are because of my buggy copy paste, ignore those) -- Kalle Valo

Re: ath6kl: fix return value in ath6kl_wmi_set_pvb_cmd

Chaehyun Lim wrote: > When building with W=1, we got one warning as belows: > drivers/net/wireless/ath/ath6kl/wmi.c:3509:6: warning: variable ‘ret’ > set but not used [-Wunused-but-set-variable] > > At the end of ath6kl_wmi_set_pvb_cmd, it is returned by 0 regardless of >

Re: rtlwifi: Add switch variable to 'switch case not processed' messages

Joe Perches wrote: > Help along debugging by showing what switch/case variable is not > being processed in these messages. > > Signed-off-by: Joe Perches > Acked-by: Larry Finger Patch applied to wireless-drivers-next.git, thanks.

Re: brcmfmac: replace WARNING on timeout with a simple error message

Rafał Miłecki wrote: > From: Rafał Miłecki > > Even with timeout increased to 950 ms we get WARNINGs from time to time. > It mostly happens on A-MPDU stalls (e.g. when station goes out of > range). It may take up to 5-10 secods for the firmware to recover and > for that time it

Re: [V2, 4.9] brcmfmac: use correct skb freeing helper when deleting flowring

Rafał Miłecki wrote: > From: Rafał Miłecki > > Flowrings contain skbs waiting for transmission that were passed to us > by netif. It means we checked every one of them looking for 802.1x > Ethernet type. When deleting flowring we have to use freeing function > that will check

Re: [v2] mwifiex: report wakeup for wowlan

Rajat Jain wrote: > Enable notifying wakeup source to the PM core in case of > a wake on wireless LAN event. > > Signed-off-by: Wei-Ning Huang > Signed-off-by: Rajat Jain > Tested-by: Wei-Ning Huang >

Re: [1/3] hostap: Use memdup_user() rather than duplicating its implementation

SF Markus Elfring wrote: > From: Markus Elfring > Date: Sat, 20 Aug 2016 18:19:43 +0200 > > Reuse existing functionality from memdup_user() instead of keeping > duplicate source code. > > This issue was detected by using the

Re: [19/28] brcmfmac: avoid maybe-uninitialized warning in brcmf_cfg80211_start_ap

initialization for the newly introduced case in which > the variable should not really be used, in order to make the warning > go away. > > Fixes: b3589dfe0212 ("brcmfmac: ignore 11d configuration errors") > Cc: Hante Meuleman <hante.meule...@broadcom.com> >

pull-request: wireless-drivers-next 2016-10-30

Berg (1): iwlwifi: pcie: mark command queue lock with separate lockdep class Kalle Valo (1): Merge tag 'iwlwifi-for-kalle-2015-10-25' of git://git.kernel.org/.../iwlwifi/iwlwifi-fixes Luca Coelho (4): iwlwifi: mvm: use ssize_t for len in iwl_debugfs_mem_read() iwlwifi: mvm

Re: [v2] cw1200: Don't leak memory if krealloc failes

Johannes Thumshirn wrote: > The call to krealloc() in wsm_buf_reserve() directly assigns the newly > returned memory to buf->begin. This is all fine except when krealloc() > failes we loose the ability to free the old memory pointed to by > buf->begin. If we just create a

Re: [PATCH] wireless: fix bogus maybe-uninitialized warning

1->addr2, ETH_ALEN); /* SA */ > break; Ideally we prefer that drivers/net/wireless and net/wireless changes are split into different patches as they get applied to different trees. Johannes, is it ok if I take this change through my tree this time? -- Kalle Valo

Re: brcmfmac: proto: add callback for queuing TX data

Rafał Miłecki wrote: > From: Rafał Miłecki > > So far our core code was calling brcmf_fws_process_skb which wasn't > a proper thing to do. If case of devices using msgbuf protocol fwsignal > shouldn't be used. It was an unnecessary extra layer simply calling > a protocol

pull-request: wireless-drivers 2016-10-14

Hi Dave, first wireless-drivers pull request for 4.9 and this time we have unusually many fixes even before -rc1 is released. Most important here are the wlcore and rtlwifi commits which fix critical regressions, otherwise smaller impact fixes and one new sdio id for ath6kl. Please let me know

pull-request: wireless-drivers-next 2016-11-25

irn (1): cw1200: Don't leak memory if krealloc failes Kalle Valo (3): Merge tag 'iwlwifi-next-for-kalle-2016-10-25-2' of git://git.kernel.org/.../iwlwifi/iwlwifi-next Merge ath-next from git://git.kernel.org/.../kvalo/ath.git Merge ath-next from git://git.kernel.org/.../kv

Re: p54: memset(0) whole array

t; [-Wmemset-elt-size] > > Fix that by passing the correct size to memset. > > Signed-off-by: Jiri Slaby <jsl...@suse.cz> > Cc: Christian Lamparter <chunk...@googlemail.com> > Cc: Kalle Valo <kv...@codeaurora.org> > Cc: linux-wirel...@vger.kernel.org > Cc

Re: brcmfmac: print name of connect status event

Rafał Miłecki wrote: > From: Rafał Miłecki > > This simplifies debugging. Format %s (%u) comes from similar debugging > message in brcmf_fweh_event_worker. > > Signed-off-by: Rafał Miłecki Patch applied to wireless-drivers-next.git, thanks. e1c122d55f9e

Re: wireless: fix bogus maybe-uninitialized warning

Arnd Bergmann wrote: > The hostap_80211_rx() function is supposed to set up the mac addresses > for four possible cases, based on two bits of input data. For > some reason, gcc decides that it's possible that none of the these > four cases apply and the addresses remain

Re: [v2] cw1200: fix bogus maybe-uninitialized warning

Arnd Bergmann wrote: > On x86, the cw1200 driver produces a rather silly warning about the > possible use of the 'ret' variable without an initialization > presumably after being confused by the architecture specific definition > of WARN_ON: > >

Re: wlcore: Allow scans when in AP mode

Xander Huff wrote: > From: James Minor > > When in AP mode, scans can be done without changing firmware to > the multi-role firmware. Allow the interface to scan if forced > in the scan request. > > Signed-off-by: James Minor >

Re: [v3] mwifiex: report wakeup for wowlan

Rajat Jain wrote: > Register the WLAN device as a wakeup source since it can > wake the system via wake-on-wireless-lan. In an actual wowlan > event, notify the PM core that we are the current wakeup source. > This allows the PM core to update the wakeup attributes in /sys. >

Re: [v5,1/5] soc: qcom: smem_state: Fix include for ERR_PTR()

Bjorn Andersson wrote: > The correct include file for getting errno constants and ERR_PTR() is > linux/err.h, rather than linux/errno.h, so fix the include. > > Fixes: e8b123e60084 ("soc: qcom: smem_state: Add stubs for disabled > smem_state") > Acked-by: Andy Gross

Re: [4.9.0-rc5] AR9300 calibration problems with antenna selected

Krzysztof wrote: > Hi, > > I recently tried to select a single antenna on AR9300 and it works for > 30 seconds only. The subsequent calibration makes the RX signal level to > drop from the usual -30/-40 dBm to -70/-80 dBm, and the transmission > practically stops. > > With the attached patch it

Re: mwifiex: fix memory leak in mwifiex_save_hidden_ssid_channels()

Ricky Liang wrote: > kmemleak reports memory leak in mwifiex_save_hidden_ssid_channels(): > > unreferenced object 0xffc0a2914780 (size 192): > comm "ksdioirqd/mmc2", pid 2004, jiffies 4307182506 (age 820.684s) > hex dump (first 32 bytes): > 00 06 47 49 4e 2d 32

Re: ath9k_htc: fix minor mistakes in dev_err messages

Colin Ian King wrote: > From: Colin Ian King > > Add missing space in a dev_err message and join wrapped text so > it does not span multiple lines. Fix spelling mistake on "unknown". > > Signed-off-by: Colin Ian King

Re: [1/1] ath10k: use the right length of "background"

Nicolas Iooss wrote: > The word "background" contains 10 characters so the third argument of > strncmp() need to be 10 in order to match this prefix correctly. > > Signed-off-by: Nicolas Iooss > Fixes: 855aed1220d2 ("ath10k: add spectral

Re: pull-request: wireless-drivers-next 2016-10-30

David Miller <da...@davemloft.net> writes: > From: Kalle Valo <kv...@codeaurora.org> > Date: Sun, 30 Oct 2016 11:20:46 +0200 > >> few fixes for 4.9. I tagged this on the plane over a slow mosh >> connection while travelling to Plumbers so I might have done some

Re: [PATCH 19/28] brcmfmac: avoid maybe-uninitialized warning in brcmf_cfg80211_start_ap

initialization for the newly introduced case in which > the variable should not really be used, in order to make the warning > go away. > > Fixes: b3589dfe0212 ("brcmfmac: ignore 11d configuration errors") > Cc: Hante Meuleman <hante.meule...@broadcom.com> >

Re: [PATCH 19/28] brcmfmac: avoid maybe-uninitialized warning in brcmf_cfg80211_start_ap

Arnd Bergmann <a...@arndb.de> writes: > On Wednesday, October 26, 2016 9:49:58 AM CEST Kalle Valo wrote: >> Arnd Bergmann <a...@arndb.de> writes: >> >> > A bugfix added a sanity check around the assignment and use of the >> > 'is_11d' variable, w

Re: [PATCH 1/1] net: wireless: intersil: fix improper return value

t;orinoco:", more info: https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#subject_name -- Kalle Valo

Re: wl1251 & mac address & calibration data

from user space (if device tree is not available), I just don't know what that could be :) But if we would start to use request_firmware() for this at least there should be a wider concensus about that and it should be properly documented, just like the device tree bindings. -- Kalle Valo

Re: [3/5] ath10k: Remove unused wmi_p2p_noa_descriptor 'noa' in wmi-tlv

implement wmi-tlv backend") > Cc: Michal Kazior <michal.kaz...@tieto.com> > Cc: Kalle Valo <kv...@qca.qualcomm.com> > Signed-off-by: Kirtika Ruchandani <kirt...@chromium.org> No response to Michal's comment by the author Patch set to Changes Requested. -- ht

Re: [GIT] Networking

t was a critical fix. Sorry about that, I'll send a new pull request to Dave first thing tomorrow. It's too late now for me. -- Kalle Valo

Re: net: wireless: ath: wil6210: constify cfg80211_ops structures

Bhumika Goyal wrote: > cfg80211_ops structures are only passed as an argument to the function > wiphy_new. This argument is of type const, so cfg80211_ops strutures > having this property can be declared as const. > Done using Coccinelle > > @r1 disable optional_qualifier @ >

Re: [v5,1/5] soc: qcom: smem_state: Fix include for ERR_PTR()

Bjorn Andersson wrote: > The correct include file for getting errno constants and ERR_PTR() is > linux/err.h, rather than linux/errno.h, so fix the include. > > Fixes: e8b123e60084 ("soc: qcom: smem_state: Add stubs for disabled > smem_state") > Acked-by: Andy Gross

Re: [1/2] ath9k: ar9002_mac: kill off ACCESS_ONCE()

gt; > > virtual patch > > @ depends on patch @ > expression E1, E2; > @@ > > - ACCESS_ONCE(E1) = E2 > + WRITE_ONCE(E1, E2) > > @ depends on patch @ > expression E; > @@ > > - ACCESS_ONCE(E) > + READ_ONCE(E) > > > Signed-off-by: Mark Ru

Re: ath9k: fix spelling mistake: "meaurement" -> "measurement"

Colin Ian King wrote: > From: Colin Ian King > > Trivial fix to spelling mistake in ath_err message > > Signed-off-by: Colin Ian King Patch applied to ath-next branch of ath.git, thanks. 714ee339ff90 ath9k: fix

pull-request: wireless-drivers 2017-01-10

Hi Dave, here's the pull request with the important rtlwifi fix, more info in the tag below. During the long weekend we had here I finally updated Ubuntu on my workstation and git was updated along that. If you see anything funny or problems in my pull request due to the upgrade, please let me

pull-request: wireless-drivers-next 2016-12-01

rates from mac80211 rtl8xxxu: Pass tx_info to fill_txdesc in order to have access to retry count rtl8xxxu: Work around issue with 8192eu and 8723bu devices not reconnecting Jiri Slaby (1): bcma: add Dell Inspiron 3148 Kalle Valo (1): Merge ath-next from git://git.kernel.org/.

pull-request: wireless-drivers 2016-11-29

Hi Dave, if there's still time here's one more patch to 3.9. I think this is good to have in 3.9 as it fixes an issue where we were printing uninitialised memory in mwifiex. I had this in wireless-drivers already for some time as I was waiting for other fixes and nothing serious actually came up.

Re: adm80211: Removed unused 'io_addr' 'mem_addr' variables

Kirtika Ruchandani wrote: > Initial commit cc0b88cf5ecf ([PATCH] Add adm8211 802.11b wireless driver) > introduced variables mem_addr and io_addr in adm80211_probe() that are > set but not used. Compiling with W=1 gives the following warnings, > fix them. > >

Re: adm80211: add checks for dma mapping errors

Alexey Khoroshilov wrote: > The driver does not check if mapping dma memory succeed. > The patch adds the checks and failure handling. > > Found by Linux Driver Verification project (linuxtesting.org). > > Signed-off-by: Alexey Khoroshilov Patch

Re: pull-request: wireless-drivers 2016-11-29

David Miller <da...@davemloft.net> writes: > From: Kalle Valo <kv...@codeaurora.org> > Date: Tue, 29 Nov 2016 16:59:44 +0200 > >> if there's still time here's one more patch to 3.9. I think this is good >> to have in 3.9 as it fixes an issue where we were

Re: wireless: ath: ath9k: constify ath_bus_ops structure

Bhumika Goyal wrote: > Declare the structure ath_bus_ops as const as it is only passed as an > argument to the function ath9k_init_device. This argument is of type > const struct ath_bus_ops *, so ath_bus_ops structures with this property > can be declared as const. > Done

Re: ath5k: drop duplicate header vmalloc.h

Geliang Tang wrote: > Drop duplicate header vmalloc.h from ath5k/debug.c. > > Signed-off-by: Geliang Tang Patch applied to ath-next branch of ath.git, thanks. 384abd33d5d5 ath5k: drop duplicate header vmalloc.h --

Re: [PATCH 23/39] Annotate hardware config module parameters in drivers/net/wireless/

ivers/net/wireless/. > > Suggested-by: One Thousand Gnomes <gno...@lxorguk.ukuu.org.uk> > Signed-off-by: David Howells <dhowe...@redhat.com> > cc: Kalle Valo <kv...@codeaurora.org> > cc: linux-wirel...@vger.kernel.org > cc: netdev@vger.kernel.org > --- > > drivers/net/

Re: linux-next: manual merge of the wireless-drivers-next tree with the net-next tree

t; complex conflicts. The fix looks good, thanks. I sent a pull request to Dave yesteday which should fix this. -- Kalle Valo

Re: brcmfmac: fix spelling mistakes on "Ivalid"

Colin Ian King wrote: > From: Colin Ian King > > Trivial fixes to spelling mistake "Ivalid" to "Invalid" in > brcmf_err error messages. > > Signed-off-by: Colin Ian King > Acked-by: Arend van Spriel

Re: rtlwifi: fix spelling mistake: "contry" -> "country"

Colin Ian King wrote: > From: Colin Ian King > > trivial fix to spelling mistake in RT_TRACE message > > Signed-off-by: Colin Ian King > Acked-by: Larry Finger Patch applied to

Re: libertas: constify cfg80211_ops structures

Bhumika Goyal wrote: > cfg80211_ops structures are only passed as an argument to the function > wiphy_new. This argument is of type const, so cfg80211_ops strutures > having this property can be declared as const. > Done using Coccinelle > > @r1 disable optional_qualifier @ >

Re: net: wireless: marvell: libertas: constify cfg80211_ops structures

Bhumika Goyal wrote: > cfg80211_ops structures are only passed as an argument to the function > wiphy_new. This argument is of type const, so cfg80211_ops strutures > having this property can be declared as const. > Done using Coccinelle > > @r1 disable optional_qualifier @ >

Re: net: wireless: ath: wil6210: constify cfg80211_ops structures

Bhumika Goyal wrote: > cfg80211_ops structures are only passed as an argument to the function > wiphy_new. This argument is of type const, so cfg80211_ops strutures > having this property can be declared as const. > Done using Coccinelle > > @r1 disable optional_qualifier @ >

Re: [PATCH][V2] [media] gp8psk: fix spelling mistake: "firmare" -> "firmware"

ical.com> > --- > drivers/media/usb/dvb-usb/gp8psk.c | 2 +- > drivers/net/wireless/realtek/rtlwifi/core.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) Could you split the rtlwifi part to it's own patch? I can't apply patches touching media drivers. -- Kalle Valo

pull-request: wireless-drivers-next 2017-01-02

) fails Johannes Berg (1): iwlegacy: make il3945_mac_ops __ro_after_init Kalle Valo (1): Merge ath-next from git://git.kernel.org/.../kvalo/ath.git Larry Finger (14): rtlwifi: Replace local debug macro RT_ASSERT rtlwifi: Remove RT_TRACE messages that use DBG_EMERG

Re: wlcore: fix spelling mistake in wl1271_warning

Colin Ian King wrote: > From: Colin Ian King > > trivial fix to spelling mistake of function name in wl1271_warning, > should be dynamic_ps_timeout instead of dyanmic_ps_timeout. > > Signed-off-by: Colin Ian King

Re: [V3] rtlwifi: fix spelling mistake: "encrypiton" -> "encryption"

Colin Ian King wrote: > From: Colin Ian King > > trivial fix to spelling mistake in RT_TRACE message > > Signed-off-by: Colin Ian King Patch applied to wireless-drivers-next.git, thanks. e16e558e83ed rtlwifi: fix

Re: [GIT] Networking

er's private data 22b68b93ae25 rtlwifi: Fix kernel oops introduced with commit e49656147359 You should have 22b68b93ae25 in your tree, but not 60f59ce02785. The reason why you didn't get 60f59ce02785 in my pull request was that I committed it late: commit 60f59ce0278557f7896d5158ae6d12a4855a72cc A

Re: wl1251 & mac address & calibration data

Tony Lindgren <t...@atomide.com> writes: > * Kalle Valo <kv...@codeaurora.org> [161220 03:47]: >> Arend Van Spriel <arend.vanspr...@broadcom.com> writes: >> >> > On 18-12-2016 13:09, Pali Rohár wrote: >> > >> >> File wl

Re: wl1251 & mac address & calibration data

ta;h=97875bd79a579a0010da3f60324b6ec966fe9c6a;hb=HEAD > But yeah, the default one from linux-firmware should never have been > there in the first place. Agreed. -- Kalle Valo

pull-request: wireless-drivers 2016-12-22

Hi Dave, before the holidays a really small pull request for 4.10. I just want to have the regressions in rtlwifi and ath9k fixed quickly so I send this earlier than I normally would. Please let me know if there are any problems. Kalle The following changes since commit

pull-request: wireless-drivers 2017-03-21

Hi Dave, few smallish fixes for 4.11. Please let me know if there are any problems. Kalle The following changes since commit 22a0e18eac7a9e986fec76c60fa4a2926d1291e2: net: properly release sk_frag.page (2017-03-15 15:37:45 -0700) are available in the git repository at:

Re: ath10k: remove redundant error check

Colin Ian King wrote: > From: Colin Ian King > > The check on ret for an error is redundant because it is already been > checked for non-zero earlier on and ret is never non-zero at this point. > Fix this by removing the redundant check and

Re: ath10k: remove redundant check of len with buf_len

Colin Ian King wrote: > From: Colin Ian King > > The check of len > buf_len is redundant as len is initialized > to 0 and buf_len to 4096, so this comparison is always false. > Remove it. > > Signed-off-by: Colin Ian King

Re: [3/3] mwifiex: wake system up when receives a wake irq

Jeffy Chen wrote: > Currrently we are disabling this wake irq after receiving it. If this > happens before we finish suspend and the pm event check is disabled, > the system will continue suspending, and this irq would not work again. > > We may need to abort system

Re: atmel: remove time_t usage

Alexandre Belloni wrote: > last_qual never really holds a time. It only holds jiffies. Make it the > same type as jiffies. > > Signed-off-by: Alexandre Belloni Patch applied to wireless-drivers-next.git, thanks.

Re: ipw2200: remove redundant check of rc < 0

Colin Ian King wrote: > From: Colin Ian King > > The check for rc < 0 is always false so the check is redundant > and can be removed. > > Detected with CoverityScan, CID#101143 ("Logically dead code") > > Signed-off-by: Colin Ian King

Re: [2/2] zd1211rw: fix NULL-deref at probe

Johan Hovold wrote: > Make sure to check the number of endpoints to avoid dereferencing a > NULL-pointer or accessing memory beyond the endpoint array should a > malicious device lack the expected endpoints. > > Fixes: a1030e92c150 ("[PATCH] zd1211rw: Convert installer CDROM

Re: [PATCH 1/3] soc: qcom: smd: Transition client drivers from smd to rpmsg

| 11 --- >> net/qrtr/Kconfig | 2 +- >> net/qrtr/smd.c | 42 - >> 13 files changed, 108 insertions(+), 104 deletions(-) > > I think that it is best if Dave takes these directly then and I pu

Re: [2/2] zd1211rw: fix NULL-deref at probe

Johan Hovold <jo...@kernel.org> writes: > On Wed, Mar 22, 2017 at 09:04:15AM +0000, Kalle Valo wrote: >> Johan Hovold <jo...@kernel.org> wrote: >> > Make sure to check the number of endpoints to avoid dereferencing a >> > NULL-pointer or accessing

Re: [PATCH 15/16] drivers, net, intersil: convert hostap_cmd_queue.usecnt from atomic_t to refcount_t

ireless/intersil/hostap/hostap_hw.c | 12 ++-- > drivers/net/wireless/intersil/hostap/hostap_wlan.h | 3 ++- > 2 files changed, 8 insertions(+), 7 deletions(-) The prefix should be "hostap:", I'll fix that. -- Kalle Valo

pull-request: wireless-drivers-next 2017-04-03

bytes to debugfs causes a crash Kalle Valo (1): Merge tag 'iwlwifi-for-kalle-2017-03-29' of git://git.kernel.org/.../iwlwifi/iwlwifi-fixes Larry Finger (1): rtlwifi: Fix scheduling while atomic splat Liad Kaufman (1): iwlwifi: mvm: support ibss in dqa mode Sara Sharon (1

Re: [PATCH 16/16] drivers, net, intersil: convert request_context.refcount from atomic_t to refcount_t

less/intersil/orinoco/orinoco_usb.c | 15 --- > 1 file changed, 8 insertions(+), 7 deletions(-) The prefix should be "orinoco_usb:", I'll fix that. -- Kalle Valo

Re: [1/2] wireless: ath9k_htc: fix NULL-deref at probe

Johan Hovold wrote: > Make sure to check the number of endpoints to avoid dereferencing a > NULL-pointer or accessing memory beyond the endpoint array should a > malicious device lack the expected endpoints. > > Fixes: 36bcce430657 ("ath9k_htc: Handle storage devices") > Cc:

Re: pull-request: wireless-drivers-next 2017-04-03

David Miller <da...@davemloft.net> writes: > From: Kalle Valo <kv...@codeaurora.org> > Date: Mon, 03 Apr 2017 14:26:10 +0300 > >> here few really small fixes. I'm hoping this to be the last pull request >> for 4.11. >> >> Please let me if there ar

<    1   2   3   4   5   6   7   8   9   10   >