Re: [PATCH v2 1/2] sctp: rcu-ify addr_waitq

On Thu, Jun 04, 2015 at 10:27:10AM -0400, Neil Horman wrote: On Wed, Jun 03, 2015 at 01:54:01PM -0300, mleit...@redhat.com wrote: From: Marcelo Ricardo Leitner marcelo.leit...@gmail.com That's needed for the next patch, so we break the lock inversion between netns_sctp-addr_wq_lock

Re: [PATCH] sctp:Make the function sctp_assoc_lookup_laddr bool

On Thu, Jun 04, 2015 at 06:35:03AM -0400, Neil Horman wrote: On Wed, Jun 03, 2015 at 08:51:07AM -0400, Nicholas Krause wrote: This makes the function sctp_assoc_lookup_laddr bool due to this function only returning either one or zero as its return value. Signed-off-by: Nicholas Krause

Re: [PATCH v2 1/2] sctp: rcu-ify addr_waitq

On Wed, Jun 03, 2015 at 01:54:01PM -0300, mleit...@redhat.com wrote: From: Marcelo Ricardo Leitner marcelo.leit...@gmail.com That's needed for the next patch, so we break the lock inversion between netns_sctp-addr_wq_lock and socket lock on sctp_addr_wq_timeout_handler(). With this, we can

Re: [PATCH v3 1/2] sctp: rcu-ify addr_waitq

, Hannes Frederic Sowa wrote: Hi Marcelo, a few hints on rcuification, sorry I reviewed the code so late: On Fri, Jun 5, 2015, at 19:08, mleit...@redhat.com wrote: From: Marcelo Ricardo Leitner marcelo.leit...@gmail.com That's needed for the next patch, so we

Re: [PATCH v3 1/2] sctp: rcu-ify addr_waitq

On Tue, Jun 09, 2015 at 04:32:59PM -0300, Marcelo Ricardo Leitner wrote: On Tue, Jun 09, 2015 at 07:36:38AM -0400, Neil Horman wrote: On Mon, Jun 08, 2015 at 05:37:05PM +0200, Hannes Frederic Sowa wrote: On Mo, 2015-06-08 at 11:19 -0400, Neil Horman wrote: On Mon, Jun 08, 2015 at 04:59

[RFC PATCH 0/2] sctp: add new getsockopt option SCTP_SOCKOPT_PEELOFF_KERNEL

() prototype and its helpers just to avoid issues with static checkers. Kernel path not really tested yet.. mainly willing to know what do you think, is this feasible? getsockopt option only reachable by kernel itself? Couldn't find any other like this. Thanks, Marcelo Marcelo Ricardo Leitner (2

[RFC PATCH 1/2] sctp: add new getsockopt option SCTP_SOCKOPT_PEELOFF_KERNEL

applications, it's listed under uapi header. That's because hidding this wouldn't add any extra security and to keep the sockopt list in one place, so it's easy to check available numbers to use. Signed-off-by: Marcelo Ricardo Leitner marcelo.leit...@gmail.com --- include/uapi/linux/sctp.h | 12

[RFC PATCH 2/2] dlm: avoid using sctp_do_peeloff directly

then be left unloaded if dlm is not really using it. Note that this was preferred other than a module split as it once was split and was merged back in 2007 by commit 6ed7257b4670 ([DLM] Consolidate transport protocols) so that we don't revert it. Signed-off-by: Marcelo Ricardo Leitner marcelo.leit

Re: [RFC PATCH 0/2] sctp: add new getsockopt option SCTP_SOCKOPT_PEELOFF_KERNEL

On 17-06-2015 07:21, Neil Horman wrote: On Tue, Jun 16, 2015 at 07:42:31PM -0300, Marcelo Ricardo Leitner wrote: Hi, I'm trying to remove a direct dependency of dlm module on sctp one. Currently dlm code is calling sctp_do_peeloff() directly and only this call is causing the load of sctp

Re: [RFC PATCH 0/2] sctp: add new getsockopt option SCTP_SOCKOPT_PEELOFF_KERNEL

On 17-06-2015 09:20, Neil Horman wrote: On Wed, Jun 17, 2015 at 08:38:10AM -0300, Marcelo Ricardo Leitner wrote: On 17-06-2015 07:21, Neil Horman wrote: On Tue, Jun 16, 2015 at 07:42:31PM -0300, Marcelo Ricardo Leitner wrote: Hi, I'm trying to remove a direct dependency of dlm module on sctp

Re: [RFC PATCH 0/2] sctp: add new getsockopt option SCTP_SOCKOPT_PEELOFF_KERNEL

On 17-06-2015 10:16, Neil Horman wrote: On Wed, Jun 17, 2015 at 09:40:32AM -0300, Marcelo Ricardo Leitner wrote: On 17-06-2015 09:20, Neil Horman wrote: On Wed, Jun 17, 2015 at 08:38:10AM -0300, Marcelo Ricardo Leitner wrote: On 17-06-2015 07:21, Neil Horman wrote: On Tue, Jun 16, 2015 at 07

Re: [PATCH net-next 0/3] Socket destruction events via netlink sock_diag

/ipv4/tcp.c | 4 +- net/ipv4/tcp_diag.c| 6 ++- net/ipv4/udp_diag.c| 2 + 12 files changed, 209 insertions(+), 7 deletions(-) -- 2.2.0.rc0.207.ga3a616c Looks good to me, thanks Craig. Reviewed-by: Marcelo Ricardo Leitner mleit...@redhat.com

Re: [PATCH] sctp: fix ASCONF list handling

On Fri, May 29, 2015 at 09:17:26AM -0400, Neil Horman wrote: On Thu, May 28, 2015 at 11:46:29AM -0300, Marcelo Ricardo Leitner wrote: On Thu, May 28, 2015 at 10:27:32AM -0300, Marcelo Ricardo Leitner wrote: On Thu, May 28, 2015 at 08:17:27AM -0300, Marcelo Ricardo Leitner wrote: On Thu

Re: [PATCH] sctp: fix ASCONF list handling

On Mon, Jun 01, 2015 at 10:00:28AM -0400, Neil Horman wrote: On Fri, May 29, 2015 at 01:50:37PM -0300, Marcelo Ricardo Leitner wrote: On Fri, May 29, 2015 at 09:17:26AM -0400, Neil Horman wrote: On Thu, May 28, 2015 at 11:46:29AM -0300, Marcelo Ricardo Leitner wrote: On Thu, May 28, 2015

Re: [PATCH] sctp: fix ASCONF list handling

On Thu, May 28, 2015 at 06:15:11AM -0400, Neil Horman wrote: On Wed, May 27, 2015 at 09:52:17PM -0300, mleit...@redhat.com wrote: From: Marcelo Ricardo Leitner marcelo.leit...@gmail.com -auto_asconf_splist is per namespace and mangled by functions like sctp_setsockopt_auto_asconf() which

Re: [PATCH] sctp: fix ASCONF list handling

On Thu, May 28, 2015 at 08:17:27AM -0300, Marcelo Ricardo Leitner wrote: On Thu, May 28, 2015 at 06:15:11AM -0400, Neil Horman wrote: On Wed, May 27, 2015 at 09:52:17PM -0300, mleit...@redhat.com wrote: From: Marcelo Ricardo Leitner marcelo.leit...@gmail.com -auto_asconf_splist is per

Re: [PATCH] sctp: fix ASCONF list handling

On Thu, May 28, 2015 at 10:27:32AM -0300, Marcelo Ricardo Leitner wrote: On Thu, May 28, 2015 at 08:17:27AM -0300, Marcelo Ricardo Leitner wrote: On Thu, May 28, 2015 at 06:15:11AM -0400, Neil Horman wrote: On Wed, May 27, 2015 at 09:52:17PM -0300, mleit...@redhat.com wrote: From

Re: [PATCH net-next] tcp: add tcpi_segs_in and tcpi_segs_out to tcp_info

On Wed, May 20, 2015 at 05:52:34PM -0700, Eric Dumazet wrote: On Wed, 2015-05-20 at 17:48 -0700, Rick Jones wrote: On 05/20/2015 05:37 PM, Eric Dumazet wrote: Anyway, if we can send tcp data at 100Gbits on one flow, I guess we are doing a terrific job and do not need to tweak TCP stack

Re: [PATCH net-next] tcp: add tcpi_segs_in and tcpi_segs_out to tcp_info

On Thu, May 21, 2015 at 12:41:21PM -0700, Yuchung Cheng wrote: On Wed, May 20, 2015 at 4:35 PM, Eric Dumazet eric.duma...@gmail.com wrote: ... diff --git a/net/ipv6/tcp_ipv6.c b/net/ipv6/tcp_ipv6.c index b6575d6655681e8e84993a5db929c7309d47d4d3..beac6bf840b9a9d1e2f281d2b1c71b5a3414b824

Re: [PATCH iproute2] ss: add support for segs_in and segs_out

segs_out:414 segs_in:600 send 976.3Mbps lastsnd:23 lastrcv:23 lastack:22 pacing_rate 1952.7Mbps rcv_rtt:98 rcv_space:28960 Signed-off-by: Craig Gallek kr...@google.com Cool, thanks Craig. Reviewed-by: Marcelo Ricardo Leitner mleit...@redhat.com --- include/linux/tcp.h | 4 +++- misc

[RFC PATCH net-next] sctp: fix src address selection if using secondary addresses

use it. Signed-off-by: Marcelo Ricardo Leitner marcelo.leit...@gmail.com --- net/sctp/protocol.c | 55 +++-- 1 file changed, 41 insertions(+), 14 deletions(-) diff --git a/net/sctp/protocol.c b/net/sctp/protocol.c index

Re: [Cluster-devel] [PATCH 4/6] dlm: use sctp 1-to-1 API

Em 13-08-2015 06:37, Steven Whitehouse escreveu: Hi, On 12/08/15 17:42, Marcelo Ricardo Leitner wrote: Em 12-08-2015 12:33, David Laight escreveu: From: Marcelo Ricardo Leitner Sent: 12 August 2015 14:16 Em 12-08-2015 07:23, David Laight escreveu: From: Marcelo Ricardo Leitner Sent: 11

Re: [PATCH net] sctp: donot reset the overall_error_count in SHUTDOWN_RECEIVE state

On Wed, Aug 19, 2015 at 12:38:03PM +0800, Xin Long wrote: commit f8d960524 fix the 0 peer.rwnd issue in SHUTDOWN_PENING state through not reseting the overall_error_count when recevie a heartbeat, but the same issue also exists in SHUTDOWN_RECEIVE state. Please fix the typos on changelog,

Re: [PATCH net] sctp: start t5 timer only when peer.rwnd == 0 and in SHUTDOWN_PENDING

On Wed, Aug 19, 2015 at 12:39:06PM +0800, Xin Long wrote: when A send a data to B, A close() to be in SHUTDOWN_PENDING state, but B neither claim his rwnd is 0 nor SACK this data, then A keep retransmiting this data. it should send abord after Max.Retrans times, only when peer.rwnd == 0 and

Re: [PATCH net] sctp: partial chunk should be drop without sending abort packet

On Mon, Aug 24, 2015 at 06:08:30PM +0800, Xin Long wrote: as RFC 4960, 6.10 said, *if the receiver detects a partial chunk, it MUST drop the chunk*, we should not send the abort. but if we put this discard to inside state machine, it will send abort. so we just drop the partial chunk there,

Re: [PATCH net v2] sctp: start t5 timer only when peer.rwnd is 0 and local.state is SHUTDOWN_PENDING

: Enforce retransmission limit during shutdown) Signed-off-by: Xin Long lucien@gmail.com You still have typos on changelog, but at least not on keywords. Acked-by: Marcelo Ricardo Leitner marcelo.leit...@gmail.com --- net/sctp/sm_statefuns.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion

Re: [PATCH net v2] sctp: start t5 timer only when peer.rwnd is 0 and local.state is SHUTDOWN_PENDING

On Mon, Aug 24, 2015 at 02:13:38PM -0400, Vlad Yasevich wrote: On 08/23/2015 07:30 AM, Xin Long wrote: when A sends a data to B, then A close() and enter into SHUTDOWN_PENDING state, if B neither claim his rwnd is 0 nor send SACK for this data, A will keep retransmitting this data util

Re: [PATCH net v2] sctp: start t5 timer only when peer.rwnd is 0 and local.state is SHUTDOWN_PENDING

On Mon, Aug 24, 2015 at 02:36:59PM -0400, Vlad Yasevich wrote: On 08/24/2015 02:31 PM, Marcelo Ricardo Leitner wrote: On Mon, Aug 24, 2015 at 02:13:38PM -0400, Vlad Yasevich wrote: On 08/23/2015 07:30 AM, Xin Long wrote: when A sends a data to B, then A close() and enter

[PATCH net] sctp: fix sockopt size check

structures to match declarations in draft-16.) Signed-off-by: Marcelo Ricardo Leitner marcelo.leit...@gmail.com --- net/sctp/socket.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/sctp/socket.c b/net/sctp/socket.c index 1425ec2bbd5ae359a8e0408a89a6da6bb60bd87e

Re: [PATCH net] sctp: fix sockopt size check

On Wed, Jul 29, 2015 at 05:07:31PM -0700, David Miller wrote: From: Marcelo Ricardo Leitner marcelo.leit...@gmail.com Date: Tue, 28 Jul 2015 11:16:23 -0300 The problem is not on being bigger than what we want, but on being smaller, as it causes read of invalid memory. Note

Re: [RFC PATCH net] sctp: ASCONF-ACK with Unresolvable Address should be sent

Em 11-08-2015 01:34, lucien xin escreveu: On Mon, Jul 27, 2015 at 9:44 PM, Marcelo Ricardo Leitner marcelo.leit...@gmail.com wrote: On Sat, Jul 25, 2015 at 01:08:08PM +0800, Xin Long wrote: RFC 5061: This is an opaque integer assigned by the sender to identify each request parameter

[PATCH 0/6] use sctp 1-to-1 API

. Many thanks, Marcelo Ricardo Leitner (6): dlm: fix connection stealing if using SCTP dlm: fix race while closing connections dlm: fix not reconnecting on connecting error handling dlm: use sctp 1-to-1 API dlm: replace BUG_ON with a less severe handling dlm: fix reconnecting

[PATCH 2/6] dlm: fix race while closing connections

be able to re-connect as lowcomms_connect_sock() will check for it. Signed-off-by: Marcelo Ricardo Leitner marcelo.leit...@gmail.com --- fs/dlm/lowcomms.c | 29 +++-- 1 file changed, 15 insertions(+), 14 deletions(-) diff --git a/fs/dlm/lowcomms.c b/fs/dlm/lowcomms.c index

[PATCH 6/6] dlm: fix reconnecting but not sending data

to connect when it needs to transmit something, it makes sense to always mark this flag right after the connect. Signed-off-by: Marcelo Ricardo Leitner marcelo.leit...@gmail.com --- fs/dlm/lowcomms.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/fs/dlm/lowcomms.c b/fs/dlm

[PATCH 5/6] dlm: replace BUG_ON with a less severe handling

is still raising the new data event. Probably a bug to be fixed in SCTP. Reported-by: tan...@zte.com.cn Signed-off-by: Marcelo Ricardo Leitner marcelo.leit...@gmail.com --- fs/dlm/lowcomms.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/fs/dlm/lowcomms.c b/fs/dlm/lowcomms.c

[PATCH 4/6] dlm: use sctp 1-to-1 API

is possible, but it is intentionally left for a later commit. Note that for using nodes with this commit, you have to have at least the early fixes on this patchset otherwise it will trigger some issues on old nodes. Signed-off-by: Marcelo Ricardo Leitner marcelo.leit...@gmail.com --- fs/dlm/lowcomms.c

[PATCH 1/6] dlm: fix connection stealing if using SCTP

. Signed-off-by: Marcelo Ricardo Leitner marcelo.leit...@gmail.com --- fs/dlm/lowcomms.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/fs/dlm/lowcomms.c b/fs/dlm/lowcomms.c index 754fd6c0b7470bab272b071e6ca6e4969e4e4209..bc04f5e3af7ac5fe107a7a26555777364de8bc15

[PATCH 3/6] dlm: fix not reconnecting on connecting error handling

If we don't clear that bit, lowcomms_connect_sock() will not schedule another attempt, and no further attempt will be done. Signed-off-by: Marcelo Ricardo Leitner marcelo.leit...@gmail.com --- fs/dlm/lowcomms.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/dlm/lowcomms.c b/fs/dlm

Re: [PATCH] net: pktgen: don't abuse current-state in pktgen_thread_worker()

On Tue, Aug 04, 2015 at 06:33:34PM +0200, Oleg Nesterov wrote: Commit 1fbe4b46caca net: pktgen: kill the Wait for kthread_stop code in pktgen_thread_worker() removed (in particular) the final __set_current_state(TASK_RUNNING) and I didn't notice the previous

Re: [PATCH] net: pktgen: don't abuse current-state in pktgen_thread_worker()

On Tue, Aug 04, 2015 at 07:08:27PM +0200, Oleg Nesterov wrote: On 08/04, Marcelo Ricardo Leitner wrote: On Tue, Aug 04, 2015 at 06:33:34PM +0200, Oleg Nesterov wrote: Commit 1fbe4b46caca net: pktgen: kill the Wait for kthread_stop code in pktgen_thread_worker() removed (in particular

Re: [PATCH 4/6] dlm: use sctp 1-to-1 API

Em 12-08-2015 12:33, David Laight escreveu: From: Marcelo Ricardo Leitner Sent: 12 August 2015 14:16 Em 12-08-2015 07:23, David Laight escreveu: From: Marcelo Ricardo Leitner Sent: 11 August 2015 23:22 DLM is using 1-to-many API but in a 1-to-1 fashion. That is, it's not needed

Re: [PATCH 4/6] dlm: use sctp 1-to-1 API

Em 12-08-2015 07:23, David Laight escreveu: From: Marcelo Ricardo Leitner Sent: 11 August 2015 23:22 DLM is using 1-to-many API but in a 1-to-1 fashion. That is, it's not needed but this causes it to use sctp_do_peeloff() to mimic an kernel_accept() and this causes a symbol dependency on sctp

Re: [RFC PATCH net] sctp: ASCONF-ACK with Unresolvable Address should be sent

On Sat, Jul 25, 2015 at 01:08:08PM +0800, Xin Long wrote: RFC 5061: This is an opaque integer assigned by the sender to identify each request parameter. The receiver of the ASCONF Chunk will copy this 32-bit value into the ASCONF Response Correlation ID field of the

Re: [RFC PATCH net] sctp: ASCONF-ACK with Unresolvable Address should be sent

On Fri, Jul 24, 2015 at 02:56:29PM +0800, Xin Long wrote: RFC 5061: This is an opaque integer assigned by the sender to identify each request parameter. The receiver of the ASCONF Chunk will copy this 32-bit value into the ASCONF Response Correlation ID field of the

Re: [PATCH 1/2] sctp: SCTP_SOCKOPT_PEELOFF return socket pointer for kernel users

On 13-07-2015 07:39, Neil Horman wrote: On Fri, Jul 10, 2015 at 06:21:14PM -0700, David Miller wrote: From: Marcelo Ricardo Leitner marcelo.leit...@gmail.com Date: Thu, 9 Jul 2015 11:15:19 -0300 SCTP has this operation to peel off associations from a given socket and create a new socket

[PATCH v2 1/2] sctp: add new getsockopt option SCTP_SOCKOPT_PEELOFF_KERNEL

numbers to use. Signed-off-by: Marcelo Ricardo Leitner marcelo.leit...@gmail.com --- include/uapi/linux/sctp.h | 12 net/sctp/socket.c | 37 + 2 files changed, 49 insertions(+) diff --git a/include/uapi/linux/sctp.h b/include/uapi/linux/sctp.h

[PATCH v2 2/2] dlm: avoid using sctp_do_peeloff directly

then be left unloaded if dlm is not really using it. Note that this was preferred other than a module split as it once was split and was merged back in 2007 by commit 6ed7257b4670 ([DLM] Consolidate transport protocols) so that we don't revert it. Signed-off-by: Marcelo Ricardo Leitner marcelo.leit

[PATCH v2 0/2] Avoid link dependency of dlm on sctp module

: - For identifying kernel users, switched from segment_eq() to fd check - Reused original option to avoid code duplication v1-v2, from David: - Back to new sockopt implementation, to avoid changing sockopt arg format. Marcelo Ricardo Leitner (2): sctp: add new getsockopt option

Re: [PATCH nf-next] netfilter: nf_ct_sctp: minimal multihoming support

On Tue, Jul 14, 2015 at 02:23:11PM +0200, Michal Kubecek wrote: Currently nf_conntrack_proto_sctp module handles only packets between primary addresses used to establish the connection. Any packets between secondary addresses are classified as invalid so that usual firewall configurations drop

Re: [PATCH nf-next] netfilter: nf_ct_sctp: minimal multihoming support

On Thu, Jul 16, 2015 at 02:05:12PM +0200, Michal Kubecek wrote: On Wed, Jul 15, 2015 at 05:35:08PM -0300, Marcelo Ricardo Leitner wrote: Hi, On Tue, Jul 14, 2015 at 06:42:25PM +0200, Michal Kubecek wrote: On Tue, Jul 14, 2015 at 03:42:03PM +0200, Florian Westphal wrote: Michal

Re: [PATCH v2 1/2] sctp: add new getsockopt option SCTP_SOCKOPT_PEELOFF_KERNEL

On Thu, Jul 16, 2015 at 09:50:16AM -0400, Vlad Yasevich wrote: On 07/14/2015 01:13 PM, Marcelo Ricardo Leitner wrote: SCTP has this operation to peel off associations from a given socket and create a new socket using this association. We currently have two ways to use this operation

Re: [RFC PATCH net-next] sctp: fix src address selection if using secondary addresses

On Thu, Jul 16, 2015 at 09:09:57AM -0400, Vlad Yasevich wrote: On 07/15/2015 03:03 PM, Marcelo Ricardo Leitner wrote: On Fri, Jul 10, 2015 at 03:27:02PM -0300, Marcelo Ricardo Leitner wrote: On Fri, Jul 10, 2015 at 01:14:21PM -0400, Vlad Yasevich wrote: On 07/10/2015 12:17 PM, Marcelo

Re: [RFC PATCH net-next] sctp: fix src address selection if using secondary addresses

On Fri, Jul 10, 2015 at 03:27:02PM -0300, Marcelo Ricardo Leitner wrote: On Fri, Jul 10, 2015 at 01:14:21PM -0400, Vlad Yasevich wrote: On 07/10/2015 12:17 PM, Marcelo Ricardo Leitner wrote: On Fri, Jul 10, 2015 at 11:35:28AM -0400, Vlad Yasevich wrote: ... have been numerous times where

Re: [PATCH nf-next] netfilter: nf_ct_sctp: minimal multihoming support

Hi, On Tue, Jul 14, 2015 at 06:42:25PM +0200, Michal Kubecek wrote: On Tue, Jul 14, 2015 at 03:42:03PM +0200, Florian Westphal wrote: Michal Kubecek mkube...@suse.cz wrote: + case SCTP_CID_HEARTBEAT: + pr_debug(SCTP_CID_HEARTBEAT); + i = 9; + break; +

[PATCH v2 0/2] sctp: fix src address selection if using secondary address

that has the address and comparing its number is enough. Marcelo Ricardo Leitner (2): sctp: reduce indent level on sctp_v4_get_dst sctp: fix src address selection if using secondary addresses net/sctp/protocol.c | 42 +++--- 1 file changed, 27 insertions(+), 15

[PATCH v2 1/2] sctp: reduce indent level on sctp_v4_get_dst

Paves the day for the next patch. Functionality stays untouched. Signed-off-by: Marcelo Ricardo Leitner marcelo.leit...@gmail.com --- net/sctp/protocol.c | 32 +--- 1 file changed, 17 insertions(+), 15 deletions(-) diff --git a/net/sctp/protocol.c b/net/sctp

[PATCH v2 2/2] sctp: fix src address selection if using secondary addresses

such packets as their src doesn't match the routes for that interface. Signed-off-by: Marcelo Ricardo Leitner marcelo.leit...@gmail.com --- net/sctp/protocol.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/net/sctp/protocol.c b/net/sctp/protocol.c index

[PATCH] sctp: fix cut and paste issue in comment

Cookie ACK is always received by the association initiator, so fix the comment to avoid confusion. Signed-off-by: Marcelo Ricardo Leitner marcelo.leit...@gmail.com --- net/sctp/sm_statefuns.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/sctp/sm_statefuns.c b/net/sctp

Re: [PATCH v2 net-next] net/vxlan: Fix kernel unaligned access in __vxlan_find_mac

...@oracle.com Reviewed-by: Marcelo Ricardo Leitner marcelo.leit...@gmail.com -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/2] sctp: SCTP_SOCKOPT_PEELOFF return socket pointer for kernel users

On 13-07-2015 15:59, David Miller wrote: From: Neil Horman nhor...@tuxdriver.com Date: Mon, 13 Jul 2015 06:39:11 -0400 Initially Marcelo had created duplicate code paths, one to return an fd, one to return a file struct. If you would rather go in that direction, I'm sure he can propose it

Re: [PATCH 1/2] sctp: SCTP_SOCKOPT_PEELOFF return socket pointer for kernel users

On 13-07-2015 16:58, David Miller wrote: From: Marcelo Ricardo Leitner marcelo.leit...@gmail.com Date: Mon, 13 Jul 2015 16:05:27 -0300 On 13-07-2015 15:59, David Miller wrote: From: Neil Horman nhor...@tuxdriver.com Date: Mon, 13 Jul 2015 06:39:11 -0400 Initially Marcelo had created

Re: [PATCH net-next 14/22] vxlan: Flow based tunneling

On Mon, Jul 20, 2015 at 02:15:22PM -0300, Marcelo Ricardo Leitner wrote: On Fri, Jul 17, 2015 at 02:55:33PM +0200, Thomas Graf wrote: [ snip ] @@ -2373,6 +2470,12 @@ static void vxlan_setup(struct net_device *dev) netif_keep_dst(dev); --- (a) dev-priv_flags

Re: [PATCH v2 1/2] sctp: add new getsockopt option SCTP_SOCKOPT_PEELOFF_KERNEL

On Thu, Jul 16, 2015 at 11:03:14AM -0300, Marcelo Ricardo Leitner wrote: On Thu, Jul 16, 2015 at 09:50:16AM -0400, Vlad Yasevich wrote: ... I am not familiar enough with DLM and its history, but my question is this: If dlm always peels off a socket for a new associations, why is it using 1

Re: [PATCH net-next 14/22] vxlan: Flow based tunneling

On Fri, Jul 17, 2015 at 02:55:33PM +0200, Thomas Graf wrote: [ snip ] @@ -2373,6 +2470,12 @@ static void vxlan_setup(struct net_device *dev) netif_keep_dst(dev); --- (a) dev-priv_flags |= IFF_LIVE_ADDR_CHANGE; + /* If in flow based mode, keep the dst

Re: [PATCH v2 1/2] sctp: add new getsockopt option SCTP_SOCKOPT_PEELOFF_KERNEL

On 15-07-2015 10:18, Neil Horman wrote: On Tue, Jul 14, 2015 at 02:13:24PM -0300, Marcelo Ricardo Leitner wrote: SCTP has this operation to peel off associations from a given socket and create a new socket using this association. We currently have two ways to use this operation: - via

Re: [PATCH net v2] sctp: asconf's process should verify address parameter is in the beginning

On Tue, Aug 25, 2015 at 08:29:24PM +0800, Xin Long wrote: in sctp_process_asconf(), we get address parameter from the beginning of the addip params. but we never check if it's really there. if the addr param is not there, it still can pass sctp_verify_asconf(), then to be handled by

Re: [PATCH net] sctp: asconf process should treat multiple address parameter as unrecognized parameter

On Tue, Aug 25, 2015 at 08:43:10PM +0800, lucien xin wrote: On Tue, Aug 25, 2015 at 8:39 PM, lucien xin lucien@gmail.com wrote: I think it would be much better to catch this in the validation stage. If an implementation inserts multiple address parameters, we don't really know

Re: net: lockdep warning in ip_mc_msfget (net/ipv4/igmp.c:2400)

Em 02-11-2015 22:38, Cong Wang escreveu: On Mon, Nov 2, 2015 at 1:31 PM, Cong Wang <cw...@twopensource.com> wrote: Good catch! This is probably introduced by: commit baf606d9c9b12517e47e0d1370e8aa9f7323f210 Author: Marcelo Ricardo Leitner <marcelo.leit...@gmail.com> Date: Wed

Re: [Patch net v2] ipv4: fix a potential deadlock in mcast getsockopt() path

) Reported-by: Sasha Levin <sasha.le...@oracle.com> Cc: Marcelo Ricardo Leitner <marcelo.leit...@gmail.com> Signed-off-by: Cong Wang <xiyou.wangc...@gmail.com> Reviewed-by: Marcelo Ricardo Leitner <marcelo.leit...@gmail.com> Thanks --- net/ipv4/igmp.c| 12

Re: HW communication debugging interface - ideas?

On Wed, Sep 30, 2015 at 03:51:41PM +0200, Jiri Pirko wrote: > Hi Dave/all. > > There is quite common for drivers to speak with HW using "packet-like" > messages. In our case, we put message into skb and push that out as > an ordinary packet. HW then sends us reply in a packet, similar to other >

[PATCH 2/2] dlm: avoid using sctp_do_peeloff directly

unloaded if dlm is not really using it. Note that this was preferred other than a module split as it once was split and was merged back in 2007 by commit 6ed7257b4670 ([DLM] Consolidate transport protocols) so that we don't revert it. Signed-off-by: Marcelo Ricardo Leitner marcelo.leit...@gmail.com

[PATCH 1/2] sctp: SCTP_SOCKOPT_PEELOFF return socket pointer for kernel users

then updates SCTP_SOCKOPT_PEELOFF so that for kernel users of this protocol it will not allocate a file descriptor but instead just return the socket pointer directly. If called by an user application it will work as before. Signed-off-by: Marcelo Ricardo Leitner marcelo.leit...@gmail.com

Re: [RFC PATCH net-next] sctp: fix src address selection if using secondary addresses

Cc'ing Michael too. On Tue, Jul 07, 2015 at 02:42:25PM -0300, Marcelo Ricardo Leitner wrote: Hi folks, This is an attempt to better choose a src address for sctp packets as peers with rp_filter could be dropping our packets in some situations. With this patch, we try to respect and use

Re: [RFC PATCH net-next] sctp: fix src address selection if using secondary addresses

On Thu, Jul 09, 2015 at 09:55:19PM +0200, Michael Tuexen wrote: On 09 Jul 2015, at 18:54, Marcelo Ricardo Leitner mleit...@redhat.com wrote: Cc'ing Michael too. I'm not familiar with the Linux kernel code, so I can't comment on it. But making sure to use a source address belonging

Re: [PATCH 0/2] net: pktgen: fix race between pktgen_thread_worker() and kthread_stop()

On Wed, Jul 08, 2015 at 09:41:54PM +0200, Oleg Nesterov wrote: Hello, I am not familiar with this code and I have no idea how to test these changes, so 2/2 comes as a separate change. 1/2 looks like the obvious bugfix, and probably candidate for -stable. Oleg. net/core/pktgen.c |9

Re: [RFC net-next 1/1] : sctp: denoise deprecation log on SCTP_EVENTS

On Thu, Jul 09, 2015 at 01:54:37PM +0200, Daniel Borkmann wrote: On 07/09/2015 12:38 PM, Jamal Hadi Salim wrote: ... In the newer kernels this message is extremely noisy. After a quick discussion with Daniel it seems to me it will be very hard to get existing apps that nobody is going to

Re: [RFC PATCH net-next] sctp: fix src address selection if using secondary addresses

On Fri, Jul 10, 2015 at 01:14:21PM -0400, Vlad Yasevich wrote: On 07/10/2015 12:17 PM, Marcelo Ricardo Leitner wrote: On Fri, Jul 10, 2015 at 11:35:28AM -0400, Vlad Yasevich wrote: On 07/10/2015 07:53 AM, Marcelo Ricardo Leitner wrote: On Thu, Jul 09, 2015 at 09:55:19PM +0200, Michael

Re: [RFC PATCH net-next] sctp: fix src address selection if using secondary addresses

On Fri, Jul 10, 2015 at 11:35:28AM -0400, Vlad Yasevich wrote: On 07/10/2015 07:53 AM, Marcelo Ricardo Leitner wrote: On Thu, Jul 09, 2015 at 09:55:19PM +0200, Michael Tuexen wrote: On 09 Jul 2015, at 18:54, Marcelo Ricardo Leitner mleit...@redhat.com wrote: Cc'ing Michael too. I'm

Re: [PATCH net v3] sctp: asconf's process should verify address parameter is in the beginning

On Wed, Aug 26, 2015 at 04:42:21PM -0400, Vlad Yasevich wrote: On 08/26/2015 04:35 PM, Xin Long wrote: in sctp_process_asconf(), we get address parameter from the beginning of the addip params. but we never check if it's really there. if the addr param is not there, it still can pass

Re: [PATCH net v3] sctp: donot reset the overall_error_count in SHUTDOWN_RECEIVE state

in those states. Fixes: Commit f8d960524328 (sctp: Enforce retransmission limit during shutdown) Signed-off-by: Xin Long lucien@gmail.com Acked-by: Marcelo Ricardo Leitner marcelo.leit...@gmail.com thx --- net/sctp/sm_sideeffect.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion

Re: [PATCH net v2] sctp: ASCONF-ACK with Unresolvable Address should be sent

) ASCONF- (Delete IP Address) - ASCONF-ACK (Unresolvable Address) Signed-off-by: Xin Long lucien@gmail.com Acked-by: Marcelo Ricardo Leitner marcelo.leit...@gmail.com --- net

Re: vxlan regression: multiple VXLANs on a single multicast group broken in kernel 4.1

Em 25-08-2015 14:35, John Nielsen escreveu: After updating the kernel on a KVM host, I discovered yesterday that I can no longer use more than one vxlan interface on a single multicast group/address. The interfaces can be created but only the first one may be brought up: # ip link add vx100

[PATCH net 2/2] sctp: add routing output fallback

restores the original behavior if no better interface could be found. Fixes: 0ca50d12fe46 ("sctp: fix src address selection if using secondary addresses") Signed-off-by: Marcelo Ricardo Leitner <marcelo.leit...@gmail.com> --- net/sctp/protocol.c | 8 +++- 1 file changed, 7

[PATCH net 1/2] sctp: fix dst leak

Commit 0ca50d12fe46 failed to release the reference to dst entries that it decided to skip. Fixes: 0ca50d12fe46 ("sctp: fix src address selection if using secondary addresses") Signed-off-by: Marcelo Ricardo Leitner <marcelo.leit...@gmail.com> --- net/sctp/protocol.c | 4 +++- 1

[PATCH net 0/2] couple of sctp fixes for 0ca50d12fe46

ups relies on the old behavior and I don't see a better fix for it. Please consider both to -stable tree. Thanks! Marcelo Ricardo Leitner (2): sctp: fix dst leak sctp: add routing output fallback net/sctp/protocol.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-)

[PATCH net] vxlan: re-ignore EADDRINUSE from igmp_join

Ricardo Leitner marcelo.leit...@gmail.com --- John, please see how this goes for you. It worked in here. Dave, please consider this for stable trees. At least 4.1 is affected. Thanks. drivers/net/vxlan.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/vxlan.c b/drivers/net

Re: [PATCH net] sctp: fix race on protocol/netns initialization

Em 09-09-2015 21:16, David Miller escreveu: From: Marcelo Ricardo Leitner <marcelo.leit...@gmail.com> Date: Wed, 9 Sep 2015 17:03:01 -0300 So the fix then is to invert the initialization order inside register_pernet_subsys() so that the control socket is created by last and also block

Re: [PATCH net] sctp: fix race on protocol/netns initialization

Em 10-09-2015 10:24, Vlad Yasevich escreveu: On 09/09/2015 05:06 PM, Marcelo Ricardo Leitner wrote: Em 09-09-2015 17:30, Vlad Yasevich escreveu: On 09/09/2015 04:03 PM, Marcelo Ricardo Leitner wrote: Consider sctp module is unloaded and is being requested because an user is creating a sctp

Re: [PATCH net] sctp: fix race on protocol/netns initialization

Em 10-09-2015 10:02, David Laight escreveu: From: Marcelo Ricardo Leitner Sent: 10 September 2015 13:54 Em 09-09-2015 21:16, David Miller escreveu: From: Marcelo Ricardo Leitner <marcelo.leit...@gmail.com> Date: Wed, 9 Sep 2015 17:03:01 -0300 So the fix then is to invert the initiali

Re: [PATCH net] sctp: fix race on protocol/netns initialization

On Thu, Sep 10, 2015 at 11:50:06AM -0400, Vlad Yasevich wrote: > On 09/10/2015 10:22 AM, Marcelo Ricardo Leitner wrote: > > Em 10-09-2015 10:24, Vlad Yasevich escreveu: ... > >> Then you can order sctp_net_init() such that it happens first, then > >> protos

Re: [PATCH net] sctp: fix race on protocol/netns initialization

On Thu, Sep 10, 2015 at 01:24:54PM -0300, Marcelo Ricardo Leitner wrote: > On Thu, Sep 10, 2015 at 11:50:06AM -0400, Vlad Yasevich wrote: > > On 09/10/2015 10:22 AM, Marcelo Ricardo Leitner wrote: > > > Em 10-09-2015 10:24, Vlad Yasevich escreveu: > ... > > >>

Re: [PATCH net] sctp: fix race on protocol/netns initialization

On Thu, Sep 10, 2015 at 03:35:20PM -0300, Marcelo Ricardo Leitner wrote: > On Thu, Sep 10, 2015 at 01:24:54PM -0300, Marcelo Ricardo Leitner wrote: > > On Thu, Sep 10, 2015 at 11:50:06AM -0400, Vlad Yasevich wrote: > > > On 09/10/2015 10:22 AM, Marcelo Ricardo Leitner wrote: >

Re: [patch net-next 2/3] mlxsw: expose EMAD transactions statistics via debugfs

On Thu, Aug 27, 2015 at 08:40:29AM +0200, Jiri Pirko wrote: > Thu, Aug 27, 2015 at 08:36:03AM CEST, da...@davemloft.net wrote: > >From: Jiri Pirko > >Date: Thu, 27 Aug 2015 08:27:04 +0200 > > > >> I'm not saying it is not possible, it certainly is. But I think that > >> for

Re: [PATCH net] sctp: fix race on protocol/netns initialization

Em 10-09-2015 16:14, Vlad Yasevich escreveu: On 09/10/2015 02:35 PM, Marcelo Ricardo Leitner wrote: On Thu, Sep 10, 2015 at 01:24:54PM -0300, Marcelo Ricardo Leitner wrote: On Thu, Sep 10, 2015 at 11:50:06AM -0400, Vlad Yasevich wrote: On 09/10/2015 10:22 AM, Marcelo Ricardo Leitner wrote

[PATCH net v2] sctp: fix race on protocol/netns initialization

s today. Fixes: 4db67e808640 ("sctp: Make the address lists per network namespace") Signed-off-by: Vlad Yasevich <vyasev...@gmail.com> Signed-off-by: Marcelo Ricardo Leitner <marcelo.leit...@gmail.com> --- Notes: As discussed, a supplementary fix for this one for serializi

Re: [PATCH RFC 3/7] netfilter: add NF_INET_LOCAL_SOCKET_IN chain type

On Wed, Sep 30, 2015 at 09:24:21AM +0200, Daniel Mack wrote: > On 09/29/2015 11:19 PM, Florian Westphal wrote: > > Daniel Mack wrote: > >> Add a new chain type NF_INET_LOCAL_SOCKET_IN which is ran after the > >> input demux is complete and the final destination socket (if any)

Re: [PATCH RFC 3/7] netfilter: add NF_INET_LOCAL_SOCKET_IN chain type

On Thu, Oct 01, 2015 at 11:07:30PM +0200, Daniel Mack wrote: > On 10/01/2015 07:13 PM, Marcelo Ricardo Leitner wrote: > > On Wed, Sep 30, 2015 at 09:24:21AM +0200, Daniel Mack wrote: > >> On 09/29/2015 11:19 PM, Florian Westphal wrote: > >>> Daniel Mack <dan...@zo

Re: [PATCH v2] net: sctp: Don't use 64 kilobyte lookup table for four elements

tatement. > > Signed-off-by: Denys Vlasenko <dvlas...@redhat.com> > CC: Vlad Yasevich <vyasev...@gmail.com> > CC: Neil Horman <nhor...@tuxdriver.com> > CC: Marcelo Ricardo Leitner <marcelo.leit...@gmail.com> > CC: linux-s...@vger.kernel.org > CC: netdev@vger.

Re: [PATCH] net: sctp: Don't use 64 kilobyte lookup table for four elements

On Sat, Sep 26, 2015 at 08:53:14PM +0200, Denys Vlasenko wrote: > Seemingly innocuous sctp_trans_state_to_prio_map[] array > is way bigger than it looks, since > "[SCTP_UNKNOWN] = 2" expands into "[0x] = 2" ! > > This patch replaces it with switch() statement. > > Signed-off-by: Denys

Re: [PATCH 10/12] net: sctp: avoid incorrect time_t use

On Wed, Sep 30, 2015 at 09:57:31AM -0400, Neil Horman wrote: > On Wed, Sep 30, 2015 at 01:26:40PM +0200, Arnd Bergmann wrote: > > We want to avoid using time_t in the kernel because of the y2038 > > overflow problem. The use in sctp is not for storing seconds at > > all, but instead uses

  1   2   3   4   5   6   7   8   9   10   >