[PATCH] net: bgmac: Fix errant feature flag check

During the conversion to the feature flags, a check against ci->id != BCMA_CHIP_ID_BCM47162 became bgmac->feature_flags & BGMAC_FEAT_CLKCTLS instead of !(bgmac->feature_flags & BGMAC_FEAT_CLKCTLS) Reported-by: Rafał Miłecki <zaj...@gmail.com> Signed-off-by: Jon Mason

Re: [PATCH v2 4/6] net: ethernet: bgmac: convert to feature flags

On Tue, Sep 20, 2016 at 1:19 AM, Rafał Miłecki <zaj...@gmail.com> wrote: > On 17 August 2016 at 13:34, Rafał Miłecki <zaj...@gmail.com> wrote: >> On 8 July 2016 at 01:08, Jon Mason <jon.ma...@broadcom.com> wrote: >>> mode = (bgmac_read(bgmac,

Re: [PATCH RFC 4/4] xfs: Transmit flow steering

On 08/30/2016 08:00 PM, Tom Herbert wrote: XFS maintains a per device flow table that is indexed by the skbuff hash. The XFS table is only consulted when there is no queue saved in a transmit socket for an skbuff. Each entry in the flow table contains a queue index and a queue pointer. The

Re: [PATCH 1/1] net: s2io: simplify logical constraint

On Sun, Jul 31, 2016 at 5:53 AM, Heinrich Schuchardt <xypron.g...@gmx.de> wrote: > (!A || (A && B)) is equivalent to (!A || B) Seems logical to me. Acked-by: Jon Mason <jdma...@kudzu.us> > Signed-off-by: Heinrich Schuchardt <xypron.g...@gmx.de> > --- > dr

Re: WARNING: CPU: 0 PID: 0 at net/ipv4/af_inet.c:155 inet_sock_destruct+0x1c4/0x1dc

On 12/07/2016 16:38, Mason wrote: > With Eric's patch applied, I get this warning at boot: > > [4.668309] nb8800 26000.ethernet eth0: Link is Up - 1Gbps/Full - flow > control rx/tx > [4.688609] Sending DHCP requests ., OK > [4.711935] IP-Config: Got DHCP answer fro

Re: WARNING: CPU: 0 PID: 0 at net/ipv4/af_inet.c:155 inet_sock_destruct+0x1c4/0x1dc

On 12/07/2016 16:25, Eric Dumazet wrote: > Could you try this debug patch ? Note: I've been unable to trigger the warning again. Dunno what has changed... With your patch applied, I get a warning at boot: [4.668309] nb8800 26000.ethernet eth0: Link is Up - 1Gbps/Full - flow control rx/tx

Re: WARNING: CPU: 0 PID: 0 at net/ipv4/af_inet.c:155 inet_sock_destruct+0x1c4/0x1dc

On 12/07/2016 11:53, Mason wrote: > However, the 310 seconds time span still seems to be relevant. > > Steps to reproduce: I booted the system, logged in as root, > mounted an NFS file system, then left the system idling at > the prompt. > > (I don't remember seeing

Re: WARNING: CPU: 0 PID: 0 at net/ipv4/af_inet.c:155 inet_sock_destruct+0x1c4/0x1dc

On 05/07/2016 17:28, Florian Fainelli wrote: > Le 05/07/2016 07:50, Mason wrote: > >> On 05/07/2016 15:33, Mason wrote: >> >>> I was testing suspend/resume sequences where the suspend operation >>> fails and returns without having suspended the platform. Pl

Re: [PATCH v2 0/6] net: ethernet: bgmac: Add platform device support

On Thu, Jul 7, 2016 at 7:08 PM, Jon Mason <jon.ma...@broadcom.com> wrote: > David Miller, Please consider including patches 1-5 in net-next > > Florian Fainelli, Please consider including patches 6 & 7 in > devicetree/next Oops. I didn't send out the 7th patch in thi

[PATCH 7/7] ARM: dts: NSP: Add bgmac entries

Add device tree entries for the ethernet devices present on the Broadcom Northstar Plus SoCs Signed-off-by: Jon Mason <jon.ma...@broadcom.com> --- arch/arm/boot/dts/bcm-nsp.dtsi | 18 ++ arch/arm/boot/dts/bcm958625k.dts | 8 2 files changed, 26 insertions(+)

[PATCH v2 4/6] net: ethernet: bgmac: convert to feature flags

that struct. In place of that, each "feature" has been given a flag, and the flags are enabled for their respective device and SoC. Signed-off-by: Jon Mason <jon.ma...@broadcom.com> Acked-by: Arnd Bergmann <a...@arndb.de> --- drivers/net/ethernet/

[PATCH v2 5/6] net: ethernet: bgmac: Add platform device support

platform functions that access the same areas via MMIO. This necessitated adding function pointers for both platform and bcma to hide which backend is being used from the generic bgmac code. Signed-off-by: Jon Mason <jon.ma...@broadcom.com> Acked-by: Arnd Bergmann <a...@arndb.de> ---

[PATCH v2 0/6] net: ethernet: bgmac: Add platform device support

board (NS SoC), and that the platform code works using a 58625K board (NSP SoC). Thanks, Jon Jon Mason (6): net: ethernet: bgmac: change bgmac_* prints to dev_* prints net: ethernet: bgmac: add dma_dev pointer net: ethernet: bgmac: move BCMA MDIO Phy code into a separate file net: ethernet: bgmac: conv

[PATCH v2 6/6] dt-bindings: net: bgmac: add bindings documentation for bgmac

Signed-off-by: Jon Mason <jon.ma...@broadcom.com> --- .../devicetree/bindings/net/brcm,amac.txt | 24 ++ .../devicetree/bindings/net/brcm,bgmac-nsp.txt | 24 ++ 2 files changed, 48 insertions(+) create mode 100644 Documentation/devi

[PATCH v2 1/6] net: ethernet: bgmac: change bgmac_* prints to dev_* prints

netdev_* prints are more appropriate, so change those as well. Signed-off-by: Jon Mason <jon.ma...@broadcom.com> Acked-by: Arnd Bergmann <a...@arndb.de> --- drivers/net/ethernet/broadcom/bgmac.c | 103 +- drivers/net/ethernet/broadcom/bgmac.h | 14 +-

[PATCH v2 2/6] net: ethernet: bgmac: add dma_dev pointer

-by: Jon Mason <jon.ma...@broadcom.com> Acked-by: Arnd Bergmann <a...@arndb.de> --- drivers/net/ethernet/broadcom/bgmac.c | 17 + drivers/net/ethernet/broadcom/bgmac.h | 1 + 2 files changed, 10 insertions(+), 8 deletions(-) diff --git a/drivers/net/ethernet/broadco

[PATCH v2 3/6] net: ethernet: bgmac: move BCMA MDIO Phy code into a separate file

more changes to the driver. Note: the phy_reset was intentionally removed, as the mdio phy subsystem automatically resets the phy if a reset function pointer is present. In addition to the moving of the driver, this reset function is added. Signed-off-by: Jon Mason <jon.ma...@broadcom.com>

Re: [PATCH 6/7] dt-bindings: net: bgmac: add bindings documentation for bgmac

On Wed, Jul 6, 2016 at 3:34 AM, Arnd Bergmann <a...@arndb.de> wrote: > On Tuesday, July 5, 2016 7:18:45 PM CEST Jon Mason wrote: >> > >> > Ok, then I'd suggest making the compatible string here >> > >> > compatible = "brcm,nsp-amac",

Re: [PATCH 6/7] dt-bindings: net: bgmac: add bindings documentation for bgmac

On Tue, Jul 5, 2016 at 9:37 AM, Arnd Bergmann <a...@arndb.de> wrote: > On Monday, July 4, 2016 9:34:35 AM CEST Ray Jui wrote: >> On 7/1/2016 8:42 AM, Arnd Bergmann wrote: >> > On Friday, July 1, 2016 11:17:25 AM CEST Jon Mason wrote: >> >> On Fri, J

Re: WARNING: CPU: 0 PID: 0 at net/ipv4/af_inet.c:155 inet_sock_destruct+0x1c4/0x1dc

On 05/07/2016 23:22, Florian Fainelli wrote: > On 07/05/2016 01:26 PM, Mason wrote: >> On 05/07/2016 18:20, Florian Fainelli wrote: >>> On 07/05/2016 08:56 AM, Mason wrote: >>>> On 05/07/2016 17:28, Florian Fainelli wrote: >>>> >>>>&

Re: WARNING: CPU: 0 PID: 0 at net/ipv4/af_inet.c:155 inet_sock_destruct+0x1c4/0x1dc

On 05/07/2016 18:20, Florian Fainelli wrote: > On 07/05/2016 08:56 AM, Mason wrote: >> On 05/07/2016 17:28, Florian Fainelli wrote: >> >>> nb8800.c does not currently show suspend/resume hooks implemented, are >>> you positive that when you suspend, you properly te

Re: WARNING: CPU: 0 PID: 0 at net/ipv4/af_inet.c:155 inet_sock_destruct+0x1c4/0x1dc

On 05/07/2016 17:28, Florian Fainelli wrote: > nb8800.c does not currently show suspend/resume hooks implemented, are > you positive that when you suspend, you properly tear down all HW, stop > transmit queues, etc. and do the opposite upon resumption? I am currently testing the error path for

Re: WARNING: CPU: 0 PID: 0 at net/ipv4/af_inet.c:155 inet_sock_destruct+0x1c4/0x1dc

On 05/07/2016 15:33, Mason wrote: > I was testing suspend/resume sequences where the suspend operation > fails and returns without having suspended the platform. > > # echo mem > /sys/power/state > [ 90.322264] PM: Syncing filesystems ... done. > [ 90.328758] Freezing

WARNING: CPU: 0 PID: 0 at net/ipv4/af_inet.c:155 inet_sock_destruct+0x1c4/0x1dc

Hello, I was testing suspend/resume sequences where the suspend operation fails and returns without having suspended the platform. # echo mem > /sys/power/state [ 90.322264] PM: Syncing filesystems ... done. [ 90.328758] Freezing user space processes ... (elapsed 0.001 seconds) done. [

Re: [PATCH 6/7] dt-bindings: net: bgmac: add bindings documentation for bgmac

On Fri, Jul 1, 2016 at 5:46 AM, Arnd Bergmann <a...@arndb.de> wrote: > On Thursday, June 30, 2016 6:59:13 PM CEST Jon Mason wrote: >> + >> +Required properties: >> + - compatible: "brcm,bgmac-nsp" >> + - reg:Address and length of the

Re: [PATCH 6/7] dt-bindings: net: bgmac: add bindings documentation for bgmac

On Thu, Jun 30, 2016 at 10:56 PM, Rob Herring <r...@kernel.org> wrote: > On Thu, Jun 30, 2016 at 06:59:13PM -0400, Jon Mason wrote: >> Signed-off-by: Jon Mason <jon.ma...@broadcom.com> >> --- >> .../devicetree/bindings/net/brcm,bgmac-nsp.txt | 24 >> ++

[PATCH 3/7] net: ethernet: bgmac: move BCMA MDIO Phy code into a separate file

more changes to the driver. Note: the phy_reset was intentionally removed, as the mdio phy subsystem automatically resets the phy if a reset function pointer is present. In addition to the moving of the driver, this reset function is added. Signed-off-by: Jon Mason <jon.ma...@broadcom.

[PATCH 5/7] net: ethernet: bgmac: Add platform device support

platform functions that access the same areas via MMIO. This necessitated adding function pointers for both platform and bcma to hide which backend is being used from the generic bgmac code. Signed-off-by: Jon Mason <jon.ma...@broadcom.com> --- drivers/net/ethernet/broadcom/Kconfig

[PATCH 4/7] net: ethernet: bgmac: convert to feature flags

that struct. In place of that, each "feature" has been given a flag, and the flags are enabled for their respective device and SoC. Signed-off-by: Jon Mason <jon.ma...@broadcom.com> --- drivers/net/ethernet/broadcom/bgmac.c | 167 -- drivers/net/ethernet/

[PATCH 1/7] net: ethernet: bgmac: change bgmac_* prints to dev_* prints

netdev_* prints are more appropriate, so change those as well. Signed-off-by: Jon Mason <jon.ma...@broadcom.com> --- drivers/net/ethernet/broadcom/bgmac.c | 103 +- drivers/net/ethernet/broadcom/bgmac.h | 14 + 2 files changed, 55 insertions(+), 62 del

[PATCH 7/7] ARM: dts: NSP: Add bgmac entries

Add device tree entries for the ethernet devices present on the Broadcom Northstar Plus SoCs Signed-off-by: Jon Mason <jon.ma...@broadcom.com> --- arch/arm/boot/dts/bcm-nsp.dtsi | 18 ++ arch/arm/boot/dts/bcm958625k.dts | 8 2 files changed, 26 insertions(+)

[PATCH 0/7] net: ethernet: bgmac: Add platform device support

tform code works using a 58625K board (NSP SoC). Thanks, Jon Jon Mason (7): net: ethernet: bgmac: change bgmac_* prints to dev_* prints net: ethernet: bgmac: add dma_dev pointer net: ethernet: bgmac: move BCMA MDIO Phy code into a separate file net: ethernet: bgmac: convert to feature f

[PATCH 2/7] net: ethernet: bgmac: add dma_dev pointer

-by: Jon Mason <jon.ma...@broadcom.com> --- drivers/net/ethernet/broadcom/bgmac.c | 17 + drivers/net/ethernet/broadcom/bgmac.h | 1 + 2 files changed, 10 insertions(+), 8 deletions(-) diff --git a/drivers/net/ethernet/broadcom/bgmac.c b/drivers/net/ethernet/broadcom/bgmac.c

[PATCH 6/7] dt-bindings: net: bgmac: add bindings documentation for bgmac

Signed-off-by: Jon Mason <jon.ma...@broadcom.com> --- .../devicetree/bindings/net/brcm,bgmac-nsp.txt | 24 ++ 1 file changed, 24 insertions(+) create mode 100644 Documentation/devicetree/bindings/net/brcm,bgmac-nsp.txt diff --git a/Documentation/devicetree/bindin

Re: [RFC 6/7] dt-bindings: net: bgmac: add bindings documentation for bgmac

On Thu, Jun 30, 2016 at 2:06 PM, Ray Jui <ray@broadcom.com> wrote: > Hi Jon, > > On 6/28/2016 12:34 PM, Jon Mason wrote: >> >> Signed-off-by: Jon Mason <jon.ma...@broadcom.com> >> --- >> .../devicetree/bindings/net/brcm,bgmac-enet.txt | 21 &g

Re: [RFC 5/7] net: ethernet: bgmac: Add platform device support

On Thu, Jun 30, 2016 at 1:58 PM, Ray Jui <ray@broadcom.com> wrote: > Hi Jon, > > > On 6/28/2016 12:34 PM, Jon Mason wrote: >> >> The bcma portion of the driver has been split off into a bcma specific >> driver. This has been mirrored for the plat

Re: [RFC 3/7] net: ethernet: bgmac: move BCMA MDIO Phy code into a separate file

On Wed, Jun 29, 2016 at 4:15 PM, Andrew Lunn <and...@lunn.ch> wrote: > On Wed, Jun 29, 2016 at 04:08:20PM -0400, Jon Mason wrote: >> On Wed, Jun 29, 2016 at 2:46 PM, Andrew Lunn <and...@lunn.ch> wrote: >> > On Wed, Jun 29, 2016 at 11:35:28AM -0700, Florian Fainelli wr

Re: [RFC 1/7] net: ethernet: bgmac: change bgmac_* prints to dev_* prints

On Tue, Jun 28, 2016 at 3:43 PM, Joe Perches <j...@perches.com> wrote: > On Tue, 2016-06-28 at 15:34 -0400, Jon Mason wrote: >> The bgmac_* print wrappers call dev_* prints with the dev pointer from >> the bcma core. In anticipation of removing the bcma requirement for >&

Re: [RFC 3/7] net: ethernet: bgmac: move BCMA MDIO Phy code into a separate file

On Wed, Jun 29, 2016 at 2:46 PM, Andrew Lunn wrote: > On Wed, Jun 29, 2016 at 11:35:28AM -0700, Florian Fainelli wrote: >> On 06/29/2016 07:13 AM, Andrew Lunn wrote: >> > Hi Jon >> > >> > I know you are just refactoring code, but at some point it would be >> > good to take a

[RFC 1/7] net: ethernet: bgmac: change bgmac_* prints to dev_* prints

netdev_* prints are more appropriate, so change those as well. Signed-off-by: Jon Mason <jon.ma...@broadcom.com> --- drivers/net/ethernet/broadcom/bgmac.c | 105 +- drivers/net/ethernet/broadcom/bgmac.h | 14 + 2 files changed, 56 insertions(+), 63 del

[RFC 3/7] net: ethernet: bgmac: move BCMA MDIO Phy code into a separate file

more changes to the driver. Note: the phy_reset was intentionally removed, as the mdio phy subsystem automatically resets the phy if a reset function pointer is present. In addition to the moving of the driver, this reset function is added. Signed-off-by: Jon Mason <jon.ma...@broadcom.

[RFC 5/7] net: ethernet: bgmac: Add platform device support

platform functions that access the same areas via MMIO. This necessitated adding function pointers for both platform and bcma to hide which backend is being used from the generic bgmac code. Signed-off-by: Jon Mason <jon.ma...@broadcom.com> --- drivers/net/ethernet/broadcom/Kconfig

[RFC 4/7] net: ethernet: bgmac: convert to feature flags

that struct. In place of that, each "feature" has been given a flag, and the flags are enabled for their respective device and SoC. Signed-off-by: Jon Mason <jon.ma...@broadcom.com> --- drivers/net/ethernet/broadcom/bgmac.c | 167 -- drivers/net/ethernet/

[RFC 0/7] net: ethernet: bgmac: Add platform device support

ch the NSP bgmac can use for the external MDIO Phy to properly connect (instead of using the fixed phy). Thanks, Jon Jon Mason (7): net: ethernet: bgmac: change bgmac_* prints to dev_* prints net: ethernet: bgmac: add dma_dev pointer net: ethernet: bgmac: move BCMA MDIO Phy code into a sep

[RFC 7/7] ARM: dts: NSP: Add bgmac entries

Add device tree entries for the ethernet devices present on the Broadcom Northstar Plus SoCs Signed-off-by: Jon Mason <jon.ma...@broadcom.com> --- arch/arm/boot/dts/bcm-nsp.dtsi | 16 arch/arm/boot/dts/bcm958625k.dts | 8 2 files changed, 24 insertions(+) diff

[RFC 6/7] dt-bindings: net: bgmac: add bindings documentation for bgmac

Signed-off-by: Jon Mason <jon.ma...@broadcom.com> --- .../devicetree/bindings/net/brcm,bgmac-enet.txt | 21 + 1 file changed, 21 insertions(+) create mode 100644 Documentation/devicetree/bindings/net/brcm,bgmac-enet.txt diff --git a/Documentation/devicetree/bindin

[RFC 2/7] net: ethernet: bgmac: add dma_dev pointer

-by: Jon Mason <jon.ma...@broadcom.com> --- drivers/net/ethernet/broadcom/bgmac.c | 17 + drivers/net/ethernet/broadcom/bgmac.h | 1 + 2 files changed, 10 insertions(+), 8 deletions(-) diff --git a/drivers/net/ethernet/broadcom/bgmac.c b/drivers/net/ethernet/broadcom/bgmac.c

Re: [PATCH] net: phy: at803x: don't depend on GPIOLIB

On 22/03/2016 20:42, Uwe Kleine-König wrote: > Preconditions: > - Some of the devices a given driver handles have a reset line and >others don't. > - A non-empty subset (maybe all) of the devices that have a reset line >require that this reset line is used. > > Then the way to handle

Re: [PATCH] net: phy: at803x: don't depend on GPIOLIB

On 18/03/2016 20:12, Uwe Kleine-König wrote: > On Fri, Mar 18, 2016 at 04:56:21PM +0100, Sebastian Frias wrote: > >> What would you think of making at803x_link_change_notify() print a >> message every time it should do a reset but does not has a way to do it? > > Then this question is obsolete

Re: [PATCH] net: phy: at803x: don't depend on GPIOLIB

On 18/03/2016 21:11, Uwe Kleine-König wrote: > Hello, > > On Fri, Mar 18, 2016 at 08:31:20PM +0100, Mason wrote: > >> On 18/03/2016 20:12, Uwe Kleine-König wrote: >> >>> On Fri, Mar 18, 2016 at 04:56:21PM +0100, Sebastian Frias wrote: >&g

Re: [PATCH] net: phy: at803x: don't depend on GPIOLIB

[ CCing a few devs who might be interested ] On 16/03/2016 18:25, Sebastian Frias wrote: > Commit 687908c2b649 ("net: phy: at803x: simplify using > devm_gpiod_get_optional and its 4th argument") introduced a dependency > on GPIOLIB that was not there before. > > This commit removes such

Re: [PATCH v5] net: ethernet: nb8800: support fixed-link DT node

On 16/02/2016 21:04, David Miller wrote: > This doesn't apply, please respin against my tree. I fixed several formatting issues with Sebastian's patch, and submitted v6. Regards.

[PATCH v6] net: ethernet: nb8800: support fixed-link DT node

-less-connection-to-a-dsa-switch This patch adds support for the "fixed-link" node to the nb8800 driver. Signed-off-by: Sebastian Frias <s...@laposte.net> Acked-by: Mans Rullgard <m...@mansr.com> Cc: Mason <slash@free.fr> --- There were spurious spaces in the prev

Re: [PATCH v3] net: ethernet: support "fixed-link" DT node on nb8800 driver

On 08/02/2016 14:37, Måns Rullgård wrote: > Sebastian Frias wrote: > >> By the way, I know some people like the command line, email, etc. but >> there ought to be other tools better suited for patch review... > > Some kernel subsystems use http://patchwork.ozlabs.org/ to track status > of

Re: [PATCH 2/4] net: phy: at803x: Allow specifying the RGMII RX clock delay via phy mode

On 27/12/2015 04:28, Florian Fainelli wrote: > Le 25/12/2015 16:27, Martin Blumenstingl wrote: > >> diff --git a/drivers/net/phy/at803x.c b/drivers/net/phy/at803x.c >> index f566b6e..0b262a2 100644 >> --- a/drivers/net/phy/at803x.c >> +++ b/drivers/net/phy/at803x.c >> @@ -36,8 +36,10 @@ >>

Re: Small improvements for the at803x PHY driver

[ CCing people who might be interested in this patch series ] On 26/12/2015 01:26, Martin Blumenstingl wrote: > while trying to debug a problem on a board with an AR8030 PHY (which turned > out to be an incorrectly configured MDC clock) I made a few changes to the > at803x driver. > Due to lack

Re: [PATCH v8] net: ethernet: add driver for Aurora VLSI NB8800 Ethernet controller

On 25/11/2015 17:16, Måns Rullgård wrote: > Alexander Duyck writes: > >> On Wed, Nov 25, 2015 at 5:04 AM, Måns Rullgård wrote: >> >>> Mason writes: >>> >>>> On 25/11/2015 13:45, Måns Rullgård wrote: >>>> >>>

Re: [PATCH v8] net: ethernet: add driver for Aurora VLSI NB8800 Ethernet controller

On 19/11/2015 14:02, Mans Rullgard wrote: > + if (dma_mapping_error(>dev, dma_addr)) { > + skb_free_frag(data); > + return -ENOMEM; > + } I'm back-porting this driver to 4.1 skb_free_frag() was introduced in 4.2 by 181edb2bfa22b IIUC. +static inline void

Re: [PATCH v8] net: ethernet: add driver for Aurora VLSI NB8800 Ethernet controller

[ Using different address for Alexander ] On 25/11/2015 13:36, Mason wrote: > On 19/11/2015 14:02, Mans Rullgard wrote: > >> +if (dma_mapping_error(>dev, dma_addr)) { >> +skb_free_frag(data); >> +return -ENOMEM; >> +} > &

Re: [PATCH v8] net: ethernet: add driver for Aurora VLSI NB8800 Ethernet controller

On 25/11/2015 13:45, Måns Rullgård wrote: > Mason wrote: > >> On 19/11/2015 14:02, Mans Rullgard wrote: >> >>> + if (dma_mapping_error(>dev, dma_addr)) { >>> + skb_free_frag(data); >>> + return -ENOMEM; >>> + } >

Re: [PATCH] net: phy: vitesse: add support for VSC8601

On 12/11/2015 19:41, Mans Rullgard wrote: > + .phy_id = PHY_ID_VSC8601, > + .name = "Vitesse VSC8601", > + .phy_id_mask= 0x0000, > + .features = PHY_GBIT_FEATURES, > + .flags = PHY_HAS_INTERRUPT, > + .config_init= _config_init,

Re: [PATCH] net: phy: at803x: support interrupt on 8030 and 8035

On 12/11/2015 20:14, Florian Fainelli wrote: > On 12/11/15 11:09, Måns Rullgård wrote: >> On 12 November 2015 19:06:23 GMT+00:00, Mason wrote: >>> On 12/11/2015 18:40, Mans Rullgard wrote: >>>> Commit 77a993942 "phy/at8031: enable at8031 to work on interrupt

Re: [PATCH v5] net: ethernet: add driver for Aurora VLSI NB8800 Ethernet controller

On 10/11/2015 20:25, Måns Rullgård wrote: > Mason writes: > >> On 10/11/2015 17:14, Mans Rullgard wrote: >> >>> This adds a driver for the Aurora VLSI NB8800 Ethernet controller. >>> It is an almost complete rewrite of a driver originally found in >>>

Re: [PATCH v5] net: ethernet: add driver for Aurora VLSI NB8800 Ethernet controller

[ CCing a few knowledgeable people ] Despite the subject, this is about an Atheros 8035 PHY :-) On 12/11/2015 15:04, Måns Rullgård wrote: > Mason wrote: > >> BTW, you're not using the PHY IRQ, right? I think I remember you saying >> it didn't work reliably? > > It doe

Re: [PATCH] net: phy: at803x: support interrupt on 8030 and 8035

On 12/11/2015 18:40, Mans Rullgard wrote: > Commit 77a993942 "phy/at8031: enable at8031 to work on interrupt mode" > added interrupt support for the 8031 PHY but left out the other two > chips supported by this driver. > > This patch sets the .ack_interrupt and .config_intr functions for the >

Re: [PATCH v5] net: ethernet: add driver for Aurora VLSI NB8800 Ethernet controller

On 10/11/2015 17:14, Mans Rullgard wrote: > This adds a driver for the Aurora VLSI NB8800 Ethernet controller. > It is an almost complete rewrite of a driver originally found in > a Sigma Designs 2.6.22 tree. > > Signed-off-by: Mans Rullgard > --- > Changes: > - Refactored mdio

Re: [RFC] net: use atomic allocation for order-3 page allocation

On 06/11/2015 04:48 PM, Eric Dumazet wrote: On Thu, 2015-06-11 at 13:24 -0700, Shaohua Li wrote: We saw excessive memory compaction triggered by skb_page_frag_refill. This causes performance issues. Commit 5640f7685831e0 introduces the order-3 allocation to improve performance. But memory

Re: [RFC] net: use atomic allocation for order-3 page allocation

On 06/11/2015 05:22 PM, Eric Dumazet wrote: On Thu, 2015-06-11 at 17:16 -0400, Chris Mason wrote: On 06/11/2015 04:48 PM, Eric Dumazet wrote: networking is asking for 32KB, and the MM layer is doing what it can to provide it. Are the gains from getting 32KB contig bigger than the cost

[PATCH] add NAPI support to sb1250-mac.c (take 2)

Patch to add NAPI support to sb1250-mac.c (rev 2). This patch differs from the last in that the NAPI support isn't marked as experimental, nor is it configurable (ie. once applied - NAPI is enabled all the time). This was based on feedback from Ralf and others. Signed-off-by: Mark Mason [EMAIL

RE: [PATCH] NAPI support for Sibyte MAC

Hello, -Original Message- From: Sergei Shtylyov [mailto:[EMAIL PROTECTED] Sent: Saturday, March 24, 2007 12:49 PM To: Mark E Mason Cc: [EMAIL PROTECTED]; netdev@vger.kernel.org Subject: Re: [PATCH] NAPI support for Sibyte MAC [snip] @@ -2075,12 +2143,52

[PATCH] NAPI support for Sibyte MAC

routine. Signed off by: Mark Mason ([EMAIL PROTECTED]) Signed off by: Dan Krejsa ([EMAIL PROTECTED]) Signed off by: Steve Yang ([EMAIL PROTECTED]) Index: linux-2.6.14-cgl/drivers/net/Kconfig === --- linux-2.6.14-cgl.orig

[PATCH] bridge: add ETH_HLEN to packet_length

it would be better to drop those skbs than panic. Attached is a patch to do this. Thanks, Jon Signed-off-by: Jon Mason [EMAIL PROTECTED] diff -r b1d36669f98d net/bridge/br_forward.c --- a/net/bridge/br_forward.c Mon Sep 4 03:00:04 2006 + +++ b/net/bridge/br_forward.c Thu Sep 14 13:18:04 2006

Re: [PATCH] bridge: add ETH_HLEN to packet_length

On Thu, Sep 14, 2006 at 11:53:48PM +0300, Mika Penttil? wrote: Jon Mason wrote: In br_dev_queue_push_xmit, why is the check to drop mtu oversized packets not checking for enough room for the impending ETH_HLEN size skb_push? In some code currently under development, we are seeing

RE: PATCH SB1250 NAPI support

it if it could be merged in. Thx, Mark Mason Broadcom -Original Message- From: Martin Michlmayr [mailto:[EMAIL PROTECTED] Sent: Thursday, June 29, 2006 1:22 AM To: [EMAIL PROTECTED]; netdev@vger.kernel.org Cc: Tom Rix; Mark E Mason Subject: Re: PATCH SB1250 NAPI support * Tom Rix

Re: [RFT] pcnet32 NAPI changes

On Mon, Jun 19, 2006 at 04:49:33PM -0400, Lennart Sorensen wrote: On Mon, Jun 19, 2006 at 03:41:40PM -0500, Jon Mason wrote: I believe it is preferred to be a compile option for non-gigabit drivers, given that it will be eating a lot of cycles for infrequent packets (especially for the 10Mb

Re: [RFT] pcnet32 NAPI changes

On Tue, Jun 20, 2006 at 10:48:07AM -0400, Lennart Sorensen wrote: On Tue, Jun 20, 2006 at 08:53:55AM -0500, Jon Mason wrote: The amount of polls per received packet is very low, thus removing the benefit of NAPI. A compile time option would allow those users who know better to DTRT

Re: [RFT] pcnet32 NAPI changes

On Fri, Jun 16, 2006 at 12:11:54PM -0700, Don Fry wrote: This patch is a collection of changes to pcnet32 which does the following: - Fix section mismatch warning. - fix set_ringparam to correctly handle memory allocation failures - fix off-by-one in get_ringparam. - cleanup at end of

Re: dl2k: PCI parity error

On Sat, May 13, 2006 at 09:57:15AM -0700, Shane wrote: Hello list, Not sure if this is the best place to report this. I seem to be having a conflict of sorts and believe it may be a dl2k issue. The card is a Dlink 550t gigabit pci-64 card. When connected to the pci-64 slot on the mb

Re: [PATCH] pcnet32.c: modify RX ring size through module parameter

Why is this necessary? There is already an ethtool function to set the rx ring size (pcnet32_set_ringparam). Since module parameters are being phased out in favor of the ethtool functions, why not use the existing ethtool infrastructure for this? Thanks, Jon On Mon, May 15, 2006 at 11:32:14AM

Re: [PATCH -mm] dl2k gcc 4.1 warning fix

On Tue, May 09, 2006 at 07:55:57PM -0700, Daniel Walker wrote: Fixes the following warning, Please CC netdev on networking patches. All the changed lines are over 80 chars. Please fix. Thanks, Jon drivers/net/dl2k.c: In function 'rio_free_tx': drivers/net/dl2k.c:768: warning: integer

Re: [PATCH] dl2k: use explicit DMA_48BIT_MASK

On Wed, May 10, 2006 at 08:57:18PM +0200, Francois Romieu wrote: Typo will be harder with this one. While I agree that a #define is much better than the magic number, I think this is bastardizing the intended use of DMA_*BIT_MASK. DMA_*BIT_MASK is intended to be used in the DMA_API's checking of

[PATCH] dl2k: DMA freeing error

Signed-off-by: Jon Mason [EMAIL PROTECTED] diff -r c698c94ff82e drivers/net/dl2k.c --- a/drivers/net/dl2k.cThu Mar 9 15:03:49 2006 +++ b/drivers/net/dl2k.cFri Mar 10 08:48:50 2006 @@ -50,8 +50,8 @@ */ #define DRV_NAME D-Link DL2000-based linux driver -#define DRV_VERSION

Re: help with kernel crasing in skb_over_panic

On Thu, Mar 09, 2006 at 10:06:29AM -0600, Kumar Gala wrote: I was hoping someone might have some ideas on what might have happened with the following oops/BUG(). This is on an embedded PPC running 2.6.16-rc5. From the description I got from my coworker who say this, he was doing NFS on

[PATCH] trivial: fix spelling errors in Kconfigs

Resubmission of patch originally sent on November 17, modified to apply cleanly to 2.6.16 This patch corrects a few spelling and grammar errors found in drivers/net Signed-off-by: Jon Mason [EMAIL PROTECTED] diff -r 2fa13972604f drivers/net/Kconfig --- a/drivers/net/Kconfig Wed Feb 8 17

[PATCH] pcnet32: Add PCI_DEVICE macro to pcnet32_pci_tbl

This patch adds the PCI_DEVICE macro to the pcnet32 driver. This has been tested on my opteron with my trident adapter. Thanks, Jon Signed-off-by: Jon Mason [EMAIL PROTECTED] diff -r 4a7597b41d25 drivers/net/pcnet32.c --- a/drivers/net/pcnet32.c Wed Jan 11 19:14:08 2006 +++ b/drivers/net

Re: [RFC] [PATCH 0/3] ioat: DMA engine support

On Wed, Nov 23, 2005 at 05:45:36PM -0500, Jeff Garzik wrote: Andrew Grover wrote: As presented in our talk at this year's OLS, the Bensley platform, which will be out in early 2006, will have an asyncronous DMA engine. It can be used to offload copies from the CPU, such as the kernel copies

[PATCH] fix spelling errors in netdev Kconfigs

I ran aspell on the Kconfigs in drivers/net/ and found the following spelling errors. Signed-off-by: Jon Mason [EMAIL PROTECTED] diff -r 971dbac4c501 drivers/net/Kconfig --- a/drivers/net/Kconfig Wed Nov 16 16:25:28 2005 +++ b/drivers/net/Kconfig Thu Nov 17 08:24:31 2005 @@ -55,7

<    1   2   3