Hi Geert,
Am 04.05.2018 um 19:24 schrieb Geert Uytterhoeven:
> Hi Michael,
>
>>> Yes, that would be useful. The other assumption could be that
>>> platform devices always allow an all-0xff dma mask.
>>
>> That's not always true (Atari NCR5380 SCSI and floppy would use a 24
>> bit DMA mask). We
Hi Finn,
Am 11.05.2018 um 15:28 schrieb Finn Thain:
> On Fri, 11 May 2018, Michael Schmitz wrote:
>
>>>> Which begs the question: why can' you set up all Nubus bus devices'
>>>> DMA masks in nubus_device_register(), or nubus_add_board()?
>>>
>>
Hi Finn,
On Fri, May 11, 2018 at 11:55 AM, Finn Thain wrote:
>> > What's worse, if you do pass a dma_mask in struct
>> > platform_device_info, you end up with this problem in
>> > platform_device_register_full():
>> >
>> > if (pdevinfo->dma_mask) {
>> >
Hi Finn,
Am 11.05.2018 um 17:28 schrieb Finn Thain:
> On Fri, 11 May 2018, Michael Schmitz wrote:
>
>>
>> I'm afraid using platform_device_register() (which you already use for
>> the SCC devices) is the only option handling this on a per-device basis
>> witho
Hi Finn,
Am 11.05.2018 um 22:06 schrieb Finn Thain:
>> You would have to be careful not to overwrite a pdev->dev.dma_mask and
>> pdev->dev.dma_coherent_mask that might have been set in a platform
>> device passed via platform_device_register here. Coldfire is the only
>> m68k platform
Hi Finn,
On Thu, May 10, 2018 at 1:25 PM, Finn Thain wrote:
> On Thu, 3 May 2018, Geert Uytterhoeven wrote:
>
>>
>> Perhaps you can add a new helper
>> (platform_device_register_simple_dma()?) that takes the DMA mask, too?
[...]
> To actually hoist the dma mask setup
Hi Christoph,
On Thu, May 3, 2018 at 8:51 PM, Christoph Hellwig wrote:
> On Thu, May 03, 2018 at 10:46:56AM +0200, Geert Uytterhoeven wrote:
>> Perhaps you can add a new helper (platform_device_register_simple_dma()?)
>> that takes the DMA mask, too?
>> With people setting the mask
Hi Finn,
thanks for the feedback!
On Wed, Apr 18, 2018 at 5:45 PM, Finn Thain wrote:
>> > 1/9 net: phy: new Asix Electronics PHY driver
>> > 2/9 net: ax88796: Fix MAC address reading
>> > 3/9 net: ax88796: Attach MII bus only when open
>> > 4/9 net: ax88796: Do not
Hi Andrew,
sorry, my mistake. I didn't realize how fast DaveM's tree diverges
from Linus' (and Geert's) once the merge window opens.
Cheers,
Michael
On Thu, Apr 19, 2018 at 12:19 AM, Andrew Lunn <and...@lunn.ch> wrote:
> On Wed, Apr 18, 2018 at 05:10:45PM +1200, Michael Schm
All,
just noticed belatedly that the Makefile hunk of patch 9 does no
longer apply cleanly in 4.17-rc1, sorry. My series was based on 4.16.
I'll resend that one, OK?
Cheers,
Michael
On Wed, Apr 18, 2018 at 4:26 PM, Michael Schmitz <schmitz...@gmail.com> wrote:
> This patch se
From: Michael Schmitz <schm...@debian.org>
Unregister and free up mdiobus resources if ax_mii_init() failed.
Signed-off-by: Michael Karcher <ker...@mkarcher.dialup.fu-berlin.de>
Signed-off-by: Michael Schmitz <schmitz...@gmail.com>
---
drivers/net/ethernet/8390/ax88796.c |
;
Signed-off-by: Michael Schmitz <schmitz...@gmail.com>
---
drivers/net/ethernet/8390/ax88796.c |6 ++
1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/drivers/net/ethernet/8390/ax88796.c
b/drivers/net/ethernet/8390/ax88796.c
index 2455547..2a256aa 100644
--- a/drivers/net/ether
8796.c | 66 +-
drivers/net/ethernet/8390/xsurf100.c | 411 ++
include/net/ax88796.h| 14 +-
5 files changed, 495 insertions(+), 11 deletions(-)
Cheers,
Michael Schmitz
From: John Paul Adrian Glaubitz
This complements the fix in 82533ad9a1c that removed the free_irq
call in the error path of probe, to also not call free_irq when
remove is called to revert the effects of probe.
Signed-off-by: Michael Karcher
.de>
Signed-off-by: Michael Schmitz <schmitz...@gmail.com>
---
drivers/net/ethernet/8390/Kconfig| 14 +-
drivers/net/ethernet/8390/Makefile |1 +
drivers/net/ethernet/8390/xsurf100.c | 411 ++
3 files changed, 425 insertions(+), 1 deletions(-)
create
rcher <ker...@mkarcher.dialup.fu-berlin.de>
Signed-off-by: Michael Schmitz <schmitz...@gmail.com>
---
drivers/net/ethernet/8390/ax88796.c | 23 +--
include/net/ax88796.h |5 +
2 files changed, 26 insertions(+), 2 deletions(-)
diff --git a/drivers/net/e
Add platform specific hooks for block transfer reads/writes of packet
buffer data, superseding the default provided ax_block_input/output.
Currently used for m68k Amiga XSurf100.
Signed-off-by: Michael Karcher <ker...@mkarcher.dialup.fu-berlin.de>
Signed-off-by: Michael Schmitz &l
r <ker...@mkarcher.dialup.fu-berlin.de>
Signed-off-by: Michael Schmitz <schmitz...@gmail.com>
---
drivers/net/ethernet/8390/ax88796.c | 13 +
1 files changed, 9 insertions(+), 4 deletions(-)
diff --git a/drivers/net/ethernet/8390/ax88796.c
b/drivers/net/ethernet/8390/ax88796.c
inde
From: John Paul Adrian Glaubitz
The AX88796B as installed on the X-Surf-100 does not recognize a MII reset
request if the previous write to the MII control register also was a reset
request. So a dummy write to the control register makes the soft reset in
the PHY
From: John Paul Adrian Glaubitz <glaub...@physik.fu-berlin.de>
On the Amiga X-Surf100, the network card interrupt is shared with many
other interrupt sources, so requires the IRQF_SHARED flag to register.
Signed-off-by: Michael Karcher <ker...@mkarcher.dialup.fu-berlin.de>
Signed-off
The net device struct pointer is stored as platform device drvdata on
module probe - clear the drvdata entry on probe fail there, as well as
when unloading the module.
Signed-off-by: Michael Schmitz <schmitz...@gmail.com>
---
drivers/net/ethernet/8390/ax88796.c |2 ++
1 files chan
Thanks Florian,
I'll keep the Asix PHY driver separate from ax88796 for now. Mainly to
simplify testing. Let's see whether it can be used by any other MAC -
can still fold it into ax88796 later.
Cheers,
Michael
On Wed, Apr 18, 2018 at 6:08 AM, Florian Fainelli wrote:
Hi Geert,
thanks for your suggestions!
On Wed, Apr 18, 2018 at 1:53 AM, Geert Uytterhoeven
<ge...@linux-m68k.org> wrote:
> Hi Michael,
>
> Thanks for your patch!
>
> On Tue, Apr 17, 2018 at 12:04 AM, Michael Schmitz <schmitz...@gmail.com>
> wrote:
>> Ad
Hi Andrew,
On Wed, Apr 18, 2018 at 1:26 AM, Andrew Lunn <and...@lunn.ch> wrote:
> On Tue, Apr 17, 2018 at 02:08:15PM +1200, Michael Schmitz wrote:
>> Add platform device driver to populate the ax88796 platform data from
>> information provided by the XSurf100 zorro device d
Hi Adrian,
On Tue, Apr 17, 2018 at 11:40 PM, John Paul Adrian Glaubitz
<glaub...@physik.fu-berlin.de> wrote:
> On 04/17/2018 04:08 AM, Michael Schmitz wrote:
>>
>> From: John Paul Adrian Glaubitz <glaub...@physik.fu-berlin.de>
>
> This should b
Thanks Geert, I'll fix that.
I see my v2 series shows up as new series on patchwork - do I need to
do something different when tagging the next version, Dave?
Cheers,
Michael
On Wed, Apr 18, 2018 at 1:51 AM, David Miller wrote:
> From: Geert Uytterhoeven
Hi Andrew,
thanks, that's what I was looking for. The next version will have all
but one patch correctly attributed to Michael Karcher.
Cheers,
Michael
On Wed, Apr 18, 2018 at 9:13 AM, Andrew Lunn <and...@lunn.ch> wrote:
> On Wed, Apr 18, 2018 at 08:32:25AM +1200, Michael Schm
Hi Andrew,
thank you for reviewing this series!
On Tue, Apr 17, 2018 at 10:59 AM, Andrew Lunn <and...@lunn.ch> wrote:
> On Tue, Apr 17, 2018 at 10:04:37AM +1200, Michael Schmitz wrote:
>> From: Michael Karcher <deb...@mkarcher.dialup.fu-berlin.de>
>>
>
Hi Andrew,
On Tue, Apr 17, 2018 at 11:12 AM, Andrew Lunn <and...@lunn.ch> wrote:
> On Tue, Apr 17, 2018 at 10:04:43AM +1200, Michael Schmitz wrote:
>> From: John Paul Adrian Glaubitz <glaub...@physik.fu-berlin.de>
>>
>> The AX88796B as installed on the X-Surf-1
The net device struct pointer is stored as platform device drvdata on
module probe - clear the drvdata entry on probe fail there, as well as
when unloading the module.
Signed-off-by: Michael Schmitz <schmitz...@gmail.com>
---
drivers/net/ethernet/8390/ax88796.c |2 ++
1 files chan
From: John Paul Adrian Glaubitz
This complements the fix in 82533ad9a1c that removed the free_irq
call in the error path of probe, to also not call free_irq when
remove is called to revert the effects of probe.
Signed-off-by: Michael Karcher
.de>
Signed-off-by: Michael Schmitz <schmitz...@gmail.com>
---
drivers/net/ethernet/8390/Kconfig| 14 +-
drivers/net/ethernet/8390/Makefile |1 +
drivers/net/ethernet/8390/xsurf100.c | 411 ++
3 files changed, 425 insertions(+), 1 deletions(-)
create
From: John Paul Adrian Glaubitz <glaub...@physik.fu-berlin.de>
On the Amiga X-Surf100, the network card interrupt is shared with many
other interrupt sources, so requires the IRQF_SHARED flag to register.
Signed-off-by: Michael Karcher <ker...@mkarcher.dialup.fu-berlin.de>
Signed-off
rcher <ker...@mkarcher.dialup.fu-berlin.de>
Signed-off-by: Michael Schmitz <schmitz...@gmail.com>
---
drivers/net/ethernet/8390/ax88796.c | 23 +--
include/net/ax88796.h |5 +
2 files changed, 26 insertions(+), 2 deletions(-)
diff --git a/drivers/net/e
;
Signed-off-by: Michael Schmitz <schmitz...@gmail.com>
---
drivers/net/ethernet/8390/ax88796.c |6 ++
1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/drivers/net/ethernet/8390/ax88796.c
b/drivers/net/ethernet/8390/ax88796.c
index 2455547..2a256aa 100644
--- a/drivers/net/ether
Add platform specific hooks for block transfer reads/writes of packet
buffer data, superseding the default provided ax_block_input/output.
Currently used for m68k Amiga XSurf100.
Signed-off-by: Michael Karcher <ker...@mkarcher.dialup.fu-berlin.de>
Signed-off-by: Michael Schmitz &l
r <ker...@mkarcher.dialup.fu-berlin.de>
Signed-off-by: Michael Schmitz <schmitz...@gmail.com>
---
drivers/net/ethernet/8390/ax88796.c | 183 ++-
1 files changed, 95 insertions(+), 88 deletions(-)
diff --git a/drivers/net/ethernet/8390/ax88796.c
b/drivers/net/ether
This patch series adds support for the Individual Computers X-Surf 100
network card for m68k Amiga, a network adapter based on the AX88796 chip set.
The driver was originally written for kernel version 3.19 by Michael Karcher
(see CC:), and adapted to 4.16 for submission to netdev by me.
rhaps something to improve:
>
> [auto build test WARNING on v4.16]
> [cannot apply to net-next/master net/master v4.17-rc1 next-20180417]
> [if your patch is applied to the wrong git tree, please drop us a note to
> help improve the system]
>
> url:
> https://github.com/0d
Hi Andrew,
I agree, that's much better. I had something like that in mind before
I got distracted...
/me looking for brown paper bag now.
Cheers,
Michael
On Thu, Apr 19, 2018 at 12:13 AM, Andrew Lunn wrote:
>> +
>> +/**
>> + * asix_soft_reset - software reset the PHY via
, Andrew Lunn <and...@lunn.ch> wrote:
> On Wed, Apr 18, 2018 at 12:53:21PM +1200, Michael Schmitz wrote:
>> I think this is a false positive - we're encouraged to provide the
>> full parameter list for functions, so the sreuct sk_buff* can't be
>> avoided.
>
> Hi M
Hi Finn,
On Wed, Apr 18, 2018 at 1:23 PM, Finn Thain <fth...@telegraphics.com.au> wrote:
> On Wed, 18 Apr 2018, Michael Schmitz wrote:
>
>> I think this is a false positive - we're encouraged to provide the
>> full parameter list for functions, so the sreuct sk_buff* can't
The net device struct pointer is stored as platform device drvdata on
module probe - clear the drvdata entry on probe fail there, as well as
when unloading the module.
Signed-off-by: Michael Schmitz <schmitz...@gmail.com>
---
drivers/net/ethernet/8390/ax88796.c |2 ++
1 files chan
code duplication.
Signed-off-by: Michael Schmitz <schmitz...@gmail.com>
---
drivers/net/phy/Kconfig |6
drivers/net/phy/Makefile |1 +
drivers/net/phy/asix.c | 65 ++
drivers/net/phy/phy_device.c |3 +-
include/linux
This patch series adds support for the Individual Computers X-Surf 100
network card for m68k Amiga, a network adapter based on the AX88796 chip set.
The driver was originally written for kernel version 3.19 by Michael Karcher
(see CC:), and adapted to 4.16 for submission to netdev by me.
r <ker...@mkarcher.dialup.fu-berlin.de>
Signed-off-by: Michael Schmitz <schmitz...@gmail.com>
---
Changes in v3:
Suggested by Geert Uytterhoeven:
- use ei_local->reset_8390() instead of duplicating ax_reset_8390()
- use %pR to format struct resource pointers
- assign pd
being
compatible to the previous behaviour).
Signed-off-by: Michael Karcher <ker...@mkarcher.dialup.fu-berlin.de>
Signed-off-by: Michael Schmitz <schmitz...@gmail.com>
---
drivers/net/ethernet/8390/ax88796.c | 23 +--
include/net/ax88796.h |5 +
2 files
From: Michael Karcher <ker...@mkarcher.dialup.fu-berlin.de>
On the Amiga X-Surf100, the network card interrupt is shared with many
other interrupt sources, so requires the IRQF_SHARED flag to register.
Signed-off-by: Michael Karcher <ker...@mkarcher.dialup.fu-berlin.de>
Signed-off
;
Signed-off-by: Michael Schmitz <schmitz...@gmail.com>
---
drivers/net/ethernet/8390/ax88796.c |6 ++
1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/drivers/net/ethernet/8390/ax88796.c
b/drivers/net/ethernet/8390/ax88796.c
index 2455547..2a256aa 100644
--- a/drivers/net/ether
r <ker...@mkarcher.dialup.fu-berlin.de>
Signed-off-by: Michael Schmitz <schmitz...@gmail.com>
Reviewed-by: Andrew Lunn <and...@lunn.ch>
---
drivers/net/ethernet/8390/ax88796.c | 183 ++-
1 files changed, 95 insertions(+), 88 deletions(-)
diff --git a/drivers/n
called to revert the effects of probe.
Fixes: 82533ad9a1c (net: ethernet: ax88796: don't call free_irq without
request_irq first)
Signed-off-by: Michael Karcher <ker...@mkarcher.dialup.fu-berlin.de>
Signed-off-by: Michael Schmitz <schmitz...@gmail.com>
Reviewed-by: Geert Uytterhoeven <ge.
dialup.fu-berlin.de>
Signed-off-by: Michael Schmitz <schmitz...@gmail.com>
---
Changes in v3:
Suggested by Andrew Lunn/Finn Thain:
- declare struct sk_buff in ax88796.h
- correct whitespace error
---
drivers/net/ethernet/8390/ax88796.c | 10 --
include/net/ax88796.h
Hi Geert,
On Wed, Apr 18, 2018 at 1:53 AM, Geert Uytterhoeven
wrote:
>> --- /dev/null
>> +++ b/drivers/net/ethernet/8390/xsurf100.c
>> @@ -0,0 +1,411 @@
>> +#include
>> +#include
>> +#include
>> +#include
>> +#include
>> +#include
>> +
>> +#define
Hi,
messed up the subject there, sorry - this was meant to be
[PATCH v4 0/9] net-next: New network driver for Amiga X-Surf 100 (m68k)
Cheers,
Michael
Am 19.04.2018 um 14:05 schrieb Michael Schmitz:
> [This is a resend of my v3 series which was based on the wrong version and
>
being
compatible to the previous behaviour).
Signed-off-by: Michael Karcher <ker...@mkarcher.dialup.fu-berlin.de>
Signed-off-by: Michael Schmitz <schmitz...@gmail.com>
---
drivers/net/ethernet/8390/ax88796.c | 23 +--
include/net/ax88796.h |5 +
2 files
From: Michael Karcher <ker...@mkarcher.dialup.fu-berlin.de>
On the Amiga X-Surf100, the network card interrupt is shared with many
other interrupt sources, so requires the IRQF_SHARED flag to register.
Signed-off-by: Michael Karcher <ker...@mkarcher.dialup.fu-berlin.de>
Signed-off
The net device struct pointer is stored as platform device drvdata on
module probe - clear the drvdata entry on probe fail there, as well as
when unloading the module.
Signed-off-by: Michael Schmitz <schmitz...@gmail.com>
---
drivers/net/ethernet/8390/ax88796.c |2 ++
1 files chan
;
Signed-off-by: Michael Schmitz <schmitz...@gmail.com>
---
drivers/net/ethernet/8390/ax88796.c |6 ++
1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/drivers/net/ethernet/8390/ax88796.c
b/drivers/net/ethernet/8390/ax88796.c
index da61cf3..ae39375 100644
--- a/drivers/net/ether
r <ker...@mkarcher.dialup.fu-berlin.de>
Signed-off-by: Michael Schmitz <schmitz...@gmail.com>
---
Changes in v3:
Suggested by Geert Uytterhoeven:
- use ei_local->reset_8390() instead of duplicating ax_reset_8390()
- use %pR to format struct resource pointers
- assign pd
r <ker...@mkarcher.dialup.fu-berlin.de>
Signed-off-by: Michael Schmitz <schmitz...@gmail.com>
Reviewed-by: Andrew Lunn <and...@lunn.ch>
---
drivers/net/ethernet/8390/ax88796.c | 183 ++-
1 files changed, 95 insertions(+), 88 deletions(-)
diff --git a/drivers/n
called to revert the effects of probe.
Fixes: 82533ad9a1c (net: ethernet: ax88796: don't call free_irq without
request_irq first)
Signed-off-by: Michael Karcher <ker...@mkarcher.dialup.fu-berlin.de>
Signed-off-by: Michael Schmitz <schmitz...@gmail.com>
Reviewed-by: Geert Uytterhoeven <ge.
dialup.fu-berlin.de>
Signed-off-by: Michael Schmitz <schmitz...@gmail.com>
---
Changes in v3:
Suggested by Andrew Lunn/Finn Thain:
- declare struct sk_buff in ax88796.h
- correct whitespace error in ax88796.h
---
drivers/net/ethernet/8390/ax88796.c | 10 --
inc
<and...@lunn.ch>
Signed-off-by: Michael Schmitz <schmitz...@gmail.com>
---
Changes in v4:
Andrew Lunn:
- don't duplicate genphy_soft_reset, just call after writing zero
to control register
---
drivers/net/phy/Kconfig |6
drivers/net/phy/Makefile |1 +
drivers/ne
[This is a resend of my v3 series which was based on the wrong version and
tree. Only substantial change is to Asix AX99796B PHY driver.]
This patch series adds support for the Individual Computers X-Surf 100
network card for m68k Amiga, a network adapter based on the AX88796 chip set.
The
Thanks Dave!
And many thanks to all the reviewers and testers!
Cheers,
Michael
On Fri, Apr 20, 2018 at 8:11 AM, David Miller <da...@davemloft.net> wrote:
> From: Michael Schmitz <schmitz...@gmail.com>
> Date: Thu, 19 Apr 2018 14:05:17 +1200
>
>> Thi
65 matches
Mail list logo