On Wed, Jul 26, 2017 at 12:00 PM, David Ahern wrote:
> On 7/26/17 12:55 PM, Roopa Prabhu wrote:
>> On Wed, Jul 26, 2017 at 11:49 AM, David Ahern wrote:
>>> On 7/26/17 12:27 PM, Roopa Prabhu wrote:
>>>> agreed...so looks like the check in v3 should be
>>>&
t; unreachable 2004::/64 dev lo metric 1024 error -113 pref medium
>
> Fixes: 18c3a61c4264 ("net: ipv6: RTM_GETROUTE: return matched fib...")
> Signed-off-by: Hangbin Liu
> ---
Acked-by: Roopa Prabhu
From: Roopa Prabhu
Forward Error Correction (FEC) modes i.e Base-R
and Reed-Solomon modes are introduced in 25G/40G/100G standards
for providing good BER at high speeds. Various networking devices
which support 25G/40G/100G provides ability to manage supported FEC
modes and the lack of FEC
From: Casey Leedom
Signed-off-by: Casey Leedom
---
drivers/net/ethernet/chelsio/cxgb4/t4_hw.c | 152 ++---
1 file changed, 117 insertions(+), 35 deletions(-)
diff --git a/drivers/net/ethernet/chelsio/cxgb4/t4_hw.c
b/drivers/net/ethernet/chelsio/cxgb4/t4_hw.c
index db41
From: Casey Leedom
Signed-off-by: Casey Leedom
---
drivers/net/ethernet/chelsio/cxgb4/cxgb4_ethtool.c | 100 +
1 file changed, 100 insertions(+)
diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_ethtool.c
b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_ethtool.c
index 26eb0
FEC modes i.e. None (No FEC mode), RS, BaseR/FC
are defined so that users can configure these fec modes for supported
and advertising fields as part of link autonegotiation.
Signed-off-by: Vidya Sagar Ravipati
Signed-off-by: Dustin Byford
Signed-off-by: Roopa Prabhu
---
include/linux
On Thu, Jul 27, 2017 at 7:33 PM, Jakub Kicinski wrote:
> On Thu, 27 Jul 2017 16:47:25 -0700, Roopa Prabhu wrote:
>> From: Roopa Prabhu
>>
>> Forward Error Correction (FEC) modes i.e Base-R
>> and Reed-Solomon modes are introduced in 25G/40G/100G standards
>> for
On Fri, Jul 28, 2017 at 8:10 AM, David Ahern wrote:
> On 7/27/17 10:56 PM, Cong Wang wrote:
>> On Wed, Jul 26, 2017 at 11:49 AM, David Ahern wrote:
>>> On 7/26/17 12:27 PM, Roopa Prabhu wrote:
>>>> agreed...so looks like the check in v3 should be
>>>&
On Fri, Jul 28, 2017 at 10:39 AM, David Ahern wrote:
> On 7/28/17 11:13 AM, Roopa Prabhu wrote:
>> for fibmatch, my original intent was to return with an error code.
>> This is similar
>> to the ipv4 behavior. One option is to keep the check in there and put
>> the &#x
From: Roopa Prabhu
A few useful tracepoints to trace bridge forwarding
database updates.
Signed-off-by: Roopa Prabhu
---
v2 - address comments from Florian
include/trace/events/bridge.h | 98 +
net/bridge/br_fdb.c |7 +++
net/core/net
On Tue, Aug 29, 2017 at 6:36 AM, Andrew Lunn wrote:
> On Mon, Aug 28, 2017 at 09:22:48PM -0700, Roopa Prabhu wrote:
>> From: Roopa Prabhu
>>
>> A few useful tracepoints to trace bridge forwarding
>> database updates.
>
> Hi Roopa
>
> Once accepted, it would
On Tue, Aug 29, 2017 at 9:46 AM, Florian Fainelli wrote:
> On 08/28/2017 09:22 PM, Roopa Prabhu wrote:
>> From: Roopa Prabhu
>>
>> A few useful tracepoints to trace bridge forwarding
>> database updates.
>>
>> Signed-off-by: Roopa Prabhu
>
> Revie
From: Roopa Prabhu
A few useful tracepoints to trace bridge forwarding
database updates.
Signed-off-by: Roopa Prabhu
---
v2: address comments from florian
v3: remove stray character '=' in print (pointed out by florian)
include/trace/events/bridg
From: Roopa Prabhu
This extends bridge fdb table tracepoints to also cover
learned fdb entries in the br_fdb_update path. Note that
unlike other tracepoints I have moved this to when the fdb
is modified because this is in the datapath and can generate
a lot of noise in the trace output
On Thu, Aug 31, 2017 at 5:38 AM, Jesper Dangaard Brouer
wrote:
> On Wed, 30 Aug 2017 22:18:13 -0700
> Roopa Prabhu wrote:
>
>> From: Roopa Prabhu
>>
>> This extends bridge fdb table tracepoints to also cover
>> learned fdb entries in the br_fdb_update path. Note
On Tue, Sep 5, 2017 at 7:07 AM, Jiri Pirko wrote:
> Tue, Sep 05, 2017 at 02:48:21PM CEST, niko...@cumulusnetworks.com wrote:
>>Hi all,
>>This RFC adds a new mode for clsact which designates a device's egress
>>classifier as global per netns. The packets that are not classified for
>>a particular d
On Tue, Sep 5, 2017 at 11:18 AM, Cong Wang wrote:
> On Tue, Sep 5, 2017 at 5:48 AM, Nikolay Aleksandrov
> wrote:
>> Hi all,
>> This RFC adds a new mode for clsact which designates a device's egress
>> classifier as global per netns. The packets that are not classified for
>> a particular device w
On Tue, Sep 5, 2017 at 3:45 PM, Daniel Borkmann wrote:
> On 09/06/2017 12:01 AM, Roopa Prabhu wrote:
>>
>> On Tue, Sep 5, 2017 at 11:18 AM, Cong Wang
>> wrote:
>>>
>>> On Tue, Sep 5, 2017 at 5:48 AM, Nikolay Aleksandrov
>>> wrote:
>>>>
On Tue, Sep 5, 2017 at 3:25 PM, Jamal Hadi Salim wrote:
> On 17-09-05 06:01 PM, Roopa Prabhu wrote:
>
>>
>> yes, like Nikolay says we have been discussing this as well. Nikolay's
>> patch is a cleaver and most importantly non-invasive
>> way today given the an
On Wed, Sep 6, 2017 at 12:24 AM, Jiri Pirko wrote:
> Wed, Sep 06, 2017 at 06:04:17AM CEST, ro...@cumulusnetworks.com wrote:
>>On Tue, Sep 5, 2017 at 3:45 PM, Daniel Borkmann wrote:
>>> On 09/06/2017 12:01 AM, Roopa Prabhu wrote:
>>>>
>>>> On Tue, Sep
On Tue, Sep 5, 2017 at 5:47 PM, Andrew Lunn wrote:
>> The third and last issue will be explained in a followup email.
>
> Hi DSA hackers
>
> So there is the third issue. It affects just DSA, but it possible
> affects all DSA drivers.
>
> This patchset broken broadcast with the Marvell drivers. It
On Fri, Sep 8, 2017 at 2:52 PM, Roman Mashak wrote:
> Signed-off-by: Roman Mashak
> ---
> bridge/link.c | 16 +---
> 1 file changed, 13 insertions(+), 3 deletions(-)
>
> diff --git a/bridge/link.c b/bridge/link.c
> index 60200f1..9e4206f 100644
> --- a/bridge/link.c
> +++ b/bridge/li
On Sat, Sep 9, 2017 at 10:23 AM, Jamal Hadi Salim wrote:
> On 17-09-09 12:24 PM, Roopa Prabhu wrote:
>>
>> On Fri, Sep 8, 2017 at 2:52 PM, Roman Mashak wrote:
>>>
>>> Signed-off-by: Roman Mashak
>>> ---
>>> bridge/link.c | 16 +++
On Sat, Sep 9, 2017 at 11:15 AM, Nikolay Aleksandrov
wrote:
> On 09/09/17 20:23, Jamal Hadi Salim wrote:
>> On 17-09-09 12:24 PM, Roopa Prabhu wrote:
>>> On Fri, Sep 8, 2017 at 2:52 PM, Roman Mashak wrote:
>>>> Signed-off-by: Roman Mashak
>>>> ---
>
On Mon, Dec 11, 2017 at 5:53 AM, Michal Kubecek wrote:
> This is still work in progress and only a very small part of the ioctl
> interface is reimplemented but I would like to get some comments before
> the patchset becomes too big and changing things becomes too tedious.
>
> The interface used f
From: Roopa Prabhu
Dissect flow in fwd path if fib rules require it. Controlled by
a flag to avoid penatly for the common case. Flag is set when fib
rules with sport, dport and proto match that require flow dissect
are installed. Also passes the dissected hash keys to the multipath
hash function
From: Roopa Prabhu
Add support to match on src port, dst port and ip protocol.
Signed-off-by: Roopa Prabhu
---
include/uapi/linux/fib_rules.h | 3 +++
net/ipv4/fib_rules.c | 46 --
2 files changed, 47 insertions(+), 2 deletions(-)
diff --git
From: Roopa Prabhu
This series extends fib rule match support to include sport, dport
and ip proto match (to complete the 5-tuple match support).
Common use-cases of Policy based routing in the data center require
5-tuple match. The last 2 patches in the series add a call to flow dissect
in the
From: Roopa Prabhu
Dissect flow in fwd path if fib rules require it. Controlled by
a flag to avoid penatly for the common case. Flag is set when fib
rules with sport, dport and proto match that require flow dissect
are installed. Also passes the dissected hash keys to the multipath
hash function
From: Roopa Prabhu
Add support to match on src port, dst port and ip protocol.
Signed-off-by: Roopa Prabhu
---
net/ipv6/fib6_rules.c | 49 ++---
1 file changed, 46 insertions(+), 3 deletions(-)
diff --git a/net/ipv6/fib6_rules.c b/net/ipv6
On Sun, Feb 11, 2018 at 11:44 PM, Ido Schimmel wrote:
> On Sun, Feb 11, 2018 at 02:26:29PM -0800, Roopa Prabhu wrote:
>> From: Roopa Prabhu
>>
>> Dissect flow in fwd path if fib rules require it. Controlled by
>> a flag to avoid penatly for the common case. Flag is
On Mon, Feb 12, 2018 at 4:03 PM, David Miller wrote:
> From: Eric Dumazet
> Date: Mon, 12 Feb 2018 13:54:59 -0800
>
>> We had project/teams using different routing tables for each vlan they
>> setup :/
>
> Indeed, people use FIB rules and think they can scale in software. As
> currently implemen
On Tue, Feb 13, 2018 at 8:34 AM, David Miller wrote:
> From: Roopa Prabhu
> Date: Tue, 13 Feb 2018 08:19:35 -0800
>
>> - Regardless of this series, I think we should optimize ip rules or
>> have a new implementation of policy based routing. happy to hear about
>
On Tue, Feb 20, 2018 at 12:33 PM, Stephen Hemminger
wrote:
> On Tue, 20 Feb 2018 13:27:21 -0700
> David Ahern wrote:
>
>> On 2/20/18 1:17 PM, Serhey Popovych wrote:
>> > Stephen Hemminger wrote:
>> >> On Tue, 20 Feb 2018 21:39:51 +0200
>> >> Serhey Popovych wrote:
>> >>
>> >>> Signed-off-by: Ser
On Tue, Feb 20, 2018 at 12:49 PM, David Ahern wrote:
> On 2/20/18 1:44 PM, Roopa Prabhu wrote:
>> On Tue, Feb 20, 2018 at 12:33 PM, Stephen Hemminger
>> wrote:
>>> On Tue, 20 Feb 2018 13:27:21 -0700
>>> David Ahern wrote:
>>>
>>>> On
From: Roopa Prabhu
before:
$ss --packet -p -m
p_raw0 0*:eth0
users:(("lldpd",pid=2240,fd=11))
after:
$ss --packet -p -m
p_raw0 0*:eth0
users:(("lldpd",pid=2240,fd=11))
On Wed, Jan 17, 2018 at 1:01 PM, Jiri Pirko wrote:
> Wed, Jan 17, 2018 at 09:48:54PM CET, dsah...@gmail.com wrote:
>>On 1/15/18 11:18 AM, Ido Schimmel wrote:
>>> diff --git a/tools/testing/selftests/forwarding/lib.sh
>>> b/tools/testing/selftests/forwarding/lib.sh
>>> index bb423371f4de..264bf0af
On Wed, Jan 17, 2018 at 2:46 PM, Roopa Prabhu wrote:
> On Wed, Jan 17, 2018 at 1:01 PM, Jiri Pirko wrote:
>> Wed, Jan 17, 2018 at 09:48:54PM CET, dsah...@gmail.com wrote:
>>>On 1/15/18 11:18 AM, Ido Schimmel wrote:
>>>> diff --git a/tools/testing/selftests/forwardin
From: Roopa Prabhu
It takes 1sec for bond link down notification to hit user-space
when all slaves of the bond go down. 1sec is too long for
protocol daemons in user-space relying on bond link notification
to failover/recover (eg: multichassis lag implementations in user-space).
Since the link
On Mon, Jan 22, 2018 at 12:13 AM, Jiri Pirko wrote:
> Mon, Jan 22, 2018 at 07:07:53AM CET, ro...@cumulusnetworks.com wrote:
>>From: Roopa Prabhu
>>
>>It takes 1sec for bond link down notification to hit user-space
>>when all slaves of the bond go down. 1sec is too lon
From: Roopa Prabhu
It takes 1sec for bond link down notification to hit user-space
when all slaves of the bond go down. 1sec is too long for
protocol daemons in user-space relying on bond notification
to recover (eg: multichassis lag implementations in user-space).
Since the link event code
On Tue, Jan 23, 2018 at 7:13 PM, David Ahern wrote:
> IPv6 allows routes to be installed when the device is not up (admin up).
> Worse, it does not mark it as LINKDOWN. IPv4 does not allow it and really
> there is no reason for IPv6 to allow it, so check the flags and deny if
> device is admin dow
ice is admin down.
>
> Signed-off-by: David Ahern
Reviewed-by: Roopa Prabhu
> ---
> v3
> - moved err=-ENETDOWN under the if check per Eric's request
> - left the up check using dev->flags for consistency with IPv4
> and that it is used more often in ipv4 and ivp6 code
On Fri, Jul 28, 2017 at 9:46 AM, Jakub Kicinski wrote:
> On Fri, 28 Jul 2017 07:53:01 -0700, Roopa Prabhu wrote:
>> On Thu, Jul 27, 2017 at 7:33 PM, Jakub Kicinski wrote:
>> > On Thu, 27 Jul 2017 16:47:25 -0700, Roopa Prabhu wrote:
>> >> From: Roopa Prabhu
>&g
On Fri, Jul 28, 2017 at 10:29 AM, Andrew Lunn wrote:
> On Fri, Jul 28, 2017 at 09:46:20AM -0700, Jakub Kicinski wrote:
>> On Fri, 28 Jul 2017 07:53:01 -0700, Roopa Prabhu wrote:
>> > On Thu, Jul 27, 2017 at 7:33 PM, Jakub Kicinski wrote:
>> > > On Thu, 27 Jul 201
On Mon, Jul 31, 2017 at 5:40 PM, Amritha Nambiar
wrote:
> The Mirred/redirect action is extended to accept a traffic
> class on the device in addition to the device's ifindex.
>
> Usage: mirred
>
> Example:
> # tc qdisc add dev eth0 ingress
>
> # tc filter add dev eth0 protocol ip parent :
From: Roopa Prabhu
Signed-off-by: Roopa Prabhu
---
net/core/lwtunnel.c | 26 +-
1 file changed, 13 insertions(+), 13 deletions(-)
diff --git a/net/core/lwtunnel.c b/net/core/lwtunnel.c
index d9cb353..8693ff8 100644
--- a/net/core/lwtunnel.c
+++ b/net/core/lwtunnel.c
On Fri, Aug 4, 2017 at 3:25 PM, Andrew Lunn wrote:
> On Fri, Aug 04, 2017 at 03:23:37PM -0700, Roopa Prabhu wrote:
>> From: Roopa Prabhu
>>
>> Signed-off-by: Roopa Prabhu
>> ---
>> net/core/lwtunnel.c | 26 +-
>> 1 file
From: Roopa Prabhu
Signed-off-by: Roopa Prabhu
---
v2 - fixed a incorrect replace
net/core/lwtunnel.c | 26 +-
1 file changed, 13 insertions(+), 13 deletions(-)
diff --git a/net/core/lwtunnel.c b/net/core/lwtunnel.c
index d9cb353..435f35f 100644
--- a/net/core
On Tue, Aug 8, 2017 at 6:15 AM, Arkadi Sharshevsky wrote:
> Drivers may require driver specific information during the init stage.
> For example, memory based shared resource which should be segmented for
> different ASIC processes, such as FDB and LPM lookups.
>
> The current mlxsw implementation
On Wed, Aug 9, 2017 at 4:43 AM, Arkadi Sharshevsky wrote:
>
>
> On 08/08/2017 07:08 PM, Roopa Prabhu wrote:
>> On Tue, Aug 8, 2017 at 6:15 AM, Arkadi Sharshevsky
>> wrote:
>>>
[snip]
>>> User Configuration
>>> --
>>> Suc
On Fri, Aug 11, 2017 at 5:34 AM, David Lamparter wrote:
> On Thu, Aug 10, 2017 at 10:28:36PM +0200, Amine Kherbouche wrote:
>> Mpls handler allows creation/deletion of mpls routes without using
>> rtnetlink. When an incoming mpls packet matches this route, the saved
>> function handler is called.
On Fri, Aug 11, 2017 at 5:55 AM, David Lamparter wrote:
> On Thu, Aug 10, 2017 at 10:28:37PM +0200, Amine Kherbouche wrote:
>> This commit introduces the support of VPLS virtual device, that allows
>> performing L2VPN multipoint to multipoint communication over MPLS PSN.
>>
>> VPLS device encap r
On Thu, Aug 10, 2017 at 2:16 PM, Girish Moodalbail
wrote:
> The kernel log is not where users expect error messages for netlink
> requests; as we have extended acks now, we can replace pr_debug() with
> NL_SET_ERR_MSG_ATTR().
>
> Signed-off-by: Matthias Schiffer
> Signed-off-by: Girish Moodalbail
On Fri, Aug 11, 2017 at 9:39 AM, Jiri Benc wrote:
> On Fri, 11 Aug 2017 09:19:34 -0700, Roopa Prabhu wrote:
>> > if (tb[IFLA_ADDRESS]) {
>> > if (nla_len(tb[IFLA_ADDRESS]) != ETH_ALEN) {
>> > - pr_debug("in
On Sat, Aug 12, 2017 at 6:40 AM, Amine Kherbouche
wrote:
>
>
> On 11/08/2017 17:14, Roopa Prabhu wrote:
>>
>> On Fri, Aug 11, 2017 at 5:55 AM, David Lamparter
>> wrote:
>>>
>>> On Thu, Aug 10, 2017 at 10:28:37PM +0200, Amine Kherbouche wrote:
>>
On Sat, Aug 12, 2017 at 6:35 AM, Amine Kherbouche
wrote:
>
>
> On 11/08/2017 16:37, Roopa Prabhu wrote:
>>
>> On Fri, Aug 11, 2017 at 5:34 AM, David Lamparter
>> wrote:
>>>
>>> On Thu, Aug 10, 2017 at 10:28:36PM +0200, Amine Kherbouche wrote:
>&
On Mon, May 8, 2017 at 5:57 PM, David Ahern wrote:
> On 5/8/17 1:11 PM, David Miller wrote:
>> From: Johannes Berg
>> Date: Mon, 08 May 2017 10:55:12 +0200
>>
>>>
+static inline bool netif_is_lwd(struct net_device *dev)
+{
+ return !!(dev->priv_flags & IFF_LWT_NETDEV);
+}
>>
.
In converting from ip_route_output_key to ip_route_output_key_hash_rcu
the xfrm_lookup_route in ip_route_output_flow is dropped since
flowi4_proto is not set for a route get request.
Signed-off-by: David Ahern
Signed-off-by: Roopa Prabhu
---
net/ipv4/route.c | 25 +++--
1
From: Roopa Prabhu
This flag when specified will return matched fib result in
response to a RTM_GETROUTE query.
Signed-off-by: Roopa Prabhu
---
include/uapi/linux/rtnetlink.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/uapi/linux/rtnetlink.h b/include/uapi/linux/rtnetlink.h
From: Roopa Prabhu
This patch adds support to return matched fib result when RTM_F_FIB_MATCH
flag is specified in RTM_GETROUTE request. This is useful for user-space
applications/controllers wanting to query a matching route.
Signed-off-by: Roopa Prabhu
---
net/ipv4/route.c | 13
From: David Ahern
Prefix is needed for returning matching route spec on get route request.
Signed-off-by: David Ahern
Signed-off-by: Roopa Prabhu
---
include/net/ip_fib.h | 1 +
net/ipv4/fib_trie.c | 1 +
2 files changed, 2 insertions(+)
diff --git a/include/net/ip_fib.h b/include/net
From: David Ahern
rt_fill_info has 1 caller with the event set to RTM_NEWROUTE. Given that
remove the arg and use RTM_NEWROUTE directly in rt_fill_info.
Signed-off-by: David Ahern
Signed-off-by: Roopa Prabhu
---
net/ipv4/route.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions
From: Roopa Prabhu
This patch adds support to return matched fib result when RTM_F_FIB_MATCH
flag is specified in RTM_GETROUTE request. This is useful for user-space
applications/controllers wanting to query a matching route.
Signed-off-by: Roopa Prabhu
---
net/ipv6/route.c | 36
From: Roopa Prabhu
This series adds a new RTM_F_FIB_MATCH flag to return matched fib result
with RTM_GETROUTE. This is useful for applications and protocols in
userspace wanting to query the selected route.
examples (with patched iproute2):
ipv4:
$ip route show
default via 192.168.0.2 dev
under control remove the leading underscores
from the name. _rcu is added to the name of the new helper indicating
it is called with the rcu read lock held.
Signed-off-by: David Ahern
Signed-off-by: Roopa Prabhu
---
include/net/route.h | 7 ++-
net/ipv4/icmp.c | 2 +-
net/ipv4/route.c
Signed-off-by: Roopa Prabhu
---
include/net/route.h | 3 +++
net/ipv4/route.c| 66 ++---
2 files changed, 40 insertions(+), 29 deletions(-)
diff --git a/include/net/route.h b/include/net/route.h
index 5a92347..8d209ad 100644
--- a/include/net
On Wed, May 24, 2017 at 6:10 PM, David Ahern wrote:
> On 5/24/17 1:33 PM, Rosen, Rami wrote:
>> Hi, Rupa /David Ahern,
>>
>> First, thanks for this patch set!
>>
>> Second, it seems to me that something might be incorrect here.
>>
>> You have these additions in this patch (1/8):
>> ...
>> +struct
On Wed, May 24, 2017 at 7:35 PM, David Ahern wrote:
> Since you have to do a v2 ...
>
> On 5/24/17 12:19 PM, Roopa Prabhu wrote:
>> @@ -3622,6 +3623,7 @@ static int inet6_rtm_getroute(struct sk_buff *in_skb,
>> struct nlmsghdr *nlh,
>> memset(&fl6
From: Roopa Prabhu
This series adds a new RTM_F_FIB_MATCH flag to return matched fib result
with RTM_GETROUTE. This is useful for applications and protocols in
userspace wanting to query the selected route.
examples (with patched iproute2):
ipv4:
$ip route show
default via 192.168.0.2 dev
control remove the leading underscores
from the name and add _rcu to the name of the new helper indicating it
is called with the rcu read lock held.
Signed-off-by: David Ahern
Signed-off-by: Roopa Prabhu
---
include/net/route.h | 9 ++---
net/ipv4/icmp.c | 2 +-
net/ipv4/route.c
Signed-off-by: Roopa Prabhu
---
include/net/route.h | 3 +++
net/ipv4/route.c| 66 ++---
2 files changed, 40 insertions(+), 29 deletions(-)
diff --git a/include/net/route.h b/include/net/route.h
index 89e4028..08e689f 100644
--- a/include/net
From: David Ahern
rt_fill_info has 1 caller with the event set to RTM_NEWROUTE. Given that
remove the arg and use RTM_NEWROUTE directly in rt_fill_info.
Signed-off-by: David Ahern
Signed-off-by: Roopa Prabhu
---
net/ipv4/route.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions
From: Roopa Prabhu
This patch adds support to return matched fib result when RTM_F_FIB_MATCH
flag is specified in RTM_GETROUTE request. This is useful for user-space
applications/controllers wanting to query a matching route.
Signed-off-by: Roopa Prabhu
---
net/ipv6/route.c | 34
From: Roopa Prabhu
This flag when specified will return matched fib result in
response to a RTM_GETROUTE query.
Signed-off-by: Roopa Prabhu
---
include/uapi/linux/rtnetlink.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/uapi/linux/rtnetlink.h b/include/uapi/linux/rtnetlink.h
From: Roopa Prabhu
This patch adds support to return matched fib result when RTM_F_FIB_MATCH
flag is specified in RTM_GETROUTE request. This is useful for user-space
applications/controllers wanting to query a matching route.
Signed-off-by: Roopa Prabhu
---
net/ipv4/route.c | 13
From: David Ahern
Prefix is needed for returning matching route spec on get route request.
Signed-off-by: David Ahern
Signed-off-by: Roopa Prabhu
---
include/net/ip_fib.h | 1 +
net/ipv4/fib_trie.c | 1 +
2 files changed, 2 insertions(+)
diff --git a/include/net/ip_fib.h b/include/net
.
In converting from ip_route_output_key to ip_route_output_key_hash_rcu
the xfrm_lookup_route in ip_route_output_flow is dropped since
flowi4_proto is not set for a route get request.
Signed-off-by: David Ahern
Signed-off-by: Roopa Prabhu
---
net/ipv4/route.c | 21 +
1 file
On Fri, May 26, 2017 at 11:18 AM, David Miller wrote:
> From: Roopa Prabhu
> Date: Thu, 25 May 2017 10:42:32 -0700
>
>> This series adds a new RTM_F_FIB_MATCH flag to return matched fib result
>> with RTM_GETROUTE. This is useful for applications and protocols in
>>
vial fix like this
> makes sense.
> Am I missing something?
Thanks for the report and analysis...this looks similar to a rarely
reproducible crash we hit on the 4.1 kernel. I am glad you have a
KASAN recipe to reproduce. Your analysis aligns with ours. I have
ported our patch to latest ne
On Sun, May 28, 2017 at 11:28 PM, Mark Bloch wrote:
> Hi Roopa,
>
> On 29/05/2017 05:50, Roopa Prabhu wrote:
>> On Sun, May 28, 2017 at 3:49 AM, Mark Bloch wrote:
[snip]
>>
>> From: Balakrishnan Raman
>>
>> Date: Sun, 28 May 2017 19:34:25 -0700
>&g
From: Roopa Prabhu
recent fixes to use WRITE_ONCE for nh_flags on link up,
accidently ended up leaving the deadflags on a nh. This patch
fixes the WRITE_ONCE to use freshly evaluated nh_flags.
Fixes: 39eb8cd17588 ("net: mpls: rt_nhn_alive and nh_flags should be accessed
using READ
On Wed, May 31, 2017 at 2:48 PM, David Ahern wrote:
> On 5/31/17 2:11 PM, John Fastabend wrote:
>>> @@ -2721,14 +2724,14 @@ static int inet_rtm_getroute(struct sk_buff
>>> *in_skb, struct nlmsghdr *nlh,
>>> skb->protocol = htons(ETH_P_IP);
>>> skb->dev= dev;
>>
From: Roopa Prabhu
recent updates to inet_rtm_getroute dropped skb_dst_set in
inet_rtm_getroute. This patch restores it because it is
needed to release the dst correctly.
Fixes: 3765d35ed8b9 ("net: ipv4: Convert inet_rtm_getroute to rcu versions of
route lookup")
Reported-by: John
ng it.
>
> We add vxlan_vs_del_dev() to match vxlan_vs_add_dev() and call
> it from vxlan_stop() to match the call from vxlan_open().
>
> Fixes: 56ef9c909b40 ("vxlan: Move socket initialization to within rtnl scope")
> Acked-by: Jiri Benc
> Tested-by: Roi Dayan
> Signed-off-by: Mark Bloch
Acked-by: Roopa Prabhu
From: Roopa Prabhu
Uses newly introduced RTM_GETROUTE flag RTM_F_FIB_MATCH
to return a matching fib route. Introduces 'fibmatch'
keyword to ip route get.
ipv4:
$ip route show
default via 192.168.0.2 dev eth0
10.0.14.0/24
nexthop via 172.16.0.3 dev dummy0 weight 1
;
> Reported-by: Gustavo A. R. Silva
> Fixes: efa5356b0d97 ("bridge: per vlan dst_metadata netlink support")
> Signed-off-by: Nikolay Aleksandrov
Acked-by: Roopa Prabhu
Thanks Nikolay.
registering and release the
> route for that case.
>
> Fixes: a1a22c12060e4 ("net: ipv6: Keep nexthop of multipath route on admin
> down")
> Reported-by: Roopa Prabhu
> Signed-off-by: David Ahern
> ---
Acked-by: Roopa Prabhu
This patch fixes the issue for me. Thanks David.
From: Roopa Prabhu
This patch fixes vxlan_snoop to not move permanent fdb entries
on learn events. This is consistent with the bridge fdb
handling of permanent entries.
Signed-off-by: Roopa Prabhu
---
drivers/net/vxlan.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a
On Sun, Jun 11, 2017 at 4:04 PM, David Miller wrote:
> From: Roopa Prabhu
> Date: Sun, 11 Jun 2017 15:51:22 -0700
>
>> From: Roopa Prabhu
>>
>> This patch fixes vxlan_snoop to not move permanent fdb entries
>> on learn events. This is consistent with the br
From: Roopa Prabhu
This patch fixes vxlan_snoop to not move permanent fdb entries
on learn events. This is consistent with the bridge fdb
handling of permanent entries.
Fixes: 26a41ae60438 ("vxlan: only migrate dynamic FDB entries")
Signed-off-by: Roopa Prabhu
---
v2 - added
er vlan dst_metadata netlink support")
> Signed-off-by: Nikolay Aleksandrov
> ---
Acked-by: Roopa Prabhu
thanks
From: Roopa Prabhu
Signed-off-by: Roopa Prabhu
---
bridge/fdb.c | 9 +
1 file changed, 9 insertions(+)
diff --git a/bridge/fdb.c b/bridge/fdb.c
index e5cebf9..081233a 100644
--- a/bridge/fdb.c
+++ b/bridge/fdb.c
@@ -204,6 +204,15 @@ int print_fdb(const struct sockaddr_nl *who, struct
From: Roopa Prabhu
This series adds the required options to iplink and bridge commands
to enable per vlan tunnel info on a bridge port provided by
netlink attributes IFLA_BRPORT_VLAN_TUNNEL (flag) and
IFLA_BRIDGE_VLAN_TUNNEL_INFO
enable vlan-tunnel mapping on a bridge port:
$ip link set dev
From: Roopa Prabhu
This patch uses kernel bridge vlan attribute
IFLA_BRIDGE_VLAN_TUNNEL_INFO to set/delete/show per vlan tunnel info.
$bridge vlan add dev vxlan0 vid 2000 tunnel_info id 2000
$bridge vlan add dev vxlan0 vid 1000-1001 tunnel_info id 2000-2001
$bridge vlan tunnelshow
portvlan
From: Roopa Prabhu
This config maps to IFLA_BRPORT_VLAN_TUNNEL bridge port netlink
flag attribute. This flag enables vlan to tunnel mapping on a bridge
port. It is off by default.
set vlan_tunnel attribute on bridge port vxlan0:
$ip link set dev vxlan0 type bridge_slave vlan_tunnel on
$ip link
From: Roopa Prabhu
This series adds the required options to iplink and bridge commands
to enable per vlan tunnel info on a bridge port provided by
netlink attributes IFLA_BRPORT_VLAN_TUNNEL (flag) and
IFLA_BRIDGE_VLAN_TUNNEL_INFO
enable vlan-tunnel mapping on a bridge port:
$ip link set dev
From: Roopa Prabhu
This config maps to IFLA_BRPORT_VLAN_TUNNEL bridge port netlink
flag attribute. This flag enables vlan to tunnel mapping on a bridge
port. It is off by default.
set vlan_tunnel attribute on bridge port vxlan0:
$ip link set dev vxlan0 type bridge_slave vlan_tunnel on
$ip link
From: Roopa Prabhu
This patch uses kernel bridge vlan attribute
IFLA_BRIDGE_VLAN_TUNNEL_INFO to set/delete/show per vlan tunnel info.
$bridge vlan add dev vxlan0 vid 2000 tunnel_info id 2000
$bridge vlan add dev vxlan0 vid 1000-1001 tunnel_info id 2000-2001
$bridge vlan tunnelshow
portvlan
On Mon, Oct 30, 2017 at 3:56 AM, Nikolay Aleksandrov
wrote:
> Add an entry for IFLA_BRPORT_NEIGH_SUPPRESS to bridge port policies.
>
> Fixes: 821f1b21cabb ("bridge: add new BR_NEIGH_SUPPRESS port flag to suppress
> arp and nd flood")
> Signed-off-by: Nikolay Aleksandrov
401 - 500 of 829 matches
Mail list logo
