Re: [PATCH] dt-bindings: net: ravb: Add support for r8a774c0 SoC

2018-12-14 Thread Simon Horman
On Thu, Dec 13, 2018 at 08:18:34PM +, Fabrizio Castro wrote: > Document RZ/G2E (R8A774C0) SoC bindings. > > Signed-off-by: Fabrizio Castro Reviewed-by: Simon Horman

Re: [PATCH] dt-bindings: can: rcar_can: Add r8a774c0 support

2018-12-15 Thread Simon Horman
On Thu, Dec 13, 2018 at 08:19:38PM +, Fabrizio Castro wrote: > Document RZ/G2E (r8a774c0) SoC specific bindings. > > Signed-off-by: Fabrizio Castro Reviewed-by: Simon Horman

Re: [PATCH/RFT net] ravb: expand rx descriptor data to accommodate hw checksum

2018-12-16 Thread Simon Horman
On Mon, Dec 10, 2018 at 07:56:14PM +0300, Sergei Shtylyov wrote: > Hello! > > On 12/10/2018 11:59 AM, Simon Horman wrote: > > > From: Simon Horman > > > > EtherAVB may provide a checksum of packet data appended to packet data. In > > order to allow this

Re: [PATCH net-next] ravb: Disable Pause Advertisement

2018-09-25 Thread Simon Horman
e the Pause and Asym Pause modes, so restoring the old behavior. > > Reported-by: Simon Horman > Fixes: 41124fa64d4b ("net: ethernet: Add helper to remove a supported link > mode") > Signed-off-by: Andrew Lunn Tested-by: Simon Horman Reviewed-by: Simon Horman

Re: [PATCH v3 net-next 07/12] net: ethernet: Add helper to remove a supported link mode

2018-09-25 Thread Simon Horman
On Fri, Sep 21, 2018 at 03:01:44PM +0200, Andrew Lunn wrote: > > Thanks Andrew, > > > > it seems that removing Aysm Pause does the trick. > > Great. > > I will submit the patch today. > > I see two possible followups: > > 1) Figure out why auto-neg does not complete when Pause is > advertised.

[PATCH iproute2-next] tc: f_flower: add geneve option match support to flower

2018-09-28 Thread Simon Horman
:80:1122334421314151/:ff: \ ip_proto udp \ action mirred egress redirect dev eth1 Signed-off-by: Pieter Jansen van Vuuren Signed-off-by: Simon Horman --- man/man8/tc-flower.8 | 13 ++- tc/f_flower.c| 282

Re: [PATCH v2 net] mpls: allow routes on ip6gre devices

2018-10-03 Thread Simon Horman
1d 1e1f 2021 2223 .!"# > 0x0080: 2425 2627 2829 2a2b 2c2d 2e2f 3031 3233 $%&'()*+,-./0123 > 0x0090: 3435 3637 4567 > ``` > > Signed-off-by: Saif Hasan This appears to be consistent with work I did to enable MPLS over SIT

Re: [ovs-dev] [PATCH net-next V2 1/1] openvswitch: Declare ovs key structures using macros

2019-02-07 Thread Simon Horman
On Mon, Feb 04, 2019 at 12:09:00PM -0800, David Miller wrote: > From: Gregory Rose > Date: Mon, 4 Feb 2019 11:41:29 -0800 > > > > > On 2/3/2019 1:12 AM, Eli Britstein wrote: > >> Declare ovs key structures using macros as a pre-step towards to > >> enable retrieving fields information, as a work

Re: [PATCH net-next 2/2] net: Change TCA_ACT_* to TCA_ID_* to match that of TCA_ID_POLICE

2019-02-08 Thread Simon Horman
On Thu, Feb 07, 2019 at 09:45:49AM +0200, Eli Cohen wrote: > Modify the kernel users of the TCA_ACT_* macros to use TCA_ID_*. For > example, use TCA_ID_GACT instead of TCA_ACT_GACT. This will align with > TCA_ID_POLICE and also differentiates these identifier, used in struct > tc_action_ops type fi

Re: [PATCH net-next] ipvs: Use struct_size() helper

2019-02-08 Thread Simon Horman
) helper: > > size = struct_size(instance, entry, count); > > This code was detected with the help of Coccinelle. > > Signed-off-by: Gustavo A. R. Silva Acked-by: Simon Horman Pablo, could you consider applying this? > --- > net/netfilter/ipvs/ip_vs_ctl.c | 6 ++

Re: [PATCH] dt-bindings: net: ravb: Add support for r8a77990 SoC

2018-05-13 Thread Simon Horman
f-by: Yoshihiro Shimoda > > I'm assuming this isn't targetted at one of my trees. Just FYI. Hi Dave, I think this is appropriate for net-next but if not I can take it. Reviewed-by: Simon Horman Shimoda-san, please use "[PATCH net-next]" for non-bugfix networking up

Re: [PATCH 2/3] sh_eth: add EDMR.NBST support

2018-05-17 Thread Simon Horman
> > Signed-off-by: Vladimir Barinov > Signed-off-by: Sergei Shtylyov Reviewed-by: Simon Horman > > --- > drivers/net/ethernet/renesas/sh_eth.c |4 > drivers/net/ethernet/renesas/sh_eth.h |2 ++ > 2 files changed, 6 insertions(+) > > Index: net-

Re: [PATCH 3/3] sh_eth: add R8A77980 support

2018-05-17 Thread Simon Horman
e) patch by Vladimir Barinov. > > Signed-off-by: Vladimir Barinov > Signed-off-by: Sergei Shtylyov Reviewed-by: Simon Horman

Re: [PATCH 1/8] dt-bindings: can: rcar_can: document r8a774[35] can support

2017-11-20 Thread Simon Horman
er change is needed. > > Signed-off-by: Fabrizio Castro > Reviewed-by: Biju Das Reviewed-by: Simon Horman

Re: [PATCH 0/8] Add CAN support to iwg2[02]d

2017-11-20 Thread Simon Horman
On Tue, Nov 07, 2017 at 03:10:41PM +, Fabrizio Castro wrote: > Hello, > > this series delivers all of the changes necessary to add CAN bus > support to the: > * iW-RainboW-G22D SODIMM, and > * iW-RainboW-G20M-Qseven-RZG1M > development platforms, including documentation, pinctrl driver, SoC >

[PATCH net-next] flow_dissector: dissect tunnel info outside __skb_flow_dissect()

2017-12-04 Thread Simon Horman
. Signed-off-by: Simon Horman Reviewed-by: Jakub Kicinski --- include/linux/skbuff.h| 5 + net/core/flow_dissector.c | 12 +--- net/sched/cls_flower.c| 1 + 3 files changed, 11 insertions(+), 7 deletions(-) diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h index

[PATCH net-next 01/10] nfp: debug dump ethtool ops

2017-12-04 Thread Simon Horman
can be specified, this is stored between ethtool invocations. Dump level 0 is still the "arm.diag" resource for backward compatibility. Other dump levels each define a set of state information to include in the dump, driven by a spec from FW. Signed-off-by: Carl Heymann Review

[PATCH net-next 00/10] nfp: enhanced debug dump via ethtool

2017-12-04 Thread Simon Horman
Add debug dump implementation to the NFP driver. This makes use of existing ethtool infrastructure. ethtool -W is used to select the dump level and ethtool -w is used to dump NFP state. The existing behaviour of dump level 0, dumping the arm.diag resource, is preserved. Dump levels greater than 0

[PATCH net-next 05/10] nfp: dump rtsyms

2017-12-04 Thread Simon Horman
From: Carl Heymann - Support rtsym TLVs. - If specified rtsym is not found, dump the spec TLV as -ENOENT error. Signed-off-by: Carl Heymann Reviewed-by: Jakub Kicinski Signed-off-by: Simon Horman --- .../net/ethernet/netronome/nfp/nfp_net_debugdump.c | 124 + 1 file

[PATCH net-next 04/10] nfp: dumpspec TLV traversal

2017-12-04 Thread Simon Horman
From: Carl Heymann - Perform dumpspec traversals for calculating size and populating the dump. - Initially, wrap all spec TLVs in dump error TLVs (changed by later patches in the series). Signed-off-by: Carl Heymann Reviewed-by: Jakub Kicinski Signed-off-by: Simon Horman --- .../net

[PATCH net-next 07/10] nfp: dump single hwinfo field by key

2017-12-04 Thread Simon Horman
Reviewed-by: Jakub Kicinski Signed-off-by: Simon Horman --- .../net/ethernet/netronome/nfp/nfp_net_debugdump.c | 57 ++ 1 file changed, 57 insertions(+) diff --git a/drivers/net/ethernet/netronome/nfp/nfp_net_debugdump.c b/drivers/net/ethernet/netronome/nfp/nfp_net_debugdump.c

[PATCH net-next 06/10] nfp: dump all hwinfo

2017-12-04 Thread Simon Horman
From: Carl Heymann - Dump hwinfo as separate TLV chunk, in a packed format containing zero-separated key and value strings. - This provides additional debug context, if requested by the dumpspec. Signed-off-by: Carl Heymann Reviewed-by: Jakub Kicinski Signed-off-by: Simon Horman

[PATCH net-next 08/10] nfp: dump firmware name

2017-12-04 Thread Simon Horman
From: Carl Heymann Dump FW name as TLV, based on dump specification. Signed-off-by: Carl Heymann Reviewed-by: Jakub Kicinski Signed-off-by: Simon Horman --- .../net/ethernet/netronome/nfp/nfp_net_debugdump.c | 36 ++ 1 file changed, 36 insertions(+) diff --git a/drivers

[PATCH net-next 03/10] nfp: dump prolog

2017-12-04 Thread Simon Horman
From: Carl Heymann - Use a TLV structure, with the typed chunks aligned to 8-byte sizes. - Dump numeric fields as big-endian. - Prolog contains the dump level. Signed-off-by: Carl Heymann Reviewed-by: Jakub Kicinski Signed-off-by: Simon Horman --- .../net/ethernet/netronome/nfp

[PATCH net-next 09/10] nfp: dump CPP, XPB and direct ME CSRs

2017-12-04 Thread Simon Horman
From: Carl Heymann - The spec defines CSR address ranges for these types. - Dump each TLV chunk in the spec as a chunk that includes the spec and the data over the defined address range. Signed-off-by: Carl Heymann Reviewed-by: Jakub Kicinski Signed-off-by: Simon Horman --- .../net

[PATCH net-next 10/10] nfp: dump indirect ME CSRs

2017-12-04 Thread Simon Horman
derived address, read it back, and then read the register value. - For each address, read and dump all 8 contexts in this manner. Signed-off-by: Carl Heymann Reviewed-by: Jakub Kicinski Signed-off-by: Simon Horman --- drivers/net/ethernet/netronome/nfp/nfp_asm.h | 10 ++ .../net/ethernet

[PATCH net-next 02/10] nfp: load debug dump spec

2017-12-04 Thread Simon Horman
From: Carl Heymann Load the TLV-based binary specification of what needs to be included in a dump, from the "_abi_dump_spec" rtsymbol. If the symbol is not defined, then dumps for levels >= 1 are not supported. Signed-off-by: Carl Heymann Reviewed-by: Jakub Kicinski Signed-

[PATCH net-net] nfp: flower: inform firmware of flower features in the driver

2020-05-13 Thread Simon Horman
: Simon Horman --- .../net/ethernet/netronome/nfp/flower/main.c | 110 +- .../net/ethernet/netronome/nfp/flower/main.h | 11 ++ 2 files changed, 91 insertions(+), 30 deletions(-) diff --git a/drivers/net/ethernet/netronome/nfp/flower/main.c b/drivers/net/ethernet/netronome/nfp

Re: [oss-drivers] [RFC v2] current devlink extension plan for NICs

2020-05-13 Thread Simon Horman
On Fri, May 01, 2020 at 11:14:49AM +0200, Jiri Pirko wrote: > Hi all. > > First, I would like to apologize for very long email. But I think it > would be beneficial to the see the whole picture, where we are going. > > Currently we are working internally on several features with > need of extensi

Re: [PATCH net-next 2/3] nfp: don't check lack of RX/TX channels

2020-05-18 Thread Simon Horman
On Fri, May 15, 2020 at 12:49:01PM -0700, Jakub Kicinski wrote: > Core will now perform this check. > > Signed-off-by: Jakub Kicinski Reviewed-by: Simon Horman > --- > drivers/net/ethernet/netronome/nfp/nfp_net_ethtool.c | 3 +-- > 1 file changed, 1 insertion(+), 2 dele

[PATCH net] nfp: flower: fix used time of merge flow statistics

2020-05-27 Thread Simon Horman
ned-off-by: Heinrich Kuhn Signed-off-by: Simon Horman --- drivers/net/ethernet/netronome/nfp/flower/offload.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/netronome/nfp/flower/offload.c b/drivers/net/ethernet/netronome/nfp/flower/offload.c index c6

[PATCH net-next] nfp: flower: fix incorrect flag assignment

2020-05-28 Thread Simon Horman
bits") Signed-off-by: Louis Peens Signed-off-by: Simon Horman --- drivers/net/ethernet/netronome/nfp/flower/main.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) This fix is for net-next as the patch that introduces this problem hasn't propagated to Linus's tre

[PATCH net-next v2 2/2] nfp: flower: inform firmware of flower features

2020-05-19 Thread Simon Horman
: Simon Horman --- .../net/ethernet/netronome/nfp/flower/main.c | 106 +- .../net/ethernet/netronome/nfp/flower/main.h | 11 ++ 2 files changed, 87 insertions(+), 30 deletions(-) diff --git a/drivers/net/ethernet/netronome/nfp/flower/main.c b/drivers/net/ethernet/netronome/nfp

[PATCH net-next v2 0/2] nfp: flower: feature bit updates

2020-05-19 Thread Simon Horman
Hi, this short series has two parts. * The first patch cleans up the treatment of existing feature bits. There are two distinct methods used and the code now reflects this more clearly. * The second patch informs firmware of flower features. This allows the firmware to disable certain featu

[PATCH net-next v2 1/2] nfp: flower: renaming of feature bits

2020-05-19 Thread Simon Horman
From: Louis Peens Clean up name aliasing. Some features gets enabled using a slightly different method, but the bitmap for these were stored in the same field. Rename their #defines and move the bitmap to a new variable. Signed-off-by: Louis Peens Signed-off-by: Simon Horman --- drivers/net

[net-next 02/11] devlink: add 'reset_dev_on_drv_probe' param

2019-09-06 Thread Simon Horman
From: Dirk van der Merwe Add the 'reset_dev_on_drv_probe' devlink parameter, controlling the device reset policy on driver probe. This parameter is useful in conjunction with the existing 'fw_load_policy' parameter. Signed-off-by: Dirk van der Merwe Signed-

[net-next 01/11] devlink: extend 'fw_load_policy' values

2019-09-06 Thread Simon Horman
From: Dirk van der Merwe Add the 'disk' value to the generic 'fw_load_policy' devlink parameter. This value indicates that firmware should always be loaded from disk only. Signed-off-by: Dirk van der Merwe Signed-off-by: Simon Horman --- Documentation/networking/de

[net-next 11/11] Documentation: nfp: add nfp driver specific notes

2019-09-06 Thread Simon Horman
/nfp-drv-kmods/blob/master/README.md Signed-off-by: Dirk van der Merwe Signed-off-by: Simon Horman --- .../networking/device_drivers/netronome/nfp.rst| 133 + 1 file changed, 133 insertions(+) create mode 100644 Documentation/networking/device_drivers/netronome/nfp.rst

[net-next 07/11] nfp: add devlink param infrastructure

2019-09-06 Thread Simon Horman
: Simon Horman --- drivers/net/ethernet/netronome/nfp/Makefile| 1 + drivers/net/ethernet/netronome/nfp/devlink_param.c | 60 ++ drivers/net/ethernet/netronome/nfp/nfp_main.h | 3 ++ drivers/net/ethernet/netronome/nfp/nfp_net_main.c | 7 +++ 4 files changed, 71

[net-next 08/11] nfp: devlink: add 'fw_load_policy' support

2019-09-06 Thread Simon Horman
From: Dirk van der Merwe Add support for the 'fw_load_policy' devlink parameter. The FW load policy is controlled by the 'app_fw_from_flash' hwinfo key. Remap the values from devlink to the hwinfo key and back. Signed-off-by: Dirk van der Merwe Signed-off-by: Simon Horman

[net-next 05/11] nfp: nsp: add support for hwinfo set operation

2019-09-06 Thread Simon Horman
From: Dirk van der Merwe Add support for the NSP HWinfo set command. This closely follows the HWinfo lookup command. Signed-off-by: Dirk van der Merwe Reviewed-by: Jakub Kicinski Signed-off-by: Simon Horman --- drivers/net/ethernet/netronome/nfp/nfpcore/nfp_nsp.c | 15

[net-next 04/11] nfp: nsp: add support for optional hwinfo lookup

2019-09-06 Thread Simon Horman
structure provides the ability to silence command errors, in which case the caller should log any command errors appropriately. Protocol errors are unaffected by this. Signed-off-by: Dirk van der Merwe Reviewed-by: Jakub Kicinski Signed-off-by: Simon Horman --- .../net/ethernet/netronome/n

[net-next 10/11] kdoc: fix nfp_fw_load documentation

2019-09-06 Thread Simon Horman
From: Dirk van der Merwe Fixed the incorrect prefix for the 'nfp_fw_load' function. Signed-off-by: Dirk van der Merwe Reviewed-by: Jakub Kicinski Signed-off-by: Simon Horman --- drivers/net/ethernet/netronome/nfp/nfp_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) di

[net-next 09/11] nfp: devlink: add 'reset_dev_on_drv_probe' support

2019-09-06 Thread Simon Horman
From: Dirk van der Merwe Add support for the 'reset_dev_on_drv_probe' devlink parameter. The reset control policy is controlled by the 'abi_drv_reset' hwinfo key. Signed-off-by: Dirk van der Merwe Signed-off-by: Simon Horman --- Documentation/networking/devlink-pa

[net-next 03/11] nfp: nsp: add support for fw_loaded command

2019-09-06 Thread Simon Horman
From: Dirk van der Merwe Add support for the simple command that indicates whether application firmware is loaded. Signed-off-by: Dirk van der Merwe Reviewed-by: Jakub Kicinski Signed-off-by: Simon Horman --- drivers/net/ethernet/netronome/nfp/nfpcore/nfp_nsp.c | 10 ++ drivers/net

[net-next 06/11] nfp: honor FW reset and loading policies

2019-09-06 Thread Simon Horman
loaded firmware. This is needed to avoid firmware being removed while in use on multi-host platforms. Signed-off-by: Dirk van der Merwe Signed-off-by: Simon Horman --- drivers/net/ethernet/netronome/nfp/nfp_main.c | 139 + drivers/net/ethernet/netronome/nfp/nfp_main.h

[net-next 00/11] nfp: implement firmware loading policy

2019-09-06 Thread Simon Horman
Hi Dave, I am handling maintenance of the nfp diver in Jakub's absence while he is on vacation this week and next, and I am sending this patchset in that capacity. Regarding the patches, Dirk says: This series adds configuration capabilities to the firmware loading policy of the NFP driver. NFP

[PATCH net] nfp: flower: cmsg rtnl locks can timeout reify messages

2019-09-06 Thread Simon Horman
(tasklet) in order to resolve timeouts caused by a blocked work queue waiting on rtnl locks. Signed-off-by: Fred Lotter Signed-off-by: Simon Horman --- drivers/net/ethernet/netronome/nfp/flower/cmsg.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) Hi Dave, I am handling

[PATCH net-next v2 07/11] nfp: add devlink param infrastructure

2019-09-08 Thread Simon Horman
: Jakub Kicinski Signed-off-by: Simon Horman --- drivers/net/ethernet/netronome/nfp/Makefile| 1 + drivers/net/ethernet/netronome/nfp/devlink_param.c | 60 ++ drivers/net/ethernet/netronome/nfp/nfp_main.h | 3 ++ drivers/net/ethernet/netronome/nfp/nfp_net_main.c

[PATCH net-next v2 06/11] nfp: honor FW reset and loading policies

2019-09-08 Thread Simon Horman
loaded firmware. This is needed to avoid firmware being removed while in use on multi-host platforms. Signed-off-by: Dirk van der Merwe Signed-off-by: Jakub Kicinski Signed-off-by: Simon Horman --- drivers/net/ethernet/netronome/nfp/nfp_main.c | 140 + drivers/net/

[PATCH net-next v2 08/11] nfp: devlink: add 'fw_load_policy' support

2019-09-08 Thread Simon Horman
inski Signed-off-by: Simon Horman --- Documentation/networking/devlink-params-nfp.txt| 2 + drivers/net/ethernet/netronome/nfp/devlink_param.c | 165 + 2 files changed, 167 insertions(+) create mode 100644 Documentation/networking/devlink-params-nfp.txt diff --git a/Docu

[PATCH net-next v2 00/11] nfp: implement firmware loading policy

2019-09-08 Thread Simon Horman
Dirk says: This series adds configuration capabilities to the firmware loading policy of the NFP driver. NFP firmware loading is controlled via three HWinfo keys which can be set per device: 'abi_drv_reset', 'abi_drv_load_ifc' and 'app_fw_from_flash'. Refer to patch #11 for more detail on how the

[PATCH net-next v2 05/11] nfp: nsp: add support for hwinfo set operation

2019-09-08 Thread Simon Horman
From: Dirk van der Merwe Add support for the NSP HWinfo set command. This closely follows the HWinfo lookup command. Signed-off-by: Dirk van der Merwe Signed-off-by: Jakub Kicinski Signed-off-by: Simon Horman --- drivers/net/ethernet/netronome/nfp/nfpcore/nfp_nsp.c | 15

[PATCH net-next v2 03/11] nfp: nsp: add support for fw_loaded command

2019-09-08 Thread Simon Horman
From: Dirk van der Merwe Add support for the simple command that indicates whether application firmware is loaded. Signed-off-by: Dirk van der Merwe Signed-off-by: Jakub Kicinski Signed-off-by: Simon Horman --- drivers/net/ethernet/netronome/nfp/nfpcore/nfp_nsp.c | 10 ++ drivers

[PATCH net-next v2 02/11] devlink: add 'reset_dev_on_drv_probe' param

2019-09-08 Thread Simon Horman
Kicinski Signed-off-by: Simon Horman --- Documentation/networking/devlink-params.txt | 14 ++ include/net/devlink.h | 5 + include/uapi/linux/devlink.h| 7 +++ net/core/devlink.c | 5 + 4 files changed, 31

[PATCH net-next v2 11/11] Documentation: nfp: add nfp driver specific notes

2019-09-08 Thread Simon Horman
/nfp-drv-kmods/blob/master/README.md Signed-off-by: Dirk van der Merwe Signed-off-by: Jakub Kicinski Signed-off-by: Simon Horman --- .../networking/device_drivers/netronome/nfp.rst| 133 + 1 file changed, 133 insertions(+) create mode 100644 Documentation/networking

[PATCH net-next v2 01/11] devlink: extend 'fw_load_policy' values

2019-09-08 Thread Simon Horman
From: Dirk van der Merwe Add the 'disk' value to the generic 'fw_load_policy' devlink parameter. This value indicates that firmware should always be loaded from disk only. Signed-off-by: Dirk van der Merwe Signed-off-by: Jakub Kicinski Signed-off-by: Simon Horman

[PATCH net-next v2 04/11] nfp: nsp: add support for optional hwinfo lookup

2019-09-08 Thread Simon Horman
structure provides the ability to silence command errors, in which case the caller should log any command errors appropriately. Protocol errors are unaffected by this. Signed-off-by: Dirk van der Merwe Signed-off-by: Jakub Kicinski Signed-off-by: Simon Horman --- .../net/ethernet/netronome/n

[PATCH net-next v2 09/11] nfp: devlink: add 'reset_dev_on_drv_probe' support

2019-09-08 Thread Simon Horman
From: Dirk van der Merwe Add support for the 'reset_dev_on_drv_probe' devlink parameter. The reset control policy is controlled by the 'abi_drv_reset' hwinfo key. Signed-off-by: Dirk van der Merwe Signed-off-by: Jakub Kicinski Signed-off-by: Simon Horman --- Documentatio

[PATCH net-next v2 10/11] kdoc: fix nfp_fw_load documentation

2019-09-08 Thread Simon Horman
From: Dirk van der Merwe Fixed the incorrect prefix for the 'nfp_fw_load' function. Signed-off-by: Dirk van der Merwe Signed-off-by: Jakub Kicinski Signed-off-by: Simon Horman --- drivers/net/ethernet/netronome/nfp/nfp_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH net-next 0/2] devlink: add unknown 'fw_load_policy' value

2019-09-11 Thread Simon Horman
Dirk says: Recently we added an unknown value for the 'reset_dev_on_drv_probe' devlink parameter. Extend the 'fw_load_policy' parameter in the same way. The only driver that uses this right now is the nfp driver. Dirk van der Merwe (2): devlink: add unknown 'fw_load_policy' value nfp: devlin

[PATCH net-next 1/2] devlink: add unknown 'fw_load_policy' value

2019-09-11 Thread Simon Horman
y useful for u8/enum parameters. Suggested-by: Jakub Kicinski Signed-off-by: Dirk van der Merwe Signed-off-by: Simon Horman --- include/uapi/linux/devlink.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/uapi/linux/devlink.h b/include/uapi/linux/devlink.h index 1da3e83f1fd4..8da5

[PATCH net-next 2/2] nfp: devlink: set unknown fw_load_policy

2019-09-11 Thread Simon Horman
From: Dirk van der Merwe If the 'app_fw_from_flash' HWinfo key is invalid, set the 'fw_load_policy' devlink parameter value to unknown. Suggested-by: Jakub Kicinski Signed-off-by: Dirk van der Merwe Signed-off-by: Simon Horman --- drivers/net/ethernet/netronome/nfp

[PATCH iproute2-next] devlink: add 'reset_dev_on_drv_probe' devlink param

2019-09-11 Thread Simon Horman
From: Dirk van der Merwe Add support for the new devlink parameter along with string to uint conversion. Signed-off-by: Dirk van der Merwe Signed-off-by: Simon Horman --- Depends on devlink.h changes present in net-next commit 5bbd21df5a07 ("devlink: add 'reset_dev_on_drv_pr

[PATCH iproute2-next] devlink: unknown 'fw_load_policy' string validation

2019-09-11 Thread Simon Horman
From: Dirk van der Merwe The 'fw_load_policy' devlink parameter now supports an unknown value. Suggested-by: Jakub Kicinski Signed-off-by: Dirk van der Merwe Signed-off-by: Simon Horman --- Sorry about these depenendencies, some related changes came through in separate patc

[PATCH net-next] nfp: read chip model from the PluDevice register

2019-09-11 Thread Simon Horman
-by: Francois H. Theron Signed-off-by: Dirk van der Merwe Signed-off-by: Simon Horman --- drivers/net/ethernet/netronome/nfp/nfpcore/nfp_cpplib.c | 16 ++-- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git a/drivers/net/ethernet/netronome/nfp/nfpcore/nfp_cpplib.c b

Re: [PATCH] ipvs: no need to update skb route entry for local destination packets.

2019-10-01 Thread Simon Horman
On Mon, Sep 30, 2019 at 09:49:38PM +0300, Julian Anastasov wrote: > > Hello, > > On Mon, 30 Sep 2019, zhang kai wrote: > > > In the end of function __ip_vs_get_out_rt/__ip_vs_get_out_rt_v6,the > > 'local' variable is always zero. > > > > Signed-off-by: zhang kai > > Looks good to

Re: [PATCH v2 0/2] ipvs: speedup ipvs netns dismantle

2019-10-01 Thread Simon Horman
On Mon, Sep 30, 2019 at 10:08:23PM +0300, Julian Anastasov wrote: > > Hello, > > On Fri, 27 Sep 2019, Haishuang Yan wrote: > > > Implement exit_batch() method to dismantle more ipvs netns > > per round. > > > > Tested: > > $ cat add_del_unshare.sh > > #!/bin/bash > > > > for i in `seq 1

Re: [ovs-dev] [PATCH 1/1] openvswitch: fix infoleak in conntrack

2020-06-16 Thread Simon Horman
On Mon, Jun 15, 2020 at 07:13:01PM -0700, Xidong Wang wrote: > From: xidongwang > > The stack object “zone_limit” has 3 members. In function > ovs_ct_limit_get_default_limit(), the member "count" is > not initialized and sent out via “nla_put_nohdr”. Hi Xidong, thanks for your patch. It appear

Re: [PATCH net v3 2/4] flow_offload: fix incorrect cb_priv check for flow_block_cb

2020-06-16 Thread Simon Horman
On Tue, Jun 16, 2020 at 11:19:38AM +0800, we...@ucloud.cn wrote: > From: wenxu > > In the function __flow_block_indr_cleanup, The match stataments > this->cb_priv == cb_priv is always false, the flow_block_cb->cb_priv > is totally different data with the flow_indr_dev->cb_priv. > > Store the rep

Re: [PATCH net v3 2/4] flow_offload: fix incorrect cb_priv check for flow_block_cb

2020-06-16 Thread Simon Horman
On Tue, Jun 16, 2020 at 10:20:46PM +0800, wenxu wrote: > > 在 2020/6/16 18:51, Simon Horman 写道: > > On Tue, Jun 16, 2020 at 11:19:38AM +0800, we...@ucloud.cn wrote: > >> From: wenxu > >> > >> In the function __flow_block_indr_cleanup, The match stataments

Re: [PATCH net v3 1/4] flow_offload: fix incorrect cleanup for flowtable indirect flow_blocks

2020-06-16 Thread Simon Horman
removed, > then identify the indirect flow_blocks that need to be removed by > the release callback. > > Fixes: 1fac52da5942 ("net: flow_offload: consolidate indirect flow_block > infrastructure") > Signed-off-by: wenxu Reviewed-by: Simon Horman

Re: [PATCH net v3 2/4] flow_offload: fix incorrect cb_priv check for flow_block_cb

2020-06-16 Thread Simon Horman
On Tue, Jun 16, 2020 at 11:18:16PM +0800, wenxu wrote: > > 在 2020/6/16 22:34, Simon Horman 写道: > > On Tue, Jun 16, 2020 at 10:20:46PM +0800, wenxu wrote: > >> 在 2020/6/16 18:51, Simon Horman 写道: > >>> On Tue, Jun 16, 2020 at 11:19:38AM +0800, we...@uc

Re: [PATCH net v4 0/4] several fixes for indirect flow_blocks offload

2020-06-18 Thread Simon Horman
PP which lead the warning > demesg log. > The block->nooffloaddevcnt should always count for indr block. > even the indr block offload successful. The representor maybe > gone away and the ingress qdisc can work in software mode. Thanks Wenxu, Pablo's minor comment wrt patch #1 not withstanding this series is now looking good to me. With that fixed feel free to add: Reviewed-by: Simon Horman

Re: [PATCH iproute2] tc: m_tunnel_key: fix geneve opt output

2020-06-18 Thread Simon Horman
On Thu, Jun 18, 2020 at 06:44:20PM +0800, Hangbin Liu wrote: > Commit f72c3ad00f3b changed the geneve option output from "geneve_opt" > to "geneve_opts", which may break the program compatibility. Reset > it back to geneve_opt. > > Fixes: f72c3ad00f3b ("tc: m_tunnel_key: add options support for vx

Re: [PATCH iproute2] tc: m_tunnel_key: fix geneve opt output

2020-06-18 Thread Simon Horman
On Fri, Jun 19, 2020 at 10:25:24AM +0800, Hangbin Liu wrote: > On Thu, Jun 18, 2020 at 12:51:08PM +0200, Simon Horman wrote: > > On Thu, Jun 18, 2020 at 06:44:20PM +0800, Hangbin Liu wrote: > > > Commit f72c3ad00f3b changed the geneve option output from "geneve_opt" &

Re: [PATCHv2 net] tc-testing: update geneve options match in tunnel_key unit tests

2020-06-18 Thread Simon Horman
th old and new > iproute2, let's accept both "geneve_opt" and "geneve_opts". > > Suggested-by: Davide Caratti > Signed-off-by: Hangbin Liu Reviewed-by: Simon Horman

Re: [v2,net-next] net: qos offload add flow status with dropped count

2020-06-19 Thread Simon Horman
| 3 ++- > 25 files changed, 60 insertions(+), 50 deletions(-) Netronome portion: Reviewed-by: Simon Horman

Re: [PATCH net v5 0/4] several fixes for indirect flow_blocks offload

2020-06-19 Thread Simon Horman
r block offload successful. The representor maybe > gone away and the ingress qdisc can work in software mode. > > > wenxu (4): > flow_offload: add flow_indr_block_cb_alloc/remove function > flow_offload: use flow_indr_block_cb_alloc/remove function > net: flow_offload: fix flow_indr_dev_unregister path > net/sched: cls_api: fix nooffloaddevcnt warning dmesg log Reviewed-by: Simon Horman

Re: [PATCH net v5 0/4] several fixes for indirect flow_blocks offload

2020-06-22 Thread Simon Horman
On Fri, Jun 19, 2020 at 08:13:42PM -0700, David Miller wrote: > From: we...@ucloud.cn > Date: Thu, 18 Jun 2020 20:49:07 +0800 > > > From: wenxu > > > > v2: > > patch2: store the cb_priv of representor to the flow_block_cb->indr.cb_priv > > in the driver. And make the correct check with the statm

[PATCH net-next 1/6] nfp: flower: set ip tunnel ttl from encap action

2018-08-07 Thread Simon Horman
From: John Hurley The TTL for encapsulating headers in IPv4 UDP tunnels is taken from a route lookup. Modify this to first check if a user has specified a TTL to be used in the TC action. Signed-off-by: John Hurley Reviewed-by: Jakub Kicinski Signed-off-by: Simon Horman --- drivers/net

[PATCH net-next 0/6] nfp: flower: tunnel TTL & TOS, and Geneve options set & match support

2018-08-07 Thread Simon Horman
nel ttl from encap action nfp: flower: allow matching on ipv4 UDP tunnel tos and ttl Pieter Jansen van Vuuren (3): net/sched: allow flower to match tunnel options nfp: flower: add geneve option push action offload nfp: flower: add geneve option match offload Simon Horman (1): flow_diss

[PATCH net-next 3/6] flow_dissector: allow dissection of tunnel options from metadata

2018-08-07 Thread Simon Horman
ntly only the Flower classifier makes that call. So there should be no impact on other users of the flow dissector. This is in preparation for allowing the flower classifier to match on Geneve options. Signed-off-by: Simon Horman Signed-off-by: Pieter Jansen van Vuuren Reviewed-by: Jakub Kicins

[PATCH net-next 6/6] nfp: flower: add geneve option match offload

2018-08-07 Thread Simon Horman
From: Pieter Jansen van Vuuren Introduce a new layer for matching on geneve options. This allows offloading filters configured to match geneve with options. Signed-off-by: Pieter Jansen van Vuuren Signed-off-by: Simon Horman --- drivers/net/ethernet/netronome/nfp/flower/cmsg.h | 6

[PATCH net-next 5/6] nfp: flower: add geneve option push action offload

2018-08-07 Thread Simon Horman
From: Pieter Jansen van Vuuren Introduce new push geneve option action. This allows offloading filters configured to entunnel geneve with options. Signed-off-by: Pieter Jansen van Vuuren Reviewed-by: Jakub Kicinski Signed-off-by: Simon Horman --- drivers/net/ethernet/netronome/nfp/flower

[PATCH net-next 2/6] nfp: flower: allow matching on ipv4 UDP tunnel tos and ttl

2018-08-07 Thread Simon Horman
From: John Hurley The addition of FLOW_DISSECTOR_KEY_ENC_IP to TC flower means that the ToS and TTL of the tunnel header can now be matched on. Extend the NFP tunnel match function to include these new fields. Signed-off-by: John Hurley Reviewed-by: Jakub Kicinski Signed-off-by: Simon Horman

[PATCH net-next 4/6] net/sched: allow flower to match tunnel options

2018-08-07 Thread Simon Horman
. And be done in a way that drivers that facilitate offload of the Flower classifier can reject or accept such flows based on hardware datapath capabilities. This approach was discussed and agreed on at Netconf 2018 in Seoul. Signed-off-by: Simon Horman Signed-off-by: Pieter Jansen van Vuuren

[net-next 0/7] nfp: ethtool and related improvements

2017-11-04 Thread Simon Horman
Dirk van der Merwe says: This patch series throws a couple of loosely related items into a single series. Patch 1: Clang compilation fix reported by Matthias Kaehlcke Patch 2: Driver can now do MAC reinit on load when there has been a media override set in the NSP. Patch 3: Refactor the nf

[net-next 1/7] nfp: don't depend on compiler constant propagation

2017-11-04 Thread Simon Horman
he mask and shift and pass those to nfp_eth_set_bit_config() separately. Reported-by: Matthias Kaehlcke Signed-off-by: Jakub Kicinski Tested-by: Dirk van der Merwe Signed-off-by: Simon Horman --- .../ethernet/netronome/nfp/nfpcore/nfp_nsp_eth.c | 23 ++ 1 file changed, 15 insertio

[net-next 7/7] nfp: implement ethtool FEC mode settings

2017-11-04 Thread Simon Horman
From: Dirk van der Merwe Add support in the driver ethtool ops to modify the NFP FEC modes. The FEC modes can be set for vNIC associated with physical ports or for MAC representor netdevs. Signed-off-by: Dirk van der Merwe Signed-off-by: Simon Horman --- .../net/ethernet/netronome/nfp

[net-next 4/7] nfp: resync repr state when port table sync

2017-11-04 Thread Simon Horman
accessor function for reprs returns NULL when it cannot access a repr. Signed-off-by: Dirk van der Merwe Signed-off-by: Simon Horman --- drivers/net/ethernet/netronome/nfp/nfp_net_main.c | 6 +++ drivers/net/ethernet/netronome/nfp/nfp_net_repr.c | 47 +++ drivers/net

[net-next 5/7] nfp: add get/set link settings ndos to representors

2017-11-04 Thread Simon Horman
. Signed-off-by: Dirk van der Merwe Signed-off-by: Simon Horman --- drivers/net/ethernet/netronome/nfp/nfp_net_ethtool.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ethernet/netronome/nfp/nfp_net_ethtool.c b/drivers/net/ethernet/netronome/nfp/nfp_net_ethtool.c index 0061097c271e

[net-next 6/7] nfp: add helpers for FEC support

2017-11-04 Thread Simon Horman
From: Dirk van der Merwe Implement helpers to determine and modify FEC modes via the NSP. The NSP advertises FEC capabilities on a per port basis and provides support for: * Auto mode selection * Reed Solomon * BaseR * None/Off Signed-off-by: Dirk van der Merwe Signed-off-by: Simon Horman

[net-next 2/7] nfp: make use of MAC reinit

2017-11-04 Thread Simon Horman
time (not only the ones which have been reconfigured, and thus potentially causing disruption to unrelated netdevs) therefore for now changing MAC config without reloading the driver still remains future work. Signed-off-by: Jakub Kicinski Tested-by: Dirk van der Merwe Signed-off-by: Simon

[net-next 3/7] nfp: refactor nfp_app_reprs_set

2017-11-04 Thread Simon Horman
case where reprs exist and need to be replaced. Signed-off-by: Dirk van der Merwe Signed-off-by: Simon Horman --- drivers/net/ethernet/netronome/nfp/flower/main.c | 16 drivers/net/ethernet/netronome/nfp/nfp_app.c | 6 -- 2 files changed, 4 insertions(+), 18 deletions

Re: [patch net-next 1/9] net_sch: red: Add offload ability to RED qdisc

2017-11-06 Thread Simon Horman
7;t require any RED function to be called. > > Signed-off-by: Nogah Frankel > Signed-off-by: Jiri Pirko Reviewed-by: Simon Horman

Re: [patch net-next 2/9] net_sch: mqprio: Change TC_SETUP_MQPRIO to TC_SETUP_QDISC_MQPRIO

2017-11-06 Thread Simon Horman
On Mon, Nov 06, 2017 at 07:23:42AM +0100, Jiri Pirko wrote: > From: Nogah Frankel > > Change TC_SETUP_MQPRIO to TC_SETUP_QDISC_MQPRIO to match the new > convention. > > Signed-off-by: Nogah Frankel > Signed-off-by: Jiri Pirko Reviewed-by: Simon Horman

Re: [patch net-next 3/9] net_sch: cbs: Change TC_SETUP_CBS to TC_SETUP_QDISC_CBS

2017-11-06 Thread Simon Horman
On Mon, Nov 06, 2017 at 07:23:43AM +0100, Jiri Pirko wrote: > From: Nogah Frankel > > Change TC_SETUP_CBS to TC_SETUP_QDISC_CBS to match the new convention.. > > Signed-off-by: Nogah Frankel > Signed-off-by: Jiri Pirko Reviewed-by: Simon Horman

Re: [PATCH v2] netfilter: mark expected switch fall-throughs

2017-11-13 Thread Simon Horman
115120 > Addresses-Coverity-ID: 115121 > Signed-off-by: Gustavo A. R. Silva Signed-off-by: Simon Horman Pablo, could you take this one directly?

[PATCH net-next 01/12] net: store port/representator id in metadata_dst

2017-06-19 Thread Simon Horman
ff-by: Sridhar Samudrala Signed-off-by: Simon Horman --- include/net/dst_metadata.h | 41 - net/core/dst.c | 15 ++- net/core/filter.c | 1 + net/ipv4/ip_tunnel_core.c | 6 -- net/openvswitch/flow_netlink.c

<    1   2   3   4   5   6   7   8   9   10   >