[PATCH/RFC net-next 2/2] net/sched: allow flower to match tunnel options

2017-09-12 Thread Simon Horman
4789 \ id 11 \ opts 0102800100800022 \ action mirred egress redirect dev geneve0 Signed-off-by: Simon Horman <simon.hor...@netronome.com> Reviewed-by: Jakub Kicinski <jakub.kicin...@netronome.com> --- include/net/flow_dissector.h | 13 + includ

[PATCH/RFC net-next 1/2] net/sched: add tunnel option support to act_tunnel_key

2017-09-12 Thread Simon Horman
-by: Simon Horman <simon.hor...@netronome.com> Reviewed-by: Jakub Kicinski <jakub.kicin...@netronome.com> --- include/uapi/linux/tc_act/tc_tunnel_key.h | 1 + net/sched/act_tunnel_key.c| 26 +- 2 files changed, 22 insertions(+), 5 deletions(-)

[PATCH net-next 1/7] nfp: add helper to get flower cmsg length

2017-09-25 Thread Simon Horman
From: John Hurley <john.hur...@netronome.com> Add a helper function that returns the length of the cmsg data when given the cmsg skb Signed-off-by: John Hurley <john.hur...@netronome.com> Signed-off-by: Simon Horman <simon.hor...@netronome.com> --- drivers/net/ethernet/ne

[PATCH net-next 0/7] nfp: flower vxlan tunnel offload

2017-09-25 Thread Simon Horman
From: Simon Horman <simon.hor...@netronome.com> John says: This patch set allows offloading of TC flower match and set tunnel fields to the NFP. The initial focus is on VXLAN traffic. Due to the current state of the NFP firmware, only VXLAN traffic on well known port 4789 is handled. The

[PATCH net-next 5/7] nfp: offload vxlan IPv4 endpoints of flower rules

2017-09-25 Thread Simon Horman
d only be aware of tunnel end points that are currently used by rules on the device Signed-off-by: John Hurley <john.hur...@netronome.com> Reviewed-by: Simon Horman <simon.hor...@netronome.com> Signed-off-by: Simon Horman <simon.hor...@netronome.com> --- drivers/net/ethernet/netronome/n

[PATCH net-next 7/7] nfp: flower vxlan neighbour keep-alive

2017-09-25 Thread Simon Horman
rather signals an ARP to verify the connection. From an NFP perspective, packets will not fall back mid-flow unless the link is verified to be down. Signed-off-by: John Hurley <john.hur...@netronome.com> Reviewed-by: Simon Horman <simon.hor...@netronome.com> Signed-off-by: Simon

[PATCH net-next 2/7] nfp: compile flower vxlan tunnel metadata match fields

2017-09-25 Thread Simon Horman
From: John Hurley <john.hur...@netronome.com> Compile ovs-tc flower vxlan metadata match fields for offloading. Only support offload of tunnel data when the VXLAN port specifically matches well known port 4789. Signed-off-by: John Hurley <john.hur...@netronome.com> Signed-off-by:

[PATCH net-next 6/7] nfp: flower vxlan neighbour offload

2017-09-25 Thread Simon Horman
hanges and update NFP with relevant information. Overwrite routes with zero values on the NFP when they expire. Signed-off-by: John Hurley <john.hur...@netronome.com> Reviewed-by: Simon Horman <simon.hor...@netronome.com> Signed-off-by: Simon Horman <simon.hor...@netronome.com> -

[PATCH net-next 3/7] nfp: compile flower vxlan tunnel set actions

2017-09-25 Thread Simon Horman
From: John Hurley <john.hur...@netronome.com> Compile set tunnel actions for tc flower. Only support VXLAN and ensure a tunnel destination port of 4789 is used. Signed-off-by: John Hurley <john.hur...@netronome.com> Signed-off-by: Simon Horman <simon.hor...@netronome.com>

[PATCH net-next 4/7] nfp: offload flower vxlan endpoint MAC addresses

2017-09-25 Thread Simon Horman
netdev, any changes are implemented by overwriting the index on NFP. Signed-off-by: John Hurley <john.hur...@netronome.com> Signed-off-by: Simon Horman <simon.hor...@netronome.com> --- drivers/net/ethernet/netronome/nfp/Makefile| 3 +- drivers/net/ethernet/netronome/nfp/flo

Re: [Patch net-next] net_sched: use idr to allocate u32 filter handles

2017-09-29 Thread Simon Horman
On Thu, Sep 28, 2017 at 03:19:05PM -0700, Cong Wang wrote: > On Thu, Sep 28, 2017 at 12:34 AM, Simon Horman > <simon.hor...@netronome.com> wrote: > > Hi Cong, > > > > this looks like a nice enhancement to me. Did you measure any performance > > benefit fro

[PATCH net-next 2/2] flow_dissector: dissect tunnel info

2017-10-02 Thread Simon Horman
Move dissection of tunnel info from the flower classifier to the flow dissector where all other dissection occurs. This should not have any behavioural affect on other users of the flow dissector. Signed-off-by: Simon Horman <simon.hor...@netronome.com> Reviewed-by: Jakub Kicinski <ja

[PATCH net-next 0/2] flow_dissector: dissect tunnel info

2017-10-02 Thread Simon Horman
Move dissection of tunnel info from the flower classifier to the flow dissector where all other dissection occurs. This should not have any behavioural affect on other users of the flow dissector. Simon Horman (2): net/dst: Make skb parameter of skb{metadata_dst,tunnel_info}() const

[PATCH net-next 1/2] net/dst: Make skb parameter of skb{metadata_dst,tunnel_info}() const

2017-10-02 Thread Simon Horman
Make the skb parameter of skb_metadata_dst() and skb_tunnel_info() const as they are not modified. This is in preparation for using them in call-sites where skb is const. Signed-off-by: Simon Horman <simon.hor...@netronome.com> Reviewed-by: Jakub Kicinski <jakub.kicin...@netr

Re: [PATCH v2 net-next 0/2] net/sched: support tunnel options in cls_flower and act_tunnel_key

2017-10-02 Thread Simon Horman
On Fri, Sep 29, 2017 at 05:54:23AM +0100, David Miller wrote: > From: Simon Horman <simon.hor...@netronome.com> > Date: Wed, 27 Sep 2017 10:16:32 +0200 > > > Users of options: > > > > * There are eBPF hooks to allow getting on and setting tunnel metad

Re: [PATCH/RFC net-next] ravb: RX checksum offload

2017-09-28 Thread Simon Horman
On Wed, Sep 13, 2017 at 08:54:00PM +0300, Sergei Shtylyov wrote: > Hello! > > On 09/12/2017 04:04 PM, Simon Horman wrote: > > >Add support for RX checksum offload. This is enabled by default and > >may be disabled and re-enabled using ethtool: > > > > # etht

Re: [PATCH net-next 2/2] flow_dissector: dissect tunnel info

2017-10-03 Thread Simon Horman
On Mon, Oct 02, 2017 at 01:37:55PM -0700, Tom Herbert wrote: > On Mon, Oct 2, 2017 at 1:41 AM, Simon Horman <simon.hor...@netronome.com> > wrote: > > Move dissection of tunnel info from the flower classifier to the flow > > dissector where all other dissection occurs.

Re: [PATCH net-next 0/7] nfp: flower vxlan tunnel offload

2017-09-25 Thread Simon Horman
On Mon, Sep 25, 2017 at 06:25:03PM +0300, Or Gerlitz wrote: > On Mon, Sep 25, 2017 at 1:23 PM, Simon Horman > <simon.hor...@netronome.com> wrote: > > From: Simon Horman <simon.hor...@netronome.com> > > > > John says: > > > > This patch set allows off

Re: RFC iproute2 doc files

2017-09-28 Thread Simon Horman
On Wed, Sep 20, 2017 at 08:11:59AM -0700, Stephen Hemminger wrote: > I noticed that the iproute man pages are up to date but the LaTex > documentation > is very out of date. Rarely updated since the Linux 2.2 days. > > Either someone needs to do a massive editing job on them, or they should just

Re: [Patch net-next] net_sched: use idr to allocate u32 filter handles

2017-09-28 Thread Simon Horman
On Thu, Sep 21, 2017 at 04:43:02PM -0700, Cong Wang wrote: > Cc: Chris Mi > Cc: Jamal Hadi Salim > Signed-off-by: Cong Wang Hi Cong, this looks like a nice enhancement to me. Did you measure any performance benefit from it.

Re: [PATCH v2 0/5] ARM: dts: rcar-gen2: Convert to new CPG/MSSR bindings

2017-08-21 Thread Simon Horman
On Fri, Aug 18, 2017 at 11:11:33AM +0200, Geert Uytterhoeven wrote: > Hi Simon, Magnus, > > Currently Renesas R-Car Gen2 SoCs use the common clk-rcar-gen2, > clk-mstp, and clk-div6 drivers, which depend on most clocks being > described in DT. Especially the module (MSTP) clocks are

Re: [patch net-next 2/3] net/sched: Change cls_flower to use IDR

2017-08-28 Thread Simon Horman
On Mon, Aug 28, 2017 at 02:41:16AM -0400, Chris Mi wrote: > Currently, all filters with the same priority are linked in a doubly > linked list. Every filter should have a unique handle. To make the > handle unique, we need to iterate the list every time to see if the > handle exists or not when

Re: [PATCH net 0/2] netfilter: ipvs: some fixes in sctp_conn_schedule

2017-08-31 Thread Simon Horman
for Julian and Simon to tell me what I should do with this. Hi Pablo, could you take these directly with Julian's Ack and the following? Signed-off-by: Simon Horman <ho...@verge.net.au>

Re: [PATCH net-next 2/2] flow_dissector: Add limits for encapsulation and EH

2017-09-01 Thread Simon Horman
On Thu, Aug 31, 2017 at 03:22:39PM -0700, Tom Herbert wrote: > In flow dissector there are no limits to the number of nested > encapsulations that might be dissected which makes for a nice DOS > attack. This patch limits for dissecting nested encapsulations > as well as for dissecting over

Re: [PATCH net-next 1/2] flow_dissector: Cleanup control flow

2017-09-01 Thread Simon Horman
Hi Tom, On Thu, Aug 31, 2017 at 03:22:38PM -0700, Tom Herbert wrote: > __skb_flow_dissect is riddled with gotos that make discerning the flow, > debugging, and extending the capability difficult. This patch > reorganizes things so that we only perform goto's after the two main > switch statements

[PATCH iproute2/master] tc actions: store and dump correct length of user cookies

2017-09-05 Thread Simon Horman
, overlimits 0 requeues 0) backlog 0b 0p requeues 0 cookie len 16 0123456789abcdef0123456789abcdef Fixes: fd8b3d2c1b9b ("actions: Add support for user cookies") Cc: Jamal Hadi Salim <j...@mojatatu.com> Signed-off-by: Simon Horman <simon.hor...@netronome.com> --- tc/

Re: [PATCH 13/14] netfilter/ipvs: Use %pS printk format for direct addresses

2017-10-08 Thread Simon Horman
parisc64 > architectures. > > Signed-off-by: Helge Deller <del...@gmx.de> > Cc: Wensong Zhang <wens...@linux-vs.org> > Cc: netdev@vger.kernel.org > Cc: lvs-de...@vger.kernel.org > Cc: netfilter-de...@vger.kernel.org Sorry for the delay in processing this. Acked-by

Re: [PATCH net-next 2/2] flow_dissector: dissect tunnel info

2017-10-04 Thread Simon Horman
ote: > >>>On Tue, Oct 03, 2017 at 11:17:46AM -0700, Tom Herbert wrote: > >>>> On Tue, Oct 3, 2017 at 2:40 AM, Simon Horman > >>>> <simon.hor...@netronome.com> wrote: > >>>> > On Mon, Oct 02, 2017 at 01:37:55PM -0700, Tom H

Re: [PATCH net-next 0/7] nfp: flower vxlan tunnel offload

2017-09-27 Thread Simon Horman
On Tue, Sep 26, 2017 at 09:29:03PM -0700, David Miller wrote: > From: Simon Horman <simon.hor...@netronome.com> > Date: Mon, 25 Sep 2017 12:23:34 +0200 > > > From: Simon Horman <simon.hor...@netronome.com> > > > > John says: > > > > This pat

[PATCH v2 net-next 0/2] net/sched: support tunnel options in cls_flower and act_tunnel_key

2017-09-27 Thread Simon Horman
: * Drop RFC prefix * Correct changelogs and enhance cover letter. Simon Horman (2): net/sched: add tunnel option support to act_tunnel_key net/sched: allow flower to match tunnel options include/net/flow_dissector.h | 13 include/uapi/linux/pkt_cls.h | 3

[PATCH v2 net-next 1/2] net/sched: add tunnel option support to act_tunnel_key

2017-09-27 Thread Simon Horman
egress redirect dev geneve0 Signed-off-by: Simon Horman <simon.hor...@netronome.com> Reviewed-by: Jakub Kicinski <jakub.kicin...@netronome.com> --- v2 * Correct example which was incorrectly described matching rather than setting tunnel options --- include/uapi/linux/tc_act/tc_tunne

[PATCH v2 net-next 2/2] net/sched: allow flower to match tunnel options

2017-09-27 Thread Simon Horman
eth1 Signed-off-by: Simon Horman <simon.hor...@netronome.com> Reviewed-by: Jakub Kicinski <jakub.kicin...@netronome.com> --- v2 * Correct example which was incorrectly described setting rather than matching tunnel options --- include/net/flow_dissector.h | 13 + includ

Re: [PATCH v2 net-next 2/2] net/sched: allow flower to match tunnel options

2017-09-27 Thread Simon Horman
l ip parent : \ > > flower \ > > enc_src_ip 10.0.99.192 \ > > enc_dst_ip 10.0.99.193 \ > > enc_key_id 11 \ > > enc_opts 0102800100800020/fff0 \ > > ip_proto udp \ > > action mirred egress redirect dev e

Re: [PATCH v2 net-next 2/2] net/sched: allow flower to match tunnel options

2017-09-27 Thread Simon Horman
> flower \ > >> > enc_src_ip 10.0.99.192 \ > >> > enc_dst_ip 10.0.99.193 \ > >> > enc_key_id 11 \ > >> > enc_opts 0102800100800020/fff0 \ > >> > ip_proto udp \ > >> > action mirred egress

Re: [PATCH v2 net-next 2/2] net/sched: allow flower to match tunnel options

2017-09-27 Thread Simon Horman
On Wed, Sep 27, 2017 at 01:08:22PM +0200, Jiri Pirko wrote: > Wed, Sep 27, 2017 at 11:27:33AM CEST, simon.hor...@netronome.com wrote: > >On Wed, Sep 27, 2017 at 11:10:05AM +0200, Jiri Pirko wrote: > >> Wed, Sep 27, 2017 at 10:16:34AM CEST, simon.hor...@netronome.com wrote: ... > >> > enum

Re: [PATCH v2 net-next 2/2] net/sched: allow flower to match tunnel options

2017-09-27 Thread Simon Horman
On Wed, Sep 27, 2017 at 02:56:03PM +0200, Jiri Pirko wrote: > Wed, Sep 27, 2017 at 02:52:06PM CEST, simon.hor...@netronome.com wrote: > >On Wed, Sep 27, 2017 at 01:08:22PM +0200, Jiri Pirko wrote: > >> Wed, Sep 27, 2017 at 11:27:33AM CEST, simon.hor...@netronome.com wrote: > >> >On Wed, Sep 27,

Re: [PATCH v2 net-next 2/2] net/sched: allow flower to match tunnel options

2017-09-27 Thread Simon Horman
On Wed, Sep 27, 2017 at 03:47:50PM +0200, Jiri Pirko wrote: > Wed, Sep 27, 2017 at 03:37:33PM CEST, simon.hor...@netronome.com wrote: > >On Wed, Sep 27, 2017 at 02:56:03PM +0200, Jiri Pirko wrote: > >> Wed, Sep 27, 2017 at 02:52:06PM CEST, simon.hor...@netronome.com wrote: > >> >On Wed, Sep 27,

Re: [PATCH v2 net-next 2/2] net/sched: allow flower to match tunnel options

2017-09-27 Thread Simon Horman
On Wed, Sep 27, 2017 at 04:00:11PM +0200, Jiri Pirko wrote: > Wed, Sep 27, 2017 at 03:50:44PM CEST, simon.hor...@netronome.com wrote: > >On Wed, Sep 27, 2017 at 03:47:50PM +0200, Jiri Pirko wrote: > >> Wed, Sep 27, 2017 at 03:37:33PM CEST, simon.hor...@netronome.com wrote: > >> >On Wed, Sep 27,

Re: [PATCH net-next 0/7] nfp: extend match and action for flower offload

2017-10-09 Thread Simon Horman
On Fri, Oct 06, 2017 at 08:34:59AM -0700, Tom Herbert wrote: > Simon, > > Maybe a bit off topic, but I had the impression netronome would > support BPF so that filters could be programmed for arbitrary > protocols and fields. Is that true? If so, what is the relationship > between that

[PATCH net-next v2 1/3] dt-bindings: net: sh_eth: add R-Car Gen[12] fallback compatibility strings

2017-10-18 Thread Simon Horman
is to name common code, compatibility strings and so on after R-Car Gen2. Signed-off-by: Simon Horman <horms+rene...@verge.net.au> Reviewed-by: Geert Uytterhoeven <geert+rene...@glider.be> Reviewed-by: Sergei Shtylyov <sergei.shtyl...@cogentembedded.com> --- v2 * Corrected typos in cha

[PATCH net-next v2 3/3] net: sh_eth: implement R-Car Gen[12] fallback compatibility strings

2017-10-18 Thread Simon Horman
is to name common code, compatibility strings and so on after R-Car Gen2. Signed-off-by: Simon Horman <horms+rene...@verge.net.au> Reviewed-by: Geert Uytterhoeven <geert+rene...@glider.be> Acked-by: Sergei Shtylyov <sergei.shtyl...@cogentembedded.com> --- v2 * Corrected

[PATCH net-next v2 0/3] net: sh_eth: add R-Car Gen[12] fallback compatibility strings

2017-10-18 Thread Simon Horman
of description of bindings usage Simon Horman (3): dt-bindings: net: sh_eth: add R-Car Gen[12] fallback compatibility strings net: sh_eth: rename name structures as rcar_gen[12]_* net: sh_eth: implement R-Car Gen[12] fallback compatibility strings Documentation/devicetree/bindings/net

[PATCH net-next v2 2/3] net: sh_eth: rename name structures as rcar_gen[12]_*

2017-10-18 Thread Simon Horman
no run-time effect and is compile-tested only. Signed-off-by: Simon Horman <horms+rene...@verge.net.au> Reviewed-by: Geert Uytterhoeven <geert+rene...@glider.be> Acked-by: Sergei Shtylyov <sergei.shtyl...@cogentembedded.com> --- v2 * Updated changelog * Collected review tag

Re: [PATCH net-next 0/3] net: sh_eth: add R-Car Gen[12] fallback compatibility strings

2017-10-18 Thread Simon Horman
On Tue, Oct 17, 2017 at 09:47:44AM +0200, Simon Horman wrote: > Add fallback compatibility strings for R-Car Gen 1 and 2. > > In the case of Renesas R-Car hardware we know that there are generations of > SoCs, f.e. Gen 1 and 2. But beyond that its not clear what the relationship

Re: [PATCH v2] netfilter: mark expected switch fall-throughs

2017-11-13 Thread Simon Horman
115120 > Addresses-Coverity-ID: 115121 > Signed-off-by: Gustavo A. R. Silva <garsi...@embeddedor.com> Signed-off-by: Simon Horman <ho...@verge.net.au> Pablo, could you take this one directly?

[PATCH net-next 08/10] nfp: dump firmware name

2017-12-04 Thread Simon Horman
From: Carl Heymann <carl.heym...@netronome.com> Dump FW name as TLV, based on dump specification. Signed-off-by: Carl Heymann <carl.heym...@netronome.com> Reviewed-by: Jakub Kicinski <jakub.kicin...@netronome.com> Signed-off-by: Simon Horman <simon.hor...@netronome.com&g

[PATCH net-next 03/10] nfp: dump prolog

2017-12-04 Thread Simon Horman
<jakub.kicin...@netronome.com> Signed-off-by: Simon Horman <simon.hor...@netronome.com> --- .../net/ethernet/netronome/nfp/nfp_net_debugdump.c | 88 +- 1 file changed, 86 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/netronome/nfp/nfp_net_debugdump.c

[PATCH net-next 09/10] nfp: dump CPP, XPB and direct ME CSRs

2017-12-04 Thread Simon Horman
ed-by: Jakub Kicinski <jakub.kicin...@netronome.com> Signed-off-by: Simon Horman <simon.hor...@netronome.com> --- .../net/ethernet/netronome/nfp/nfp_net_debugdump.c | 102 + 1 file changed, 102 insertions(+) diff --git a/drivers/net/ethernet/netronome/nfp/nfp_net_de

[PATCH net-next 10/10] nfp: dump indirect ME CSRs

2017-12-04 Thread Simon Horman
write the context to a specific derived address, read it back, and then read the register value. - For each address, read and dump all 8 contexts in this manner. Signed-off-by: Carl Heymann <carl.heym...@netronome.com> Reviewed-by: Jakub Kicinski <jakub.kicin...@netronome.com> Si

[PATCH net-next 04/10] nfp: dumpspec TLV traversal

2017-12-04 Thread Simon Horman
ed-by: Jakub Kicinski <jakub.kicin...@netronome.com> Signed-off-by: Simon Horman <simon.hor...@netronome.com> --- .../net/ethernet/netronome/nfp/nfp_net_debugdump.c | 154 - 1 file changed, 153 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/netronome

[PATCH net-next 07/10] nfp: dump single hwinfo field by key

2017-12-04 Thread Simon Horman
error. Signed-off-by: Carl Heymann <carl.heym...@netronome.com> Reviewed-by: Jakub Kicinski <jakub.kicin...@netronome.com> Signed-off-by: Simon Horman <simon.hor...@netronome.com> --- .../net/ethernet/netronome/nfp/nfp_net_debugdump.c | 57 ++ 1 file changed, 57 i

[PATCH net-next 06/10] nfp: dump all hwinfo

2017-12-04 Thread Simon Horman
gt; Reviewed-by: Jakub Kicinski <jakub.kicin...@netronome.com> Signed-off-by: Simon Horman <simon.hor...@netronome.com> --- .../net/ethernet/netronome/nfp/nfp_net_debugdump.c | 33 ++ drivers/net/ethernet/netronome/nfp/nfpcore/nfp.h | 2 ++ .../ethernet/netronome/

[PATCH net-next 02/10] nfp: load debug dump spec

2017-12-04 Thread Simon Horman
.heym...@netronome.com> Reviewed-by: Jakub Kicinski <jakub.kicin...@netronome.com> Signed-off-by: Simon Horman <simon.hor...@netronome.com> --- .../net/ethernet/netronome/nfp/nfp_net_debugdump.c | 34 +- 1 file changed, 33 insertions(+), 1 deletion(-) diff --git

[PATCH net-next 01/10] nfp: debug dump ethtool ops

2017-12-04 Thread Simon Horman
f-by: Carl Heymann <carl.heym...@netronome.com> Reviewed-by: Jakub Kicinski <jakub.kicin...@netronome.com> Signed-off-by: Simon Horman <simon.hor...@netronome.com> --- drivers/net/ethernet/netronome/nfp/Makefile| 1 + drivers/net/ethernet/netronome/nfp/nfp_mai

[PATCH net-next 00/10] nfp: enhanced debug dump via ethtool

2017-12-04 Thread Simon Horman
Add debug dump implementation to the NFP driver. This makes use of existing ethtool infrastructure. ethtool -W is used to select the dump level and ethtool -w is used to dump NFP state. The existing behaviour of dump level 0, dumping the arm.diag resource, is preserved. Dump levels greater than

[PATCH net-next 05/10] nfp: dump rtsyms

2017-12-04 Thread Simon Horman
From: Carl Heymann <carl.heym...@netronome.com> - Support rtsym TLVs. - If specified rtsym is not found, dump the spec TLV as -ENOENT error. Signed-off-by: Carl Heymann <carl.heym...@netronome.com> Reviewed-by: Jakub Kicinski <jakub.kicin...@netronome.com> Signed-off-by: Simon

[PATCH net-next 3/4] nfp: flower: compile Geneve match fields

2017-12-19 Thread Simon Horman
Signed-off-by: John Hurley <john.hur...@netronome.com> Reviewed-by: Jakub Kicinski <jakub.kicin...@netronome.com> Signed-off-by: Simon Horman <simon.hor...@netronome.com> --- drivers/net/ethernet/netronome/nfp/flower/cmsg.h | 32 - drivers/net/ethernet/netronome/

[PATCH net-next 4/4] nfp: flower: compile Geneve encap actions

2017-12-19 Thread Simon Horman
ptions is not supported yet. Only attempt to offload if the fw supports Geneve. Signed-off-by: John Hurley <john.hur...@netronome.com> Reviewed-by: Jakub Kicinski <jakub.kicin...@netronome.com> Signed-off-by: Simon Horman <simon.hor...@netronome.com> --- drivers/net/ethernet/netronome/

[PATCH net-next 0/4] nfp: flower: add Geneve tunnel support

2017-12-19 Thread Simon Horman
John Hurley says: This patchset adds support for offloading the encap and decap of Geneve tunnels to the NFP. In both cases, specifying well known port 6081 is a requirement for rule offload. Geneve firmware support has been recently added, so the patchset includes the reading of a fw symbol

[PATCH net-next 2/4] nfp: flower: read extra feature support from fw

2017-12-19 Thread Simon Horman
l does not exist, set the bitmap to 0. Signed-off-by: John Hurley <john.hur...@netronome.com> Reviewed-by: Jakub Kicinski <jakub.kicin...@netronome.com> Signed-off-by: Simon Horman <simon.hor...@netronome.com> --- drivers/net/ethernet/netronome/nfp/flower/main.c | 10 +- driver

[PATCH net-next 1/4] nfp: flower: remove unused tun_mask variable

2017-12-19 Thread Simon Horman
.@netronome.com> Signed-off-by: Simon Horman <simon.hor...@netronome.com> --- drivers/net/ethernet/netronome/nfp/flower/match.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/net/ethernet/netronome/nfp/flower/match.c b/drivers/net/ethernet/netronome/

Re: [PATCH net-next 0/2] nfp: fix rtsym and XDP register handling in debug dump

2017-12-15 Thread Simon Horman
On Thu, Dec 14, 2017 at 10:50:24AM +0100, Simon Horman wrote: > Hi, > > this series resolves two problems in the recently added debug dump facility. > > * Correctly handle reading absolute rtysms > * Correctly handle special-case PB register reads > > These fixes a

[PATCH net-next 2/2] nfp: fix XPB register reads in debug dump

2017-12-14 Thread Simon Horman
PB and direct ME CSRs") Signed-off-by: Carl Heymann <carl.heym...@netronome.com> Reviewed-by: Jakub Kicinski <jakub.kicin...@netronome.com> Signed-off-by: Simon Horman <simon.hor...@netronome.com> --- drivers/net/ethernet/netronome/nfp/nfp_net_debugdump.c | 15

[PATCH net-next 1/2] nfp: fix absolute rtsym handling in debug dump

2017-12-14 Thread Simon Horman
4a 0x is reported. The values may be read using ethtool debug level 2. # ethtool -W 2 # ethtool -w data dump.dat Fixes: e1e798e3fd93 ("nfp: dump rtsyms") Signed-off-by: Carl Heymann <carl.heym...@netronome.com> Reviewed-by: Jakub Kicinski <jakub.kicin...@netronome.

[PATCH net-next 0/2] nfp: fix rtsym and XDP register handling in debug dump

2017-12-14 Thread Simon Horman
Hi, this series resolves two problems in the recently added debug dump facility. * Correctly handle reading absolute rtysms * Correctly handle special-case PB register reads These fixes are for code only present in net-next. Carl Heymann (2): nfp: fix absolute rtsym handling in debug dump

Re: [PATCH 1/8] dt-bindings: can: rcar_can: document r8a774[35] can support

2017-11-20 Thread Simon Horman
river change is needed. > > Signed-off-by: Fabrizio Castro <fabrizio.cas...@bp.renesas.com> > Reviewed-by: Biju Das <biju@bp.renesas.com> Reviewed-by: Simon Horman <horms+rene...@verge.net.au>

Re: [PATCH 0/8] Add CAN support to iwg2[02]d

2017-11-20 Thread Simon Horman
On Tue, Nov 07, 2017 at 03:10:41PM +, Fabrizio Castro wrote: > Hello, > > this series delivers all of the changes necessary to add CAN bus > support to the: > * iW-RainboW-G22D SODIMM, and > * iW-RainboW-G20M-Qseven-RZG1M > development platforms, including documentation, pinctrl driver, SoC >

[net-next 7/7] nfp: implement ethtool FEC mode settings

2017-11-04 Thread Simon Horman
m> Signed-off-by: Simon Horman <simon.hor...@netronome.com> --- .../net/ethernet/netronome/nfp/nfp_net_ethtool.c | 117 - 1 file changed, 116 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/netronome/nfp/nfp_net_ethtool.c b/drivers/net/ethe

[net-next 4/7] nfp: resync repr state when port table sync

2017-11-04 Thread Simon Horman
ecomes NULL which is safe since the app accessor function for reprs returns NULL when it cannot access a repr. Signed-off-by: Dirk van der Merwe <dirk.vanderme...@netronome.com> Signed-off-by: Simon Horman <simon.hor...@netronome.com> --- drivers/net/ethernet/netronome/nfp/n

[net-next 5/7] nfp: add get/set link settings ndos to representors

2017-11-04 Thread Simon Horman
emoved in the same way a vnic would be. Signed-off-by: Dirk van der Merwe <dirk.vanderme...@netronome.com> Signed-off-by: Simon Horman <simon.hor...@netronome.com> --- drivers/net/ethernet/netronome/nfp/nfp_net_ethtool.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ethe

[net-next 0/7] nfp: ethtool and related improvements

2017-11-04 Thread Simon Horman
Dirk van der Merwe says: This patch series throws a couple of loosely related items into a single series. Patch 1: Clang compilation fix reported by Matthias Kaehlcke Patch 2: Driver can now do MAC reinit on load when there has been a media override set in the NSP.

[net-next 1/7] nfp: don't depend on compiler constant propagation

2017-11-04 Thread Simon Horman
e mask and shift and pass those to nfp_eth_set_bit_config() separately. Reported-by: Matthias Kaehlcke <m...@chromium.org> Signed-off-by: Jakub Kicinski <jakub.kicin...@netronome.com> Tested-by: Dirk van der Merwe <dirk.vanderme...@netronome.com> Signed-off-by: Simon Horman <

[net-next 6/7] nfp: add helpers for FEC support

2017-11-04 Thread Simon Horman
Merwe <dirk.vanderme...@netronome.com> Signed-off-by: Simon Horman <simon.hor...@netronome.com> --- .../net/ethernet/netronome/nfp/nfpcore/nfp_nsp.h | 30 ++ .../ethernet/netronome/nfp/nfpcore/nfp_nsp_eth.c | 64 ++ 2 files changed, 94 insertions(+) di

[net-next 3/7] nfp: refactor nfp_app_reprs_set

2017-11-04 Thread Simon Horman
ssible for the current code to encounter a case where reprs exist and need to be replaced. Signed-off-by: Dirk van der Merwe <dirk.vanderme...@netronome.com> Signed-off-by: Simon Horman <simon.hor...@netronome.com> --- drivers/net/ethernet/netronome/nfp/flower/main.c | 16 dr

[net-next 2/7] nfp: make use of MAC reinit

2017-11-04 Thread Simon Horman
kub.kicin...@netronome.com> Tested-by: Dirk van der Merwe <dirk.vanderme...@netronome.com> Signed-off-by: Simon Horman <simon.hor...@netronome.com> --- drivers/net/ethernet/netronome/nfp/nfp_main.c | 28 +- .../net/ethernet/netronome/nfp/nfp_net_ethtool.c | 2 +- driver

Re: [patch net-next v2 0/4] net: sched: block callbacks follow-up

2017-11-01 Thread Simon Horman
ature flag. Reviewed-by: Simon Horman <simon.hor...@netronome.com>

Re: [PATCH net-next v4 3/3] net sched act_vlan: VLAN action rewrite to use RCU lock/unlock and update

2017-11-01 Thread Simon Horman
On Tue, Oct 31, 2017 at 02:17:00PM -0400, Manish Kurup wrote: > Using a spinlock in the VLAN action causes performance issues when the VLAN > action is used on multiple cores. Rewrote the VLAN action to use RCU read > locking for reads and updates instead. > > Acked-by: Jamal Hadi Salim

Re: [patch net-next RFC 2/9] net_sch: mqprio: Change TC_SETUP_MQPRIO to TC_SETUP_QDISC_MQPRIO

2017-11-01 Thread Simon Horman
On Mon, Oct 30, 2017 at 09:56:06AM +0100, Jiri Pirko wrote: > From: Nogah Frankel > > Change TC_SETUP_MQPRIO to TC_SETUP_QDISC_MQPRIO to match the new > convention. Why is there a new convention? This churn in this and the following patch warrant some justification IMHO.

Re: [PATCH] netfilter: ipvs: Convert timers to use timer_setup()

2017-11-02 Thread Simon Horman
imer_setup() and from_timer() > > to pass the timer pointer explicitly. > > > > Cc: Wensong Zhang <wens...@linux-vs.org> > > Cc: Simon Horman <ho...@verge.net.au> > > Cc: Julian Anastasov <j...@ssi.bg> > > Cc: Pablo Neira Ayuso <pa...@netfilter.

Re: [PATCH] netfilter/ipvs: clear ipvs_property flag when SKB net namespace changed

2017-11-02 Thread Simon Horman
; > > Patch looks good to me. ipvs_property was added long ago > but skb_scrub_packet() is more recent (3.11), so: > > Fixes: 621e84d6f373 ("dev: introduce skb_scrub_packet()") > Signed-off-by: Julian Anastasov <j...@ssi.bg> > > I guess, DaveM can apply

Re: [patch net-next 1/9] net_sch: red: Add offload ability to RED qdisc

2017-11-06 Thread Simon Horman
offload state but doesn't require any RED function to be called. > > Signed-off-by: Nogah Frankel <nog...@mellanox.com> > Signed-off-by: Jiri Pirko <j...@mellanox.com> Reviewed-by: Simon Horman <simon.hor...@netronome.com>

Re: [patch net-next 2/9] net_sch: mqprio: Change TC_SETUP_MQPRIO to TC_SETUP_QDISC_MQPRIO

2017-11-06 Thread Simon Horman
by: Jiri Pirko <j...@mellanox.com> Reviewed-by: Simon Horman <simon.hor...@netronome.com>

Re: [patch net-next 3/9] net_sch: cbs: Change TC_SETUP_CBS to TC_SETUP_QDISC_CBS

2017-11-06 Thread Simon Horman
<j...@mellanox.com> Reviewed-by: Simon Horman <simon.hor...@netronome.com>

[PATCH net-next] flow_dissector: dissect tunnel info outside __skb_flow_dissect()

2017-12-04 Thread Simon Horman
. Signed-off-by: Simon Horman <simon.hor...@netronome.com> Reviewed-by: Jakub Kicinski <jakub.kicin...@netronome.com> --- include/linux/skbuff.h| 5 + net/core/flow_dissector.c | 12 +--- net/sched/cls_flower.c| 1 + 3 files changed, 11 insertions(+), 7 deletions(-)

Re: [PATCH v4 0/4] Teach phylib hard-resetting devices

2017-12-10 Thread Simon Horman
On Mon, Dec 04, 2017 at 11:34:48AM +0100, Geert Uytterhoeven wrote: > Hi David, Andrew, Florian, Simon, Magnus, > > This patch series adds optional PHY reset support to phylib. > > The first two patches are destined for David's net-next tree. They add > core PHY reset code, and update a

Re: [PATCH] dt-bindings: net: ravb: Add support for r8a77990 SoC

2018-05-13 Thread Simon Horman
tation. > > > > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com> > > I'm assuming this isn't targetted at one of my trees. Just FYI. Hi Dave, I think this is appropriate for net-next but if not I can take it. Reviewed-by: Simon Horman <horms+rene..

Re: [PATCH] dt-bindings: can: rcar_can: Fix R8A7796 SoC name

2018-05-04 Thread Simon Horman
On Thu, May 03, 2018 at 03:02:33PM +0200, Geert Uytterhoeven wrote: > R8A7796 is R-Car M3-W. > > Signed-off-by: Geert Uytterhoeven <geert+rene...@glider.be> Reviewed-by: Simon Horman <horms+rene...@verge.net.au>

Re: [PATCH 3/3] sh_eth: add R8A77980 support

2018-05-17 Thread Simon Horman
tch by Vladimir Barinov. > > Signed-off-by: Vladimir Barinov <vladimir.bari...@cogentembedded.com> > Signed-off-by: Sergei Shtylyov <sergei.shtyl...@cogentembedded.com> Reviewed-by: Simon Horman <horms+rene...@verge.net.au>

Re: [PATCH 2/3] sh_eth: add EDMR.NBST support

2018-05-17 Thread Simon Horman
> > Signed-off-by: Vladimir Barinov <vladimir.bari...@cogentembedded.com> > Signed-off-by: Sergei Shtylyov <sergei.shtyl...@cogentembedded.com> Reviewed-by: Simon Horman <horms+rene...@verge.net.au> > > --- > drivers/net/ethernet/renesas/sh_eth.c |4

Re: [PATCH net v2] net/sched: act_simple: fix parsing of TCA_DEF_DATA

2018-06-08 Thread Simon Horman
message, thanks Hangbin Liu > > Fixes: fa1b1cff3d06 ("net_cls_act: Make act_simple use of netlink policy.") > Signed-off-by: Davide Caratti Reviewed-by: Simon Horman

Re: [PATCH net] KEYS: DNS: fix parsing multiple options

2018-06-11 Thread Simon Horman
On Mon, Jun 11, 2018 at 10:57:42AM -0700, Eric Biggers wrote: > Hi Simon, > > On Mon, Jun 11, 2018 at 11:40:23AM +0200, Simon Horman wrote: > > On Fri, Jun 08, 2018 at 09:20:37AM -0700, Eric Biggers wrote: > > > From: Eric Biggers > > > > > > My recen

Re: [PATCH net] KEYS: DNS: fix parsing multiple options

2018-06-11 Thread Simon Horman
On Fri, Jun 08, 2018 at 09:20:37AM -0700, Eric Biggers wrote: > From: Eric Biggers > > My recent fix for dns_resolver_preparse() printing very long strings was > incomplete, as shown by syzbot which still managed to hit the > WARN_ONCE() in set_precision() by adding a crafted "dns_resolver" key:

Re: [PATCH iproute2] configure: require libmnl

2018-06-05 Thread Simon Horman
nger Reviewed-by: Simon Horman

Re: [PATCH net-next V2 1/2] cls_flower: Fix missing free of rhashtable

2018-06-04 Thread Simon Horman
by: Jiri Pirko > Signed-off-by: Paul Blakey Reviewed-by: Simon Horman

Re: [PATCH net-next V2 2/2] cls_flower: Fix comparing of old filter mask with new filter

2018-06-04 Thread Simon Horman
y") > Reported-by: Vlad Buslov > Reviewed-by: Roi Dayan > Reviewed-by: Jiri Pirko > Signed-off-by: Paul Blakey Reviewed-by: Simon Horman

Re: [PATCH net 0/5] net sched actions: code style cleanup and fixes

2018-06-20 Thread Simon Horman
et sched actions: fix coding style in pedit headers > net sched actions: fix sparse warning > net sched actions: use sizeof operator for buffer length > net sched actions: fix misleading text strings in pedit action All patches: Reviewed-by: Simon Horman

Re: [PATCH] DT: net: can: rcar_canfd: document R8A77970 bindings

2018-04-30 Thread Simon Horman
On Thu, Apr 26, 2018 at 10:41:14PM +0300, Sergei Shtylyov wrote: > Document the R-Car V3M (R8A77970) SoC support in the R-Car CAN-FD bindings. > > Signed-off-by: Sergei Shtylyov <sergei.shtyl...@cogentembedded.com> Reviewed-by: Simon Horman <horms+rene...@verge.net.au>

Re: [PATCH] DT: net: can: rcar_canfd: document R8A77980 bindings

2018-04-30 Thread Simon Horman
' repo plus the R8A77970 bindings > patch posted yesterday. Although I wouldn't object if they're both merged to > the 'linux-can.git' repo instead. :-) > > Documentation/devicetree/bindings/net/can/rcar_canfd.txt |1 + > 1 file changed, 1 insertion(+) Reviewed-by: Simon Horman &

Re: [PATCH v3 0/4] Teach phylib hard-resetting devices

2017-10-20 Thread Simon Horman
On Fri, Oct 20, 2017 at 10:14:17AM +0200, Geert Uytterhoeven wrote: > Hi David, Andrew, Florian, Simon, Magnus, > > This patch series adds optional PHY reset support to phylib. > > The first two patches are destined for David's net-next tree. They add > core PHY reset code, and update a

[PATCH net-next] nfp: use struct fields for 8 bit-wide access

2017-10-20 Thread Simon Horman
From: Pieter Jansen van Vuuren <pieter.jansenvanvuu...@netronome.com> Use direct access struct fields rather than PREP_FIELD() macros to manipulate the jump ID and length, both of which are exactly 8-bits wide. This simplifies the code somewhat. Signed-off-by: Simon Horman <

<    5   6   7   8   9   10   11   >