Re: [PATCH V3 29/29] ethernet: use parity8 in broadcom/tg3.c

2016-04-21 Thread Siva Reddy Kallam
On Thu, Apr 14, 2016 at 8:42 AM, <zengzhao...@163.com> wrote: > > From: Zhaoxiu Zeng <zhaoxiu.z...@gmail.com> > > Signed-off-by: Zhaoxiu Zeng <zhaoxiu.z...@gmail.com> Looks good to me. Acked-by: Siva Reddy Kallam <siva.kal...@broadcom.com> > --- >

Re: question: tg3 driver/nics and inconsistent RX ring count

2016-07-29 Thread Siva Reddy Kallam
On Wed, Jul 27, 2016 at 4:25 AM, Michael Chan wrote: > On Tue, Jul 26, 2016 at 1:32 PM, Michal Soltys wrote: >> On 2016-07-26 22:06, Alexander Duyck wrote: >>> On Tue, Jul 26, 2016 at 12:52 PM, Michal Soltys wrote: Hi,

Re: [PATCH net 1/2] tg3: Fix for diasllow rx coalescing time to be 0

2016-08-04 Thread Siva Reddy Kallam
On Thu, Aug 4, 2016 at 3:45 AM, Michael Chan wrote: > On Wed, Aug 3, 2016 at 9:04 AM, Rick Jones wrote: >> >> Should anything then happen with: >> >> /* No rx interrupts will be generated if both are zero */ >> if

Re: 4.9.0-rc8: tg3 dead after resume

2017-01-24 Thread Siva Reddy Kallam
On Mon, Jan 16, 2017 at 8:29 PM, Billy Shuman <wshum...@gmail.com> wrote: > On Mon, Jan 16, 2017 at 2:15 AM, Siva Reddy Kallam > <siva.kal...@broadcom.com> wrote: >> Hi, >> >> Sorry for the late reply. >> We don't have exact model. >> We tried to rep

Re: [PATCH net v2] tg3: Fix for disallow tx coalescing time to be 0

2016-09-01 Thread Siva Reddy Kallam
; Cc: siva.kal...@broadcom.com > Cc: michael.c...@broadcom.com > Signed-off-by: Ivan Vecera <ivec...@redhat.com> Acked-by: Siva Reddy Kallam <siva.kal...@broadcom.com> > --- > drivers/net/ethernet/broadcom/tg3.c | 11 +-- > 1 file changed, 1 insertion(+), 10 delet

Re: tg3 BUG: spinlock lockup suspected

2016-10-08 Thread Siva Reddy Kallam
On Sat, Oct 8, 2016 at 10:15 PM, Meelis Roos wrote: >> That did not go well - bisect found the following commit but that does >> not seem to be related at all. So probably the reproducibility is not >> 100% but more random. > > Now I reproduced the bug even with 4.7-rc1 so it is

Re: tg3 BUG: spinlock lockup suspected

2016-10-10 Thread Siva Reddy Kallam
On Sun, Oct 9, 2016 at 12:35 AM, Meelis Roos wrote: >> > That did not go well - bisect found the following commit but that does >> > not seem to be related at all. So probably the reproducibility is not >> > 100% but more random. >> >> Now I reproduced the bug even with 4.7-rc1 so

Re: tg3 BUG: spinlock lockup suspected

2016-10-18 Thread Siva Reddy Kallam
On Mon, Oct 17, 2016 at 6:35 PM, Meelis Roos wrote: >> > Now I reproduced the bug even with 4.7-rc1 so it is older than 4.7. Will >> > test further. >> >> It gets stranger and stranger - my old 4.7 image worked fine, freshly >> compiled 4.7 exhibits the same problem. >> >>

Re: tg3 BUG: spinlock lockup suspected

2016-10-13 Thread Siva Reddy Kallam
On Mon, Oct 10, 2016 at 5:21 PM, Siva Reddy Kallam <siva.kal...@broadcom.com> wrote: > On Sun, Oct 9, 2016 at 12:35 AM, Meelis Roos <mr...@linux.ee> wrote: >>> > That did not go well - bisect found the following commit but that does >>> > not

Re: 4.9.0-rc8: tg3 dead after resume

2016-12-08 Thread Siva Reddy Kallam
On Thu, Dec 8, 2016 at 12:14 AM, Billy Shuman wrote: > On Wed, Dec 7, 2016 at 12:37 PM, Michael Chan > wrote: >> On Wed, Dec 7, 2016 at 7:20 AM, Billy Shuman wrote: >>> After resume on 4.9.0-rc8 tg3 is dead. >>> >>> In logs I

Re: 4.9.0-rc8: tg3 dead after resume

2016-12-12 Thread Siva Reddy Kallam
On Fri, Dec 9, 2016 at 7:59 PM, Billy Shuman <wshum...@gmail.com> wrote: > On Thu, Dec 8, 2016 at 4:03 AM, Siva Reddy Kallam > <siva.kal...@broadcom.com> wrote: >> On Thu, Dec 8, 2016 at 12:14 AM, Billy Shuman <wshum...@gmail.com> wrote: >>> On Wed, Dec 7, 20

Re: 4.9.0-rc8: tg3 dead after resume

2016-12-25 Thread Siva Reddy Kallam
On Mon, Dec 12, 2016 at 3:53 PM, Siva Reddy Kallam <siva.kal...@broadcom.com> wrote: > On Fri, Dec 9, 2016 at 7:59 PM, Billy Shuman <wshum...@gmail.com> wrote: >> On Thu, Dec 8, 2016 at 4:03 AM, Siva Reddy Kallam >> <siva.kal...@broadcom.com> wrote: >>&

Re: [PATCH net-next] tg3: Add the ability to conditionally build w/ HWMON

2017-03-07 Thread Siva Reddy Kallam
On Tue, Mar 7, 2017 at 2:26 AM, Florian Fainelli <f.faine...@gmail.com> wrote: > Introduce a Kconfig option: CONFIG_TIGON3_HWMON which allows to build > in/out support for thermal sensors reported by Tigon3 NICs. > > Signed-off-by: Florian Fainelli <f.faine...@gmail.com&

Re: [Problem] Broadcom BCM5762 Ethernet tg3 times out with stack trace

2017-05-11 Thread Siva Reddy Kallam
On Thu, May 11, 2017 at 8:55 PM, Daniel Kim wrote: > Summary: > Broadcom BCM5762 Ethernet tg3 times out with stack trace > > Description: > The ethernet device will disconnect with dmesg reporting a stack trace > and a time out (visible in DMesg Output below). The ethernet

Re: [Problem] Broadcom BCM5762 Ethernet tg3 times out with stack trace

2017-05-12 Thread Siva Reddy Kallam
On Fri, May 12, 2017 at 9:39 AM, Siva Reddy Kallam <siva.kal...@broadcom.com> wrote: > On Thu, May 11, 2017 at 8:55 PM, Daniel Kim <d...@playmechanix.com> wrote: >> Summary: >> Broadcom BCM5762 Ethernet tg3 times out with stack trace >> >> Description:

Re: [Problem] Broadcom BCM5762 Ethernet tg3 times out with stack trace

2017-06-06 Thread Siva Reddy Kallam
On Fri, Jun 2, 2017 at 3:31 AM, Daniel Kim wrote: > On Fri, May 12, 2017 at 6:12 PM, Daniel Kim wrote: >> I believe I do have IOMMU enabled. At least the dmesg output seems to >> imply that I do: >> [1.141948] iommu: Adding device :00:02.0 to

Re: tg3 pxe weirdness

2017-09-22 Thread Siva Reddy Kallam
On Thu, Sep 21, 2017 at 7:53 PM, Berend De Schouwer wrote: > Hi, > > I've got a machine with a Broadcom bcm5762c, using the tg3 driver, that > fails to receive network packets under some very specific conditions. > > It works perfectly using a 1Gbps switch. If,

Re: tg3 pxe weirdness

2017-09-25 Thread Siva Reddy Kallam
On Fri, Sep 22, 2017 at 9:04 PM, Berend De Schouwer <berend.de.schou...@gmail.com> wrote: > On Fri, 2017-09-22 at 11:51 +0530, Siva Reddy Kallam wrote: >> >> >> Can you please share below details? >> 1) Model and Manufacturer of the system >> 2) Linux distr

Re: netdev watchdog enp1s0 (tg3): transmit queue 0 timed out

2017-09-04 Thread Siva Reddy Kallam
On Fri, Sep 1, 2017 at 12:13 PM, Frans van Berckel wrote: > Dear Michael and Siva, > > On Thu, 2017-08-31 at 23:36 -0700, Michael Chan wrote: >> On Thu, Aug 31, 2017 at 11:10 PM, Frans van Berckel >> wrote: >> > >> > a long list of likely the same type of

Re: tg3 pxe weirdness

2017-09-27 Thread Siva Reddy Kallam
On Wed, Sep 27, 2017 at 3:35 PM, Berend De Schouwer <berend.de.schou...@gmail.com> wrote: > On Mon, 2017-09-25 at 15:11 +0530, Siva Reddy Kallam wrote: >> On Fri, Sep 22, 2017 at 9:04 PM, Berend De Schouwer >> <berend.de.schou...@gmail.com> wrote: >> > On Fri, 2

Re: [PATCH] tg3: Fix rx hang on MTU change with 5717/5719

2017-12-16 Thread Siva Reddy Kallam
On Sat, Dec 16, 2017 at 2:51 AM, Brian King wrote: > This fixes a hang issue seen when changing the MTU size from 1500 MTU > to 9000 MTU on both 5717 and 5719 chips. In discussion with Broadcom, > they've indicated that these chipsets have the same phy as the 57766 >

Re: tg3 crashes under high load, when using 100Mbits

2018-02-11 Thread Siva Reddy Kallam
On Fri, Feb 9, 2018 at 10:41 AM, Kai Heng Feng wrote: > Hi Broadcom folks, > > We are now enabling a new platform with tg3 nic, unfortunately we observed > the bug [1] that dated back to 2015. > I tried commit 4419bb1cedcd ("tg3: Add workaround to restrict 5762 MRRS

Re: tg3 crashes under high load, when using 100Mbits

2018-02-15 Thread Siva Reddy Kallam
On Mon, Feb 12, 2018 at 10:59 AM, Siva Reddy Kallam <siva.kal...@broadcom.com> wrote: > On Fri, Feb 9, 2018 at 10:41 AM, Kai Heng Feng > <kai.heng.f...@canonical.com> wrote: >> Hi Broadcom folks, >> >> We are now enabling a new platform with tg3 nic, unf

[PATCH 1/3] tg3: Update copyright

2017-12-22 Thread Siva Reddy Kallam
From: Siva Reddy Kallam <siva.kal...@broadcom.com> Signed-off-by: Siva Reddy Kallam <siva.kal...@broadcom.com> Signed-off-by: Michael Chan <michael.c...@broadcom.com> --- drivers/net/ethernet/broadcom/tg3.c | 6 -- drivers/net/ethernet/broadcom/tg3.h | 3 ++- 2 files cha

[PATCH 3/3] tg3: Enable PHY reset in MTU change path for 5720

2017-12-22 Thread Siva Reddy Kallam
From: Siva Reddy Kallam <siva.kal...@broadcom.com> A customer noticed RX path hang when MTU is changed on the fly while running heavy traffic with NCSI enabled for 5717 and 5719. Since 5720 belongs to same ASIC family, we observed same issue and same fix could solve this problem for 5720.

[PATCH net 0/3] update on copyright and couple of fixes

2017-12-22 Thread Siva Reddy Kallam
First patch: Update copyright Second patch: Add workaround to restrict 5762 MRRS Third patch: Add PHY reset in change MTU path for 5720 Siva Reddy Kallam (3): tg3: Update copyright tg3: Add workaround to restrict 5762 MRRS to 2048 tg3: Enable PHY reset in MTU

[PATCH 2/3] tg3: Add workaround to restrict 5762 MRRS to 2048

2017-12-22 Thread Siva Reddy Kallam
From: Siva Reddy Kallam <siva.kal...@broadcom.com> One of AMD based server with 5762 hangs with jumbo frame traffic. This AMD platform has southbridge limitation which is restricting MRRS to 4000. As a work around, driver to restricts the MRRS to 2048 for this particular 5762 NX1 card.

[PATCH net 2/2] tg3: Add higher cpu clock for 5762.

2018-07-15 Thread Siva Reddy Kallam
From: Sanjeev Bansal This patch has fix for TX timeout while running bi-directional traffic with 100 Mbps using 5762. Signed-off-by: Sanjeev Bansal Signed-off-by: Siva Reddy Kallam Reviewed-by: Michael Chan --- drivers/net/ethernet/broadcom/tg3.c | 9 + 1 file changed, 9 insertions

[PATCH net 0/2] tg3: Update copyright and fix for tx timeout with 5762

2018-07-15 Thread Siva Reddy Kallam
From: Siva Reddy Kallam First patch: Update copyright Second patch: Add higher cpu clock for 5762 Sanjeev Bansal (1): tg3: Add higher cpu clock for 5762. Siva Reddy Kallam (1): tg3: Update copyright drivers/net/ethernet/broadcom/tg3.c | 17 + drivers/net

[PATCH net 1/2] tg3: Update copyright

2018-07-15 Thread Siva Reddy Kallam
From: Siva Reddy Kallam Signed-off-by: Siva Reddy Kallam Reviewed-by: Michael Chan --- drivers/net/ethernet/broadcom/tg3.c | 4 drivers/net/ethernet/broadcom/tg3.h | 2 ++ 2 files changed, 6 insertions(+) diff --git a/drivers/net/ethernet/broadcom/tg3.c b/drivers/net/ethernet/broadcom

Re: tg3 crashes under high load, when using 100Mbits

2018-04-18 Thread Siva Reddy Kallam
>>> On Thu, Feb 15, 2018 at 7:37 PM, Siva Reddy Kallam >>> <siva.kal...@broadcom.com> wrote: >>>> On Mon, Feb 12, 2018 at 10:59 AM, Siva Reddy Kallam >>>> <siva.kal...@broadcom.com> wrote: >>>>> On Fri, Feb 9, 2018 at 10:41 AM, Kai H

Re: NETDEV WATCHDOG: eth0 (tg3): transmit queue 0 timed out

2018-02-28 Thread Siva Reddy Kallam
On Sat, Feb 24, 2018 at 3:48 PM, Borislav Petkov wrote: > Hi, > > this didn't happen before but after 4.16-rc1 my tg3 nic stops for > whatever reason and the connection to the machine is dead. It didn't show > anything in dmesg until today. > > The IO pagefaults look like it is

[PATCH net] tg3: Add PHY reset for 5717/5719/5720 in change ring and flow control paths

2018-11-19 Thread Siva Reddy Kallam
From: Siva Reddy Kallam This patch has the fix to avoid PHY lockup with 5717/5719/5720 in change ring and flow control paths. This patch solves the RX hang while doing continuous ring or flow control parameters with heavy traffic from peer. Signed-off-by: Siva Reddy Kallam Acked-by: Michael