[PATCH] net: qca_spi: Fix possible race during probe

Registering the netdev before setting the priv data is unsafe. So fix this possible race by setting the priv data first. Signed-off-by: Stefan Wahren stefan.wah...@i2se.com Cc: sta...@vger.kernel.org # v3.18+ Fixes: 291ab06e (net: qualcomm: new Ethernet over SPI driver for QCA7000) --- drivers

[PATCH] net: qca_spi: fix transmit queue timeout handling

. Signed-off-by: Stefan Wahren <stefan.wah...@i2se.com> Cc: <sta...@vger.kernel.org> # v3.18+ Fixes: 291ab06ecf67 ("net: qualcomm: new Ethernet over SPI driver for QCA7000") --- drivers/net/ethernet/qualcomm/qca_spi.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) di

[PATCH net-next RFT] net: fec: handle small PHY reset durations more precisely

Since msleep is based on jiffies the PHY reset could take longer than expected. So use msleep for values greater than 20 msec otherwise usleep_range. Signed-off-by: Stefan Wahren <stefan.wah...@i2se.com> --- drivers/net/ethernet/freescale/fec_main.c |7 ++- 1 file changed, 6 inse

[PATCH 1/2] net: qca_spi: Don't clear IFF_BROADCAST

Currently qcaspi_netdev_setup accidentally clears IFF_BROADCAST. So fix this by keeping the flags from ether_setup. Reported-by: Michael Heimpold <michael.heimp...@i2se.com> Signed-off-by: Stefan Wahren <stefan.wah...@i2se.com> Fixes: 291ab06ecf67 (net: qualcomm: new Ethernet ove

[PATCH 2/2] net: qca_spi: clear IFF_TX_SKB_SHARING

ether_setup sets IFF_TX_SKB_SHARING but this is not supported by qca_spi as it modifies the skb on xmit. Signed-off-by: Stefan Wahren <stefan.wah...@i2se.com> Fixes: 291ab06ecf67 (net: qualcomm: new Ethernet over SPI driver for QCA7000) --- drivers/net/ethernet/qualcomm/qca_spi.c |

Re: usb/net/hso: WARNING: ungligned urb->setup_dma

Hi Baruch, Am 28.02.2017 um 13:01 schrieb Baruch Siach: Hi linux-usb list, (Dropped Jan's bouncing address, added Rpi3 platform lists) On Tue, Feb 28, 2017 at 10:28:10AM +0200, Baruch Siach wrote: Hi linux-usb list, I'm hitting this warning consistently on my Raspberry Pi 3 running kernel

Re: usb/net/hso: WARNING: ungligned urb->setup_dma

Hi Baruch, > Baruch Siach <bar...@tkos.co.il> hat am 28. Februar 2017 um 19:07 geschrieben: > > > Hi Stefan, > > On Tue, Feb 28, 2017 at 05:21:18PM +0100, Stefan Wahren wrote: > > Am 28.02.2017 um 13:01 schrieb Baruch Siach: > > > On Tue, Feb 28, 2017

Re: [PATCH net-next 8/8] net: qualcomm: add QCA7000 UART driver

> kbuild test robot <l...@intel.com> hat am 20. September 2016 um 16:44 > geschrieben: > > > Hi Stefan, > > [auto build test ERROR on net-next/master] > > url: > > https://github.com/0day-ci/linux/commits/Stefan-Wahren/net-qualcomm-add-QCA7000-UAR

Re: [PATCH net-next 8/8] net: qualcomm: add QCA7000 UART driver

Hi Marcel, Am 20.09.2016 um 17:32 schrieb Marcel Holtmann: > Hi Stefan, > >> This patch adds the Ethernet over UART driver for the >> Qualcomm QCA7000 HomePlug GreenPHY. >> >> Signed-off-by: Stefan Wahren <stefan.wah...@i2se.com> >> --- >>

[PATCH net-next 1/8] net: qualcomm: remove unnecessary includes

Most of the includes in qca_7k.c are unnecessary so we better remove them. Signed-off-by: Stefan Wahren <stefan.wah...@i2se.com> --- drivers/net/ethernet/qualcomm/qca_7k.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/net/ethernet/qualcomm/qca_7k.c b/drivers/net/et

[PATCH net-next 8/8] net: qualcomm: add QCA7000 UART driver

This patch adds the Ethernet over UART driver for the Qualcomm QCA7000 HomePlug GreenPHY. Signed-off-by: Stefan Wahren <stefan.wah...@i2se.com> --- drivers/net/ethernet/qualcomm/Kconfig | 12 + drivers/net/ethernet/qualcomm/Makefile | 2 + drivers/net/ethernet/qualcomm/qca_co

[PATCH net-next 5/8] net: qualcomm: move MTU handling to qca_common

The MTU of the QCA7000 is independent from it's host interface (UART,SPI). So move the change_mtu function to qca_common. Signed-off-by: Stefan Wahren <stefan.wah...@i2se.com> --- drivers/net/ethernet/qualcomm/qca_common.c | 11 +++ drivers/net/ethernet/qualcomm/qca_common.

[PATCH net-next 2/8] net: qca_debug: use net_device_ops instead of direct call

There is no need to export qcaspi_netdev_open and qcaspi_netdev_close because they are also accessible via the net_device_ops. Signed-off-by: Stefan Wahren <stefan.wah...@i2se.com> --- drivers/net/ethernet/qualcomm/qca_debug.c | 5 +++-- drivers/net/ethernet/qualcomm/qca_spi.h | 3 --- 2

[PATCH net-next 6/8] net: qualcomm: prepare frame decoding for UART driver

Unfortunately the frame format is not exactly identical between SPI and UART. In case of SPI there is an additional HW length at the beginning. So store the initial state to make the decoding state machine more flexible and easy to extend for UART support. Signed-off-by: Stefan Wahren <stefan.

[PATCH net-next 4/8] net: qualcomm: rename qca_framing.c to qca_common.c

As preparation for the upcoming UART driver we need a module which contains common functions for both interfaces. The module qca_framing is a good candidate but renaming to qca_common would make it clear. Signed-off-by: Stefan Wahren <stefan.wah...@i2se.com> --- drivers/net/ethernet/qu

[PATCH net-next 0/8] net: qualcomm: add QCA7000 UART driver

/qca7k_support_1_24 Stefan Wahren (8): net: qualcomm: remove unnecessary includes net: qca_debug: use net_device_ops instead of direct call net: qualcomm: move qcaspi_tx_cmd to qca_spi.c net: qualcomm: rename qca_framing.c to qca_common.c net: qualcomm: move MTU handling to qca_common net

[PATCH net-next 7/8] net: qualcomm: make qca_common a separate kernel module

In order to share common functions between QCA7000 SPI and UART protocol driver the qca_common needs to be a separate kernel module. Signed-off-by: Stefan Wahren <stefan.wah...@i2se.com> --- drivers/net/ethernet/qualcomm/Kconfig | 8 +++- drivers/net/ethernet/qualcomm/Makefile

[PATCH net-next 3/8] net: qualcomm: move qcaspi_tx_cmd to qca_spi.c

The function qcaspi_tx_cmd() is only called from qca_spi.c. So we better move it there. Signed-off-by: Stefan Wahren <stefan.wah...@i2se.com> --- drivers/net/ethernet/qualcomm/qca_7k.c | 24 drivers/net/ethernet/qualcomm/qca_7k.h | 1 - drivers/net/ethernet/qu

[PATCH RFC v2 net-next 7/8] net: qualcomm: make qca_common a separate kernel module

In order to share common functions between QCA7000 SPI and UART protocol driver the qca_common needs to be a separate kernel module. Signed-off-by: Stefan Wahren <stefan.wah...@i2se.com> --- drivers/net/ethernet/qualcomm/Kconfig | 8 +++- drivers/net/ethernet/qualcomm/Makefile

[PATCH RFC v2 net-next 3/8] net: qualcomm: move qcaspi_tx_cmd to qca_spi.c

The function qcaspi_tx_cmd() is only called from qca_spi.c. So we better move it there. Signed-off-by: Stefan Wahren <stefan.wah...@i2se.com> --- drivers/net/ethernet/qualcomm/qca_7k.c | 24 drivers/net/ethernet/qualcomm/qca_7k.h | 1 - drivers/net/ethernet/qu

[PATCH RFC v2 net-next 1/8] net: qualcomm: remove unnecessary includes

Most of the includes in qca_7k.c are unnecessary so we better remove them. Signed-off-by: Stefan Wahren <stefan.wah...@i2se.com> --- drivers/net/ethernet/qualcomm/qca_7k.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/net/ethernet/qualcomm/qca_7k.c b/drivers/net/et

[PATCH RFC v2 net-next 0/8] net: qualcomm: add QCA7000 UART driver

] - https://github.com/IoE/qca7000 [2] - https://github.com/lategoodbye/busybox/commits/qca7k_support_1_24 Stefan Wahren (8): net: qualcomm: remove unnecessary includes net: qca_debug: use net_device_ops instead of direct call net: qualcomm: move qcaspi_tx_cmd to qca_spi.c net: qualcomm: rename

[PATCH RFC v2 net-next 8/8] net: qualcomm: add QCA7000 UART driver

This patch adds the Ethernet over UART driver for the Qualcomm QCA7000 HomePlug GreenPHY. Signed-off-by: Stefan Wahren <stefan.wah...@i2se.com> --- drivers/net/ethernet/qualcomm/Kconfig | 12 + drivers/net/ethernet/qualcomm/Makefile | 2 + drivers/net/ethernet/qualcomm/qca_co

[PATCH RFC v2 net-next 4/8] net: qualcomm: rename qca_framing.c to qca_common.c

As preparation for the upcoming UART driver we need a module which contains common functions for both interfaces. The module qca_framing is a good candidate but renaming to qca_common would make it clear. Signed-off-by: Stefan Wahren <stefan.wah...@i2se.com> --- drivers/net/ethernet/qu

[PATCH RFC v2 net-next 2/8] net: qca_debug: use net_device_ops instead of direct call

There is no need to export qcaspi_netdev_open and qcaspi_netdev_close because they are also accessible via the net_device_ops. Signed-off-by: Stefan Wahren <stefan.wah...@i2se.com> --- drivers/net/ethernet/qualcomm/qca_debug.c | 5 +++-- drivers/net/ethernet/qualcomm/qca_spi.h | 3 --- 2

[PATCH RFC v2 net-next 6/8] net: qualcomm: prepare frame decoding for UART driver

Unfortunately the frame format is not exactly identical between SPI and UART. In case of SPI there is an additional HW length at the beginning. So store the initial state to make the decoding state machine more flexible and easy to extend for UART support. Signed-off-by: Stefan Wahren <stefan.

[PATCH RFC v2 net-next 5/8] net: qualcomm: move MTU handling to qca_common

The MTU of the QCA7000 is independent from it's host interface (UART,SPI). So move the change_mtu function to qca_common. Signed-off-by: Stefan Wahren <stefan.wah...@i2se.com> --- drivers/net/ethernet/qualcomm/qca_common.c | 11 +++ drivers/net/ethernet/qualcomm/qca_common.

[PATCH v3 net-next 4/8] net: qualcomm: rename qca_framing.c to qca_common.c

As preparation for the upcoming UART driver we need a module which contains common functions for both interfaces. The module qca_framing is a good candidate but renaming to qca_common would make it clear. Signed-off-by: Stefan Wahren <stefan.wah...@i2se.com> --- drivers/net/ethernet/qu

[PATCH v3 net-next 8/8] net: qualcomm: add QCA7000 UART driver

This patch adds the Ethernet over UART driver for the Qualcomm QCA7000 HomePlug GreenPHY. Signed-off-by: Stefan Wahren <stefan.wah...@i2se.com> --- drivers/net/ethernet/qualcomm/Kconfig | 12 + drivers/net/ethernet/qualcomm/Makefile | 2 + drivers/net/ethernet/qualcomm/qca_co

[PATCH v3 net-next 1/8] net: qualcomm: remove unnecessary includes

Most of the includes in qca_7k.c are unnecessary so we better remove them. Signed-off-by: Stefan Wahren <stefan.wah...@i2se.com> --- drivers/net/ethernet/qualcomm/qca_7k.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/net/ethernet/qualcomm/qca_7k.c b/drivers/net/et

[PATCH v3 net-next 7/8] net: qualcomm: make qca_common a separate kernel module

In order to share common functions between QCA7000 SPI and UART protocol driver the qca_common needs to be a separate kernel module. Signed-off-by: Stefan Wahren <stefan.wah...@i2se.com> --- drivers/net/ethernet/qualcomm/Kconfig | 8 +++- drivers/net/ethernet/qualcomm/Makefile

[PATCH v3 net-next 0/8] net: qualcomm: add QCA7000 UART driver

netif_trans_update() and dev_trans_start() [1] - https://github.com/IoE/qca7000 [2] - https://github.com/lategoodbye/busybox/commits/qca7k_support_1_24 Stefan Wahren (8): net: qualcomm: remove unnecessary includes net: qca_debug: use net_device_ops instead of direct call net: qualcomm: move

[PATCH v3 net-next 5/8] net: qualcomm: move MTU handling to qca_common

The MTU of the QCA7000 is independent from it's host interface (UART,SPI). So move the change_mtu function to qca_common. Signed-off-by: Stefan Wahren <stefan.wah...@i2se.com> --- drivers/net/ethernet/qualcomm/qca_common.c | 11 +++ drivers/net/ethernet/qualcomm/qca_common.

[PATCH v3 net-next 3/8] net: qualcomm: move qcaspi_tx_cmd to qca_spi.c

The function qcaspi_tx_cmd() is only called from qca_spi.c. So we better move it there. Signed-off-by: Stefan Wahren <stefan.wah...@i2se.com> --- drivers/net/ethernet/qualcomm/qca_7k.c | 24 drivers/net/ethernet/qualcomm/qca_7k.h | 1 - drivers/net/ethernet/qu

[PATCH v3 net-next 6/8] net: qualcomm: prepare frame decoding for UART driver

Unfortunately the frame format is not exactly identical between SPI and UART. In case of SPI there is an additional HW length at the beginning. So store the initial state to make the decoding state machine more flexible and easy to extend for UART support. Signed-off-by: Stefan Wahren <stefan.

[PATCH v3 net-next 2/8] net: qca_debug: use net_device_ops instead of direct call

There is no need to export qcaspi_netdev_open and qcaspi_netdev_close because they are also accessible via the net_device_ops. Signed-off-by: Stefan Wahren <stefan.wah...@i2se.com> --- drivers/net/ethernet/qualcomm/qca_debug.c | 5 +++-- drivers/net/ethernet/qualcomm/qca_spi.h | 3 --- 2

Re: [PATCH v3 net-next 8/8] net: qualcomm: add QCA7000 UART driver

Am 18.10.2016 um 20:30 schrieb David Miller: > From: Stefan Wahren <stefan.wah...@i2se.com> > Date: Tue, 18 Oct 2016 13:27:34 +0200 > >> +void >> +qca_tty_receive(struct tty_struct *tty, const unsigned char *cp, char *fp, >> +int count) >&g

Re: [PATCH RFC v2 net-next 0/8] net: qualcomm: add QCA7000 UART driver

> Stefan Wahren <stefan.wah...@i2se.com> hat am 26. September 2016 um 13:07 > geschrieben: > > > The Qualcomm QCA7000 HomePlug GreenPHY supports two interfaces: > UART and SPI. This patch series adds the missing support for UART. > > This driver based on the Q

Re: [PATCH RFC v4 07/10] dt-bindings: net: add binding for QCA7000 UART

Am 27.03.2017 um 22:30 schrieb Rob Herring: > On Mon, Mar 27, 2017 at 8:37 AM, Stefan Wahren <stefan.wah...@i2se.com> wrote: >> This is the serdev binding for the QCA7000 UART driver (Ethernet over UART). >> >> Signed-off-by: Stefan Wahren <stefan.wah...@i2

Re: [PATCH RFC v4 06/10] net: qualcomm: make qca_common a separate kernel module

Am 27.03.2017 um 17:44 schrieb Dan Williams: > On Mon, 2017-03-27 at 15:37 +0200, Stefan Wahren wrote: >> In order to share common functions between QCA7000 SPI and UART >> protocol >> driver the qca_common needs to be a separate kernel module. > Maybe "qca_eth_co

Re: [PATCH RFC v4 10/10] tty: serdev: add functions to retrieve common UART settings

Am 27.03.2017 um 22:00 schrieb Rob Herring: > On Mon, Mar 27, 2017 at 8:37 AM, Stefan Wahren <stefan.wah...@i2se.com> wrote: >> Currently serdev core doesn't provide functions to retrieve common >> UART settings like data bits, stop bits or parity. This patch adds >>

[PATCH RFC v4 01/10] net: qualcomm: remove unnecessary includes

Most of the includes in qca_7k.c are unnecessary so we better remove them. Signed-off-by: Stefan Wahren <stefan.wah...@i2se.com> --- drivers/net/ethernet/qualcomm/qca_7k.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/net/ethernet/qualcomm/qca_7k.c b/drivers/net/et

[PATCH RFC v4 06/10] net: qualcomm: make qca_common a separate kernel module

In order to share common functions between QCA7000 SPI and UART protocol driver the qca_common needs to be a separate kernel module. Signed-off-by: Stefan Wahren <stefan.wah...@i2se.com> --- drivers/net/ethernet/qualcomm/Kconfig | 8 +++- drivers/net/ethernet/qualcomm/Makefile

[PATCH RFC v4 10/10] tty: serdev: add functions to retrieve common UART settings

Currently serdev core doesn't provide functions to retrieve common UART settings like data bits, stop bits or parity. This patch adds the interface to the core and the necessary implementation for serdev-ttyport. Signed-off-by: Stefan Wahren <stefan.wah...@i2se.com> --- drivers/tty/serdev/

[PATCH RFC v4 04/10] net: qualcomm: rename qca_framing.c to qca_common.c

As preparation for the upcoming UART driver we need a module which contains common functions for both interfaces. The module qca_framing is a good candidate but renaming to qca_common would make it clear. Signed-off-by: Stefan Wahren <stefan.wah...@i2se.com> --- drivers/net/ethernet/qu

[PATCH RFC v4 03/10] net: qualcomm: move qcaspi_tx_cmd to qca_spi.c

The function qcaspi_tx_cmd() is only called from qca_spi.c. So we better move it there. Signed-off-by: Stefan Wahren <stefan.wah...@i2se.com> --- drivers/net/ethernet/qualcomm/qca_7k.c | 24 drivers/net/ethernet/qualcomm/qca_7k.h | 1 - drivers/net/ethernet/qu

[PATCH RFC v4 08/10] net: qualcomm: add QCA7000 UART driver

This patch adds the Ethernet over UART driver for the Qualcomm QCA7000 HomePlug GreenPHY. Signed-off-by: Stefan Wahren <stefan.wah...@i2se.com> --- drivers/net/ethernet/qualcomm/Kconfig | 10 + drivers/net/ethernet/qualcomm/Makefile | 2 + drivers/net/ethernet/qualcomm/qca_co

[PATCH RFC v4 00/10] net: qualcomm: add QCA7000 UART driver

order of local variables where possible * implement basic serdev support (without hardware flow control) Changes in v3: * rebase to current net-next Changes in v2: * fix build issue by using netif_trans_update() and dev_trans_start() [1] - https://github.com/IoE/qca7000 Stefan Wahren (10

[PATCH RFC v4 02/10] net: qca_debug: use net_device_ops instead of direct call

There is no need to export qcaspi_netdev_open and qcaspi_netdev_close because they are also accessible via the net_device_ops. Signed-off-by: Stefan Wahren <stefan.wah...@i2se.com> --- drivers/net/ethernet/qualcomm/qca_debug.c | 5 +++-- drivers/net/ethernet/qualcomm/qca_spi.h | 3 --- 2

[PATCH RFC v4 05/10] net: qualcomm: prepare frame decoding for UART driver

Unfortunately the frame format is not exactly identical between SPI and UART. In case of SPI there is an additional HW length at the beginning. So store the initial state to make the decoding state machine more flexible and easy to extend for UART support. Signed-off-by: Stefan Wahren <stefan.

[PATCH RFC v4 07/10] dt-bindings: net: add binding for QCA7000 UART

This is the serdev binding for the QCA7000 UART driver (Ethernet over UART). Signed-off-by: Stefan Wahren <stefan.wah...@i2se.com> --- According to this binding are still some questions: Where should be the optional hardware flow control defined (at master or slave side)? Is it okay t

[PATCH RFC v4 09/10] tty: serdev-ttyport: return actual baudrate from ttyport_set_baudrate

Instead of returning the requested baudrate, we better return the actual one because it isn't always the same. Signed-off-by: Stefan Wahren <stefan.wah...@i2se.com> --- drivers/tty/serdev/serdev-ttyport.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/tty/

Re: usb/net/hso: WARNING: ungligned urb->setup_dma

Hi Baruch, Am 01.03.2017 um 11:54 schrieb Baruch Siach: > Hi Stefan, > > On Tue, Feb 28, 2017 at 07:32:09PM +0100, Stefan Wahren wrote: >>> Baruch Siach <bar...@tkos.co.il> hat am 28. Februar 2017 um 19:07 >>> geschrieben: >>> On Tue, Feb 28, 201

[PATCH v5 03/17] net: qca_7k: Use BIT macro

Use the BIT macro for the CONFIG and INT register values. Signed-off-by: Stefan Wahren <stefan.wah...@i2se.com> --- drivers/net/ethernet/qualcomm/qca_7k.h | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/net/ethernet/qualcomm/qca_7k.h b/drive

[PATCH v5 09/17] net: qualcomm: rename qca_framing.c to qca_7k_common.c

As preparation for the upcoming UART driver we need a module which contains common functions for both interfaces. The module qca_framing is a good candidate but renaming to qca_7k_common would make it clear. Signed-off-by: Stefan Wahren <stefan.wah...@i2se.com> --- drivers/net/ethernet/qu

[PATCH v5 11/17] net: qualcomm: make qca_7k_common a separate kernel module

In order to share common functions between QCA7000 SPI and UART protocol driver the qca_7k_common needs to be a separate kernel module. Signed-off-by: Stefan Wahren <stefan.wah...@i2se.com> --- drivers/net/ethernet/qualcomm/Kconfig | 8 +++- drivers/net/ethernet/qualcomm/Ma

[PATCH v5 04/17] net: qualcomm: use net_device_ops instead of direct call

There is no need to export qcaspi_netdev_open and qcaspi_netdev_close because they are also accessible via the net_device_ops. Signed-off-by: Stefan Wahren <stefan.wah...@i2se.com> --- drivers/net/ethernet/qualcomm/qca_debug.c | 5 +++-- drivers/net/ethernet/qualcomm/qca_spi.c

[PATCH v5 06/17] net: qca_spi: remove QCASPI_MTU

There is no need for an additional MTU define. Signed-off-by: Stefan Wahren <stefan.wah...@i2se.com> --- drivers/net/ethernet/qualcomm/qca_spi.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/ethernet/qualcomm/qca_spi.c b/drivers/net/ethernet/qu

[PATCH v5 01/17] net: qualcomm: remove unnecessary includes

Most of the includes in qca_7k.c are unnecessary so we better remove them. Signed-off-by: Stefan Wahren <stefan.wah...@i2se.com> --- drivers/net/ethernet/qualcomm/qca_7k.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/net/ethernet/qualcomm/qca_7k.c b/drivers/net/et

[PATCH v5 07/17] net: qualcomm: move qcaspi_tx_cmd to qca_spi.c

The function qcaspi_tx_cmd() is only called from qca_spi.c. So we better move it there. Signed-off-by: Stefan Wahren <stefan.wah...@i2se.com> --- drivers/net/ethernet/qualcomm/qca_7k.c | 24 drivers/net/ethernet/qualcomm/qca_7k.h | 1 - drivers/net/ethernet/qu

[PATCH v5 00/17] net: qualcomm: add QCA7000 UART driver

(without hardware flow control) Changes in v3: * rebase to current net-next Changes in v2: * fix build issue by using netif_trans_update() and dev_trans_start() [1] - https://github.com/IoE/qca7000 [2] - http://marc.info/?l=linux-serial=149338017301309=2 Stefan Wahren (17): net: qualcomm: remove

[PATCH v5 12/17] dt-bindings: qca7000-spi: Rework binding

In preparation for the QCA7000 UART binding rework the binding document. Signed-off-by: Stefan Wahren <stefan.wah...@i2se.com> --- .../devicetree/bindings/net/qca-qca7000-spi.txt| 49 +- 1 file changed, 29 insertions(+), 20 deletions(-) diff --git a/Documen

[PATCH v5 10/17] net: qualcomm: prepare frame decoding for UART driver

Unfortunately the frame format is not exactly identical between SPI and UART. In case of SPI there is an additional HW length at the beginning. So store the initial state to make the decoding state machine more flexible and easy to extend for UART support. Signed-off-by: Stefan Wahren <stefan.

[PATCH v5 08/17] net: qca_spi: Clarify MODULE_DESCRIPTION

Since this driver is specific to the QCA7000, we should make the module description more precisely. Signed-off-by: Stefan Wahren <stefan.wah...@i2se.com> --- drivers/net/ethernet/qualcomm/qca_spi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/qu

[PATCH v5 13/17] dt-bindings: qca7000: rename binding

Before we can merge the QCA7000 UART binding the document needs to be renamed. Signed-off-by: Stefan Wahren <stefan.wah...@i2se.com> --- .../devicetree/bindings/net/{qca-qca7000-spi.txt => qca-qca7000.txt} | 0 1 file changed, 0 insertions(+), 0 deletions(-) rename Documentation/d

[PATCH v5 16/17] tty: serdev-ttyport: return actual baudrate from ttyport_set_baudrate

Instead of returning the requested baudrate, we better return the actual one because it isn't always the same. Signed-off-by: Stefan Wahren <stefan.wah...@i2se.com> Acked-by: Rob Herring <r...@kernel.org> --- drivers/tty/serdev/serdev-ttyport.c | 2 +- 1 file changed, 1 insertion(+)

[PATCH v5 14/17] dt-bindings: slave-device: add current-speed property

This adds a new DT property to define the current baud rate of the slave device. Signed-off-by: Stefan Wahren <stefan.wah...@i2se.com> --- Documentation/devicetree/bindings/serial/slave-device.txt | 9 + 1 file changed, 9 insertions(+) diff --git a/Documentation/devicetree/bi

[PATCH v5 17/17] net: qualcomm: add QCA7000 UART driver

This patch adds the Ethernet over UART driver for the Qualcomm QCA7000 HomePlug GreenPHY. Signed-off-by: Stefan Wahren <stefan.wah...@i2se.com> --- drivers/net/ethernet/qualcomm/Kconfig | 16 + drivers/net/ethernet/qualcomm/Makefile| 2 + drivers/net/ethernet/qu

[PATCH v5 15/17] dt-bindings: qca7000: append UART interface to binding

This merges the serdev binding for the QCA7000 UART driver (Ethernet over UART) into the existing document. Signed-off-by: Stefan Wahren <stefan.wah...@i2se.com> --- .../devicetree/bindings/net/qca-qca7000.txt| 32 ++ 1 file changed, 32 insertions(+) diff

[PATCH v5 02/17] net: qca_framing: use u16 for frame offset

It doesn't make sense to use a signed variable for offset here, so fix it up. Signed-off-by: Stefan Wahren <stefan.wah...@i2se.com> --- drivers/net/ethernet/qualcomm/qca_framing.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/qualcomm/qca_framin

[PATCH v5 05/17] net: qualcomm: Improve readability of length defines

In order to avoid mixing things up, make the MTU and frame length defines easier to read. Signed-off-by: Stefan Wahren <stefan.wah...@i2se.com> --- drivers/net/ethernet/qualcomm/qca_framing.c | 2 +- drivers/net/ethernet/qualcomm/qca_framing.h | 8 drivers/net/ethernet/qu

Re: [PATCH] qca_debug: Reduce function calls for sequence output in qcaspi_info_show()

Am 08.05.2017 um 19:29 schrieb SF Markus Elfring: > From: Markus Elfring > Date: Mon, 8 May 2017 19:21:27 +0200 > > A bit of data was put into a sequence by separate function calls. > Print the same data together with adjusted seq_printf() calls instead. Sorry, i'm

Re: [PATCH v5 16/17] tty: serdev-ttyport: return actual baudrate from ttyport_set_baudrate

Hi Greg, Am 10.05.2017 um 10:53 schrieb Stefan Wahren: > Instead of returning the requested baudrate, we better return the > actual one because it isn't always the same. > > Signed-off-by: Stefan Wahren <stefan.wah...@i2se.com> > Acked-by: Rob Herring <r...@kernel.org>

[PATCH] net: qca_spi: Fix alignment issues in rx path

The qca_spi driver causes alignment issues on ARM devices. So fix this by using netdev_alloc_skb_ip_align(). Signed-off-by: Stefan Wahren <stefan.wah...@i2se.com> Fixes: 291ab06ecf67 ("net: qualcomm: new Ethernet over SPI driver for QCA7000") --- drivers/net/ethernet/qualcom

[PATCH v6 net-next 15/17] dt-bindings: slave-device: add current-speed property

This adds a new DT property to define the current baud rate of the slave device. Signed-off-by: Stefan Wahren <stefan.wah...@i2se.com> Reviewed-by: Rob Herring <r...@kernel.org> --- Documentation/devicetree/bindings/serial/slave-device.txt | 9 + 1 file changed, 9 inserti

[PATCH v6 net-next 05/17] net: qualcomm: use net_device_ops instead of direct call

There is no need to export qcaspi_netdev_open and qcaspi_netdev_close because they are also accessible via the net_device_ops. Signed-off-by: Stefan Wahren <stefan.wah...@i2se.com> --- drivers/net/ethernet/qualcomm/qca_debug.c | 5 +++-- drivers/net/ethernet/qualcomm/qca_spi.c

[PATCH v6 net-next 10/17] net: qualcomm: rename qca_framing.c to qca_7k_common.c

As preparation for the upcoming UART driver we need a module which contains common functions for both interfaces. The module qca_framing is a good candidate but renaming to qca_7k_common would make it clear. Signed-off-by: Stefan Wahren <stefan.wah...@i2se.com> --- drivers/net/ethernet/qu

[PATCH v6 net-next 14/17] dt-bindings: qca7000: rename binding

Before we can merge the QCA7000 UART binding the document needs to be renamed. Signed-off-by: Stefan Wahren <stefan.wah...@i2se.com> --- .../devicetree/bindings/net/{qca-qca7000-spi.txt => qca,qca7000.txt} | 0 1 file changed, 0 insertions(+), 0 deletions(-) rename Documentation/d

[PATCH v6 net-next 08/17] net: qualcomm: move qcaspi_tx_cmd to qca_spi.c

The function qcaspi_tx_cmd() is only called from qca_spi.c. So we better move it there. Signed-off-by: Stefan Wahren <stefan.wah...@i2se.com> --- drivers/net/ethernet/qualcomm/qca_7k.c | 24 drivers/net/ethernet/qualcomm/qca_7k.h | 1 - drivers/net/ethernet/qu

[PATCH v6 net-next 13/17] dt-bindings: qca7000-spi: Rework binding

In preparation for the QCA7000 UART binding rework the binding document. Signed-off-by: Stefan Wahren <stefan.wah...@i2se.com> --- .../devicetree/bindings/net/qca-qca7000-spi.txt| 49 +- 1 file changed, 29 insertions(+), 20 deletions(-) diff --git a/Documen

[PATCH v6 net-next 16/17] dt-bindings: qca7000: append UART interface to binding

This merges the serdev binding for the QCA7000 UART driver (Ethernet over UART) into the existing document. Signed-off-by: Stefan Wahren <stefan.wah...@i2se.com> --- .../devicetree/bindings/net/qca,qca7000.txt| 32 ++ 1 file changed, 32 insertions(+) diff

[PATCH v6 net-next 01/17] net: qualcomm: remove unnecessary includes

Most of the includes in qca_7k.c are unnecessary so we better remove them. Signed-off-by: Stefan Wahren <stefan.wah...@i2se.com> --- drivers/net/ethernet/qualcomm/qca_7k.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/net/ethernet/qualcomm/qca_7k.c b/drivers/net/et

[PATCH v6 net-next 02/17] net: qca_framing: use u16 for frame offset

It doesn't make sense to use a signed variable for offset here, so fix it up. Signed-off-by: Stefan Wahren <stefan.wah...@i2se.com> --- drivers/net/ethernet/qualcomm/qca_framing.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/qualcomm/qca_framin

[PATCH v6 net-next 04/17] net: qca_spi: Use SET_NETDEV_DEV()

Use SET_NETDEV_DEV() in qca_spi to create the "/sys/class/net//device" symlink. Signed-off-by: Stefan Wahren <stefan.wah...@i2se.com> --- drivers/net/ethernet/qualcomm/qca_spi.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/qualcomm/qca_spi.c b/driv

[PATCH v6 net-next 00/17] net: qualcomm: add QCA7000 UART driver

hardware flow control) Changes in v3: * rebase to current net-next Changes in v2: * fix build issue by using netif_trans_update() and dev_trans_start() [1] - https://github.com/IoE/qca7000 Stefan Wahren (17): net: qualcomm: remove unnecessary includes net: qca_framing: use u16 for frame offset

[PATCH v6 net-next 11/17] net: qualcomm: prepare frame decoding for UART driver

Unfortunately the frame format is not exactly identical between SPI and UART. In case of SPI there is an additional HW length at the beginning. So store the initial state to make the decoding state machine more flexible and easy to extend for UART support. Signed-off-by: Stefan Wahren <stefan.

[PATCH v6 net-next 06/17] net: qualcomm: Improve readability of length defines

In order to avoid mixing things up, make the MTU and frame length defines easier to read. Signed-off-by: Stefan Wahren <stefan.wah...@i2se.com> --- drivers/net/ethernet/qualcomm/qca_framing.c | 2 +- drivers/net/ethernet/qualcomm/qca_framing.h | 8 drivers/net/ethernet/qu

[PATCH v6 net-next 07/17] net: qca_spi: remove QCASPI_MTU

There is no need for an additional MTU define. Signed-off-by: Stefan Wahren <stefan.wah...@i2se.com> --- drivers/net/ethernet/qualcomm/qca_spi.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/ethernet/qualcomm/qca_spi.c b/drivers/net/ethernet/qu

[PATCH v6 net-next 03/17] net: qca_7k: Use BIT macro

Use the BIT macro for the CONFIG and INT register values. Signed-off-by: Stefan Wahren <stefan.wah...@i2se.com> --- drivers/net/ethernet/qualcomm/qca_7k.h | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/net/ethernet/qualcomm/qca_7k.h b/drive

[PATCH v6 net-next 09/17] net: qca_spi: Clarify MODULE_DESCRIPTION

Since this driver is specific to the QCA7000, we should make the module description more precisely. Signed-off-by: Stefan Wahren <stefan.wah...@i2se.com> --- drivers/net/ethernet/qualcomm/qca_spi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/qu

[PATCH v6 net-next 12/17] net: qualcomm: make qca_7k_common a separate kernel module

In order to share common functions between QCA7000 SPI and UART protocol driver the qca_7k_common needs to be a separate kernel module. Signed-off-by: Stefan Wahren <stefan.wah...@i2se.com> --- drivers/net/ethernet/qualcomm/Kconfig | 8 +++- drivers/net/ethernet/qualcomm/Ma

[PATCH v6 net-next 17/17] net: qualcomm: add QCA7000 UART driver

This patch adds the Ethernet over UART driver for the Qualcomm QCA7000 HomePlug GreenPHY. Signed-off-by: Stefan Wahren <stefan.wah...@i2se.com> --- drivers/net/ethernet/qualcomm/Kconfig | 16 + drivers/net/ethernet/qualcomm/Makefile| 2 + drivers/net/ethernet/qu

[PATCH RESEND v7 net-next 17/17] net: qualcomm: add QCA7000 UART driver

This patch adds the Ethernet over UART driver for the Qualcomm QCA7000 HomePlug GreenPHY. Signed-off-by: Stefan Wahren <stefan.wah...@i2se.com> --- drivers/net/ethernet/qualcomm/Kconfig | 16 + drivers/net/ethernet/qualcomm/Makefile| 2 + drivers/net/ethernet/qu

[PATCH v7 net-next 17/17] net: qualcomm: add QCA7000 UART driver

This patch adds the Ethernet over UART driver for the Qualcomm QCA7000 HomePlug GreenPHY. Signed-off-by: Stefan Wahren <stefan.wah...@i2se.com> --- drivers/net/ethernet/qualcomm/Kconfig | 16 + drivers/net/ethernet/qualcomm/Makefile| 2 + drivers/net/ethernet/qu

Re: [PATCH RESEND v7 net-next 17/17] net: qualcomm: add QCA7000 UART driver

Am 24.05.2017 um 16:21 schrieb Lino Sanfilippo: > Hi, > > >> This patch adds the Ethernet over UART driver for the >> Qualcomm QCA7000 HomePlug GreenPHY. >> >> Signed-off-by: Stefan Wahren <stefan.wah...@i2se.com> >> --- > Reviewed-by: Lino Sanfilippo <linosanfili...@gmx.de> > Thanks Stefan

Re: [PATCH v6 net-next 17/17] net: qualcomm: add QCA7000 UART driver

> Lino Sanfilippo <linosanfili...@gmx.de> hat am 23. Mai 2017 um 20:16 > geschrieben: > > > Hi, > > On 23.05.2017 15:12, Stefan Wahren wrote: > > > > +} > > + > > +static void qca_uart_remove(struct serdev_device *serdev) > > +{ >

[PATCH v8 net-next 08/17] net: qualcomm: move qcaspi_tx_cmd to qca_spi.c

The function qcaspi_tx_cmd() is only called from qca_spi.c. So we better move it there. Signed-off-by: Stefan Wahren <stefan.wah...@i2se.com> --- drivers/net/ethernet/qualcomm/qca_7k.c | 24 drivers/net/ethernet/qualcomm/qca_7k.h | 1 - drivers/net/ethernet/qu

[PATCH v8 net-next 07/17] net: qca_spi: remove QCASPI_MTU

There is no need for an additional MTU define. Signed-off-by: Stefan Wahren <stefan.wah...@i2se.com> --- drivers/net/ethernet/qualcomm/qca_spi.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/ethernet/qualcomm/qca_spi.c b/drivers/net/ethernet/qu

[PATCH v8 net-next 01/17] net: qualcomm: qca_7k: clean up header includes

Currently the includes doesn't reflect the dependencies. So fix this up by removing all unnecessary entries and add the necessary ones explicit. Signed-off-by: Stefan Wahren <stefan.wah...@i2se.com> --- drivers/net/ethernet/qualcomm/qca_7k.c | 6 ++ 1 file changed, 2 insertions

[PATCH v8 net-next 17/17] net: qualcomm: add QCA7000 UART driver

This patch adds the Ethernet over UART driver for the Qualcomm QCA7000 HomePlug GreenPHY. Signed-off-by: Stefan Wahren <stefan.wah...@i2se.com> Reviewed-by: Lino Sanfilippo <linosanfili...@gmx.de> --- drivers/net/ethernet/qualcomm/Kconfig | 16 + drivers/net/ethernet/qualc

  1   2   >