Re: [ovs-dev] [PATCH net-next] NSH(Network Service Header) implementation

On Mon, Jun 06, 2016 at 05:45:08PM -0700, pravin shelar wrote: > On Mon, Jun 6, 2016 at 2:34 AM, Yi Yang wrote: > > IETF defined NSH(Network Service Header) for Service > > Function Chaining, this is an IETF draft > > > > https://tools.ietf.org/html/draft-ietf-sfc-nsh-05 > >

Re: [ovs-dev] [PATCH net-next] NSH(Network Service Header) implementation

On Mon, Jun 13, 2016 at 12:11:14PM +0200, Jiri Benc wrote: > On Sun, 12 Jun 2016 15:53:50 +0800, Yang, Yi wrote: > > Will use net device after those patches are merged into net-next, It > > seems current net device implementation in net-next doesn't include it, > > The curre

Re: [PATCH net-next] openvswitch: fix VxLAN-gpe port can't be created in ovs compat mode

On Thu, Dec 08, 2016 at 12:37:56PM +0100, Jiri Benc wrote: > On Thu, 8 Dec 2016 18:57:51 +0800, Yang, Yi wrote: > > So ovs out of tree modules need to adapt to upstream kernel, any > > kernel-related changes must be accepted by Linux kernel at first. > > I'm perfectly aware o

Re: [PATCH net-next] openvswitch: fix VxLAN-gpe port can't be created in ovs compat mode

On Thu, Dec 08, 2016 at 09:54:00AM +0100, Jiri Benc wrote: > On Thu, 8 Dec 2016 16:20:10 +0800, Yi Yang wrote: > > In ovs compat mode, ovs won't use LWT in current kernel, this is to > > make sure ovs can work on the old kernels, Linux kernel v4.7 includes > > VxLAN-gpe support but many Linux

Re: [PATCH net-next] openvswitch: fix VxLAN-gpe port can't be created in ovs compat mode

On Thu, Dec 08, 2016 at 11:41:58AM -0800, Pravin Shelar wrote: > On Thu, Dec 8, 2016 at 12:20 AM, Yi Yang wrote: > > > > Signed-off-by: Yi Yang > > --- > > include/uapi/linux/openvswitch.h | 1 + > > net/openvswitch/vport-vxlan.c| 15

Re: [PATCH v3] openvswitch: enable NSH support

On Wed, Aug 16, 2017 at 11:19:21AM +0200, Jiri Benc wrote: > Please always CC reviewers of the previous versions, thanks. Jiri, thank you for quick review. Sorry, I made a mistake on sending and missed all the CCs, will indeed do this in next version. > > + __be16 ver_flags_len; > > + u8

Re: [PATCH net-next v2] openvswitch: enable NSH support

On Tue, Aug 15, 2017 at 12:09:14AM +0800, Eric Garver wrote: > On Thu, Aug 10, 2017 at 09:21:15PM +0800, Yi Yang wrote: > > Hi Yi, > > In general I'd like to echo Jiri's comments on the netlink attributes. > I'd like to see the metadata separate. > > I have a few other comments below. > >

Re: [PATCH net-next v2] openvswitch: enable NSH support

On Fri, Aug 11, 2017 at 10:24:18AM +0200, Jiri Benc wrote: > On Thu, 10 Aug 2017 21:21:15 +0800, Yi Yang wrote: > > OVS master and 2.8 branch has merged NSH userspace > > patch series, this patch is to enable NSH support > > in kernel data path in order that OVS can support > > NSH in 2.8 release

Re: [PATCH net-next v2] openvswitch: enable NSH support

On Fri, Aug 11, 2017 at 11:44:49AM +0200, Jiri Benc wrote: > On Fri, 11 Aug 2017 09:24:25 +0000, Yang, Yi Y wrote: > > So far, we're not clear how we can support MD type 2 better, as I > > explained before, we need to reuse tun_metadata in struct flow_tnl > > which is the

Re: [PATCH v3] openvswitch: enable NSH support

On Wed, Aug 16, 2017 at 11:15:28PM +0800, Eric Garver wrote: > On Wed, Aug 16, 2017 at 01:35:30PM +0800, Yi Yang wrote: > > + > > +#define NSH_DST_PORT4790 /* UDP Port for NSH on VXLAN. */ > > +#define ETH_P_NSH 0x894F /* Ethertype for NSH. */ > > ETH_P_NSH probably belongs in

Re: [PATCH v3] openvswitch: enable NSH support

On Wed, Aug 16, 2017 at 10:03:22PM +0800, Jiri Benc wrote: > On Wed, 16 Aug 2017 17:31:30 +0800, Yang, Yi wrote: > > On Wed, Aug 16, 2017 at 11:19:21AM +0200, Jiri Benc wrote: > > > > --- a/include/uapi/linux/openvswitch.h > > > > +++ b/include/uapi/linux/openvswit

Re: [PATCH net-next v4] openvswitch: enable NSH support

On Fri, Aug 18, 2017 at 09:26:01PM +0800, Jiri Benc wrote: > On Fri, 18 Aug 2017 15:24:31 +0800, Yi Yang wrote: > > +struct nsh_md2_tlv { > > + __be16 md_class; > > + u8 type; > > + u8 length; > > + /* Followed by variable-length data. */ > > +}; > > What was wrong with the u8[] field

Re: [PATCH net-next v9] openvswitch: enable NSH support

On Thu, Sep 14, 2017 at 05:09:02PM +0800, Jiri Benc wrote: > On Thu, 14 Sep 2017 16:37:59 +0800, Yi Yang wrote: > > OVS master and 2.8 branch has merged NSH userspace > > patch series, this patch is to enable NSH support > > in kernel data path in order that OVS can support > > NSH in compat mode

Re: [PATCH net-next 0/4] nsh: headers, GSO

On Wed, Aug 30, 2017 at 06:17:07AM +0800, David Miller wrote: > From: Jiri Benc > Date: Mon, 28 Aug 2017 21:43:20 +0200 > > > This adds header structs and helpers for NSH together with GSO support. > > > > Note there is no code in this patchset that actually manipulates the

Re: [PATCH net-next 0/4] nsh: headers, GSO

On Wed, Aug 30, 2017 at 09:20:40AM +0200, Jiri Benc wrote: > > > I'll post new OVS NSH kernel datapath patch series if NSH GSO is done. > > Please do. Note that it's important to ensure that whenever there's a > NSH header added, the nsh module gets loaded. The easiest way is to > factor out

Re: [PATCH net-next v7] openvswitch: enable NSH support

On Mon, Sep 04, 2017 at 08:57:44PM +0800, Jiri Benc wrote: > On Mon, 4 Sep 2017 20:09:07 +0800, Yang, Yi wrote: > > So we must do many changes if we want to break this assumption. > > We may do as many changes as we want to. This is uAPI we're talking > about and we need to

Re: [PATCH net-next v6 3/3] openvswitch: enable NSH support

On Tue, Sep 05, 2017 at 09:12:09PM +0800, Hannes Frederic Sowa wrote: > "Yang, Yi" <yi.y.y...@intel.com> writes: > > > We can change this later if we really find a better way to handle this > > because it isn't defined in include/uapi/linux/openvswitch.h,

Re: [PATCH net-next v6 3/3] openvswitch: enable NSH support

On Wed, Sep 06, 2017 at 04:03:29PM +0800, Hannes Frederic Sowa wrote: > "Yang, Yi" <yi.y.y...@intel.com> writes: > >> > >> > If you check GENEVE implementation, tun_metadata* can be set or matched > >> > as any other match field. > >>

Re: [PATCH net-next v7] openvswitch: enable NSH support

On Mon, Sep 04, 2017 at 06:42:16PM +0800, Jiri Benc wrote: > On Mon, 4 Sep 2017 16:00:05 +0800, Yang, Yi wrote: > > how can we know next push_nsh uses the same nsh header as previous > > one? > > We store the prepopulated header together with the action. > I checked so

Re: [PATCH net-next v7] openvswitch: enable NSH support

On Thu, Aug 31, 2017 at 06:45:16PM +0800, Jiri Benc wrote: > On Wed, 30 Aug 2017 20:39:12 +0800, Yi Yang wrote: > > + nsh->md1.context[i] = > > + OVS_MASKED(nsh->md1.context[i], key->context[i], > > + mask->context[i]); > > +

Re: [ovs-dev] [PATCH net-next v9] openvswitch: enable NSH support

On Wed, Sep 27, 2017 at 04:59:36AM +0800, Eric Garver wrote: > On Tue, Sep 26, 2017 at 01:02:15PM +0800, Yang, Yi wrote: > > On Tue, Sep 26, 2017 at 03:28:42AM +0800, Eric Garver wrote: > > > On Mon, Sep 25, 2017 at 10:16:09PM +0800, Yi Yang wrote: > > > > + > &

Re: [PATCH net-next v10] openvswitch: enable NSH support

On Tue, Sep 26, 2017 at 10:42:40PM +0800, Jiri Benc wrote: > On Tue, 26 Sep 2017 21:52:41 +0800, Yang, Yi wrote: > > > + return ((ret != 0) ? false : true); > > > > But I don't think this is a problematic line from my understanding, > > Why not: > >

Re: [PATCH net-next v9] openvswitch: enable NSH support

On Tue, Sep 26, 2017 at 06:49:14PM +0800, Jiri Benc wrote: > On Tue, 26 Sep 2017 12:55:39 +0800, Yang, Yi wrote: > > After push_nsh, the packet won't be recirculated to flow pipeline, so > > key->eth.type must be set explicitly here, but for pop_nsh, the packet > > will

Re: [PATCH net-next v9] openvswitch: enable NSH support

On Tue, Sep 26, 2017 at 02:14:39AM +0800, Jiri Benc wrote: > On Mon, 25 Sep 2017 22:16:09 +0800, Yi Yang wrote: > > + return err; > > + > > + key->eth.type = htons(ETH_P_NSH); > > I wonder why you have this assignment here. The key is invalidated, > thus nothing should rely on

Re: [ovs-dev] [PATCH net-next v9] openvswitch: enable NSH support

On Tue, Sep 26, 2017 at 03:28:42AM +0800, Eric Garver wrote: > On Mon, Sep 25, 2017 at 10:16:09PM +0800, Yi Yang wrote: > > + > > + length = nsh_hdr_len(nsh_hdr); > > + skb_pull(skb, length); > > Do you need to verify you can actually pull length bytes? I don't see > any guarantee. I have

Re: [PATCH net-next v10] openvswitch: enable NSH support

On Tue, Sep 26, 2017 at 07:05:34PM +0800, Jiri Benc wrote: > On Tue, 26 Sep 2017 12:47:16 +0800, Yi Yang wrote: > > + return ((ret != 0) ? false : true); Jiri, I appriciate your review very carefully and professionally from my heart for 10 versions, that is really very very big effort. I

Re: [PATCH net-next v9] openvswitch: enable NSH support

On Fri, Sep 29, 2017 at 07:10:52AM +, Jan Scheurich wrote: > > From: Yang, Yi [mailto:yi.y.y...@intel.com] > > Sent: Friday, 29 September, 2017 08:41 > > To: Pravin Shelar <pshe...@ovn.org> > > Cc: Jiri Benc <jb...@redhat.com>; netdev@vger.kernel.org; &g

Re: [PATCH net-next v9] openvswitch: enable NSH support

On Fri, Sep 29, 2017 at 02:28:38AM +0800, Pravin Shelar wrote: > On Tue, Sep 26, 2017 at 6:39 PM, Yang, Yi <yi.y.y...@intel.com> wrote: > > On Tue, Sep 26, 2017 at 06:49:14PM +0800, Jiri Benc wrote: > >> On Tue, 26 Sep 2017 12:55:39 +0800, Yang, Yi wrote: > >> &

Re: [PATCH net-next v4] openvswitch: enable NSH support

On Mon, Aug 21, 2017 at 05:47:13PM +0800, Jiri Benc wrote: > On Mon, 21 Aug 2017 17:15:42 +0800, Yang, Yi wrote: > > The issue is it is used union in > > > > struct nsh_hdr { > > ovs_be16 ver_flags_ttl_len; > > uint8_t md_type; > > uint8_t

Re: [PATCH net-next v4] openvswitch: enable NSH support

On Sat, Aug 19, 2017 at 03:09:47AM +0800, Eric Garver wrote: > On Fri, Aug 18, 2017 at 03:24:31PM +0800, Yi Yang wrote: > > v3->v4 > > - Add new NSH match field ttl > > - Update NSH header to the latest format > >which will be final format and won't change > >per its author's

Re: [PATCH net-next v4] openvswitch: enable NSH support

On Fri, Aug 18, 2017 at 09:31:03PM +0800, Jiri Benc wrote: > On Fri, 18 Aug 2017 15:26:01 +0200, Jiri Benc wrote: > > Out of time for today, will continue the review next week. Again, feel > > free to send a new version meanwhile or wait for the rest of the > > review, whatever works better for

Re: [PATCH net-next v5] openvswitch: enable NSH support

On Mon, Aug 21, 2017 at 10:25:09AM +0200, Jiri Benc wrote: > On Mon, 21 Aug 2017 13:54:23 +0800, Yi Yang wrote: > > v4->v5 > > - Fix many comments by Jiri Benc and Eric Garver > >for v4. > > NACK for v5, we haven't finished discussing v4. You're sending new > versions too quickly. > > My

Re: [PATCH net-next v4] openvswitch: enable NSH support

On Mon, Aug 21, 2017 at 11:18:54AM +0200, Jiri Benc wrote: > On Mon, 21 Aug 2017 16:39:01 +0800, Yang, Yi wrote: > > Anyway, we need to keep the code in userspace consistent with the one in > > kernel as possible as, otherwise it will be a burden for developer, I > > know us

Re: [PATCH net-next v4] openvswitch: enable NSH support

On Mon, Aug 21, 2017 at 10:19:24AM +0200, Jiri Benc wrote: > On Mon, 21 Aug 2017 14:11:10 +0800, Yang, Yi wrote: > > In OVS code, it has been removed because of Microsoft compiler issue. > > We absolutely, completely and utterly do not care in the kernel. Please > never m

Re: [PATCH net-next v4] openvswitch: enable NSH support

On Mon, Aug 21, 2017 at 05:47:13PM +0800, Jiri Benc wrote: > > > I don't know how we can support this, is it a must-have thing? > > What would happen if you get a GSO packet? Ports of an ovs bridge claim > GSO support, thus they may get a GSO packet. You have to handle it one > way or the other:

Re: [PATCH net-next v1] net: gso: Add GSO support for NSH (Network Service Header)

On Thu, Aug 24, 2017 at 10:13:26PM +0800, Jiri Benc wrote: > On Thu, 24 Aug 2017 17:36:16 +0800, Yi Yang wrote: > > include/net/nsh.h | 307 > > ++ > > include/uapi/linux/if_ether.h | 1 + > > net/Kconfig | 1 + > >

Re: [PATCH net-next v7] openvswitch: enable NSH support

On Mon, Sep 04, 2017 at 12:42:16PM +0200, Jiri Benc wrote: > On Mon, 4 Sep 2017 16:00:05 +0800, Yang, Yi wrote: > > I think we have had similiar discussion about this, the issue is we have > > no way to handle both MD type 1 and MD type 2 by using a common flow key > > struct

Re: [PATCH net-next v7] openvswitch: enable NSH support

On Thu, Aug 31, 2017 at 06:45:16PM +0800, Jiri Benc wrote: > > + mask->context[i]); > > + } > > + memcpy(flow_key->nsh.context, nsh->md1.context, > > + sizeof(nsh->md1.context)); > > Do you follow the discussion that Hannes

Re: [PATCH net-next v6 3/3] openvswitch: enable NSH support

On Wed, Aug 30, 2017 at 05:53:27PM +0800, Hannes Frederic Sowa wrote: > Hello, > > Yi Yang writes: > > [...] > > > +struct ovs_key_nsh { > > + u8 flags; > > + u8 ttl; > > + u8 mdtype; > > + u8 np; > > + __be32 path_hdr; > > + __be32

Re: [PATCH net-next v6 3/3] openvswitch: enable NSH support

On Mon, Sep 04, 2017 at 07:22:26PM +0800, Hannes Frederic Sowa wrote: > Hello, > > "Yang, Yi" <yi.y.y...@intel.com> writes: > > > On Wed, Aug 30, 2017 at 05:53:27PM +0800, Hannes Frederic Sowa wrote: > >> Hello, >

Re: [PATCH net-next v6 3/3] openvswitch: enable NSH support

On Tue, Sep 05, 2017 at 12:30:09PM +0200, Hannes Frederic Sowa wrote: > "Yang, Yi" <yi.y.y...@intel.com> writes: > > > I'm not sure what new action you expect to bring here, I think group > > action is just for this, as you said it isn't only bound to N

Re: [PATCH net-next v7] openvswitch: enable NSH support

On Tue, Sep 05, 2017 at 11:47:41AM +0200, Jiri Benc wrote: > On Tue, 5 Sep 2017 14:37:05 +0800, Yang, Yi wrote: > > I checked source code but can't find where we can prepopulate it and how > > we can deliver the prepopulated header to push_nsh, can you expand it in > > orde

Re: [PATCH net-next v7] openvswitch: enable NSH support

On Tue, Sep 05, 2017 at 11:46:45AM +0200, Jiri Benc wrote: > On Tue, 5 Sep 2017 13:51:45 +0800, Yang, Yi wrote: > > But if we follow your way, how does nla_for_each_nested handle such > > pattern? > > > > attribute1 > > attribute1_mask > > attrib

Re: [PATCH net-next v11] openvswitch: enable NSH support

On Tue, Oct 03, 2017 at 03:13:08AM +0800, Jiri Benc wrote: > On Fri, 29 Sep 2017 15:03:30 +0800, Yi Yang wrote: > > --- a/include/net/nsh.h > > +++ b/include/net/nsh.h > > @@ -304,4 +304,7 @@ static inline void nsh_set_flags_ttl_len(struct nshhdr > > *nsh, u8 flags, > >

Re: [PATCH net-next v12] openvswitch: enable NSH support

On Thu, Oct 19, 2017 at 05:19:55AM +0800, Jiri Benc wrote: > On Mon, 16 Oct 2017 21:53:29 +0800, Yi Yang wrote: > > +static int set_nsh(struct sk_buff *skb, struct sw_flow_key *flow_key, > > + const struct nlattr *a) > > +{ > > + struct nshhdr *nh; > > + size_t length; > > + int

Re: [PATCH net-next v15] openvswitch: enable NSH support

On Sat, Nov 04, 2017 at 10:29:46PM +0800, Pravin Shelar wrote: > On Tue, Oct 31, 2017 at 9:03 PM, Yi Yang wrote: > > +int nsh_push(struct sk_buff *skb, const struct nshhdr *pushed_nh) > > +{ > > + struct nshhdr *nh; > > + size_t length = nsh_hdr_len(pushed_nh); >

Re: [PATCH net-next v15] openvswitch: enable NSH support

On Thu, Nov 02, 2017 at 08:52:40AM +0800, Pravin Shelar wrote: > On Tue, Oct 31, 2017 at 9:03 PM, Yi Yang wrote: > > > > OVS master and 2.8 branch has merged NSH userspace > > patch series, this patch is to enable NSH support > > in kernel data path in order that OVS can

Re: [PATCH net-next v15] openvswitch: enable NSH support

On Thu, Nov 02, 2017 at 05:06:47AM -0700, Pravin Shelar wrote: > On Wed, Nov 1, 2017 at 7:50 PM, Yang, Yi <yi.y.y...@intel.com> wrote: > > On Thu, Nov 02, 2017 at 08:52:40AM +0800, Pravin Shelar wrote: > >> On Tue, Oct 31, 2017 at 9:03 PM, Yi Yang <yi.y.y...@intel.co

Re: [PATCH net-next v15] openvswitch: enable NSH support

On Tue, Nov 07, 2017 at 06:57:30PM +0800, Pravin Shelar wrote: > On Mon, Nov 6, 2017 at 4:22 AM, Jiri Benc wrote: > > On Sat, 4 Nov 2017 07:29:46 -0700, Pravin Shelar wrote: > >> > +int nsh_push(struct sk_buff *skb, const struct nshhdr *pushed_nh) > >> > +{ > >> > + struct

Re: [PATCH net-next v15] openvswitch: enable NSH support

On Tue, Nov 07, 2017 at 03:58:35AM -0800, Pravin Shelar wrote: > On Tue, Nov 7, 2017 at 3:28 AM, Yang, Yi <yi.y.y...@intel.com> wrote: > > On Tue, Nov 07, 2017 at 06:57:30PM +0800, Pravin Shelar wrote: > >> On Mon, Nov 6, 2017 at 4:22 AM, Jiri Benc <jb...@redhat.com&g

Re: [PATCH net-next v15] openvswitch: enable NSH support

On Tue, Nov 07, 2017 at 05:01:28AM -0800, Pravin Shelar wrote: > On Tue, Nov 7, 2017 at 3:55 AM, Yang, Yi <yi.y.y...@intel.com> wrote: > > On Tue, Nov 07, 2017 at 03:58:35AM -0800, Pravin Shelar wrote: > >> On Tue, Nov 7, 2017 at 3:28 AM, Yang, Yi <yi.y.y...@intel.com>

Re: [PATCH net-next v15] openvswitch: enable NSH support

On Thu, Nov 02, 2017 at 05:06:47AM -0700, Pravin Shelar wrote: > On Wed, Nov 1, 2017 at 7:50 PM, Yang, Yi <yi.y.y...@intel.com> wrote: > > On Thu, Nov 02, 2017 at 08:52:40AM +0800, Pravin Shelar wrote: > >> On Tue, Oct 31, 2017 at 9:03 PM, Yi Yang <yi.y.y...@intel.co

Re: [PATCH net-next v13] openvswitch: enable NSH support

On Mon, Oct 30, 2017 at 10:01:34AM +0900, David Miller wrote: > From: Yi Yang > Date: Thu, 26 Oct 2017 15:45:16 +0800 > > > OVS master and 2.8 branch has merged NSH userspace > > patch series, this patch is to enable NSH support > > in kernel data path in order that OVS can

Re: [PATCH net-next v14] openvswitch: enable NSH support

On Wed, Nov 01, 2017 at 03:57:41AM +0800, Eric Garver wrote: > On Mon, Oct 30, 2017 at 09:29:34AM +0800, Yi Yang wrote: > [...] > > +int nsh_pop(struct sk_buff *skb) > > +{ > > + struct nshhdr *nh; > > + size_t length; > > + __be16 inner_proto; > > + > > + if (!pskb_may_pull(skb,

Re: [PATCH net-next v14] openvswitch: enable NSH support

On Wed, Nov 01, 2017 at 04:08:22AM +0800, Jiri Benc wrote: > On Mon, 30 Oct 2017 09:29:34 +0800, Yi Yang wrote: > > +static int set_nsh(struct sk_buff *skb, struct sw_flow_key *flow_key, > > + const struct nlattr *a) > > +{ > > + struct nshhdr *nh; > > + size_t length; > > + int

Re: [PATCH net-next v12] openvswitch: enable NSH support

On Thu, Oct 19, 2017 at 02:43:47PM +0200, Jiri Benc wrote: > On Thu, 19 Oct 2017 19:40:53 +0800, Yang, Yi wrote: > > Actually mdtype can't be set, only push_nsh can set mdtype, so set_nsh > > won't have mdtype flow key, we can't get it from flow_key in set_nsh, > > only ttl, f

Re: [PATCH net-next v12] openvswitch: enable NSH support

On Thu, Oct 19, 2017 at 03:41:18PM +0200, Jiri Benc wrote: > On Thu, 19 Oct 2017 21:12:15 +0800, Yang, Yi wrote: > > flow_key in set_nsh is got from netlink message which is set by > > commit_nsh in user space, here is code. > > Isn't this the 'key' local variable that you're

Re: [PATCH net-next v12] openvswitch: enable NSH support

On Fri, Oct 20, 2017 at 04:05:35PM +0800, Jiri Benc wrote: > On Fri, 20 Oct 2017 05:53:12 +0800, Yang, Yi wrote: > > For push_nsh, my typical use scinario is push_nsh then set then output > > to vxlangpe port. > > Okay. Then I just need to do the below change against v

RE: [ovs-dev] [PATCH v9 net-next 4/7] openvswitch: add layer 3 flow/port support

I think it is still necessary to keep eth_type in push_eth action, for the classifier case, it will push_nsh then push_eth for the original frame, this will need to set eth_type to 0x894f by push_eth, otherwise push_eth won't know this eth_type. -Original Message- From: dev

RE: [ovs-dev] [PATCH net-next v13 0/8] openvswitch: support for layer 3 encapsulated packets

Got it, thanks, I'll follow your discussion thread. -Original Message- From: Thadeu Lima de Souza Cascardo [mailto:casca...@cascardo.eti.br] Sent: Wednesday, November 16, 2016 3:01 AM To: Yang, Yi Y <yi.y.y...@intel.com>; Jiri Benc <jb...@redhat.com>; netdev@vger.kern

RE: [PATCH net-next v13 0/8] openvswitch: support for layer 3 encapsulated packets

Hi, Jiri I'm very glad to see you're continuing this work :-), I asked Simon about this twice, but nobody replies. I also remember Cascardo has a patch set to collaborate with this patch set, I asked Cascardo, but nobody responds, will you continue to do Cascardo's " create tunnel devices

RE: [PATCH net-next v2] openvswitch: enable NSH support

is not tunnel, so it has to be changed to support both Geneve and NSH. Anyway, they won't be part of ovs_key_nsh. -Original Message- From: netdev-ow...@vger.kernel.org [mailto:netdev-ow...@vger.kernel.org] On Behalf Of Jiri Benc Sent: Friday, August 11, 2017 5:11 PM To: Yang, Yi Y <yi.

RE: [PATCH net-next] openvswitch: add NSH support

of the header. Again, OVS userspace code must be consistent with here, so keeping it intact will be better because OVS userspace code was there. -Original Message- From: netdev-ow...@vger.kernel.org [mailto:netdev-ow...@vger.kernel.org] On Behalf Of Jiri Benc Sent: Tuesday, August 8, 2017

RE: [ovs-dev] [PATCH net-next] openvswitch: add NSH support

mdlen, 4); +pad_len = size - sizeof(struct ovs_action_encap_nsh) + - encap_nsh->mdlen; +if (pad_len > 0) { + memset(encap_nsh->metadata + encap_nsh->mdlen, 0, pad_len); +} +nl_msg_put_unspec(odp_actions, OVS_ACTION_ATTR_ENCAP_NSH, encap_nsh,

RE: [ovs-dev] [PATCH net-next] openvswitch: add NSH support

in struct ovs_action_encap_nsh? I mean how we handle the arguments for function encap_nsh. -Original Message- From: netdev-ow...@vger.kernel.org [mailto:netdev-ow...@vger.kernel.org] On Behalf Of Ben Pfaff Sent: Thursday, August 10, 2017 2:09 AM To: Yang, Yi Y <yi.y.y...@intel.com> C

RE: [ovs-dev] [PATCH net-next] openvswitch: add NSH support

- From: Ben Pfaff [mailto:b...@ovn.org] Sent: Thursday, August 10, 2017 4:54 AM To: Yang, Yi Y <yi.y.y...@intel.com> Cc: Jan Scheurich <jan.scheur...@ericsson.com>; d...@openvswitch.org; netdev@vger.kernel.org; Jiri Benc <jb...@redhat.com>; da...@davemloft.net; Zoltán