GOTO_CHAIN(maybe 0x2)
and the rest "XXX" is a free floating parameter values
which carry the goto count for ACT_JUMP and GOTO_CHAIN chain-id.
That is exactly what this patch is doing.
You are right, sorry ;->
cheers,
jamal
On 17-05-01 09:58 AM, Benjamin LaHaise wrote:
Since several of the the netlink attributes used to configure the flower
classifier's MPLS TC, BOS and Label fields have additional bits which are
unused, check those bits to ensure that they are actually 0 as suggested
by Jamal.
Signed-off
On 17-05-01 06:36 AM, Simon Horman wrote:
On Sun, Apr 30, 2017 at 09:51:30AM -0400, Jamal Hadi Salim wrote:
On 17-04-28 10:14 AM, Simon Horman wrote:
[..]
minimal some flag should qualify it as "truncated".
Would changing TCA_FLOWER_HEADER_PARSE_ERR_ACT to
TCA_FLOWER_META_TRUN
On 17-04-30 09:51 AM, Jamal Hadi Salim wrote:
[..]
1. As things stand, without this patch-set, flower does not differentiate
between a packet truncated at the end of the IP header and a packet
with
zero ports. Likewise for icmp type and code of zero.
The first three patches
From: Jamal Hadi Salim <j...@mojatatu.com>
Generic bitflags attribute content sent to the kernel by user.
With this type the user can either set or unset a flag in the
kernel.
The nla_flag_values is a bitmap that defines the values being set
The nla_flag_selector is a bitmask that defines
ry the goto count for ACT_JUMP and GOTO_CHAIN chain-id.
cheers,
jamal
On 17-04-28 12:13 PM, Jiri Pirko wrote:
From: Jiri Pirko <j...@mellanox.com>
Jump is now the only one using value action opcode. This is going to
change soon. So introduce helpers to work with this. Convert TC_ACT_JUMP.
Signed-o
On 17-04-28 10:14 AM, Simon Horman wrote:
On Fri, Apr 28, 2017 at 09:41:00AM -0400, Jamal Hadi Salim wrote:
On 17-04-28 09:11 AM, Simon Horman wrote:
[..]
A default lower prio match all on udp or icmp?
I'm certainly not opposed to exploring ideas here.
The way that flower currently works
will have chainlimit 0x1000-1
If you pick a range to own (one that is not being used)
like 0x2000 then chain limit starts at 0x2001
to some upper bound. I dont know if you need all the range,
but if you put upper bound to 0x2FFF that is a few
million.
cheers,
jamal
,
jamal
LAGS which is re-usable elsewhere?
Exactly. That's what I'm saying.
If you want to make it general:
I see the semantics of this thing as more detailed than what I had.
It would have a u32 bitmap + u32 bitmask.
cheers,
jamal
On 17-04-28 09:11 AM, Simon Horman wrote:
On Fri, Apr 28, 2017 at 08:52:56AM -0400, Jamal Hadi Salim wrote:
On 17-04-28 08:00 AM, Simon Horman wrote:
Hi,
this series is intended to avoid false-positives which match
truncated packets against flower classifiers which match on:
* zero L4 ports
neering (A lot of new things on my patchset).
Jiri, could this come in your cleanups later?
cheers,
jamal
should be present (according to skb_flow_get_ports()).
I think i understand the use case/need.
But would it be fair to say that the truncated vs non-truncated are two
different filter rules? Example what would offloading of
header_parse_err_action mean?
cheers,
jamal
t
have any semantics with NLA_FLAGS flags, which eventually will carry
the exact same u32, but with predefined semantics, helpers, everything.
I didnt understand fully Jiri. Are you suggesting a new type called
NLA_FLAGS which is re-usable elsewhere?
cheers,
jamal
action police
if exceed
goto chain 12
else did not exceed
tag packet, goto chain 11
"
But it is not just the policer, other actions as well would benefit.
I am not sure you can achieve that with just gact.
cheers,
jamal
Attached.
Needs some cleanup and more testing (I only tested a few of these
actions - should work, just need to vet before official submission).
cheers,
jamal
diff --git a/tc/m_connmark.c b/tc/m_connmark.c
index 295f90d..bdb6195 100644
--- a/tc/m_connmark.c
+++ b/tc/m_connmark.c
@@ -81,7 +81,7
is encoding of chain 1 etc.
I will post the iproute2 code i used for jumping of actions.
cheers,
jamal
On 17-04-27 07:12 AM, Jiri Pirko wrote:
From: Jiri Pirko <j...@mellanox.com>
Introduce new type of gact action called "goto_chain". This allows
user to specify a chain
. I am not sure the
"actions dump large messages" is a fit for that level.
Jamal, the idea is to have exactly what you want to have. Only does not
use NLA_U32 attr for that but a special attr NLA_FLAGS which would have
well defined semantics and set of helpers to work with a
ent hierarchy level. I am not sure the
"actions dump large messages" is a fit for that level.
cheers,
jamal
On 17-04-26 09:17 AM, Jamal Hadi Salim wrote:
On 17-04-26 09:08 AM, Jiri Pirko wrote:
Wed, Apr 26, 2017 at 02:42:17PM CEST, j...@mojatatu.com wrote:
+#define VALID_TCA_ROOT_FLAGS TCA_FLAG_LARGE_DUMP_ON
+static inline bool tca_flags_valid(u32 act_flags)
+{
+u32 invalid_flags_mask
need this.
Thanks
We are going to have to agree to disagree.
cheers,
jamal
ers,
jamal
.
I thought people script against what iproute2 outputs today. We
may have to change habits.
cheers,
jamal
evolution.
There will be a blood bath with existing apps before the new norm comes
into proper effect.
cheers,
jamal
().
There is a user of BIT() already in iproute2 (devlink). We can move
the code to be more generally available for other iproute2 users.
Then this UAPI change makes use of it.
cheers,
jamal
From: Jamal Hadi Salim <j...@mojatatu.com>
When you dump hundreds of thousands of actions, getting only 32 per
dump batch even when the socket buffer and memory allocations allow
is inefficient.
With this change, the user will get as many as possibly fitting
within the given const
From: Jamal Hadi Salim <j...@mojatatu.com>
This adds support for filtering based on time since last used.
When we are dumping a large number of actions it is useful to
have the option of filtering based on when the action was last
used to reduce the amount of data crossing to user
From: Jamal Hadi Salim <j...@mojatatu.com>
Bug fix for an issue which has been around for about a decade.
We got away with it because the enumeration was larger than needed.
Fixes: 7ba699c604ab ("[NET_SCHED]: Convert actions from rtnetlink to new
netlink API")
Suggested-b
From: Jamal Hadi Salim <j...@mojatatu.com>
Changes since v8:
-
1) Jiri:
-Add back the use of BIT(). Eventually fix iproute2 instead
- Rename VALID_TCA_FLAGS to VALID_TCA_ROOT_FLAGS
Changes since v7:
-
Jamal:
Patch 1 went out twice. Resend without two
s - if you dont like this then speak up and
David needs to be convinced. This is UAPI - once patches are in it is
cast in stone and I dont mind a discussion to make sure we get it right.
Jamal, note that I never suggested having more flags in a single attr.
Therefore I suggested u8 to carry a s
If I used u8 then the 24 of those 32 bits i dont use will be used
as pads in the TLV. So it doesnt make sense for me to use a u8/16.
Does that make more sense?
cheers,
jamal
its being alloced. If i use a u8 then i have
24 bits which are pads - given current discussions I can never ever use
again!
If i keep 32 bits I am free to use those without ever changing the
data structure (except for the restrictions to now make sure nothing
gets set).
cheers,
jamal
asking out invalid bits
should also work in conjunction with user-supplied masks.
The challenge we have right now is "users do stoopid or malicious
things". So are you going to accept the wrong bitmap + mask?
cheers,
jamal
trings?
i.e what if some user has written a bash script that depends on this
string and it gets changed later.
cheers,
jamal
From: Jamal Hadi Salim <j...@mojatatu.com>
Bug fix for an issue which has been around for about a decade.
We got away with it because the enumeration was larger than needed.
Fixes: 7ba699c604ab ("[NET_SCHED]: Convert actions from rtnetlink to new
netlink API")
Suggested-b
From: Jamal Hadi Salim <j...@mojatatu.com>
This adds support for filtering based on time since last used.
When we are dumping a large number of actions it is useful to
have the option of filtering based on when the action was last
used to reduce the amount of data crossing to user
From: Jamal Hadi Salim <j...@mojatatu.com>
Changes since v7:
-
Jamal:
Patch 1 went out twice. Resend without two copies of patch 1
changes since v6:
-
1) DaveM:
New rules for netlink messages. From now on we are going to start
checking for bits that are no
From: Jamal Hadi Salim <j...@mojatatu.com>
When you dump hundreds of thousands of actions, getting only 32 per
dump batch even when the socket buffer and memory allocations allow
is inefficient.
With this change, the user will get as many as possibly fitting
within the given const
From: Jamal Hadi Salim <j...@mojatatu.com>
Bug fix for an issue which has been around for about a decade.
We got away with it because the enumeration was larger than needed.
Fixes: 7ba699c604ab ("[NET_SCHED]: Convert actions from rtnetlink to new
netlink API")
Suggested-b
Grr. I gitta git my git-foo right.
Patch 1 repeated twice - I'll send v8.
cheers,
jamal
From: Jamal Hadi Salim <j...@mojatatu.com>
Bug fix for an issue which has been around for about a decade.
We got away with it because the enumeration was larger than needed.
Fixes: 7ba699c604ab ("[NET_SCHED]: Convert actions from rtnetlink to new
netlink API")
Suggested-b
From: Jamal Hadi Salim <j...@mojatatu.com>
When you dump hundreds of thousands of actions, getting only 32 per
dump batch even when the socket buffer and memory allocations allow
is inefficient.
With this change, the user will get as many as possibly fitting
within the given const
From: Jamal Hadi Salim <j...@mojatatu.com>
This adds support for filtering based on time since last used.
When we are dumping a large number of actions it is useful to
have the option of filtering based on when the action was last
used to reduce the amount of data crossing to user
From: Jamal Hadi Salim <j...@mojatatu.com>
changes since v6:
-
1) DaveM:
New rules for netlink messages. From now on we are going to start
checking for bits that are not used and rejecting anything we dont
understand. In the future this is going to require major changes
t
On 17-04-24 10:00 PM, Jamal Hadi Salim wrote:
On 17-04-24 09:48 PM, Jamal Hadi Salim wrote:
Hrm. maybe I am wrong.
Lets say user sets all of the 8 bits in BOS,
what does setting
key_val->mpls_bos = nla_get_u8 do?
Same with the 20 bits for the label in the u32
or 3 bit bits in the u8
On 17-04-24 09:48 PM, Jamal Hadi Salim wrote:
On 17-04-24 09:20 PM, Jakub Kicinski wrote:
On Mon, 24 Apr 2017 20:58:18 -0400, Jamal Hadi Salim wrote:
On 17-04-24 02:32 PM, David Miller wrote:
You have 3 TLVs, one of which is u8 that only allows use of 3 bits.
The other is a u32 which allows
On 17-04-24 09:20 PM, Jakub Kicinski wrote:
On Mon, 24 Apr 2017 20:58:18 -0400, Jamal Hadi Salim wrote:
On 17-04-24 02:32 PM, David Miller wrote:
You have 3 TLVs, one of which is u8 that only allows use of 3 bits.
The other is a u32 which allows only 20 bits to be set.
I don't think we
On 17-04-24 09:05 PM, Benjamin LaHaise wrote:
On Mon, Apr 24, 2017 at 08:58:18PM -0400, Jamal Hadi Salim wrote:
On 17-04-24 02:32 PM, David Miller wrote:
You have 3 TLVs, one of which is u8 that only allows use of 3 bits.
The other is a u32 which allows only 20 bits to be set.
What
ve 3 TLVs, one of which is u8 that only allows use of 3 bits.
The other is a u32 which allows only 20 bits to be set.
cheers,
jamal
Yeah, not sure i see it either.
cheers,
jamal
On Mon, Apr 24, 2017 at 8:09 PM, Cong Wang <xiyou.wangc...@gmail.com> wrote:
> On Mon, Apr 24, 2017 at 4:41 PM, Stephen Hemminger
> <step...@networkplumber.org> wrote:
>> This loo
this in without
the liberal flag i was suggesting.
This is more about the next flag change that will fail with
older kernels unless the large tc change happens
i.e future ones after this kernel patch.
cheers,
jamal
it makes no difference if i make the
bitmask u32 or u16 - the TLV still eats 32 + 32 bits. So using a u32
is sensible.
cheers,
jamal
[1]
This is because i worry about making large changes to
the behavior of user space apps like tc. If I reject I will need to
change tc to detect this rejection
On 17-04-24 10:20 AM, Pablo Neira Ayuso wrote:
On Mon, Apr 24, 2017 at 08:49:00AM -0400, Jamal Hadi Salim wrote:
I am fine with the counter-Postel view of having the kernel
validate that appropriate bits are set as long as we dont make
user space to now start learning how to play acrobatics
On 17-04-24 05:27 AM, Simon Horman wrote:
On Fri, Apr 21, 2017 at 02:11:00PM -0400, Jamal Hadi Salim wrote:
On 17-04-21 12:12 PM, David Miller wrote:
From my PoV, for #d user-space has to either get smart or fail.
Creating new tc involved work in order to support the new feature.
Part
On 17-04-24 05:14 AM, Simon Horman wrote:
[..]
Jamal, I am confused about why are you so concerned about the space
consumed by this attribute, it's per-message, right? Is it the bigger
picture you are worried about - a similar per-entry flag at some point in
the future?
To me the two worries
add dev lo parent : protocol ip prio 10 \
u32 match ip dst 127.0.0.1/32 flowid 1:1 \
action pedit munge offset 0 u8 set 0x0A retain 0xF0
Mostly curious about hardware handling.
cheers,
jamal
On 17-04-23 12:11 PM, Stephen Hemminger wrote:
On Sat, 22 Apr 2017 08:36:23 -0400
Applied. Please update man page as well.
Will do.
cheers,
jamal
From: Jamal Hadi Salim <j...@mojatatu.com>
per discussion at netconf/netdev:
When we have an action that is capable of branching (example a policer),
we can achieve a continuation of the action graph by programming a
"continue" where we find an exact replica of the same filter r
On 17-04-22 12:54 PM, Stephen Hemminger wrote:
On Sat, 22 Apr 2017 12:43:50 -0400
Jamal Hadi Salim <j...@mojatatu.com> wrote:
On 17-04-22 12:18 PM, Daniel Borkmann wrote:
[..]
Anything I'm missing?
Let me get back to that machine (couple of hours) and try to see how i
created the
On 17-04-22 12:18 PM, Daniel Borkmann wrote:
[..]
Anything I'm missing?
Let me get back to that machine (couple of hours) and try to see how i
created the issue.
Shouldve cutnpasted the error msg. Cant create it on this laptop.
cheers,
jamal
From: Jamal Hadi Salim <j...@mojatatu.com>
Make use of 128b user cookies
Introduce optional 128-bit action cookie.
Like all other cookie schemes in the networking world (eg in protocols
like http or existing kernel fib protocol field, etc) the idea is to
save user state that when ret
bpf_send_map_fds(const char *path, const char *obj)
{
return 0;
}
-
Let me know if you want a formal patch or feel free to take it.
cheers,
jamal
On 17-04-21 02:11 PM, Jamal Hadi Salim wrote:
Please bear with me. I want to make sure to get this right.
Lets say I updated the kernel today to reject transactions with
bits it didnt understand. Lets call this "old kernel". A tc that
understands/sets these bits and nothing else. Ca
On 17-04-21 09:13 AM, Jiri Pirko wrote:
Fri, Apr 21, 2017 at 12:55:32PM CEST, j...@mojatatu.com wrote:
From: Jamal Hadi Salim <j...@mojatatu.com>
@@ -1000,6 +1008,7 @@ static int tcf_action_add(struct net *net, struct nlattr
*nla,
static const struct nla_policy tcaa_policy[TCA_RO
On 17-04-21 11:20 AM, Eric Dumazet wrote:
On Fri, 2017-04-21 at 11:12 -0400, Jamal Hadi Salim wrote:
On 17-04-21 09:12 AM, Jiri Pirko wrote:
Fri, Apr 21, 2017 at 12:55:31PM CEST, j...@mojatatu.com wrote:
From: Jamal Hadi Salim <j...@mojatatu.com>
Jiri, there is a balance b
tell the kernel "if you dont understand
something I am asking for - please ignore it and do what you can".
This would maintain current behavior but would force the user to
explicitly state so.
cheers,
jamal
On 17-04-21 11:55 AM, Jamal Hadi Salim wrote:
On 17-04-21 11:38 AM, David Miller wrote:
If a user says "enable X" and it just gets simply ignored by older
kernels, that can't work properly. What if "enable X" is something
like "turn on encryption"? Ar
On 17-04-21 09:12 AM, Jiri Pirko wrote:
Fri, Apr 21, 2017 at 12:55:31PM CEST, j...@mojatatu.com wrote:
From: Jamal Hadi Salim <j...@mojatatu.com>
+#define TCA_FLAG_LARGE_DUMP_ON (1 << 0)
This is u32 "flags" that could not be extended for other use in future.
On 17-04-21 11:38 AM, David Miller wrote:
From: Jamal Hadi Salim <j...@mojatatu.com>
Date: Fri, 21 Apr 2017 11:29:19 -0400
You don't know this because the kernel has never verified it.
Jamal, you cannot walk past this important point, nothing can
be argued further because of it.
On 17-04-21 10:51 AM, David Miller wrote:
From: Jamal Hadi Salim <j...@mojatatu.com>
Date: Fri, 21 Apr 2017 06:36:19 -0400
On 17-04-20 01:58 PM, David Miller wrote:
From: Jamal Hadi Salim <j...@mojatatu.com>
Date: Thu, 20 Apr 2017 13:38:14 -0400
Which means we can ne
On 17-04-21 09:08 AM, Jiri Pirko wrote:
subj: s/user/use/
Fri, Apr 21, 2017 at 12:55:30PM CEST, j...@mojatatu.com wrote:
From: Jamal Hadi Salim <j...@mojatatu.com>
Bug fix for an issue which has been around for about a decade.
We got away with it because the enumeration was large
From: Jamal Hadi Salim <j...@mojatatu.com>
This adds support for filtering based on time since last used.
When we are dumping a large number of actions it is useful to
have the option of filtering based on when the action was last
used to reduce the amount of data crossing to user
From: Jamal Hadi Salim <j...@mojatatu.com>
Bug fix for an issue which has been around for about a decade.
We got away with it because the enumeration was larger than needed.
Fixes commit 7ba699c604ab ("[NET_SCHED]: Convert actions from rtnetlink to new
netlink API")
Than
From: Jamal Hadi Salim <j...@mojatatu.com>
When you dump hundreds of thousands of actions, getting only 32 per
dump batch even when the socket buffer and memory allocations allow
is inefficient.
With this change, the user will get as many as possibly fitting
within the given const
From: Jamal Hadi Salim <j...@mojatatu.com>
Changes since v5:
0)
Remove use of BIT() because it is kernel specific. Requires a separate
patch (Jiri can submit that in his cleanups)
1)To paraphrase Eric D.
"memcpy(nla_data(count_attr), >args[1], sizeof(u32));
wont
On 17-04-20 01:58 PM, David Miller wrote:
From: Jamal Hadi Salim <j...@mojatatu.com>
Date: Thu, 20 Apr 2017 13:38:14 -0400
There are no examples of such issues with bitmasks encapsulated in
TLVs
It does not make much sense to have a TLV for each of these
bits when i can fit a
On 17-04-20 12:09 PM, Eric Dumazet wrote:
On Thu, 2017-04-20 at 09:06 -0400, Jamal Hadi Salim wrote:
nest = nla_nest_start(skb, TCA_ACT_TAB);
if (nest == NULL)
@@ -1113,6 +1136,8 @@ static int tc_dump_action(struct sk_buff *skb, struct
netlink_callback *cb)
if (ret >
On 17-04-20 11:50 AM, David Miller wrote:
From: Jamal Hadi Salim <j...@mojatatu.com>
Date: Thu, 20 Apr 2017 09:27:00 -0400
The issue Jiri is bringing up is unrelated. He is talking about
a bitmap and conflating it with a data structure. They are not
the same issue.
Bitmaps can have th
A_ATTR_XXX ?
Of course it is an attribute. No need to have "attr" in the name. No
other enum has it. Does not make sense.
The name should contain the group name. What group this enum defines?
It defines tc root level Action attributes.
Would TCRLAA_XXX be more exciting? ;->
cheers,
jamal
On 17-04-20 09:59 AM, Jiri Pirko wrote:
Thu, Apr 20, 2017 at 03:06:21PM CEST, j...@mojatatu.com wrote:
From: Jamal Hadi Salim <j...@mojatatu.com>
When you dump hundreds of thousands of actions, getting only 32 per
dump batch even when the socket buffer and memory allocations
On 17-04-20 09:59 AM, Jiri Pirko wrote:
Thu, Apr 20, 2017 at 03:06:21PM CEST, j...@mojatatu.com wrote:
From: Jamal Hadi Salim <j...@mojatatu.com>
When you dump hundreds of thousands of actions, getting only 32 per
dump batch even when the socket buffer and memory allocations
ex data structures in a TLV for performance reasons.
One lesson is: in the future we can make these extra service header like
tcamsg very small and always use all their fields instead of defining
pads.
cheers,
jamal
On 17-04-20 08:18 AM, Eric Dumazet wrote:
On Thu, 2017-04-20 at 06:42 -0400, Jamal Hadi Salim wrote:
They are not the same issue Jiri. We have used bitmasks fine on netlink
message for a millenia. Nobody sets garbage on a bitmask they are not
supposed to touch. The struct padding thing
Not to be used in production.
cheers,
jamal
diff --git a/tc/f_basic.c b/tc/f_basic.c
index d663668..8370ea6 100644
--- a/tc/f_basic.c
+++ b/tc/f_basic.c
@@ -135,7 +135,7 @@ static int basic_print_opt(struct filter_util *qu, FILE *f,
}
if (tb[TCA_BASIC_ACT
From: Jamal Hadi Salim <j...@mojatatu.com>
Changes since v4:
1) Eric D.
pointed out that when all skb space is used up by the dump
there will be no space to insert the TCAA_ACT_COUNT attribute.
2) Jiri:
i) Change:
enum {
TCAA_UNSPEC,
TCAA_ACT_TAB,
TCAA_ACT
From: Jamal Hadi Salim <j...@mojatatu.com>
When you dump hundreds of thousands of actions, getting only 32 per
dump batch even when the socket buffer and memory allocations allow
is inefficient.
With this change, the user will get as many as possibly fitting
within the given const
From: Jamal Hadi Salim <j...@mojatatu.com>
This adds support for filtering based on time since last used.
When we are dumping a large number of actions it is useful to
have the option of filtering based on when the action was last
used to reduce the amount of data crossing to user
...@mojatatu.com wrote:
On 17-04-19 08:36 AM, Jiri Pirko wrote:
Wed, Apr 19, 2017 at 01:57:29PM CEST, j...@mojatatu.com wrote:
From: Jamal Hadi Salim <j...@mojatatu.com>
include/uapi/linux/rtnetlink.h | 21 +++--
net/sched/act_api.c
On 17-04-19 11:03 AM, Wolfgang Bumiller wrote:
On April 19, 2017 at 1:32 PM Jamal Hadi Salim <j...@mojatatu.com> wrote:
On 17-04-19 04:09 AM, Wolfgang Bumiller wrote:
This solves one issue, but I am afraid the issue Cong mentioned is a
possibility still.
Lets say user did a replace and
On 17-04-19 01:25 PM, Cong Wang wrote:
On Wed, Apr 19, 2017 at 4:32 AM, Jamal Hadi Salim <j...@mojatatu.com> wrote:
This solves one issue, but I am afraid the issue Cong mentioned is a
possibility still.
Lets say user did a replace and tried to also replace the cookie
in that trans
...@mojatatu.com wrote:
From: Jamal Hadi Salim <j...@mojatatu.com>
include/uapi/linux/rtnetlink.h | 21 +++--
net/sched/act_api.c| 43 --
3 files changed, 53 insertions(+), 12 deletions(-)
+#define TCAA_MAX (__TCAA_MAX - 1)
#
of "hackedtc"
Yes, the user sets it. I can make the diff available next time.
I didnt want to go on a discussion how to pass the command line
parameter in tc.
TIME_DELTA?
sure.
Let me wait more comments then I will push the new update
by tommorow.
cheers,
jamal
m I missing ?
Ok, I understand you now ;->
You are saying we need make sure there is at
least 64 bits reserved so we can stick this TLV in there.
We may have to review a lot of other dumping code in general
to make sure this doesnt happen. Thanks Eric.
cheers,
jamal
On 17-04-19 09:13 AM, Jiri Pirko wrote:
Wed, Apr 19, 2017 at 03:03:59PM CEST, j...@mojatatu.com wrote:
On 17-04-19 08:36 AM, Jiri Pirko wrote:
Wed, Apr 19, 2017 at 01:57:29PM CEST, j...@mojatatu.com wrote:
From: Jamal Hadi Salim <j...@mojatatu.com>
include/uapi/linux/rtnetlink.
On 17-04-19 08:53 AM, Jiri Pirko wrote:
Wed, Apr 19, 2017 at 01:57:30PM CEST, j...@mojatatu.com wrote:
From: Jamal Hadi Salim <j...@mojatatu.com>
This adds support for filtering based on time since last used.
When we are dumping a large number of actions it is useful to
have the
On 17-04-19 08:36 AM, Jiri Pirko wrote:
Wed, Apr 19, 2017 at 01:57:29PM CEST, j...@mojatatu.com wrote:
From: Jamal Hadi Salim <j...@mojatatu.com>
include/uapi/linux/rtnetlink.h | 21 +++--
net/sched/act_api.c| 43 --
3
From: Jamal Hadi Salim <j...@mojatatu.com>
This adds support for filtering based on time since last used.
When we are dumping a large number of actions it is useful to
have the option of filtering based on when the action was last
used to reduce the amount of data crossing to user
From: Jamal Hadi Salim <j...@mojatatu.com>
When you dump hundreds of thousands of actions, getting only 32 per
dump batch even when the socket buffer and memory allocations allow
is inefficient.
With this change, the user will get as many as possibly fitting
within the given const
On 17-04-19 07:49 AM, Jamal Hadi Salim wrote:
From: Jamal Hadi Salim <j...@mojatatu.com>
When you dump hundreds of thousands of actions, getting only 32 per
dump batch even when the socket buffer and memory allocations allow
is inefficient.
With this change, the user will get a
From: Jamal Hadi Salim <j...@mojatatu.com>
When you dump hundreds of thousands of actions, getting only 32 per
dump batch even when the socket buffer and memory allocations allow
is inefficient.
With this change, the user will get as many as possibly fitting
within the given const
301 - 400 of 2031 matches
Mail list logo
