On 16-02-24 12:58 PM, Daniel Borkmann wrote:
On 02/24/2016 01:49 PM, Jamal Hadi Salim wrote:
Yes, a bit of that ++.
I am between two worlds: There are people who do user space packet
processing that claim they do so because they can quickly prototype
without compiling the kernel. My goal
On 16-02-24 12:48 PM, Daniel Borkmann wrote:
On 02/24/2016 01:49 PM, Jamal Hadi Salim wrote:
Drivers do set the hash. My use case is slightly different.
I have a NIC which has an embedded cavium processor. This thing
strips off the TLV and uses the hash to select the host MSI.
Only thing we
On 16-02-24 12:37 PM, Daniel Borkmann wrote:
On 02/23/2016 01:49 PM, Jamal Hadi Salim wrote:
From: Jamal Hadi Salim <j...@mojatatu.com>
[...]
+static const struct nla_policy ife_policy[TCA_IFE_MAX + 1] = {
+[TCA_IFE_PARMS] = {.len = sizeof(struct tc_ife)},
+[TCA_IFE_DMAC] =
On 16-02-24 12:21 PM, Cong Wang wrote:
On Wed, Feb 24, 2016 at 5:19 AM, Jamal Hadi Salim <j...@mojatatu.com> wrote:
[..]
Did you mean something else or am i missing the obvious?
I am looking at the call sites for tcf_action_destroy():
-tc_dump_tfilter() has access to *net
-tcf_exts_
for them in s/ware first.
There's some really freaking slow hardware interfaces out there...
(a record of 60 seconds to find something is not unheard of).
cheers,
jamal
into the core code and removes it from the
driver specific case.
Signed-off-by: John Fastabend <john.r.fastab...@intel.com>
Acked-by: Jamal Hadi Salim <j...@mojatatu.com>
cheers,
jamal
in one function lift
the current check into a helper routine tc_should_offload().
Signed-off-by: John Fastabend <john.r.fastab...@intel.com>
Acked-by: Jamal Hadi Salim <j...@mojatatu.com>
cheers,
jamal
On 16-02-23 05:23 PM, Cong Wang wrote:
On Tue, Feb 23, 2016 at 5:14 AM, Jamal Hadi Salim <j...@mojatatu.com> wrote:
It doesnt seem neccessary to have hinfo in tc_action. Quick scan:
__tcf_hash_release() seems to be the only other place that uses it.
And the callers to that appear c
On 16-02-23 04:44 PM, Cong Wang wrote:
On Tue, Feb 23, 2016 at 4:49 AM, Jamal Hadi Salim <j...@mojatatu.com> wrote:
+#define MODULE_ALIAS_IFE_META(metan) MODULE_ALIAS("ifemeta"
__stringify_1(metan))
+
+int get_meta_u32(struct sk_buff *skb, struct tcf_meta_info *mi);
+
On 16-02-23 11:12 AM, Daniel Borkmann wrote:
On 02/23/2016 03:39 PM, Jamal Hadi Salim wrote:
My question was rather: should the kernel enforce the IDs and only
allow what the kernel dictates (and not in/out of tree modules)? If
yes, then there would be no need for a module parameter
On 16-02-23 10:34 AM, Daniel Borkmann wrote:
On 02/23/2016 03:28 PM, Jamal Hadi Salim wrote:
[..]
These are basic metadata. The question to ask is what could one use
skb->hash for. Today it is used to select a cpu to balance to.
Right, but that happens before you decode that informat
which
pushes or pops vlans or vxlans to use netdevs either.
Yes it quacks like a duck(i.e has receive) and walks like a duck(has
stats) but it looks like an ostrich;->
cheers,
jamal
On 16-02-23 08:32 AM, Daniel Borkmann wrote:
On 02/23/2016 01:49 PM, Jamal Hadi Salim wrote:
From: Jamal Hadi Salim <j...@mojatatu.com>
This action allows for a sending side to encapsulate arbitrary metadata
which is decapsulated by the receiving end.
The sender runs in encodin
On 16-02-23 08:20 AM, Daniel Borkmann wrote:
On 02/23/2016 01:09 PM, Jamal Hadi Salim wrote:
On 16-02-22 11:47 AM, Daniel Borkmann wrote:
[...]
So, basically this is a L2 encap with TLVs, right?
And as TLVs you have skb->mark, skb->priority, skb->hash,
skb->queue_mapping
that
le. I was hoping we could get rid of the per
action pernet ops but that could come later.
cheers,
jamal
netns in the latter patch.
Cc: Jamal Hadi Salim <j...@mojatatu.com>
Signed-off-by: Cong Wang <xiyou.wangc...@gmail.com>
Acked-by: Jamal Hadi Salim <j...@mojatatu.com>
cheers,
jamal
From: Jamal Hadi Salim <j...@mojatatu.com>
Example usage:
Set the skb priority using skbedit then allow it to be encoded
sudo tc qdisc add dev $ETH root handle 1: prio
sudo tc filter add dev $ETH parent 1: protocol ip prio 10 \
u32 match ip protocol 1 0xff flow
From: Jamal Hadi Salim <j...@mojatatu.com>
Example usage:
Set the skb using skbedit then allow it to be encoded
sudo tc qdisc add dev $ETH root handle 1: prio
sudo tc filter add dev $ETH parent 1: protocol ip prio 10 \
u32 match ip protocol 1 0xff flowid 1:2 \
action skbedit mark 17 \
acti
From: Jamal Hadi Salim <j...@mojatatu.com>
This action allows for a sending side to encapsulate arbitrary metadata
which is decapsulated by the receiving end.
The sender runs in encoding mode and the receiver in decode mode.
Both sender and receiver must specify the same ethertype.
At some
From: Jamal Hadi Salim <j...@mojatatu.com>
hard code static value of 10 for qmap
mark of 12
prio of 13
and hashid of 11
sudo tc filter add dev $ETH parent 1: protocol ip prio 10 \
u32 match ip protocol 1 0xff flowid 1:2 \
action ife encode \
type 0xDEAD \
use mark 12 \
use prio 13 \
use
From: Jamal Hadi Salim <j...@mojatatu.com>
As agreed at netconf in Seville, here's the patch finally (1 year
was just too long to wait).
Described in netdev01 paper:
"Distributing Linux Traffic Control Classifier-Action Subsystem"
Authors: Jamal Hadi Sal
From: Jamal Hadi Salim <j...@mojatatu.com>
Example usage:
allow skb hash to be encoded as metadata
sudo tc qdisc add dev $ETH root handle 1: prio
sudo tc filter add dev $ETH parent 1: protocol ip prio 10 \
u32 match ip protocol 1 0xff flow
On 16-02-23 02:00 AM, Cong Wang wrote:
On Mon, Feb 22, 2016 at 5:21 AM, Jamal Hadi Salim <j...@mojatatu.com> wrote:
From: Jamal Hadi Salim <j...@mojatatu.com>
As agreed at netconf in Seville, here's the patch finally (1 year
was just too long to wait).
Described in ne
On 16-02-22 04:03 PM, John Fastabend wrote:
On 16-02-22 05:21 AM, Jamal Hadi Salim wrote:
From: Jamal Hadi Salim <j...@mojatatu.com>
hard code static value of 10 for qmap
mark of 12
prio of 13
and hashid of 11
sudo tc filter add dev $ETH parent 1: protocol ip prio 10 \
u32 match ip prot
Hi Daniel,
On 16-02-22 11:47 AM, Daniel Borkmann wrote:
Hi Jamal,
On 02/22/2016 02:21 PM, Jamal Hadi Salim wrote:
From: Jamal Hadi Salim <j...@mojatatu.com>
As agreed at netconf in Seville, here's the patch finally (1 year
was just too long to wait).
Described in netdev01
nd per namespace instance - otherwise i would suggest for xxx_net_id
to be part of act_ops. Could we not have an #ifdef in the namespace
core like the netfilter code does and have one level of indirection
for everything but the namespace 0?
cheers,
jamal
From: Jamal Hadi Salim <j...@mojatatu.com>
Example usage:
Set the skb using skbedit then allow it to be encoded
sudo tc qdisc add dev $ETH root handle 1: prio
sudo tc filter add dev $ETH parent 1: protocol ip prio 10 \
u32 match ip protocol 1 0xff flowid 1:2 \
action skbedit mark 17 \
acti
From: Jamal Hadi Salim <j...@mojatatu.com>
hard code static value of 10 for qmap
mark of 12
prio of 13
and hashid of 11
sudo tc filter add dev $ETH parent 1: protocol ip prio 10 \
u32 match ip protocol 1 0xff flowid 1:2 \
action ife encode \
type 0xDEAD \
use mark 12 \
use prio 13 \
use
From: Jamal Hadi Salim <j...@mojatatu.com>
Example usage:
allow skb hash to be encoded as metadata
sudo tc qdisc add dev $ETH root handle 1: prio
sudo tc filter add dev $ETH parent 1: protocol ip prio 10 \
u32 match ip protocol 1 0xff flow
From: Jamal Hadi Salim <j...@mojatatu.com>
Example usage:
Set the skb priority using skbedit then allow it to be encoded
sudo tc qdisc add dev $ETH root handle 1: prio
sudo tc filter add dev $ETH parent 1: protocol ip prio 10 \
u32 match ip protocol 1 0xff flow
From: Jamal Hadi Salim <j...@mojatatu.com>
This action allows for a sending side to encapsulate arbitrary metadata
which is decapsulated by the receiving end.
The sender runs in encoding mode and the receiver in decode mode.
Both sender and receiver must specify the same ethertype.
At some
From: Jamal Hadi Salim <j...@mojatatu.com>
As agreed at netconf in Seville, here's the patch finally (1 year
was just too long to wait).
Described in netdev01 paper:
"Distributing Linux Traffic Control Classifier-Action Subsystem"
Authors: Jamal Hadi Sal
On 16-02-18 10:24 AM, John Fastabend wrote:
On 16-02-18 04:14 AM, Jamal Hadi Salim wrote:
On 16-02-17 06:07 PM, John Fastabend wrote:
[...]
IMO, it would be better at this early stage to enforce the correct
behavior for future generations.
To follow the netlink semantics which a lot
From: Jamal Hadi Salim <j...@mojatatu.com>
Signed-off-by: Jamal Hadi Salim <j...@mojatatu.com>
---
net/sched/sch_api.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/sched/sch_api.c b/net/sched/sch_api.c
index af1acf0..de1e176 100644
--- a/net/sched/sch_api
From: Jamal Hadi Salim <j...@mojatatu.com>
actions could change the etherproto in particular with ethernet
tunnelled data. Typically such actions, after peeling the outer header,
will ask for the packet to be reclassified. We then need to restart
the classification with the new proto
From: Jamal Hadi Salim <j...@mojatatu.com>
v3:
Cong says this needs to go to -net. And to put back the removed new line
v2:
Use Daniel's suggestion on when to set the skb proto
v1:
fix compile error found by build bot when CONFIG_NET_CLS_ACT was off
Jamal Hadi Salim (1):
net_sch
it
fixes a bug.
Yeah, good point. That should go to -net (minus the unrelated white
space change).
One patch coming right up boys;->
cheers,
jamal
if a rule exists first. And i have worked
in cases where #1 is assumed to mean #2 and at times #4. It is better
user experience to be explicit.
cheers,
jamal
On 16-02-17 06:19 AM, Jamal Hadi Salim wrote:
Thats how the original code was (and what i tested). I dont have time
to test right now but i will send an update with your suggestion.
My setup was still running so I managed to test it with IFE
cheers,
jamal
x that NEW with REPLACE
in patch 3.
For this patch:
Acked-by: Jamal Hadi Salim <j...@mojatatu.com>
cheers,
jamal
From: Jamal Hadi Salim <j...@mojatatu.com>
v2:
Use Daniel's suggestion on when to set the skb proto
v1:
fix compile error found by build bot when CONFIG_NET_CLS_ACT was off
Jamal Hadi Salim (1):
net_sched fix: reclassification needs to consider ether protocol
changes
net/sched/sch
From: Jamal Hadi Salim <j...@mojatatu.com>
actions could change the etherproto in particular with ethernet
tunnelled data. Typically such actions, after peeling the outer header,
will ask for the packet to be reclassified. We then need to restart
the classification with the new proto
On 16-02-16 10:20 AM, Daniel Borkmann wrote:
On 02/16/2016 01:37 PM, Jamal Hadi Salim wrote:
From: Jamal Hadi Salim <j...@mojatatu.com>
actions could change the etherproto in particular with ethernet
tunnelled data. Typically such actions, after peeling the outer header,
wi
is not too much work, please
address this.
cheers,
jamal
u32. I think most of unsigned ints should be u32.
Acked-by: Jamal Hadi Salim <j...@mojatatu.com>
tab...@intel.com>
Acked-by: Jiri Pirko <j...@mellanox.com>
Acked-by: Jamal Hadi Salim <j...@mojatatu.com>
On 16-02-17 12:18 AM, John Fastabend wrote:
This is a helper function drivers can use to learn if the
action type is a drop action.
Signed-off-by: John Fastabend <john.r.fastab...@intel.com>
Acked-by: Jamal Hadi Salim <j...@mojatatu.com>
cheers,
jamal
hw_
offloads, there are a few more instructions. Maybe just do the
dev->netdev_ops->ndo_setup_tc first?
And to Or's point: How do i distinguish s/w from h/w?
cheers,
jamal
ndo ops or grow the signature of the
callback.
Signed-off-by: John Fastabend <john.r.fastab...@intel.com>
Acked-by: Jiri Pirko <j...@mellanox.com>
Acked-by: Jamal Hadi Salim <j...@mojatatu.com>
com>
CC: Jeff Kirsher <jeffrey.t.kirs...@intel.com>
CC: Bruce Allan <bruce.w.al...@intel.com>
CC: Jesse Brandeburg <jesse.brandeb...@intel.com>
CC: Don Skidmore <donald.c.skidm...@intel.com>
Signed-off-by: John Fastabend <john.r.fastab...@intel.com>
Acked-by: Jiri Pir
From: Jamal Hadi Salim <j...@mojatatu.com>
actions could change the etherproto in particular with ethernet
tunnelled data. Typically such actions, after peeling the outer header,
will ask for the packet to be reclassified. We then need to restart
the classification with the new proto
On 16-02-15 03:59 PM, Daniel Borkmann wrote:
On 02/15/2016 08:49 PM, Jamal Hadi Salim wrote:
From: Jamal Hadi Salim <j...@mojatatu.com>
actions could change the etherproto in particular with ethernet
tunnelled data. Typically such actions, after peeling the outer header,
wi
From: Jamal Hadi Salim <j...@mojatatu.com>
actions could change the etherproto in particular with ethernet
tunnelled data. Typically such actions, after peeling the outer header,
will ask for the packet to be reclassified. We then need to restart
the classification with the new proto
c. i.e
by non-optional i mean always expected to be present.
I think a good test is old kernel with new iproute2. If the new field
is non-optional, it will fail (example iproute2 may try to print a value
that it expects but because old kernel doesnt understand it; it is
non-existent).
cheers,
jamal
On 16-02-09 06:24 AM, Fastabend, John R wrote:
On 2/4/2016 5:12 AM, Jamal Hadi Salim wrote:
On 16-02-03 01:48 PM, Fastabend, John R wrote:
Basically most hardware (or i should say driver implementations of
mostly TCAMS) allow you to add exactly the same filter as many times
as you want
know folks are following this who wont be at Seville and I don't
see any reason to block these patches and stop the thread for a
week or more.
I really dont see much of a blocker.
cheers,
jamal
truct
a mapping to a TCAM key.
What John is doing is essentially taking the nodeid and trying to use
it as a priority. In otherwise the abstraction is reduced to a linked
list in which the ordering is how the list is traversed.
It may work in this case, but i am for being able to explicitly specify
priorities.
cheers,
jamal
ertainly re-usable beyond NICs and SRIOV.
5)What happened to being both able to hardware and/or software?
Anyways, I think Seville would be a blast! Come one, come all.
cheers,
jamal
e a pktgen change that may be useful for you - I will post
it next time i get cycles.
I am also a willing guinea pig (given upcoming netdev11) to do
some perf testing ;->
cheers,
jamal
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to ma
ers,
jamal
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
?
If you meet all the above requirements, please resubmit and
add my Acked-by
cheers,
jamal
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
ims to use ebpf and then somehow translate to use
classifier/actions.
cheers,
jamal
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On 15-12-08 09:23 AM, Jamal Hadi Salim wrote:
On 15-12-08 02:33 AM, John Fastabend wrote:
;-> I feel a little vindicated with this discussion.
Of course you can implement hardware using BPF!
BTW - Just to be clear; I am not arguing for what that paper
preaches. What the paper preac
On 10/15/15 00:32, Cong Wang wrote:
On Wed, Oct 14, 2015 at 5:11 AM, Jamal Hadi Salim <j...@mojatatu.com> wrote:
On 10/12/15 14:38, Cong Wang wrote:
When the bottom qdisc decides to, for example, drop some packet,
it calls qdisc_tree_decrease_qlen() to update the queue length
for a
On 10/15/15 00:15, Cong Wang wrote:
On Wed, Oct 14, 2015 at 4:56 AM, Jamal Hadi Salim <j...@mojatatu.com> wrote:
On 10/12/15 14:38, Cong Wang wrote:
Remove nearly duplicated code and prepare for the following patch.
Cong - like Dave, I dont see equivalence in some of these
c
On 10/15/15 00:21, Cong Wang wrote:
On Wed, Oct 14, 2015 at 5:25 AM, Jamal Hadi Salim <j...@mojatatu.com> wrote:
On 10/12/15 14:38, Cong Wang wrote:
It is odd to see qlen!=0 but backlog==0, for a real example:
Backlog is a transient stat so a lot of times it should be 0. Only when
t
On 10/12/15 14:38, Cong Wang wrote:
Remove nearly duplicated code and prepare for the following patch.
Cong - like Dave, I dont see equivalence in some of these
changes.
Example not sure how the qfq grafting invocation of
qfq_purge_queue fits in. There are a few others.
cheers,
jamal
qdisc_qstats_backlog_dec() and your new
qdisc_tree_reduce_backlog()
BTW: Codel usage of looking at queue limit during control update
seems strange.
cheers,
jamal
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majo
is enqueued (and not by a parent's
enqueue asking for hierarchical enques).
I think some more work is needed Cong for this general patchset.
cheers,
jamal
qdisc htb 1: dev eth0 root refcnt 2 r2q 10 default 1 direct_packets_stat 0 ver
3.17
Sent 172680457356 bytes 222469449 pkt (dropped 0
Never mind. Mirred is speacial because it points to other netdevs.
So:
Acked-by: Jamal Hadi Salim <j...@mojatatu.com>
Thanks Cong.
cheers,
jamal
On 10/05/15 07:58, Jamal Hadi Salim wrote:
Hi Cong,
I am wondering if making the bindcount or refcount atomic would help?
How does this b
Hi Cong,
I am wondering if making the bindcount or refcount atomic would help?
How does this bug get created? i.e the RTNL is still around.
Why is this specific to mirred only?
cheers,
jamal
On 10/01/15 14:37, Cong Wang wrote:
After commit 1ce87720d456 ("net: sched: make cls_u32 loc
On 10/01/15 14:37, Cong Wang wrote:
Align with other tc actions.
Cc: Jamal Hadi Salim <j...@mojatatu.com>
Signed-off-by: Cong Wang <cw...@twopensource.com>
Signed-off-by: Cong Wang <xiyou.wangc...@gmail.com>
Acked-by: Jamal Hadi Salim <j...@mojatatu.com>
cheers,
jama
tp->root allocation into fw_init()")
Reported-by: Akshat Kakkar <akshat.1...@gmail.com>
Cc: Jamal Hadi Salim <j...@mojatatu.com>
Signed-off-by: Cong Wang <xiyou.wangc...@gmail.com>
Acked-by: Jamal Hadi Salim <j...@mojatatu.com>
--
To unsubscribe from this
we can make this decision right here,
we can use this fact and have simple return codes provided as
well.
I think it makes sense for the simple case.
But you have every other opcode in there, not just basic
accept/drop. I am worried this is leading towards an
enclave of bpf do-everything.
cheers,
the only one or guaranteed that nothing
better will exist for speficic use cases.
If there is something in the core that needs improvement
for the benefit of all, then lets do that. Example i find
the classid metadata interesting but flinching at ACT_REDIRECT.
cheers,
jamal
--
To unsubscribe from
ase).
The other part you can make more readable.
cheers,
jamal
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
under
TCA_BPF_FLAG_ACT_DIRECT flag.
This is going off in a different direction really.
You are replicating the infrastructure inside bpf.
cheers,
jamal
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordo
(return 0?).
If someone wants to add classids ids, change() is available.
The most common (efficient) use case is what Akshat shows.
So even the check in the classify should optimize for that i.e
if (head == NULL)
do old method
else
...
cheers,
jamal
--
To unsubscribe from this list: send
On 09/02/15 02:22, Cong Wang wrote:
(Why not Cc'ing Jamal for net_sched pathes?)
On Tue, Sep 1, 2015 at 9:34 AM, Daniel Borkmann <dan...@iogearbox.net> wrote:
From: John Fastabend <john.r.fastab...@intel.com>
Add a new ->preclassify() op to allow multiqueue queuing disc
On 08/28/15 19:20, David Miller wrote:
But HTB definitely should be allowed.
Problem with most non-work conserving schedulers is what the meaning
of default resources means; example, for HTB:
What is the default bandwidth you allocate to a class of users?
cheers,
jamal
--
To unsubscribe
ambiguity introduce qdisc-set_default().
cheers,
jamal
--
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
the chance to change their applications,
f.e. due to proprietary legacy stuff. So, they'll hit this warning
in fast path and are stuck with older kernels.
But i.e. due to point 1) I really fail to see the benefit of a warning.
So just revert that for now, the issue was reported up Jamal.
[1
those lines...
But certainly dequeue semantics dont seem right there..
cheers,
jamal
cheers,
jamal
--
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
. Or a brand new pktgen_burst_mode action that drops?
cheers,
jamal
--
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
classifiers/actions assume
the same skb pointer.
Alexei,
To add to what Dave said - are the rules specified here:
Documentation/networking/tc-actions-env-rules.txt
insufficient?
cheers,
jamal
--
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to majord
patch when theres some consensus.
cheers,
jamal
diff --git a/net/sctp/socket.c b/net/sctp/socket.c
index 5f6c4e6..0e8c937 100644
--- a/net/sctp/socket.c
+++ b/net/sctp/socket.c
@@ -2207,9 +2207,10 @@ static int sctp_setsockopt_events(struct sock *sk, char
__user *optval,
return -EFAULT
before/after the change?
Acked-by: Jamal Hadi Salim j...@mojatatu.com
cheers,
jamal
--
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
to keep, with each tied to a queue?
cheers,
jamal
--
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
queue capability to ifb device
Signed-off-by: Eric Dumazet eduma...@google.com
Looks good to me ;-
Acked-by: Jamal Hadi Salim j...@mojatatu.com
cant wait for the multi queue ifb.
cheers,
jamal
--
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to majord
() is renamed to qdisc_qstats_cpu_drop()
Signed-off-by: Eric Dumazet eduma...@google.com
Cc: Alexei Starovoitov a...@plumgrid.com
Cc: Jamal Hadi Salim j...@mojatatu.com
Cc: John Fastabend john.fastab...@gmail.com
Acked-by: Jamal Hadi Salim j...@mojatatu.com
cheers,
jamal
--
To unsubscribe from
On 07/02/15 09:07, Eric Dumazet wrote:
First step for gact RCU operation :
Instead of testing if tcfg_pval is zero or not, just make it 1.
No change in behavior, but slightly faster code.
Signed-off-by: Eric Dumazet eduma...@google.com
Acked-by: Jamal Hadi Salim j...@mojatatu.com
cheers
-by: Eric Dumazet eduma...@google.com
Acked-by: Jamal Hadi Salim j...@mojatatu.com
cheers,
jamal
--
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On 07/02/15 09:07, Eric Dumazet wrote:
Third step for gact RCU operation :
Following patch will get rid of spinlock protection,
so we need to read tcfg_ptype once.
Signed-off-by: Eric Dumazet eduma...@google.com
Acked-by: Jamal Hadi Salim j...@mojatatu.com
cheers,
jamal
--
To unsubscribe
, vlan and skbedit.
CCing the respective authors.
Signed-off-by: Eric Dumazet eduma...@google.com
Cc: Alexei Starovoitov a...@plumgrid.com
Cc: Jamal Hadi Salim j...@mojatatu.com
Acked-by: Jamal Hadi Salim j...@mojatatu.com
cheers,
jamal
--
To unsubscribe from this list: send the line
show a good enough performance, not sure we want a percpu thing
for this lastuse field.
Does it harm to always set gact-tcf_tm.lastuse ?
cheers,
jamal
--
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to majord...@vger.kernel.org
More majordomo info
-by: Eric Dumazet eduma...@google.com
Acked-by: Jamal Hadi Salim j...@mojatatu.com
cheers,
jamal
--
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Trying to catchup with email and i am noticing my last
received email was on the 21st. Anyone else having problems
(feel like i am asking the question if you cant hear me
please raise your hand ;-).
cheers,
jamal
--
To unsubscribe from this list: send the line unsubscribe netdev in
the body
From: Jamal Hadi Salim h...@mojatatu.com
Fix typo in the validation rules for flower's attributes
Signed-off-by: Jamal Hadi Salim j...@mojatatu.com
---
net/sched/cls_flower.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/net/sched/cls_flower.c b/net/sched
On 06/25/15 08:03, David Miller wrote:
I'm pretty sure you're just not subscribed to the list.
I never unsubscribed. Ive resubscribed.
cheers,
jamal
--
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to majord...@vger.kernel.org
More majordomo info
be slightly unsuited
for what you are after maybe?
cheers,
jamal
--
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
901 - 1000 of 2031 matches
Mail list logo
