Re: [PATCH v3 1/5] thermal/drivers/core: Use a char pointer for the cooling device name

2021-03-14 Thread Daniel Lezcano
On 14/03/2021 13:47, Ido Schimmel wrote: > On Sun, Mar 14, 2021 at 12:13:29PM +0100, Daniel Lezcano wrote: >> We want to have any kind of name for the cooling devices as we do no >> longer want to rely on auto-numbering. Let's replace the cooling >> device's fixe

[PATCH v3 1/5] thermal/drivers/core: Use a char pointer for the cooling device name

2021-03-14 Thread Daniel Lezcano
ework the error path at the same time as we have to rollback the allocations in case of error. Tested with a dummy device having the name: "Llanfairpwllgwyngyllgogerychwyrndrobwantysiliogogogoch" A village on the island of Anglesey (Wales), known to have the longest name in Europ

Re: [PATCH v2 1/5] thermal/drivers/core: Use a char pointer for the cooling device name

2021-03-14 Thread Daniel Lezcano
Hi Ido, On 14/03/2021 10:53, Ido Schimmel wrote: > On Fri, Mar 12, 2021 at 06:03:12PM +0100, Daniel Lezcano wrote: >> diff --git a/drivers/thermal/thermal_core.c b/drivers/thermal/thermal_core.c >> index 996c038f83a4..9ef8090eb645 100644 >> --- a/drivers/thermal/thermal_co

Re: [PATCH v2 1/5] thermal/drivers/core: Use a char pointer for the cooling device name

2021-03-12 Thread Daniel Lezcano
On 12/03/2021 19:49, Lukasz Luba wrote: > > > On 3/12/21 5:03 PM, Daniel Lezcano wrote: >> We want to have any kind of name for the cooling devices as we do no >> longer want to rely on auto-numbering. Let's replace the cooling >> device's fixed ar

[PATCH v2 1/5] thermal/drivers/core: Use a char pointer for the cooling device name

2021-03-12 Thread Daniel Lezcano
ework the error path at the same time as we have to rollback the allocations in case of error. Tested with a dummy device having the name: "Llanfairpwllgwyngyllgogerychwyrndrobwantysiliogogogoch" A village on the island of Anglesey (Wales), known to have the longest name in Europ

Re: [PATCH 02/20] dt-bindings: thermal: rcar-gen3-thermal: Add r8a774e1 support

2020-09-19 Thread Daniel Lezcano
On 19/09/2020 13:05, Lad, Prabhakar wrote: > Hi Niklas/Zhang/Daniel, > > On Thu, Aug 27, 2020 at 5:52 PM Lad, Prabhakar > wrote: >> >> Hi Zhang,Daniel,Amit, >> >> On Wed, Jul 15, 2020 at 12:09 PM Lad Prabhakar >> wrote: >>> >>> Document RZ/G2H (R8A774E1) SoC bindings. >>> >>> Signed-off-by: Lad

Re: [PATCH 05/20] dt-bindings: timer: renesas,cmt: Document r8a774e1 CMT support

2020-09-19 Thread Daniel Lezcano
On 19/09/2020 13:00, Lad, Prabhakar wrote: > Hi Daniel and Thomas, > > On Thu, Aug 27, 2020 at 6:00 PM Lad, Prabhakar > wrote: >> >> Hi Daniel and Thomas, >> >> On Wed, Jul 15, 2020 at 12:09 PM Lad Prabhakar >> wrote: >>> >>> Document SoC specific bindings for RZ/G2H (r8a774e1) SoC. >>> >>> Sign

Re: [PATCH] net: genetlink: Move initialization to core_initcall

2020-07-17 Thread Daniel Lezcano
On 17/07/2020 19:34, David Miller wrote: > From: Daniel Lezcano > Date: Wed, 15 Jul 2020 09:43:00 +0200 > >> if you agree with this change, is it possible I merge it through the >> thermal tree in order to fix the issue ? > > No problem: > > Acked-by: Davi

Re: [PATCH 03/20] thermal: rcar_gen3_thermal: Add r8a774e1 support

2020-07-16 Thread Daniel Lezcano
On 15/07/2020 13:08, Lad Prabhakar wrote: > From: Marian-Cristian Rotariu > > Add r8a774e1 specific compatible string. > > Signed-off-by: Marian-Cristian Rotariu > > Signed-off-by: Lad Prabhakar --- Applied, thanks -- Linaro.org │ Open source software for ARM SoC

Re: [PATCH] net: genetlink: Move initialization to core_initcall

2020-07-15 Thread Daniel Lezcano
Hi Dave, if you agree with this change, is it possible I merge it through the thermal tree in order to fix the issue ? Thanks -- Daniel On 15/07/2020 09:41, Daniel Lezcano wrote: > The generic netlink is initialized far after the netlink protocol > itself at subsys_initcall. The d

[PATCH] net: genetlink: Move initialization to core_initcall

2020-07-15 Thread Daniel Lezcano
n as soon as possible. Moving it to postcore_initcall is acceptable. This patch changes the initialization level for the generic netlink family to the core_initcall and comes after the netlink protocol initialization. Signed-off-by: Daniel Lezcano --- net/netlink/genetlink.c | 2 +- 1 file changed,

Re: [PATCH 0/3] Fixes for stop monitoring disabled devices series

2020-07-03 Thread Daniel Lezcano
On 03/07/2020 13:57, Andrzej Pietrasiewicz wrote: > Hi, > > W dniu 03.07.2020 o 13:06, Daniel Lezcano pisze: >> On 03/07/2020 12:43, Andrzej Pietrasiewicz wrote: >>> This short series contains fixes for "Stop monitoring disabled devices" >>> seri

Re: [PATCH 0/3] Fixes for stop monitoring disabled devices series

2020-07-03 Thread Daniel Lezcano
On 03/07/2020 12:43, Andrzej Pietrasiewicz wrote: > This short series contains fixes for "Stop monitoring disabled devices" > series https://www.spinics.net/lists/arm-kernel/msg817861.html > > Invocation of thermal_zone_device_is_enabled() in acpi/thermal is now > redundant, because thermal_zone_d

Re: [PATCH v7 00/11] Stop monitoring disabled devices

2020-07-03 Thread Daniel Lezcano
On 03/07/2020 12:45, Andrzej Pietrasiewicz wrote: > Hi, > > W dniu 03.07.2020 o 08:38, Daniel Lezcano pisze: >> On 03/07/2020 03:49, Zhang Rui wrote: >>> On Thu, 2020-07-02 at 19:49 +0200, Daniel Lezcano wrote: >> >> [ ... ] >> >>>>> So the

Re: [PATCH v7 00/11] Stop monitoring disabled devices

2020-07-02 Thread Daniel Lezcano
On 03/07/2020 03:49, Zhang Rui wrote: > On Thu, 2020-07-02 at 19:49 +0200, Daniel Lezcano wrote: [ ... ] >>> So the reason is that ->get_temp() is called while the mutex is >>> held and >>> thermal_zone_device_is_enabled() wants to take the same mutex. >> &

Re: [PATCH v7 00/11] Stop monitoring disabled devices

2020-07-02 Thread Daniel Lezcano
On 02/07/2020 19:49, Daniel Lezcano wrote: [ ... ] >> Thanks! >> >> That confirms your suspicions. >> >> So the reason is that ->get_temp() is called while the mutex is held and >> thermal_zone_device_is_enabled() wants to take the same mutex. > > Y

Re: [PATCH v7 00/11] Stop monitoring disabled devices

2020-07-02 Thread Daniel Lezcano
On 02/07/2020 19:19, Andrzej Pietrasiewicz wrote: > Hi, > > W dniu 02.07.2020 o 19:01, Daniel Lezcano pisze: >> On 02/07/2020 15:53, Andrzej Pietrasiewicz wrote: >>> Hi Daniel, >>> >>> >>> >>>>>>>> >>>

Re: [PATCH v7 00/11] Stop monitoring disabled devices

2020-07-02 Thread Daniel Lezcano
On 02/07/2020 15:53, Andrzej Pietrasiewicz wrote: > Hi Daniel, > > > >> >> I did reproduce: >> >> v5.8-rc3 + series => imx6 hang at boot time >> v5.8-rc3 => imx6 boots correctly >> >> So finally I succeeded to reproduce it on my imx7 locally. The sensor >> was failing to init

Re: [PATCH v7 00/11] Stop monitoring disabled devices

2020-07-02 Thread Daniel Lezcano
On 02/07/2020 15:53, Andrzej Pietrasiewicz wrote: > Hi Daniel, > > > >> >> I did reproduce: >> >> v5.8-rc3 + series => imx6 hang at boot time >> v5.8-rc3 => imx6 boots correctly >> >> So finally I succeeded to reproduce it on my imx7 locally. The sensor >> was failing to init

Re: [PATCH v7 00/11] Stop monitoring disabled devices

2020-07-02 Thread Daniel Lezcano
On 01/07/2020 12:23, Andrzej Pietrasiewicz wrote: > Hi, > > W dniu 30.06.2020 o 20:33, Daniel Lezcano pisze: >> On 30/06/2020 18:56, Andrzej Pietrasiewicz wrote: >>> Hi, >>> >>> W dniu 30.06.2020 o 17:53, Daniel Lezcano pisze: >>>> On 30/06/20

Re: [PATCH v7 00/11] Stop monitoring disabled devices

2020-07-01 Thread Daniel Lezcano
On 01/07/2020 12:23, Andrzej Pietrasiewicz wrote: > Hi, > [ ... ] I did reproduce: v5.8-rc3 + series => imx6 hang at boot time v5.8-rc3 => imx6 boots correctly > > What did you reproduce? Timeout logging in to the test system or a > "real" failure of a test? Timeo

Re: [PATCH v7 00/11] Stop monitoring disabled devices

2020-06-30 Thread Daniel Lezcano
On 30/06/2020 18:56, Andrzej Pietrasiewicz wrote: > Hi, > > W dniu 30.06.2020 o 17:53, Daniel Lezcano pisze: >> On 30/06/2020 17:29, Andrzej Pietrasiewicz wrote: >>> Hi Daniel, >>> >>> W dniu 30.06.2020 o 16:53, Daniel Lezcano pisze: >>>> On 3

Re: [PATCH v7 00/11] Stop monitoring disabled devices

2020-06-30 Thread Daniel Lezcano
On 30/06/2020 17:29, Andrzej Pietrasiewicz wrote: > Hi Daniel, > > W dniu 30.06.2020 o 16:53, Daniel Lezcano pisze: >> On 30/06/2020 15:43, Andrzej Pietrasiewicz wrote: >>> Hi Daniel, >>> >>> I am reading the logs and can't find anything

Re: [PATCH v7 00/11] Stop monitoring disabled devices

2020-06-30 Thread Daniel Lezcano
On 30/06/2020 15:43, Andrzej Pietrasiewicz wrote: > Hi Daniel, > > I am reading the logs and can't find anything specific to thermal. > > What I can see is > > "random: crng init done" > > with large times (~200s) and then e.g. > > 'auto-login-action timed out after 283 seconds' > > I'm looki

Re: [PATCH v7 00/11] Stop monitoring disabled devices

2020-06-30 Thread Daniel Lezcano
Hi Andrzej, I've tested your series with kernelci and there are 3 regressions for the imx6. https://kernelci.org/test/job/thermal/branch/testing/kernel/v5.8-rc3-11-gf5e50bf4d3ef/plan/baseline/ On 29/06/2020 14:29, Andrzej Pietrasiewicz wrote: > A respin of v6 with these changes: > > v6..v7:

Re: [PATCH v6 06/11] thermal: Add mode helpers

2020-06-29 Thread Daniel Lezcano
On 29/06/2020 13:16, Andrzej Pietrasiewicz wrote: > Prepare for making the drivers not access tzd's private members. > > Signed-off-by: Andrzej Pietrasiewicz > Reviewed-by: Bartlomiej Zolnierkiewicz > [EXPORT_SYMBOL -> EXPORT_SYMBOL_GPL] > Signed-off-by: Andrzej Pietrasiewicz > [staticize therm

Re: [PATCH v4 00/11] Stop monitoring disabled devices

2020-06-23 Thread Daniel Lezcano
Hi Andrzej, On 28/05/2020 21:20, Andrzej Pietrasiewicz wrote: > There is already a reviewed v3 (not to be confused with RFC v3), which can > be considered for merging: > > https://lore.kernel.org/linux-pm/20200423165705.13585-2-andrze...@collabora.com/ > > Let me cite Bartlomiej Zolnierkiewic

Re: [RFC v3 1/2] thermal: core: Let thermal zone device's mode be stored in its struct

2020-05-25 Thread Daniel Lezcano
On 25/05/2020 21:35, Andrzej Pietrasiewicz wrote: > Hi Daniel, > > W dniu 23.05.2020 o 23:24, Daniel Lezcano pisze: >> Hi Andrzej, >> >> On 17/04/2020 18:20, Andrzej Pietrasiewicz wrote: >>> Thermal zone devices' mode is stored in individual drivers.

Re: [RFC v3 1/2] thermal: core: Let thermal zone device's mode be stored in its struct

2020-05-23 Thread Daniel Lezcano
Hi Andrzej, On 17/04/2020 18:20, Andrzej Pietrasiewicz wrote: > Thermal zone devices' mode is stored in individual drivers. This patch > changes it so that mode is stored in struct thermal_zone_device instead. > > As a result all driver-specific variables storing the mode are not needed > and are

Re: [PATCH v5 1/3] clocksource/drivers/atcpit100: Add andestech atcpit100 timer

2018-01-08 Thread Daniel Lezcano
On 08/01/2018 16:26, Arnd Bergmann wrote: > On Fri, Jan 5, 2018 at 10:31 AM, Daniel Lezcano > wrote: >>>> No. Can't you add in arch/ndis32/Kconfig ? >>>> >>>> +select TIMER_ATCPIT100 >>>> >>>> Like: >>>> >

Re: [PATCH v5 1/3] clocksource/drivers/atcpit100: Add andestech atcpit100 timer

2018-01-05 Thread Daniel Lezcano
On 05/01/2018 09:45, Greentime Hu wrote: > Hi, Daniel: [ ... ] >> [ ... ] >> >>> +config CLKSRC_ATCPIT100 >>> + bool "Clocksource for AE3XX platform" >>> + depends on NDS32 || COMPILE_TEST >>> + depends on HAS_IOMEM >>> + help >>> + This optio

Re: [PATCH v5 1/3] clocksource/drivers/atcpit100: Add andestech atcpit100 timer

2018-01-04 Thread Daniel Lezcano
On 04/01/2018 15:06, Greentime Hu wrote: > Hi, Daniel: > > 2018-01-04 21:50 GMT+08:00 Daniel Lezcano : >> >> Hi, >> >> sorry I missed your answer. Comments below. >> >> On 13/12/2017 07:06, Greentime Hu wrote: >>> Hi, Daniel: >>> >

Re: [PATCH v5 1/3] clocksource/drivers/atcpit100: Add andestech atcpit100 timer

2018-01-04 Thread Daniel Lezcano
Hi, sorry I missed your answer. Comments below. On 13/12/2017 07:06, Greentime Hu wrote: > Hi, Daniel: > > 2017-12-12 18:05 GMT+08:00 Daniel Lezcano : >> On 12/12/2017 06:46, Rick Chen wrote: >>> ATCPIT100 is often used on the Andes architecture, >>> This timer

Re: [PATCH v5 1/3] clocksource/drivers/atcpit100: Add andestech atcpit100 timer

2017-12-12 Thread Daniel Lezcano
On 12/12/2017 06:46, Rick Chen wrote: > ATCPIT100 is often used on the Andes architecture, > This timer provide 4 PIT channels. Each PIT channel is a > multi-function timer, can be configured as 32,16,8 bit timers > or PWM as well. > > For system timer it will set channel 1 32-bit timer0 as clock

Re: [PATCH v2 33/35] clocksource/drivers/atcpit100: Add andestech atcpit100 timer

2017-12-07 Thread Daniel Lezcano
On 27/11/2017 13:28, Greentime Hu wrote: > From: Rick Chen > > ATCPIT100 is often used on the Andes architecture, > This timer provide 4 PIT channels. Each PIT channel is a > multi-function timer, can be configured as 32,16,8 bit timers > or PWM as well. > > For system timer it will set channel

Re: [PATCH v2 34/35] clocksource/drivers/Kconfig: Support andestech atcpit100 timer

2017-12-07 Thread Daniel Lezcano
On 27/11/2017 13:28, Greentime Hu wrote: > From: Rick Chen > > Add CLKSRC_ATCPIT100 for Andestech atcpit100 timer selection. > It often be used in Andestech AE3XX platform. > > Signed-off-by: Rick Chen > Signed-off-by: Greentime Hu > --- > drivers/clocksource/Kconfig |6 ++ > drivers

Re: [PATCH v2 34/35] clocksource/drivers/Kconfig: Support andestech atcpit100 timer

2017-12-07 Thread Daniel Lezcano
On 28/11/2017 03:53, Greentime Hu wrote: > 2017-11-27 22:11 GMT+08:00 Arnd Bergmann : >> On Mon, Nov 27, 2017 at 1:28 PM, Greentime Hu wrote: >>> From: Rick Chen >>> >>> Add CLKSRC_ATCPIT100 for Andestech atcpit100 timer selection. >>> It often be used in Andestech AE3XX platform. >>> >>> Signed-

Re: [PATCH V8 1/3] irq: Add flags to request_percpu_irq function

2017-03-23 Thread Daniel Lezcano
Hi Mark, On Thu, Mar 23, 2017 at 06:54:52PM +, Mark Rutland wrote: > Hi Daniel, > > On Thu, Mar 23, 2017 at 06:42:01PM +0100, Daniel Lezcano wrote: > > In the next changes, we track the interrupts but we discard the timers as > > that does not make sense. The next in

[PATCH V8 1/3] irq: Add flags to request_percpu_irq function

2017-03-23 Thread Daniel Lezcano
ned-off-by: Daniel Lezcano --- arch/arc/kernel/perf_event.c | 2 +- arch/arc/kernel/smp.c| 2 +- arch/arm/kernel/smp_twd.c| 3 ++- arch/arm/xen/enlighten.c | 2 +- drivers/clocksource/arc_timer.c | 2 +- drivers/c

Re: [PATCH 1/2] clocksource: Kconfig: replace USE_OF with OF

2015-06-29 Thread Daniel Lezcano
On 06/17/2015 01:42 PM, Antonio Borneo wrote: USE_OF is used as intermediate Kconfig option by few arch's (ARM, MIPS, Xtensa); in all these cases it implies setting option OF too. Replace the only instance of USE_OF in clocksource with OF. Signed-off-by: Antonio Borneo --- Applied for 4.3 Th

Re: [RFC,PATCH] loopback: calls netif_receive_skb() instead of netif_rx()

2008-02-22 Thread Daniel Lezcano
Eric Dumazet wrote: Daniel Lezcano a écrit : Eric Dumazet wrote: Hi David This is an RFC, based on net-2.6 for convenience only. Thank you [RFC,PATCH] loopback: calls netif_receive_skb() instead of netif_rx() Loopback transmit function loopback_xmit() actually calls netif_rx() to queue a

Re: [RFC,PATCH] loopback: calls netif_receive_skb() instead of netif_rx()

2008-02-21 Thread Daniel Lezcano
Eric Dumazet wrote: Hi David This is an RFC, based on net-2.6 for convenience only. Thank you [RFC,PATCH] loopback: calls netif_receive_skb() instead of netif_rx() Loopback transmit function loopback_xmit() actually calls netif_rx() to queue a skb to the softnet queue, and arms a softirq so

[net-2.6][DRIVER][VETH] fix dev refcount race

2008-02-19 Thread Daniel Lezcano
Subject: veth fix dev refcount race From: Daniel Lezcano <[EMAIL PROTECTED]> When deleting the veth driver, veth_close calls netif_carrier_off for the two extremities of the network device. netif_carrier_off on the peer device will fire an event and hold a reference on the peer device

Re: [PATCH 6/17 net-2.6.26] [NETNS]: Default arp parameters lookup.

2008-02-19 Thread Daniel Lezcano
Daniel Lezcano wrote: Denis V. Lunev wrote: On Tue, 2008-02-19 at 10:51 +0100, Daniel Lezcano wrote: Denis V. Lunev wrote: On Tue, 2008-02-19 at 10:14 +0100, Daniel Lezcano wrote: Denis V. Lunev wrote: Default ARP parameters should be findable regardless of the context. Required to make

Re: [PATCH 6/17 net-2.6.26] [NETNS]: Default arp parameters lookup.

2008-02-19 Thread Daniel Lezcano
Denis V. Lunev wrote: On Tue, 2008-02-19 at 10:51 +0100, Daniel Lezcano wrote: Denis V. Lunev wrote: On Tue, 2008-02-19 at 10:14 +0100, Daniel Lezcano wrote: Denis V. Lunev wrote: Default ARP parameters should be findable regardless of the context. Required to make inetdev_event working

Re: [PATCH 6/17 net-2.6.26] [NETNS]: Default arp parameters lookup.

2008-02-19 Thread Daniel Lezcano
Denis V. Lunev wrote: On Tue, 2008-02-19 at 10:14 +0100, Daniel Lezcano wrote: Denis V. Lunev wrote: Default ARP parameters should be findable regardless of the context. Required to make inetdev_event working. Signed-off-by: Denis V. Lunev <[EMAIL PROTECTED]> --- net/core/neighbour.c

Re: [PATCH 6/17 net-2.6.26] [NETNS]: Default arp parameters lookup.

2008-02-19 Thread Daniel Lezcano
Denis V. Lunev wrote: Default ARP parameters should be findable regardless of the context. Required to make inetdev_event working. Signed-off-by: Denis V. Lunev <[EMAIL PROTECTED]> --- net/core/neighbour.c |4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) diff --git a/net/core/neig

Re: [BUG] IPv6 recursive locking

2008-02-17 Thread Daniel Lezcano
Kristof Provost wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi, I'm running the current git (1309d4e68497184d2fd87e892ddf14076c2bda98) without problems. While I was toying with IPv6 on my local network I managed to completely hang my machine whenever it receives or sends a neighbour

Network namespace status

2008-02-15 Thread Daniel Lezcano
I receive some emails about the current status of the network namespace. I tried to synthesize this information and I uploaded it at: http://lxc.sourceforge.net/network_status.php I hope that can help. -- Daniel -- To unsubscribe from this list: send the line "unsubscribe netdev" i

Re: Network namespace and tc?

2008-02-14 Thread Daniel Lezcano
Denis V. Lunev wrote: Hello, Stephen! Namespaces are not fully implemented yet :) Right now we we have only basic infrastructure in the mainstream and, currently, we can't even run TCP in different namespace :( We hope this will be changed very soon. These marks (net != &init_net) are used to -

Re: ipv6_chk_acast_addr remove unused loop

2008-02-08 Thread Daniel Lezcano
David Stevens wrote: NACK. Daniel, This code is part of the in-kernel API for anycast, which is intended to be the same as for multicast. By removing support for NULL there, you're making a special case for the anycast code that isn't there in the multicast code (can't support a NULL

ipv6_chk_acast_addr remove unused loop

2008-02-08 Thread Daniel Lezcano
Subject: ipv6_chk_acast_addr remove unused loop From: Daniel Lezcano <[EMAIL PROTECTED]> The ipv6_chk_acast_addr is called with a netdev pointer parameter which can be NULL. This value is used as a wildcard to browse the netdev list and search if a device is owning the address. But when l

Re: [PATCH] [NETNS] Remove unused member (dst_net) of dst_ops.

2008-02-08 Thread Daniel Lezcano
Denis V. Lunev wrote: This has been added by the Daniel Lezcano <[EMAIL PROTECTED]> in the commit d4fa26ff44e31c2636a985e3092e2cd55d8045de. It looks to me a preparatory staff for IPv6 namespacing. I think this is not needed in 2.6.25 but will be required in 2.6.26 very soon. Yes, t

Re: [RFC] [IPV4][IPV6][TCP] remove skb->dev NULL assignation in tcp_v[4|6]_rcv functions

2008-02-07 Thread Daniel Lezcano
David Miller wrote: From: Daniel Lezcano <[EMAIL PROTECTED]> Date: Thu, 07 Feb 2008 12:17:27 +0100 Subject: [RFC] remove skb->dev NULL assignation I was trying to figure out why in the tcp_v4_rcv/tcp_v6_rcv function, the skb->dev field is set to NULL. There is certainly a good r

[RFC] [IPV4][IPV6][TCP] remove skb->dev NULL assignation in tcp_v[4|6]_rcv functions

2008-02-07 Thread Daniel Lezcano
Subject: [RFC] remove skb->dev NULL assignation From: Daniel Lezcano <[EMAIL PROTECTED]> I was trying to figure out why in the tcp_v4_rcv/tcp_v6_rcv function, the skb->dev field is set to NULL. There is certainly a good reason, but I was not able to find it. Is it possible to

Re: [patch 14/14] replace __inline__ by inline in include/linux (net related)

2008-02-06 Thread Daniel Lezcano
David Miller wrote: > From: Daniel Lezcano <[EMAIL PROTECTED]> > Date: Wed, 06 Feb 2008 11:39:27 +0100 > >> YOSHIFUJI Hideaki / 吉藤英明 wrote: >>> In article <[EMAIL PROTECTED]> (at Wed, 06 Feb 2008 10:14:19 +0100), Daniel >>> Lezcano <[EMAIL PROTECT

Re: [patch 14/14] replace __inline__ by inline in include/linux (net related)

2008-02-06 Thread Daniel Lezcano
YOSHIFUJI Hideaki / 吉藤英明 wrote: In article <[EMAIL PROTECTED]> (at Wed, 06 Feb 2008 10:14:19 +0100), Daniel Lezcano <[EMAIL PROTECTED]> says: replace __inline__ by inline in include/linux (net related) Signed-off-by: Daniel Lezcano <[EMAIL PROTECTED]> --- include/linux/a

[patch 13/14] replace __inline__ by inline in include/net

2008-02-06 Thread Daniel Lezcano
replace __inline__ by inline in include/net Signed-off-by: Daniel Lezcano <[EMAIL PROTECTED]> --- include/net/addrconf.h |2 +- include/net/ax25.h |2 +- include/net/checksum.h |4 ++-- include/net/dn_nsp.h | 16 include/ne

[patch 11/14] replace __inline__ by inline in net/key

2008-02-06 Thread Daniel Lezcano
replace __inline__ by inline in net/key Signed-off-by: Daniel Lezcano <[EMAIL PROTECTED]> --- net/key/af_key.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) Index: net-2.6/net/key/af_key.c === --- net-2.6.or

[patch 08/14] replace __inline__ by inline in net/x25

2008-02-06 Thread Daniel Lezcano
replace __inline__ by inline in net/x25 Signed-off-by: Daniel Lezcano <[EMAIL PROTECTED]> --- net/x25/x25_proc.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) Index: net-2.6/net/x25/x25_proc.c === --- net-2.

[patch 10/14] replace __inline__ by inline in net/lapb

2008-02-06 Thread Daniel Lezcano
replace __inline__ by inline in net/lapb Signed-off-by: Daniel Lezcano <[EMAIL PROTECTED]> --- net/lapb/lapb_iface.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Index: net-2.6/net/lapb/lapb_iface.c === --- n

[patch 12/14] replace __inline__ by inline in net/ipx

2008-02-06 Thread Daniel Lezcano
replace __inline__ by inline in net/ipx Signed-off-by: Daniel Lezcano <[EMAIL PROTECTED]> --- net/ipx/af_ipx.c |2 +- net/ipx/ipx_proc.c |6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) Index: net-2.6/net/ipx/af

[patch 14/14] replace __inline__ by inline in include/linux (net related)

2008-02-06 Thread Daniel Lezcano
replace __inline__ by inline in include/linux (net related) Signed-off-by: Daniel Lezcano <[EMAIL PROTECTED]> --- include/linux/atm.h|4 ++-- include/linux/atmsap.h |2 +- include/linux/hdlc.h | 13 +++-- include/linux/inetdevice.h

[patch 09/14] replace __inline__ by inline in net/llc

2008-02-06 Thread Daniel Lezcano
replace __inline__ by inline in net/llc Signed-off-by: Daniel Lezcano <[EMAIL PROTECTED]> --- net/llc/llc_input.c |2 +- net/llc/llc_station.c |3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) Index: net-2.6/net/llc/llc_i

[patch 05/14] replace __inline__ by inline in net/core

2008-02-06 Thread Daniel Lezcano
replace __inline__ by inline in net/core Signed-off-by: Daniel Lezcano <[EMAIL PROTECTED]> --- net/core/neighbour.c |2 +- net/core/pktgen.c|2 +- net/core/scm.c |2 +- 3 files changed, 3 insertions(+), 3 deletions(-) Index: net-2.6/net/core/neigh

[patch 02/14] replace __inline__ by inline in net/ipv6

2008-02-06 Thread Daniel Lezcano
replace __inline__ by inline in net/ipv6 Signed-off-by: Daniel Lezcano <[EMAIL PROTECTED]> --- net/ipv6/af_inet6.c |2 +- net/ipv6/icmp.c |6 +++--- net/ipv6/ip6_fib.c | 12 ++-- net/ipv6/ip6_flowl

[patch 07/14] replace __inline__ by inline in net/sched

2008-02-06 Thread Daniel Lezcano
replace __inline__ by inline in net/sched Signed-off-by: Daniel Lezcano <[EMAIL PROTECTED]> --- net/sched/cls_fw.c|2 +- net/sched/cls_route.c | 10 +- net/sched/cls_u32.c | 10 +- net/sched/sch_cbq.c | 35 --- net/sched/sch

[patch 04/14] replace __inline__ by inline in net/atm

2008-02-06 Thread Daniel Lezcano
replace __inline__ by inline in net/atm Signed-off-by: Daniel Lezcano <[EMAIL PROTECTED]> --- net/atm/lec.c |4 ++-- net/atm/resources.c |2 +- 2 files changed, 3 insertions(+), 3 deletions(-) Index: net-2.6/net/atm

[patch 06/14] replace __inline__ by inline in net/decnet

2008-02-06 Thread Daniel Lezcano
replace __inline__ by inline in net/decnet Signed-off-by: Daniel Lezcano <[EMAIL PROTECTED]> --- net/decnet/dn_dev.c |2 +- net/decnet/dn_nsp_in.c |3 ++- net/decnet/dn_nsp_out.c |9 + net/decnet/dn_route.c |2 +- net/decnet/dn_table.c

[patch 03/14] replace __inline__ by inline in net/appletalk

2008-02-06 Thread Daniel Lezcano
replace __inline__ by inline in net/appletalk Signed-off-by: Daniel Lezcano <[EMAIL PROTECTED]> --- net/appletalk/atalk_proc.c |6 +++--- net/appletalk/ddp.c|2 +- 2 files changed, 4 insertions(+), 4 deletions(-) Index: net-2.6/net/appletalk/atalk_

[patch 00/14] replace __inline__ by inline in net code

2008-02-06 Thread Daniel Lezcano
The following patchset replaces all occurences of __inline__ by inline and make some minor coding style fixes. It touches: . net/* files . include/net/* files . include/linux/* files (only the ones related to the network) The patchset touches a lot of files and that can probably increase th

[patch 01/14] replace __inline__ by inline in net/ipv4

2008-02-06 Thread Daniel Lezcano
replace __inline__ by inline in net/ipv4 Signed-off-by: Daniel Lezcano <[EMAIL PROTECTED]> --- net/ipv4/devinet.c|2 +- net/ipv4/fib_semantics.c |2 +- net/ipv4/igmp.c |2 +- net/ipv4/ip_fragment.c|8 net/ipv4/ip_output.c |2 +- ne

[FIB] fix fib_proc compilation error

2008-02-05 Thread Daniel Lezcano
Subject: fix fib_proc compilation error From: Daniel Lezcano <[EMAIL PROTECTED]> Fix fib_proc_[init|exit] definition when CONFIG_PROCFS=no Signed-off-by: Daniel Lezcano <[EMAIL PROTECTED]> --- include/net/ip_fib.h | 10 ++ 1 file changed, 10 insertions(+) Index: net-2.6

[IPV6] fix sysctl compilation error

2008-02-05 Thread Daniel Lezcano
Subject: fix sysctl compilation error From: Daniel Lezcano <[EMAIL PROTECTED]> Move ipv6_icmp_sysctl_init and ipv6_route_sysctl_init into the right ifdef section otherwise that does not compile when CONFIG_SYSCTL=yes and CONFIG_PROC_FS=no Signed-off-by: Daniel Lezcano <[EMAIL PROTECTE

Re: [PATCH 0/6] preparations to enable netdevice notifiers inside a namespace (resend)

2008-01-31 Thread Daniel Lezcano
Benjamin Thery wrote: On Jan 31, 2008 3:58 PM, Daniel Lezcano <[EMAIL PROTECTED]> wrote: Denis V. Lunev wrote: Here are some preparations and cleanups to enable network device/inet address notifiers inside a namespace. This set of patches has been originally sent last Friday. One c

Re: [PATCH 0/6] preparations to enable netdevice notifiers inside a namespace (resend)

2008-01-31 Thread Daniel Lezcano
Denis V. Lunev wrote: Here are some preparations and cleanups to enable network device/inet address notifiers inside a namespace. This set of patches has been originally sent last Friday. One cleanup patch from the original series is dropped as wrong, thanks to Daniel Lezcano. Can you explain

Re: net-2.6.25 is no more...

2008-01-30 Thread Daniel Lezcano
Arnaldo Carvalho de Melo wrote: Em Wed, Jan 30, 2008 at 06:38:53PM +0100, Daniel Lezcano escreveu: David Miller wrote: From: Daniel Lezcano <[EMAIL PROTECTED]> Date: Wed, 30 Jan 2008 10:03:09 +0100 David Miller wrote: Now that the bulk has been merged over and we are actively w

Re: net-2.6.25 is no more...

2008-01-30 Thread Daniel Lezcano
David Miller wrote: From: Daniel Lezcano <[EMAIL PROTECTED]> Date: Wed, 30 Jan 2008 10:03:09 +0100 David Miller wrote: Now that the bulk has been merged over and we are actively working alongside Linus's tree I have moved all current patch applying to net-2.6 instead of net-2.6

Re: net-2.6.25 is no more...

2008-01-30 Thread Daniel Lezcano
David Miller wrote: Now that the bulk has been merged over and we are actively working alongside Linus's tree I have moved all current patch applying to net-2.6 instead of net-2.6.25, so the current tree to use is: kernel.org:/pub/scm/linux/kernel/git/davem/net-2.6.git This tree is for

Re: 2.6.24-git6 net build failure when SYSFS=n, PROC_FS=n

2008-01-30 Thread Daniel Lezcano
Randy Dunlap wrote: linux-2.6.24-git6/net/ipv4/fib_frontend.c: In function 'fib_net_init': linux-2.6.24-git6/net/ipv4/fib_frontend.c:1024: error: implicit declaration of function 'fib_proc_init' linux-2.6.24-git6/net/ipv4/fib_frontend.c: In function 'fib_net_exit': linux-2.6.24-git6/net/ipv4/fib

[patch 09/11][NETNS][IPV6] fib6_rules: make per network namespace

2008-01-25 Thread Daniel Lezcano
namespace aware, so it is quite easy to retrieve the network namespace from the rules and use it in the different callbacks. Signed-off-by: Daniel Lezcano <[EMAIL PROTECTED]> --- include/net/netns/ipv6.h |1 net/ipv6/fib6_rules.c| 82 ++- 2

[patch 11/11][NETNS][IPV6] rt6_stats - make rt6_stats per namespace

2008-01-25 Thread Daniel Lezcano
The rt6_stats is now per namespace with this patch. It is allocated when a network namespace is created and freed when the network namespace exits and references are relative to the network namespace. Signed-off-by: Benjamin Thery <[EMAIL PROTECTED]> Signed-off-by: Daniel Lezcano &

[patch 05/11][NETNS][IPV6] ip6_fib - dynamically allocate the gc_timer

2008-01-25 Thread Daniel Lezcano
The ip6_fib_timer gc timer is dynamically allocated and initialized in the ip6 fib init function. There are no more references to a static global variable. That will allow to make multiple instance of the garbage collecting timer and make them per namespace. Signed-off-by: Daniel Lezcano <[EM

[patch 08/11][NETNS][IPV6] fib6_rules - dynamically allocate the fib rules ops

2008-01-25 Thread Daniel Lezcano
The fib6_rules_ops structure is dynamically allocated, so that allows to make several instances of it per network namespace. The global static fib6_rules_ops structure is renamed to fib6_rules_ops_template in order to quickly memcopy it for the structure initialization. Signed-off-by: Daniel

[patch 10/11][NETNS][IPV6] rt6_stats - dynamically allocate the rt6_stats

2008-01-25 Thread Daniel Lezcano
This patch allocates the rt6_stats struct dynamically when the fib6 is initialized. That provides the ability to create several instances of this structure for the network namespaces. Signed-off-by: Daniel Lezcano <[EMAIL PROTECTED]> Signed-off-by: Benjamin Thery <[EMAIL PROTECTED]>

[patch 06/11][NETNS][IPV6] ip6_fib - make the ip6 fib gc timer per network namespace

2008-01-25 Thread Daniel Lezcano
Move the timer initialization at the network namespace creation and store the network namespace in the timer argument. That enables multiple timers (one per network namespace) to do garbage collecting. Signed-off-by: Daniel Lezcano <[EMAIL PROTECTED]> Signed-off-by: Benjamin Thery &

[patch 07/11][NETNS][IPV6] make fib6_clean_node to use the network namespace

2008-01-25 Thread Daniel Lezcano
parameter when needed to propagate the netns pointer. Signed-off-by: Daniel Lezcano <[EMAIL PROTECTED]> --- net/ipv6/ip6_fib.c | 25 +++-- 1 file changed, 15 insertions(+), 10 deletions(-) Index: net-2.6.25/net/ipv6/ip6

[patch 04/11][NETNS][IPV6] ip6_fib - pass the network namespace parameter to timer callback

2008-01-25 Thread Daniel Lezcano
code cleaner for the fib6_run_gc callers. Signed-off-by: Daniel Lezcano <[EMAIL PROTECTED]> Signed-off-by: Benjamin Thery <[EMAIL PROTECTED]> --- include/net/ip6_fib.h |3 ++- net/ipv6/ip6_fib.c| 24 net/ipv6/ndisc.c |5 +++-- net/ipv6/route.c

[patch 03/11][NETNS][IPV6] ip6_fib - make fib6_clean_all per namespace

2008-01-25 Thread Daniel Lezcano
The function fib6_clean_all takes the network namespace as parameter. That allows to flush the routes related to a specific network namespace. Signed-off-by: Daniel Lezcano <[EMAIL PROTECTED]> Signed-off-by: Benjamin Thery <[EMAIL PROTECTED]> --- include/net/ip6_fib.h |3 ++-

[patch 02/11][NETNS][IPV6] ip6_fib - make the tables per namespace

2008-01-25 Thread Daniel Lezcano
the namespaces but the callers not yet. Signed-off-by: Daniel Lezcano <[EMAIL PROTECTED]> Signed-off-by: Benjamin Thery <[EMAIL PROTECTED]> --- include/net/ip6_fib.h|9 +- include/net/netns/ipv6.h |6 + net/ipv6/fib6_rules.c|8 +- net/ipv6/ip6_fib.c

[patch 01/11][NETNS][IPV6] ip6_fib - dynamically allocate the tables

2008-01-25 Thread Daniel Lezcano
This patch changes the fib6 tables to be dynamically allocated. That provides the ability to make several instances of them when a new network namespace is created. Signed-off-by: Daniel Lezcano <[EMAIL PROTECTED]> Signed-off-by: Benjamin Thery <[EMAIL PROTECTED]> --- net/ipv6/ip6_

[patch 00/11][NETNS][IPV6] make a subset of the routing per namespace

2008-01-25 Thread Daniel Lezcano
This patchset makes a subset of the routing to be per namespace. It takes into account fib tables, garbage collecting timer, fib rules and route statistics. The routing per namespace is not complete with this patchset, so there are some interactions between the init network namespace and other nam

Re: [PATCH 3/7 net-2.6.25] [IPV4]: Prohibit assignment of 0.0.0.0 as interface address.

2008-01-25 Thread Daniel Lezcano
Denis V. Lunev wrote: Daniel Lezcano wrote: Denis V. Lunev wrote: Daniel Lezcano wrote: Denis V. Lunev wrote: I could hardly imagine why sombady needs to assign 0.0.0.0 as an interface address or interface destination address. The kernel will behave in a strage way in several places if this

Re: [PATCH 3/7 net-2.6.25] [IPV4]: Prohibit assignment of 0.0.0.0 as interface address.

2008-01-25 Thread Daniel Lezcano
Denis V. Lunev wrote: Daniel Lezcano wrote: Denis V. Lunev wrote: I could hardly imagine why sombady needs to assign 0.0.0.0 as an interface address or interface destination address. The kernel will behave in a strage way in several places if this is possible, as ifa_local != 0 is considered

Re: [PATCH 3/7 net-2.6.25] [IPV4]: Prohibit assignment of 0.0.0.0 as interface address.

2008-01-25 Thread Daniel Lezcano
Denis V. Lunev wrote: Daniel Lezcano wrote: Denis V. Lunev wrote: I could hardly imagine why sombady needs to assign 0.0.0.0 as an interface address or interface destination address. The kernel will behave in a strage way in several places if this is possible, as ifa_local != 0 is considered

Re: [PATCH 3/7 net-2.6.25] [IPV4]: Prohibit assignment of 0.0.0.0 as interface address.

2008-01-25 Thread Daniel Lezcano
Denis V. Lunev wrote: I could hardly imagine why sombady needs to assign 0.0.0.0 as an interface address or interface destination address. The kernel will behave in a strage way in several places if this is possible, as ifa_local != 0 is considered as initialized/non-initialized state of the ifa.

[patch net-2.6.25][IPV6][SYSCTL] fix sysctl compilation error

2008-01-25 Thread Daniel Lezcano
Subject: fix sysctl compilation error From: Daniel Lezcano <[EMAIL PROTECTED]> Move ipv6_icmp_sysctl_init and ipv6_route_sysctl_init into the right ifdef section otherwise that does not compile when CONFIG_SYSCTL=yes and CONFIG_PROC_FS=no Signed-off-by: Daniel Lezcano <[EMAIL

[patch net-2.6.25][IPV4][FIB] fix fib_proc compilation error

2008-01-25 Thread Daniel Lezcano
Subject: fix fib_proc compilation error From: Daniel Lezcano <[EMAIL PROTECTED]> Fix fib_proc_[init|exit] definition when CONFIG_PROCFS=no Signed-off-by: Daniel Lezcano <[EMAIL PROTECTED]> --- include/net/ip_fib.h | 10 ++ 1 file changed, 10 insertions(+) Index: ne

Re: 2.6.24 regression: reference count leak in PPPoE

2008-01-20 Thread Daniel Lezcano
Andi Kleen wrote: My workstation running 2.6.24-rc8 just hung during shutdown with an endless (or rather I didn't wait more than a few minutes) loop of unregister_netdev: waiting for ppp-device to become free. Usage count = 1 ppp-device was an active PPPoE device. No more information current

[PATCH net-2.6.25][NET_NS][IPV6] fix ip6_frags.ctl oops

2008-01-18 Thread Daniel Lezcano
Subject: fix ip6_frag ctl From: Daniel Lezcano <[EMAIL PROTECTED]> Alexey Dobriyan reported an oops when unsharing the network indefinitely inside a loop. This is because the ip6_frag is not per namespace while the ctls are. That happens at the fragment timer expi

  1   2   3   >