[no subject]

David Miller wrote: > > Is there going to be a merge of net into net-next before the merge > > window opens? Or do you have a sample merge that I can rebase my > > afs-next branch on? > > I'll be doing a net to net-next merge some time today. Excellent, thanks! David

[no subject]

Hi Dave, Is there going to be a merge of net into net-next before the merge window opens? Or do you have a sample merge that I can rebase my afs-next branch on? The problem I have is that there's a really necessary patch in net that's not in net-next:

Re: [PATCH net] rxrpc: Fix incorrect conditional on IPV6

David Miller wrote: > > Nit : Correct attribution would require a Reported-by: tag > > Right. And I've posted a new version with that and the reviewed-by from Arnd. David

Re: [PATCH net] rxrpc: Fix incorrect conditional on IPV6

Eric Dumazet wrote: > Nit : Correct attribution would require a Reported-by: tag Point. I'll repost it with a To: line also, I'm waiting to see if Arnd will ack it. David

Re: [PATCH net-next] rxrpc: Remove set but not used variable 'ioc'

Dan Carpenter wrote: > I told him to do that because it wasn't a bugfix... Probably just Fixes > is the right thing to use though. But the correct fix *is* a bug fix. David

Re: [PATCH net-next] rxrpc: Remove set but not used variable 'ioc'

YueHaibing wrote: > net/rxrpc/output.c: In function 'rxrpc_reject_packets': > net/rxrpc/output.c:527:11: warning: > variable 'ioc' set but not used [-Wunused-but-set-variable] > > It never used since introduction in I wonder why my compiler doesn't show this warning. Anyway, NAK: just

[PATCH net-next 2/9] rxrpc: Emit the data Tx trace line before transmitting

Print the data Tx trace line before transmitting so that it appears before the trace lines indicating success or failure of the transmission. This makes the trace log less confusing. Signed-off-by: David Howells --- net/rxrpc/output.c |8 1 file changed, 4 insertions(+), 4

Re: How to post rxrpc patches for net-next with deps on net?

David Miller wrote: > Just FYI, net has been merged into net-next. I saw, thanks. I've rebased my rxrpc-next on it, tagged it and pushed. Will mail a request soon. Thanks, David

How to post rxrpc patches for net-next with deps on net?

Hi Dave, I have some rxrpc patches to post for your net-next/master branch, but there's a dependency in them on the rxrpc-fixes-20180928 tag you pulled into your net/master branch. What's the best way to handle this? (1) Wait for you to merge net into net-next? (2) Base it on my own merge of

Re: r8169 tx batching(?) causing performance problems

David Miller wrote: > Probably you are seeing some interrupt mitigation. > > It seems there is a difference in how the interrupt mitigation is > programmed on for 8168 chips vs. others by default. Most get > all zeros in the IntrMitigate register, whilst for 8168 chips > a value of 0x5151 is

Re: r8169 tx batching(?) causing performance problems

David Howells wrote: > Can someone help me figure out a performance issue that seems to be caused by > an RTL8168g/8111g NIC that seems to be batching up transmissions - or, at > least, not starting immediately that it's given something to transmit? I've been told that:

r8169 tx batching(?) causing performance problems

flag signify? The NIC is setting it, but nothing in the driver takes any notice of it or clears it. Thanks, David --- commit 4ce09fa309d8fb4b1b910091607c2290c45541f1 Author: David Howells Date: Tue Oct 2 21:14:04 2018 +0100 Add tracepoints for Realtek r8169 diff --git a/drivers/net/ethernet

Massive delays between packet rx and UDP ->data_ready handoff

Hi, I'm seeing occasional massive delays between packets being received in the r8169 driver and them turning up in the rxrpc_data_ready() function called by the UDP or UDP6 ->data_ready() handler. By massive, I mean I've seen anything up to about 4s. I *think* that the effect gets rapidly worse

Re: Is it possible to get Rx timestamps in skb->tstamp?

Toke Høiland-Jørgensen wrote: > > Is it possible to tell a UDP socket that you'd like it to put > > reception timestamps in skb->tstamp? > > I think you probably want SO_TIMESTAMP*? > > See >

Is it possible to get Rx timestamps in skb->tstamp?

Hi, Is it possible to tell a UDP socket that you'd like it to put reception timestamps in skb->tstamp? For some reason, I seem to remember that the kernel used to put something in there - and AF_RXRPC makes use of it. David

[PATCH net-next] rxrpc: Remove set but not used variable 'nowj'

-by: Wei Yongjun Signed-off-by: David Howells --- net/rxrpc/proc.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/net/rxrpc/proc.c b/net/rxrpc/proc.c index 163d05df339d..9805e3b85c36 100644 --- a/net/rxrpc/proc.c +++ b/net/rxrpc/proc.c @@ -63,7 +63,7 @@ static int

Re: [lkp-robot] [bisect done] ace45bec6d [ 52.056290] EIP: lock_release

kernel test robot wrote: > 0day kernel testing robot got the below dmesg and the first bad commit is > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master > > commit ace45bec6d77bc061c3c3d8ad99e298ea9800c2b > Author: David Howells > AuthorDate

Re: [PATCH net] KEYS: DNS: fix parsing multiple options

Simon Horman wrote: > > - eq = memchr(opt, '=', opt_len) ?: end; > > + eq = memchr(opt, '=', opt_len) ?: next_opt; > > opt_nlen = eq - opt; > > eq++; > > It seems risky to advance eq++ in the case there the value is

Re: [PATCH net] KEYS: DNS: fix parsing multiple options

tl padd dns_resolver desc @s (Note this is preexisting and nothing to do with your patch). I'm not sure how best to handle this. Anyway, Dave, can you take Eric's patch into the net tree with: Acked-by: David Howells David

'Adding' a writable proc file under /proc/net/afs/ [was [PATCH 3/3] afs: Implement namespacing]

Christoph Hellwig wrote: > So the real question here is why afs needs a write callback as the first > user of /proc/net ever in a day and time were we've deprecated adding > new proc files. This is a discussion that should be had with linux-fsdevel > and netdev in Cc.

[PATCH net 0/5] rxrpc: Fixes

/linux/kernel/git/dhowells/linux-fs.git/log/?h=rxrpc-fixes David --- David Howells (5): rxrpc: Fix missing start of call timeout rxrpc: Fix error reception on AF_INET6 sockets rxrpc: Fix the min security level for kernel calls rxrpc: Add a tracepoint to log ICMP/ICMP6

[PATCH net 1/5] rxrpc: Fix missing start of call timeout

: a158bdd3247b ("rxrpc: Fix call timeouts") Reported-by: Marc Dionne <marc.dio...@auristor.com> Signed-off-by: David Howells <dhowe...@redhat.com> --- net/rxrpc/ar-internal.h |1 + net/rxrpc/input.c |2 +- net/rxrpc/output.c | 11 +++ net/rxrpc/sendmsg.c

[PATCH net 2/5] rxrpc: Fix error reception on AF_INET6 sockets

if the socket is of the AF_INET6 family. Without this, kAFS server and address rotation doesn't work correctly because the algorithm doesn't detect received network errors. Fixes: 75b54cb57ca3 ("rxrpc: Add IPv6 support") Signed-off-by: David Howells <dhowe...@redhat.com> --- net/rxrp

[PATCH net 3/5] rxrpc: Fix the min security level for kernel calls

Fix the kernel call initiation to set the minimum security level for kernel initiated calls (such as from kAFS) from the sockopt value. Fixes: 19ffa01c9c45 ("rxrpc: Use structs to hold connection params and protocol info") Signed-off-by: David Howells <dhowe...@redhat.com>

[PATCH net 4/5] rxrpc: Add a tracepoint to log ICMP/ICMP6 and error messages

Add a tracepoint to log received ICMP/ICMP6 events and other error messages. Signed-off-by: David Howells <dhowe...@redhat.com> --- include/trace/events/rxrpc.h | 30 +++ net/rxrpc/peer_event.c | 46 +- 2 files c

[PATCH net 5/5] rxrpc: Trace UDP transmission failure

Add a tracepoint to log transmission failure from the UDP transport socket being used by AF_RXRPC. Signed-off-by: David Howells <dhowe...@redhat.com> --- include/trace/events/rxrpc.h | 55 ++ net/rxrpc/conn_event.c | 11 ++-- net

Re: simplify procfs code for seq_file instances V2

Note that your kernel hits the: inconsistent {HARDIRQ-ON-W} -> {IN-HARDIRQ-W} usage. swapper/0/0 [HC1[1]:SC0[0]:HE0:SE1] takes: (ptrval) (fs_reclaim){?.+.}, at: fs_reclaim_acquire+0x12/0x35 {HARDIRQ-ON-W} state was registered at:

Re: [PATCH 20/39] afs: simplify procfs code

Christoph Hellwig wrote: > I don't think you should need any of these. seq_file_net or > seq_file_single_net will return you the net_ns based on a struct > seq_file. And even from your write routines you can reach the > seq_file in file->private pretty easily. You've taken away

Re: [PATCH 04/40] proc: introduce proc_create_seq{,_data}

Christoph Hellwig wrote: > + > +struct proc_dir_entry *proc_create_seq_data(const char *name, umode_t mode, > + struct proc_dir_entry *parent, const struct seq_operations *ops, > + void *data) > +{ > ... > +EXPORT_SYMBOL(proc_create_seq_data); Please add

[PATCH 02/02] afs: Implement namespacing

Implement namespacing within AFS, but don't yet let mounts occur outside the init namespace. An additional patch will be required propagate the network namespace across automounts. Signed-off-by: David Howells <dhowe...@redhat.com> --- cell.c |4 +- internal.h

[PATCH 01/02] net: Export get_proc_net()

independently of the others. Signed-off-by: David Howells <dhowe...@redhat.com> --- fs/proc/proc_net.c |3 ++- include/linux/proc_fs.h |2 ++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/fs/proc/proc_net.c b/fs/proc/proc_net.c index 1763f370489d..23d56146e38f

Re: [PATCH 20/39] afs: simplify procfs code

David Howells <dhowe...@redhat.com> wrote: > > Use remove_proc_subtree to remove the whole subtree on cleanup, and > > unwind the registration loop into individual calls. Switch to use > > proc_create_seq where applicable. > > Note that this is likely going

Re: [PATCH 20/39] afs: simplify procfs code

Christoph Hellwig wrote: > Use remove_proc_subtree to remove the whole subtree on cleanup, and > unwind the registration loop into individual calls. Switch to use > proc_create_seq where applicable. Note that this is likely going to clash with my patch to net-namespace all of the

Re: linux-next: build failure after merge of the tip tree

Stephen Rothwell wrote: > + wait_var_event(>nr_calls, !atomic_read(>nr_calls)); I would prefer == 0 to ! as it's not really a true/false value. But apart from that, it's looks okay and you can add my Reviewed-by. David

Re: linux-next: build failure after merge of the tip tree

Peter Zijlstra wrote: > I figured that since there were only a handful of users it wasn't a > popular API, also David very much knew of those patches changing it so > could easily have pulled in the special tip/sched/wait branch :/ I'm not sure I could, since I have to

[PATCH net-next] rxrpc: Fix undefined packet handling

By analogy with other Rx implementations, RxRPC packet types 9, 10 and 11 should just be discarded rather than being aborted like other undefined packet types. Reported-by: Jeffrey Altman <jalt...@auristor.com> Signed-off-by: David Howells <dhowe...@redhat.com> --- net/rxrpc/input

[PATCH net-next 00/12] rxrpc: Fixes and more traces

are tagged here: git://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git rxrpc-next-20180330 and can also be found on this branch: http://git.kernel.org/cgit/linux/kernel/git/dhowells/linux-fs.git/log/?h=rxrpc-next David --- David Howells (10): rxrpc: Fix

[PATCH net-next 01/12] rxrpc: Fix firewall route keepalive

was transmitted to that peer. Also, just discard VERSION REPLY packets rather than replying to them. Signed-off-by: David Howells <dhowe...@redhat.com> --- net/rxrpc/af_rxrpc.c|4 ++ net/rxrpc/ar-internal.h | 14 ++- net/rxrpc/conn_event.c |3 + net/rxrpc/input.c

[PATCH net-next 02/12] rxrpc: Fix a bit of time confusion

of the code. Fixes: a158bdd3247b ("rxrpc: Fix call timeouts") Signed-off-by: David Howells <dhowe...@redhat.com> --- net/rxrpc/call_event.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/rxrpc/call_event.c b/net/rxrpc/call_event.c index 6a62e42e1d8d..3de

[PATCH net-next 03/12] rxrpc: Fix Tx ring annotation after initial Tx failure

rxrpc: Rewrite the data and ack handling code") Signed-off-by: David Howells <dhowe...@redhat.com> --- net/rxrpc/sendmsg.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/net/rxrpc/sendmsg.c b/net/rxrpc/sendmsg.c index 8503f279b467..783c777fc6e7 100644 --- a/net

[PATCH net-next 04/12] rxrpc: Don't treat call aborts as conn aborts

with the new call automatically terminate the old call. Fixes: 18bfeba50dfd ("rxrpc: Perform terminal call ACK/ABORT retransmission from conn processor") Reported-by: Marc Dionne <marc.dio...@auristor.com> Signed-off-by: David Howells <dhowe...@redhat.com> --- net/rxrpc/input.c |

[PATCH net-next 07/12] rxrpc: Fix checker warnings and errors

) Checker doesn't correctly handle of seq-retry lock context balance in rxrpc_find_service_conn_rcu(). (*) Checker thinks execution may proceed past the BUG() in rxrpc_publish_service_conn(). (*) Variable length array warnings from SKCIPHER_REQUEST_ON_STACK() in rxkad.c. Signed-off-

[PATCH net-next 06/12] rxrpc: remove unused static variables

-by: kbuild test robot <fengguang...@intel.com> Signed-off-by: Sebastian Andrzej Siewior <bige...@linutronix.de> Signed-off-by: David Howells <dhowe...@redhat.com> --- net/rxrpc/security.c |3 --- 1 file changed, 3 deletions(-) diff --git a/net/rxrpc/security.c b/net/r

[PATCH net-next 08/12] rxrpc: Fix potential call vs socket/net destruction race

arning: incorrect type in argument 1 (different address spaces) net/rxrpc/call_object.c:634:57:expected struct sock const *sk net/rxrpc/call_object.c:634:57:got struct sock [noderef] * Fixes: 2baec2c3f854 ("rxrpc: Support network namespacing") Signed-off-by: David Howells <

[PATCH net-next 05/12] rxrpc: Fix resend event time calculation

uot;rxrpc: Fix call timeouts") Signed-off-by: Marc Dionne <marc.dio...@auristor.com> Signed-off-by: David Howells <dhowe...@redhat.com> --- net/rxrpc/call_event.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/rxrpc/call_event.c b/net/rxrpc/call_event

[PATCH net-next 11/12] rxrpc: Add a tracepoint to track rxrpc_peer refcounting

Add a tracepoint to track reference counting on the rxrpc_peer struct. Signed-off-by: David Howells <dhowe...@redhat.com> --- include/trace/events/rxrpc.h | 42 +++ net/rxrpc/ar-internal.h | 23 +++ net/rxrpc/peer_event.c |2 + net

[PATCH net-next 10/12] rxrpc: Fix apparent leak of rxrpc_local objects

! Fix this by keeping a count of the live connections and waiting for it to go to zero at the end of rxrpc_destroy_all_connections(). Fixes: dee46364ce6f ("rxrpc: Add RCU destruction for connections and calls") Signed-off-by: David Howells <dhowe...@redhat.com> --- net/rxrpc/ar-in

[PATCH net-next 09/12] rxrpc: Add a tracepoint to track rxrpc_local refcounting

Add a tracepoint to track reference counting on the rxrpc_local struct. Signed-off-by: David Howells <dhowe...@redhat.com> --- include/trace/events/rxrpc.h | 43 net/rxrpc/ar-internal.h | 27 +++-- net/rxrpc/call_accept.c |3 +

[PATCH net-next 12/12] rxrpc: Fix leak of rxrpc_peer objects

Signed-off-by: David Howells <dhowe...@redhat.com> --- net/rxrpc/af_rxrpc.c|2 ++ net/rxrpc/ar-internal.h |1 + net/rxrpc/net_ns.c |1 + net/rxrpc/peer_object.c | 21 + net/rxrpc/sendmsg.c |1 + 5 files changed, 26 insertions(+) diff -

Re: [PATCH net-next 0/6] rxrpc: Fixes

David Miller wrote: > David, this GIT URL has tons of unrelated changes. It seems to bring in > the parts of Linus's tree that haven't proagated to 'net' yet. Sorry about that, I rebased on the wrong branch by accident. I've got some more fixes. Should I just give the

[PATCH net-next 0/3] rxrpc: Tracing updates

://git.kernel.org/cgit/linux/kernel/git/dhowells/linux-fs.git/log/?h=rxrpc-next David --- David Howells (3): rxrpc: Trace resend rxrpc, afs: Use debug_ids rather than pointers in traces rxrpc: Trace call completion fs/afs/internal.h|1 fs/afs/rxrpc.c | 12

[PATCH net-next 1/3] rxrpc: Trace resend

Add a tracepoint to trace packet resend events and to dump the Tx annotation buffer for added illumination. Signed-off-by: David Howells <dhowe...@rdhat.com> --- include/trace/events/rxrpc.h | 24 net/rxrpc/call_event.c |1 + 2 files changed, 25 inse

[PATCH net-next 2/3] rxrpc, afs: Use debug_ids rather than pointers in traces

that use rxrpc, such as afs, to take numbers from the rxrpc counter, assign them to their own call struct and pass them in to rxrpc for both client and service calls so that the trace lines for each will have the same ID tag. Signed-off-by: David Howells <dhowe...@redhat.com> --- fs/afs/inte

[PATCH net-next 3/3] rxrpc: Trace call completion

Add a tracepoint to track rxrpc calls moving into the completed state and to log the completion type and the recorded error value and abort code. Signed-off-by: David Howells <dhowe...@redhat.com> --- include/trace/events/rxrpc.h | 33 + net/rxrpc/ar-inte

Re: [PATCH net-next 0/6] rxrpc: Fixes

Sorry, that should be net, not net-next, in the subject line. David

[PATCH net-next 0/6] rxrpc: Fixes

/kernel/git/dhowells/linux-fs.git/log/?h=rxrpc-fixes David --- David Howells (4): rxrpc: Fix firewall route keepalive rxrpc: Fix a bit of time confusion rxrpc: Fix Tx ring annotation after initial Tx failure rxrpc: Don't treat call aborts as conn aborts Marc Dionne (1

[PATCH net 1/6] rxrpc: Fix firewall route keepalive

was transmitted to that peer. Also, just discard VERSION REPLY packets rather than replying to them. Signed-off-by: David Howells <dhowe...@redhat.com> --- net/rxrpc/af_rxrpc.c|4 ++ net/rxrpc/ar-internal.h | 14 ++- net/rxrpc/conn_event.c |3 + net/rxrpc/input.c

[PATCH net 4/6] rxrpc: Don't treat call aborts as conn aborts

with the new call automatically terminate the old call. Fixes: 18bfeba50dfd ("rxrpc: Perform terminal call ACK/ABORT retransmission from conn processor") Reported-by: Marc Dionne <marc.dio...@auristor.com> Signed-off-by: David Howells <dhowe...@redhat.com> --- net/rxrpc/input.c |

[PATCH net 2/6] rxrpc: Fix a bit of time confusion

of the code. Fixes: a158bdd3247b ("rxrpc: Fix call timeouts") Signed-off-by: David Howells <dhowe...@redhat.com> --- net/rxrpc/call_event.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/rxrpc/call_event.c b/net/rxrpc/call_event.c index ad2ab1103189..27f

[PATCH net 3/6] rxrpc: Fix Tx ring annotation after initial Tx failure

rxrpc: Rewrite the data and ack handling code") Signed-off-by: David Howells <dhowe...@redhat.com> --- net/rxrpc/sendmsg.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/net/rxrpc/sendmsg.c b/net/rxrpc/sendmsg.c index 09f2a3e05221..7a94ce92ffdc 100644 --- a/net

[PATCH net 5/6] rxrpc: Fix resend event time calculation

uot;rxrpc: Fix call timeouts") Signed-off-by: Marc Dionne <marc.dio...@auristor.com> Signed-off-by: David Howells <dhowe...@redhat.com> --- net/rxrpc/call_event.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/rxrpc/call_event.c b/net/rxrpc/call_event

[PATCH net 6/6] rxrpc: remove unused static variables

-by: kbuild test robot <fengguang...@intel.com> Signed-off-by: Sebastian Andrzej Siewior <bige...@linutronix.de> Signed-off-by: David Howells <dhowe...@redhat.com> --- net/rxrpc/security.c |3 --- 1 file changed, 3 deletions(-) diff --git a/net/rxrpc/security.c b/net/r

Re: [PATCH net-next nfs 6/6] net: Convert rxrpc_net_ops

namespacing stuff isn't active yet as I'm trying to decide on how to deal with the DNS cache which also needs namespacing. > Signed-off-by: Kirill Tkhai <ktk...@virtuozzo.com> DaveM: Can you take this into net-next and add: Acked-by: David Howells <dhowe...@redhat.com>

Re: [PATCH 00/16] remove eight obsolete architectures

Do we have anything left that still implements NOMMU? David

Re: [PATCH v2] KEYS: DNS: limit the length of option strings

Eric Biggers wrote: > Fix it by limiting option strings (combined name + value) to a much more > reasonable 128 bytes. The exact limit is arbitrary, but currently the > only recognized option is formatted as "dnserror=%lu" which fits well > within this limit. There will be

[PATCH net] rxrpc: Fix send in rxrpc_send_data_packet()

rxrpc: Don't store the rxrpc header in the Tx queue sk_buffs") Reported-by: Marc Dionne <marc.dio...@auristor.com> Signed-off-by: David Howells <dhowe...@redhat.com> --- net/rxrpc/output.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/rxrpc/output.c b/ne

[PATCH net] rxrpc: Work around usercopy check

+0x4e/0x90 do_syscall_64+0x7a/0x220 entry_SYSCALL_64_after_hwframe+0x26/0x9b Reported-by: Jonathan Billings <jsbilli...@jsbillings.org> Signed-off-by: David Howells <dhowe...@redhat.com> Acked-by: Kees Cook <keesc...@chromium.org> Tested-by: Jonathan

[PATCH net] rxrpc: Don't put crypto buffers on the stack

+0x3a/0x390 ? process_one_work+0x680/0x680 kthread+0x121/0x140 ? kthread_create_worker_on_cpu+0x70/0x70 ret_from_fork+0x3a/0x50 Reported-by: Jonathan Billings <jsbilli...@jsbillings.org> Reported-by: Marc Dionne <marc.dio...@auristor.com> Signed-off-by: David Howells <dhow

[PATCH net] rxrpc: Fix received abort handling

lient call") Signed-off-by: David Howells <dhowe...@redhat.com> --- net/rxrpc/conn_client.c |3 ++- net/rxrpc/conn_object.c | 16 2 files changed, 14 insertions(+), 5 deletions(-) diff --git a/net/rxrpc/conn_client.c b/net/rxrpc/conn_client.c index 7f74ca3059f8..064

[PATCH net] rxrpc: Fix the MAINTAINERS record

Fix the MAINTAINERS record so that it's more obvious who the maintainer for AF_RXRPC is. Reported-by: Joe Perches <j...@perches.com> Reported-by: David Miller <da...@davemloft.net> Signed-off-by: David Howells <dhowe...@redhat.com> --- MAINTAINERS | 18 +++---

[PATCH net] rxrpc: Use correct netns source in rxrpc_release_sock()

tic checker warning: net/rxrpc/af_rxrpc.c:898 rxrpc_release_sock() error: we previously assumed 'rx->local' could be null (see line 887) Fixes: 3d18cbb7fd0c ("rxrpc: Fix conn expiry timers") Reported-by: Dan Carpenter <dan.carpen...@oracle.com> Signed-off-by

Re: [PATCH] rxrpc: Neaten logging macros and add KERN_DEBUG logging level

t> (maintainer:NETWORKING [GENERAL],commit_signer:23/74=31%) David Howells <dhowe...@redhat.com> (commit_signer:64/74=86%,authored:60/74=81%) netdev@vger.kernel.org (open list:NETWORKING [GENERAL]) linux-ker...@vger.kernel.org (open list) It would seem a good idea to

Re: [PATCH net-next 0/3] rxrpc: Fixes

David Miller wrote: > This email says "net-next", yet your patches say "net". Sorry about that - it should be 'net'. I copied an old cover note. All the patches have a macro substitution, but the cover note does not. Do you want me to repost? David

[PATCH net-next 0/3] rxrpc: Fixes

/kernel/git/dhowells/linux-fs.git/log/?h=rxrpc-fixes Tagged thusly: git://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git rxrpc-fixes-20171129 David --- David Howells (2): rxrpc: Clean up whitespace rxrpc: Fix ACK generation from the connection event processor

[PATCH net 2/3] rxrpc: Fix ACK generation from the connection event processor

packets in which the Max MTU, Interface MTU and rwind fields have weird values and the Max Packets field is apparently missing. Reported-by: Jeffrey Altman <jalt...@auristor.com> Signed-off-by: David Howells <dhowe...@redhat.com> --- net/rxrpc/conn_ev

[PATCH net 1/3] rxrpc: Clean up whitespace

Clean up some whitespace from rxrpc. Signed-off-by: David Howells <dhowe...@redhat.com> --- net/rxrpc/call_event.c |2 +- net/rxrpc/conn_object.c |2 +- net/rxrpc/input.c |4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/net/rxrpc/call_event.c

[PATCH net 3/3] rxrpc: Fix variable overwrite

ity-ID: 1462263 Addresses-Coverity-ID: 1462264 Fixes: beb8e5e4f38c ("rxrpc: Express protocol timeouts in terms of RTT") Link: https://marc.info/?i=17004.1511808959%40warthog.procyon.org.uk Signed-off-by: Gustavo A. R. Silva <garsi...@embeddedor.com> Signed-off-by: David Howell

Re: [PATCH] rxrpc: call_event: Fix variable overwrite in __rxrpc_propose_ACK

Gustavo A. R. Silva wrote: > - ack_at = jiffies + expiry; Same issue as with the other patch. Can you just combine the two please? David

Re: [PATCH] rxrpc: sendmsg: Fix variable overwrite in rxrpc_queue_packet

Gustavo A. R. Silva wrote: > - resend_at = now + rxrpc_resend_timeout; > + resend_at += now; Yep. :-) David

Re: [PATCH] rxrpc: sendmsg: Fix variable overwrite in rxrpc_queue_packet

Gustavo A. R. Silva wrote: > Value assigned to variable resend_at is overwritten before it can be used. > > Fix this by removing the value overwrite as it seems that this is a > leftover code. NAK. Your fix will actually cause the code to break. The resend_at value

[PATCH net-next 00/12] rxrpc: Fixes and improvements

sly: git://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git rxrpc-fixes-20171124 David --- David Howells (12): rxrpc: The mutex lock returned by rxrpc_accept_call() needs releasing rxrpc: Don't set upgrade by default in sendmsg() rxrpc: Prov

[PATCH net-next 01/12] rxrpc: The mutex lock returned by rxrpc_accept_call() needs releasing

The caller of rxrpc_accept_call() must release the lock on call->user_mutex returned by that function. Signed-off-by: David Howells <dhowe...@redhat.com> --- net/rxrpc/sendmsg.c |5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/net/rxrpc/sendmsg.c b/net/rxrpc/

[PATCH net-next 03/12] rxrpc: Provide a different lockdep key for call->user_mutex for kernel calls

R10: 55ba5727cac0 R11: 0246 R12: R13: 55ba5727cac0 R14: 000055ba5727f270 R15: Signed-off-by: David Howells <dhowe...@redhat.com> --- net/rxrpc/ar-internal.h |2 +- net/rxrpc/call_accept.c |2 +- net/rxrpc/call_object.c | 19 +

[PATCH net-next 05/12] rxrpc: Split the call params from the operation params

into their own structure, a copy of which is then embedded in the operation parameters struct. The call parameters struct is then passed down into the places that need it instead of passing the individual parameters. This allows for extra call parameters to be added. Signed-off-by: David Howells <dh

[PATCH net-next 04/12] rxrpc: Delay terminal ACK transmission on a client call

Delay terminal ACK transmission on a client call by deferring it to the connection processor. This allows it to be skipped if we can send the next call instead, the first DATA packet of which will implicitly ack this call. Signed-off-by: David Howells <dhowe...@redhat.com> --- net/rx

[PATCH net-next 02/12] rxrpc: Don't set upgrade by default in sendmsg()

Don't set upgrade by default when creating a call from sendmsg(). This is a holdover from when I was testing the code. Signed-off-by: David Howells <dhowe...@redhat.com> --- net/rxrpc/sendmsg.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/rxrpc/sendmsg.c

[PATCH net-next 07/12] rxrpc: Don't transmit DELAY ACKs immediately on proposal

of packets transmitted. We do, however, want to continue sending other types of packet immediately, particularly REQUESTED ACKs, as they may be used for RTT calculation by the other side. Signed-off-by: David Howells <dhowe...@redhat.com> --- net/rxrpc/recvmsg.c |4 ++-- 1 file chan

[PATCH net-next 06/12] rxrpc: Fix call timeouts

32 normal_timeout; /* msec from data Rx */ This can be set in combination with any other sendmsg() that affects a call. Signed-off-by: David Howells <dhowe...@redhat.com> --- include/trace/events/rxrpc.h | 69 +++- include/uapi/linux/rxrpc.h |1 net/rxrpc/ar-interna

[PATCH net-next 09/12] rxrpc: Add a timeout for detecting lost ACKs/lost DATA

set. It should result in either a REQUESTED ACK or a DUPLICATE ACK which we can then use in lieu the a PING-RESPONSE ACK mentioned above. Signed-off-by: David Howells <dhowe...@redhat.com> --- include/trace/events/rxrpc.h | 11 +-- net/rxrpc/ar-internal.h |6 +- net

[PATCH net-next 11/12] rxrpc: Fix service endpoint expiry

estart the service reaper work item rather the client reaper. Signed-off-by: David Howells <dhowe...@redhat.com> --- include/trace/events/rxrpc.h |2 ++ net/rxrpc/af_rxrpc.c | 13 + net/rxrpc/ar-internal.h |3 +++ net/rxrpc/conn_client.c |2 +

[PATCH net-next 10/12] rxrpc: Add keepalive for a call

necessary for servers where the processing of the service function may take a significant amount of time. Signed-off-by: David Howells <dhowe...@redhat.com> --- include/trace/events/rxrpc.h |6 ++ net/rxrpc/ar-internal.h |1 + net/rxrpc/call_event.c | 10 +

[PATCH net-next 12/12] rxrpc: Fix conn expiry timers

and so that the timer doesn't requeue the work item if the net namespace is dead. (2) Don't use queue_delayed_work() as that won't alter the timeout if the timer is already running. (3) Don't rearm the timers if the network namespace is dead. Signed-off-by: David Howells <dh

[PATCH net-next 08/12] rxrpc: Express protocol timeouts in terms of RTT

retransmission timeout is set at RTT*1.5 and the ACK deferral timeout is set at RTT. Note that the calculated timeout is limited to a minimum of 4ns to make sure it doesn't happen too quickly. Signed-off-by: David Howells <dhowe...@redhat.com> --- net/rxrpc/call_event.c

[PATCH net-next 2/3] rxrpc: Fix a null ptr deref in rxrpc_fill_out_ack()

IP: rxrpc_send_ack_packet+0x231/0x6a4 Signed-off-by: David Howells <dhowe...@redhat.com> --- net/rxrpc/output.c |9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/net/rxrpc/output.c b/net/rxrpc/output.c index 71e6f713fbe7..8ee8b2d4a3eb 100644 --- a/net/rxrpc/output

[PATCH net-next 0/3] rxrpc: Fixes

with call expiration. The patches can be found here also: http://git.kernel.org/cgit/linux/kernel/git/dhowells/linux-fs.git/log/?h=rxrpc-next Tagged thusly: git://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git rxrpc-next-2017 David --- David Howells (3

[PATCH net-next 1/3] rxrpc: Lock around calling a kernel service Rx notification

ending afs_call is in R12, plus the offset to the spinlock. Signed-off-by: David Howells <dhowe...@redhat.com> --- net/rxrpc/af_rxrpc.c| 16 net/rxrpc/ar-internal.h |1 + net/rxrpc/call_object.c |1 + net/rxrpc/recvmsg.c |2 ++ 4 files changed, 20 inserti

[PATCH net-next 3/3] rxrpc: Fix call expiry handling

as 'keep alives' if the server is still processing the call. (5) VERSION REPLY packets should be sent to the peers of service connections to act as keep-alives. This is used to keep firewall routes in place. The AFS CM should enable this. Signed-off-by: David Howells <dh

Re: [PATCH 18/27] bpf: Restrict kernel image access functions when the kernel is locked down

Alexei Starovoitov wrote: > > TBH, I've no idea how bpf does anything, so I can't say whether this is > > better, overkill or insufficient. > > ok. To make it clear: > Nacked-by: Alexei Starovoitov > For the current patch. > Unnecessary checks for

Re: Is there a race between __mod_timer() and del_timer()?

David Howells <dhowe...@redhat.com> wrote: > I think it might just be best to put a note in the comments in __mod_timer(). How about the attached? David --- commit d538c734f9bf885292b88a81a06c5efee528d70d Author: David Howells <dhowe...@redhat.com> Date: Wed Nov 8 10:20:27 2017

Is there a race between __mod_timer() and del_timer()?

Is there a race between the optimisation for networking code in __mod_timer() and del_timer() - or, at least, a race that matters? Consider: CPU A CPU B === === [timer X is active]

  1   2   3   4   5   6   7   8   9   >