Re: [PATCH 0/6] Constant Time Memory Comparisons Are Important

On Mon, Jun 12, 2017 at 12:30 AM, Emil Lenngren <emil.lenng...@gmail.com> wrote: > 2017-06-11 22:48 GMT+02:00 Emmanuel Grumbach <egrumb...@gmail.com>: >> On Sun, Jun 11, 2017 at 4:36 PM, Kees Cook <keesc...@chromium.org> wrote: >>> >>> On

Re: [PATCH 0/6] Constant Time Memory Comparisons Are Important

On Sun, Jun 11, 2017 at 4:36 PM, Kees Cook wrote: > > On Sun, Jun 11, 2017 at 1:13 AM, Kalle Valo wrote: > > "Jason A. Donenfeld" writes: > > > >> Whenever you're comparing two MACs, it's important to do this using > >> crypto_memneq

Re: [PATCH RESEND] iwlwifi, Do not implement thermal zone unless ucode is loaded

tch moves the firmware check to iwl_mvm_thermal_zone_register() and > stops the thermal zone from being created if the ucode hasn't been loaded. > > Signed-off-by: Prarit Bhargava <pra...@redhat.com> > Cc: Johannes Berg <johannes.b...@intel.com> > Cc: Emmanuel Grumbach <emm

Re: [GIT] Networking

On Wed, May 18, 2016 at 4:00 AM, Linus Torvalds wrote: > On Tue, May 17, 2016 at 12:11 PM, David Miller wrote: >> >> Highlights: > > Lowlights: > > 1) the iwlwifi driver seems to be broken > > My laptop that uses the intel 7680 iwlwifi module

Re: [PATCH net-next v5] rtnetlink: add new RTM_GETSTATS message to dump link stats

On Tue, Apr 19, 2016 at 1:09 PM, Johannes Berg wrote: > On Mon, 2016-04-18 at 23:52 -0400, David Miller wrote: >> From: David Miller >> Date: Mon, 18 Apr 2016 21:48:51 -0400 (EDT) >> >> > I think the time has probably come to have a new netlink

Re: [PATCH] wlcore: spi: add wl18xx support

On Wed, Mar 30, 2016 at 3:58 PM, Eyal Reizer wrote: > > From: Eyal Are you trying to hide or something? :) > > Add support for using with both wl12xx and wl18xx. > > - all wilink family needs special init command for entering wspi mode. >

Re: [PATCH] codel: cast the output of MS2TIME to codel_time_t

On Mon, Feb 22, 2016 at 9:53 PM, David Miller <da...@davemloft.net> wrote: > From: Emmanuel Grumbach <emmanuel.grumb...@intel.com> > Date: Mon, 22 Feb 2016 13:49:47 +0200 > >> This will allow to pass the typecheck in the comparators: >> codel_time_{after,befo

[PATCH] codel: cast the output of MS2TIME to codel_time_t

This will allow to pass the typecheck in the comparators: codel_time_{after,before} Signed-off-by: Emmanuel Grumbach <emmanuel.grumb...@intel.com> --- include/net/codel.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/net/codel.h b/include/net/codel.h index 2

[PATCH] codel: add forgotten inline to functions in header file

Signed-off-by: Emmanuel Grumbach <emmanuel.grumb...@intel.com> --- include/net/codel.h | 44 ++-- 1 file changed, 22 insertions(+), 22 deletions(-) diff --git a/include/net/codel.h b/include/net/codel.h index 267e702..0775c24 100644 --- a/inclu

Re: [RFC v2] iwlwifi: pcie: transmit queue auto-sizing

On Mon, Feb 8, 2016 at 12:00 PM, Michal Kazior wrote: > On 5 February 2016 at 17:47, Dave Taht wrote: >>> A bursted txop can be as big as 5-10ms. If you consider you want to >>> queue 5-10ms worth of data for *each* station at any given time you >>>

Re: [RFC v2] iwlwifi: pcie: transmit queue auto-sizing

On Fri, Feb 5, 2016 at 10:44 AM, Michal Kazior <michal.kaz...@tieto.com> wrote: > On 4 February 2016 at 22:14, Ben Greear <gree...@candelatech.com> wrote: >> On 02/04/2016 12:56 PM, Grumbach, Emmanuel wrote: >>> On 02/04/2016 10:46 PM, Ben Greear wrote: >>

[RFC] iwlwifi: pcie: transmit queue auto-sizing

that the wireless problems mentioned in https://lwn.net/Articles/616241/ may have a solution. Cc: Stephen Hemminger <step...@networkplumber.org> Cc: Dave Taht <dave.t...@bufferbloat.net> Cc: Jonathan Corbet <cor...@lwn.net> Signed-off-by: Emmanuel Grumbach <emmanu

[RFC v2] iwlwifi: pcie: transmit queue auto-sizing

that the wireless problems mentioned in https://lwn.net/Articles/616241/ may have a solution. Cc: Stephen Hemminger <step...@networkplumber.org> Cc: Dave Taht <dave.t...@gmail.com> Cc: Jonathan Corbet <cor...@lwn.net> Signed-off-by: Emmanuel Grumbach <emmanuel.grumb...@inte

[RFC RESEND] iwlwifi: pcie: transmit queue auto-sizing

that the wireless problems mentioned in https://lwn.net/Articles/616241/ may have a solution. Cc: Stephen Hemminger <step...@networkplumber.org> Cc: Dave Taht <dave.t...@gmail.com> Cc: Jonathan Corbet <cor...@lwn.net> Signed-off-by: Emmanuel Grumbach <emmanuel.grumb...@inte

Re: [PATCH v2 10/27] iwlwifi: move under intel vendor directory

Hi Kalle, On Wed, Nov 18, 2015 at 4:45 PM, Kalle Valo wrote: > > Part of reorganising wireless drivers directory and Kconfig. > I am sorry but I'd prefer to wait with this. We have a big machinery of scripts / builds and alike that will break. I did give a heads up a while

[PATCH v3] net: tso: add support for IPv6

Adding IPv6 for the TSO helper API is trivial: * Don't play with the id (which doesn't exist in IPv6) * Correctly update the payload_len (don't include the length of the IP header itself) Signed-off-by: Emmanuel Grumbach <emmanuel.grumb...@intel.com> --- v3: use vlan_get_protocol an

Re: [PATCH 1/2] iwlwifi: pcie: allow to build an A-MSDU using TSO core

that the > packet is not WEP / TKIP and has a proper SNAP header. > > Signed-off-by: Emmanuel Grumbach <emmanuel.grumb...@intel.com> Assuming your review queue works as a FIFO and you reviewed the TSO helper patch, I can assume you ACK this one? :) Or at least, don't NACK it :) -- To un

[PATCH] net: tso: add support for IPv6

Adding IPv6 for the TSO helper API is trivial: * Don't play with the id (which doesn't exist in IPv6) * Correctly update the payload_len (don't include the length of the IP header itself) Signed-off-by: Emmanuel Grumbach <emmanuel.grumb...@intel.com> --- net/core/tso.

[PATCH v2] net: tso: add support for IPv6

Adding IPv6 for the TSO helper API is trivial: * Don't play with the id (which doesn't exist in IPv6) * Correctly update the payload_len (don't include the length of the IP header itself) Signed-off-by: Emmanuel Grumbach <emmanuel.grumb...@intel.com> --- v2: add else if NOTE: i

[RFC v4 1/2] iwlwifi: pcie: allow to build an A-MSDU using TSO core

it is reclaimed. When the page gets full, it is released and a new one is allocated. Since any SKB that doesn't go through the fast-xmit path of mac80211 will be segmented, we can assume here that the packet is not WEP / TKIP and has a proper SNAP header. Signed-off-by: Emmanuel Grumbach

[RFC v4 2/2] iwlwifi: mvm: send large SKBs to the transport

into account) to make sure that the skb that is passed down to the transport are not longer than the maximal A-MSDU allowed. Signed-off-by: Emmanuel Grumbach <emmanuel.grumb...@intel.com> --- v4: Don't use the original skb after it has been consumed --- drivers/net/wireless/iwlwifi/mvm/tx.c

[PATCH 2/2] iwlwifi: mvm: send large SKBs to the transport

into account) to make sure that the skb that is passed down to the transport are not longer than the maximal A-MSDU allowed. Signed-off-by: Emmanuel Grumbach <emmanuel.grumb...@intel.com> --- No change since RFCv4 --- drivers/net/wireless/iwlwifi/mvm/tx.c | 143 --

[PATCH 1/2] iwlwifi: pcie: allow to build an A-MSDU using TSO core

it is reclaimed. When the page gets full, it is released and a new one is allocated. Since any SKB that doesn't go through the fast-xmit path of mac80211 will be segmented, we can assume here that the packet is not WEP / TKIP and has a proper SNAP header. Signed-off-by: Emmanuel Grumbach

[RFC v3 2/2] iwlwifi: mvm: send large SKBs to the transport

into account) to make sure that the skb that is passed down to the transport are not longer than the maximal A-MSDU allowed. Signed-off-by: Emmanuel Grumbach <emmanuel.grumb...@intel.com> --- drivers/net/wireless/iwlwifi/mvm/tx.c | 143 -- 1 file changed, 135 insertions

[RFC v3 1/2] iwlwifi: pcie: allow to build an A-MSDU using TSO core

it is reclaimed. When the page gets full, it is released and a new one is allocated. Since any SKB that doesn't go through the fast-xmit path of mac80211 will be segmented, we can assume here that the packet is not WEP / TKIP and has a proper SNAP header. Signed-off-by: Emmanuel Grumbach

[RFC v3 0/2] Add TSO for iwlwifi

close :) Emmanuel Grumbach (2): iwlwifi: pcie: allow to build an A-MSDU using TSO core iwlwifi: mvm: send large SKBs to the transport drivers/net/wireless/iwlwifi/iwl-devtrace-data.h | 16 ++ drivers/net/wireless/iwlwifi/iwl-trans.h | 6 +- drivers/net/wireless/iwlwifi/mvm/tx.c

[RFC v3 1/3] iwlwifi: mvm: add real TSO implementation

. type=feature Change-Id: I238ffa79cacc5bbdacdfbf3e9673c8d4f02b462a Signed-off-by: Emmanuel Grumbach emmanuel.grumb...@intel.com --- drivers/net/wireless/iwlwifi/mvm/tx.c | 513 +++--- 1 file changed, 481 insertions(+), 32 deletions(-) diff --git a/drivers/net/wireless

[RFC v3 2/3] iwlwifi: mvm: allow to create A-MSDUs from a large send

: I5ea1b1132a57542187cd4c34c5299dbf44fe8b01 Signed-off-by: Emmanuel Grumbach emmanuel.grumb...@intel.com --- drivers/net/wireless/iwlwifi/mvm/mac80211.c | 3 +- drivers/net/wireless/iwlwifi/mvm/sta.c | 4 +- drivers/net/wireless/iwlwifi/mvm/sta.h | 6 +- drivers/net/wireless/iwlwifi/mvm/tx.c

[RFC v3 0/3] add TSO / A-MSDU TX for iwlwifi

fixed the whitespace problem spotted by Sergei. + I changed the D'tor check for truesize accounting. Since the D'tor seems to be set to tcp_wfree if it exists, I just the D'tor not being NULL. Emmanuel Grumbach (3): iwlwifi: mvm: add real TSO implementation iwlwifi: mvm: allow

[RFC v3 3/3] iwlwifi: mvm: transfer the truesize to the last TSO segment

: I3c894cf2afc0aedfe7b2a5b992ba41653ff79c0e Signed-off-by: Emmanuel Grumbach emmanuel.grumb...@intel.com --- drivers/net/wireless/iwlwifi/mvm/tx.c | 17 - 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/iwlwifi/mvm/tx.c b/drivers/net/wireless/iwlwifi/mvm/tx.c index

[RFC v2 1/3] iwlwifi: mvm: add real TSO implementation

. type=feature Change-Id: I238ffa79cacc5bbdacdfbf3e9673c8d4f02b462a Signed-off-by: Emmanuel Grumbach emmanuel.grumb...@intel.com --- drivers/net/wireless/iwlwifi/mvm/tx.c | 513 +++--- 1 file changed, 481 insertions(+), 32 deletions(-) diff --git a/drivers/net/wireless

[RFC v2 0/3] add TSO / A-MSDU TX for iwlwifi

(payload partition amongst the header and the different frags). I'll be very happy to get comments on that code, this is why I am sending it to netdev as well since the TSO experts are there :) Emmanuel Grumbach (3): iwlwifi: mvm: add real TSO implementation iwlwifi: mvm: allow to create A-MSDUs

[RFC v2 3/3] iwlwifi: mvm: transfer the truesize to the last TSO segment

: I3c894cf2afc0aedfe7b2a5b992ba41653ff79c0e Signed-off-by: Emmanuel Grumbach emmanuel.grumb...@intel.com --- drivers/net/wireless/iwlwifi/mvm/tx.c | 17 - 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/iwlwifi/mvm/tx.c b/drivers/net/wireless/iwlwifi/mvm/tx.c index

[RFC v2 2/3] iwlwifi: mvm: allow to create A-MSDUs from a large send

: I5ea1b1132a57542187cd4c34c5299dbf44fe8b01 Signed-off-by: Emmanuel Grumbach emmanuel.grumb...@intel.com --- drivers/net/wireless/iwlwifi/mvm/mac80211.c | 3 +- drivers/net/wireless/iwlwifi/mvm/sta.c | 4 +- drivers/net/wireless/iwlwifi/mvm/sta.h | 6 +- drivers/net/wireless/iwlwifi/mvm/tx.c

Re: [PATCH 1/2] iwlwifi: convert hex_dump_to_buffer() to %*ph

On Tue, Aug 4, 2015 at 1:47 PM, Andy Shevchenko andriy.shevche...@linux.intel.com wrote: On Thu, 2015-07-16 at 15:42 +0300, Andy Shevchenko wrote: There is no need to use hex_dump_to_buffer() in the cases like this: hexdump_to_buffer(buf, len, 16, 1, outbuf, outlen, false); /*

Re: [PATCH 1/2] iwlwifi: convert hex_dump_to_buffer() to %*ph

On Tue, Aug 4, 2015 at 2:48 PM, Emmanuel Grumbach egrumb...@gmail.com wrote: On Tue, Aug 4, 2015 at 1:47 PM, Andy Shevchenko andriy.shevche...@linux.intel.com wrote: On Thu, 2015-07-16 at 15:42 +0300, Andy Shevchenko wrote: There is no need to use hex_dump_to_buffer() in the cases like

Re: [PATCH] net/wireless: enable wiphy device to suspend/resume asynchronously

On Thu, Jul 30, 2015 at 8:18 AM, Fu, Zhonghui zhonghui...@linux.intel.com wrote: Enable wiphy device to suspend/resume asynchronously. This can improve system suspend/resume speed. How will that impact the timing with respect to the suspend call coming from the bus? I think that a few drivers

Re: [PATCH] iwlwifi: Deinline iwl_{read,write}{8,32}

On Tue, Jul 14, 2015 at 3:41 PM, Denys Vlasenko vda.li...@googlemail.com wrote: On Tue, Jul 14, 2015 at 2:38 PM, Sergei Shtylyov sergei.shtyl...@cogentembedded.com wrote: +#define IWL_READ_WRITE(static_inline) \ +static_inline void iwl_write8(struct iwl_trans *trans, u32 ofs, u8 val) \ +{ \

Re: [PATCH] mac80211: Use kstrdup to simplify code

The subject is wrong. You are not patch mac80211, but bcrmsmac. On Wed, Jul 8, 2015 at 10:32 PM, Christophe JAILLET christophe.jail...@wanadoo.fr wrote: Replace a kmalloc+strcpy by an equivalent kstrdup in order to improve readability. Signed-off-by: Christophe JAILLET