On Fri, Aug 25, 2017 at 05:05:25PM +0300, Anton Volkov wrote:
> Hello.
>
> While searching for races in the Linux kernel I've come across
> "drivers/net/irda/nsc-ircc.ko" module. Here is a question that I came up
> with while analyzing results. Lines are given using the info from Linux
> v4.12.
>
On Thu, Oct 11, 2007 at 05:45:28PM +0200, Oliver Neukum wrote:
Hi,
Hi,
You need to cc Samuel Ortiz and the IrDA mailing list if you
want any meaningful response.
it seems to me that irda_usb_net_open() must set self-netopen
under spinlock or disconnect() may fail to kill
On Thu, Jul 12, 2007 at 11:40:23AM -0500, Larry Finger wrote:
Jean Tourrilhes wrote:
Well, I actually like forcing driver to use frequency, because
that's an absolute physical measure and contains more meaning.
Yes, but it is easier to keep a channel number in your head than
On Wed, Jul 11, 2007 at 11:30:17PM -0400, Dan Williams wrote:
On Tue, 2007-07-10 at 14:25 -0500, Larry Finger wrote:
Jean,
Jean Tourrilhes wrote:
Hi,
SoftMAC output the channel twice in the scan output. It should
display frequency and channel, but only once for each
level=-65 dBm
Extra: Last beacon: 120ms ago
The fix is simple, patch attached, tested for 2.6.22 with
bcm43xx. If you like it, send it to John.
Regards,
Jean
Signed-off-by: Jean Tourrilhes [EMAIL
On Tue, Jul 10, 2007 at 02:25:12PM -0500, Larry Finger wrote:
Jean,
Jean Tourrilhes wrote:
Hi,
SoftMAC output the channel twice in the scan output. It should
display frequency and channel, but only once for each
...
Jean
Signed-off-by: Jean Tourrilhes [EMAIL PROTECTED]
---
--- linux/net/wireless/wext.j1.c2007-07-09 13:19:22.0 -0700
+++ linux/net/wireless/wext.c 2007-07-09 13:19:59.0 -0700
@@ -741,39 +741,11 @@ static int
is pretty trivial.
John : would you mind pushing that to 2.6.23 ?
Thanks...
Jean
Signed-off-by: Jean Tourrilhes [EMAIL PROTECTED]
---
--- linux/net/ieee80211/softmac/ieee80211softmac_assoc.j1.c 2007-07-09
13:56
On Mon, Jul 09, 2007 at 06:40:44PM -0500, Larry Finger wrote:
This patch should also be sent to [EMAIL PROTECTED]
Please do so if you like it.
Larry
Jean
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More
On Tue, Apr 24, 2007 at 08:07:35PM +0200, Johannes Berg wrote:
This patch kills a whole bunch of code that can only ever be used by
defining some things in wext.c. Also, the things that are printed are
mostly useless since the API is fairly well-tested.
Signed-off-by: Johannes Berg [EMAIL
On Tue, Apr 24, 2007 at 08:07:39PM +0200, Johannes Berg wrote:
This patch removes a bunch of inline abuse from wext. Most functions
that were marked inline are only used once so the compiler will inline
them anyway, others are used multiple times but there's no requirement
for them to be
On Tue, Apr 24, 2007 at 08:07:41PM +0200, Johannes Berg wrote:
This patch makes the wext bits in struct net_device depend on
CONFIG_WIRELESS_EXT.
Signed-off-by: Johannes Berg [EMAIL PROTECTED]
I personally would not do that. Having conditional fields in
struct net_device is very bad,
On Thu, Apr 26, 2007 at 07:03:27PM +0200, Michael Buesch wrote:
Sure, other people have different opinions on that, but I think
with my approach we get smallest code with good speed.
Try with gcc-3.3 if you don't trust me. Your patch will
produce bigger and slower code. Thanks.
On Wed, Apr 18, 2007 at 01:34:50AM +0200, Michael Buesch wrote:
I'd say nobody but you does fully understand WEXT.
Not true. If tommorow I was run over by an ICE, you could ask
Jouni, Dan or Pavel to take over.
Have fun...
Jean
-
To unsubscribe from this list: send the
On Mon, Apr 02, 2007 at 12:06:50PM +0200, Johannes Berg wrote:
Jean Tourrilhes wrote :
Johannes Berg discovered that kernel space was leaking to
userspace on 64 bit platform. He made a first patch to fix that. This
is an improved version of his patch.
This was tested on 2.6.21
On Tue, Apr 17, 2007 at 02:34:42PM -0400, John W. Linville wrote:
On Tue, Apr 17, 2007 at 10:08:20AM -0700, Jean Tourrilhes wrote:
First, I'm the current active maintainer of the
wext-over-netlink interface, and nobody bothered to even 'inform' me
about its removal, let alone consult
?
Thanks...
Jean
Signed-off-by: Jean Tourrilhes [EMAIL PROTECTED]
---
diff -u -p linux/fs/compat_ioctl.j1.c linux/fs/compat_ioctl.c
--- linux/fs/compat_ioctl.j1.c 2007-03-06 17:49:33.0 -0800
+++ linux/fs
Signed-off-by: Jean Tourrilhes [EMAIL PROTECTED]
---
diff -u -p linux/include/linux/wireless.j1.h linux/include/linux/wireless.h
--- linux/include/linux/wireless.j1.h 2007-03-08 10:34:32.0 -0800
+++ linux/include/linux/wireless.h
On Tue, Mar 13, 2007 at 08:42:05PM +0100, Johannes Berg wrote:
On Mon, 2007-03-12 at 10:56 -0700, Jean Tourrilhes wrote:
I did that in the e-mail to Jouni. The problem is that most
people are unfamiliar with decoding iwevents, so can't grasp the
explanation.
Basically
On Sun, Mar 11, 2007 at 06:40:01PM +0100, Johannes Berg wrote:
On Fri, 2007-03-09 at 13:35 -0800, Jean Tourrilhes wrote:
It's not as bad as it look like. All userspace programs
nowadays use either the iwlib or wpa_supplicant. For example,
NetworkManager gets its stuff through
On Mon, Mar 12, 2007 at 10:21:49AM -0800, Jouni Malinen wrote:
On Mon, Mar 12, 2007 at 10:56:39AM -0700, Jean Tourrilhes wrote:
I would guess that others use iwlib like that too.
Which others ? The applications that process scan results can
be counted on your fingers. And if you
On Thu, Mar 08, 2007 at 11:35:26PM +0100, Johannes Berg wrote:
On Thu, 2007-03-08 at 14:11 -0800, Jean Tourrilhes wrote:
First possiblity, we could stick with this band-aid
permanently.
It sucks for various reasons, one for example being that I don't even
understand your recognition
On Fri, Mar 09, 2007 at 03:19:22PM -0800, Jouni Malinen wrote:
On Fri, Mar 09, 2007 at 01:35:31PM -0800, Jean Tourrilhes wrote:
It's not as bad as it look like. All userspace programs
nowadays use either the iwlib or wpa_supplicant. For example,
NetworkManager gets its stuff through
On Thu, Mar 08, 2007 at 03:39:07PM +0100, Johannes Berg wrote:
On Tue, 2007-03-06 at 18:03 -0800, Jean Tourrilhes wrote:
Ok, please check the patch attached. I don't have a box to
test that on, and on my 32 bit kernel it is not even compiled, but I
believe I got everything all right
On Thu, Mar 08, 2007 at 08:08:29PM +0100, Johannes Berg wrote:
On Thu, 2007-03-08 at 10:49 -0800, Jean Tourrilhes wrote:
A proper fix would involve forcing the alignement in the
kernel. Unfortunately, that would break 64bit-64bit configs. I think
I can build a workaround
On Thu, Mar 08, 2007 at 08:40:01PM +0100, Johannes Berg wrote:
On Thu, 2007-03-08 at 11:34 -0800, Jouni Malinen wrote:
Yes, workaround in just iwlib is not enough. If the only possible
solution is user space workaround, it better be documented (and
communicated to maintainers of user
On Thu, Mar 08, 2007 at 02:17:56PM -0800, Randy Dunlap wrote:
On Thu, 8 Mar 2007 14:11:28 -0800 Jean Tourrilhes wrote:
Third possibility : we declare 32 bit userspace on 64 bit
kernel as not supported and advise users to get a 64 bit
userspace. The number of bug report on that issue
On Thu, Mar 08, 2007 at 11:22:06PM +0100, Johannes Berg wrote:
On Thu, 2007-03-08 at 14:11 -0800, Jean Tourrilhes wrote:
This is exactly what I was pointing out earlier. Well,
actually, there may be ways of fixing it in the kernel, but that would
be real ugly, and I don't want to go
On Tue, Mar 06, 2007 at 02:27:26AM +0100, Johannes Berg wrote:
Hi,
Wtf! After struggling with some strange problems with zd1211rw (see some
other mail) I decided to think again about what could possibly cause all
the other problems I'm having with it. The kernel seems fine, but iw*
On Tue, Mar 06, 2007 at 07:43:06PM +0100, Michael Buesch wrote:
Yep, and it's even in fs/compat_ioctl.c. Hint, hint ;-)
Ok, it is wrapping the following ioctls:
HANDLE_IOCTL(SIOCGIWRANGE, do_wireless_ioctl)
HANDLE_IOCTL(SIOCSIWSPY, do_wireless_ioctl)
HANDLE_IOCTL(SIOCGIWSPY,
On Thu, Mar 01, 2007 at 08:42:09AM +0100, Jarek Poplawski wrote:
On Wed, Feb 28, 2007 at 10:45:41AM -0800, Jean Tourrilhes wrote:
+
+ if ((size = 0) || (i = num_envp))
Btw.:
1. if size == 10 and snprintf returns 9 (without NULL)
then n == 10 (with NULL), so isn't
On Wed, Feb 28, 2007 at 07:36:17AM -0800, Greg KH wrote:
On Tue, Feb 27, 2007 at 05:27:41PM -0800, Jean Tourrilhes wrote:
diff -u -p linux/drivers/base/class.j1.c linux/drivers/base/class.c
--- linux/drivers/base/class.j1.c 2007-02-26 18:38:10.0 -0800
+++ linux/drivers/base
On Wed, Feb 28, 2007 at 10:34:37AM +0100, Jarek Poplawski wrote:
On 28-02-2007 02:27, Jean Tourrilhes wrote:
Hi all,
...
Patch for 2.6.20 is attached. The patch was tested on a system
running the hotplug scripts, and on another system running udev.
Have fun
On Wed, Feb 28, 2007 at 10:16:05AM +0100, Johannes Berg wrote:
Hi,
Patch for 2.6.20 is attached.
... and in the meantime netdevices aren't class_device any more :) IOW,
your patch isn't going to work any more.
That's why I always specify the kernel version. I'll look into
On Wed, Feb 28, 2007 at 07:36:17AM -0800, Greg KH wrote:
On Tue, Feb 27, 2007 at 05:27:41PM -0800, Jean Tourrilhes wrote:
diff -u -p linux/drivers/base/class.j1.c linux/drivers/base/class.c
--- linux/drivers/base/class.j1.c 2007-02-26 18:38:10.0 -0800
+++ linux/drivers/base
On Thu, Mar 01, 2007 at 01:37:46AM +0100, Johannes Berg wrote:
On Wed, 2007-02-28 at 16:26 -0800, Jean Tourrilhes wrote:
+ /* This function is only used for network interface.
+* Some hotplug package track interfaces by their name and
+* therefore want to know when the name
scripts, and on another system running udev.
Have fun...
Jean
Signed-off-by: Jean Tourrilhes [EMAIL PROTECTED]
-
diff -u -p linux/include/linux/kobject.j1.h linux/include/linux/kobject.h
--- linux/include/linux/kobject.j1.h
On Thu, Nov 02, 2006 at 04:21:16PM -0500, Ivan Matveich wrote:
On 11/2/06, Dan Williams [EMAIL PROTECTED] wrote:
Do you know which kernel version that patch first appeared in?
It was committed on 1 Dec 2005, and 2.6.15 was released on 3 Jan 2006.
That would be a great idea, let us know
On Thu, Oct 19, 2006 at 05:56:53PM -0400, John W. Linville wrote:
Jeff,
Here is my ugly patch to fix userland ABI compatibility for WE-21.
It tries to detect WE = 20 by the request length or the inclusion of
'\0' in the length for the ESSID and NICKN ioctls. If it finds that,
it
On Tue, Oct 10, 2006 at 03:40:04PM -0400, John W. Linville wrote:
I think this patch still has two problems. One is that the length
modification does not happen until after the Check what user space
is giving us clause. So, max length requests will fail. (Did you
check SIOCGIWESSID w/
Hi John,
Based on the feedback, I formally request you to back out all
of WE-21 from 2.6.19. Rationale : it's probably too early. You can
keep it for a later date if you wish.
Regards,
Jean
-
To unsubscribe from this list: send the line unsubscribe netdev in
the
On Thu, Oct 05, 2006 at 04:49:54PM -0400, John W. Linville wrote:
On Thu, Oct 05, 2006 at 09:31:13AM -0700, Jean Tourrilhes wrote:
Based on the feedback, I formally request you to back out all
of WE-21 from 2.6.19. Rationale : it's probably too early. You can
keep it for a later date
On Thu, Oct 05, 2006 at 04:49:54PM -0400, John W. Linville wrote:
On Thu, Oct 05, 2006 at 09:31:13AM -0700, Jean Tourrilhes wrote:
Based on the feedback, I formally request you to back out all
of WE-21 from 2.6.19. Rationale : it's probably too early. You can
keep it for a later date
On Thu, Oct 05, 2006 at 03:15:50PM -0700, Jouni Malinen wrote:
On Thu, Oct 05, 2006 at 03:12:46PM -0700, Jean Tourrilhes wrote:
+ if((cmd == SIOCSIWESSID) ||
+ (cmd == SIOCSIWNICKN)) {
+ if(extra[iwr-u.data.length - 1] == '\0
On Thu, Oct 05, 2006 at 06:37:53PM -0400, Pavel Roskin wrote:
Hello!
On Tue, 2006-10-03 at 09:34 -0700, Jean Tourrilhes wrote:
I don't really want to overstep my authority there, my goal
was to minimise the changes. Pavel will have to clean up my mess, so I
don't want change things
On Tue, Oct 03, 2006 at 05:58:31PM +0200, Samuel Tardieu wrote:
Jean == Jean Tourrilhes [EMAIL PROTECTED] writes:
Jean @@ -2500,9 +2501,9 @@ static int orinoco_hw_get_essid(struct o
Jean len = le16_to_cpu(essidbuf.len);
Jean BUG_ON(len IW_ESSID_MAX_SIZE);
Jean
Jean
On Tue, Oct 03, 2006 at 06:45:35PM +0200, Samuel Tardieu wrote:
On 3/10, Jean Tourrilhes wrote:
| I suggest that you revert the memset() to IW_ESSID_MAX_SIZE+1 so that
| the last byte is cleared as well. Or am I missing something?
|
| No, that would bring back the slab/memory overflow
On Fri, Sep 29, 2006 at 06:20:08PM -0700, Andrew Morton wrote:
On Fri, 29 Sep 2006 20:01:54 -0400
% grep ioctl /tmp/foo2 | sort -u | more
ioctl(13, SIOCGIWESSID, 0xbfbcdb9c) = 0
ioctl(13, SIOCGIWRANGE, 0xbfbcdbdc) = 0
ioctl(13, SIOCGIWRATE, 0xbfbcdbbc) = 0
Yes. The
Hi John,
This patch fixes the Orinoco driver overflow issue with
WE-21. This was discussed on the mailing list, the reporter confirmed
that it fixes the issue and Andrew has already added this patch in
tree.
Regards,
Jean
On Fri, Sep 29, 2006 at 06:20:08PM -0700, Andrew Morton wrote:
On Fri, 29 Sep 2006 20:01:54 -0400
Here's the traceback I got:
slab error in verify_redzone_free(): cache `size-32': memory outside object
was overwritten
[c0103ad2] dump_trace+0x64/0x1cd
[c0103c4d]
On Fri, Sep 29, 2006 at 06:20:08PM -0700, Andrew Morton wrote:
On Fri, 29 Sep 2006 20:01:54 -0400
A quick strace of gkrellm finds these likely ioctl's causing the problem:
% grep ioctl /tmp/foo2 | sort -u | more
ioctl(13, SIOCGIWESSID, 0xbfbcdb9c) = 0
ioctl(13, SIOCGIWRANGE,
On Fri, Sep 22, 2006 at 12:38:44AM +0200, Jiri Benc wrote:
On Thu, 21 Sep 2006 13:39:18 -0700, mabbas wrote:
I can fix the patch to do just that if we agree on that.
Well, we need a flag indicating whether we are associated or not. I don't
know about such a flag in WE (hopefully we will
On Thu, Sep 21, 2006 at 05:42:35PM -0700, Jouni Malinen wrote:
On Thu, Sep 21, 2006 at 03:55:14PM -0700, Jean Tourrilhes wrote:
Jean, are there any other possibilities?
Yes, dropping SIOCSIWAP (set) entirely, and keep only
SIOCGIWAP (get).
I don't think that this would
On Tue, Sep 12, 2006 at 10:43:57AM +0200, Johannes Berg wrote:
But there are bits left and right, so
more inspection of drivers would be needed. For example, wavelan and
netwave are using encryption key sizes which are not compatible with
802.11.
Hmm, interesting. Will need to think
On Tue, Sep 12, 2006 at 02:02:59PM -0400, John W. Linville wrote:
On Tue, Aug 29, 2006 at 06:01:40PM -0700, Jean Tourrilhes wrote:
@@ -8861,7 +8861,7 @@ static int ipw_wx_set_essid(struct net_d
int length = 0;
mutex_lock(priv-mutex);
if (wrqu-essid.flags wrqu-essid.length
On Tue, Sep 12, 2006 at 02:02:59PM -0400, John W. Linville wrote:
On Tue, Aug 29, 2006 at 06:01:40PM -0700, Jean Tourrilhes wrote:
This hunk doesn't apply to the upstream branch of wireless-2.6.
I propose this one instead:
@@ -8875,8 +8875,6 @@ static int ipw_wx_set_essid(struct net_d
On Mon, Sep 11, 2006 at 08:46:36AM +0300, Samuel Ortiz wrote:
Hi Dave,
We lock the socket when both releasing and getting a disconnected
notification. In the latter case, we also ste the socket as orphan.
This fixes a potential kernel bug that can be triggered when we get the
disconnection
On Fri, Sep 08, 2006 at 10:29:23AM -0400, John W. Linville wrote:
On Wed, Sep 06, 2006 at 02:30:53PM -0700, Jean Tourrilhes wrote:
On Wed, Sep 06, 2006 at 04:55:44PM -0400, John W. Linville wrote:
+ * V20 to V21
+ * --
+ * - Remove (struct net_device
On Wed, Sep 06, 2006 at 04:55:44PM -0400, John W. Linville wrote:
On Thu, Aug 31, 2006 at 04:00:05PM +0200, Johannes Berg wrote:
On Thu, 2006-08-31 at 06:51 -0700, Jouni Malinen wrote:
I don't know about the others, but long/short retry limits have users
(e.g., Host AP driver) and
On Mon, Sep 04, 2006 at 10:35:09AM +0200, Johannes Berg wrote:
Uh, please don't strip me from the CC list :)
WE-netlink is optional. And WE-ioctl could be made optional
(still on the todo list). You can also disable WE-event and WE-iwspy
for further footprint reduction.
The real
On Fri, Sep 01, 2006 at 08:54:00AM +0200, Johannes Berg wrote:
On Thu, 2006-08-31 at 10:12 -0700, Jean Tourrilhes wrote:
And I strongly disagree with your disagrement ;-)
You're of course free to do that :) But let me explain.
And my explanation is even more simple : let's
On Fri, Sep 01, 2006 at 08:55:48PM +0200, Michael Buesch wrote:
Note that one thing that worry me with your approach is
footprint. I've used various embedded devices over the years, such as
the Gumstix (4MB Flash), and this is why WE was optimised for
footprint.
Can you please
On Thu, Aug 31, 2006 at 03:09:04PM +0200, Johannes Berg wrote:
Jean,
This is the version of the patch for out-of-tree, I guess you
will need it. Not tested.
We don't, neither softmac nor bcm43xx is maintained out-of-tree any
more.
johannes
Cool. I should have checked...
On Thu, Aug 31, 2006 at 09:57:45AM -0400, John W. Linville wrote:
On Thu, Aug 31, 2006 at 08:22:22AM -0500, Larry Finger wrote:
John, have you merged, or do you plan to merge, [PATCH 2.6.18] WE-21
support (core API) into
wireless-2.6?
I guess that is still up for discussion. It looks
On Thu, Aug 31, 2006 at 03:32:18PM +0200, Johannes Berg wrote:
On Tue, 2006-08-29 at 17:56 -0700, Jean Tourrilhes wrote:
o modulation
o long/short retry
o relative power saving.
I strongly disagree to these.
And I strongly disagree with your
On Wed, Aug 30, 2006 at 03:46:27AM +0100, Daniel Drake wrote:
Looks like zd1211rw was forgotten from the WE-21 migration. This patch
should do it...
Good catch !
Actually, I did look at it, and verified that it was using
softmac for ESSID, so I thought I was ok... With the
On Wed, Aug 30, 2006 at 02:51:05PM +0200, Michael Buesch wrote:
On Wednesday 30 August 2006 03:12, Jean Tourrilhes wrote:
Hi,
WE-21 for Broadcom driver and SoftMAC...
This version is for wireless-2.6 git.
Jean
Signed-off-by: Jean Tourrilhes [EMAIL
Hi,
WE-21 for Aironet driver...
Jean
Signed-off-by: Jean Tourrilhes [EMAIL PROTECTED]
---
diff -u -p linux/drivers/net/wireless/airo.20.c
linux/drivers/net/wireless/airo.c
--- linux/drivers/net/wireless/airo.20.c
Hi,
WE-21 for Atmel driver...
Jean
Signed-off-by: Jean Tourrilhes [EMAIL PROTECTED]
---
diff -u -p linux/drivers/net/wireless/atmel.19.c
linux/drivers/net/wireless/atmel.c
--- linux/drivers/net/wireless/atmel.19
Hi,
WE-21 for HostAP driver...
Jean
Signed-off-by: Jean Tourrilhes [EMAIL PROTECTED]
---
diff -u -p linux/drivers/net/wireless/hostap/hostap_ioctl.20.c
linux/drivers/net/wireless/hostap/hostap_ioctl.c
--- linux
sending that into Linus's kernel at the next
opportunity, for example for 2.6.19-pre.
Have fun...
Jean
Signed-off-by: Jean Tourrilhes [EMAIL PROTECTED]
---
diff -u -p linux/include/linux/wireless.20.h linux/include/linux
Hi,
WE-21 for Raylink driver...
Jean
Signed-off-by: Jean Tourrilhes [EMAIL PROTECTED]
---
diff -u -p linux/drivers/net/wireless/ray_cs.20.c
linux/drivers/net/wireless/ray_cs.c
--- linux/drivers/net/wireless
Hi,
WE-21 for Orinoco driver...
Jean
Signed-off-by: Jean Tourrilhes [EMAIL PROTECTED]
---
diff -u -p linux/drivers/net/wireless/orinoco.20.c
linux/drivers/net/wireless/orinoco.c
--- linux/drivers/net/wireless
Hi,
WE-21 for wl3501 driver...
Jean
Signed-off-by: Jean Tourrilhes [EMAIL PROTECTED]
---
--- linux/drivers/net/wireless/wl3501_cs.20.c 2006-08-28 17:41:19.0
-0700
+++ linux/drivers/net/wireless
Hi,
WE-21 for ZyDAS driver...
Jean
Signed-off-by: Jean Tourrilhes [EMAIL PROTECTED]
---
diff -u -p linux/drivers/net/wireless/zd1201.20.c
linux/drivers/net/wireless/zd1201.c
--- linux/drivers/net/wireless
Hi,
WE-21 for ADMTek driver...
Patch for wireless-2.6 git...
Jean
Signed-off-by: Jean Tourrilhes [EMAIL PROTECTED]
---
diff -u -p linux/drivers/net/wireless/adm8211/adm8211_ioctl.20.c
linux/drivers/net
Hi,
WE-21 for Broadcom driver and SoftMac...
This version is for 2.6.18-rc5.
Jean
Signed-off-by: Jean Tourrilhes [EMAIL PROTECTED]
---
diff -u -p linux/net/ieee80211/softmac/ieee80211softmac_wx.20.c
linux
...
Jean
Signed-off-by: Jean Tourrilhes [EMAIL PROTECTED]
---
diff -u -p linux/drivers/net/wireless/prism54/isl_ioctl.r1.c
linux/drivers/net/wireless/prism54/isl_ioctl.c
--- linux/drivers/net/wireless/prism54/isl_ioctl.r1.c 2006
need to postpone the sending of
netlink skb's to a tasklet.
Yes, this was needed. I really like the way you implemented
it, simple and efficient. Go for it !
Signed-off-by: Herbert Xu [EMAIL PROTECTED]
For what it's worth :
Signed-off-by: Jean Tourrilhes [EMAIL PROTECTED
On Thu, Aug 03, 2006 at 03:11:53PM +0100, Christoph Hellwig wrote:
On Thu, Aug 03, 2006 at 11:54:41PM +1000, Herbert Xu wrote:
Arjan van de Ven [EMAIL PROTECTED] wrote:
this is another one of those nasty buggers;
Good catch. It's really time that we fix this properly rather than
On Thu, Jul 13, 2006 at 11:37:45PM -0400, Dan Williams wrote:
On Tue, 2006-07-11 at 23:03 -0500, Larry Finger wrote:
Dan Williams wrote:
NAK... remember, range-max_qual.level must be _0_ if you're in dBm,
I do not think this is right. From the comments in include/linux/wireless.h:
On Thu, May 25, 2006 at 11:09:21AM -0700, Randy.Dunlap wrote:
From: Randy Dunlap [EMAIL PROTECTED]
Fix section mismatch warning:
WARNING: drivers/net/wireless/wavelan.o - Section mismatch: reference to
.init.text: from .text between 'init_module' (at offset 0x371e) and
'cleanup_module'
On Sun, May 14, 2006 at 11:29:38PM -0400, Dan Williams wrote:
On Mon, 2006-05-15 at 00:29 +0100, Daniel Drake wrote:
Hi Jean,
Hi,
Nice discussion you got going here ;-)
I'd just like to check my understanding (and softmacs implementation)
of SIWESSID and SIWAP behaviour,
On Mon, May 15, 2006 at 02:40:14PM -0700, Jouni Malinen wrote:
On Mon, May 15, 2006 at 01:28:13PM -0700, Jean Tourrilhes wrote:
I believe the BSSID has to be unique. HP APs can also offer
multiple ESSID for the same BSSID, but they do so using different
BSSID. If you look
Marcin Juszkiewicz wrote :
This time I checked more carefully my changeset and split it into
smaller parts. Few of my patches was tested by OpenZaurus users, some
are waiting for testing.
I'm sorry, but I will have again to veto part of your patch.
You are removing IDs from
On Tue, May 09, 2006 at 12:54:55AM -0400, Pavel Roskin wrote:
On Mon, 2006-05-08 at 10:17 -0700, Jean Tourrilhes wrote:
But shouldn't you trust the drivers using IW_QUAL_DBM, whether the value
is positive or negative?
You can't remove the test, making the rest pointeless. Old
On Sat, May 06, 2006 at 11:32:12PM -0400, Pavel Roskin wrote:
On Fri, 2006-05-05 at 10:28 -0700, Jean Tourrilhes wrote:
There are still quite a few drivers which have not been
converted to use IW_QUAL_DBM, so I don't want to drop the backward
compatibility yet.
But shouldn't you
On Thu, May 04, 2006 at 12:37:45PM -0400, Pavel Roskin wrote:
Hello, Jean!
I'm converting Orinoco to the dBm reporting, and it turns out that the
best signal iwconfig will report is -1dBm (0.8mW). This would happen if
qual-level has its highest value of 255. Please see this code from
On Thu, Apr 20, 2006 at 10:37:32AM -0400, Dan Williams wrote:
On Thu, 2006-04-20 at 15:15 +0100, Daniel Drake wrote:
Hi Jean,
A query regarding wireless events: under which circumstances should a
driver/stack send a SIOCGIWSCAN event to userspace?
Should it be sent whenever a
On Sun, Apr 16, 2006 at 02:34:48PM +0200, Johannes Berg wrote:
[breaking out to a new thread so discussion on this doesn't get too
hidden, CC Jean since he designed this]
- Is SIOCSIWFREQ allowed while associated?
No idea.
Usually no, but...
If you are in managed mode,
On Mon, Apr 17, 2006 at 08:48:10PM +0200, Johannes Berg wrote:
On Mon, 2006-04-17 at 09:37 -0700, Jean Tourrilhes wrote:
Usually no, but...
If you are in managed mode, SIOCSIWFREQ usually should return
an error, because it is not allowed.
Ok.
If you are in ad-hoc mode
On Mon, Apr 17, 2006 at 09:27:09PM +0200, Johannes Berg wrote:
On Mon, 2006-04-17 at 12:06 -0700, Jean Tourrilhes wrote:
Definitely. I was just pointing out that scanning behaviour is
not dictated by current setting of the drivers (except when the
hardware does it, cf. Ornoco
Hi,
You now need to send those patches to :
[EMAIL PROTECTED]
Personally, I don't see what this patch buy us...
Jean
On Fri, Apr 14, 2006 at 01:44:46PM +0200, Adrian Bunk wrote:
This patch removes the following unused EXPORT_SYMBOL's:
-
.
Fully tested on 2.6.17-rc1.
Have fun...
Jean
Signed-off-by: Jean Tourrilhes [EMAIL PROTECTED]
---
diff -u -p linux/net/core/wireless.j1.c linux/net/core/wireless.c
--- linux/net/core/wireless.j1.c2006-04-13 18:29
On Fri, Apr 14, 2006 at 10:59:13AM -0700, Randy.Dunlap wrote:
On Fri, 14 Apr 2006 10:47:26 -0700 Jean Tourrilhes wrote:
Hi John,
I've just realised that the RtNetlink code does not check the
permission for SIOCGIWENCODE and SIOCGIWENCODEEXT, which means that
any user can read
On Fri, Apr 14, 2006 at 08:20:15PM +0200, Christoph Hellwig wrote:
sir_kthread.c pretty much duplicates the workqueue functionality.
Switch it to use a workqueue instead. It could probably use
schedule_work/schedule_delayed_work instead of having it's own
waitqueue, but I'd rather leave that
Pete Zaitcev wrote :
Do you realize that block means enterering the kernel and calling
schedule(), which is exactly what is NOT happening in the patch?
I would not mind if the tools blocked in GIWSCAN, only until
it returns success and not EGAIN.
Do you realise that block means
Stephen Hemminger wrote :
Sounds like you want a message interface like netlink, not ioctl's.
We have the message interface (through a Wireless Events,
since WE-14). However, netlink is highly undesirable in embedded space
for bloat reason.
Jean
-
To unsubscribe from this
Hi,
Check the permissions when user-space try to read the
encryption parameters via SIOCGIWENCODEEXT. This is trivial and
probably should go in 2.6.17...
Bug was found by Brian Eaton [EMAIL PROTECTED], thanks !
Have fun...
Jean
Signed-off-by: Jean
this change
help disambiguate the relation between those two options.
Have fun...
Jean
Signed-off-by: Jean Tourrilhes [EMAIL PROTECTED]
---
diff -u -p linux/drivers/net/wireless/Kconfig-b1
linux/drivers/net/wireless/Kconfig
1 - 100 of 144 matches
Mail list logo
