On 18/01/2008, Samuel Ortiz [EMAIL PROTECTED] wrote:
Hi Dave,
Here goes an IrDA patch against your latest net-2.6 tree.
This patch fixes some af_irda memory leaks.
It also checks for irias_new_obect() return value.
Signed-off-by: Jesper Juhl [EMAIL PROTECTED]
Signed-off-by: Samuel Ortiz
think
it's a lot nicer to simply return -ENOMEM to the caller here where we know
a memory allocation failed, rather than hitting an assertion later.
note: I don't have any means of actually testing this, so it has been
compile tested only.
Signed-off-by: Jesper Juhl [EMAIL PROTECTED
new ias_obj
The Coverity checker gets credit for pointing its finger towards this.
Signed-off-by: Jesper Juhl [EMAIL PROTECTED]
---
af_irda.c |8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/net/irda/af_irda.c b/net/irda/af_irda.c
index e33f0a5..352e8a7 100644
?
A module parameter that overrules the automatic detection (for when it
gets it wrong) would probably also be a good idea.
--
Jesper Juhl [EMAIL PROTECTED]
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please http://www.expita.com/nomime.html
From: Jesper Juhl [EMAIL PROTECTED]
In net/sctp/sm_statefuns.c::sctp_sf_abort_violation() we may leak
the storage allocated for 'abort' by returning from the function
without using or freeing it. This happens in case
sctp_auth_recv_cid(SCTP_CID_ABORT, asoc) is true and we jump to
the 'discard
On 30/08/2007, Daniel Drake [EMAIL PROTECTED] wrote:
Jesper Juhl wrote:
Since kmalloc() returns a void pointer there is no reason to cast
its return value.
This patch also removes a pointless initialization of a variable.
NAK: adds a sparse warning
zd_chip.c:116:15: warning: implicit
On Friday 31 August 2007 00:19:53 Joe Perches wrote:
On Thu, 2007-08-30 at 22:20 +0200, Jesper Juhl wrote:
Ok, I must admit I didn't check with sparse since it seemed pointless
- we usually never cast void pointers to other pointer types,
specifically because the C language nicely
;)
--
Jesper Juhl [EMAIL PROTECTED]
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please http://www.expita.com/nomime.html
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo
kmalloc() and friends return void*, no need to cast it.
Signed-off-by: Jesper Juhl [EMAIL PROTECTED]
---
drivers/net/wireless/libertas/debugfs.c |2 +-
drivers/net/wireless/libertas/ethtool.c |3 +--
2 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/net/wireless
The general kernel memory allocation functions return void pointers
and there is no need to cast their return values.
Signed-off-by: Jesper Juhl [EMAIL PROTECTED]
---
drivers/net/bsd_comp.c |6 ++
1 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/net/bsd_comp.c b
that we generally want to do as little
work as possible while holding a lock, wouldn't the following be
slightly better?
Signed-off-by: Keir Fraser [EMAIL PROTECTED]
Signed-off-by: Jeremy Fitzhardinge [EMAIL PROTECTED]
Cc: Jeff Garzik [EMAIL PROTECTED]
Signed-off-by: Jesper Juhl [EMAIL PROTECTED
for a NULL
'dev', then that NULL deref can never happen.
It never hurts to be safe :-)
Signed-off-by: Jesper Juhl [EMAIL PROTECTED]
---
diff --git a/drivers/net/tokenring/3c359.c b/drivers/net/tokenring/3c359.c
index e22a3f5..671f4da 100644
--- a/drivers/net/tokenring/3c359.c
+++ b/drivers/net
(this one looks like it should go to netdev as well - added to Cc)
On 10/08/07, Sinisa Segvic [EMAIL PROTECTED] wrote:
Hi,
I've just got a kernel oops.
http://lxr.linux.no/source/Documentation/oops-tracing.txt
seems to suggest that oops reports are welcome at this address.
Cheers,
barriers and locks...
Points to -- Documentation/volatile-considered-harmful.txt
--
Jesper Juhl [EMAIL PROTECTED]
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please http://www.expita.com/nomime.html
-
To unsubscribe from this list: send the line
On 09/08/2007, Chris Snook [EMAIL PROTECTED] wrote:
Jesper Juhl wrote:
On 09/08/2007, Chris Snook [EMAIL PROTECTED] wrote:
From: Chris Snook [EMAIL PROTECTED]
Some architectures currently do not declare the contents of an atomic_t to
be
volatile. This causes confusion since
'dev', then that NULL deref can never happen.
It never hurts to be safe :-)
Signed-off-by: Jesper Juhl [EMAIL PROTECTED]
---
diff --git a/drivers/net/tokenring/3c359.c b/drivers/net/tokenring/3c359.c
index e22a3f5..671f4da 100644
--- a/drivers/net/tokenring/3c359.c
+++ b/drivers/net/tokenring/3c359
after that check.
Please consider merging.
Signed-off-by: Jesper Juhl [EMAIL PROTECTED]
---
drivers/net/usb/pegasus.c |4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/drivers/net/usb/pegasus.c b/drivers/net/usb/pegasus.c
index a05fd97..04cba6b 100644
--- a/drivers/net
On 29/07/07, Satyam Sharma [EMAIL PROTECTED] wrote:
Hi,
On 7/29/07, Jesper Juhl [EMAIL PROTECTED] wrote:
Hello,
This patch makes sure we don't dereference a NULL pointer in
drivers/net/usb/pegasus.c::write_bulk_callback() in the initial
struct net_device *net = pegasus-net; assignment
On 24/07/07, Patrick McHardy [EMAIL PROTECTED] wrote:
Jesper Juhl wrote:
This patch cleans up duplicate includes in
net/netfilter/
I've queued this one and the bridge-netfilter patch (27/37), thanks
Jesper.
Thanks for the feedback Patrick.
--
Jesper Juhl [EMAIL PROTECTED]
Don't top
Hi,
This patch cleans up duplicate includes in
net/atm/
Signed-off-by: Jesper Juhl [EMAIL PROTECTED]
---
diff --git a/net/atm/lec.c b/net/atm/lec.c
index 2770fb4..59d5aa3 100644
--- a/net/atm/lec.c
+++ b/net/atm/lec.c
@@ -21,7 +21,6 @@
#include net/dst.h
#include linux/proc_fs.h
Hi,
This patch cleans up duplicate includes in
net/bridge/
Signed-off-by: Jesper Juhl [EMAIL PROTECTED]
---
diff --git a/net/bridge/netfilter/ebt_log.c b/net/bridge/netfilter/ebt_log.c
index 031bfa4..89d0d59 100644
--- a/net/bridge/netfilter/ebt_log.c
+++ b/net/bridge/netfilter
Hi,
This patch cleans up duplicate includes in
net/ipv6/
Signed-off-by: Jesper Juhl [EMAIL PROTECTED]
---
diff --git a/net/ipv6/tcp_ipv6.c b/net/ipv6/tcp_ipv6.c
index d67fb1e..db50114 100644
--- a/net/ipv6/tcp_ipv6.c
+++ b/net/ipv6/tcp_ipv6.c
@@ -56,7 +56,6 @@
#include net/inet_ecn.h
Hi,
This patch cleans up duplicate includes in
net/sched/
Signed-off-by: Jesper Juhl [EMAIL PROTECTED]
---
diff --git a/net/sched/act_police.c b/net/sched/act_police.c
index bf90e60..6085be5 100644
--- a/net/sched/act_police.c
+++ b/net/sched/act_police.c
@@ -16,7 +16,6 @@
#include
Hi,
This patch cleans up duplicate includes in
net/netfilter/
Signed-off-by: Jesper Juhl [EMAIL PROTECTED]
---
diff --git a/net/netfilter/nf_conntrack_proto_tcp.c
b/net/netfilter/nf_conntrack_proto_tcp.c
index 87ad3cc..eb3fe74 100644
--- a/net/netfilter/nf_conntrack_proto_tcp.c
+++ b
Hi,
This patch cleans up duplicate includes in
net/xfrm/
Signed-off-by: Jesper Juhl [EMAIL PROTECTED]
---
diff --git a/net/xfrm/xfrm_policy.c b/net/xfrm/xfrm_policy.c
index c3a4b0a..e67489a 100644
--- a/net/xfrm/xfrm_policy.c
+++ b/net/xfrm/xfrm_policy.c
@@ -23,10 +23,9 @@
#include
Hi,
This patch cleans up duplicate includes in
net/tipc/
Signed-off-by: Jesper Juhl [EMAIL PROTECTED]
---
diff --git a/net/tipc/port.c b/net/tipc/port.c
index 5d2b9ce..7608815 100644
--- a/net/tipc/port.c
+++ b/net/tipc/port.c
@@ -41,7 +41,6 @@
#include addr.h
#include link.h
straightforward. There are multiple ways
of course, for some reason I've always used /proc/sys/kernel/printk for
this (which has the extra feature that it accepts values greater than
8 too :-)
Why not mention all the various methods, dmesg -n,
/proc/sys/kernel/printk, SysRq, ignore_loglevel ??
--
Jesper Juhl
.
How about this?
From: Satyam Sharma [EMAIL PROTECTED]
Add some useful general-purpose tips.
Signed-off-by: Satyam Sharma [EMAIL PROTECTED]
Cc: Keiichi Kii [EMAIL PROTECTED]
Acked-by: Matt Mackall [EMAIL PROTECTED]
Signed-off-by: Jesper Juhl [EMAIL PROTECTED]
---
Documentation/networking
to be able to handle that ofcourse, but I haven't checked that yet.
--
Jesper Juhl [EMAIL PROTECTED]
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please http://www.expita.com/nomime.html
-
To unsubscribe from this list: send the line unsubscribe
char*)(skb-nh.iph[1]);
So if 'skb' is NULL, the only route I see that doesn't cause a NULL
pointer deref is if (opt != NULL) and at the same time
(opt-is_data != NULL) . Is that guaranteed in any way? If now,
how come we don't blow up regularly?
--
Jesper Juhl [EMAIL PROTECTED]
Don't top-post
20: 00 00 00 00 00 00 00 00 00 00 00 00 43 10 45 13
30: 00 00 8c fe dc 00 00 00 00 00 00 00 0b 01 20 40
This PCI ID was added to 2.6.19. You should run 2.6.19-rc5 or backport the
changes.
--
Jesper Juhl [EMAIL PROTECTED]
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Coverity found what looks like a real leak in net/dccp/ipv6.c::dccp_v6_do_rcv()
We may leave via the return inside if (sk-sk_state == DCCP_OPEN) {
but at that point we may have allocated opt_skb, but we never free it
in that path before the return.
Signed-off-by: Jesper Juhl [EMAIL PROTECTED
- that way you wouldn't get all
the historical git data.
--
Jesper Juhl [EMAIL PROTECTED]
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please http://www.expita.com/nomime.html
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body
to accomplish that. If you know of a
better way I'd appreciate a hint :)
In any event, propagating this method pointer to the wrong device
structure is a bug.
Ok, then the patch as it stands is dead. I'll try to find another way.
Thank you for your comments.
--
Jesper Juhl [EMAIL PROTECTED]
Don't top
On 31/08/06, Jesper Juhl [EMAIL PROTECTED] wrote:
On 31/08/06, Ben Greear [EMAIL PROTECTED] wrote:
Jesper Juhl wrote:
Hi,
I've got a small problem with 2.6.18-rc5-git2.
I've got a vlan setup on eth0.20, eth0 does not have an IP.
When I attempt to reboot or halt the machine I get
On 01/09/06, Herbert Xu [EMAIL PROTECTED] wrote:
Jesper Juhl [EMAIL PROTECTED] wrote:
I've just encountered the problem on a different server with an
identical vlan setup. That server is running 2.6.13.4
Do you have a simple recipe to reproduce this? Ideally it'd be a
script that anyone can
On 01/09/06, Jesper Juhl [EMAIL PROTECTED] wrote:
On 01/09/06, Herbert Xu [EMAIL PROTECTED] wrote:
Jesper Juhl [EMAIL PROTECTED] wrote:
I've just encountered the problem on a different server with an
identical vlan setup. That server is running 2.6.13.4
Do you have a simple recipe
that's
mergable, I'd greatly appreciate it.
PS. If you reply to this on the netdev list, please keep me on Cc:
since I'm only subscribed to linux-kernel.
Kind regards,
Jesper Juhl [EMAIL PROTECTED]
Signed-off-by: Jesper Juhl [EMAIL PROTECTED]
---
net/8021q/vlan.c |5 +
net
On 31/08/06, Ben Greear [EMAIL PROTECTED] wrote:
Jesper Juhl wrote:
Hi,
I've got a small problem with 2.6.18-rc5-git2.
I've got a vlan setup on eth0.20, eth0 does not have an IP.
When I attempt to reboot or halt the machine I get the following
message from the loop in net/core/dev.c
a replacement URL if one exist, but
failing that removing the wrong ones is a good thing IMHO.
--
Jesper Juhl [EMAIL PROTECTED]
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please http://www.expita.com/nomime.html
-
To unsubscribe from this list
On 05/08/06, David Miller [EMAIL PROTECTED] wrote:
From: Jesper Juhl [EMAIL PROTECTED]
Date: Sat, 5 Aug 2006 01:30:49 +0200
On 31/07/06, David Miller [EMAIL PROTECTED] wrote:
From: Jesper Juhl [EMAIL PROTECTED]
Date: Sun, 30 Jul 2006 23:51:20 +0200
Looks ok to me.
I've applied
There's an obvious memory leak in net/ipv4/tcp_probe.c::tcpprobe_read()
We are not freeing 'tbuf' on error.
Patch below fixes that.
Signed-off-by: Jesper Juhl [EMAIL PROTECTED]
---
net/ipv4/tcp_probe.c |4 +++-
1 files changed, 3 insertions(+), 1 deletion(-)
--- linux-2.6.18-rc3-orig/net
On 30/07/06, James Morris [EMAIL PROTECTED] wrote:
On Sun, 30 Jul 2006, Stephen Hemminger wrote:
On Sun, 30 Jul 2006 21:38:02 +0200
Jesper Juhl [EMAIL PROTECTED] wrote:
There's an obvious memory leak in net/ipv4/tcp_probe.c::tcpprobe_read()
We are not freeing 'tbuf' on error.
Patch
apps. Even if
no app is known to the people on this list there may still be apps out
there depending on it - and we don't break userspace without *very*
good reasons, and even then it's announced for several months (years
sometimes) in Documentation/feature-removal.txt and elsewhere.
--
Jesper
break userspace if necessary.
Maybe if you described your current problem someone could suggest a
solution...
--
Jesper Juhl [EMAIL PROTECTED]
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please http://www.expita.com/nomime.html
-
To unsubscribe
something that could be used to
cause trouble and something that will lose its usefulness once enough
people start using it (for valid or invalid reasons), so what's the
point...
--
Jesper Juhl [EMAIL PROTECTED]
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only
Get rid of needless casting of kmalloc() return value in net/
Signed-off-by: Jesper Juhl [EMAIL PROTECTED]
---
net/bluetooth/hci_conn.c |2 +-
net/sunrpc/svc.c |4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
--- linux-2.6.15-rc5-git1-orig/net/bluetooth/hci_conn.c
this involve the kernel? The interface to the kernel
for hardware configuration is via ioctl(). For logic, sockets.
If the user-level tools suck, then they should be fixed. It
really doesn't have anything to do with the kernel.
Cheers,
Dick Johnson
[snip]
Thank you.
--
Jesper Juhl [EMAIL
simply change that?
Firmware should go into /lib/firmware, not /etc/firmware.
Found by Alejandro Bonilla.
Signed-off-by: Jesper Juhl [EMAIL PROTECTED]
---
drivers/net/wireless/Kconfig |2 +-
1 files changed, 1 insertion(+), 1 deletion(-)
--- linux-2.6.13-mm1-orig/drivers/net/wireless
).
--
Jesper Juhl [EMAIL PROTECTED]
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please http://www.expita.com/nomime.html
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo
the compressed files to the email
--
Jesper Juhl [EMAIL PROTECTED]
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please http://www.expita.com/nomime.html
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message
and not -mm,
so this patch is against 2.6.13.
Feedback, ACK, NACK, etc welcome.
Sorry about the large Cc list, but I wanted to include everyone involved
with the code I change.
Please keep me on Cc.
Signed-off-by: Jesper Juhl [EMAIL PROTECTED]
---
./drivers/net/wireless/airo.c |3 +--
./fs
52 matches
Mail list logo
