Re: [iproute2-next PATCH v6] tc: flower: Classify packets based port ranges

On 12/3/2018 3:52 PM, David Ahern wrote: > On 11/27/18 3:40 PM, Amritha Nambiar wrote: >> Added support for filtering based on port ranges. >> UAPI changes have been accepted into net-next. >> >> Example: >> 1. Match on a port range: >> - >> $ tc filter add dev enp4s0

Re: [iproute2-next PATCH v4] tc: flower: Classify packets based port ranges

On 11/26/2018 8:02 PM, Stephen Hemminger wrote: > On Mon, 26 Nov 2018 17:56:10 -0800 > "Nambiar, Amritha" wrote: > >> On 11/26/2018 4:43 PM, David Ahern wrote: >>> On 11/26/18 5:23 PM, Nambiar, Amritha wrote: >>>>> Can tc flower use so

Re: [iproute2-next PATCH v4] tc: flower: Classify packets based port ranges

On 11/26/2018 4:43 PM, David Ahern wrote: > On 11/26/18 5:23 PM, Nambiar, Amritha wrote: >>> Can tc flower use something similar to ip ru with single port or port >>> range handled like this? >>> >>> },{ >>> "priority": 32764,

Re: [iproute2-next PATCH v4] tc: flower: Classify packets based port ranges

On 11/21/2018 1:42 PM, David Ahern wrote: > On 11/20/18 11:17 PM, Amritha Nambiar wrote: >> diff --git a/tc/f_flower.c b/tc/f_flower.c >> index 65fca04..722647d 100644 >> --- a/tc/f_flower.c >> +++ b/tc/f_flower.c >> @@ -494,6 +494,68 @@ static int flower_parse_port(char *str, __u8 ip_proto, >>

Re: [iproute2-next PATCH v3 2/2] man: tc-flower: Add explanation for range option

On 11/20/2018 8:59 PM, David Ahern wrote: > On 11/20/18 9:59 PM, Nambiar, Amritha wrote: >> Oops, submitted the v2 patch for man changes too soon, without seeing >> this. So, in this case, should I re-submit the iproute2-flower patch >> that was accepted removing the 'range'

Re: [iproute2-next PATCH v3 2/2] man: tc-flower: Add explanation for range option

On 11/20/2018 8:46 PM, David Ahern wrote: > On 11/20/18 9:44 PM, Nambiar, Amritha wrote: >> On 11/20/2018 2:56 PM, David Ahern wrote: >>> On 11/15/18 5:55 PM, Amritha Nambiar wrote: >>>> Add details explaining filtering based on port ranges. >>&g

Re: [iproute2-next PATCH v3 2/2] man: tc-flower: Add explanation for range option

On 11/20/2018 2:56 PM, David Ahern wrote: > On 11/15/18 5:55 PM, Amritha Nambiar wrote: >> Add details explaining filtering based on port ranges. >> >> Signed-off-by: Amritha Nambiar >> --- >> man/man8/tc-flower.8 | 12 ++-- >> 1 file changed, 10 insertions(+), 2 deletions(-) >> >>

Re: [net-next PATCH v3] net: sched: cls_flower: Classify packets using port ranges

On 11/9/2018 11:14 PM, Jiri Pirko wrote: > Sat, Nov 10, 2018 at 01:11:10AM CET, amritha.namb...@intel.com wrote: > > [...] > >> @@ -1026,8 +1122,7 @@ static void fl_init_dissector(struct flow_dissector >> *dissector, >> FLOW_DISSECTOR_KEY_IPV4_ADDRS, ipv4); >>

Re: [net-next PATCH v2] net: sched: cls_flower: Classify packets using port ranges

On 11/9/2018 4:10 AM, Jiri Pirko wrote: > Wed, Nov 07, 2018 at 10:22:42PM CET, amritha.namb...@intel.com wrote: >> Added support in tc flower for filtering based on port ranges. >> >> Example: >> 1. Match on a port range: >> - >> $ tc filter add dev enp4s0 protocol ip

Re: [net-next PATCH v2] net: sched: cls_flower: Classify packets using port ranges

On 11/8/2018 3:15 PM, David Miller wrote: > From: Amritha Nambiar > Date: Wed, 07 Nov 2018 13:22:42 -0800 > >> diff --git a/include/uapi/linux/pkt_cls.h b/include/uapi/linux/pkt_cls.h >> index 401d0c1..b63c3cf 100644 >> --- a/include/uapi/linux/pkt_cls.h >> +++ b/include/uapi/linux/pkt_cls.h >>

Re: [iproute2 PATCH v2] tc: flower: Classify packets based port ranges

On 11/9/2018 12:51 AM, Jiri Pirko wrote: > Wed, Nov 07, 2018 at 10:22:50PM CET, amritha.namb...@intel.com wrote: >> Added support for filtering based on port ranges. >> >> Example: >> 1. Match on a port range: >> - >> $ tc filter add dev enp4s0 protocol ip parent :\ >>

Re: [net-next PATCH] net: sched: cls_flower: Classify packets using port ranges

On 10/19/2018 1:52 AM, Jiri Pirko wrote: > Thu, Oct 18, 2018 at 08:24:44PM CEST, amritha.namb...@intel.com wrote: >> On 10/18/2018 5:17 AM, Jiri Pirko wrote: >>> Fri, Oct 12, 2018 at 03:53:30PM CEST, amritha.namb...@intel.com wrote: Added support in tc flower for filtering based on port

Re: [iproute2 PATCH] tc: flower: Classify packets based port ranges

On 10/18/2018 5:21 AM, Jiri Pirko wrote: > Fri, Oct 12, 2018 at 03:54:42PM CEST, amritha.namb...@intel.com wrote: > > [...] > >> @@ -1516,6 +1625,22 @@ static int flower_print_opt(struct filter_util *qu, >> FILE *f, >> if (nl_type >= 0) >> flower_print_port("src_port",

Re: [net-next PATCH] net: sched: cls_flower: Classify packets using port ranges

On 10/18/2018 5:17 AM, Jiri Pirko wrote: > Fri, Oct 12, 2018 at 03:53:30PM CEST, amritha.namb...@intel.com wrote: >> Added support in tc flower for filtering based on port ranges. >> This is a rework of the RFC patch at: >> https://patchwork.ozlabs.org/patch/969595/ >> >> Example: >> 1. Match on a

Re: [net-next PATCH] net: sched: cls_flower: Classify packets using port ranges

On 10/17/2018 10:41 PM, Cong Wang wrote: > On Wed, Oct 17, 2018 at 9:42 PM David Miller wrote: >> >> From: Amritha Nambiar >> Date: Fri, 12 Oct 2018 06:53:30 -0700 >> >>> Added support in tc flower for filtering based on port ranges. >>> This is a rework of the RFC patch at: >>>

Re: [net-next, RFC PATCH] net: sched: cls_range: Introduce Range classifier

On 9/14/2018 2:58 AM, Jiri Pirko wrote: > Thu, Sep 13, 2018 at 10:52:06PM CEST, amritha.namb...@intel.com wrote: > > [...] > >> +static struct cls_range_filter *range_lookup(struct cls_range_head *head, >> + struct range_flow_key *key, >> +

Re: [net-next,RFC PATCH] Introduce TC Range classifier

On 9/14/2018 2:09 PM, Cong Wang wrote: > On Fri, Sep 14, 2018 at 2:53 AM Jiri Pirko wrote: >> >> Thu, Sep 13, 2018 at 10:52:01PM CEST, amritha.namb...@intel.com wrote: >>> This patch introduces a TC range classifier to support filtering based >>> on ranges. Only port-range filters are supported

Re: [net-next, v6, 6/7] net-sysfs: Add interface for Rx queue(s) map per Tx queue

On 7/4/2018 12:20 AM, Andrei Vagin wrote: > Hello Amritha, > > I see a following warning on 4.18.0-rc3-next-20180703. > It looks like a problem is in this series. > > [1.084722] > [1.084797] WARNING: possible recursive locking detected > [

Re: [net-next PATCH v5 4/7] net: Record receive queue number for a connection

On 6/29/2018 6:06 AM, David Miller wrote: > From: Amritha Nambiar > Date: Wed, 27 Jun 2018 15:31:34 -0700 > >> @@ -1702,6 +1709,13 @@ static inline int sk_tx_queue_get(const struct sock >> *sk) >> return -1; >> } >> >> +static inline void sk_rx_queue_set(struct sock *sk, const struct

Re: [net-next PATCH v5 3/7] net: sock: Change tx_queue_mapping in sock_common to unsigned short

On 6/29/2018 6:05 AM, David Miller wrote: > From: Amritha Nambiar > Date: Wed, 27 Jun 2018 15:31:28 -0700 > >> @@ -1681,17 +1681,25 @@ static inline int sk_receive_skb(struct sock *sk, >> struct sk_buff *skb, >> >> static inline void sk_tx_queue_set(struct sock *sk, int tx_queue) >> { >> +

Re: [net-next PATCH v5 1/7] net: Refactor XPS for CPUs and Rx queues

On 6/29/2018 5:59 AM, David Miller wrote: > From: Amritha Nambiar > Date: Wed, 27 Jun 2018 15:31:18 -0700 > >> diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h >> index c6b377a..3790ac9 100644 >> --- a/include/linux/netdevice.h >> +++ b/include/linux/netdevice.h > ... >>

Re: [net-next PATCH v4 5/7] net: Enable Tx queue selection based on Rx queues

On 6/27/2018 3:47 AM, Willem de Bruijn wrote: +static int get_xps_queue(struct net_device *dev, struct sk_buff *skb) { #ifdef CONFIG_XPS struct xps_dev_maps *dev_maps; - struct xps_map *map; + struct sock *sk = skb->sk; int

Re: [net-next PATCH v4 1/7] net: Refactor XPS for CPUs and Rx queues

On 6/26/2018 3:53 PM, Tom Herbert wrote: > On Mon, Jun 25, 2018 at 11:04 AM, Amritha Nambiar > wrote: >> Refactor XPS code to support Tx queue selection based on >> CPU(s) map or Rx queue(s) map. >> >> Signed-off-by: Amritha Nambiar >> --- >> include/linux/cpumask.h | 11 ++ >>

Re: [net-next PATCH v4 5/7] net: Enable Tx queue selection based on Rx queues

On 6/26/2018 4:04 AM, Willem de Bruijn wrote: > On Mon, Jun 25, 2018 at 7:06 PM Amritha Nambiar > wrote: >> >> This patch adds support to pick Tx queue based on the Rx queue(s) map >> configuration set by the admin through the sysfs attribute >> for each Tx queue. If the user configuration for

Re: [net-next PATCH v4 6/7] net-sysfs: Add interface for Rx queue(s) map per Tx queue

On 6/26/2018 3:55 AM, Willem de Bruijn wrote: > On Mon, Jun 25, 2018 at 7:06 PM Amritha Nambiar > wrote: >> >> Extend transmit queue sysfs attribute to configure Rx queue(s) map >> per Tx queue. By default no receive queues are configured for the >> Tx queue. >> >> -

Re: [net-next PATCH v4 3/7] net: sock: Change tx_queue_mapping in sock_common to unsigned short

On 6/26/2018 3:58 AM, Willem de Bruijn wrote: > On Mon, Jun 25, 2018 at 7:06 PM Amritha Nambiar > wrote: >> >> Change 'skc_tx_queue_mapping' field in sock_common structure from >> 'int' to 'unsigned short' type with 0 indicating unset and >> a positive queue value being set. This way it is

Re: [net-next PATCH v4 3/7] net: sock: Change tx_queue_mapping in sock_common to unsigned short

On 6/25/2018 8:25 PM, Alexander Duyck wrote: > On Mon, Jun 25, 2018 at 6:34 PM, Tom Herbert wrote: >> >> >> On Mon, Jun 25, 2018 at 11:04 AM, Amritha Nambiar >> wrote: >>> >>> Change 'skc_tx_queue_mapping' field in sock_common structure from >>> 'int' to 'unsigned short' type with 0 indicating

Re: [net-next PATCH v3 3/5] net: Enable Tx queue selection based on Rx queues

On 6/6/2018 12:13 PM, Willem de Bruijn wrote: > On Wed, Jun 6, 2018 at 3:08 PM, Samudrala, Sridhar > wrote: >> >> On 6/6/2018 11:56 AM, Willem de Bruijn wrote: >>> >>> On Tue, Jun 5, 2018 at 4:38 AM, Amritha Nambiar >>> wrote: This patch adds support to pick Tx queue based on the Rx

Re: [net-next PATCH v3 3/5] net: Enable Tx queue selection based on Rx queues

On 6/5/2018 10:57 AM, Tom Herbert wrote: > > > On Tue, Jun 5, 2018 at 1:38 AM, Amritha Nambiar > mailto:amritha.namb...@intel.com>> wrote: > > This patch adds support to pick Tx queue based on the Rx queue(s) map > configuration set by the admin through the sysfs attribute > for

Re: [net-next PATCH v2 2/4] net: Enable Tx queue selection based on Rx queues

On 5/22/2018 7:09 AM, Tom Herbert wrote: > On Mon, May 21, 2018 at 8:12 AM, Willem de Bruijn > wrote: >> On Mon, May 21, 2018 at 10:51 AM, Tom Herbert wrote: >>> On Sat, May 19, 2018 at 1:27 PM, Willem de Bruijn >>>

Re: [net-next PATCH v2 2/4] net: Enable Tx queue selection based on Rx queues

On 5/19/2018 1:13 PM, Willem de Bruijn wrote: > On Fri, May 18, 2018 at 12:03 AM, Tom Herbert wrote: >> On Tue, May 15, 2018 at 6:26 PM, Amritha Nambiar >> wrote: >>> This patch adds support to pick Tx queue based on the Rx queue map >>>

Re: [net-next PATCH v2 1/4] net: Refactor XPS for CPUs and Rx queues

On 5/17/2018 9:08 PM, Tom Herbert wrote: > On Tue, May 15, 2018 at 6:26 PM, Amritha Nambiar > wrote: >> Refactor XPS code to support Tx queue selection based on >> CPU map or Rx queue map. >> >> Signed-off-by: Amritha Nambiar >> --- >>

Re: [net-next PATCH v2 3/4] net-sysfs: Add interface for Rx queue map per Tx queue

On 5/17/2018 12:05 PM, Florian Fainelli wrote: > On 05/15/2018 06:26 PM, Amritha Nambiar wrote: >> Extend transmit queue sysfs attribute to configure Rx queue map >> per Tx queue. By default no receive queues are configured for the >> Tx queue. >> >> - /sys/class/net/eth0/queues/tx-*/xps_rxqs > >

Re: [net-next PATCH v2 1/4] net: Refactor XPS for CPUs and Rx queues

On 5/17/2018 11:38 AM, David Miller wrote: > From: Amritha Nambiar > Date: Tue, 15 May 2018 18:26:43 -0700 > >> @@ -2125,7 +2125,7 @@ static bool remove_xps_queue_cpu(struct net_device >> *dev, >> int i, j; >> >> for (i = count, j = offset;

Re: [net-next PATCH 1/3] net: Refactor XPS for CPUs and Rx queues

On 5/14/2018 9:53 AM, Tom Herbert wrote: > On Wed, May 9, 2018 at 1:54 PM, Nambiar, Amritha > <amritha.namb...@intel.com> wrote: >> On 5/9/2018 1:31 PM, Tom Herbert wrote: >>> On Thu, Apr 19, 2018 at 6:04 PM, Amritha Nambiar >>> <amritha.namb...@intel.com>

Re: [net-next PATCH 1/3] net: Refactor XPS for CPUs and Rx queues

On 5/9/2018 1:31 PM, Tom Herbert wrote: > On Thu, Apr 19, 2018 at 6:04 PM, Amritha Nambiar > wrote: >> Refactor XPS code to support Tx queue selection based on >> CPU map or Rx queue map. >> >> Signed-off-by: Amritha Nambiar >> --- >>

Re: [net-next PATCH 0/3] Symmetric queue selection using XPS for Rx queues

On 5/8/2018 10:19 AM, Alexander Duyck wrote: > On Tue, May 8, 2018 at 10:07 AM, Eric Dumazet wrote: >> >> >> On 05/08/2018 09:02 AM, Alexander Duyck wrote: >>> On Tue, May 8, 2018 at 8:15 AM, Tom Herbert wrote: On Thu, Apr 19, 2018 at 7:41 PM,

Re: [PATCH net] i40e: flower: check if TC offload is enabled on a netdev

On 1/23/2018 12:08 AM, Jakub Kicinski wrote: > Since TC block changes drivers are required to check if > the TC hw offload flag is set on the interface themselves. > > Fixes: 2f4b411a3d67 ("i40e: Enable cloud filters via tc-flower") > Fixes: 44ae12a768b7 ("net: sched: move the can_offload check

Re: [iproute2 PATCH] tc/mqprio: Offload mode and shaper options in mqprio

On 10/31/2017 10:20 AM, Stephen Hemminger wrote: > On Thu, 26 Oct 2017 17:02:42 -0700 > Amritha Nambiar wrote: > >> This patch was previously submitted as RFC. Submitting this as >> non-RFC now that the tc/mqprio changes are accepted in net-next. >> >> Adds new mqprio

Re: [Intel-wired-lan] [jkirsher/next-queue PATCH v4 6/6] i40e: Enable cloud filters via tc-flower

On 10/26/2017 2:35 PM, Shannon Nelson wrote: > On 10/26/2017 2:29 PM, Nambiar, Amritha wrote: >> On 10/11/2017 4:30 PM, Shannon Nelson wrote: >>> On 10/10/2017 5:24 PM, Amritha Nambiar wrote: > > [...] > >>>> + /* For Geneve, the

Re: [Intel-wired-lan] [jkirsher/next-queue PATCH v4 6/6] i40e: Enable cloud filters via tc-flower

On 10/11/2017 4:30 PM, Shannon Nelson wrote: > On 10/10/2017 5:24 PM, Amritha Nambiar wrote: >> This patch enables tc-flower based hardware offloads. tc flower >> filter provided by the kernel is configured as driver specific >> cloud filter. The patch implements functions and admin queue >>

Re: [Intel-wired-lan] [jkirsher/next-queue PATCH v4 3/6] i40e: Cloud filter mode for set_switch_config command

On 10/11/2017 4:30 PM, Shannon Nelson wrote: > On 10/10/2017 5:24 PM, Amritha Nambiar wrote: >> Add definitions for L4 filters and switch modes based on cloud filters >> modes and extend the set switch config command to include the >> additional cloud filter mode. >> >> Signed-off-by: Amritha

Re: [patch net-next v2 00/20] net: sched: convert cls ndo_setup_tc offload calls to per-block callbacks

On 10/25/2017 5:15 AM, Jiri Pirko wrote: > Tue, Oct 24, 2017 at 06:01:34PM CEST, alexander.du...@gmail.com wrote: > > [...] > >> 1. To offload filter into HW, the hw-tc-offload feature flag has >> to be turned on before creating the ingress qdisc. >> >> Previously, this could also be

Re: [patch net-next v2 00/20] net: sched: convert cls ndo_setup_tc offload calls to per-block callbacks

On 10/24/2017 10:02 AM, Or Gerlitz wrote: > On Tue, Oct 24, 2017 at 7:24 PM, Alexander Duyck > > wrote: > > On Tue, Oct 24, 2017 at 9:01 AM, Alexander Duyck > > wrote:

Re: [Intel-wired-lan] [PATCH] [v2] i40e: avoid 64-bit division where possible

On 10/17/2017 10:33 AM, Alexander Duyck wrote: > On Tue, Oct 17, 2017 at 8:49 AM, Arnd Bergmann wrote: >> The new bandwidth calculation caused a link error on 32-bit >> architectures, like >> >> ERROR: "__aeabi_uldivmod" [drivers/net/ethernet/intel/i40e/i40e.ko] >> undefined! >>

Re: [net-next 4/9] i40e: Enable 'channel' mode in mqprio for TC configs

On 10/16/2017 1:53 AM, Yunsheng Lin wrote: > Hi, Jeff > > On 2017/10/14 5:52, Jeff Kirsher wrote: >> From: Amritha Nambiar >> >> The i40e driver is modified to enable the new mqprio hardware >> offload mode and factor the TCs and queue configuration by >> creating

Re: [jkirsher/next-queue PATCH v4 0/6] tc-flower based cloud filters in i40e

On 10/11/2017 5:42 AM, Jamal Hadi Salim wrote: > On 17-10-10 08:24 PM, Amritha Nambiar wrote: >> This patch series enables configuring cloud filters in i40e >> using the tc-flower classifier. The classification function >> of the filter is to match a packet to a class. cls_flower is >> extended to

Re: [RFC PATCH v3 7/7] i40e: Enable cloud filters via tc-flower

On 9/14/2017 1:00 AM, Nambiar, Amritha wrote: > On 9/13/2017 6:26 AM, Jiri Pirko wrote: >> Wed, Sep 13, 2017 at 11:59:50AM CEST, amritha.namb...@intel.com wrote: >>> This patch enables tc-flower based hardware offloads. tc flower >>> filter provided by the kernel is co

Re: [RFC PATCH v3 7/7] i40e: Enable cloud filters via tc-flower

On 9/13/2017 6:26 AM, Jiri Pirko wrote: > Wed, Sep 13, 2017 at 11:59:50AM CEST, amritha.namb...@intel.com wrote: >> This patch enables tc-flower based hardware offloads. tc flower >> filter provided by the kernel is configured as driver specific >> cloud filter. The patch implements functions and

Re: [RFC PATCH v3 2/7] sched: act_mirred: Traffic class option for mirror/redirect action

On 9/13/2017 6:18 AM, Jiri Pirko wrote: > Wed, Sep 13, 2017 at 11:59:24AM CEST, amritha.namb...@intel.com wrote: >> Adds optional traffic class parameter to the mirror/redirect action. >> The mirror/redirect action is extended to forward to a traffic >> class on the device if the traffic class

Re: [RFC PATCH v3 0/6] Configuring traffic classes via new hardware offload mechanism in tc/mqprio

On 9/7/2017 11:34 AM, Florian Fainelli wrote: > On 09/07/2017 04:00 AM, Amritha Nambiar wrote: >> The following series introduces a new hardware offload mode in >> tc/mqprio where the TCs, the queue configurations and bandwidth >> rate limits are offloaded to the hardware. The existing mqprio

Re: [Intel-wired-lan] [RFC PATCH v3 0/6] Configuring traffic classes via new hardware offload mechanism in tc/mqprio

On 9/7/2017 9:45 AM, Shannon Nelson wrote: > On 9/7/2017 4:00 AM, Amritha Nambiar wrote: >> The following series introduces a new hardware offload mode in >> tc/mqprio where the TCs, the queue configurations and >> bandwidth rate limits are offloaded to the hardware. The existing >> mqprio

Re: [Intel-wired-lan] [PATCH 6/6] [net-next]net: i40e: Enable cloud filters in i40e via tc/flower classifier

On 8/1/2017 12:16 PM, Shannon Nelson wrote: > On 7/31/2017 5:38 PM, Amritha Nambiar wrote: >> This patch enables tc-flower based hardware offloads. tc/flower >> filter provided by the kernel is configured as driver specific >> cloud filter. The patch implements functions and admin queue >>

Re: [Intel-wired-lan] [PATCH 5/6] [net-next]net: i40e: Clean up of cloud filters

On 8/1/2017 12:16 PM, Shannon Nelson wrote: > On 7/31/2017 5:38 PM, Amritha Nambiar wrote: >> Introduce the cloud filter datastructure and cleanup of cloud >> filters associated with the device. >> >> Signed-off-by: Amritha Nambiar >> --- >>

Re: [Intel-wired-lan] [PATCH 4/6] [net-next]net: i40e: Admin queue definitions for cloud filters

On 8/1/2017 12:16 PM, Shannon Nelson wrote: > On 7/31/2017 5:37 PM, Amritha Nambiar wrote: >> Add new admin queue definitions and extended fields for cloud >> filter support. Define big buffer for extended general fields >> in Add/Remove Cloud filters command. >> >> Signed-off-by: Amritha Nambiar

Re: [PATCH RFC, iproute2] tc/mirred: Extend the mirred/redirect action to accept additional traffic class parameter

On 8/2/2017 11:41 AM, Roopa Prabhu wrote: > On Mon, Jul 31, 2017 at 5:40 PM, Amritha Nambiar > wrote: >> The Mirred/redirect action is extended to accept a traffic >> class on the device in addition to the device's ifindex. >> >> Usage: mirred >> >> Example: >> # tc

Re: [PATCH RFC, iproute2] tc/mirred: Extend the mirred/redirect action to accept additional traffic class parameter

On 8/1/2017 8:12 AM, David Laight wrote: > From: Stephen Hemminger >> Sent: 01 August 2017 04:52 >> On Mon, 31 Jul 2017 17:40:50 -0700 >> Amritha Nambiar wrote: >> The concept is fine, bu t the code looks different than the rest which >> is never a good sign. >> >> >>>

Re: [PATCH 6/6] [net-next]net: i40e: Enable cloud filters in i40e via tc/flower classifier

On 8/2/2017 5:02 AM, Jamal Hadi Salim wrote: > On 17-08-01 10:13 PM, Nambiar, Amritha wrote: >> >> On 8/1/2017 3:56 AM, Jamal Hadi Salim wrote: >>> On 17-07-31 08:38 PM, Amritha Nambiar wrote: >>>> This patch enables tc-flower based hardware offloads. tc/flowe

Re: [PATCH net-next RFC 0/6] Configure cloud filters in i40e via tc/flower classifier

On 8/2/2017 5:01 AM, Jamal Hadi Salim wrote: > On 17-08-01 08:57 PM, Nambiar, Amritha wrote: >> >> On 8/1/2017 3:15 AM, Jamal Hadi Salim wrote: >>> On 17-07-31 08:36 PM, Amritha Nambiar wrote: > >>>> >>>> # tc filter add dev eth0 prot

Re: [PATCH 1/6] [net-next]net: sched: act_mirred: Extend redirect action to accept a traffic class

On 8/1/2017 4:12 AM, Jiri Pirko wrote: > Tue, Aug 01, 2017 at 02:37:37AM CEST, amritha.namb...@intel.com wrote: >> The Mirred/redirect action is extended to forward to a traffic >> class on the device. The traffic class index needs to be >> provided in addition to the device's ifindex. >> >>

Re: [PATCH 6/6] [net-next]net: i40e: Enable cloud filters in i40e via tc/flower classifier

On 8/1/2017 3:56 AM, Jamal Hadi Salim wrote: > On 17-07-31 08:38 PM, Amritha Nambiar wrote: >> This patch enables tc-flower based hardware offloads. tc/flower >> filter provided by the kernel is configured as driver specific >> cloud filter. The patch implements functions and admin queue >>

Re: [PATCH 1/6] [net-next]net: sched: act_mirred: Extend redirect action to accept a traffic class

On 8/1/2017 3:44 AM, Jamal Hadi Salim wrote: > On 17-07-31 08:37 PM, Amritha Nambiar wrote: >> The Mirred/redirect action is extended to forward to a traffic >> class on the device. The traffic class index needs to be >> provided in addition to the device's ifindex. >> >> Example: >> # tc filter

Re: [PATCH 1/6] [net-next]net: sched: act_mirred: Extend redirect action to accept a traffic class

On 8/1/2017 3:22 AM, Jamal Hadi Salim wrote: > On 17-07-31 08:37 PM, Amritha Nambiar wrote: >> The Mirred/redirect action is extended to forward to a traffic >> class on the device. The traffic class index needs to be >> provided in addition to the device's ifindex. >> >> Example: >> # tc filter

Re: [PATCH net-next RFC 0/6] Configure cloud filters in i40e via tc/flower classifier

On 8/1/2017 3:15 AM, Jamal Hadi Salim wrote: > On 17-07-31 08:36 PM, Amritha Nambiar wrote: >> This patch series enables configuring cloud filters in i40e >> using the tc/flower classifier. The only tc-filter action >> supported is to redirect packets to a traffic class on the >> same device. The

Re: [PATCH 0/4] Configuring traffic classes via new hardware offload mechanism in tc/mqprio

On 7/21/2017 2:42 AM, Richard Cochran wrote: On Mon, May 22, 2017 at 12:31:12PM -0700, Jeff Kirsher wrote: On Fri, 2017-05-19 at 17:58 -0700, Amritha Nambiar wrote: The following series introduces a new harware offload mode in tc/mqprio where the TCs, the queue configurations and bandwidth

Re: [PATCH 1/6] [next-queue]net: mqprio: Introduce new hardware offload mode in mqprio for offloading full TC configurations

On 7/14/2017 1:36 AM, Jamal Hadi Salim wrote: On 17-07-11 06:18 AM, Amritha Nambiar wrote: This patch introduces a new hardware offload mode in mqprio which makes full use of the mqprio options, the TCs, the queue configurations and the bandwidth rates for the TCs. This is achieved by setting

Re: [PATCH 0/6] Configuring traffic classes via new hardware offload mechanism in tc/mqprio

On 7/14/2017 12:56 AM, Jamal Hadi Salim wrote: Hi Amritha, On 17-07-11 06:18 AM, Amritha Nambiar wrote: The following series introduces a new hardware offload mode in tc/mqprio where the TCs, the queue configurations and bandwidth rate limits are offloaded to the hardware. The existing mqprio