Re: [PATCH] MIPS: NI 169445 board support

2017-01-05 Thread Nathan Sullivan
On Thu, Jan 05, 2017 at 06:33:53PM +, Joao Pinto wrote: > Hi, > > Às 6:28 PM de 1/5/2017, Niklas Cassel escreveu: > > On 01/04/2017 05:38 PM, Nathan Sullivan wrote: > >> On Tue, Dec 20, 2016 at 05:34:34PM +0100, Ralf Baechle wrote: > >>> On Fri, Dec

Re: [PATCH] MIPS: NI 169445 board support

2017-01-04 Thread Nathan Sullivan
On Tue, Dec 20, 2016 at 05:34:34PM +0100, Ralf Baechle wrote: > On Fri, Dec 02, 2016 at 09:42:09AM -0600, Nathan Sullivan wrote: > > Date: Fri, 2 Dec 2016 09:42:09 -0600 > > From: Nathan Sullivan <nathan.sulli...@ni.com> > > To: r...@linux-mips.org, mark.rutl...@

[PATCH] igb: adjust ptp timestamps for tx/rx latency

2016-05-03 Thread Nathan Sullivan
Table 7-62 on page 338 of the i210 datasheet lists TX and RX latencies for the various speeds the chip supports. To give better ptp timestamp accuracy, adjust the timestamps by the amounts Intel gives based on current link speed. Signed-off-by: Nathan Sullivan <nathan.sulli...@ni.

Re: [PATCH v2] net: macb: do not scan PHYs manually

2016-04-28 Thread Nathan Sullivan
On Thu, Apr 28, 2016 at 08:43:03PM +0200, Andrew Lunn wrote: > > I agree that is a valid fix for AT91, however it won't solve our problem, > > since > > we have no children on the second ethernet MAC in our devices' device > > trees. I'm > > starting to feel like our second MAC shouldn't even

Re: [PATCH v2] net: macb: do not scan PHYs manually

2016-04-28 Thread Nathan Sullivan
On Thu, Apr 28, 2016 at 06:32:07PM +0200, Andrew Lunn wrote: > > Hmm, are AT91 platforms special in this regard? As far as I can tell, this > > driver (macb) and Marvell PXA are the only ethernet drivers that call > > mdiobus_scan directly, and PXA does it on a known address. I do see that > >

Re: [PATCH v2] net: macb: do not scan PHYs manually

2016-04-28 Thread Nathan Sullivan
On Thu, Apr 28, 2016 at 05:44:14PM +0200, Nicolas Ferre wrote: > Le 28/04/2016 16:46, Nathan Sullivan a écrit : > > Since of_mdiobus_register and mdiobus_register will scan automatically, > > do not manually scan for PHY devices in the macb ethernet driver. Doing > > s

[PATCH v2] net: macb: do not scan PHYs manually

2016-04-28 Thread Nathan Sullivan
Since of_mdiobus_register and mdiobus_register will scan automatically, do not manually scan for PHY devices in the macb ethernet driver. Doing so will result in many nonexistent PHYs on the MDIO bus if the MDIO lines are floating or grounded, such as when they are not used. Signed-off-by: Nathan

[PATCH] net: macb: do not scan PHYs manually

2016-04-28 Thread Nathan Sullivan
Since of_mdiobus_register and mdiobus_register will scan automatically, do not manually scan for PHY devices in the macb ethernet driver. Doing so will result in many nonexistent PHYs on the MDIO bus if the MDIO lines are floating or grounded, such as when they are not used. Signed-off-by: Nathan

[PATCH] net/phy: micrel: Add workaround for bad autoneg

2015-10-21 Thread Nathan Sullivan
Very rarely, the KSZ9031 will appear to complete autonegotiation, but will drop all traffic afterwards. When this happens, the idle error count will read 0xFF after autonegotiation completes. Reset the PHY when in that state. Signed-off-by: Nathan Sullivan <nathan.sulli...@ni.com> --- d

Re: [PATCH] net/phy: micrel: Add workaround for bad autoneg

2015-10-21 Thread Nathan Sullivan
On Wed, Oct 21, 2015 at 12:20:21PM -0700, Florian Fainelli wrote: > 2015-10-21 12:17 GMT-07:00 Nathan Sullivan <nathan.sulli...@ni.com>: > > Very rarely, the KSZ9031 will appear to complete autonegotiation, but > > will drop all traffic afterwards. When this happens, the

Re: [PATCH v2] net/phy: micrel: Reenable interrupts during resume

2015-07-31 Thread Nathan Sullivan
On Fri, Jul 31, 2015 at 12:22:04AM -0700, David Miller wrote: From: Nathan Sullivan nathan.sulli...@ni.com Date: Thu, 30 Jul 2015 18:09:05 -0500 On Thu, Jul 30, 2015 at 10:00:34AM -0700, David Miller wrote: From: Nathan Sullivan nathan.sulli...@ni.com Date: Thu, 30 Jul 2015 10:15:48

Re: [RFC PATCH 0/2] net: macb: Add mdio driver for accessing multiple phy devices

2015-07-31 Thread Nathan Sullivan
On Tue, Jul 28, 2015 at 03:34:51AM +, Punnaiah Choudary Kalluri wrote: Ok. I will send you updated patch for mdio support soon and we will finalize next Course of actions if it doesn't break the existing flow. Thanks, Punnaiah When you submit this patch and mdio is seperate from

Re: [RFC PATCH 0/2] net: macb: Add mdio driver for accessing multiple phy devices

2015-07-31 Thread Nathan Sullivan
On Tue, Jul 28, 2015 at 03:34:51AM +, Punnaiah Choudary Kalluri wrote: Ok. I will send you updated patch for mdio support soon and we will finalize next Course of actions if it doesn't break the existing flow. Thanks, Punnaiah Just a heads up, when mdio no longer turns off when macb

[PATCH v2] net/phy: micrel: Reenable interrupts during resume

2015-07-30 Thread Nathan Sullivan
The ksz9031 has a behavior where it will clear the interrupt enable bits when leaving power down. To work around this, make sure the interrupt bits are in the state they are expected to be when resuming. Signed-off-by: Nathan Sullivan nathan.sulli...@ni.com --- Changes for V2: Actually make

Re: [PATCH v2] net/phy: micrel: Reenable interrupts during resume

2015-07-30 Thread Nathan Sullivan
On Thu, Jul 30, 2015 at 10:00:34AM -0700, David Miller wrote: From: Nathan Sullivan nathan.sulli...@ni.com Date: Thu, 30 Jul 2015 10:15:48 -0500 Changes for V2: Actually make sure it compiles this time. If V1 didn't compile, even for you, then I have a big problem. And that problem

[PATCH] net/phy: micrel: Reenable interrupts during resume

2015-07-29 Thread Nathan Sullivan
The ksz9031 has a behavior where it will clear the interrupt enable bits when leaving power down. To work around this, make sure the interrupt bits are in the state they are expected to be when resuming. Signed-off-by: Nathan Sullivan nathan.sulli...@ni.com --- drivers/net/phy/micrel.c | 18

[PATCH v2 3/3] ARM: zynq: DT: Use the zynq binding with macb

2015-05-22 Thread Nathan Sullivan
Use the new zynq binding for macb ethernet, since it will disable half duplex gigabit like the Zynq TRM says to do. Signed-off-by: Nathan Sullivan nathan.sulli...@ni.com --- arch/arm/boot/dts/zynq-7000.dtsi |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/boot

[PATCH v2 1/3] net: macb: Document zynq gem dt binding

2015-05-22 Thread Nathan Sullivan
Signed-off-by: Nathan Sullivan nathan.sulli...@ni.com --- Documentation/devicetree/bindings/net/cdns-emac.txt |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/net/cdns-emac.txt b/Documentation/devicetree/bindings/net/cdns-emac.txt index

[PATCH v2 2/3] net: macb: Disable half duplex gigabit on Zynq

2015-05-22 Thread Nathan Sullivan
According to the Zynq TRM, gigabit half duplex is not supported. Add a new cap and compatible string so Zynq can avoid advertising that mode. Signed-off-by: Nathan Sullivan nathan.sulli...@ni.com --- drivers/net/ethernet/cadence/macb.c | 12 drivers/net/ethernet/cadence/macb.h

[PATCH] net: macb: Disable half duplex gigabit on Zynq

2015-05-21 Thread Nathan Sullivan
According to the Zynq TRM, gigabit half duplex is not supported. Add a new cap and compatible string so Zynq can avoid advertising that mode. Signed-off-by: Nathan Sullivan nathan.sulli...@ni.com --- drivers/net/ethernet/cadence/macb.c | 12 drivers/net/ethernet/cadence/macb.h

[PATCH] net: macb: Handle the RXUBR interrupt on all devices

2015-05-05 Thread Nathan Sullivan
The same hardware issue the at91 must work around applies to at least the Zynq ethernet, and possibly more devices. The driver also needs to handle the RXUBR interrupt since it turns it on with MACB_RX_INT_FLAGS anyway. Signed-off-by: Nathan Sullivan nathan.sulli...@ni.com --- drivers/net