Hi James.
> > > If none of the 140 patches here fix a real bug, and there is no
> > > change to machine code then it sounds to me like a W=2 kind of a
> > > warning.
> >
> > FWIW, this series has found at least one bug so far:
> > https://lore.kernel.org/lkml/CAFCwf11izHF=g1mGry1fE5kvFFFrxzhPSM6q
Hi Mauro.
Laurent and I discussed this driver a little on irc.
Some highlights:
This parts could use register names:
+ writel(0x2, noc_dss_base + 0xc);
+ writel(0x2, noc_dss_base + 0x8c);
+ writel(0x2, noc_dss_base + 0x10c);
+ writel(0x2, noc_dss_base + 0x18c);
The two no
Hi Mauro
> Before posting the big patch series again, let me send the new
> version folded into a single patch.
>
> If you'd like to see the entire thing, I'm placing it here:
>
>
> https://gitlab.freedesktop.org/mchehab_kernel/hikey-970/-/commits/hikey970_v2/
Review 3/3
For next submis
Hi Mauro
> Before posting the big patch series again, let me send the new
> version folded into a single patch.
Review 2/N
The way output_poll_changed is used to set gpio_mux to select between
the panel and the HDMI looks strange. But I do not know if there is a
more correct way to do it. Other
Hi Mauro
> kirin9xx_fb_panel.h b/drivers/staging/hikey9xx/gpu/kirin9xx_fb_panel.h
> new file mode 100644
> index ..a69c20470f1d
> --- /dev/null
> +++ b/drivers/staging/hikey9xx/gpu/kirin9xx_fb_panel.h
This file is not referenced and should be deleted.
Sam
Hi Mauro.
> Before posting the big patch series again, let me send the new
> version folded into a single patch.
Review 1/N
Lots of small details I missed last time.
A good thing is that there is an opportunity to delete som more code.
Sam
> diff --git a/drivers/staging/hikey9xx/gpu/Kc
Hi Mauro.
On Fri, Aug 21, 2020 at 04:41:58PM +0200, Mauro Carvalho Chehab wrote:
> Another quick question:
>
> Em Wed, 19 Aug 2020 19:35:58 +0200
> Sam Ravnborg escreveu:
>
> > > +#define DSS_REDUCE(x)((x) > 0 ? ((x) - 1) : (x))
> > Use generic macros for
Hi Mauro.
Thanks for the detailed feedabck.
Two comments in the following.
Sam
>
> > > + ctx->dss_pri_clk = devm_clk_get(dev, "clk_edc0");
> > > + if (!ctx->dss_pri_clk) {
> > > + DRM_ERROR("failed to parse dss_pri_clk\n");
> > > + return -ENODEV;
> > > + }
> ...
>
> > I had ex
Hi Mauro.
Quick feedback below.
Sam
On Thu, Aug 20, 2020 at 05:13:22PM +0200, Mauro Carvalho Chehab wrote:
> Em Thu, 20 Aug 2020 16:48:08 +0200
> Sam Ravnborg escreveu:
>
> > Hi Mauro.
> >
> > On Thu, Aug 20, 2020 at 04:06:49PM +0200, Mauro Carvalho Chehab
Hi Mauro.
On Thu, Aug 20, 2020 at 04:06:49PM +0200, Mauro Carvalho Chehab wrote:
> Em Wed, 19 Aug 2020 19:35:58 +0200
> Sam Ravnborg escreveu:
>
> I'm already handling the other comments from your review (I'll send a
> more complete comment about them after finishing)
Hi John.
> > So, IMO, the best is to keep it on staging for a while, until those
> > remaining bugs gets solved.
>
> I'm not sure I see all of these as compelling for pushing it in via
> staging. And I suspect in the process of submitting the patches for
> review folks may find the cause of some
Hi Mauro.
Some feedback in the following.
Good to see DT schma files and not .txt files - but needs a bit more
work.
Sam
On Wed, Aug 19, 2020 at 01:46:17PM +0200, Mauro Carvalho Chehab wrote:
> Add a description of the bindings used by Kirin 960/970 Display
> Serial Interface (DSI) contr
Hi Mauro.
On Wed, Aug 19, 2020 at 01:45:28PM +0200, Mauro Carvalho Chehab wrote:
> This patch series port the out-of-tree driver for Hikey 970 (which
> should also support Hikey 960) from the official 96boards tree:
>
>https://github.com/96boards-hikey/linux/tree/hikey970-v4.9
>
> Based on h
> keyword.
>
> Found with yamllint (which I plan to integrate into the checks).
I have browsed through the patch - and there was only a few things
that jumped at me.
With these points considered:
Acked-by: Sam Ravnborg
I expect only some (few) of my points to actually results in any updates.
st of the issues with:
>
> ./scripts/documentation-file-ref-check --fix
>
> Signed-off-by: Mauro Carvalho Chehab
Patch looks good.
Acked-by: Sam Ravnborg
> ---
>
> PS.: This patch is against today's linux-next.
>
>
> .../devicetree/bindings/display/bridge/sii902
Hi Jaejoong.
> Change return type for tty functions. Patch No.01
> tty: Change return type to void
Adding this patch first will generate a lot of warnings
until all users are updated.
It is usual practice to prepare all users
and then apply the infrastructure changes as the
last patch.
Then peop
On Tue, Apr 18, 2017 at 02:58:06PM -0400, David Miller wrote:
>
> This is in preparation for adding the 64-bit eBPF JIT.
>
> Signed-off-by: David S. Miller
> ---
> arch/sparc/net/Makefile | 2 +-
> arch/sparc/net/bpf_jit.h | 68
> arch/sparc/net/bpf_jit_32.h | 68
Hi Andreas.
Tak!
Sam
On Wed, Apr 27, 2016 at 04:46:10PM +0200, Andreas Larsson wrote:
> Signed-off-by: Andreas Larsson
> ---
> MAINTAINERS |2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 1d5b4be..08ffebd 100644
> --- a/MAIN
On Sun, Feb 24, 2008 at 10:33:12PM -0800, David Brownell wrote:
> On Sunday 24 February 2008, Sam Ravnborg wrote:
>
> > From a quick look this is wrong.
> > smc_drv_probe is assined the .probe member so it is used during
> > hotplug and thus should be __devinit.
> >
On Sun, Feb 24, 2008 at 07:34:11PM -0800, David Brownell wrote:
> Section fixup:
>
> WARNING: drivers/net/built-in.o(.text+0x1a2c): Section mismatch
> in reference from the function smc_drv_probe()
> to the function .init.text:smc_probe()
> The function smc_drv_probe() references
> the
On Fri, Feb 22, 2008 at 11:59:12AM -0800, Stephens, Allan wrote:
> This patch eliminates warnings about a pair of undeclared symbols.
Hi Allan.
Last I looked there where ~90 sparse warnings for tipc.
I assume you are aware and that they are getting fixed.
Sam - who would like to see an a
On Wed, Feb 20, 2008 at 02:27:19PM +0100, Jonas Bonn wrote:
> Sam Ravnborg wrote:
> >On Wed, Feb 20, 2008 at 01:53:36PM +0100, Jonas Bonn wrote:
> >>The PCI_DEVICE_TABLE patch I sent earlier doesn't necessarily make
> >>much sense by itself... here is a set of patch
On Wed, Feb 20, 2008 at 01:53:36PM +0100, Jonas Bonn wrote:
>
> The PCI_DEVICE_TABLE patch I sent earlier doesn't necessarily make
> much sense by itself... here is a set of patches that apply
> this macro, in turn moving a lot of this data into __devinitconst
> which is discardable in certain sit
On Sun, Feb 17, 2008 at 02:25:36PM +0100, Sam Ravnborg wrote:
> On Sat, Feb 16, 2008 at 07:51:13PM -0800, Subbu Seetharaman wrote:
> > Patch 0/16 and 15/16 of this series are getting dropped by the
> > spam filter. I am trying to get them across with changes
> > that will p
On Sat, Feb 16, 2008 at 07:51:13PM -0800, Subbu Seetharaman wrote:
> Patch 0/16 and 15/16 of this series are getting dropped by the
> spam filter. I am trying to get them across with changes
> that will please the spam filter. Sorry about the inconvenience.
> Below is the 0/16 of the series.
>
>
On Mon, Feb 11, 2008 at 04:57:06PM +0100, Jan-Bernd Themann wrote:
> Drivers like eHEA need memory notifiers in order to
> update their internal DMA memory map when memory is added
> to or removed from the system.
Can you please add proper kernel-doc formatted comments
when you export a symbol so
checkcard is only used during init or when hot plugging
ISDN devices. So annotate hisax_cs_setup_card() with __devinit.
checkcard() is used by exported functions so it cannot be
annotated __devinit. Annotate it with __ref so modpost
ignore references to _devinit section.
Signed-off-by: Sam Ravnborg
setup_avm_a1_pcmcia() to the function
.devinit.text:setup_isac()
ISACVer were only used from function annotated __devinit
so add same annotation to ISACVer.
One af the fererencing functions missed __devinit so add it
and kill an additional warning.
Signed-off-by: Sam Ravnborg <[EMAIL PROTECTED]>
Ac
CARD_INIT branch
will only be taken under __devinit context but to be consistent
remove the __devinit annotation of inithfcsx() so we
do not mix non-__devinit and __devinit code.
Signed-off-by: Sam Ravnborg <[EMAIL PROTECTED]>
Acked-by: Karsten Keil <[EMAIL PROTECTED]>
Cc: Jeff Ga
clear_pending_isac_ints()
were all used via a cardmsg fnction - which may be called
ouside __devinit context.
So remove the bogus __devinit annotation of the
above three functions to fix the warnings.
Signed-off-by: Sam Ravnborg <[EMAIL PROTECTED]>
Acked-by: Karsten Keil <[EMAIL PROTECTED]&
> > > > From: Andrew Morton <[EMAIL PROTECTED]>
> > > >
> > > > gcc-3.4.4 on powerpc:
> > > >
> > > > drivers/net/typhoon.c:137: error: version causes a section type conflict
> > > >
> > > > Cc: Jeff Garzik &l
On Mon, Feb 04, 2008 at 09:52:23PM +0530, Kamalesh Babulal wrote:
> Hi Andrew,
>
> The 2.6.24-mm1 kernel build fails at many places with section type
> conflict build error.
What arch?
We have troubles with powerpc as pointed out by Al in another thread.
Sam
--
To unsubscribe from this l
to Jeff once I have tested it with real
> hardware (sunday evening entertainment). Sam, is it ok to add your
> s-o-b to it ?
No - a s-o-b document the path of the patch. And it will not hit
Jeff via me. Although I know I said ths was to way to do it.
But you can add my:
Acked-by: Sam Ravnborg &
On Fri, Feb 01, 2008 at 11:56:27PM +0530, Sudhir Kumar wrote:
> Hi All,
> I found the following kernel build failure for 2.6.24-git10
> on my machine:
>
> CC [M] drivers/scsi/lpfc/lpfc_attr.o
> drivers/net/sis190.c:329: error: sis190_pci_tbl causes a section type
> conflict
> make[2]: *** [driv
Can we please get the following warnings fixed
in mainline soonish.
I get the below list with a x86 64bit allyesconfig build
and I expect anyone to see roughly the same list.
It would be great to say that both net/ and drivers/net/
were warning free in this respect.
If you have questions let me
() to the function .exit.text:rc80211_pid_exit()
The fix was simple - I just did as modpost told me and removed the
wrong __exit annotation of rc80211_simple_exit and rc80211_pid_exit.
Signed-off-by: Sam Ravnborg <[EMAIL PROTECTED]>
Cc: Johannes Berg <[EMAIL PROTECTED]>
Cc: John W. Linv
On Wed, Jan 30, 2008 at 11:47:11PM +0100, Francois Romieu wrote:
> Sam Ravnborg <[EMAIL PROTECTED]> :
> [...]
> > > -static struct pci_device_id sis190_pci_tbl[] __devinitdata = {
> > > +static struct pci_device_id sis190_pci_tbl[] = {
> > > { PCI_DE
On Wed, Jan 30, 2008 at 09:49:59PM +0530, Kamalesh Babulal wrote:
> Hi,
>
> Following are the different build failure with 2.6.24-git7 kernel on the
> powerpc
>
> drivers/net/typhoon.c:181: error: typhoon_card_info causes a section type
> conflict
> make[2]: *** [drivers/net/typhoon.o] Error 1
On Wed, Jan 30, 2008 at 02:31:05PM +0100, Jan Engelhardt wrote:
>
> On Jan 30 2008 12:25, Sam Ravnborg wrote:
> >
> >We have just introduced __initconst, __cpuinitconst, __meminitconst
> >for const data.
> >So the patch is wrong.
>
> Oh joy, more tags. Is i
On Wed, Jan 30, 2008 at 12:57:16PM +0100, Jonas Bonn wrote:
> This fixes build error as gcc complains about a "section type conflict"
> due to the mixing of const and non-const data in same section.
> ---
> drivers/net/sis190.c |4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> d
On Wed, Jan 30, 2008 at 12:23:23PM +0100, Jan Engelhardt wrote:
>
> On Jan 30 2008 11:53, Jonas Bonn wrote:
> >
> >This fixes build error as gcc complains about a "section type conflict"
> >due to the const __devinitdata in sis190_get_mac_addr_from_apc().
>
> >-static struct pci_device_id sis190_
>
> Jeff Garzik (1):
> [netdrvr] sis190: build fix
But you did it wrong...
sis190.c b/drivers/net/sis190.c
> index b570402..2e9e88b 100644
> --- a/drivers/net/sis190.c
> +++ b/drivers/net/sis190.c
> @@ -326,7 +326,7 @@ static const struct {
> { "SiS 191 PCI Gigabit Ethernet adapter" }
On Wed, Jan 30, 2008 at 03:22:51AM -0500, Jeff Garzik wrote:
> Sam Ravnborg wrote:
> >On Tue, Jan 29, 2008 at 11:03:10PM +0100, Francois Romieu wrote:
> >>maximilian attems <[EMAIL PROTECTED]> :
> >>> CC [M] drivers/net/sis190.o
> >>> drivers/
On Wed, Jan 30, 2008 at 09:11:36AM +0530, Kamalesh Babulal wrote:
> Hi,
>
> The 2.6.24-git6 kernel build fails on various x86_64 machines with the build
> failure
>
> drivers/net/sis190.c:329: error: sis190_pci_tbl causes a section type conflict
> make[2]: *** [drivers/net/sis190.o] Error 1
>
>
On Tue, Jan 29, 2008 at 11:03:10PM +0100, Francois Romieu wrote:
> maximilian attems <[EMAIL PROTECTED]> :
> > CC [M] drivers/net/sis190.o
> > drivers/net/sis190.c:329: error: sis190_pci_tbl causes a section type
> > conflict
> > make[5]: *** [drivers/net/sis190.o] Error 1
> >
> > gcc --ve
On Sat, Jan 19, 2008 at 03:18:51PM +0200, Adrian Bunk wrote:
> EXPORT_SYMBOL'ed code mustn't be __*init.
>
> Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
Acked-by: Sam Ravnborg <[EMAIL PROTECTED]>
>
> ---
> --- linux-2.6/drivers/atm/suni.c.old 2008-01
On Sat, Jan 19, 2008 at 03:18:49PM +0200, Adrian Bunk wrote:
> EXPORT_SYMBOL'ed code mustn't be __*init.
>
> Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
Acked-by: Sam Ravnborg <[EMAIL PROTECTED]>
>
> ---
> --- linux-2.6/drivers/atm/idt77105.c.old
On Tue, Dec 25, 2007 at 12:46:56PM -0800, Stephen Hemminger wrote:
> Move veth.h from net/ to linux/ since it is a user api, and
> add it to user header processing Kbuild.
>
> Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]>
>
> --- a/drivers/net/veth.c 2007-12-25 12:30:56.0 -080
On Thu, Dec 20, 2007 at 03:22:58AM -0800, David Miller wrote:
> From: Sam Ravnborg <[EMAIL PROTECTED]>
> Date: Thu, 20 Dec 2007 10:55:10 +0100
>
> > net-2.6.25.git <= patches for current kernel release (only fixes)
> > net-2.6.git <= patches for nex
On Thu, Dec 20, 2007 at 11:20:26AM +0200, David Shwatrz wrote:
> Hello,
> I have a short question regarding the net git tree and patches:
> I want to write and send patches against the most recent and
> bleeding edge kernel networking code.
> I see in:
> http://kernel.org/pub/scm/linux/kernel/git/d
On Mon, Dec 10, 2007 at 08:57:28PM +0100, Andi Kleen wrote:
> On Monday 10 December 2007 20:32, Sam Ravnborg wrote:
> > On Thu, Nov 22, 2007 at 03:43:10AM +0100, Andi Kleen wrote:
> > > When passing an file name > 1k the stack could be overflowed.
> > > Not real
On Thu, Nov 22, 2007 at 03:43:10AM +0100, Andi Kleen wrote:
>
> When passing an file name > 1k the stack could be overflowed.
> Not really a security issue, but still better plugged.
Looks good. A s-o-b line again please.
Although I am not so happy with the ue of gcc extensions.
Sam
>
>
On Thu, Nov 22, 2007 at 03:43:09AM +0100, Andi Kleen wrote:
>
> Fix wrong format strings in modpost exposed by the previous patch.
> Including one missing argument -- some random data was printed instead.
Looks good. Can I get a s-o-b then I will apply it.
Sam
>
> ---
> scripts/mod/mo
On Thu, Nov 22, 2007 at 03:43:08AM +0100, Andi Kleen wrote:
>
> This way gcc can warn for wrong format strings
This loks good. Can I get i s-o-b then I will apply it.
Sam
>
> ---
> scripts/mod/modpost.c |8 +---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
> Index: li
On Thu, Nov 15, 2007 at 10:17:14PM +0300, Denis V. Lunev wrote:
>
> will you mind against this?
> diff --git a/include/net/net_namespace.h b/include/net/net_namespace.h
> index 5dd6d90..d136707 100644
> --- a/include/net/net_namespace.h
> +++ b/include/net/net_namespace.h
> @@ -119,10 +119,14 @@
On Thu, Nov 15, 2007 at 11:19:26AM -0700, Eric W. Biederman wrote:
> Sam Ravnborg <[EMAIL PROTECTED]> writes:
>
> > On Thu, Nov 15, 2007 at 05:42:04PM +0300, Denis V. Lunev wrote:
> >>
> >> nothing is discarded after module load. Though, I can be wrong. Could
On Thu, Nov 15, 2007 at 05:42:04PM +0300, Denis V. Lunev wrote:
> Eric W. Biederman wrote:
> > "Denis V. Lunev" <[EMAIL PROTECTED]> writes:
> >
> >> This patch reverts Eric's commit 2b008b0a8e96b726c603c5e1a5a7a509b5f61e35
> >>
> >> It diets .text & .data section of the kernel if CONFIG_NET_NS is
On Thu, Nov 15, 2007 at 04:05:30AM -0800, David Miller wrote:
> From: Urs Thuermann <[EMAIL PROTECTED]>
> Date: 15 Nov 2007 12:51:34 +0100
>
> > I prefer our code because it is shorter (fits into one line) and can
> > be used anywhere where an expression is allowed compared to only where
> > a sta
> > > +
> > > +struct timer_list stattimer; /* timer for statistics update */
> > > +struct s_stats stats; /* packet statistics */
> > > +struct s_pstats pstats; /* receive list statistics */
> >
> > More global variables without prefix.
>
> These variables are not exported with EXPOR
On Wed, Nov 14, 2007 at 06:56:06AM +0100, Sam Ravnborg wrote:
> >
> > > If so, MANITAINERS claims that it is subscribers-only. That would cause
> > > some bug reporters to give up and go away.
> >
> > Find some other mailing list; I'm not hosting *nor*
>
> > If so, MANITAINERS claims that it is subscribers-only. That would cause
> > some bug reporters to give up and go away.
>
> Find some other mailing list; I'm not hosting *nor* am I willing to run a
> non-subscribers only mailing list. Period. Not negotiable, so don't even
> try to change
>
> As a general rule, I think it better to use includes
> than use naked forward declarations.
Quite the opposite - at least in the kernel source.
The general rule is that a .h file shall include the
.h files which contain declarations used by said .h files.
But naked declarations as above is pr
Hi Maks.
On Wed, Sep 19, 2007 at 07:18:41PM +0200, maximilian attems wrote:
> On Wed, Sep 19, 2007 at 10:12:38AM -0700, H. Peter Anvin wrote:
> >
> > Could you give a concrete example?
> >
> > -hpa
>
> [EMAIL PROTECTED]:~/src/klibc$ touch usr/utils/mount_main.c
> [EMAIL PROTECTED]:~/src/kli
On Tue, Sep 18, 2007 at 01:08:10PM -0700, David Miller wrote:
> From: "H. Peter Anvin" <[EMAIL PROTECTED]>
> Date: Tue, 18 Sep 2007 12:27:04 -0700
>
> > Well, what I was referring to here, of course, was the initramfs
> > integrated in the kernel image, so it all comes out of the kernel build
> >
Hi Jeff.
You wrote:
> The hooks ->self_test_count() and ->get_stats_count() are now unused
> in the main tree.
So I'm suprised to see more lines added than deleted:
> 35 files changed, 346 insertions(+), 246 deletions(-)
Puzzled - may need a bit more coffee (morning here)..
Sam
-
To un
On Sun, Sep 02, 2007 at 03:36:08AM +0530, Satyam Sharma wrote:
>
>
> On Fri, 31 Aug 2007, Andrew Morton wrote:
> >
> > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.23-rc4/2.6.23-rc4-mm1/
>
> Got these on an i386 build with CONFIG_MODVERSIONS=y ...
>
> WARNING: "div64_64" [
On Sat, Sep 01, 2007 at 06:44:06AM -0400, Robert P. J. Day wrote:
>
> > > while (1) {
> > > printf("%*s%s ", indent - 1, "", menu->prompt->text);
> > > + switch (sym->maturity) {
> > > + case M_EXPERIMENTAL:
> > > + printf("(EXPERIMENTAL) ");
> > > +
On Tue, Aug 28, 2007 at 07:59:04PM +0200, Adrian Bunk wrote:
> On Tue, Aug 28, 2007 at 07:06:04PM +0200, Sam Ravnborg wrote:
> > >
> > > It fixes a bug exposed by a -mm only patch, not by the net tree
> > > (and 2.6.23-rc3-mm1 doesn't contain the net tree at
>
> It fixes a bug exposed by a -mm only patch, not by the net tree
> (and 2.6.23-rc3-mm1 doesn't contain the net tree at all).
>
> > But I'd like a better description, please. Which "non-gcc parser" are we
> > talking about here? Something under ./scripts/. Well, please identify it,
> > and d
On Tue, Aug 28, 2007 at 12:37:04AM -0700, Andrew Morton wrote:
> On Mon, 27 Aug 2007 23:27:43 +0200 Adrian Bunk <[EMAIL PROTECTED]> wrote:
>
> > On Wed, Aug 22, 2007 at 03:33:27PM +0200, Gabriel C wrote:
> > >...
> > > WARNING: "div64_64" [net/netfilter/xt_connbytes.ko] has no CRC!
> > >...
> >
>
> >
> > ...
> > endif # NETDEVICES
> >
> > config NETPOLL
> > depends on NETDEVICES
> > def_bool NETCONSOLE
> >
> > config NETPOLL_TRAP
> > bool "Netpoll traffic trapping"
> > default n
> > depends on NETPOLL
> >
> > config NET_POLL_CONTROLLER
> >
On Wed, Jul 25, 2007 at 06:08:03PM +0800, chengong wrote:
> On Wed, 2007-07-25 at 09:27 +0200, Sam Ravnborg wrote:
> > On Wed, Jul 25, 2007 at 02:14:12AM -0500, Kumar Gala wrote:
> > > I'm seeing the following warning:
> > >
> > > WARNING: vmlinu
> >
> >For the popular architectures (i386,x86_64) we discard .exit.text at
> >runtime so here we do not see the error from ld (sadly).
>
> Fair point, wondering what we do with .exit on PPC, another thing for
> the list :)
from:
arch/ppc/kernel/vmlinux.lds.S:
/* .exit.text is discarded at ru
On Wed, Jul 25, 2007 at 02:14:12AM -0500, Kumar Gala wrote:
> I'm seeing the following warning:
>
> WARNING: vmlinux.o(.init.text+0x1acdc): Section mismatch: reference to
> .exit.text:gfar_mdio_exit (between 'gfar_init' and 'gfar_mdio_init')
>
> I don't understand why its not ok to access .exit.t
ldi <[EMAIL PROTECTED]>
> Cc: David Miller <[EMAIL PROTECTED]>
> Cc: Sam Ravnborg <[EMAIL PROTECTED]>
> Cc: Andrew Morton <[EMAIL PROTECTED]>
> ---
> --- a/net/netfilter/Kconfig 2007-07-09 06:38:52.0 +0300
> +++ b/net/netfilter/Kconfig
>
> For example, missing from the call graph is
>
> get_page_from_freelist ->
> buffered_rmqueue -> [ missing - inlined ]
> prep_new_page ->[ missing - inlined ]
> prep_zero_page -> [ missing - inlined ]
> clear_highp
On Mon, Jul 16, 2007 at 03:56:26PM +0400, Evgeniy Polyakov wrote:
> Hi Samuel.
>
> On Mon, Jul 16, 2007 at 02:17:15PM +0300, Samuel Ortiz ([EMAIL PROTECTED])
> wrote:
> > This is due to the irda_init fix recently added, where we call __exit
> > routines from an __init one. It is a build failure t
eported by: Massimo Maiurana <[EMAIL PROTECTED]>
Signed-off-by: Sam Ravnborg <[EMAIL PROTECTED]>
Cc: Massimo Maiurana <[EMAIL PROTECTED]>
---
diff --git a/drivers/net/usb/Kconfig b/drivers/net/usb/Kconfig
index 3de564b..8dc09a3 100644
--- a/drivers/net/usb/Kconfig
+++ b/drivers/net/
s where we discard __exit section
for drivers that are built-in.
Signed-off-by: Sam Ravnborg <[EMAIL PROTECTED]>
---
Comple tested only.
Note: This warning does not appear with modpost in upstream kernel
but I would like to submit patches for the obvious bugs ASAP
Sam
diff --g
On Thu, May 03, 2007 at 10:25:48PM +0200, Øyvind Vågen Jægtnes wrote:
> Hi,
Hi Øyvind.
Forwarding your mail to netdev where the networking people are
hanging out. Maybe they can help you.
Sam
>
> We have a one gigabit internet connection that is normally
> routed by a hardware juniper r
Hi Robert.
>I have a makefielt to make several driver modules:
> obj-$(CONFIG_FUSION_SPI) += mptbase.o mptscsih.o
> mptspi.o
> obj-$(CONFIG_FUSION_FC) += mptbase.o mptscsih.o
> mptfc.o
> obj-m += mptbase.o mptscsih.o mptsas.o
> obj-$(CONFIG_FUSION_LAN
On Fri, Aug 11, 2006 at 12:03:37PM -0500, Linas Vepstas wrote:
>
> The following series of patches implement some fixes and performance
> improvements for the Spedernet ethernet device driver. The high point
> of the patch series is some code to implement a low-watermark interrupt
> on the transmi
On Wed, Aug 09, 2006 at 10:40:20AM +0200, Jan-Bernd Themann wrote:
> Signed-off-by: Jan-Bernd Themann <[EMAIL PROTECTED]>
>
>
> drivers/net/ehea/Makefile |7 +++
> 1 file changed, 7 insertions(+)
>
>
>
> --- linux-2.6.18-rc4-orig/drivers/net/ehea/Makefile 1969-12-31
> 16:00:00.
On Sun, Jul 30, 2006 at 03:59:56PM -0700, David Miller wrote:
> From: Sam Ravnborg <[EMAIL PROTECTED]>
> Date: Mon, 31 Jul 2006 00:45:43 +0200
>
> > >From a pure eye-candy perspective it would be nice to use same format
> > all over.
> > &
On Sun, Jul 30, 2006 at 03:28:46PM -0700, David Miller wrote:
> From: "Ilpo J?rvinen" <[EMAIL PROTECTED]>
> Date: Sun, 30 Jul 2006 14:01:09 +0300 (EEST)
>
> >[TCP] FRTO: summary here
>
> This looks perfectly fine.
Looking 100 commits back or so it is obvious we have two distinct
notations:
On Tue, Jul 04, 2006 at 11:27:27AM +0200, Arjan van de Ven wrote:
> On Tue, 2006-07-04 at 02:25 -0700, Andrew Morton wrote:
> > On Tue, 04 Jul 2006 11:07:59 +0200
> > Arjan van de Ven <[EMAIL PROTECTED]> wrote:
> >
> > > patch below removes the use of UTS_RELEASE from the tiacx driver; there
> > >
> Probably over enthusiastic gcc inlining. gcc 4 will inline functions
> that are not declared as inline. That is not so bad, except that some
> versions of gcc will ignore a mismatch in function attributes and
> inline a __init function into normal text, generating additional
> section mismatc
On Sun, Jun 11, 2006 at 04:37:31PM +0200, Mikael Pettersson wrote:
> On Sat, 10 Jun 2006 22:38:00 +0200, Sam Ravnborg wrote:
> >> --- linux-2617-rc6.orig/drivers/net/ne.c
> >> +++ linux-2617-rc6/drivers/net/ne.c
> >> @@ -829,7 +829,7 @@ that the ne2k probe is the
> >
> > Not sure how serious this is; the driver seems to work fine later on.
>
> Doesn't look serious. init_module() is not __init, but it calls
> some __init functions and touches some __initdata.
This is the typical case with inconsistent tagging.
> BTW, I would be happy to see some consist
On Mon, May 01, 2006 at 02:08:34PM -0700, Stephen Hemminger wrote:
> Add basic sysfs support for vlan device. It creates an entry in the
> vlan pseudo-device to display tag.
> /sys/class/net/eth0.5/vlan_id
>
> It would be nice at some future to have something like:
> /sys/class/net/e
137: error: version causes a section type conflict
> drivers/net/natsemi.c:241: error: version causes a section type conflict
>
> Signed-off-by: Randy Dunlap <[EMAIL PROTECTED]>
Acked-by: Sam Ravnborg <[EMAIL PROTECTED]>
> ---
> drivers/net/bnx2.c |2 +-
On Sat, Apr 08, 2006 at 03:14:04AM -0700, David S. Miller wrote:
> Perhaps fs_initcall() would work better. Or if that causes
> problems we could create a net_initcall() that sits between
> fs_initcall() and device_initcall().
fs_initcall() seems to be used mainly for "init after subsystem" stu
On Mon, Apr 03, 2006 at 10:27:32AM -0700, Randy.Dunlap wrote:
> On Sun, 2 Apr 2006 23:12:03 +0200 Sam Ravnborg wrote:
>
> > On Mon, Mar 27, 2006 at 02:32:14PM -0800, Randy.Dunlap wrote:
> > > >
> > > > Sam, I am now seeing this error (not a WARNING
On Mon, Mar 27, 2006 at 02:32:14PM -0800, Randy.Dunlap wrote:
> >
> > Sam, I am now seeing this error (not a WARNING like the previous ones were):
> >
> > drivers/net/typhoon.c:137: error: version causes a section type conflict
> >
> > but I don't see a real problem in the driver source file.
>
On Mon, Mar 27, 2006 at 02:32:14PM -0800, Randy.Dunlap wrote:
> > >
> > > Nope, only with HOTPLUG enabled. I can try without also (but
> > > disabling it is a pain :).
> >
> > ugh, FW_LOADER is the beast (not CONFIG_HOTPLUG itself).
> >
> > Sam, I am now seeing this error (not a WARNING like th
On Mon, Mar 27, 2006 at 12:26:12PM -0800, Randy.Dunlap wrote:
> From: Randy Dunlap <[EMAIL PROTECTED]>
>
> Fix section mismatches in acenic driver:
> WARNING: drivers/net/acenic.o - Section mismatch: reference to
> .init.data:tigon2FwText from .text between 'acenic_probe_one' (at offset
> 0x2409
On Sun, Mar 05, 2006 at 12:09:33AM -0800, Andrew Morton wrote:
> > +
> > +static inline u8 read_reg8(struct cb_device *device, unsigned int offset)
> > +{
> > + return readb(device->reg_base + offset);
> > +}
>
> These are fairly generic-sounding names. In fact the as-yet-unmerged tiacx
> wirel
t.
Fix is to declare init_module() __init too.
Signed-off-by: Sam Ravnborg <[EMAIL PROTECTED]>
---
Compile tested with allmodconfig on amd64.
diff --git a/drivers/net/de620.c b/drivers/net/de620.c
index 0069f5f..22fc5b8 100644
--- a/drivers/net/de620.c
+++ b/drivers/net/de620.c
@@ -1012,7 +1
Declare init_module() __init too to fix warning.
Signed-off-by: Sam Ravnborg <[EMAIL PROTECTED]>
---
Compile tested with allmodconfig on amd64.
diff --git a/drivers/net/wan/sbni.c b/drivers/net/wan/sbni.c
index db2c798..175ba13 100644
--- a/drivers/net/wan/sbni.c
+++ b/drivers/net/wan
inet_bind_bucket_create was exported twice.
Keep the export in the file where inet_bind_bucket_create is defined.
Signed-off-by: Sam Ravnborg <[EMAIL PROTECTED]>
---
I've noticed double export while playing with modpost.
I did not see any ill-effect of it - but modpost may so
1 - 100 of 115 matches
Mail list logo
