Re: [PATCH net 3/3] net: sched: ife: check on metadata length

ned-off-by: Alexander Aring <ar...@mojatatu.com> Reviewed-by: Yotam Gigi <yotam...@gmail.com> > --- > net/ife/ife.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/net/ife/ife.c b/net/ife/ife.c > index 8632d2685efb..7c100034fbee 100644 > --- a/net/if

Re: [PATCH net 2/3] net: sched: ife: handle malformed tlv length

tical, but it looks a bit odd to me: the function ife_decode returns "metalen" - maybe it is better to change it too to return ifehdr_end? If not, the caller has to calculate it himself for no particular reason. Having both metalen and ifehdr_end is redundant, so we should stick to only one

Re: [PATCH net 1/3] net: sched: ife: signal not finding metaid

jatatu.com> Reviewed-by: Yotam Gigi <yotam...@gmail.com> > --- > net/sched/act_ife.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/sched/act_ife.c b/net/sched/act_ife.c > index a5994cf0512b..49b8ab551fbe 100644 > --- a/net/sched/act_i

Re: [PATCH iproute2 1/1] tc: use get_u32() in psample action to match types

On Tue, Mar 13, 2018 at 11:16 PM, Roman Mashak <m...@mojatatu.com> wrote: Makes sense :) Acked-by: Yotam Gigi <yotam...@gmail.com> > Signed-off-by: Roman Mashak <m...@mojatatu.com> > --- > tc/m_sample.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 de

[PATCH iproute2 net-next] ip: mroute: Print offload indication

ot;ip route show" command. Example output: $ ip mroute (0.0.0.0, 239.255.0.1) Iif: sw1p7 Oifs: t_br0 State: resolved offload (192.168.1.1, 239.255.0.1) Iif: sw1p7 Oifs: sw1p4 State: resolved offload Signed-off-by: Yotam Gigi <yot...@mellanox.com> --- ip/ipmroute.c | 2 ++ 1 file

Re: [patch net-next 1/6] net: bridge: Use the MDB_RTR_TYPE_TEMP on bridge device too

On 10/08/2017 12:42 PM, Nikolay Aleksandrov wrote: > On 08/10/17 12:39, Nikolay Aleksandrov wrote: >> On 08/10/17 08:23, Yotam Gigi wrote: >>> On 10/05/2017 03:09 PM, Nikolay Aleksandrov wrote: >>>> On 05/10/17 13:36, Jiri Pirko wrote: >>>>> From: Yotam

Re: [patch net-next 1/6] net: bridge: Use the MDB_RTR_TYPE_TEMP on bridge device too

On 10/05/2017 03:09 PM, Nikolay Aleksandrov wrote: > On 05/10/17 13:36, Jiri Pirko wrote: >> From: Yotam Gigi <yot...@mellanox.com> >> >> Every bridge port is in one of four mcast router port states: >> - MDB_RTR_TYPE_PERM - the port is set by the user to be

Re: [PATCH 1/2 net-next] mlxsw: spectrum: Fix check for IS_ERR() instead of NULL

On 10/03/2017 01:53 PM, Dan Carpenter wrote: > mlxsw_afa_block_create() doesn't return error pointers, it returns NULL > on error. > > Fixes: 0e14cacb ("mlxsw: spectrum: Add the multicast routing hardware > logic") > Signed-off-by: Dan Carpenter <dan.carpen.

Re: [PATCH 2/2 net-next] mlxsw: spectrum: Add missing error code on allocation failure

On 10/03/2017 01:53 PM, Dan Carpenter wrote: > We accidentally return success if the kmalloc_array() call fails. > > Fixes: 0e14cacb ("mlxsw: spectrum: Add the multicast routing hardware > logic") > Signed-off-by: Dan Carpenter <dan.carpen...@oracle.com

Re: [PATCH][next] mlxsw: spectrum: fix uninitialized value in err

by CoverityScan CID#1457207 ("Unitialized scalar value") Thanks for that! Reviewed-by: Yotam Gigi <yot...@mellanox.com> > > Fixes: c011ec1bbfd6 ("mlxsw: spectrum: Add the multicast routing offloading > logic") > Signed-off-by: Colin Ian King <colin.k...@cano

Re: [patch net-next 3/7] ipv4: ipmr: Don't forward packets already forwarded by hardware

On 09/28/2017 08:56 PM, Florian Fainelli wrote: > On 09/28/2017 10:34 AM, Jiri Pirko wrote: >> From: Yotam Gigi <yot...@mellanox.com> >> >> Change the ipmr module to not forward packets if: >> - The packet is marked with the offload_mr_fwd_mark, and >> - Bo

Re: [patch net-next 2/7] ipv4: ipmr: Add the parent ID field to VIF struct

On 09/29/2017 12:50 PM, Nikolay Aleksandrov wrote: > On 28/09/17 20:34, Jiri Pirko wrote: >> From: Yotam Gigi <yot...@mellanox.com> >> >> In order to allow the ipmr module to do partial multicast forwarding >> according to the device parent ID, add the device par

Re: [patch net-next 2/7] ipv4: ipmr: Add the parent ID field to VIF struct

On 09/29/2017 12:45 PM, Nikolay Aleksandrov wrote: > On 29/09/17 12:29, Nikolay Aleksandrov wrote: >> On 28/09/17 20:34, Jiri Pirko wrote: >>> From: Yotam Gigi <yot...@mellanox.com> >>> >>> In order to allow the ipmr module to do partial multicast forwar

Re: [patch net-next v2 06/12] net: mroute: Check if rule is a default rule

On 09/25/2017 01:02 PM, Nikolay Aleksandrov wrote: > On 25/09/17 12:45, Jiri Pirko wrote: >> Mon, Sep 25, 2017 at 03:28:21AM CEST, linyunsh...@huawei.com wrote: >>> Hi, Jiri >>> >>> On 2017/9/25 1:22, Jiri Pirko wrote: >>>> From: Yotam Gigi <

Re: [patch net-next v2 05/12] net: ipmr: Add MFC offload indication

On 09/25/2017 12:36 PM, Nikolay Aleksandrov wrote: > On 24/09/17 20:22, Jiri Pirko wrote: >> From: Yotam Gigi <yot...@mellanox.com> >> >> Allow drivers, registered to the fib notification chain indicate whether a >> multicast MFC route is offloaded or

Re: [patch net-next v2 07/12] mlxsw: spectrum: Add the multicast routing offloading logic

On 09/25/2017 01:40 PM, Nikolay Aleksandrov wrote: > On 24/09/17 20:22, Jiri Pirko wrote: >> From: Yotam Gigi <yot...@mellanox.com> >> >> Add the multicast router offloading logic, which is in charge of handling >> the VIF and MFC notifications and transla

Re: [patch net-next v2 07/12] mlxsw: spectrum: Add the multicast routing offloading logic

On 09/25/2017 04:48 AM, Yunsheng Lin wrote: > Hi, Jiri > > On 2017/9/25 1:22, Jiri Pirko wrote: >> From: Yotam Gigi <yot...@mellanox.com> >> >> Add the multicast router offloading logic, which is in charge of handling >> the VIF and MFC notifications and t

Re: [patch net-next v2 06/12] net: mroute: Check if rule is a default rule

On 09/25/2017 04:28 AM, Yunsheng Lin wrote: > Hi, Jiri > > On 2017/9/25 1:22, Jiri Pirko wrote: >> From: Yotam Gigi <yot...@mellanox.com> >> >> When the ipmr starts, it adds one default FIB rule that matches all packets >> and sends them to the DEFAULT (mu

Re: [patch net-next v2 03/12] ipmr: Add FIB notification access functions

On 09/25/2017 04:19 AM, Yunsheng Lin wrote: > Hi, Jiri > > On 2017/9/25 1:22, Jiri Pirko wrote: >> From: Yotam Gigi <yot...@mellanox.com> >> >> Make the ipmr module register as a FIB notifier. To do that, implement both >> the ipmr_seq_read and ipmr_dump

Re: [patch net-next 07/12] mlxsw: spectrum: Add the multicast routing offloading logic

On 09/22/2017 04:21 PM, Andrew Lunn wrote: > On Fri, Sep 22, 2017 at 11:36:59AM +0300, Yotam Gigi wrote: >> On 09/21/2017 06:26 PM, Andrew Lunn wrote: >>>> +static void mlxsw_sp_mr_route_stats_update(struct mlxsw_sp *mlxsw_sp, >>>> +

Re: [patch net-next 07/12] mlxsw: spectrum: Add the multicast routing offloading logic

On 09/21/2017 06:26 PM, Andrew Lunn wrote: >> +static void mlxsw_sp_mr_route_stats_update(struct mlxsw_sp *mlxsw_sp, >> + struct mlxsw_sp_mr_route *mr_route) >> +{ >> +struct mlxsw_sp_mr *mr = mlxsw_sp->mr; >> +u64 packets, bytes; >> + >> +if

Re: [patch net-next 03/12] ipmr: Add FIB notification access functions

On 09/21/2017 02:19 PM, Nikolay Aleksandrov wrote: > On 21/09/17 09:43, Jiri Pirko wrote: >> From: Yotam Gigi <yot...@mellanox.com> >> >> Make the ipmr module register as a FIB notifier. To do that, implement both >> the ipmr_seq_read and ipmr_dump ops. &

Re: [PATCH net] net/sched: cls_matchall: fix crash when used with classful qdisc

gt; +++ b/net/sched/cls_matchall.c > @@ -32,6 +32,7 @@ static int mall_classify(struct sk_buff *skb, const struct > tcf_proto *tp, > if (tc_skip_sw(head->flags)) > return -1; > > + *res = head->res; > return tcf_exts_exec(skb, >exts, res); > } > Acked-by: Yotam Gigi <yot...@mellanox.com>

Re: IGMP snooping, switchdev and local multicast receiver on br interface

On 07/14/2017 06:30 PM, Vivien Didelot wrote: > Hi All, > > Andrew Lunn writes: > >> I've been testing IGMP snooping support with DSA, putting MDB entries >> into the switch so that traffic only goes out ports where there has >> been an interest indicated via IGMP. It mostly

Re: [PATCH net-next] net/mlxfw: fix a NULL dereference

g magic\n"); > + err = -EINVAL; > goto err_out; > } > Acked-by: Yotam Gigi <yot...@mellanox.com>

ipmr: MFC routes when VIF deleted

I have been looking into some weird behavior, and I am not sure whether it is a bug or a feature. When a VIF with index v gets deleted, the MFC routes does not get updated, which means that there can be routes pointing to that VIF. On datapath, when packet hits that route, the VIF validity will

Re: [PATCH net v3] net: ipmr: Fix some mroute forwarding issues in vrf's

_lock(_lock); > - ip_mr_forward(net, mrt, skb, cache, local); > + ip_mr_forward(net, mrt, dev, skb, cache, local); > read_unlock(_lock); > > if (local) > @@ -2238,7 +2236,7 @@ int ipmr_get_route(struct net *net, struct sk_buff *skb, > iph->saddr = saddr; > iph->daddr = daddr; > iph->version = 0; > - err = ipmr_cache_unresolved(mrt, vif, skb2); > + err = ipmr_cache_unresolved(mrt, vif, skb2, dev); > read_unlock(_lock); > rcu_read_unlock(); > return err; Thanks Donald! Reviewed-by: Yotam Gigi <yot...@mellanox.com>

Re: [PATCH][net-next] net/mlxfw: remove redundant goto on error check

static int mlxfw_mfa2_file_cb_offset_xz(const struct > mlxfw_mfa2_file *mfa2_file, > dec_buf.out_pos = 0; > dec_buf.out_size = size; > err = mlxfw_mfa2_xz_dec_run(xz_dec, _buf, ); > - if (err) > - goto out; > out: > xz_dec_end(xz_dec); > return err; Thanks! Acked-by: Yotam Gigi <yot...@mellanox.com>

[PATCH net-next] mlxsw: spectrum: Implement the ethtool flash_device callback

process and take it again before leaving the callback. This way, the rtnl is not held during the process. To make sure the device does not get deleted during the flash process, take a reference to it before releasing the rtnl lock. Signed-off-by: Yotam Gigi <yot...@mellanox.com> Reviewed-b

Re: [PATCH linux-firmware] Mellanox: Add firmware for mlxsw_spectrum

On 05/30/2017 10:22 PM, Kyle McMartin wrote: > On Mon, May 29, 2017 at 01:42:28PM +0300, Yotam Gigi wrote: >> Add first firmware for the Mellanox Spectrum switch, as a followup to the >> recently added commit: >> 6b7421992b8d ("mlxsw: spectrum: Validate

Re: [PATCH net-next] net/mlxfw: select CONFIG_XZ_DEC

ers/net/ethernet/mellanox/mlxfw/Kconfig > @@ -4,3 +4,4 @@ > > config MLXFW > tristate "mlxfw" if COMPILE_TEST > + select XZ_DEC Thanks! Acked-by: Yotam Gigi <yot...@mellanox.com>

Re: [patch net-next 0/9] mlxsw: Support firmware flash

On 05/29/2017 03:17 AM, Jakub Kicinski wrote: > On Sun, 28 May 2017 10:26:49 +0300, Yotam Gigi wrote: >> On 05/23/2017 06:38 PM, David Miller wrote: >>> From: Yotam Gigi <yot...@mellanox.com> >>> Date: Tue, 23 May 2017 18:14:15 +0300 >>> >>

Re: [patch net-next 0/9] mlxsw: Support firmware flash

On 05/23/2017 06:38 PM, David Miller wrote: > From: Yotam Gigi <yot...@mellanox.com> > Date: Tue, 23 May 2017 18:14:15 +0300 > >> Sorry, I am not sure I understand. You think that drivers should not >> implement >> ethtool's flash_device callback an

Re: [patch net-next 0/9] mlxsw: Support firmware flash

On 05/23/2017 06:04 PM, Mintz, Yuval wrote: Patches 6-8 add the "ethtool -f" and the boot-time firmware upgrade on >> the mlxsw spectrum driver. >>> When we tried using `ethtool -E' for qed we got burned for trying to use >> the magic >>> value [1]. When we suggested extending it to

Re: [patch net-next 0/9] mlxsw: Support firmware flash

r code can only be used to transfer firmware to the device, and cannot be used to configure the device. > > [1] http://marc.info/?l=linux-netdev=146093513926921=4 > [2] http://marc.info/?l=linux-netdev=146514461214421=2 > >> Patch 9 adds a fix needed for new firmware vers

Re: [PATCH net] rtnetlink: Fix the IFLA_PHYS_PORT_NAME TLV to include terminating NULL

On 05/09/2017 03:31 PM, Tobias Klauser wrote: > On 2017-05-09 at 14:12:02 +0200, Yotam Gigi <yot...@mellanox.com> wrote: >> The IFLA_PHYS_PORT_NAME rtnetlink TLV length does not include the >> terminating NULL character, which is different from other string typed >

[PATCH net] rtnetlink: Fix the IFLA_PHYS_PORT_NAME TLV to include terminating NULL

that implement ndo_get_phys_port_name. Make the fill_phys_port_name function include the terminating NULL in the TLV size by using the nla_put_string helper function. Fixes: db24a9044ee1 ("net: add support for phys_port_name") Signed-off-by: Yotam Gigi <yot...@mellanox.com> Cc

[PATCH net] bridge: Fix error path in nbp_vlan_init

Fix error path order in nbp_vlan_init, so if switchdev_port_attr_set call failes, the vlan_hash wouldn't be destroyed before inited. Fixes: efa5356b0d97 ("bridge: per vlan dst_metadata netlink support") CC: Roopa Prabhu <ro...@cumulusnetworks.com> Signed-off-by: Yotam Gigi <

[PATCH net-next/iproute v2 1/5] tc: bash-completion: Add the _from variant to _tc_one* funcs

a" existed in the command line in args 0. Add the _from variant to those functions, which allows having the command line option once from a specified index. In the previous example, calling _tc_once_attr with 4 and "a f g" will suggest "a f g". Signed-off-by: Yotam Gigi

[PATCH net-next/iproute v2 5/5] tc: bash-completion: Add support for matchall

Add support for the matchall classifier and its parameters. Signed-off-by: Yotam Gigi <yot...@mellanox.com> --- bash-completion/tc | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/bash-completion/tc b/bash-completion/tc index e4c6804..80d1297 100644 --- a/bash-comp

[PATCH net-next/iproute v2 2/5] tc: bash-completion: Prepare action autocomplete to support several actions

d not from the beginning of the command line. Signed-off-by: Yotam Gigi <yot...@mellanox.com> --- bash-completion/tc | 23 --- 1 file changed, 12 insertions(+), 11 deletions(-) diff --git a/bash-completion/tc b/bash-completion/tc index 04f969e..c854dc0 100644 --- a/bash-com

[PATCH net-next/iproute v2 4/5] tc: bash-completion: Add support for filter actions

for this kind of completion by adding the _tc_filter_action_options routine and invoking it from inside _tc_filter_options. Signed-off-by: Yotam Gigi <yot...@mellanox.com> --- bash-completion/tc | 38 +++--- 1 file changed, 35 insertions(+), 3 deletions(-)

[PATCH net-next/iproute v2 3/5] tc: bash-completion: Make the *_KIND variables global

The QDISC_KIND, FILTER_KIND, ACTION_KIND variables may be used by other routines, thus make them global variables. Signed-off-by: Yotam Gigi <yot...@mellanox.com> --- bash-completion/tc | 21 ++--- 1 file changed, 10 insertions(+), 11 deletions(-) diff --git a/bash-complet

[PATCH net-next/iproute v2 0/5] tc: bash-completion: Add features

[...] \ action sample group 10 rate 10 action mirred actiondev egressindex ingress mirrorredirect Finally, the last patch adds support in matchall autocompletion. v1->v2: - Rebased on top of net-next tree Yotam Gigi (5): tc: bash-completion: Add the _f

RE: [PATCH net-next/iproute 2/5] tc: bash-completion: Prepare action autocomplete to support several actions

>-Original Message- >From: Stephen Hemminger [mailto:step...@networkplumber.org] >Sent: Tuesday, February 07, 2017 12:11 AM >To: Yotam Gigi <yot...@mellanox.com> >Cc: netdev@vger.kernel.org; Elad Raz <el...@mellanox.com>; Ido Schimmel ><ido...@mellanox.co

RE: [PATCH] [net-next] mlxsw: add psample dependency for spectrum

enforce usable configurations. > >Fixes: 98d0f7b9acda ("mlxsw: spectrum: Add packet sample offloading support") >Signed-off-by: Arnd Bergmann <a...@arndb.de> Acked-by: Yotam Gigi <yot...@mellanox.com> >--- > drivers/net/ethernet/mellanox/mlxsw/Kconfig | 1 + >

[PATCH net-next/iproute 3/5] tc: bash-completion: Make the *_KIND variables global

The QDISC_KIND, FILTER_KIND, ACTION_KIND variables may be used by other routines, thus make them global variables. Signed-off-by: Yotam Gigi <yot...@mellanox.com> --- bash-completion/tc | 21 ++--- 1 file changed, 10 insertions(+), 11 deletions(-) diff --git a/bash-complet

[PATCH net-next/iproute 5/5] tc: bash-completion: Add support for matchall

Add support for the matchall classifier and its parameters. Signed-off-by: Yotam Gigi <yot...@mellanox.com> --- bash-completion/tc | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/bash-completion/tc b/bash-completion/tc index e4c6804..80d1297 100644 --- a/bash-comp

[PATCH net-next/iproute 4/5] tc: bash-completion: Add support for filter actions

for this kind of completion by adding the _tc_filter_action_options routine and invoking it from inside _tc_filter_options. Signed-off-by: Yotam Gigi <yot...@mellanox.com> --- bash-completion/tc | 38 +++--- 1 file changed, 35 insertions(+), 3 deletions(-)

[PATCH net-next/iproute 1/5] tc: bash-completion: Add the _from variant to _tc_one* funcs

a" existed in the command line in args 0. Add the _from variant to those functions, which allows having the command line option once from a specified index. In the previous example, calling _tc_once_attr with 4 and "a f g" will suggest "a f g". Signed-off-by: Yotam Gigi

[PATCH net-next/iproute 2/5] tc: bash-completion: Prepare action autocomplete to support several actions

d not from the beginning of the command line. Signed-off-by: Yotam Gigi <yot...@mellanox.com> --- bash-completion/tc | 23 --- 1 file changed, 12 insertions(+), 11 deletions(-) diff --git a/bash-completion/tc b/bash-completion/tc index 04f969e..c854dc0 100644 --- a/bash-com

[PATCH net-next/iproute 0/5] tc: bash-completion: Add features

[...] \ action sample group 10 rate 10 action mirred actiondev egressindex ingress mirrorredirect Finally, the last patch adds support in matchall autocompletion. Yotam Gigi (5): tc: bash-completion: Add the _from variant to _tc_one* funcs tc: bash-completion

RE: [PATCH iproute2/net-next 1/3] tc: Add support for the sample tc action

>-Original Message- >From: Florian Fainelli [mailto:f.faine...@gmail.com] >Sent: Sunday, February 05, 2017 10:55 PM >To: Yotam Gigi <yot...@mellanox.com>; step...@networkplumber.org; >netdev@vger.kernel.org; Jiri Pirko <j...@mellanox.com>; Elad Raz ><

RE: [PATCH iproute2/net-next 1/3] tc: Add support for the sample tc action

>-Original Message- >From: Florian Fainelli [mailto:f.faine...@gmail.com] >Sent: Sunday, February 05, 2017 8:37 PM >To: Yotam Gigi <yot...@mellanox.com>; step...@networkplumber.org; >netdev@vger.kernel.org; Jiri Pirko <j...@mellanox.com>; Elad Raz ><el...@m

[PATCH iproute2/net-next 0/3] Add the tc-sample action

This patchset adds the tc-sample action support and the corresponding man page. More information about the action and its usage can be found in the commit message. Yotam Gigi (3): tc: Add support for the sample tc action tc: man: Add man entry for the tc-sample action tc: man: matchall

[PATCH iproute2/net-next 3/3] tc: man: matchall: Update examples to include sample

Add an example of packet sampling to the tc-matchall man page examples section. The example uses the matchall classifier and the sample action to create packet sampling on a port. Reviewed-by: Jiri Pirko <j...@mellanox.com> Signed-off-by: Yotam Gigi <yot...@mellanox.com> --- man/man8

[PATCH iproute2/net-next 1/3] tc: Add support for the sample tc action

t;j...@mellanox.com> Signed-off-by: Yotam Gigi <yot...@mellanox.com> --- bash-completion/tc | 8 +- include/linux/tc_act/tc_sample.h | 26 ++ tc/Makefile | 1 + tc/m_sample.c| 186 +++ 4 files changed, 22

[PATCH iproute2/net-next 2/3] tc: man: Add man entry for the tc-sample action

In addition to general information about the tc action, the man entry contains common usage examples and information about the tlv fields packed within each sampled packet. Reviewed-by: Jiri Pirko <j...@mellanox.com> Signed-off-by: Yotam Gigi <yot...@mellanox.com> --- man/man8/Makef

RE: [PATCH net-next 0/2] Extract IFE logic to module

>-Original Message- >From: Simon Horman [mailto:simon.hor...@netronome.com] >Sent: Thursday, February 02, 2017 12:17 PM >To: Yotam Gigi <yot...@mellanox.com> >Cc: j...@mojatatu.com; da...@davemloft.net; netdev@vger.kernel.org; Jiri Pirko ><j...@mellanox.com>

RE: linux-next: manual merge of the net-next tree with Linus' tree

...@vger.kernel.org; linux-ker...@vger.kernel.org; Yotam Gigi ><yot...@mellanox.com> >Subject: linux-next: manual merge of the net-next tree with Linus' tree > >Hi all, > >Today's linux-next merge of the net-next tree got a conflict in: > > net/sched/cls_matchall.c >

[PATCH 2/3] net: Introduce ife encapsulation module

header space. - ife_tlv_meta_decode - decodes one tlv entry from the packet - ife_tlv_meta_next - advance to the next tlv Reviewed-by: Jiri Pirko <j...@mellanox.com> Signed-off-by: Yotam Gigi <yot...@mellanox.com> --- MAINTAINERS | 7 +++ include/net/ife.h

[PATCH 1/3] net/sched: act_ife: Unexport ife_tlv_meta_encode

As the function ife_tlv_meta_encode is not used by any other module, unexport it and make it static for the act_ife module. Signed-off-by: Yotam Gigi <yot...@mellanox.com> --- include/net/tc_act/tc_ife.h | 2 -- net/sched/act_ife.c | 4 ++-- 2 files changed, 2 insertions(+), 4 del

[PATCH v2 net-next 0/3] Extract IFE logic to module

hus the symbol does not collide. Yotam Gigi (3): net/sched: act_ife: Unexport ife_tlv_meta_encode net: Introduce ife encapsulation module net/sched: act_ife: Change to use ife module MAINTAINERS| 7 ++ include/net/ife.h | 51 + include/

[PATCH 3/3] net/sched: act_ife: Change to use ife module

Use the encode/decode functionality from the ife module instead of using implementation inside the act_ife. Reviewed-by: Jiri Pirko <j...@mellanox.com> Signed-off-by: Yotam Gigi <yot...@mellanox.com> --- include/net/tc_act/tc_ife.h| 1 - include/uapi/linux/tc_act/tc

RE: [PATCH net-next 1/2] net: Introduce ife encapsulation module

>-Original Message- >From: kbuild test robot [mailto:l...@intel.com] >Sent: Wednesday, February 01, 2017 1:58 AM >To: Yotam Gigi <yot...@mellanox.com> >Cc: kbuild-...@01.org; j...@mojatatu.com; da...@davemloft.net; >netdev@vger.kernel.org; Jiri Pirko <j...@m

[PATCH net-next 0/2] Extract IFE logic to module

Extract ife logic from the tc_ife action into an independent module, and make the tc_ife action use it. This way, the ife encapsulation can be used by other modules other than tc_ife action. Yotam Gigi (2): net: Introduce ife encapsulation module net/sched: act_ife: Change to use ife module

[PATCH net-next 2/2] net/sched: act_ife: Change to use ife module

Use the encode/decode functionality from the ife module instead of using implementation inside the act_ife. Reviewed-by: Jiri Pirko <j...@mellanox.com> Signed-off-by: Yotam Gigi <yot...@mellanox.com> --- include/net/tc_act/tc_ife.h| 3 - include/uapi/linux/tc_act/tc

[PATCH net-next 1/2] net: Introduce ife encapsulation module

header space. - ife_tlv_meta_decode - decodes one tlv entry from the packet - ife_tlv_meta_next - advance to the next tlv Reviewed-by: Jiri Pirko <j...@mellanox.com> Signed-off-by: Yotam Gigi <yot...@mellanox.com> --- MAINTAINERS | 7 +++ include/net/ife.h

[PATCH net v2] net/sched: matchall: Fix configuration race

in cls_cgroup. Fixes: bf3994d2ed31 ("net/sched: introduce Match-all classifier") Reported-by: Daniel Borkmann <dan...@iogearbox.net> Signed-off-by: Yotam Gigi <yot...@mellanox.com> Acked-by: Jiri Pirko <j...@mellanox.com> --- v1->v2: - Rebased on net When net is m

[PATCH iproute] tc: man: matchall: Fix example indentation

The man page contains two examples, which have different indentation. Fix the indentation of the two examples to match. Reviewed-by: Jiri Pirko <j...@mellanox.com> Signed-off-by: Yotam Gigi <yot...@mellanox.com> --- man/man8/tc-matchall.8 | 1 + 1 file changed, 1 insertion(+) diff

[PATCH net-next 1/2] net/sched: act_sample: Fix error path in init

Fix error path of in sample init, by releasing the tc hash in case of failure in psample_group creation. Fixes: 5c5670fae430 ("net/sched: Introduce sample tc action") Reported-by: Cong Wang <xiyou.wangc...@gmail.com> Reviewed-by: Jiri Pirko <j...@mellanox.com> Signed-o

[PATCH net-next 0/2] net/sched: act_sample: Little fixes

Little fixes in sample tc action. Yotam Gigi (2): net/sched: act_sample: Fix error path in init net/sched: act_psample: Remove unnecessary ASSERT_RTNL net/sched/act_sample.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) -- 2.4.11

[PATCH net-next 2/2] net/sched: act_psample: Remove unnecessary ASSERT_RTNL

The ASSERT_RTNL is not necessary in the init function, as it does not touch any rtnl protected structures, as opposed to the mirred action which does have to hold a net device. Reported-by: Cong Wang <xiyou.wangc...@gmail.com> Reviewed-by: Jiri Pirko <j...@mellanox.com> Signed-off-by

RE: [patch net-next v2 2/4] net/sched: Introduce sample tc action

>-Original Message- >From: Yotam Gigi >Sent: Friday, January 27, 2017 8:09 AM >To: 'Cong Wang' <xiyou.wangc...@gmail.com>; Jiri Pirko <j...@resnulli.us> >Cc: Linux Kernel Network Developers <netdev@vger.kernel.org>; David Miller ><da...@davemloft.

RE: [patch net-next v2 2/4] net/sched: Introduce sample tc action

>-Original Message- >From: Cong Wang [mailto:xiyou.wangc...@gmail.com] >Sent: Thursday, January 26, 2017 1:30 AM >To: Jiri Pirko <j...@resnulli.us> >Cc: Linux Kernel Network Developers <netdev@vger.kernel.org>; David Miller ><da...@davemloft.net>; Y

RE: [patch net-next v2 2/4] net/sched: Introduce sample tc action

>-Original Message- >From: Simon Horman [mailto:simon.hor...@netronome.com] >Sent: Tuesday, January 24, 2017 10:33 AM >To: Jiri Pirko <j...@resnulli.us> >Cc: netdev@vger.kernel.org; da...@davemloft.net; Yotam Gigi ><yot...@mellanox.com>; Ido Schimmel <id

[PATCH net] net/sched: matchall: Fix configuration race

in cls_cgroup. Fixes: bf3994d2ed31 ("net/sched: introduce Match-all classifier") Signed-off-by: Yotam Gigi <yot...@mellanox.com> Acked-by: Jiri Pirko <j...@mellanox.com> --- net/sched/cls_matchall.c | 129 +-- 1 file changed, 46 inser

RE: [patch net-next 2/4] net/sched: Introduce sample tc action

>-Original Message- >From: Jamal Hadi Salim [mailto:j...@mojatatu.com] >Sent: Sunday, January 22, 2017 3:17 PM >To: Jiri Pirko <j...@resnulli.us>; netdev@vger.kernel.org >Cc: da...@davemloft.net; Yotam Gigi <yot...@mellanox.com>; Ido Schimmel ><i

RE: [patch net-next v2 5/8] Introduce sample tc action

>-Original Message- >From: Simon Horman [mailto:simon.hor...@netronome.com] >Sent: Wednesday, January 04, 2017 12:43 PM >To: Yotam Gigi <yot...@mellanox.com> >Cc: Roopa Prabhu <ro...@cumulusnetworks.com>; Jiri Pirko <j...@resnulli.us>; >netdev@vger.

[PATCH net-next v2] net/sched: cls_matchall: Fix error path

Fix several error paths in matchall: - Release reference to actions in case the hardware fails offloading (relevant to skip_sw only) - Fix error path in case tcf_exts initialization/validation fail Fixes: bf3994d2ed31 ("net/sched: introduce Match-all classifier") Signed-off-by:

RE: [PATCH net-next] net/sched: cls_matchall: Fix error path

>-Original Message- >From: David Miller [mailto:da...@davemloft.net] >Sent: Tuesday, January 03, 2017 6:08 PM >To: Yotam Gigi <yot...@mellanox.com> >Cc: j...@mojatatu.com; Elad Raz <el...@mellanox.com>; Jiri Pirko ><j...@mellanox.com>; netdev@vger.kern

[PATCH net-next] net/sched: cls_matchall: Fix error path

Fix several error paths in matchall: - Release reference to actions in case the hardware fails offloading (relevant to skip_sw only) - Fix error path in case tcf_exts initialization fails Fixes: bf3994d2ed31 ("net/sched: introduce Match-all classifier") Signed-off-by: Yotam

RE: [patch net-next v2 5/8] Introduce sample tc action

>-Original Message- >From: Roopa Prabhu [mailto:ro...@cumulusnetworks.com] >Sent: Wednesday, November 16, 2016 6:15 PM >To: Jiri Pirko <j...@resnulli.us> >Cc: netdev@vger.kernel.org; da...@davemloft.net; Yotam Gigi ><yot...@mellanox.com>; Ido Schimmel <id

RE: [patch net-next 5/8] Introduce sample tc action

>-Original Message- >From: Simon Horman [mailto:simon.hor...@netronome.com] >Sent: Friday, November 11, 2016 2:44 PM >To: Yotam Gigi <yot...@mellanox.com> >Cc: John Fastabend <john.fastab...@gmail.com>; Jiri Pirko <j...@resnulli.us>; >netdev@vger.

RE: [patch net-next 5/8] Introduce sample tc action

>-Original Message- >From: Yotam Gigi >Sent: Thursday, November 10, 2016 9:59 PM >To: 'John Fastabend' <john.fastab...@gmail.com>; Jiri Pirko <j...@resnulli.us>; >netdev@vger.kernel.org >Cc: da...@davemloft.net; Ido Schimmel <ido...@mellanox.com>; E

RE: [patch net-next 5/8] Introduce sample tc action

>-Original Message- >From: John Fastabend [mailto:john.fastab...@gmail.com] >Sent: Thursday, November 10, 2016 9:38 PM >To: Jiri Pirko <j...@resnulli.us>; netdev@vger.kernel.org >Cc: da...@davemloft.net; Yotam Gigi <yot...@mellanox.com>; Ido Schimmel ><i

RE: [patch net-next 1/8] Introduce ife encapsulation module

>-Original Message- >From: David Miller [mailto:da...@davemloft.net] >Sent: Thursday, November 10, 2016 9:18 PM >To: j...@resnulli.us >Cc: netdev@vger.kernel.org; Yotam Gigi <yot...@mellanox.com>; Ido Schimmel ><ido...@mellanox.com>; Elad Raz <el...@m

[PATCH net-next] tc_act: Remove tcf_act macro

tc_act macro addressed a non existing field, and was not used in the kernel source. Signed-off-by: Yotam Gigi <yot...@mellanox.com> Reviewed-by: Jiri Pirko <j...@mellanox.com> --- include/net/act_api.h | 1 - 1 file changed, 1 deletion(-) diff --git a/include/net/act_api.h b

RE: nfs NULL-dereferencing in net-next

>-Original Message- >From: Anna Schumaker [mailto:anna.schuma...@netapp.com] >Sent: Wednesday, October 26, 2016 9:17 PM >To: Jakub Kicinski <kubak...@wp.pl> >Cc: Yotam Gigi <yot...@mellanox.com>; Andy Adamson <and...@netapp.com>; >linux-...@vger.kerne

RE: nfs NULL-dereferencing in net-next

>-Original Message- >From: netdev-ow...@vger.kernel.org [mailto:netdev-ow...@vger.kernel.org] On >Behalf Of Jakub Kicinski >Sent: Monday, October 17, 2016 10:20 PM >To: Andy Adamson ; Anna Schumaker >; linux-...@vger.kernel.org >Cc:

RE: [patch net-next RFC 4/6] Introduce sample tc action

>-Original Message- >From: Roopa Prabhu [mailto:ro...@cumulusnetworks.com] >Sent: Wednesday, October 19, 2016 10:33 AM >To: Yotam Gigi <yot...@mellanox.com> >Cc: Jamal Hadi Salim <j...@mojatatu.com>; Jiri Pirko <j...@resnulli.us>; >netdev@vger.

RE: [patch net-next RFC 4/6] Introduce sample tc action

>-Original Message- >From: Or Gerlitz [mailto:gerlitz...@gmail.com] >Sent: Sunday, October 16, 2016 1:27 PM >To: Jiri Pirko <j...@resnulli.us> >Cc: Linux Netdev List <netdev@vger.kernel.org>; David Miller ><da...@davemloft.net>; Yotam Gigi <y

RE: [patch net-next RFC 4/6] Introduce sample tc action

>-Original Message- >From: Roopa Prabhu [mailto:ro...@cumulusnetworks.com] >Sent: Tuesday, October 18, 2016 3:17 AM >To: Jamal Hadi Salim <j...@mojatatu.com> >Cc: Jiri Pirko <j...@resnulli.us>; netdev@vger.kernel.org; da...@davemloft.net; >Yotam Gigi <y

[PATCH net v3 2/2] act_ife: Fix false encoding

parsing loop. This fix changes the loop counter to be signed and fixes the encoding to take into account the tlv type and size. Fixes: 28a10c426e81 ("net sched: fix encoding to use real length") Acked-by: Jamal Hadi Salim <j...@mojatatu.com> Signed-off-by: Yotam Gigi <yot...@me

[PATCH net v3 1/2] act_ife: Fix external mac header on encode

in the external mac header once the values were not set by user. This fix takes the internal mac header from the packet, after the call to skb_cow_head. Fixes: ef6980b6becb ("net sched: introduce IFE action") Acked-by: Jamal Hadi Salim <j...@mojatatu.com> Signed-off-by: Yotam Gigi <

[PATCH net v3 0/2] Fix tc-ife bugs

This patch-set contains two bugfixes in the tc-ife action, one fixing some random behaviour in encode side, and one fixing the decode side packet parsing logic. v2->v3 - Fix the encode side instead of the decode side Yotam Gigi (2): act_ife: Fix external mac header on encode act_ife:

RE: [PATCH net v2 0/2] Fix tc-ife bugs

>-Original Message- >From: Jamal Hadi Salim [mailto:j...@mojatatu.com] >Sent: Monday, September 26, 2016 3:47 AM >To: Yotam Gigi <yot...@mellanox.com>; Yotam Gigi <yotam...@gmail.com>; >da...@davemloft.net; netdev@vger.kernel.org >Cc: Jiri Pirko <

RE: [PATCH net v2 0/2] Fix tc-ife bugs

>-Original Message- >From: Jamal Hadi Salim [mailto:j...@mojatatu.com] >Sent: Sunday, September 25, 2016 4:46 PM >To: Yotam Gigi <yotam...@gmail.com>; da...@davemloft.net; >netdev@vger.kernel.org; Yotam Gigi <yot...@mellanox.com> >Subject: Re: [PATCH net v2 0/

[PATCH net v2 1/2] act_ife: Fix external mac header on encode

in the external mac header once the values were not set by user. This fix takes the internal mac header from the packet, after the call to skb_cow_head. Fixes: ef6980b6becb ("net sched: introduce IFE action") Signed-off-by: Yotam Gigi <yot...@mellanox.com> --- net/sched/act_ife.c | 3 +--

[PATCH net v2 2/2] act_ife: Fix false parsing on decode side

oduce IFE action") Signed-off-by: Yotam Gigi <yot...@mellanox.com> --- net/sched/act_ife.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/net/sched/act_ife.c b/net/sched/act_ife.c index b949d97..1a055ea 100644 --- a/net/sched/act_ife.c +++ b/net/sched/act_ife.c

  1   2   >