Re: [PATCH V2 net-next 5/7] rds: zerocopy Tx support.

2018-02-14 Thread Willem de Bruijn
On Wed, Feb 14, 2018 at 7:09 PM, Sowmini Varadhan wrote: > On (02/14/18 18:48), Willem de Bruijn wrote: >> >> If the missing break is intentional, no need to respin just for the other >> minor comments. > > yes the missing break is intentional- the function returns the > size of the scatterlist n

Re: [PATCH V2 net-next 5/7] rds: zerocopy Tx support.

2018-02-14 Thread Sowmini Varadhan
On (02/14/18 18:48), Willem de Bruijn wrote: > > If the missing break is intentional, no need to respin just for the other > minor comments. yes the missing break is intentional- the function returns the size of the scatterlist needed for RDMA, and RDS_CMSG_ZCOPY_COOKIE (like RDMA_DEST and RDMA_

Re: [PATCH V2 net-next 5/7] rds: zerocopy Tx support.

2018-02-14 Thread Willem de Bruijn
On Wed, Feb 14, 2018 at 5:28 AM, Sowmini Varadhan wrote: > If the MSG_ZEROCOPY flag is specified with rds_sendmsg(), and, > if the SO_ZEROCOPY socket option has been set on the PF_RDS socket, > application pages sent down with rds_sendmsg() are pinned. > > The pinning uses the accounting infrastru

Re: [PATCH V2 net-next 5/7] rds: zerocopy Tx support.

2018-02-14 Thread Santosh Shilimkar
On 2/14/2018 11:49 AM, Sowmini Varadhan wrote: On (02/14/18 11:10), Santosh Shilimkar wrote: s/RDS_CMSG_ZCOPY_COOKIE/RDS_CMSG_ZMSGCOPY_COOKIE Please see https://www.spinics.net/lists/netdev/msg483627.html Just saw it and responded to Dave. @@ -356,6 +358,53 @@ int rds_message_cop

Re: [PATCH V2 net-next 5/7] rds: zerocopy Tx support.

2018-02-14 Thread Sowmini Varadhan
On (02/14/18 11:10), Santosh Shilimkar wrote: > s/RDS_CMSG_ZCOPY_COOKIE/RDS_CMSG_ZMSGCOPY_COOKIE > Please see https://www.spinics.net/lists/netdev/msg483627.html > >@@ -356,6 +358,53 @@ int rds_message_copy_from_user(struct rds_message *rm, > >struct iov_iter *from) > > sg = rm->data.

Re: [PATCH V2 net-next 5/7] rds: zerocopy Tx support.

2018-02-14 Thread Santosh Shilimkar
On 2/14/2018 2:28 AM, Sowmini Varadhan wrote: If the MSG_ZEROCOPY flag is specified with rds_sendmsg(), and, if the SO_ZEROCOPY socket option has been set on the PF_RDS socket, application pages sent down with rds_sendmsg() are pinned. The pinning uses the accounting infrastructure added by Comm

[PATCH V2 net-next 5/7] rds: zerocopy Tx support.

2018-02-14 Thread Sowmini Varadhan
If the MSG_ZEROCOPY flag is specified with rds_sendmsg(), and, if the SO_ZEROCOPY socket option has been set on the PF_RDS socket, application pages sent down with rds_sendmsg() are pinned. The pinning uses the accounting infrastructure added by Commit a91dbff551a6 ("sock: ulimit on MSG_ZEROCOPY p