On Thu, May 24, 2018 at 10:45 PM, Fu, Qiaobin wrote:
> The new action inheritdsfield copies the field DS of
> IPv4 and IPv6 packets into skb->priority. This enables
> later classification of packets based on the DS field.
Please move it to skbedit.
On Fri, May 25, 2018 at 05:45:03AM +, Fu, Qiaobin wrote:
> Hi Marcelo,
>
> Thanks for pointing out these style issues. Below is the updated version:
Hi Qiaobin,
Looks good to me. Now you have to submit it like you submitted the
original patch, but add the version tag to the summary. Like
Hi Marcelo,
Thanks for pointing out these style issues. Below is the updated version:
---
The new action inheritdsfield copies the field DS of
IPv4 and IPv6 packets into skb->priority. This enables
later classification of packets based on the DS field.
Original idea by Jamal Hadi Salim
On 23/05/18 07:01 PM, Cong Wang wrote:
On Thu, May 17, 2018 at 12:33 PM, Fu, Qiaobin wrote:
Hmm, but skbedit seems better than skbmod for this job,
given:
1) It already modifies skb->priority, although with a given value
2) skbmod doesn't change skb metadata, it only
On Thu, May 17, 2018 at 12:33 PM, Fu, Qiaobin wrote:
> net/sched: add action inheritdsfield to skbmod
>
> The new action inheritdsfield copies the field DS of
> IPv4 and IPv6 packets into skb->prioriry. This enables
> later classification of packets based on the DS field.
>
>
Hi,
Some style fixes:
On Thu, May 17, 2018 at 07:33:08PM +, Fu, Qiaobin wrote:
> net/sched: add action inheritdsfield to skbmod
This extra line above should not be here.
>
> The new action inheritdsfield copies the field DS of
> IPv4 and IPv6 packets into skb->prioriry. This enables
On 21/05/18 10:42 AM, Fu, Qiaobin wrote:
Hi Jamal,
I've tested my patch before publishing it here, and Nishanth is going to test it
further with version 2 of the GKprio. I'm going to push a patch to the repository
iproute2 to add support for "inheritdsfield”.
Thanks. I already acked the
On 17/05/18 03:33 PM, Fu, Qiaobin wrote:
net/sched: add action inheritdsfield to skbmod
The new action inheritdsfield copies the field DS of
IPv4 and IPv6 packets into skb->prioriry. This enables
later classification of packets based on the DS field.
Original idea by Jamal Hadi Salim
net/sched: add action inheritdsfield to skbmod
The new action inheritdsfield copies the field DS of
IPv4 and IPv6 packets into skb->prioriry. This enables
later classification of packets based on the DS field.
Original idea by Jamal Hadi Salim
Signed-off-by: Qiaobin Fu