Re: [PATCH net-next 2/2] udp: implement and use per cpu rx skbs cache

2018-04-23 Thread Jesper Dangaard Brouer
On Sun, 22 Apr 2018 13:22:58 +0200 Paolo Abeni wrote: > On Fri, 2018-04-20 at 15:48 +0200, Jesper Dangaard Brouer wrote: > > On Thu, 19 Apr 2018 06:47:10 -0700 Eric Dumazet > > wrote: > > > On 04/19/2018 12:40 AM, Paolo Abeni wrote: > > > > On

Re: [PATCH net-next 2/2] udp: implement and use per cpu rx skbs cache

2018-04-23 Thread Tariq Toukan
On 20/04/2018 4:48 PM, Jesper Dangaard Brouer wrote: On Thu, 19 Apr 2018 06:47:10 -0700 Eric Dumazet wrote: On 04/19/2018 12:40 AM, Paolo Abeni wrote: On Wed, 2018-04-18 at 12:21 -0700, Eric Dumazet wrote: On 04/18/2018 10:15 AM, Paolo Abeni wrote: [...] Any

Re: [PATCH net-next 2/2] udp: implement and use per cpu rx skbs cache

2018-04-22 Thread Paolo Abeni
On Fri, 2018-04-20 at 15:48 +0200, Jesper Dangaard Brouer wrote: > On Thu, 19 Apr 2018 06:47:10 -0700 Eric Dumazet > wrote: > > On 04/19/2018 12:40 AM, Paolo Abeni wrote: > > > On Wed, 2018-04-18 at 12:21 -0700, Eric Dumazet wrote: > > > > On 04/18/2018 10:15 AM, Paolo

Re: [PATCH net-next 2/2] udp: implement and use per cpu rx skbs cache

2018-04-21 Thread Eric Dumazet
On 04/21/2018 08:54 AM, Willem de Bruijn wrote: > On Fri, Apr 20, 2018 at 9:48 AM, Jesper Dangaard Brouer > wrote: >> >> On Thu, 19 Apr 2018 06:47:10 -0700 Eric Dumazet >> wrote: >>> On 04/19/2018 12:40 AM, Paolo Abeni wrote: On Wed, 2018-04-18

Re: [PATCH net-next 2/2] udp: implement and use per cpu rx skbs cache

2018-04-21 Thread Willem de Bruijn
On Fri, Apr 20, 2018 at 9:48 AM, Jesper Dangaard Brouer wrote: > > On Thu, 19 Apr 2018 06:47:10 -0700 Eric Dumazet > wrote: >> On 04/19/2018 12:40 AM, Paolo Abeni wrote: >> > On Wed, 2018-04-18 at 12:21 -0700, Eric Dumazet wrote: >> >> On 04/18/2018

Re: [PATCH net-next 2/2] udp: implement and use per cpu rx skbs cache

2018-04-20 Thread Jesper Dangaard Brouer
On Thu, 19 Apr 2018 06:47:10 -0700 Eric Dumazet wrote: > On 04/19/2018 12:40 AM, Paolo Abeni wrote: > > On Wed, 2018-04-18 at 12:21 -0700, Eric Dumazet wrote: > >> On 04/18/2018 10:15 AM, Paolo Abeni wrote: [...] > > > > Any suggestions for better results are more than

Re: [PATCH net-next 2/2] udp: implement and use per cpu rx skbs cache

2018-04-19 Thread Eric Dumazet
On 04/19/2018 12:40 AM, Paolo Abeni wrote: > Hi, > > On Wed, 2018-04-18 at 12:21 -0700, Eric Dumazet wrote: >> >> On 04/18/2018 10:15 AM, Paolo Abeni wrote: >> is not appealing to me :/ >>> >>> Thank you for the feedback. >>> Sorry for not being clear about it, but knotd is using SO_REUSEPORT

Re: [PATCH net-next 2/2] udp: implement and use per cpu rx skbs cache

2018-04-19 Thread Paolo Abeni
Hi, On Wed, 2018-04-18 at 12:21 -0700, Eric Dumazet wrote: > > On 04/18/2018 10:15 AM, Paolo Abeni wrote: > is not appealing to me :/ > > > > Thank you for the feedback. > > Sorry for not being clear about it, but knotd is using SO_REUSEPORT and > > the above tests are leveraging it. > > > >

Re: [PATCH net-next 2/2] udp: implement and use per cpu rx skbs cache

2018-04-18 Thread Eric Dumazet
On 04/18/2018 10:15 AM, Paolo Abeni wrote: is not appealing to me :/ > > Thank you for the feedback. > Sorry for not being clear about it, but knotd is using SO_REUSEPORT and > the above tests are leveraging it. > > That 5% is on top of that 300%. Then there is something wrong. Adding copies

Re: [PATCH net-next 2/2] udp: implement and use per cpu rx skbs cache

2018-04-18 Thread Paolo Abeni
Hi, On Wed, 2018-04-18 at 09:56 -0700, Eric Dumazet wrote: > > On 04/18/2018 03:22 AM, Paolo Abeni wrote: > > This changeset extends the idea behind commit c8c8b127091b ("udp: > > under rx pressure, try to condense skbs"), trading more BH cpu > > time and memory bandwidth to decrease the load on

Re: [PATCH net-next 2/2] udp: implement and use per cpu rx skbs cache

2018-04-18 Thread Eric Dumazet
On 04/18/2018 03:22 AM, Paolo Abeni wrote: > This changeset extends the idea behind commit c8c8b127091b ("udp: > under rx pressure, try to condense skbs"), trading more BH cpu > time and memory bandwidth to decrease the load on the user space > receiver. > > At boot time we allocate a limited

[PATCH net-next 2/2] udp: implement and use per cpu rx skbs cache

2018-04-18 Thread Paolo Abeni
This changeset extends the idea behind commit c8c8b127091b ("udp: under rx pressure, try to condense skbs"), trading more BH cpu time and memory bandwidth to decrease the load on the user space receiver. At boot time we allocate a limited amount of skbs with small data buffer, storing them in per