Re: [PATCH net-next v2 4/7] vxlan: improve vxlan route lookup checks.

2016-11-10 Thread Jiri Benc
On Thu, 10 Nov 2016 10:10:25 -0800, Pravin Shelar wrote: > I am specifically talking about cached routes. If the dst entry is > cached, this patch avoids checking for device loop. Okay, true, for cached routes we do less work with this patch. This was more a side note anyway, the real comment

Re: [PATCH net-next v2 4/7] vxlan: improve vxlan route lookup checks.

2016-11-10 Thread Pravin Shelar
On Thu, Nov 10, 2016 at 1:56 AM, Jiri Benc wrote: > On Wed, 9 Nov 2016 19:34:06 -0800, Pravin Shelar wrote: >> Why it would not help in non-ovs vxlan egress path? It avoids checking >> (if condition) for device loop. > > I may be missing something but I count the same number of

Re: [PATCH net-next v2 4/7] vxlan: improve vxlan route lookup checks.

2016-11-10 Thread Jiri Benc
On Wed, 9 Nov 2016 19:34:06 -0800, Pravin Shelar wrote: > Why it would not help in non-ovs vxlan egress path? It avoids checking > (if condition) for device loop. I may be missing something but I count the same number of conditions for each packet, they're just at a different place after the

Re: [PATCH net-next v2 4/7] vxlan: improve vxlan route lookup checks.

2016-11-09 Thread Pravin Shelar
On Wed, Nov 9, 2016 at 8:41 AM, Jiri Benc wrote: > On Sat, 5 Nov 2016 11:45:54 -0700, Pravin B Shelar wrote: >> Move route sanity check to respective vxlan[4/6]_get_route functions. >> This allows us to perform all sanity checks before caching the dst so >> that we can avoid

Re: [PATCH net-next v2 4/7] vxlan: improve vxlan route lookup checks.

2016-11-09 Thread Jiri Benc
On Sat, 5 Nov 2016 11:45:54 -0700, Pravin B Shelar wrote: > Move route sanity check to respective vxlan[4/6]_get_route functions. > This allows us to perform all sanity checks before caching the dst so > that we can avoid these checks on subsequent packets. > This give move accurate metadata

[PATCH net-next v2 4/7] vxlan: improve vxlan route lookup checks.

2016-11-05 Thread Pravin B Shelar
Move route sanity check to respective vxlan[4/6]_get_route functions. This allows us to perform all sanity checks before caching the dst so that we can avoid these checks on subsequent packets. This give move accurate metadata information for packet from fill_metadata_dst(). Signed-off-by: Pravin