Re: [PATCH net-next v3 0/4] net: ipv6: Improve user experience with multipath routes

2017-01-30 Thread David Ahern
On 1/30/17 4:56 PM, Stephen Hemminger wrote: >> >> As I mentioned quagga does not work with IPv6 multipath as is today. >> >> I just looked at bird. IPv6 mpath support was added in Sept. 2016. It >> specifically hard codes not accepting RTA_MULTIPATH for IPv6 which I think >> is an odd choice

Re: [PATCH net-next v3 0/4] net: ipv6: Improve user experience with multipath routes

2017-01-30 Thread Stephen Hemminger
On Mon, 30 Jan 2017 16:53:44 -0700 David Ahern wrote: > On 1/30/17 2:16 PM, Stephen Hemminger wrote: > > My fear is that routing daemons already adapt to the funny semantics of > > multi-path routing in IPv4 vs IPv6 > > and therefore any change in semantics or flags

Re: [PATCH net-next v3 0/4] net: ipv6: Improve user experience with multipath routes

2017-01-30 Thread David Ahern
On 1/30/17 2:16 PM, Stephen Hemminger wrote: > My fear is that routing daemons already adapt to the funny semantics of > multi-path routing in IPv4 vs IPv6 > and therefore any change in semantics or flags risks breaking existing user > space. That is a possibility, but so far the 2 open source

Re: [PATCH net-next v3 0/4] net: ipv6: Improve user experience with multipath routes

2017-01-30 Thread Stephen Hemminger
On Mon, 30 Jan 2017 10:45:57 -0800 Roopa Prabhu wrote: > On 1/30/17, 8:12 AM, David Ahern wrote: > > On 1/30/17 8:49 AM, Roopa Prabhu wrote: > >>> Single next hop delete will be around because IPv6 allows it -- and > >>> because IPv4 needs to support it. > >>> >

Re: [PATCH net-next v3 0/4] net: ipv6: Improve user experience with multipath routes

2017-01-30 Thread Roopa Prabhu
On 1/30/17, 8:12 AM, David Ahern wrote: > On 1/30/17 8:49 AM, Roopa Prabhu wrote: >>> Single next hop delete will be around because IPv6 allows it -- and because >>> IPv4 needs to support it. >>> >> understand single next hop delete for ipv6 will be around..and my only point >> was to leave it

Re: [PATCH net-next v3 0/4] net: ipv6: Improve user experience with multipath routes

2017-01-30 Thread Nicolas Dichtel
Le 30/01/2017 à 16:23, David Ahern a écrit : > On 1/30/17 4:07 AM, Nicolas Dichtel wrote: >> Le 29/01/2017 à 19:02, David Ahern a écrit : >> [snip] >>> Data centers are moving to L3, and multipath is a big part of that. Anyone >>> who looks at ip -6 route enough knows it gets painful mentally

Re: [PATCH net-next v3 0/4] net: ipv6: Improve user experience with multipath routes

2017-01-30 Thread Nicolas Dichtel
Le 30/01/2017 à 16:45, Roopa Prabhu a écrit : > On 1/30/17, 3:08 AM, Nicolas Dichtel wrote: >> Le 30/01/2017 à 00:55, Roopa Prabhu a écrit : >>> On 1/29/17, 10:02 AM, David Ahern wrote: On 1/28/17 6:00 PM, Roopa Prabhu wrote: >> 4. Route Appends >>- IPv6 allows nexthops to be

Re: [PATCH net-next v3 0/4] net: ipv6: Improve user experience with multipath routes

2017-01-30 Thread David Ahern
On 1/30/17 8:49 AM, Roopa Prabhu wrote: >> Single next hop delete will be around because IPv6 allows it -- and because >> IPv4 needs to support it. >> > understand single next hop delete for ipv6 will be around..and my only point > was to leave it around but not optimize for that case. > I don't

Re: [PATCH net-next v3 0/4] net: ipv6: Improve user experience with multipath routes

2017-01-30 Thread David Ahern
On 1/30/17 4:13 AM, Nicolas Dichtel wrote: > Le 30/01/2017 à 03:57, David Ahern a écrit : >> On 1/29/17 7:20 PM, Roopa Prabhu wrote: 2. Delete - 1 notification for each hop for all combinations of delete commands >>> >>> here I was trying to say, for people deleting the full multipath

Re: [PATCH net-next v3 0/4] net: ipv6: Improve user experience with multipath routes

2017-01-30 Thread Roopa Prabhu
On 1/29/17, 6:57 PM, David Ahern wrote: > On 1/29/17 7:20 PM, Roopa Prabhu wrote: >>> 2. Delete - 1 notification for each hop for all combinations of delete >>> commands >> here I was trying to say, for people deleting the full multipath route, you >> should send a RTA_MULTIPATH. > The only way

Re: [PATCH net-next v3 0/4] net: ipv6: Improve user experience with multipath routes

2017-01-30 Thread David Ahern
On 1/30/17 4:07 AM, Nicolas Dichtel wrote: > Le 29/01/2017 à 19:02, David Ahern a écrit : > [snip] >> Data centers are moving to L3, and multipath is a big part of that. Anyone >> who looks at ip -6 route enough knows it gets painful mentally pulling the >> individual routes into a single one. >

Re: [PATCH net-next v3 0/4] net: ipv6: Improve user experience with multipath routes

2017-01-30 Thread Roopa Prabhu
On 1/30/17, 3:08 AM, Nicolas Dichtel wrote: > Le 30/01/2017 à 00:55, Roopa Prabhu a écrit : >> On 1/29/17, 10:02 AM, David Ahern wrote: >>> On 1/28/17 6:00 PM, Roopa Prabhu wrote: > 4. Route Appends >- IPv6 allows nexthops to be appended to an existing route. In this > case

Re: [PATCH net-next v3 0/4] net: ipv6: Improve user experience with multipath routes

2017-01-30 Thread Nicolas Dichtel
Le 30/01/2017 à 03:57, David Ahern a écrit : > On 1/29/17 7:20 PM, Roopa Prabhu wrote: >>> 2. Delete - 1 notification for each hop for all combinations of delete >>> commands >> >> here I was trying to say, for people deleting the full multipath route, you >> should send a RTA_MULTIPATH. > >

Re: [PATCH net-next v3 0/4] net: ipv6: Improve user experience with multipath routes

2017-01-30 Thread Nicolas Dichtel
Le 30/01/2017 à 00:55, Roopa Prabhu a écrit : > On 1/29/17, 10:02 AM, David Ahern wrote: >> On 1/28/17 6:00 PM, Roopa Prabhu wrote: 4. Route Appends - IPv6 allows nexthops to be appended to an existing route. In this case one notification is sent per nexthop added >>> thanks

Re: [PATCH net-next v3 0/4] net: ipv6: Improve user experience with multipath routes

2017-01-30 Thread Nicolas Dichtel
Le 29/01/2017 à 19:02, David Ahern a écrit : [snip] > Data centers are moving to L3, and multipath is a big part of that. Anyone > who looks at ip -6 route enough knows it gets painful mentally pulling the > individual routes into a single one. I agree, but it's only an iproute2 problem.

Re: [PATCH net-next v3 0/4] net: ipv6: Improve user experience with multipath routes

2017-01-29 Thread David Ahern
On 1/29/17 7:20 PM, Roopa Prabhu wrote: >> 2. Delete - 1 notification for each hop for all combinations of delete >> commands > > here I was trying to say, for people deleting the full multipath route, you > should send a RTA_MULTIPATH. The only way to do that is to call inet6_rt_notify()

Re: [PATCH net-next v3 0/4] net: ipv6: Improve user experience with multipath routes

2017-01-29 Thread Roopa Prabhu
On 1/29/17, 5:29 PM, David Ahern wrote: [snip] > Let's give an example for each case: > > 1. Add - full multipath route > > This route command: > ip -6 ro add vrf red 2001:db8:200::/120 nexthop via 2001:db8:1::2 nexthop via > 2001:db8:2::2 > > generates this notification (ip -t mon ro): > >

Re: [PATCH net-next v3 0/4] net: ipv6: Improve user experience with multipath routes

2017-01-29 Thread David Ahern
On 1/29/17 4:55 PM, Roopa Prabhu wrote: > On 1/29/17, 10:02 AM, David Ahern wrote: >> On 1/28/17 6:00 PM, Roopa Prabhu wrote: 4. Route Appends - IPv6 allows nexthops to be appended to an existing route. In this case one notification is sent per nexthop added >>> thanks for

Re: [PATCH net-next v3 0/4] net: ipv6: Improve user experience with multipath routes

2017-01-29 Thread Roopa Prabhu
On 1/29/17, 10:02 AM, David Ahern wrote: > On 1/28/17 6:00 PM, Roopa Prabhu wrote: >>> 4. Route Appends >>>- IPv6 allows nexthops to be appended to an existing route. In this >>> case one notification is sent per nexthop added >> thanks for listing all of these...I think you mentioned

Re: [PATCH net-next v3 0/4] net: ipv6: Improve user experience with multipath routes

2017-01-29 Thread David Ahern
On 1/28/17 6:00 PM, Roopa Prabhu wrote: >> 4. Route Appends >>- IPv6 allows nexthops to be appended to an existing route. In this >> case one notification is sent per nexthop added > > thanks for listing all of these...I think you mentioned this case to me.. > but I don't remember now

Re: [PATCH net-next v3 0/4] net: ipv6: Improve user experience with multipath routes

2017-01-28 Thread Roopa Prabhu
On 1/27/17, 3:20 PM, David Ahern wrote: > This series closes a couple of gaps between IPv4 and IPv6 with respect > to multipath routes: > > 1. IPv4 allows all nexthops of multipath routes to be deleted using just >the prefix and length; IPv6 only deletes the first nexthop for the >route if

[PATCH net-next v3 0/4] net: ipv6: Improve user experience with multipath routes

2017-01-27 Thread David Ahern
This series closes a couple of gaps between IPv4 and IPv6 with respect to multipath routes: 1. IPv4 allows all nexthops of multipath routes to be deleted using just the prefix and length; IPv6 only deletes the first nexthop for the route if only the prefix and length are given. 2. IPv4