Re: [PATCH net v3] tipc: fix missing RTNL lock protection during setting link properties

2018-02-13 Thread Ying Xue
On 02/13/2018 07:03 PM, Kirill Tkhai wrote: > The patch is logically OK for me. The only thing I'm confused, > I had to split it in 7 patches to review, otherwise the patch > looks difficult to do. There is possible to extract: > > 1)Refactoring in __tipc_nl_compat_doit > 2)Introduce __tipc_nl_bea

Re: [PATCH net v3] tipc: fix missing RTNL lock protection during setting link properties

2018-02-13 Thread Kirill Tkhai
Hi, Ying, On 13.02.2018 12:04, Ying Xue wrote: > Currently when user changes link properties, TIPC first checks if > user's command message contains media name or bearer name through > tipc_media_find() or tipc_bearer_find() which is protected by RTNL > lock. But when tipc_nl_compat_link_set() con

[PATCH net v3] tipc: fix missing RTNL lock protection during setting link properties

2018-02-13 Thread Ying Xue
Currently when user changes link properties, TIPC first checks if user's command message contains media name or bearer name through tipc_media_find() or tipc_bearer_find() which is protected by RTNL lock. But when tipc_nl_compat_link_set() conducts the checking with the two functions, it doesn't ho