Re: [RFT] proxy arp deadlock possible

2007-04-05 Thread Dave Jones
On Wed, Apr 04, 2007 at 06:10:42PM -0700, Arjan van de Ven wrote: On Thu, 2007-04-05 at 10:44 +1000, Herbert Xu wrote: Stephen Hemminger [EMAIL PROTECTED] wrote: Thanks Dave, there is a classic AB BA deadlock here. We should break the dependency like this. Could someone who

Re: [RFT] proxy arp deadlock possible

2007-04-05 Thread Herbert Xu
On Wed, Apr 04, 2007 at 06:10:42PM -0700, Arjan van de Ven wrote: what's the exact lockdep output here? Here's the original report: === [ INFO: possible circular locking dependency detected ] 2.6.20-1.2933.fc6debug #1

[RFT] proxy arp deadlock possible

2007-04-04 Thread Stephen Hemminger
Thanks Dave, there is a classic AB BA deadlock here. We should break the dependency like this. Could someone who uses proxy ARP test this? - Need to drop one of the locks to avoid deadlock between proxy arp and incoming arp receive. --- net/core/neighbour.c | 10 +- 1 files

Re: [RFT] proxy arp deadlock possible

2007-04-04 Thread Herbert Xu
Stephen Hemminger [EMAIL PROTECTED] wrote: Thanks Dave, there is a classic AB BA deadlock here. We should break the dependency like this. Could someone who uses proxy ARP test this? Sorry Stephen, this isn't necessary. The lockdep thing is simply confused here. It's treating

Re: [RFT] proxy arp deadlock possible

2007-04-04 Thread Arjan van de Ven
On Thu, 2007-04-05 at 10:44 +1000, Herbert Xu wrote: Stephen Hemminger [EMAIL PROTECTED] wrote: Thanks Dave, there is a classic AB BA deadlock here. We should break the dependency like this. Could someone who uses proxy ARP test this? Sorry Stephen, this isn't necessary. The lockdep