On Friday 14 December 2007 05:30:31 Christian Borntraeger wrote:
Rusty, if you decide to apply my patch, there is one downside: The
debugging code in virtio_ring sometimes triggers with a false positive:
try_fill_recv calls vring_kick. Here we do a notify to the host. This might
cause an
Christian Borntraeger wrote:
Am Mittwoch, 12. Dezember 2007 schrieb Dor Laor:
I think the change below handles the race. Otherwise please detail the
use case.
[...]
@@ -292,6 +292,9 @@ static int virtnet_open(struct net_devic
return -ENOMEM;
Am Donnerstag, 13. Dezember 2007 schrieb Dor Laor:
You're right I got confused somehow.
So in that case setting the driver status field on open in addition to
your enable will do the trick.
On DRIVER_OPEN the host will trigger an interrupt if the queue is not
empty..
Thanks,
Dor
After
Am Mittwoch, 12. Dezember 2007 schrieb Dor Laor:
This is why initially I suggested another status code in order to split
the ring logic with driver status.
but also not filling any buffers as long as VIRTIO_CONFIG_DEV_OPEN is
not
set. I will have a look but I think that add_status needs
Am Mittwoch, 12. Dezember 2007 schrieb Rusty Russell:
On Wednesday 12 December 2007 00:16:12 Christian Borntraeger wrote:
That would also work. We already have VRING_AVAIL_F_NO_INTERRUPT in
virtio_ring.c - maybe we can use that. Its hidden in callback and
restart handling, what about adding
Christian Borntraeger wrote:
Am Mittwoch, 12. Dezember 2007 schrieb Rusty Russell:
On Wednesday 12 December 2007 00:16:12 Christian Borntraeger wrote:
That would also work. We already have VRING_AVAIL_F_NO_INTERRUPT in
virtio_ring.c - maybe we can use that. Its hidden in callback and
Am Mittwoch, 12. Dezember 2007 schrieb Dor Laor:
I think the change below handles the race. Otherwise please detail the
use case.
[...]
@@ -292,6 +292,9 @@ static int virtnet_open(struct net_devic
return -ENOMEM;
napi_enable(vi-napi);
+
+
This time I send in text so netdev list won't reject it; sorry.
Dor Laor wrote:
Christian Borntraeger wrote:
Hello Rusty,
while implementing and testing virtio on s390 I found a problem in
virtio_net: The current virtio_net driver has a startup race, which
prevents any incoming traffic:
If
2nd try. I somehow enable html on the last post
Dor Laor wrote:
Christian Borntraeger wrote:
Hello Rusty,
while implementing and testing virtio on s390 I found a problem in
virtio_net: The current virtio_net driver has a startup race, which
prevents any incoming traffic:
If try_fill_recv
Am Dienstag, 11. Dezember 2007 schrieb Christian Borntraeger:
The way other physical NICs doing it is by dis/en/abling interrupt
using registers (look at e1000).
I suggest we can export add_status and use the original code but
before enabling napi add a call to add_status(dev,
Christian Borntraeger wrote:
Am Dienstag, 11. Dezember 2007 schrieb Christian Borntraeger:
The way other physical NICs doing it is by dis/en/abling interrupt
using registers (look at e1000).
I suggest we can export add_status and use the original code but
before enabling napi add a call to
On Wednesday 12 December 2007 00:16:12 Christian Borntraeger wrote:
That would also work. We already have VRING_AVAIL_F_NO_INTERRUPT in
virtio_ring.c - maybe we can use that. Its hidden in callback and
restart handling, what about adding an explicit startup?
Yes, I debated whether to make this
12 matches
Mail list logo
