Re: [net-next PATCH v3 6/6] virtio_net: xdp, add slowpath case for non contiguous buffers

2016-11-30 Thread Michael S. Tsirkin
On Wed, Nov 30, 2016 at 08:50:41AM -0800, John Fastabend wrote: > On 16-11-30 06:30 AM, Jakub Kicinski wrote: > > [add MST] > > > > Thanks sorry MST. I did a cut'n'paste of an old list of CC's and missed > you were not on the list. > > [...] > > >> + memcpy(page_address(page) + page_off,

Re: [net-next PATCH v3 6/6] virtio_net: xdp, add slowpath case for non contiguous buffers

2016-11-30 Thread John Fastabend
On 16-11-30 06:30 AM, Jakub Kicinski wrote: > [add MST] > Thanks sorry MST. I did a cut'n'paste of an old list of CC's and missed you were not on the list. [...] >> +memcpy(page_address(page) + page_off, page_address(p) + offset, *len); >> +while (--num_buf) { >> +unsigned

Re: [net-next PATCH v3 6/6] virtio_net: xdp, add slowpath case for non contiguous buffers

2016-11-30 Thread Jakub Kicinski
[add MST] On Tue, 29 Nov 2016 12:11:33 -0800, John Fastabend wrote: > virtio_net XDP support expects receive buffers to be contiguous. > If this is not the case we enable a slowpath to allow connectivity > to continue but at a significan performance overhead associated with > linearizing data. To

Re: [net-next PATCH v3 6/6] virtio_net: xdp, add slowpath case for non contiguous buffers

2016-11-29 Thread Alexei Starovoitov
On Tue, Nov 29, 2016 at 06:50:18PM -0800, John Fastabend wrote: > On 16-11-29 04:37 PM, Alexei Starovoitov wrote: > > On Tue, Nov 29, 2016 at 12:11:33PM -0800, John Fastabend wrote: > >> virtio_net XDP support expects receive buffers to be contiguous. > >> If this is not the case we enable a

Re: [net-next PATCH v3 6/6] virtio_net: xdp, add slowpath case for non contiguous buffers

2016-11-29 Thread John Fastabend
On 16-11-29 04:37 PM, Alexei Starovoitov wrote: > On Tue, Nov 29, 2016 at 12:11:33PM -0800, John Fastabend wrote: >> virtio_net XDP support expects receive buffers to be contiguous. >> If this is not the case we enable a slowpath to allow connectivity >> to continue but at a significan performance

Re: [net-next PATCH v3 6/6] virtio_net: xdp, add slowpath case for non contiguous buffers

2016-11-29 Thread Alexei Starovoitov
On Tue, Nov 29, 2016 at 12:11:33PM -0800, John Fastabend wrote: > virtio_net XDP support expects receive buffers to be contiguous. > If this is not the case we enable a slowpath to allow connectivity > to continue but at a significan performance overhead associated with > linearizing data. To make

[net-next PATCH v3 6/6] virtio_net: xdp, add slowpath case for non contiguous buffers

2016-11-29 Thread John Fastabend
virtio_net XDP support expects receive buffers to be contiguous. If this is not the case we enable a slowpath to allow connectivity to continue but at a significan performance overhead associated with linearizing data. To make it painfully aware to users that XDP is running in a degraded mode we